cha-core 1.8.0

Core analysis engine for Cha — pluggable code smell detection
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80

mod common;

use cha_core::Plugin;
use cha_core::plugins::*;
use common::*;

#[test]
fn message_chain_triggers() {
    let mut f = func("deep", 10, 1, false);
    f.chain_depth = 4;
    let model = make_model(vec![f], vec![], vec![], 10);
    let findings = analyze(&MessageChainAnalyzer::default(), &model);
    assert_eq!(findings.len(), 1);
    assert_eq!(findings[0].smell_name, "message_chain");
}

#[test]
fn message_chain_at_threshold() {
    let mut f = func("ok", 10, 1, false);
    f.chain_depth = 3;
    let model = make_model(vec![f], vec![], vec![], 10);
    let findings = analyze(&MessageChainAnalyzer::default(), &model);
    assert!(findings.is_empty());
}

#[test]
fn message_chain_shallow() {
    let mut f = func("shallow", 10, 1, false);
    f.chain_depth = 1;
    let model = make_model(vec![f], vec![], vec![], 10);
    let findings = analyze(&MessageChainAnalyzer::default(), &model);
    assert!(findings.is_empty());
}

#[test]
fn message_chain_points_at_chain_expression() {
    use cha_core::{AnalysisContext, SourceFile};
    use std::path::PathBuf;
    let content = "\
fn deep() {
    let x = 1;
    let y = a.b.c.d.e;
}
";
    let mut f = func("deep", 4, 1, false);
    f.chain_depth = 4;
    let model = make_model(vec![f], vec![], vec![], 4);
    let file = SourceFile::new(PathBuf::from("test.rs"), content.into());
    let ctx = AnalysisContext {
        file: &file,
        model: &model,
    };
    let findings = MessageChainAnalyzer::default().analyze(&ctx);
    assert_eq!(findings.len(), 1);
    // `a.b.c.d.e` starts at column 12 on line 3
    assert_eq!(findings[0].location.start_line, 3);
    assert_eq!(findings[0].location.start_col, 12);
    // Chain is 9 chars, so end_col = 21
    assert_eq!(findings[0].location.end_col, 21);
}

#[test]
fn message_chain_falls_back_when_no_chain_text() {
    use cha_core::{AnalysisContext, SourceFile};
    use std::path::PathBuf;
    let mut f = func("synthetic", 10, 1, false);
    f.chain_depth = 5;
    f.name_col = 3;
    f.name_end_col = 12;
    let model = make_model(vec![f], vec![], vec![], 10);
    let file = SourceFile::new(PathBuf::from("test.rs"), "".into());
    let ctx = AnalysisContext {
        file: &file,
        model: &model,
    };
    let findings = MessageChainAnalyzer::default().analyze(&ctx);
    assert_eq!(findings.len(), 1);
    assert_eq!(findings[0].location.start_col, 3);
    assert_eq!(findings[0].location.end_col, 12);
}