cha-core 0.6.4

Core analysis engine for Cha — pluggable code smell detection
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69

use std::collections::HashMap;

use crate::{AnalysisContext, Finding, Location, Plugin, Severity, SmellCategory};

/// Detect functions with identical AST structure (duplicate code).
pub struct DuplicateCodeAnalyzer;

impl Plugin for DuplicateCodeAnalyzer {
    fn name(&self) -> &str {
        "duplicate_code"
    }

    fn analyze(&self, ctx: &AnalysisContext) -> Vec<Finding> {
        let hash_map = build_hash_groups(&ctx.model.functions);
        hash_map
            .values()
            .filter(|g| g.len() >= 2)
            .flat_map(|group| build_duplicate_findings(ctx, group))
            .collect()
    }
}

/// Group non-trivial functions by their body hash.
fn build_hash_groups(functions: &[crate::FunctionInfo]) -> HashMap<u64, Vec<&crate::FunctionInfo>> {
    let mut map: HashMap<u64, Vec<&crate::FunctionInfo>> = HashMap::new();
    for f in functions {
        if let Some(hash) = f.body_hash
            && f.line_count > 10
        {
            map.entry(hash).or_default().push(f);
        }
    }
    map
}

/// Build findings for a group of structurally duplicate functions.
fn build_duplicate_findings(ctx: &AnalysisContext, group: &[&crate::FunctionInfo]) -> Vec<Finding> {
    let names: Vec<&str> = group.iter().map(|f| f.name.as_str()).collect();
    group
        .iter()
        .map(|f| {
            let peers = names
                .iter()
                .filter(|n| **n != f.name)
                .copied()
                .collect::<Vec<_>>()
                .join(", ");
            Finding {
                smell_name: "duplicate_code".into(),
                category: SmellCategory::Dispensables,
                severity: Severity::Warning,
                location: Location {
                    path: ctx.file.path.clone(),
                    start_line: f.start_line,
                    end_line: f.end_line,
                    name: Some(f.name.clone()),
                },
                message: format!(
                    "Function `{}` has duplicate structure with: {}",
                    f.name, peers
                ),
                suggested_refactorings: vec![
                    "Extract Method".into(),
                    "Form Template Method".into(),
                ],
            }
        })
        .collect()
}