cha-core 0.5.2

Core analysis engine for Cha — pluggable code smell detection
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53

mod common;

use cha_core::plugins::*;
use cha_core::*;
use common::*;

fn field_class(name: &str, fields: Vec<&str>, methods: usize) -> ClassInfo {
    let mut c = class(name, methods, 30, false);
    c.field_count = fields.len();
    c.field_names = fields.into_iter().map(String::from).collect();
    c
}

fn func_with_refs(name: &str, refs: Vec<&str>) -> FunctionInfo {
    let mut f = func(name, 10, 1, false);
    f.referenced_fields = refs.into_iter().map(String::from).collect();
    f
}

#[test]
fn temporary_field_detected() {
    // field used in only 1 out of 5 methods
    let model = make_model(
        vec![
            func_with_refs("init", vec!["temp_value"]),
            func("process", 10, 1, false),
            func("validate", 10, 1, false),
            func("save", 10, 1, false),
            func("reset", 10, 1, false),
        ],
        vec![field_class("Service", vec!["temp_value", "name", "id"], 5)],
        vec![],
        50,
    );
    let findings = analyze(&TemporaryFieldAnalyzer::default(), &model);
    assert!(findings.iter().any(|f| f.smell_name == "temporary_field"));
}

#[test]
fn widely_used_field_ok() {
    let model = make_model(
        vec![
            func_with_refs("a", vec!["name"]),
            func_with_refs("b", vec!["name"]),
            func_with_refs("c", vec!["name"]),
        ],
        vec![field_class("Service", vec!["name"], 3)],
        vec![],
        30,
    );
    let findings = analyze(&TemporaryFieldAnalyzer::default(), &model);
    assert!(findings.is_empty());
}