cha-cli 1.10.0

Cha — pluggable code smell detection CLI (察)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133

use super::*;
use cha_core::{FunctionInfo, SourceModel};

fn func(name: &str, calls: Vec<&str>) -> FunctionInfo {
    FunctionInfo {
        name: name.into(),
        start_line: 1,
        end_line: 1,
        called_functions: calls.into_iter().map(String::from).collect(),
        ..Default::default()
    }
}

fn model_with(functions: Vec<FunctionInfo>) -> SourceModel {
    SourceModel {
        language: "rust".into(),
        total_lines: 10,
        functions,
        classes: vec![],
        imports: vec![],
        comments: vec![],
        type_aliases: vec![],
    }
}

#[test]
fn flags_bidirectional_calls() {
    // a.rs calls b.rs's b1 and b2; b.rs calls a.rs's a1 and a2.
    let a = model_with(vec![
        func("a1", vec![]),
        func("a2", vec![]),
        func("caller_in_a", vec!["b1", "b2"]),
    ]);
    let b = model_with(vec![
        func("b1", vec![]),
        func("b2", vec![]),
        func("caller_in_b", vec!["a1", "a2"]),
    ]);
    let idx = ProjectIndex::from_models(vec![
        (PathBuf::from("src/a.rs"), a),
        (PathBuf::from("src/b.rs"), b),
    ]);
    let findings = detect(&idx);
    assert_eq!(findings.len(), 2);
    assert!(
        findings
            .iter()
            .all(|f| f.smell_name == "circular_abstraction")
    );
}

#[test]
fn ignores_one_way_call() {
    // a calls b twice but b never calls a.
    let a = model_with(vec![
        func("a1", vec![]),
        func("caller_in_a", vec!["b1", "b2"]),
    ]);
    let b = model_with(vec![func("b1", vec![]), func("b2", vec![])]);
    let idx = ProjectIndex::from_models(vec![
        (PathBuf::from("src/a.rs"), a),
        (PathBuf::from("src/b.rs"), b),
    ]);
    let findings = detect(&idx);
    assert!(findings.is_empty());
}

#[test]
fn ignores_below_threshold() {
    // Each side only calls the other once — below MIN_CALLS_EACH_SIDE.
    let a = model_with(vec![func("a1", vec![]), func("caller_in_a", vec!["b1"])]);
    let b = model_with(vec![func("b1", vec![]), func("caller_in_b", vec!["a1"])]);
    let idx = ProjectIndex::from_models(vec![
        (PathBuf::from("src/a.rs"), a),
        (PathBuf::from("src/b.rs"), b),
    ]);
    let findings = detect(&idx);
    assert!(findings.is_empty());
}

#[test]
fn ignores_self_calls() {
    // A file calling its own functions is normal; no cycle.
    let m = model_with(vec![
        func("a1", vec![]),
        func("a2", vec!["a1"]),
        func("a3", vec!["a1", "a2"]),
    ]);
    let idx = ProjectIndex::from_models(vec![(PathBuf::from("src/a.rs"), m)]);
    let findings = detect(&idx);
    assert!(findings.is_empty());
}

#[test]
fn reports_each_pair_once_even_with_many_call_sites() {
    // a has many callers into b, b has many callers into a. Still one
    // pair (two findings, one per side).
    let a = model_with(vec![
        func("a1", vec![]),
        func("a2", vec![]),
        func("call1", vec!["b1", "b2"]),
        func("call2", vec!["b1", "b2"]),
        func("call3", vec!["b2"]),
    ]);
    let b = model_with(vec![
        func("b1", vec![]),
        func("b2", vec![]),
        func("callback1", vec!["a1", "a2"]),
        func("callback2", vec!["a1", "a2"]),
    ]);
    let idx = ProjectIndex::from_models(vec![
        (PathBuf::from("src/a.rs"), a),
        (PathBuf::from("src/b.rs"), b),
    ]);
    let findings = detect(&idx);
    assert_eq!(findings.len(), 2);
}

#[test]
fn unresolved_callees_do_not_fabricate_cycles() {
    // If neither side's calls resolve to a project file, no cycle.
    let a = model_with(vec![
        func("a1", vec![]),
        func("caller", vec!["println", "format", "to_string"]),
    ]);
    let b = model_with(vec![func("b1", vec![]), func("caller_b", vec!["println"])]);
    let idx = ProjectIndex::from_models(vec![
        (PathBuf::from("src/a.rs"), a),
        (PathBuf::from("src/b.rs"), b),
    ]);
    let findings = detect(&idx);
    assert!(findings.is_empty());
}