use crate::error::signature_error;
use crate::{DocumentId, Result};
use super::signature::{Signature, SignatureAlgorithm, SignatureVerification, SignerInfo};
pub trait Signer {
fn algorithm(&self) -> SignatureAlgorithm;
fn signer_info(&self) -> SignerInfo;
fn sign(&self, document_id: &DocumentId) -> Result<Signature>;
}
pub trait Verifier {
fn verify(
&self,
document_id: &DocumentId,
signature: &Signature,
) -> Result<SignatureVerification>;
}
#[cfg(feature = "signatures")]
pub struct EcdsaSigner {
signing_key: p256::ecdsa::SigningKey,
signer_info: SignerInfo,
}
#[cfg(feature = "signatures")]
impl EcdsaSigner {
pub fn from_pem(pem: &str, signer_info: SignerInfo) -> Result<Self> {
use p256::pkcs8::DecodePrivateKey;
let signing_key = p256::ecdsa::SigningKey::from_pkcs8_pem(pem)
.map_err(|e| signature_error(format!("Failed to parse private key PEM: {e}")))?;
Ok(Self {
signing_key,
signer_info,
})
}
pub fn generate(signer_info: SignerInfo) -> Result<(Self, String)> {
use p256::pkcs8::EncodePublicKey;
use p256::elliptic_curve::Generate;
let signing_key = p256::ecdsa::SigningKey::generate();
let verifying_key = signing_key.verifying_key();
let public_key_pem = verifying_key
.to_public_key_pem(p256::pkcs8::LineEnding::LF)
.map_err(|e| signature_error(format!("Failed to encode public key: {e}")))?;
Ok((
Self {
signing_key,
signer_info,
},
public_key_pem,
))
}
pub fn public_key_pem(&self) -> Result<String> {
use p256::pkcs8::EncodePublicKey;
self.signing_key
.verifying_key()
.to_public_key_pem(p256::pkcs8::LineEnding::LF)
.map_err(|e| signature_error(format!("Failed to encode public key: {e}")))
}
}
#[cfg(feature = "signatures")]
impl Signer for EcdsaSigner {
fn algorithm(&self) -> SignatureAlgorithm {
SignatureAlgorithm::ES256
}
fn signer_info(&self) -> SignerInfo {
self.signer_info.clone()
}
fn sign(&self, document_id: &DocumentId) -> Result<Signature> {
use base64::Engine;
use ecdsa::signature::Signer as EcdsaSignerTrait;
if document_id.is_pending() {
return Err(crate::Error::InvalidManifest {
reason: "Cannot sign a pending document ID".to_string(),
});
}
let signature: p256::ecdsa::Signature = self.signing_key.sign(document_id.digest());
let value = base64::engine::general_purpose::STANDARD.encode(signature.to_bytes());
let sig_id = format!(
"sig-{}",
&crate::Hasher::hash(crate::HashAlgorithm::Sha256, value.as_bytes()).hex_digest()[..8]
);
Ok(Signature::new(
sig_id,
SignatureAlgorithm::ES256,
self.signer_info.clone(),
value,
))
}
}
#[cfg(feature = "signatures")]
pub struct EcdsaVerifier {
verifying_key: p256::ecdsa::VerifyingKey,
}
#[cfg(feature = "signatures")]
impl EcdsaVerifier {
pub fn from_pem(pem: &str) -> Result<Self> {
use p256::pkcs8::DecodePublicKey;
let verifying_key = p256::ecdsa::VerifyingKey::from_public_key_pem(pem)
.map_err(|e| signature_error(format!("Failed to parse public key PEM: {e}")))?;
Ok(Self { verifying_key })
}
}
#[cfg(feature = "signatures")]
impl Verifier for EcdsaVerifier {
fn verify(
&self,
document_id: &DocumentId,
signature: &Signature,
) -> Result<SignatureVerification> {
use base64::Engine;
use ecdsa::signature::Verifier as EcdsaVerifierTrait;
if signature.algorithm != SignatureAlgorithm::ES256 {
return Ok(SignatureVerification::invalid(
&signature.id,
format!(
"Algorithm mismatch: expected ES256, got {}",
signature.algorithm
),
));
}
let sig_bytes = base64::engine::general_purpose::STANDARD
.decode(&signature.value)
.map_err(|e| signature_error(format!("Failed to decode signature: {e}")))?;
let ecdsa_sig = p256::ecdsa::Signature::from_slice(&sig_bytes)
.map_err(|e| signature_error(format!("Invalid signature format: {e}")))?;
match self.verifying_key.verify(document_id.digest(), &ecdsa_sig) {
Ok(()) => Ok(SignatureVerification::valid(&signature.id)),
Err(e) => Ok(SignatureVerification::invalid(
&signature.id,
format!("Signature verification failed: {e}"),
)),
}
}
}
#[cfg(all(test, feature = "signatures"))]
mod tests {
use super::*;
use crate::security::test_helpers;
fn generate_keypair() -> (EcdsaSigner, EcdsaVerifier) {
let signer_info = SignerInfo::new("Test Signer");
let (signer, public_key_pem) = EcdsaSigner::generate(signer_info).unwrap();
let verifier = EcdsaVerifier::from_pem(&public_key_pem).unwrap();
(signer, verifier)
}
#[test]
fn test_generate_and_sign() {
let signer_info = SignerInfo::new("Test Signer");
let (signer, public_key_pem) = EcdsaSigner::generate(signer_info).unwrap();
assert!(!public_key_pem.is_empty());
assert!(public_key_pem.contains("BEGIN PUBLIC KEY"));
test_helpers::assert_sign_produces_valid_signature(&signer, SignatureAlgorithm::ES256);
}
#[test]
fn test_sign_and_verify() {
let (signer, verifier) = generate_keypair();
test_helpers::assert_sign_verify_roundtrip(&signer, &verifier);
}
#[test]
fn test_verify_wrong_document() {
let (signer, verifier) = generate_keypair();
test_helpers::assert_verify_wrong_document_fails(&signer, &verifier);
}
#[test]
fn test_cannot_sign_pending_id() {
let (signer, _) = generate_keypair();
test_helpers::assert_cannot_sign_pending_id(&signer);
}
#[test]
fn test_algorithm_mismatch() {
let (signer, verifier) = generate_keypair();
test_helpers::assert_algorithm_mismatch_rejected(
&signer,
&verifier,
SignatureAlgorithm::EdDSA,
);
}
}