1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
use std::{
ffi::{OsStr, OsString},
fs::{self, File, OpenOptions},
io::{self, BufReader, Read, Seek, Write},
mem,
path::{Path, PathBuf},
sync::{Arc, Mutex},
time::{Duration, SystemTime},
};
use cargo_metadata::semver;
use flate2::read::GzDecoder;
use futures_util::future::{join_all, try_join_all};
use reqwest::Url;
use serde::{Deserialize, Serialize};
use similar::{udiff::unified_diff, Algorithm};
use tar::Archive;
use tracing::{error, info, log::warn, trace};
use crate::{
cli::FetchMode,
criteria::CriteriaMapper,
errors::{
AggregateError, BadFormatError, BadWildcardEndDateError, CacheAcquireError,
CacheCommitError, CertifyError, CommandError, CrateInfoError, CriteriaChangeError,
CriteriaChangeErrors, DiffError, DownloadError, FetchAndDiffError,
FetchAuditAggregateError, FetchAuditError, FetchError, FetchRegistryError, FlockError,
InvalidCriteriaError, JsonParseError, LoadJsonError, LoadTomlError, SourceFile,
StoreAcquireError, StoreCommitError, StoreCreateError, StoreJsonError, StoreTomlError,
StoreValidateError, StoreValidateErrors, TomlParseError, UnpackCheckoutError, UnpackError,
},
flock::{FileLock, Filesystem},
format::{
self, AuditEntry, AuditedDependencies, AuditsFile, CommandHistory, ConfigFile,
CratesAPICrate, CratesCache, CratesCacheEntry, CratesCacheUser, CratesCacheVersionDetails,
CratesPublisher, CratesPublisherSource, CratesSourceId, CratesUserId, CriteriaEntry,
CriteriaMap, CriteriaName, CriteriaStr, Delta, DiffCache, DiffStat, FastMap, FastSet,
FetchCommand, ForeignAuditsFile, ImportName, ImportsFile, MetaConfig, PackageName,
PackageStr, RegistryEntry, RegistryFile, SortedMap, StoreVersion, TrustEntry,
TrustedPackages, UnpublishedEntry, VetVersion, WildcardAudits, WildcardEntry,
SAFE_TO_DEPLOY, SAFE_TO_RUN,
},
network::Network,
out::{progress_bar, IncProgressOnDrop},
serialization::{parse_from_table, spanned::Spanned, to_formatted_toml, Tidyable},
Config, PackageExt, PartialConfig, CARGO_ENV,
};
// tmp cache for various shenanigans
const CACHE_DIFF_CACHE: &str = "diff-cache.toml";
const CACHE_COMMAND_HISTORY: &str = "command-history.json";
const CACHE_CRATES_IO_CACHE: &str = "crates-io-cache.json";
const CACHE_EMPTY_PACKAGE: &str = "empty";
const CACHE_REGISTRY_SRC: &str = "src";
const CACHE_REGISTRY_CACHE: &str = "cache";
const CACHE_VET_LOCK: &str = ".vet-lock";
// Files which are allowed to appear in the root of the cache directory, and
// will not be GC'd
const CACHE_ALLOWED_FILES: &[&str] = &[
CACHE_DIFF_CACHE,
CACHE_COMMAND_HISTORY,
CACHE_CRATES_IO_CACHE,
CACHE_EMPTY_PACKAGE,
CACHE_REGISTRY_SRC,
CACHE_REGISTRY_CACHE,
CACHE_VET_LOCK,
];
// Various cargo values
const CARGO_REGISTRY: &str = "registry";
const CARGO_REGISTRY_SRC: &str = "src";
const CARGO_REGISTRY_CRATES_IO_GIT: &str = "github.com-1ecc6299db9ec823";
const CARGO_REGISTRY_CRATES_IO_HTTP: &str = "index.crates.io-6f17d22bba15001f";
const CARGO_TOML_FILE: &str = "Cargo.toml";
const CARGO_OK_FILE: &str = ".cargo-ok";
const CARGO_OK_BODY: &str = "ok";
pub const DEFAULT_STORE: &str = "supply-chain";
const AUDITS_TOML: &str = "audits.toml";
const CONFIG_TOML: &str = "config.toml";
const IMPORTS_LOCK: &str = "imports.lock";
// Files which are skipped when counting changes for diffs.
const DIFF_SKIP_PATHS: &[&str] = &["Cargo.lock", ".cargo_vcs_info.json", ".cargo-ok"];
// FIXME: This is a completely arbitrary number, and may be too high or too low.
const MAX_CONCURRENT_DIFFS: usize = 40;
// Url of the registry.
pub const REGISTRY_URL: &str =
"https://raw.githubusercontent.com/mozilla/cargo-vet/main/registry.toml";
struct StoreLock {
config: FileLock,
}
impl StoreLock {
fn new(store: &Filesystem) -> Result<Self, FlockError> {
Ok(StoreLock {
config: store.open_rw(CONFIG_TOML, "vet store")?,
})
}
fn read_config(&self) -> io::Result<impl Read + '_> {
let mut file = self.config.file();
file.rewind()?;
Ok(file)
}
fn write_config(&self) -> io::Result<impl Write + '_> {
let mut file = self.config.file();
file.rewind()?;
file.set_len(0)?;
Ok(file)
}
fn read_audits(&self) -> io::Result<impl Read> {
File::open(self.config.parent().join(AUDITS_TOML))
}
fn write_audits(&self) -> io::Result<impl Write> {
File::create(self.config.parent().join(AUDITS_TOML))
}
fn read_imports(&self) -> io::Result<impl Read> {
File::open(self.config.parent().join(IMPORTS_LOCK))
}
fn write_imports(&self) -> io::Result<impl Write> {
File::create(self.config.parent().join(IMPORTS_LOCK))
}
}
/// The store (typically `supply-chain/`)
///
/// All access to this directory should be managed by this type to avoid races.
/// By default, modifications to this type will not be written back to the store
/// because we don't generally want to write back any results unless everything
/// goes perfectly.
///
/// To write back this value, use [`Store::commit`][].
pub struct Store {
// Exclusive file lock held for the config file
lock: Option<StoreLock>,
// Contents of the store, eagerly loaded and already validated.
pub config: ConfigFile,
pub imports: ImportsFile,
pub audits: AuditsFile,
// The complete live set of imports fetched from the network. Will be
// initialized to `None` if `--locked` was passed.
pub live_imports: Option<ImportsFile>,
pub config_src: SourceFile,
pub imports_src: SourceFile,
pub audits_src: SourceFile,
}
impl Store {
/// Create a new store (files will be completely empty, must be committed for files to be created)
pub fn create(cfg: &Config) -> Result<Self, StoreCreateError> {
let root = cfg.metacfg.store_path();
root.create_dir().map_err(StoreCreateError::CouldntCreate)?;
let lock = StoreLock::new(&root)?;
Ok(Self {
lock: Some(lock),
config: ConfigFile {
cargo_vet: Default::default(),
default_criteria: format::get_default_criteria(),
imports: SortedMap::new(),
policy: Default::default(),
exemptions: SortedMap::new(),
},
imports: ImportsFile {
unpublished: SortedMap::new(),
publisher: SortedMap::new(),
audits: SortedMap::new(),
},
audits: AuditsFile {
criteria: SortedMap::new(),
wildcard_audits: SortedMap::new(),
audits: SortedMap::new(),
trusted: SortedMap::new(),
},
live_imports: None,
config_src: SourceFile::new_empty(CONFIG_TOML),
audits_src: SourceFile::new_empty(AUDITS_TOML),
imports_src: SourceFile::new_empty(IMPORTS_LOCK),
})
}
pub fn is_init(metacfg: &MetaConfig) -> bool {
// Probably want to do more here later...
metacfg.store_path().as_path_unlocked().exists()
}
pub fn acquire_offline(cfg: &Config) -> Result<Self, StoreAcquireError> {
let root = cfg.metacfg.store_path();
// Before we do anything else, acquire an exclusive lock on the
// config.toml file in the store.
// XXX: Consider acquiring a non-exclusive lock in cases where an
// exclusive one isn't needed.
let lock = StoreLock::new(&root)?;
let (config_src, mut config): (_, ConfigFile) =
load_toml(CONFIG_TOML, lock.read_config()?)?;
// Compare the version from the store with the current StoreVersion.
// It's always an error to downgrade cargo-vet versions, but only an
// error to upgrade versions when --locked.
let current_version = StoreVersion::current();
if config.cargo_vet.version < current_version && cfg.cli.locked {
return Err(StoreAcquireError::OutdatedStore(config.cargo_vet.version));
} else if config.cargo_vet.version > current_version {
return Err(StoreAcquireError::NewerStore(config.cargo_vet.version));
}
config.cargo_vet.version = current_version;
let (audits_src, audits): (_, AuditsFile) = load_toml(AUDITS_TOML, lock.read_audits()?)?;
let (imports_src, imports): (_, ImportsFile) =
load_toml(IMPORTS_LOCK, lock.read_imports()?)?;
let store = Self {
lock: Some(lock),
config,
audits,
imports,
live_imports: None,
config_src,
audits_src,
imports_src,
};
// Check that the store isn't corrupt
store.validate(cfg.today(), cfg.cli.locked)?;
Ok(store)
}
/// Acquire an existing store
///
/// If `network` is passed and `!cfg.cli.locked`, this will fetch remote
/// imports to use for comparison purposes.
pub fn acquire(
cfg: &Config,
network: Option<&Network>,
allow_criteria_changes: bool,
) -> Result<Self, StoreAcquireError> {
let mut this = Self::acquire_offline(cfg)?;
if let Some(network) = network {
let cache = Cache::acquire(cfg).map_err(Box::new)?;
tokio::runtime::Handle::current().block_on(this.go_online(
cfg,
network,
&cache,
allow_criteria_changes,
))?;
this.validate(cfg.today(), cfg.cli.locked)?;
}
Ok(this)
}
pub async fn go_online(
&mut self,
cfg: &Config,
network: &Network,
cache: &Cache,
allow_criteria_changes: bool,
) -> Result<(), StoreAcquireError> {
if cfg.cli.locked {
return Ok(());
}
// If this command isn't locked, and the network is available, fetch the
// live state of imported audits.
let local_criteria_mapper = CriteriaMapper::new(&self.audits.criteria);
let fetched_audits =
fetch_imported_audits(network, &local_criteria_mapper, &self.config).await?;
let mut live_imports =
process_imported_audits(fetched_audits, &self.imports, allow_criteria_changes)?;
import_unpublished_entries(
&cfg.metadata,
network,
cache,
&self.config,
&self.imports,
&mut live_imports,
)
.await
.map_err(Box::new)?;
import_publisher_versions(
&cfg.metadata,
network,
cache,
&wildcard_audits_packages(&self.audits, &live_imports),
false,
&self.config,
&self.imports,
&mut live_imports,
)
.await
.map_err(Box::new)?;
self.live_imports = Some(live_imports);
Ok(())
}
/// Create a mock store
#[cfg(test)]
pub fn mock(config: ConfigFile, audits: AuditsFile, imports: ImportsFile) -> Self {
Self {
lock: None,
config,
imports,
audits,
live_imports: None,
config_src: SourceFile::new_empty(CONFIG_TOML),
audits_src: SourceFile::new_empty(AUDITS_TOML),
imports_src: SourceFile::new_empty(IMPORTS_LOCK),
}
}
/// Create a mock store, also mocking out the unlocked import fetching
/// process by providing a mocked `Network` instance.
///
/// NOTE: When validating the store, `mock_online` will use a "today" date
/// of 2023-01-01.
#[cfg(test)]
pub fn mock_online(
cfg: &Config,
config: ConfigFile,
audits: AuditsFile,
imports: ImportsFile,
network: &Network,
allow_criteria_changes: bool,
) -> Result<Self, StoreAcquireError> {
let local_criteria_mapper = CriteriaMapper::new(&audits.criteria);
let fetched_audits = tokio::runtime::Handle::current().block_on(fetch_imported_audits(
network,
&local_criteria_mapper,
&config,
))?;
let mut live_imports =
process_imported_audits(fetched_audits, &imports, allow_criteria_changes)?;
let cache = Cache::acquire(cfg).map_err(Box::new)?;
tokio::runtime::Handle::current()
.block_on(import_unpublished_entries(
&cfg.metadata,
network,
&cache,
&config,
&imports,
&mut live_imports,
))
.map_err(Box::new)?;
tokio::runtime::Handle::current()
.block_on(import_publisher_versions(
&cfg.metadata,
network,
&cache,
&wildcard_audits_packages(&audits, &live_imports),
false,
&config,
&imports,
&mut live_imports,
))
.map_err(Box::new)?;
let store = Self {
lock: None,
config,
imports,
audits,
live_imports: Some(live_imports),
config_src: SourceFile::new_empty(CONFIG_TOML),
audits_src: SourceFile::new_empty(AUDITS_TOML),
imports_src: SourceFile::new_empty(IMPORTS_LOCK),
};
let today = chrono::NaiveDate::from_ymd_opt(2023, 1, 1).unwrap();
store.validate(today, false)?;
Ok(store)
}
#[cfg(test)]
pub fn mock_acquire(
config: &str,
audits: &str,
imports: &str,
today: chrono::NaiveDate,
check_file_formatting: bool,
) -> Result<Self, StoreAcquireError> {
let (config_src, config): (_, ConfigFile) = load_toml(CONFIG_TOML, config.as_bytes())?;
let (audits_src, audits): (_, AuditsFile) = load_toml(AUDITS_TOML, audits.as_bytes())?;
let (imports_src, imports): (_, ImportsFile) = load_toml(IMPORTS_LOCK, imports.as_bytes())?;
let store = Self {
lock: None,
config,
imports,
audits,
live_imports: None,
config_src,
audits_src,
imports_src,
};
store.validate(today, check_file_formatting)?;
Ok(store)
}
/// Create a clone of the store for use to resolve `suggest`.
///
/// If `clear_exemptions` is passed, this cloned store will not contain
/// `exemptions` entries from the config, unless they're marked as `suggest
/// = false`, such that the resolver will identify these missing audits when
/// generating a report.
///
/// Unlike the primary store created with `Store::acquire` or
/// `Store::create`, this store will not hold the store lock, and cannot be
/// committed to disk by calling `commit()`.
pub fn clone_for_suggest(&self, clear_exemptions: bool) -> Self {
let mut clone = Self {
lock: None,
config: self.config.clone(),
imports: self.imports.clone(),
audits: self.audits.clone(),
live_imports: self.live_imports.clone(),
config_src: self.config_src.clone(),
audits_src: self.audits_src.clone(),
imports_src: self.imports_src.clone(),
};
if clear_exemptions {
// Delete all exemptions entries except those that are suggest=false
for versions in clone.config.exemptions.values_mut() {
versions.retain(|e| !e.suggest);
}
// If we have a live_imports, clear all stale unpublished entries so
// we suggest audits to replace them.
if let Some(live_imports) = &mut clone.live_imports {
for unpublished in live_imports.unpublished.values_mut() {
unpublished.retain(|e| e.is_fresh_import);
}
}
}
clone
}
/// Returns the set of audits which should be operated upon.
///
/// If the store was acquired unlocked, this will include audits which are
/// not stored in imports.lock, otherwise it will only contain imports
/// stored locally.
pub fn imported_audits(&self) -> &SortedMap<ImportName, AuditsFile> {
match &self.live_imports {
Some(live_imports) => &live_imports.audits,
None => &self.imports.audits,
}
}
/// Returns the set of publisher information which should be operated upon.
///
/// If the store was acquired unlocked, whis may include publisher
/// information which is not stored in imports.lock, otherwise it will only
/// contain imports stored locally.
pub fn publishers(&self) -> &SortedMap<PackageName, Vec<CratesPublisher>> {
match &self.live_imports {
Some(live_imports) => &live_imports.publisher,
None => &self.imports.publisher,
}
}
/// Returns the set of unpublished information which should be operated upon.
///
/// If the store was acquired unlocked, whis may include unpublished
/// information which is not stored in imports.lock, otherwise it will only
/// contain imports stored locally.
pub fn unpublished(&self) -> &SortedMap<PackageName, Vec<UnpublishedEntry>> {
match &self.live_imports {
Some(live_imports) => &live_imports.unpublished,
None => &self.imports.unpublished,
}
}
/// Commit the store's contents back to disk
pub fn commit(self) -> Result<(), StoreCommitError> {
// TODO: make this truly transactional?
// (With a dir rename? Does that work with the lock? Fine because it's already closed?)
if let Some(lock) = self.lock {
let mut audits = lock.write_audits()?;
let mut config = lock.write_config()?;
let mut imports = lock.write_imports()?;
let user_info = user_info_map(&self.imports);
audits.write_all(store_audits(self.audits, &user_info)?.as_bytes())?;
config.write_all(store_config(self.config)?.as_bytes())?;
imports.write_all(store_imports(self.imports, &user_info)?.as_bytes())?;
}
Ok(())
}
/// Mock `commit`. Returns the serialized value for each file in the store.
/// Doesn't take `self` by value so that it can continue to be used.
#[cfg(test)]
pub fn mock_commit(&self) -> SortedMap<String, String> {
let user_info = user_info_map(&self.imports);
[
(
AUDITS_TOML.to_owned(),
store_audits(self.audits.clone(), &user_info).unwrap(),
),
(
CONFIG_TOML.to_owned(),
store_config(self.config.clone()).unwrap(),
),
(
IMPORTS_LOCK.to_owned(),
store_imports(self.imports.clone(), &user_info).unwrap(),
),
]
.into_iter()
.collect()
}
/// Validate the store's integrity
#[allow(clippy::for_kv_map)]
pub fn validate(
&self,
today: chrono::NaiveDate,
check_file_formatting: bool,
) -> Result<(), StoreValidateErrors> {
// ERRORS: ideally these are all gathered diagnostics, want to report as many errors
// at once as possible!
let max_end_date = today + chrono::Months::new(12);
// TODO(#66): implement validation
//
// * check that policy entries are only first-party?
// * (we currently allow policy.criteria on third-parties for audit-as-crates-io)
// * check that exemptions entries are for things that exist?
// * check that lockfile and imports aren't desync'd (catch new/removed import urls)
//
// * check that each CriteriaEntry has 'description' or 'description_url'
// * check that no one is trying to shadow builtin criteria (safe-to-run, safe-to-deploy)
// * check that all 'audits' entries are well-formed
// * check that all package names are valid (with crates.io...?)
// * check that all reviews have a 'who' (currently an Option to stub it out)
// * catch no-op deltas?
// * nested check imports, complicated because of namespaces
fn check_criteria(
source_code: &SourceFile,
valid: &Arc<Vec<CriteriaName>>,
errors: &mut Vec<StoreValidateError>,
criteria: &[Spanned<CriteriaName>],
) {
for criteria in criteria {
if !valid.contains(criteria) {
errors.push(StoreValidateError::InvalidCriteria(InvalidCriteriaError {
source_code: source_code.clone(),
span: Spanned::span(criteria),
invalid: criteria.to_string(),
valid_names: valid.clone(),
}))
}
}
}
let mut errors = Vec::new();
// Fixme: this should probably be a Map...? Sorted? Stable?
let valid_criteria = Arc::new(
self.audits
.criteria
.keys()
.map(|c| &**c)
.chain([SAFE_TO_RUN, SAFE_TO_DEPLOY])
.map(|name| name.to_string())
.collect::<Vec<_>>(),
);
let no_criteria = vec![];
for (_package, entries) in &self.config.exemptions {
for entry in entries {
check_criteria(
&self.config_src,
&valid_criteria,
&mut errors,
&entry.criteria,
);
}
}
for (_name, _version, policy) in &self.config.policy {
check_criteria(
&self.config_src,
&valid_criteria,
&mut errors,
policy.criteria.as_ref().unwrap_or(&no_criteria),
);
check_criteria(
&self.config_src,
&valid_criteria,
&mut errors,
policy.dev_criteria.as_ref().unwrap_or(&no_criteria),
);
for (_dep_package, dep_criteria) in &policy.dependency_criteria {
check_criteria(&self.config_src, &valid_criteria, &mut errors, dep_criteria);
}
}
for (_new_criteria, entry) in &self.audits.criteria {
// TODO: check that new_criteria isn't shadowing a builtin criteria
check_criteria(
&self.audits_src,
&valid_criteria,
&mut errors,
&entry.implies,
);
}
for (_package, entries) in &self.audits.audits {
for entry in entries {
// TODO: check that new_criteria isn't shadowing a builtin criteria
check_criteria(
&self.audits_src,
&valid_criteria,
&mut errors,
&entry.criteria,
);
}
}
for (_package, entries) in &self.audits.wildcard_audits {
for entry in entries {
check_criteria(
&self.audits_src,
&valid_criteria,
&mut errors,
&entry.criteria,
);
if entry.end > max_end_date {
errors.push(StoreValidateError::BadWildcardEndDate(
BadWildcardEndDateError {
source_code: self.audits_src.clone(),
span: Spanned::span(&entry.end),
date: *entry.end,
max: max_end_date,
},
))
}
}
}
// If requested, verify that files in the store are correctly formatted
// and have no unrecognized fields. We don't want to be reformatting
// them or dropping unused fields while in CI, as those changes will be
// ignored.
if check_file_formatting {
let user_info = user_info_map(&self.imports);
for (name, old, new) in [
(
CONFIG_TOML,
self.config_src.source(),
store_config(self.config.clone())
.unwrap_or_else(|_| self.config_src.source().to_owned()),
),
(
AUDITS_TOML,
self.audits_src.source(),
store_audits(self.audits.clone(), &user_info)
.unwrap_or_else(|_| self.audits_src.source().to_owned()),
),
(
IMPORTS_LOCK,
self.imports_src.source(),
store_imports(self.imports.clone(), &user_info)
.unwrap_or_else(|_| self.imports_src.source().to_owned()),
),
] {
if old.trim_end() != new.trim_end() {
errors.push(StoreValidateError::BadFormat(BadFormatError {
unified_diff: unified_diff(
Algorithm::Myers,
old,
&new,
3,
Some((&format!("old/{name}"), &format!("new/{name}"))),
),
}));
}
}
}
// If we're locked, and therefore not fetching new live imports,
// validate that our imports.lock is in sync with config.toml.
if check_file_formatting && self.imports_lock_outdated() {
errors.push(StoreValidateError::ImportsLockOutdated);
};
if !errors.is_empty() {
return Err(StoreValidateErrors { errors });
}
Ok(())
}
fn imports_lock_outdated(&self) -> bool {
// If we have live imports, we're going to be updating imports.lock, so
// it's OK if it's out-of-date with regard to the config.
if self.live_imports.is_some() {
return false;
}
// We must have the exact same set of imports, otherwise an import has
// been added or removed and we're out of date.
if self.config.imports.keys().ne(self.imports.audits.keys()) {
return true;
}
for (import_name, config) in &self.config.imports {
let audits_file = self.imports.audits.get(import_name).unwrap();
// If we have any excluded crates in the imports.lock, it is out of
// date and needs to be regenerated.
for crate_name in &config.exclude {
if audits_file.audits.contains_key(crate_name) {
return true;
}
}
}
false
}
/// Called to ensure that there is publisher information in the store's live
/// imports for the given crate. This is used when adding new wildcard
/// audits from `certify`.
pub fn ensure_publisher_versions(
&mut self,
cfg: &Config,
network: Option<&Network>,
package: PackageStr<'_>,
) -> Result<&[CratesPublisher], CertifyError> {
if let (Some(network), Some(live_imports)) = (network, self.live_imports.as_mut()) {
let cache = Cache::acquire(cfg)?;
tokio::runtime::Handle::current().block_on(import_publisher_versions(
&cfg.metadata,
network,
&cache,
&[package.to_owned()].into_iter().collect(),
true,
&self.config,
&self.imports,
live_imports,
))?;
Ok(live_imports
.publisher
.get(package)
.map(|v| &v[..])
.unwrap_or(&[]))
} else {
Ok(&[])
}
}
/// Called when suggesting in order to fetch all audits from potential peers
/// in the registry, in case a registry import could solve an encountered
/// problem.
pub async fn fetch_registry_audits(
&mut self,
cfg: &Config,
network: &Network,
cache: &Cache,
) -> Result<Vec<(ImportName, RegistryEntry, AuditsFile)>, FetchRegistryError> {
let registry_file = fetch_registry(network).await?;
let registry_entries = {
let progress_bar = progress_bar(
"Fetching",
"registry audits",
registry_file.registry.len() as u64,
);
let local_criteria_mapper = CriteriaMapper::new(&self.audits.criteria);
join_all(
registry_file
.registry
.iter()
.map(|(name, entry)| (name.clone(), entry.clone()))
.map(|(name, entry)| async {
let _guard = IncProgressOnDrop(&progress_bar, 1);
let existing_entry = self.config.imports.get(&name);
fetch_imported_audit(
network,
&local_criteria_mapper,
&name,
&entry.url,
existing_entry.map(|e| &e.exclude[..]).unwrap_or(&[]),
existing_entry
.map(|e| &e.criteria_map)
.unwrap_or(&SortedMap::new()),
)
.await
.map_err(|error| {
error!("Error fetching registry audits for '{name}': {error:?}")
})
.map(|audit_file| (name, entry, audit_file))
.ok()
}),
)
.await
.into_iter()
.flatten()
.collect::<Vec<_>>()
};
// Re-run import_publisher_versions to ensure that we have all publisher
// information for any potential wildcard audit imports.
// Note: This is the only reason we need mutable access to the store.
// XXX: Consider limiting further to only packages which are currently
// failing to vet?
// XXX: Consider making this fetch async?
let wildcard_packages = registry_entries
.iter()
.flat_map(|(_, _, audits_file)| audits_file.wildcard_audits.keys())
.cloned()
.collect::<FastSet<_>>();
import_publisher_versions(
&cfg.metadata,
network,
cache,
&wildcard_packages,
false,
&self.config,
&self.imports,
self.live_imports.as_mut().unwrap(),
)
.await?;
Ok(registry_entries)
}
}
/// Process imported audits from the network, generating a `LiveImports`
/// description of the live state of imported audits.
fn process_imported_audits(
fetched_audits: Vec<(ImportName, AuditsFile)>,
imports_lock: &ImportsFile,
allow_criteria_changes: bool,
) -> Result<ImportsFile, CriteriaChangeErrors> {
let mut new_imports = ImportsFile {
unpublished: SortedMap::new(),
publisher: SortedMap::new(),
audits: SortedMap::new(),
};
let mut changed_criteria = Vec::new();
for (import_name, mut audits_file) in fetched_audits {
if let Some(existing_audits_file) = imports_lock.audits.get(&import_name) {
update_import_freshness(
&mut audits_file,
existing_audits_file,
|criteria_name, old_desc, new_desc| {
if !allow_criteria_changes {
// Compare the new criteria descriptions with existing criteria
// descriptions. If the description already exists, record a
// CriteriaChangeError.
changed_criteria.push(CriteriaChangeError {
import_name: import_name.clone(),
criteria_name: criteria_name.to_owned(),
unified_diff: unified_diff(
Algorithm::Myers,
old_desc,
new_desc,
5,
None,
),
});
}
},
);
}
// Now add the new import
new_imports.audits.insert(import_name, audits_file);
}
if !changed_criteria.is_empty() {
return Err(CriteriaChangeErrors {
errors: changed_criteria,
});
}
// FIXME: Consider doing some additional validation on these audits
// before returning?
Ok(new_imports)
}
fn update_import_freshness(
audits_file: &mut AuditsFile,
existing_audits_file: &AuditsFile,
mut on_changed_criteria_description: impl FnMut(CriteriaStr<'_>, &str, &str),
) {
// Compare the new criteria descriptions with existing criteria
// descriptions. If the description already exists, notify our caller.
for (criteria_name, old_entry) in &existing_audits_file.criteria {
if let Some(new_entry) = audits_file.criteria.get(criteria_name) {
let old_desc = old_entry.description.as_ref().unwrap();
let new_desc = new_entry.description.as_ref().unwrap();
if old_desc != new_desc {
on_changed_criteria_description(criteria_name, old_desc, new_desc);
}
}
}
// Compare the new audits with existing audits. If an audit already
// existed in the existing audits file, mark it as non-fresh.
for (package, existing_audits) in &existing_audits_file.audits {
let new_audits = audits_file
.audits
.get_mut(package)
.map(|v| &mut v[..])
.unwrap_or(&mut []);
for existing_audit in existing_audits {
for new_audit in &mut *new_audits {
if new_audit.is_fresh_import && new_audit.same_audit_as(existing_audit) {
new_audit.is_fresh_import = false;
break;
}
}
}
}
for (package, existing_audits) in &existing_audits_file.wildcard_audits {
let new_audits = audits_file
.wildcard_audits
.get_mut(package)
.map(|v| &mut v[..])
.unwrap_or(&mut []);
for existing_audit in existing_audits {
for new_audit in &mut *new_audits {
if new_audit.is_fresh_import && new_audit.same_audit_as(existing_audit) {
new_audit.is_fresh_import = false;
break;
}
}
}
}
}
/// Fetch all declared imports from the network, mapping criteria to the local
/// namespace, and filling in any criteria descriptions.
async fn fetch_imported_audits(
network: &Network,
local_criteria_mapper: &CriteriaMapper,
config: &ConfigFile,
) -> Result<Vec<(ImportName, AuditsFile)>, Box<FetchAuditError>> {
let progress_bar = progress_bar("Fetching", "imported audits", config.imports.len() as u64);
try_join_all(config.imports.iter().map(|(name, import)| async {
let _guard = IncProgressOnDrop(&progress_bar, 1);
let audit_file = fetch_imported_audit(
network,
local_criteria_mapper,
name,
&import.url,
&import.exclude,
&import.criteria_map,
)
.await
.map_err(Box::new)?;
Ok::<_, Box<FetchAuditError>>((name.clone(), audit_file))
}))
.await
}
async fn fetch_imported_audit(
network: &Network,
local_criteria_mapper: &CriteriaMapper,
name: &str,
urls: &[String],
exclude: &[PackageName],
criteria_map: &CriteriaMap,
) -> Result<AuditsFile, FetchAuditError> {
// Fetch all imported URLs, and then aggregate them.
let sources = try_join_all(urls.iter().map(|url| async {
fetch_single_imported_audit(
network,
local_criteria_mapper,
name,
url,
exclude,
criteria_map,
)
.await
.map(|audits_file| (url.clone(), audits_file))
}))
.await?;
// If we only have a single source, don't aggregate so that we don't add
// unnecessary `aggregated-from` members.
if sources.len() == 1 {
Ok(sources.into_iter().next().unwrap().1)
} else {
crate::do_aggregate_audits(sources).map_err(|error| FetchAuditError::Aggregate {
import_name: name.to_owned(),
errors: error
.errors
.into_iter()
.map(|err| match err {
AggregateError::CriteriaDescriptionMismatch(mismatch) => {
FetchAuditAggregateError {
mapped_to: criteria_map
.get(&mismatch.criteria_name)
.cloned()
.unwrap_or_default(),
criteria_name: mismatch.criteria_name,
first: mismatch.first,
second: mismatch.second,
}
}
AggregateError::ImpliesMismatch(_) => {
unreachable!("implies is stripped by fetch_single_imported_audit")
}
})
.collect(),
})
}
}
/// Fetch a single AuditsFile from the network, filling in any criteria
/// descriptions.
async fn fetch_single_imported_audit(
network: &Network,
local_criteria_mapper: &CriteriaMapper,
name: &str,
url: &str,
exclude: &[PackageName],
criteria_map: &CriteriaMap,
) -> Result<AuditsFile, FetchAuditError> {
let parsed_url = Url::parse(url).map_err(|error| FetchAuditError::InvalidUrl {
import_url: url.to_owned(),
import_name: name.to_owned(),
error,
})?;
let audit_source = network.download_source_file_cached(parsed_url).await?;
let mut audit_file = foreign_audit_source_to_local_warn(name, audit_source)?;
// Remove any excluded audits from the live copy. We'll effectively
// pretend they don't exist upstream.
for excluded in exclude {
audit_file.audits.remove(excluded);
}
// Construct a mapping from the foreign criteria namespace into the
// local criteria namespace based on the criteria map from the config.
let foreign_criteria_mapper = CriteriaMapper::new(&audit_file.criteria);
let foreign_to_local_mapping: Vec<_> = foreign_criteria_mapper
.all_criteria_names()
.map(|foreign_name| {
// NOTE: We try the map before we check for built-in criteria to
// allow overriding the default behaviour.
if let Some(mapped) = criteria_map.get(foreign_name) {
local_criteria_mapper.criteria_from_list(mapped)
} else if foreign_name == SAFE_TO_DEPLOY {
local_criteria_mapper.criteria_from_list([SAFE_TO_DEPLOY])
} else if foreign_name == SAFE_TO_RUN {
local_criteria_mapper.criteria_from_list([SAFE_TO_RUN])
} else {
local_criteria_mapper.no_criteria()
}
})
.collect();
// Helper to re-write foreign criteria into the local criteria
// namespace.
let make_criteria_local = |criteria: &mut Vec<Spanned<CriteriaName>>| {
let foreign_set = foreign_criteria_mapper.criteria_from_list(&*criteria);
let mut local_set = local_criteria_mapper.no_criteria();
for foreign_criteria_idx in foreign_set.indices() {
local_set.unioned_with(&foreign_to_local_mapping[foreign_criteria_idx]);
}
*criteria = local_criteria_mapper
.criteria_names(&local_set)
.map(|name| name.to_owned().into())
.collect();
};
// By default all audits read from the network are fresh.
//
// Note: This may leave behind useless audits which imply no criteria,
// but that's OK - we'll never choose to import them. In the future we
// might want to trim them.
for audit_entry in audit_file.audits.values_mut().flat_map(|v| v.iter_mut()) {
audit_entry.is_fresh_import = true;
make_criteria_local(&mut audit_entry.criteria);
}
for audit_entry in audit_file
.wildcard_audits
.values_mut()
.flat_map(|v| v.iter_mut())
{
audit_entry.is_fresh_import = true;
make_criteria_local(&mut audit_entry.criteria);
}
for trust_entry in audit_file.trusted.values_mut().flat_map(|v| v.iter_mut()) {
make_criteria_local(&mut trust_entry.criteria);
}
// Now that we're done with foreign criteria, trim the set to only
// contain mapped criteria, as we don't care about other criteria, so
// shouldn't bother importing them.
audit_file
.criteria
.retain(|name, _| criteria_map.contains_key(name));
// Eagerly fetch all descriptions for criteria in the imported audits file,
// and store them inline. We'll error out if any of these descriptions are
// unavailable.
try_join_all(
audit_file
.criteria
.iter_mut()
.map(|(criteria_name, criteria_entry)| async {
if criteria_entry.description.is_some() {
return Ok(());
}
let url_string = criteria_entry.description_url.as_ref().ok_or_else(|| {
FetchAuditError::MissingCriteriaDescription {
import_name: name.to_owned(),
criteria_name: criteria_name.clone(),
}
})?;
let url = Url::parse(url_string).map_err(|error| {
FetchAuditError::InvalidCriteriaDescriptionUrl {
import_name: name.to_owned(),
criteria_name: criteria_name.clone(),
url: url_string.clone(),
error,
}
})?;
let bytes = network.download(url.clone()).await?;
let description =
String::from_utf8(bytes).map_err(|error| DownloadError::InvalidText {
url: Box::new(url.clone()),
error,
})?;
criteria_entry.description = Some(description);
Ok::<(), FetchAuditError>(())
}),
)
.await?;
// Clear out the description URL and implies, as those will never be used
// locally.
for criteria_entry in audit_file.criteria.values_mut() {
criteria_entry.description_url = None;
criteria_entry.implies = Vec::new();
}
Ok(audit_file)
}
pub(crate) struct ForeignAuditFileToLocalResult {
pub audit_file: AuditsFile,
pub ignored_criteria: Vec<CriteriaName>,
pub ignored_audits: Vec<PackageName>,
}
fn is_known_criteria(valid_criteria: &[CriteriaName], criteria_name: &CriteriaName) -> bool {
criteria_name == format::SAFE_TO_RUN
|| criteria_name == format::SAFE_TO_DEPLOY
|| valid_criteria.contains(criteria_name)
}
/// Convert a foreign audits file into a local audits file, ignoring any entries
/// which could not be interpreted, due to issues such as being created with a
/// newer version of cargo-vet.
pub(crate) fn foreign_audit_file_to_local(
foreign_audit_file: ForeignAuditsFile,
) -> ForeignAuditFileToLocalResult {
let mut ignored_criteria = Vec::new();
let mut criteria: SortedMap<CriteriaName, CriteriaEntry> = foreign_audit_file
.criteria
.into_iter()
.filter_map(|(criteria, value)| match parse_imported_criteria(value) {
Some(entry) => Some((criteria, entry)),
None => {
ignored_criteria.push(criteria);
None
}
})
.collect();
let valid_criteria: Vec<CriteriaName> = criteria.keys().cloned().collect();
// Remove any unknown criteria from implies sets, to ensure we don't run
// into errors later on in the resolver.
for entry in criteria.values_mut() {
entry
.implies
.retain(|criteria_name| is_known_criteria(&valid_criteria, criteria_name));
}
let mut ignored_audits = Vec::new();
let audits: AuditedDependencies = foreign_audit_file
.audits
.into_iter()
.map(|(package, audits)| {
let parsed: Vec<_> = audits
.into_iter()
.filter_map(|value| match parse_imported_audit(&valid_criteria, value) {
Some(audit) => Some(audit),
None => {
ignored_audits.push(package.clone());
None
}
})
// Filter out non-importable audits
.filter(|value| value.importable)
.collect();
(package, parsed)
})
.filter(|(_, audits)| !audits.is_empty())
.collect();
let wildcard_audits: WildcardAudits = foreign_audit_file
.wildcard_audits
.into_iter()
.map(|(package, audits)| {
let parsed: Vec<_> = audits
.into_iter()
.filter_map(
|value| match parse_imported_wildcard_audit(&valid_criteria, value) {
Some(audit) => Some(audit),
None => {
ignored_audits.push(package.clone());
None
}
},
)
.collect();
(package, parsed)
})
.filter(|(_, audits)| !audits.is_empty())
.collect();
let trusted: TrustedPackages = foreign_audit_file
.trusted
.into_iter()
.map(|(package, trusted)| {
let parsed: Vec<_> = trusted
.into_iter()
.filter_map(|value| parse_imported_trust_entry(&valid_criteria, value))
.collect();
(package, parsed)
})
.filter(|(_, trusted)| !trusted.is_empty())
.collect();
ForeignAuditFileToLocalResult {
audit_file: AuditsFile {
criteria,
wildcard_audits,
audits,
trusted,
},
ignored_criteria,
ignored_audits,
}
}
/// Attempt to parse each criteria and audit independently, to allow
/// recovering from parsing or validation errors on a per-entry basis when
/// importing audits. This reduces the risk of an upstream vendor adopting a
/// new cargo-vet feature breaking projects still using an older version of
/// cargo-vet.
pub(crate) fn foreign_audit_source_to_local_warn(
name: &str,
audit_source: SourceFile,
) -> Result<AuditsFile, LoadTomlError> {
let foreign_audit_file: ForeignAuditsFile = toml::de::from_str(audit_source.source())
.map_err(|error| TomlParseError {
span: error.span().unwrap_or(0..0).into(),
source_code: audit_source,
error,
})
.map_err(LoadTomlError::from)?;
let ForeignAuditFileToLocalResult {
audit_file,
ignored_criteria,
ignored_audits,
} = foreign_audit_file_to_local(foreign_audit_file);
if !ignored_criteria.is_empty() {
warn!(
"Ignored {} invalid criteria entries when importing from '{}'\n\
These criteria may have been made with a more recent version of cargo-vet",
ignored_criteria.len(),
name
);
info!(
"The following criteria were ignored when importing from '{}': {:?}",
name, ignored_criteria
);
}
if !ignored_audits.is_empty() {
warn!(
"Ignored {} invalid audits when importing from '{}'\n\
These audits may have been made with a more recent version of cargo-vet",
ignored_audits.len(),
name
);
info!(
"Audits for the following packages were ignored when importing from '{}': {:?}",
name, ignored_audits
);
}
Ok(audit_file)
}
/// Parse an unparsed criteria entry, validating and returning it.
fn parse_imported_criteria(value: toml::Table) -> Option<CriteriaEntry> {
parse_from_table(value)
.map_err(|err| info!("imported criteria parsing failed due to {err}"))
.ok()
}
/// Parse an unparsed audit entry, validating and returning it.
fn parse_imported_audit(valid_criteria: &[CriteriaName], value: toml::Table) -> Option<AuditEntry> {
let mut audit: AuditEntry = parse_from_table(value)
.map_err(|err| info!("imported audit parsing failed due to {err}"))
.ok()?;
// Remove any unrecognized criteria to avoid later errors caused by being
// unable to find criteria, and ignore the entry if it names no known
// criteria.
audit.criteria.retain(|criteria_name| {
if !is_known_criteria(valid_criteria, criteria_name) {
info!("discarding unknown criteria in imported audit: {criteria_name}");
return false;
}
true
});
if audit.criteria.is_empty() {
info!("imported audit parsing failed due to no known criteria");
return None;
}
Some(audit)
}
/// Parse an unparsed wildcard audit entry, validating and returning it.
fn parse_imported_wildcard_audit(
valid_criteria: &[CriteriaName],
table: toml::Table,
) -> Option<WildcardEntry> {
let mut audit: WildcardEntry = parse_from_table(table)
.map_err(|err| info!("imported wildcard audit parsing failed due to {err}"))
.ok()?;
// Remove any unrecognized criteria to avoid later errors caused by being
// unable to find criteria, and ignore the entry if it names no known
// criteria.
audit.criteria.retain(|criteria_name| {
if !is_known_criteria(valid_criteria, criteria_name) {
info!("discarding unknown criteria in imported wildcard audit: {criteria_name}");
return false;
}
true
});
if audit.criteria.is_empty() {
info!("imported wildcard audit parsing failed due to no known criteria");
return None;
}
Some(audit)
}
/// Parse an unparsed wildcard audit entry, validating and returning it.
fn parse_imported_trust_entry(
valid_criteria: &[CriteriaName],
table: toml::Table,
) -> Option<TrustEntry> {
let mut audit: TrustEntry = parse_from_table(table)
.map_err(|err| info!("imported trust entry audit parsing failed due to {err}"))
.ok()?;
audit
.criteria
.retain(|criteria_name| is_known_criteria(valid_criteria, criteria_name));
if audit.criteria.is_empty() {
info!("imported trust entry parsing failed due to no known criteria");
return None;
}
Some(audit)
}
async fn import_unpublished_entries(
metadata: &cargo_metadata::Metadata,
network: &Network,
cache: &Cache,
config_file: &ConfigFile,
imports_lock: &ImportsFile,
live_imports: &mut ImportsFile,
) -> Result<(), CrateInfoError> {
// We always persist any unpublished entries from the imports.lock into
// live-imports, even if the version has since been published, as it may be
// necessary for `cargo vet` to pass.
live_imports.unpublished = imports_lock.unpublished.clone();
// Find all packages which are forced to be audit-as-crates-io, and check if
// they are actually published. We also skip git versions, as those can
// always be audit-as-crates-io.
let audit_as_packages = crate::first_party_packages_strict(metadata, config_file)
.filter(|package| package.is_third_party(&config_file.policy))
.filter(|package| package.git_rev().is_none());
for package in audit_as_packages {
// If we have no versions for the crate, it cannot be
// audit-as-crates-io, so treat it as an error.
// FIXME: better errors here?
let versions = cache.published_versions(network, &package.name).await?;
// Pick which verison of the crate we'd audit as. We prefer the exact
// version of the crate, followed by the largest version below, and then
// finally the smallest version above.
let max_below = versions.keys().filter(|&v| v <= &package.version).max();
let audited_as = max_below
.or_else(|| versions.keys().filter(|&v| v > &package.version).min())
.expect("There must be at least one version");
// The exact version is published, no unpublished entries are required.
if audited_as == &package.version {
continue;
}
let unpublished = live_imports
.unpublished
.entry(package.name.to_string())
.or_default();
// Mark each existing entry for this version as `still_unpublished`, as
// we now know this version is still unpublished.
for entry in &mut *unpublished {
if entry.version.equals_semver(&package.version) {
entry.still_unpublished = true;
}
}
// Push an entry for this audited_as marked as `is_fresh_import`.
//
// NOTE: We intentionally add a new entry even if there is an
// "identical" one already. This allows edge prioritization logic to
// prefer stale entries when not pruning, and fresh ones while pruning,
// to keep the unaudited delta as small as possible without unnecessary
// imports.lock churn. Only one of the two entries should ever appear in
// imports.lock.
unpublished.push(UnpublishedEntry {
version: package.vet_version(),
audited_as: VetVersion {
semver: audited_as.clone(),
git_rev: None,
},
still_unpublished: true,
is_fresh_import: true,
});
}
Ok(())
}
fn wildcard_audits_packages(
audits_file: &AuditsFile,
imports_file: &ImportsFile,
) -> FastSet<PackageName> {
// Determine which versions are relevant for the purposes of wildcard audit
// checks. We'll only care about crates which have associated wildcard
// audits or existing cached publisher info.
audits_file
.wildcard_audits
.keys()
.chain(
imports_file
.audits
.values()
.flat_map(|audits_file| audits_file.wildcard_audits.keys()),
)
.chain(imports_file.publisher.keys())
.chain(audits_file.trusted.keys())
.cloned()
.collect()
}
#[allow(clippy::too_many_arguments)]
async fn import_publisher_versions(
metadata: &cargo_metadata::Metadata,
network: &Network,
cache: &Cache,
relevant_packages: &FastSet<PackageName>,
force: bool,
config_file: &ConfigFile,
imports_lock: &ImportsFile,
live_imports: &mut ImportsFile,
) -> Result<(), CrateInfoError> {
// Determine which packages we need publisher information for. Unless
// `force` has been passed, we only care about packages which are used by
// our dependency tree.
let to_fetch: FastSet<&str> = if force {
relevant_packages
.iter()
.map(|pkg_name| &pkg_name[..])
.collect()
} else {
metadata
.packages
.iter()
.filter(|pkg| {
relevant_packages.contains(&*pkg.name) && pkg.is_third_party(&config_file.policy)
})
.map(|pkg| &pkg.name[..])
.collect()
};
// Actually fetch the crates.io information, showing a progress bar.
let relevant_publishers = {
let progress = progress_bar("Fetching", "crate publishers", to_fetch.len() as u64);
try_join_all(to_fetch.into_iter().map(|pkg_name| {
let progress = &progress;
async move {
let _inc_progress = IncProgressOnDrop(progress, 1);
cache
.crates_io_info(Some(network), pkg_name)
.await
.map(|entry| (pkg_name, entry))
}
}))
.await?
};
// NOTE: We make sure to process all imports before we look up user
// information in the cache, to ensure we're fetching consistent user
// information.
for (pkg_name, entry) in relevant_publishers {
// Fill in the live imports table with the relevant information.
let nonfresh_versions: FastSet<_> = imports_lock
.publisher
.get(pkg_name)
.into_iter()
.flatten()
.map(|publisher| &publisher.version.semver)
.collect();
live_imports.publisher.insert(
pkg_name.to_owned(),
entry
.versions
.iter()
.filter_map(|(version, details)| {
let source_id = details.source.as_ref()?;
let source = cache.publisher_id_to_source(source_id)?;
let is_fresh_import = !nonfresh_versions.contains(version);
Some(CratesPublisher {
version: VetVersion {
semver: version.clone(),
git_rev: None,
},
source,
when: details.created_at.date_naive(),
is_fresh_import,
})
})
.collect(),
);
}
Ok(())
}
pub async fn fetch_registry(network: &Network) -> Result<RegistryFile, FetchRegistryError> {
let registry_url = Url::parse(REGISTRY_URL).unwrap();
let registry_source = network.download_source_file_cached(registry_url).await?;
let registry_file: RegistryFile = toml::de::from_str(registry_source.source())
.map_err(|error| TomlParseError {
span: error.span().unwrap_or(0..0).into(),
source_code: registry_source,
error,
})
.map_err(LoadTomlError::from)?;
Ok(registry_file)
}
pub fn user_info_map(imports: &ImportsFile) -> FastMap<CratesUserId, CratesCacheUser> {
let mut user_info = FastMap::new();
for publisher in imports.publisher.values().flatten() {
if let CratesPublisherSource::User {
user_id,
user_login,
user_name,
} = &publisher.source
{
user_info
.entry(*user_id)
.or_insert_with(|| CratesCacheUser {
login: user_login.clone(),
name: user_name.clone(),
});
}
}
user_info
}
type PublishedVersions = Arc<SortedMap<semver::Version, crates_index::Version>>;
struct CacheState {
/// The loaded DiffCache, will be persisted between invocations
diff_cache: DiffCache,
/// Command history, will be persisted between invocations
command_history: CommandHistory,
/// Cache of fetched info from crates.io, will be persisted between invocations
crates_cache: CratesCache,
/// Package versions and sha256 checksums from index.crates.io
published_versions: FastMap<PackageName, Arc<tokio::sync::OnceCell<PublishedVersions>>>,
/// Used to avoid multiple requests to the crates.io API for crate metadata.
/// Results are populated into crates_cache.
crates_io_info_fetches: FastMap<PackageName, Arc<tokio::sync::OnceCell<Arc<CratesCacheEntry>>>>,
/// Paths for unpacked packages from this version.
fetched_packages: FastMap<(PackageName, VetVersion), Arc<tokio::sync::OnceCell<PathBuf>>>,
/// Computed diffstats from this version.
diffed: FastMap<(PackageName, Delta), Arc<tokio::sync::OnceCell<DiffStat>>>,
}
#[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Debug)]
pub enum FetchModeCommand {
Diff,
Inspect,
}
impl FetchModeCommand {
fn default_fetch_mode(self) -> FetchMode {
match self {
Self::Diff => FetchMode::DiffRs,
Self::Inspect => FetchMode::CratesIo,
}
}
}
/// The cache where we store globally shared artifacts like fetched packages and diffstats
///
/// All access to this directory should be managed by this type to avoid races.
pub struct Cache {
/// System-global lock over the cache, will be None if we're mocking.
_lock: Option<FileLock>,
/// Path to the root of the cache
root: Option<PathBuf>,
/// Path to the DiffCache (for when we want to save it back)
diff_cache_path: Option<PathBuf>,
/// Path to the CommandHistory (for when we want to save it back)
command_history_path: Option<PathBuf>,
/// Path to the CratesCache (for when we want to save it back)
publisher_cache_path: Option<PathBuf>,
/// Semaphore preventing exceeding the maximum number of concurrent diffs.
diff_semaphore: tokio::sync::Semaphore,
/// The time to use as `now` when considering cache expiry.
now: chrono::DateTime<chrono::Utc>,
/// Common mutable state for the cache which can be mutated concurrently
/// from multiple tasks.
state: Mutex<CacheState>,
}
impl Drop for Cache {
fn drop(&mut self) {
let state = self.state.get_mut().unwrap();
if let Some(diff_cache_path) = &self.diff_cache_path {
// Write back the diff_cache
if let Err(err) = || -> Result<(), CacheCommitError> {
let diff_cache = store_diff_cache(mem::take(&mut state.diff_cache))?;
fs::write(diff_cache_path, diff_cache)?;
Ok(())
}() {
error!("error writing back changes to diff-cache: {:?}", err);
}
}
if let Some(command_history_path) = &self.command_history_path {
// Write back the command_history
if let Err(err) = || -> Result<(), CacheCommitError> {
let command_history = store_command_history(mem::take(&mut state.command_history))?;
fs::write(command_history_path, command_history)?;
Ok(())
}() {
error!("error writing back changes to command history: {:?}", err);
}
}
if let Some(publisher_cache_path) = &self.publisher_cache_path {
// Write back the publisher_cache
if let Err(err) = || -> Result<(), CacheCommitError> {
let publisher_cache = store_publisher_cache(mem::take(&mut state.crates_cache))?;
fs::write(publisher_cache_path, publisher_cache)?;
Ok(())
}() {
error!("error writing back changes to publisher-cache: {:?}", err);
}
}
// `_lock: FileLock` implicitly released here
}
}
impl Cache {
/// Acquire the cache
pub fn acquire(cfg: &PartialConfig) -> Result<Self, CacheAcquireError> {
#[cfg(test)]
if cfg.mock_cache {
// We're in unit tests, everything should be mocked and not touch real caches
return Ok(Cache {
_lock: None,
root: None,
diff_cache_path: None,
command_history_path: None,
publisher_cache_path: None,
diff_semaphore: tokio::sync::Semaphore::new(MAX_CONCURRENT_DIFFS),
now: cfg.now,
state: Mutex::new(CacheState {
diff_cache: DiffCache::default(),
command_history: CommandHistory::default(),
crates_cache: CratesCache::default(),
published_versions: FastMap::new(),
crates_io_info_fetches: FastMap::new(),
fetched_packages: FastMap::new(),
diffed: FastMap::new(),
}),
});
}
// Make sure the cache directory exists, and acquire an exclusive lock on it.
let root = cfg.cache_dir.clone();
fs::create_dir_all(&root).map_err(|error| CacheAcquireError::Root {
target: root.clone(),
error,
})?;
let lock = Filesystem::new(root.clone()).open_rw(CACHE_VET_LOCK, "cache lock")?;
let empty = root.join(CACHE_EMPTY_PACKAGE);
fs::create_dir_all(&empty).map_err(|error| CacheAcquireError::Empty {
target: empty.clone(),
error,
})?;
let packages_src = root.join(CACHE_REGISTRY_SRC);
fs::create_dir_all(&packages_src).map_err(|error| CacheAcquireError::Src {
target: packages_src.clone(),
error,
})?;
let packages_cache = root.join(CACHE_REGISTRY_CACHE);
fs::create_dir_all(&packages_cache).map_err(|error| CacheAcquireError::Cache {
target: packages_cache.clone(),
error,
})?;
// Setup the diff_cache.
let diff_cache_path = root.join(CACHE_DIFF_CACHE);
let diff_cache: DiffCache = File::open(&diff_cache_path)
.ok()
.and_then(|f| load_toml(CACHE_DIFF_CACHE, f).map(|v| v.1).ok())
.unwrap_or_default();
// Setup the command_history.
let command_history_path = root.join(CACHE_COMMAND_HISTORY);
let command_history: CommandHistory = File::open(&command_history_path)
.ok()
.and_then(|f| load_json(f).ok())
.unwrap_or_default();
// Setup the publisher_cache.
let publisher_cache_path = root.join(CACHE_CRATES_IO_CACHE);
let publisher_cache: CratesCache = File::open(&publisher_cache_path)
.ok()
.and_then(|f| load_json(f).ok())
.unwrap_or_default();
Ok(Self {
_lock: Some(lock),
root: Some(root),
diff_cache_path: Some(diff_cache_path),
command_history_path: Some(command_history_path),
publisher_cache_path: Some(publisher_cache_path),
diff_semaphore: tokio::sync::Semaphore::new(MAX_CONCURRENT_DIFFS),
now: cfg.now,
state: Mutex::new(CacheState {
diff_cache,
command_history,
crates_cache: publisher_cache,
published_versions: FastMap::new(),
crates_io_info_fetches: FastMap::new(),
fetched_packages: FastMap::new(),
diffed: FastMap::new(),
}),
})
}
#[tracing::instrument(skip(self, metadata, network), err)]
pub async fn fetch_package(
&self,
metadata: &cargo_metadata::Metadata,
network: Option<&Network>,
package: PackageStr<'_>,
version: &VetVersion,
) -> Result<PathBuf, FetchError> {
// Lock the mutex to extract a reference to the OnceCell which we'll use
// to asynchronously synchronize on and fetch the package only once in a
// single execution.
let once_cell = {
// NOTE: Don't .await while this is held, or we might deadlock!
let mut guard = self.state.lock().unwrap();
guard
.fetched_packages
.entry((package.to_owned(), version.clone()))
.or_default()
.clone()
};
let path_res: Result<_, FetchError> = once_cell
.get_or_try_init(|| async {
let root = self.root.as_ref().unwrap();
// crates.io won't have a copy of any crates with git revision
// versions, so they need to be found in local clones within the
// cargo metadata, otherwise we cannot find them.
if let Some(git_rev) = &version.git_rev {
let repacked_src = root.join(CACHE_REGISTRY_SRC).join(format!(
"{}-{}.git.{}",
package,
version.semver,
version.git_rev.as_ref().unwrap()
));
if fetch_is_ok(&repacked_src).await {
return Ok(repacked_src);
}
// We don't have a cached re-pack - repack again ourselves.
let checkout_path = locate_local_checkout(metadata, package, version)
.ok_or_else(|| FetchError::UnknownGitRevision {
package: package.to_owned(),
git_rev: git_rev.to_owned(),
})?;
// We re-package any git checkouts into the cache in order
// to maintain a consistent directory structure with crates
// fetched from crates.io in diffs.
unpack_checkout(&checkout_path, &repacked_src)
.await
.map_err(|error| FetchError::UnpackCheckout {
src: checkout_path,
error,
})?;
return Ok(repacked_src);
}
let version = &version.semver;
let dir_name = format!("{package}-{version}");
// First try to get a cached copy from cargo's registry.
if let Ok(cargo_home) = home::cargo_home() {
// Check both the sparse and git registry caches.
for registry in [CARGO_REGISTRY_CRATES_IO_HTTP, CARGO_REGISTRY_CRATES_IO_GIT] {
let fetched_src = cargo_home
.join(CARGO_REGISTRY)
.join(CARGO_REGISTRY_SRC)
.join(registry)
.join(&dir_name);
if fetch_is_ok(&fetched_src).await {
return Ok(fetched_src);
}
}
}
// Paths for the fetched package and checkout in our local cache.
let fetched_package = root
.join(CACHE_REGISTRY_CACHE)
.join(format!("{dir_name}.crate"));
let fetched_src = root.join(CACHE_REGISTRY_SRC).join(&dir_name);
// Check if the resource is already available in our local cache.
let fetched_package_ = fetched_package.clone();
let now = filetime::FileTime::from_system_time(SystemTime::from(self.now));
let cached_file = tokio::task::spawn_blocking(move || {
File::open(&fetched_package_).inspect(|file| {
// Update the atime and mtime for this crate to ensure it isn't
// collected by the gc.
if let Err(err) =
filetime::set_file_handle_times(file, Some(now), Some(now))
{
warn!(
"failed to update mtime for {}, gc may not function correctly: {}",
fetched_package_.display(),
err
);
}
})
})
.await
.expect("failed to join");
// If the file isn't in our local cache, make sure to download it.
let file = match cached_file {
Ok(file) => file,
Err(_) => {
let network = network.ok_or_else(|| FetchError::Frozen {
package: package.to_owned(),
version: version.clone(),
})?;
// We don't have it, so download it
let url =
format!("https://crates.io/api/v1/crates/{package}/{version}/download");
let url = Url::parse(&url).map_err(|error| FetchError::InvalidUrl {
url: url.clone(),
error,
})?;
info!(
"downloading package {}:{} from {} to {}",
package,
version,
url,
fetched_package.display()
);
network.download_and_persist(url, &fetched_package).await?;
let fetched_package_ = fetched_package.clone();
tokio::task::spawn_blocking(move || File::open(fetched_package_))
.await
.expect("failed to join")
.map_err(|error| FetchError::OpenCached {
target: fetched_package.clone(),
error,
})?
}
};
// TODO(#116): take the SHA2 of the bytes and compare it to what the registry says
if fetch_is_ok(&fetched_src).await {
Ok(fetched_src)
} else {
info!(
"unpacking package {}:{} from {} to {}",
package,
version,
fetched_package.display(),
fetched_src.display()
);
// The tarball needs to be unpacked, so do so.
tokio::task::spawn_blocking(move || {
unpack_package(&file, &fetched_src)
.map(|_| fetched_src)
.map_err(|error| FetchError::Unpack {
src: fetched_package.clone(),
error,
})
})
.await
.expect("failed to join")
}
})
.await;
let path = path_res?;
Ok(path.to_owned())
}
#[tracing::instrument(skip_all, err)]
pub async fn diffstat_package(
&self,
version1: &Path,
version2: &Path,
has_git_rev: bool,
) -> Result<(DiffStat, Vec<(PathBuf, PathBuf)>), DiffError> {
let _permit = self
.diff_semaphore
.acquire()
.await
.expect("Semaphore dropped?!");
// ERRORS: all of this is properly fallible internal workings, we can fail
// to diffstat some packages and still produce some useful output
trace!("diffstating {version1:#?} {version2:#?}");
let out = tokio::process::Command::new("git")
.arg("diff")
.arg("--ignore-cr-at-eol")
.arg("--no-index")
.arg("--numstat")
.arg("-z")
.arg(version1)
.arg(version2)
.output()
.await
.map_err(CommandError::CommandFailed)?;
let status = out.status.code().unwrap_or(-1);
// 0 = empty
// 1 = some diff
if status != 0 && status != 1 {
return Err(CommandError::BadStatus(status).into());
}
let mut diffstat = DiffStat {
files_changed: 0,
insertions: 0,
deletions: 0,
};
let mut to_compare = Vec::new();
// Thanks to the `-z` flag the output takes the rough format of:
// "{INSERTED}\t{DELETED}\t\0{FROM_PATH}\0{TO_PATH}\0" for each file
// being diffed. If the file was added or removed one of the sides will
// be "/dev/null", even on Windows. Binary files use "-" for the
// inserted & deleted counts.
let output = String::from_utf8(out.stdout).map_err(CommandError::BadOutput)?;
let mut chunks = output.split('\0');
while let (Some(changes_s), Some(from_s), Some(to_s)) =
(chunks.next(), chunks.next(), chunks.next())
{
// Check if the path is one of the files which is ignored.
let rel_path = if to_s != "/dev/null" {
Path::new(to_s)
.strip_prefix(version2)
.map_err(DiffError::UnexpectedPath)?
} else {
assert_ne!(
from_s, "/dev/null",
"unexpected diff from /dev/null to /dev/null"
);
Path::new(from_s)
.strip_prefix(version1)
.map_err(DiffError::UnexpectedPath)?
};
if DIFF_SKIP_PATHS.iter().any(|p| Path::new(p) == rel_path)
|| (has_git_rev && Path::new(CARGO_TOML_FILE) == rel_path)
{
continue;
}
to_compare.push((from_s.into(), to_s.into()));
diffstat.files_changed += 1;
match changes_s.trim().split_once('\t') {
Some(("-", "-")) => {} // binary diff
Some((insertions_s, deletions_s)) => {
diffstat.insertions += insertions_s
.parse::<u64>()
.map_err(|_| DiffError::InvalidOutput)?;
diffstat.deletions += deletions_s
.parse::<u64>()
.map_err(|_| DiffError::InvalidOutput)?;
}
None => Err(DiffError::InvalidOutput)?,
};
}
Ok((diffstat, to_compare))
}
#[tracing::instrument(skip(self, metadata, network), err)]
pub async fn fetch_and_diffstat_package(
&self,
metadata: &cargo_metadata::Metadata,
network: Option<&Network>,
package: PackageStr<'_>,
delta: &Delta,
) -> Result<DiffStat, FetchAndDiffError> {
// Lock the mutex to extract a reference to the OnceCell which we'll use
// to asynchronously synchronize on and diff the package only once in a
// single execution.
//
// While we have the mutex locked, we'll also check the DiffStat cache
// to return without any async steps if possible.
let once_cell = {
// NOTE: Don't .await while this is held, or we might deadlock!
let mut guard = self.state.lock().unwrap();
// Check if the value has already been cached.
if let Some(cached) = guard
.diff_cache
.diffs
.get(package)
.and_then(|cache| cache.get(delta))
.cloned()
{
return Ok(cached);
}
if self.root.is_none() {
// If we don't have a root, assume we want mocked results
// ERRORS: this warning really rides the line, I'm not sure if the user can/should care
warn!("Missing root, assuming we're in tests and mocking");
let from_len = match &delta.from {
Some(from) => from.semver.major * from.semver.major,
None => 0,
};
let to_len: u64 = delta.to.semver.major * delta.to.semver.major;
let diff = to_len as i64 - from_len as i64;
let count = diff.unsigned_abs();
return Ok(DiffStat {
files_changed: 1,
insertions: if diff > 0 { count } else { 0 },
deletions: if diff < 0 { count } else { 0 },
});
}
guard
.diffed
.entry((package.to_owned(), delta.clone()))
.or_default()
.clone()
};
let diffstat = once_cell
.get_or_try_init(|| async {
let from = match &delta.from {
Some(from) => self.fetch_package(metadata, network, package, from).await?,
None => self.root.as_ref().unwrap().join(CACHE_EMPTY_PACKAGE),
};
let to = self
.fetch_package(metadata, network, package, &delta.to)
.await?;
// Have fetches, do a real diffstat
// NOTE: We'll never pick a 'from' version with a git_rev, so we
// don't need to check for that here.
let (diffstat, _) = self
.diffstat_package(&from, &to, delta.to.git_rev.is_some())
.await?;
// Record the cache result in the diffcache
{
let mut guard = self.state.lock().unwrap();
guard
.diff_cache
.diffs
.entry(package.to_string())
.or_default()
.insert(delta.clone(), diffstat.clone());
}
Ok::<_, FetchAndDiffError>(diffstat)
})
.await?;
Ok(diffstat.clone())
}
/// Run a garbage-collection pass over the cache, removing any files which
/// aren't supposed to be there, or which haven't been touched for an
/// extended period of time.
pub async fn gc(&self, max_package_age: Duration) {
if self.root.is_none() {
return;
}
let (root_rv, empty_rv, packages_rv) = tokio::join!(
self.gc_root(),
self.gc_empty(),
self.gc_packages(max_package_age)
);
if let Err(err) = root_rv {
error!("gc: performing gc on the cache root failed: {err}");
}
if let Err(err) = empty_rv {
error!("gc: performing gc on the empty package failed: {err}");
}
if let Err(err) = packages_rv {
error!("gc: performing gc on the package cache failed: {err}");
}
}
/// Sync version of `gc`
pub fn gc_sync(&self, max_package_age: Duration) {
tokio::runtime::Handle::current().block_on(self.gc(max_package_age));
}
/// Remove any unrecognized files from the root of the cargo-vet cache
/// directory.
async fn gc_root(&self) -> Result<(), io::Error> {
let root = self.root.as_ref().unwrap();
let mut root_entries = tokio::fs::read_dir(root).await?;
while let Some(entry) = root_entries.next_entry().await? {
if !entry
.file_name()
.to_str()
.is_some_and(|name| CACHE_ALLOWED_FILES.contains(&name))
{
remove_dir_entry(&entry).await?;
}
}
Ok(())
}
/// Remove all files located in the `cargo-vet/empty` directory, as it
/// should be empty.
async fn gc_empty(&self) -> Result<(), std::io::Error> {
let empty = self.root.as_ref().unwrap().join(CACHE_EMPTY_PACKAGE);
let mut empty_entries = tokio::fs::read_dir(&empty).await?;
while let Some(entry) = empty_entries.next_entry().await? {
remove_dir_entry(&entry).await?;
}
Ok(())
}
/// Remove any non '.crate' files from the registry cache, '.crate' files
/// which are older than `max_package_age`, and any source directories from
/// the registry src which no longer have a corresponding .crate.
async fn gc_packages(&self, max_package_age: Duration) -> Result<(), io::Error> {
let cache = self.root.as_ref().unwrap().join(CACHE_REGISTRY_CACHE);
let src = self.root.as_ref().unwrap().join(CACHE_REGISTRY_SRC);
let mut kept_packages = Vec::new();
let mut cache_entries = tokio::fs::read_dir(&cache).await?;
while let Some(entry) = cache_entries.next_entry().await? {
if let Some(to_keep) = self.should_keep_package(&entry, max_package_age).await {
kept_packages.push(to_keep);
} else {
remove_dir_entry(&entry).await?;
}
}
let mut src_entries = tokio::fs::read_dir(&src).await?;
while let Some(entry) = src_entries.next_entry().await? {
if !kept_packages.contains(&entry.file_name()) || !fetch_is_ok(&entry.path()).await {
remove_dir_entry(&entry).await?;
}
}
Ok(())
}
/// Given a directory entry for a file, returns how old it is. If there is an
/// issue (e.g. mtime >= now), will return `None` instead.
async fn get_file_age(&self, entry: &tokio::fs::DirEntry) -> Option<Duration> {
let meta = entry.metadata().await.ok()?;
SystemTime::from(self.now)
.duration_since(meta.modified().ok()?)
.ok()
}
/// Returns tne name of the crate if it should be preserved, or `None` if it shouldn't.
async fn should_keep_package(
&self,
entry: &tokio::fs::DirEntry,
max_package_age: Duration,
) -> Option<OsString> {
// Get the stem and extension from the directory entry's path, and
// immediately remove it if something goes wrong.
let path = entry.path();
let stem = path.file_stem()?;
if path.extension()? != OsStr::new("crate") {
return None;
}
match self.get_file_age(entry).await {
Some(age) if age > max_package_age => None,
_ => Some(stem.to_owned()),
}
}
/// Delete every file in the cache directory other than the cache lock, and
/// clear out the command history and diff cache files.
///
/// NOTE: The diff_cache, command_history, and publisher_cache files will be
/// re-created when the cache is unlocked, however they will be empty.
pub async fn clean(&self) -> Result<(), io::Error> {
let root = self.root.as_ref().expect("cannot clean a mocked cache");
// Make sure we don't write back the command history, diff cache, or
// publisher cache when dropping.
{
let mut guard = self.state.lock().unwrap();
guard.command_history = Default::default();
guard.diff_cache = Default::default();
guard.crates_cache = Default::default();
}
let mut root_entries = tokio::fs::read_dir(&root).await?;
while let Some(entry) = root_entries.next_entry().await? {
if entry.file_name() != Path::new(CACHE_VET_LOCK) {
remove_dir_entry(&entry).await?;
}
}
Ok(())
}
/// Sync version of `clean`
pub fn clean_sync(&self) -> Result<(), io::Error> {
tokio::runtime::Handle::current().block_on(self.clean())
}
pub fn get_last_fetch(&self) -> Option<FetchCommand> {
let guard = self.state.lock().unwrap();
guard.command_history.last_fetch.clone()
}
pub fn set_last_fetch(&self, last_fetch: FetchCommand) {
let mut guard = self.state.lock().unwrap();
guard.command_history.last_fetch = Some(last_fetch);
}
pub fn select_fetch_mode(
&self,
command: FetchModeCommand,
chosen_mode: &Option<FetchMode>,
force_local: bool,
) -> FetchMode {
// If we're going to be forced to use a local mode, return it.
//
// We don't update the cache here so that folks used to manually typing
// out `--local` when doing git diffs don't clobber their last fetch
// mode settings.
if force_local {
return FetchMode::Local;
}
// If an explicit mode was selected on the command line, update the last
// fetch mode to reflect it.
let mut guard = self.state.lock().unwrap();
let fetch_mode = match command {
FetchModeCommand::Diff => &mut guard.command_history.last_diff_fetch_mode,
FetchModeCommand::Inspect => &mut guard.command_history.last_inspect_fetch_mode,
};
if let Some(mode) = chosen_mode {
*fetch_mode = Some(mode.clone());
}
// Return either the most-recently selected fetch mode, or the default for the command if no
// fetch mode has been explicitly selected.
fetch_mode.clone().unwrap_or(command.default_fetch_mode())
}
/// For a given package, fetch the list of versions published on crates.io,
/// along with the corresponding index entry.
///
/// This information will be pulled live from index.crates.io each time
/// cargo-vet is run, but is cached in-memory.
pub async fn published_versions(
&self,
network: &Network,
package: PackageStr<'_>,
) -> Result<PublishedVersions, CrateInfoError> {
// Lock the mutex to extract a reference to the OnceCell which we'll use
// to asynchronously synchronize on and fetch the index metadata only
// once in a single execution.
let once_cell = {
// NOTE: Don't .await while this is held, or we might deadlock!
let mut guard = self.state.lock().unwrap();
guard
.published_versions
.entry(package.to_owned())
.or_default()
.clone()
};
// NOTE: Currently this makes no effort to re-use cargo's local cache,
// which might save us some requests. Newer versions of `crates-index`
// have some limited support for interacting with this cache.
let res: Result<_, CrateInfoError> = once_cell
.get_or_try_init(|| async {
// Crate names can only be a subset of ascii (valid rust
// identifier characters and `-`), so using `len()` and indexing
// will result in valid counts/characters.
let mut url = String::from("https://index.crates.io/");
use std::fmt::Write;
match package.len() {
1 => write!(url, "1/{package}"),
2 => write!(url, "2/{package}"),
3 => write!(url, "3/{}/{package}", &package[0..1]),
_ => write!(url, "{}/{}/{package}", &package[0..2], &package[2..4]),
}
.expect("writing to a String should not fail");
// Crate index always use lowercases, but crate name may contain
// uppercase characters.
url.make_ascii_lowercase();
let url = Url::parse(&url).expect("invalid crate name");
// Fetch the crate's entry from the index
let response = match network.download(url).await {
Ok(response) => response,
Err(DownloadError::FailedToStartDownload { error, .. })
if error.status() == Some(reqwest::StatusCode::NOT_FOUND) =>
{
// The crate doesn't exist. We don't want to keep
// checking the URL, so return an empty versions list
// which will be stored in the cache.
return Ok(Arc::new(SortedMap::new()));
}
Err(error) => return Err(error.into()),
};
let crate_entry =
crates_index::Crate::from_slice(&response[..]).map_err(LoadJsonError::from)?;
let mut result = SortedMap::new();
for version_entry in crate_entry.versions() {
match semver::Version::parse(version_entry.version()) {
Ok(version) => {
result.insert(version, version_entry.clone());
}
Err(err) => {
error!(
"bad index version '{}' for crate {package}: {err}",
version_entry.version(),
);
}
}
}
info!("found {} versions for crate {}", result.len(), package);
Ok(Arc::new(result))
})
.await;
let res = res?;
// If we have no published versions, the crate does not exist, which can
// be reported as an error.
if res.is_empty() {
return Err(CrateInfoError::DoesNotExist {
name: package.to_owned(),
});
}
Ok(res.clone())
}
/// Get up-to-date crates.io information for a given crate.
///
/// The result is cached to avoid unnecessary calls to the crates.io API,
/// and the sparse HTTP index will be used to determine when updated
/// information is required.
pub async fn crates_io_info(
&self,
network: Option<&Network>,
package: PackageStr<'_>,
) -> Result<Arc<CratesCacheEntry>, CrateInfoError> {
// If we don't have network access, we're forced to assume that the
// cache is up to date.
let Some(network) = network else {
let guard = self.state.lock().unwrap();
let entry = guard.crates_cache.crates.get(package).ok_or_else(|| {
CrateInfoError::DoesNotExist {
name: package.to_owned(),
}
})?;
return Ok(entry.clone());
};
// Check if we already have information for all published versions, if
// we do, we don't need to update anything.
// This will also check if the crate does not exist, in which case we'll
// early-return with an error.
let published_versions = self.published_versions(network, package).await?;
// Lock the mutex. We'll either detect that we already have metadata for
// all published versions, or we'll extract a reference to the OnceCell
// which can be used to ensure only a single request is made to the
// crates.io API for this crate.
let once_cell = {
// NOTE: Don't .await while this is held, or we might deadlock!
let mut guard = self.state.lock().unwrap();
if let Some(entry) = guard.crates_cache.crates.get(package) {
if entry.versions.len() == published_versions.len()
&& entry.versions.keys().eq(published_versions.keys())
{
return Ok(entry.clone());
}
}
guard
.crates_io_info_fetches
.entry(package.to_owned())
.or_default()
.clone()
};
// The crate exists, and some metadata is missing. Perform the fetch and
// update crates_cache with the new data from the network.
once_cell
.get_or_try_init(|| async {
info!("fetching crate metadata for crate {}", package);
let url = Url::parse(&format!("https://crates.io/api/v1/crates/{}", package))
.expect("invalid crate name");
let response = network.download(url).await?;
let result = load_json::<CratesAPICrate>(&response[..])?;
// Update the users cache and individual crates caches, and return our
// set of versions.
let mut guard = self.state.lock().unwrap();
let versions: SortedMap<_, _> = result
.versions
.into_iter()
// If a race occurred and a new version was published since
// `published_versions` was checked, discard it to avoid
// confusing other callers.
.filter(|api_version| published_versions.contains_key(&api_version.num))
.map(|api_version| {
(
api_version.num,
CratesCacheVersionDetails {
created_at: api_version.created_at,
source: api_version
.published_by
.map(|api_user| {
info!("recording user info for {api_user:?}");
guard.crates_cache.users.insert(
api_user.id,
CratesCacheUser {
login: api_user.login,
name: api_user.name,
},
);
CratesSourceId::User {
user_id: api_user.id,
}
})
.or_else(|| {
Some(CratesSourceId::TrustedPublisher {
trusted_publisher: api_version
.trustpub_data?
.as_signature()?,
})
}),
},
)
})
.collect();
if versions.len() != published_versions.len() {
panic!(
"crates.io API state inconsistent with index - missing: {:?}",
published_versions
.keys()
.filter(|k| !versions.contains_key(k))
.collect::<Vec<_>>()
);
}
let entry = Arc::new(CratesCacheEntry {
versions,
metadata: result.crate_data,
});
guard
.crates_cache
.crates
.insert(package.to_owned(), entry.clone());
Ok::<_, CrateInfoError>(entry)
})
.await?;
let guard = self.state.lock().unwrap();
let entry = guard
.crates_cache
.crates
.get(package)
.expect("entry cannot be missing");
Ok(entry.clone())
}
/// Hydrate a CratesSourceId into a CratesPublisherSource based on
/// user information for a crates.io user from the publisher cache.
pub fn publisher_id_to_source(&self, source: &CratesSourceId) -> Option<CratesPublisherSource> {
match source {
CratesSourceId::User { user_id } => {
let user_info = self.get_crates_user_info(*user_id)?;
Some(CratesPublisherSource::User {
user_id: *user_id,
user_login: user_info.login.clone(),
user_name: user_info.name.clone(),
})
}
CratesSourceId::TrustedPublisher { trusted_publisher } => {
Some(CratesPublisherSource::TrustedPublisher {
trusted_publisher: trusted_publisher.clone(),
})
}
}
}
/// Look up user information for a crates.io user from the publisher cache.
pub fn get_crates_user_info(&self, user_id: u64) -> Option<CratesCacheUser> {
let guard = self.state.lock().unwrap();
guard.crates_cache.users.get(&user_id).cloned()
}
}
/// Queries a package in the crates.io registry for a specific published version
pub fn exact_version<'a>(
this: &'a crates_index::Crate,
target_version: &semver::Version,
) -> Option<&'a crates_index::Version> {
for index_version in this.versions() {
if let Ok(index_ver) = index_version.version().parse::<semver::Version>() {
if &index_ver == target_version {
return Some(index_version);
}
}
}
None
}
/// Locate the checkout path for the given package and version if it is part of
/// the local build graph. Returns `None` if a local checkout cannot be found.
pub fn locate_local_checkout(
metadata: &cargo_metadata::Metadata,
package: PackageStr<'_>,
version: &VetVersion,
) -> Option<PathBuf> {
for pkg in &metadata.packages {
if *pkg.name == package && &pkg.vet_version() == version {
assert_eq!(
pkg.manifest_path.file_name(),
Some(CARGO_TOML_FILE),
"unexpected manifest file name"
);
return Some(pkg.manifest_path.parent().map(PathBuf::from).unwrap());
}
}
None
}
#[tracing::instrument(err)]
fn unpack_package(tarball: &File, unpack_dir: &Path) -> Result<(), UnpackError> {
// If we get here and the unpack_dir exists, this implies we had a previously failed fetch,
// blast it away so we can have a clean slate!
if unpack_dir.exists() {
fs::remove_dir_all(unpack_dir)?;
}
fs::create_dir(unpack_dir)?;
let gz = GzDecoder::new(tarball);
let mut tar = Archive::new(gz);
let prefix = unpack_dir.file_name().unwrap();
let parent = unpack_dir.parent().unwrap();
for entry in tar.entries()? {
let mut entry = entry.map_err(UnpackError::ArchiveIterate)?;
let entry_path = entry
.path()
.map_err(UnpackError::ArchiveEntry)?
.into_owned();
// We're going to unpack this tarball into the global source
// directory, but we want to make sure that it doesn't accidentally
// (or maliciously) overwrite source code from other crates. Cargo
// itself should never generate a tarball that hits this error, and
// crates.io should also block uploads with these sorts of tarballs,
// but be extra sure by adding a check here as well.
if !entry_path.starts_with(prefix) {
return Err(UnpackError::InvalidPaths {
entry_path,
prefix: prefix.to_owned(),
});
}
entry
.unpack_in(parent)
.map_err(|error| UnpackError::Unpack {
entry_path: entry_path.clone(),
error,
})?;
}
create_unpack_lock(unpack_dir).map_err(|error| UnpackError::LockCreate {
target: unpack_dir.to_owned(),
error,
})?;
Ok(())
}
fn create_unpack_lock(unpack_dir: &Path) -> Result<(), io::Error> {
let lockfile = unpack_dir.join(CARGO_OK_FILE);
// The lock file is created after unpacking so we overwrite a lock file
// which may have been extracted from the package.
let mut ok = OpenOptions::new()
.create(true)
.truncate(true)
.read(true)
.write(true)
.open(lockfile)?;
// Write to the lock file to indicate that unpacking was successful.
write!(ok, "ok")?;
ok.sync_all()?;
Ok(())
}
/// Unpack a non-crates.io package checkout in a format similar to what would be
/// unpacked from a .crate file published on crates.io.
///
/// This is used in order to normalize the file and directory structure for git
/// revisions to make them easier to work with when diffing.
async fn unpack_checkout(
checkout_path: &Path,
unpack_path: &Path,
) -> Result<(), UnpackCheckoutError> {
// Invoke `cargo package --list` to determine the list of files which
// should be copied to the repackaged directory.
let cargo_path = std::env::var_os(CARGO_ENV).expect("Cargo failed to set $CARGO, how?");
let out = tokio::process::Command::new(cargo_path)
.arg("package")
.arg("--list")
.arg("--allow-dirty")
.arg("--manifest-path")
.arg(checkout_path.join(CARGO_TOML_FILE))
.output()
.await
.map_err(CommandError::CommandFailed)?;
if !out.status.success() {
return Err(CommandError::BadStatus(out.status.code().unwrap_or(-1)).into());
}
let stdout = String::from_utf8(out.stdout).map_err(CommandError::BadOutput)?;
tokio::fs::create_dir_all(unpack_path)
.await
.map_err(|error| UnpackCheckoutError::CreateDirError {
path: unpack_path.to_owned(),
error,
})?;
// Asynchronously copy all required files to the target directory.
try_join_all(stdout.lines().map(|target| async move {
// We'll be ignoring diffs for each of the skipped paths, so we can
// ignore these if cargo reports them.
if DIFF_SKIP_PATHS.contains(&target) {
return Ok(());
}
let to = unpack_path.join(target);
let from = match target {
// Copy the original Cargo.toml to Cargo.toml.orig for better
// comparisons.
"Cargo.toml.orig" => checkout_path.join(CARGO_TOML_FILE),
_ => checkout_path.join(target),
};
// Create the directory this file will be placed in.
let parent = to.parent().unwrap();
tokio::fs::create_dir_all(&parent).await.map_err(|error| {
UnpackCheckoutError::CreateDirError {
path: parent.to_owned(),
error,
}
})?;
match tokio::fs::copy(from, to).await {
Ok(_) => Ok(()),
Err(error) => match error.kind() {
// Cargo may tell us about files which don't exist (e.g. because
// they are generated). It's OK to ignore those files when
// copying.
io::ErrorKind::NotFound => Ok(()),
_ => Err(UnpackCheckoutError::CopyError {
target: target.into(),
error,
}),
},
}
}))
.await?;
let unpack_path_ = unpack_path.to_owned();
tokio::task::spawn_blocking(move || create_unpack_lock(&unpack_path_))
.await
.expect("failed to join")
.map_err(UnpackCheckoutError::LockCreate)?;
Ok(())
}
async fn fetch_is_ok(fetch: &Path) -> bool {
match tokio::fs::read_to_string(fetch.join(CARGO_OK_FILE)).await {
Ok(ok) => ok == CARGO_OK_BODY,
Err(_) => false,
}
}
/// Based on the type of file for an entry, either recursively remove the
/// directory, or remove the file. This is intended to be roughly equivalent to
/// `rm -r`.
async fn remove_dir_entry(entry: &tokio::fs::DirEntry) -> Result<(), io::Error> {
info!("gc: removing {}", entry.path().display());
let file_type = entry.file_type().await?;
if file_type.is_dir() {
tokio::fs::remove_dir_all(entry.path()).await?;
} else {
tokio::fs::remove_file(entry.path()).await?;
}
Ok(())
}
fn load_toml<T>(file_name: &str, reader: impl Read) -> Result<(SourceFile, T), LoadTomlError>
where
T: for<'a> Deserialize<'a>,
{
let mut reader = BufReader::new(reader);
let mut string = String::new();
reader.read_to_string(&mut string)?;
let source_code = SourceFile::new(file_name, string);
let result = toml::de::from_str(source_code.source());
match result {
Ok(toml) => Ok((source_code, toml)),
Err(error) => Err(TomlParseError {
source_code,
span: error.span().unwrap_or(0..0).into(),
error,
}
.into()),
}
}
fn store_toml<T>(
heading: &str,
mut val: T,
user_info: Option<&FastMap<CratesUserId, CratesCacheUser>>,
) -> Result<String, StoreTomlError>
where
T: Serialize + Tidyable,
{
val.tidy();
let toml_document = to_formatted_toml(val, user_info)?;
Ok(format!("{heading}{toml_document}"))
}
fn load_json<T>(reader: impl Read) -> Result<T, LoadJsonError>
where
T: for<'a> Deserialize<'a>,
{
let mut reader = BufReader::new(reader);
let mut string = String::new();
reader.read_to_string(&mut string)?;
let json = serde_json::from_str(&string).map_err(|error| JsonParseError { error })?;
Ok(json)
}
fn store_json<T>(val: T) -> Result<String, StoreJsonError>
where
T: Serialize,
{
let json_string = serde_json::to_string(&val)?;
Ok(json_string)
}
fn store_audits(
audits: AuditsFile,
user_info: &FastMap<CratesUserId, CratesCacheUser>,
) -> Result<String, StoreTomlError> {
let heading = r###"
# cargo-vet audits file
"###;
store_toml(heading, audits, Some(user_info))
}
fn store_config(config: ConfigFile) -> Result<String, StoreTomlError> {
let heading = r###"
# cargo-vet config file
"###;
store_toml(heading, config, None)
}
fn store_imports(
imports: ImportsFile,
user_info: &FastMap<CratesUserId, CratesCacheUser>,
) -> Result<String, StoreTomlError> {
let heading = r###"
# cargo-vet imports lock
"###;
store_toml(heading, imports, Some(user_info))
}
fn store_diff_cache(diff_cache: DiffCache) -> Result<String, StoreTomlError> {
let heading = "";
store_toml(heading, diff_cache, None)
}
fn store_command_history(command_history: CommandHistory) -> Result<String, StoreJsonError> {
store_json(command_history)
}
fn store_publisher_cache(publisher_cache: CratesCache) -> Result<String, StoreJsonError> {
store_json(publisher_cache)
}