cargo-shear 1.9.0

Detect and fix unused/misplaced dependencies from Cargo.toml
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
use std::{error::Error, fmt};

use miette::{Diagnostic, LabeledSpan, NamedSource, Severity, SourceSpan};
use rustc_hash::FxHashSet;

use crate::{
    context::{PackageContext, WorkspaceContext},
    manifest::{DepTable, FeatureRef},
    package_processor::{
        EmptyFile, MisplacedDependency, MisplacedOptionalDependency, PackageAnalysis,
        RedundantIgnore, RedundantIgnorePath, UnknownIgnore, UnlinkedFile, UnusedDependency,
        UnusedFeatureDependency, UnusedOptionalDependency, UnusedWorkspaceDependency,
        WorkspaceAnalysis,
    },
    tree::Tree,
};

/// Result of processing all packages across the workspace.
#[derive(Debug, Default)]
pub struct ShearAnalysis {
    /// All diagnostic findings.
    pub findings: Vec<ShearDiagnostic>,

    /// All package names used across the workspace.
    pub packages: FxHashSet<String>,

    /// Count of errors.
    pub errors: usize,

    /// Count of warnings.
    /// Anything that can't be automatically fixed is considered a warning.
    pub warnings: usize,

    /// Count of fixed issues.
    pub fixed: usize,

    /// Whether to show the `ignored` advice.
    pub show_ignored: bool,

    /// Whether to show the `ignored-paths` advice.
    pub show_ignored_paths: bool,
}

impl ShearAnalysis {
    pub fn add_package_result(
        &mut self,
        ctx: &PackageContext<'_>,
        result: &PackageAnalysis,
        fixed: usize,
    ) {
        let relative_path = ctx
            .manifest_path
            .strip_prefix(&ctx.workspace.root)
            .unwrap_or(&ctx.manifest_path)
            .display()
            .to_string();

        let src = NamedSource::new(relative_path, ctx.manifest_content.clone());
        self.packages.extend(result.used_packages.iter().cloned());
        self.fixed += fixed;

        for finding in &result.unused_dependencies {
            self.insert(ShearDiagnostic::unused_dependency(finding, &src));
        }

        for finding in &result.unused_optional_dependencies {
            self.insert(ShearDiagnostic::unused_optional_dependency(finding, &src));
        }

        for finding in &result.unused_feature_dependencies {
            self.insert(ShearDiagnostic::unused_feature_dependency(finding, &src));
        }

        for finding in &result.misplaced_dependencies {
            self.insert(ShearDiagnostic::misplaced_dependency(finding, &src));
        }

        for finding in &result.misplaced_optional_dependencies {
            self.insert(ShearDiagnostic::misplaced_optional_dependency(finding, &src));
        }

        // Calculate root path for file diagnostics
        let root = ctx
            .directory
            .strip_prefix(&ctx.workspace.root)
            .ok()
            .filter(|path| !path.as_os_str().is_empty())
            .map_or_else(|| ".".to_owned(), |path| path.display().to_string());

        if !result.unlinked_files.is_empty() {
            self.insert(ShearDiagnostic::unlinked_files(&result.unlinked_files, &ctx.name, &root));
        }

        if !result.empty_files.is_empty() {
            self.insert(ShearDiagnostic::empty_files(&result.empty_files, &ctx.name, &root));
        }

        for finding in &result.unknown_ignores {
            self.insert(ShearDiagnostic::unknown_ignore(finding, &src));
        }

        for finding in &result.redundant_ignores {
            self.insert(ShearDiagnostic::redundant_ignore(finding, &src));
        }

        for finding in &result.redundant_ignore_paths {
            self.insert(ShearDiagnostic::redundant_ignore_path(finding));
        }
    }

    pub fn add_workspace_result(
        &mut self,
        ctx: &WorkspaceContext,
        result: &WorkspaceAnalysis,
        fixed: usize,
    ) {
        let src = NamedSource::new("Cargo.toml", ctx.manifest_content.clone());
        self.fixed += fixed;

        for finding in &result.unused_dependencies {
            self.insert(ShearDiagnostic::unused_workspace_dependency(finding, &src));
        }

        for finding in &result.unknown_ignores {
            self.insert(ShearDiagnostic::unknown_ignore(finding, &src));
        }

        for finding in &result.redundant_ignores {
            self.insert(ShearDiagnostic::redundant_ignore(finding, &src));
        }
    }

    fn insert(&mut self, diagnostic: ShearDiagnostic) {
        match &diagnostic.kind {
            DiagnosticKind::UnusedDependency { .. }
            | DiagnosticKind::UnusedWorkspaceDependency { .. }
            | DiagnosticKind::MisplacedDependency { .. } => {
                self.errors += 1;
                self.show_ignored = true;
            }
            DiagnosticKind::UnusedOptionalDependency { .. }
            | DiagnosticKind::UnusedFeatureDependency { .. }
            | DiagnosticKind::MisplacedOptionalDependency { .. } => {
                self.warnings += 1;
                self.show_ignored = true;
            }
            DiagnosticKind::UnlinkedFiles { .. } | DiagnosticKind::EmptyFiles { .. } => {
                self.warnings += 1;
                self.show_ignored_paths = true;
            }
            DiagnosticKind::UnknownIgnore { .. }
            | DiagnosticKind::RedundantIgnore { .. }
            | DiagnosticKind::RedundantIgnorePath { .. } => self.warnings += 1,
        }

        self.findings.push(diagnostic);
    }

    /// Whether to show the `--fix` advice.
    pub const fn show_fix(&self) -> bool {
        self.errors > 0 && self.fixed == 0
    }
}

/// Unified diagnostic type that contains all information needed for display.
pub struct ShearDiagnostic {
    /// The kind of diagnostic.
    kind: DiagnosticKind,

    /// Source content.
    source: Option<NamedSource<String>>,

    /// Primary span.
    span: Option<SourceSpan>,

    /// Any related diagnostics.
    related: Vec<Box<dyn Diagnostic + Send + Sync>>,

    /// Optional help text.
    help: Option<String>,
}

impl fmt::Debug for ShearDiagnostic {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("ShearDiagnostic")
            .field("kind", &self.kind)
            .field("source", &self.source)
            .field("span", &self.span)
            .field("related", &format!("[{} related diagnostics]", self.related.len()))
            .field("help", &self.help)
            .finish()
    }
}

impl ShearDiagnostic {
    pub fn unused_dependency(diagnostic: &UnusedDependency, source: &NamedSource<String>) -> Self {
        Self {
            kind: DiagnosticKind::UnusedDependency { name: diagnostic.name.get_ref().clone() },
            source: Some(source.clone()),
            span: Some(diagnostic.name.span().into()),
            related: Vec::new(),
            help: Some("remove this dependency".to_owned()),
        }
    }

    pub fn unused_workspace_dependency(
        diagnostic: &UnusedWorkspaceDependency,
        source: &NamedSource<String>,
    ) -> Self {
        Self {
            kind: DiagnosticKind::UnusedWorkspaceDependency {
                name: diagnostic.name.get_ref().clone(),
            },
            source: Some(source.clone()),
            span: Some(diagnostic.name.span().into()),
            related: Vec::new(),
            help: Some("remove this dependency".to_owned()),
        }
    }

    pub fn unused_optional_dependency(
        diagnostic: &UnusedOptionalDependency,
        source: &NamedSource<String>,
    ) -> Self {
        Self {
            kind: DiagnosticKind::UnusedOptionalDependency {
                name: diagnostic.name.get_ref().clone(),
            },
            source: Some(source.clone()),
            span: Some(diagnostic.name.span().into()),
            related: ShearRelatedDiagnostic::from_features(
                Some("removing an optional dependency may be a breaking change"),
                &diagnostic.features,
                source,
            ),
            help: None,
        }
    }

    pub fn unused_feature_dependency(
        diagnostic: &UnusedFeatureDependency,
        source: &NamedSource<String>,
    ) -> Self {
        Self {
            kind: DiagnosticKind::UnusedFeatureDependency {
                name: diagnostic.name.get_ref().clone(),
            },
            source: Some(source.clone()),
            span: Some(diagnostic.name.span().into()),
            related: ShearRelatedDiagnostic::from_features(None, &diagnostic.features, source),
            help: None,
        }
    }

    pub fn misplaced_dependency(
        diagnostic: &MisplacedDependency,
        source: &NamedSource<String>,
    ) -> Self {
        let target = diagnostic.location.as_table(DepTable::Dev);
        Self {
            kind: DiagnosticKind::MisplacedDependency { name: diagnostic.name.get_ref().clone() },
            source: Some(source.clone()),
            span: Some(diagnostic.name.span().into()),
            related: Vec::new(),
            help: Some(format!("move this dependency to `{target}`")),
        }
    }

    pub fn misplaced_optional_dependency(
        diagnostic: &MisplacedOptionalDependency,
        source: &NamedSource<String>,
    ) -> Self {
        let target = diagnostic.location.as_table(DepTable::Dev);
        Self {
            kind: DiagnosticKind::MisplacedOptionalDependency {
                name: diagnostic.name.get_ref().clone(),
            },
            source: Some(source.clone()),
            span: Some(diagnostic.name.span().into()),
            related: ShearRelatedDiagnostic::from_features(
                Some("removing an optional dependency may be a breaking change"),
                &diagnostic.features,
                source,
            ),
            help: Some(format!("remove the `optional` flag and move to `{target}`")),
        }
    }

    pub fn unlinked_files(diagnostics: &[UnlinkedFile], package: &str, root: &str) -> Self {
        let paths: Vec<String> =
            diagnostics.iter().map(|file| file.path.display().to_string()).collect();

        let help = if paths.len() == 1 {
            "delete this file".to_owned()
        } else {
            "delete these files".to_owned()
        };

        Self {
            kind: DiagnosticKind::UnlinkedFiles {
                package: package.to_owned(),
                root: root.to_owned(),
                paths,
            },
            source: None,
            span: None,
            related: Vec::new(),
            help: Some(help),
        }
    }

    pub fn empty_files(diagnostics: &[EmptyFile], package: &str, root: &str) -> Self {
        let paths: Vec<String> =
            diagnostics.iter().map(|file| file.path.display().to_string()).collect();

        let help = if paths.len() == 1 {
            "delete this file".to_owned()
        } else {
            "delete these files".to_owned()
        };

        Self {
            kind: DiagnosticKind::EmptyFiles {
                package: package.to_owned(),
                root: root.to_owned(),
                paths,
            },
            source: None,
            span: None,
            related: Vec::new(),
            help: Some(help),
        }
    }

    pub fn unknown_ignore(diagnostic: &UnknownIgnore, source: &NamedSource<String>) -> Self {
        Self {
            kind: DiagnosticKind::UnknownIgnore { name: diagnostic.name.get_ref().clone() },
            source: Some(source.clone()),
            span: Some(diagnostic.name.span().into()),
            related: Vec::new(),
            help: Some("remove from ignored list".to_owned()),
        }
    }

    pub fn redundant_ignore(diagnostic: &RedundantIgnore, source: &NamedSource<String>) -> Self {
        Self {
            kind: DiagnosticKind::RedundantIgnore { name: diagnostic.name.get_ref().clone() },
            source: Some(source.clone()),
            span: Some(diagnostic.name.span().into()),
            related: Vec::new(),
            help: Some("remove from ignored list".to_owned()),
        }
    }

    pub fn redundant_ignore_path(diagnostic: &RedundantIgnorePath) -> Self {
        Self {
            kind: DiagnosticKind::RedundantIgnorePath { pattern: diagnostic.pattern.clone() },
            source: None,
            span: None,
            related: Vec::new(),
            help: Some("remove from ignored paths list".to_owned()),
        }
    }
}

#[derive(Debug)]
enum DiagnosticKind {
    UnusedDependency { name: String },
    UnusedWorkspaceDependency { name: String },
    UnusedOptionalDependency { name: String },
    UnusedFeatureDependency { name: String },
    MisplacedDependency { name: String },
    MisplacedOptionalDependency { name: String },
    UnlinkedFiles { package: String, root: String, paths: Vec<String> },
    EmptyFiles { package: String, root: String, paths: Vec<String> },
    UnknownIgnore { name: String },
    RedundantIgnore { name: String },
    RedundantIgnorePath { pattern: String },
}

impl DiagnosticKind {
    fn message(&self) -> String {
        match self {
            Self::UnusedDependency { name } => format!("unused dependency `{name}`"),
            Self::UnusedWorkspaceDependency { name } => {
                format!("unused workspace dependency `{name}`")
            }
            Self::UnusedOptionalDependency { name } => {
                format!("unused optional dependency `{name}`")
            }
            Self::UnusedFeatureDependency { name } => {
                format!("dependency `{name}` only used in features")
            }
            Self::MisplacedDependency { name } => format!("misplaced dependency `{name}`"),
            Self::MisplacedOptionalDependency { name } => {
                format!("misplaced optional dependency `{name}`")
            }
            Self::UnlinkedFiles { package, root, paths } => {
                let tree = Tree::with_paths(root, paths);
                let s = if paths.len() == 1 { "" } else { "s" };
                format!("{} unlinked file{s} in `{package}`\n{tree}", paths.len())
                    .trim_end()
                    .to_owned()
            }
            Self::EmptyFiles { package, root, paths } => {
                let tree = Tree::with_paths(root, paths);
                let s = if paths.len() == 1 { "" } else { "s" };
                format!("{} empty file{s} in `{package}`\n{tree}", paths.len())
                    .trim_end()
                    .to_owned()
            }
            Self::UnknownIgnore { name } => format!("unknown ignore `{name}`"),
            Self::RedundantIgnore { name } => format!("redundant ignore `{name}`"),
            Self::RedundantIgnorePath { pattern } => {
                format!("redundant ignored paths pattern `{pattern}`")
            }
        }
    }

    const fn label(&self) -> Option<&'static str> {
        match self {
            Self::UnusedWorkspaceDependency { .. } => Some("not used by any workspace member"),
            Self::UnusedDependency { .. }
            | Self::UnusedOptionalDependency { .. }
            | Self::UnusedFeatureDependency { .. } => Some("not used in code"),
            Self::MisplacedDependency { .. } | Self::MisplacedOptionalDependency { .. } => {
                Some("only used in dev targets")
            }
            Self::UnlinkedFiles { .. }
            | Self::EmptyFiles { .. }
            | Self::RedundantIgnorePath { .. } => None,
            Self::UnknownIgnore { .. } => Some("not a dependency"),
            Self::RedundantIgnore { .. } => Some("dependency is used"),
        }
    }

    const fn code(&self) -> &'static str {
        match self {
            Self::UnusedDependency { .. } => "shear/unused_dependency",
            Self::UnusedWorkspaceDependency { .. } => "shear/unused_workspace_dependency",
            Self::UnusedOptionalDependency { .. } => "shear/unused_optional_dependency",
            Self::UnusedFeatureDependency { .. } => "shear/unused_feature_dependency",
            Self::MisplacedDependency { .. } => "shear/misplaced_dependency",
            Self::MisplacedOptionalDependency { .. } => "shear/misplaced_optional_dependency",
            Self::UnlinkedFiles { .. } => "shear/unlinked_files",
            Self::EmptyFiles { .. } => "shear/empty_files",
            Self::UnknownIgnore { .. } => "shear/unknown_ignore",
            Self::RedundantIgnore { .. } => "shear/redundant_ignore",
            Self::RedundantIgnorePath { .. } => "shear/redundant_ignore_path",
        }
    }

    const fn severity(&self) -> Severity {
        match self {
            Self::UnusedDependency { .. }
            | Self::UnusedWorkspaceDependency { .. }
            | Self::MisplacedDependency { .. } => Severity::Error,
            Self::UnlinkedFiles { .. }
            | Self::EmptyFiles { .. }
            | Self::UnusedOptionalDependency { .. }
            | Self::UnusedFeatureDependency { .. }
            | Self::MisplacedOptionalDependency { .. }
            | Self::UnknownIgnore { .. }
            | Self::RedundantIgnore { .. }
            | Self::RedundantIgnorePath { .. } => Severity::Warning,
        }
    }
}

impl fmt::Display for ShearDiagnostic {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{}", self.kind.message())
    }
}

impl Error for ShearDiagnostic {}

impl Diagnostic for ShearDiagnostic {
    fn code<'a>(&'a self) -> Option<Box<dyn fmt::Display + 'a>> {
        Some(Box::new(self.kind.code()))
    }

    fn severity(&self) -> Option<Severity> {
        Some(self.kind.severity())
    }

    fn help<'a>(&'a self) -> Option<Box<dyn fmt::Display + 'a>> {
        self.help.as_ref().map(|help| Box::new(help.as_str()) as Box<dyn fmt::Display>)
    }

    fn source_code(&self) -> Option<&dyn miette::SourceCode> {
        self.source.as_ref().map(|source| source as &dyn miette::SourceCode)
    }

    fn labels(&self) -> Option<Box<dyn Iterator<Item = LabeledSpan> + '_>> {
        let label = self.kind.label()?;
        let span = self.span?;
        Some(Box::new(std::iter::once(LabeledSpan::new_with_span(Some(label.to_owned()), span))))
    }

    fn related<'a>(&'a self) -> Option<Box<dyn Iterator<Item = &'a dyn Diagnostic> + 'a>> {
        if self.related.is_empty() {
            return None;
        }

        Some(Box::new(self.related.iter().map(|diagnostic| diagnostic.as_ref() as &dyn Diagnostic)))
    }
}

/// A related diagnostic.
#[derive(Debug)]
struct ShearRelatedDiagnostic {
    message: String,
    label: Option<(String, SourceSpan, NamedSource<String>)>,
}

impl ShearRelatedDiagnostic {
    fn from_features(
        message: Option<&str>,
        features: &[FeatureRef],
        source: &NamedSource<String>,
    ) -> Vec<Box<dyn Diagnostic + Send + Sync>> {
        let mut related: Vec<Box<dyn Diagnostic + Send + Sync>> = Vec::new();

        if let Some(message) = message {
            related.push(Self { message: message.to_owned(), label: None }.into());
        }

        for feature in features {
            match feature {
                FeatureRef::Explicit { feature, value }
                | FeatureRef::DepFeature { feature, value }
                | FeatureRef::WeakDepFeature { feature, value } => {
                    let name = feature.get_ref();
                    related.push(
                        Self {
                            message: format!("used in feature `{name}`"),
                            label: Some((
                                "enabled here".to_owned(),
                                value.span().into(),
                                source.clone(),
                            )),
                        }
                        .into(),
                    );
                }
                FeatureRef::Implicit => {}
            }
        }

        related
    }
}

impl fmt::Display for ShearRelatedDiagnostic {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{}", self.message)
    }
}

impl Error for ShearRelatedDiagnostic {}

impl Diagnostic for ShearRelatedDiagnostic {
    fn severity(&self) -> Option<Severity> {
        Some(Severity::Advice)
    }

    fn source_code(&self) -> Option<&dyn miette::SourceCode> {
        self.label.as_ref().map(|(_, _, source)| source as &dyn miette::SourceCode)
    }

    fn labels(&self) -> Option<Box<dyn Iterator<Item = LabeledSpan> + '_>> {
        self.label.as_ref().map(|(label, span, _)| {
            Box::new(std::iter::once(LabeledSpan::new_with_span(Some(label.clone()), *span)))
                as Box<dyn Iterator<Item = LabeledSpan> + '_>
        })
    }
}