cargo-pgo 0.3.0

Cargo subcommand for optimizing Rust binaries with PGO and BOLT.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
use crate::get_default_target;
use cargo_metadata::{Artifact, Message, MessageIter, TargetKind};
use std::collections::HashMap;
use std::fmt::Write as WriteFmt;
use std::io::{BufReader, Write};
use std::path::PathBuf;
use std::process::{Child, ChildStdout, Command, Stdio};

#[derive(Debug, Default)]
pub struct CargoArgs {
    pub filtered: Vec<String>,
    pub contains_target: bool,
    pub contains_profile: bool,
    pub target_dir: Option<PathBuf>,
}

enum ReleaseMode {
    AddRelease,
    NoRelease,
}

pub struct RunningCargo {
    child: Child,
    message_iter: MessageIter<BufReader<ChildStdout>>,
}

#[derive(Debug, Copy, Clone, clap::ValueEnum)]
pub enum CargoCommand {
    Build,
    Test,
    Run,
    Bench,
}

impl CargoCommand {
    pub fn to_str(&self) -> &str {
        match self {
            CargoCommand::Build => "build",
            CargoCommand::Test => "test",
            CargoCommand::Run => "run",
            CargoCommand::Bench => "bench",
        }
    }
}

impl RunningCargo {
    pub fn messages(&mut self) -> &mut MessageIter<BufReader<ChildStdout>> {
        &mut self.message_iter
    }

    pub fn check_status(mut self) -> anyhow::Result<()> {
        let status = self.child.wait()?;
        if !status.success() {
            return Err(anyhow::anyhow!(
                "Cargo finished with an error ({})",
                status.code().unwrap_or(-1),
            ));
        }
        Ok(())
    }
}

/// Start a `cargo` command in release mode with the provided RUSTFLAGS and Cargo arguments.
pub fn cargo_command_with_rustflags(
    command: CargoCommand,
    rustflags: Vec<String>,
    cargo_args: Vec<String>,
) -> anyhow::Result<RunningCargo> {
    let mut env = HashMap::default();

    // We have to handle RUSTFLAGS in a special way, to make sure that we don't override users
    // values from .cargo/config.toml.

    // The `--config` flag is only supported in Rust 1.63+.
    let supports_config_flag = rustc_version::version()? >= semver::Version::new(1, 63, 0);
    let serialized_rustflags = rustflags.join(" ");

    let mut final_cargo_args = vec![];

    match (supports_config_flag, std::env::var("RUSTFLAGS")) {
        (_, Ok(mut existing_rustflags)) => {
            // If RUSTFLAGS was defined explicitly, we want to append to it. These RUSTFLAGS will
            // override everything else, so we don't need to care about .cargo/config.toml, but we
            // have to add ourselves to it, so that we do use the PGO flags
            write!(&mut existing_rustflags, " {serialized_rustflags}")?;
            env.insert("RUSTFLAGS".to_string(), existing_rustflags);
        }
        (false, _) => {
            // If there's no RUSTFLAGS, and Cargo doesn't support `--config` yet, just use
            // RUSTFLAGS.
            env.insert("RUSTFLAGS".to_string(), serialized_rustflags);
        }
        (true, _) => {
            // If there's no RUSTFLAGS, and Cargo supports `--config`, use it.
            // The user might have some flags in their config.toml file(s), and
            // `--config target.*.rustflags` will append to it instead of overwriting it.
            // We use target RUSTFLAGS instead of e.g. build rustflags, because it has a higher
            // precedence. See https://github.com/Kobzol/cargo-pgo/issues/56 for more details.
            final_cargo_args.push("--config".to_string());

            // `cfg(all())` should match any target.
            let mut flags = String::from("target.'cfg(all())'.rustflags=[");
            for (index, flag) in rustflags.into_iter().enumerate() {
                if index > 0 {
                    flags.push(',');
                }
                flags.push_str(&format!("'{flag}'"));
            }
            flags.push(']');
            final_cargo_args.push(flags);
        }
    }

    let release_mode = match command {
        CargoCommand::Bench => ReleaseMode::NoRelease,
        _ => ReleaseMode::AddRelease,
    };

    // We need to add any new Cargo arguments to the beginning of `cargo_args`, because it could
    // end with `--`, in which case the added arguments would be sent to e.g. the executed binary
    // instead.
    final_cargo_args.extend(cargo_args);

    let mut child = cargo_command(command, final_cargo_args, env, release_mode)?;
    let stdout = child.stdout.take().unwrap();
    Ok(RunningCargo {
        child,
        message_iter: Message::parse_stream(BufReader::new(stdout)),
    })
}

/// Spawn `cargo` command in release mode with the provided env variables and Cargo arguments.
fn cargo_command(
    cargo_cmd: CargoCommand,
    cargo_args: Vec<String>,
    env: HashMap<String, String>,
    release_mode: ReleaseMode,
) -> anyhow::Result<Child> {
    let parsed_args = parse_cargo_args(cargo_args);

    let mut command = Command::new("cargo");
    command.args([
        cargo_cmd.to_str(),
        "--message-format",
        "json-diagnostic-rendered-ansi",
    ]);
    command.stdin(Stdio::inherit());
    command.stdout(Stdio::piped());
    command.stderr(Stdio::inherit());

    match release_mode {
        ReleaseMode::AddRelease => {
            if !parsed_args.contains_profile {
                command.arg("--release");
            }
        }
        ReleaseMode::NoRelease => {}
    }

    // --target is passed to avoid instrumenting build scripts
    // See https://doc.rust-lang.org/rustc/profile-guided-optimization.html#a-complete-cargo-workflow
    if !parsed_args.contains_target {
        let default_target = get_default_target().map_err(|error| {
            anyhow::anyhow!(
                "Unable to find default target triple for your platform: {:?}",
                error
            )
        })?;
        command.args(["--target", &default_target]);
    }

    for arg in parsed_args.filtered {
        command.arg(arg);
    }
    for (key, value) in env {
        command.env(key, value);
    }
    log::debug!("Executing cargo command: {:?}", command);
    Ok(command.spawn()?)
}

pub fn parse_cargo_args(cargo_args: Vec<String>) -> CargoArgs {
    let mut args = CargoArgs::default();

    let mut iterator = cargo_args.into_iter();
    while let Some(arg) = iterator.next() {
        match arg.as_str() {
            "--" => {
                // After this, the user program arguments start, we should ignore these
                args.filtered.push("--".to_string());
                args.filtered.extend(iterator);
                break;
            }
            // Skip `--release`, we will pass it by ourselves.
            "--release" => {
                log::warn!(
                    "Do not pass `--release` manually, it will be added automatically by `cargo-pgo`"
                );
            }
            _ => {
                if get_key_value("--message-format", arg.as_str(), &mut iterator).is_some() {
                    // Skip `--message-format`, we need it to be JSON.
                    log::warn!(
                        "Do not pass `--message-format` manually, it will be added automatically by `cargo-pgo`"
                    );
                } else if let Some(value) = get_key_value("--target", arg.as_str(), &mut iterator) {
                    // Check if `--target` was passed
                    args.contains_target = true;
                    args.filtered.push("--target".to_string());
                    if let Some(value) = value {
                        args.filtered.push(value);
                    }
                } else if let Some(value) = get_key_value("--profile", arg.as_str(), &mut iterator)
                {
                    // Check if `--profile` was passed
                    args.contains_profile = true;
                    args.filtered.push("--profile".to_string());
                    if let Some(value) = value {
                        args.filtered.push(value);
                    }
                } else if let Some(value) =
                    get_key_value("--target-dir", arg.as_str(), &mut iterator)
                {
                    // Extract `--target-dir`
                    args.target_dir = value.clone().map(PathBuf::from);
                    args.filtered.push("--target-dir".to_string());
                    if let Some(value) = value {
                        args.filtered.push(value);
                    }
                } else {
                    args.filtered.push(arg);
                }
            }
        }
    }
    args
}

/// Parses a `--key=<value>` or `--key <value>` key/value CLI argument pair.
fn get_key_value<Iter: Iterator<Item = String>>(
    key: &str,
    arg: &str,
    iter: &mut Iter,
) -> Option<Option<String>> {
    // A different argument was passed, nothing to be seen here
    if !arg.starts_with(key) {
        return None;
    }
    // --key was passed exactly, we should extract the value from the following argument
    if arg == key {
        let value = iter.next();
        return Some(value);
    }

    // --key<suffix> was passed, let's try to split it into --key=value
    if let Some((parsed_key, value)) = arg.split_once('=') {
        // if --keyfoo=value was passed, ignore it
        if parsed_key == key {
            return Some(Some(value.to_string()));
        }
    }

    None
}

pub fn handle_metadata_message(message: Message) {
    let stdout = std::io::stdout();
    let mut stdout = stdout.lock();
    write_metadata_message(&mut stdout, message);
    stdout.flush().unwrap();
}

fn write_metadata_message<W: Write>(mut stream: W, message: Message) {
    match message {
        Message::TextLine(line) => {
            log::debug!("TextLine {}", line);
            writeln!(stream, "{line}").unwrap();
        }
        Message::CompilerMessage(message) => {
            log::debug!("CompilerMessage {}", message);
            write!(
                stream,
                "{}",
                message.message.rendered.unwrap_or(message.message.message)
            )
            .unwrap();
        }
        _ => {
            log::debug!("Metadata output: {:?}", message);
        }
    }
}

/// Returns a user-friendly name of an artifact kind.
pub fn get_artifact_kind(artifact: &Artifact) -> &str {
    for kind in &artifact.target.kind {
        match kind {
            TargetKind::Bin => {
                return "binary";
            }
            TargetKind::Bench => {
                return "benchmark";
            }
            TargetKind::Example => {
                return "example";
            }
            _ => {}
        }
    }
    "artifact"
}

#[cfg(test)]
mod tests {
    use crate::build::{get_key_value, parse_cargo_args};
    use std::path::PathBuf;

    #[test]
    fn parse_cargo_args_filter_release() {
        let args = parse_cargo_args(vec![
            "foo".to_string(),
            "--release".to_string(),
            "--bar".to_string(),
        ]);
        assert_eq!(args.filtered, vec!["foo".to_string(), "--bar".to_string()]);
    }

    #[test]
    fn parse_cargo_args_filter_message_format() {
        let args = parse_cargo_args(vec![
            "foo".to_string(),
            "--message-format".to_string(),
            "json".to_string(),
            "bar".to_string(),
        ]);
        assert_eq!(args.filtered, vec!["foo".to_string(), "bar".to_string()]);
    }

    #[test]
    fn parse_cargo_args_filter_message_format_equals() {
        let args = parse_cargo_args(vec![
            "foo".to_string(),
            "--message-format=json".to_string(),
            "bar".to_string(),
        ]);
        assert_eq!(args.filtered, vec!["foo".to_string(), "bar".to_string()]);
    }

    #[test]
    fn parse_cargo_args_find_target() {
        let args = parse_cargo_args(vec![
            "--target".to_string(),
            "x64".to_string(),
            "bar".to_string(),
        ]);
        assert_eq!(
            args.filtered,
            vec!["--target".to_string(), "x64".to_string(), "bar".to_string()]
        );
        assert!(args.contains_target);
    }

    #[test]
    fn parse_cargo_args_find_target_equals() {
        let args = parse_cargo_args(vec!["--target=x64".to_string(), "bar".to_string()]);
        assert_eq!(
            args.filtered,
            vec!["--target".to_string(), "x64".to_string(), "bar".to_string()]
        );
        assert!(args.contains_target);
    }

    #[test]
    fn parse_cargo_args_target_dir() {
        let args = parse_cargo_args(vec![
            "--target-dir".to_string(),
            "/tmp/foo".to_string(),
            "bar".to_string(),
        ]);
        assert_eq!(
            args.filtered,
            vec![
                "--target-dir".to_string(),
                "/tmp/foo".to_string(),
                "bar".to_string()
            ]
        );
        assert_eq!(args.target_dir, Some(PathBuf::from("/tmp/foo")));
    }

    #[test]
    fn parse_cargo_args_target_dir_equals() {
        let args = parse_cargo_args(vec!["--target-dir=/tmp/foo".to_string(), "bar".to_string()]);
        assert_eq!(
            args.filtered,
            vec![
                "--target-dir".to_string(),
                "/tmp/foo".to_string(),
                "bar".to_string()
            ]
        );
        assert_eq!(args.target_dir, Some(PathBuf::from("/tmp/foo")));
    }

    #[test]
    fn parse_cargo_args_profile() {
        let args = parse_cargo_args(vec!["--profile".to_string(), "dev".to_string()]);
        assert_eq!(
            args.filtered,
            vec!["--profile".to_string(), "dev".to_string(),]
        );
        assert!(args.contains_profile);
    }

    #[test]
    fn parse_cargo_args_respect_user_args() {
        let args = parse_cargo_args(vec![
            "-v".to_string(),
            "--".to_string(),
            "--release".to_string(),
            "--profile".to_string(),
            "dev".to_string(),
        ]);
        assert_eq!(
            args.filtered,
            vec![
                "-v".to_string(),
                "--".to_string(),
                "--release".to_string(),
                "--profile".to_string(),
                "dev".to_string()
            ]
        );
        assert!(!args.contains_profile);
    }

    #[test]
    fn get_key_value_wrong_key() {
        assert_eq!(
            get_key_value("--foo", "--bar", &mut std::iter::empty()),
            None
        );
    }

    #[test]
    fn get_key_value_exact_key_missing_value() {
        assert_eq!(
            get_key_value("--foo", "--foo", &mut std::iter::empty()),
            Some(None)
        );
    }

    #[test]
    fn get_key_value_exact_key_value() {
        assert_eq!(
            get_key_value("--foo", "--foo", &mut vec!["bar".to_string()].into_iter()),
            Some(Some("bar".to_string()))
        );
    }

    #[test]
    fn get_key_value_equals_wrong_prefix() {
        assert_eq!(
            get_key_value("--foo", "--foox=bar", &mut std::iter::empty()),
            None
        );
    }

    #[test]
    fn get_key_value_equals() {
        assert_eq!(
            get_key_value("--foo", "--foo=bar", &mut std::iter::empty()),
            Some(Some("bar".to_string()))
        );
    }
}