cargo-build-rx 0.1.0

Compile-time diagnostic and prescription tool for Rust projects
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65

use std::collections::HashMap;

use crate::checks::Check;
use crate::context::ProjectContext;
use crate::finding::*;

pub struct DuplicatesCheck;

/// Crates where duplicates are especially costly.
const HIGH_IMPACT_CRATES: &[&str] = &["syn", "serde", "tokio", "rand", "itertools", "http"];

impl Check for DuplicatesCheck {
    fn name(&self) -> &'static str {
        "duplicates"
    }

    fn run(&self, ctx: &ProjectContext) -> Vec<Finding> {
        let mut findings = Vec::new();

        // Group packages by name, track distinct major.minor versions
        let mut versions_by_name: HashMap<&str, Vec<&str>> = HashMap::new();
        for package in &ctx.metadata.packages {
            versions_by_name
                .entry(package.name.as_str())
                .or_default()
                .push(package.version.to_string().leak());
        }

        for (name, versions) in &versions_by_name {
            if versions.len() <= 1 {
                continue;
            }

            // Deduplicate — cargo metadata can list the same version twice in workspaces
            let mut unique: Vec<&str> = versions.clone();
            unique.sort();
            unique.dedup();
            if unique.len() <= 1 {
                continue;
            }

            let is_high_impact = HIGH_IMPACT_CRATES.contains(name);
            let (severity, impact) = if is_high_impact {
                (Severity::Warn, Impact::Medium)
            } else {
                (Severity::Info, Impact::Low)
            };

            let version_list = unique.join(", ");
            findings.push(Finding {
                severity,
                category: Category::Dependencies,
                impact,
                title: format!("{name} present in {count} incompatible versions", count = unique.len()),
                description: format!("Versions: {version_list}. Each distinct version is compiled separately."),
                fix: Some(Fix {
                    description: format!("Try updating dependents to unify on one version of {name}"),
                    kind: FixKind::ShellCommand(format!("cargo update -p {name}")),
                }),
            });
        }

        findings
    }
}