capo-cli 0.4.0

Capo — a Rust-native coding agent CLI.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
//! v0.4 Phase B — `--rpc` server harness: the permission resolver bridge
//! (§5.3 of the v0.4 design spec) and the stdin/stdout JSONL plumbing
//! around `forward_commands`.

use std::collections::HashMap;
use std::io;
use std::sync::{Arc, Mutex};

use capo_agent::permissions::{Decision, SessionCache};
use capo_agent::{Command, PermissionChoice, UiEvent};
use tokio::io::{AsyncBufReadExt, AsyncRead, AsyncWrite, AsyncWriteExt, BufReader};
use tokio::sync::{mpsc, oneshot};

/// Maps an in-process `tokio::oneshot::Sender<Decision>` to an `id`-keyed
/// request/response over the JSONL wire.
///
/// `--rpc` clients see `{"type":"permission_requested","payload":{…},"id":"…"}`
/// and reply with `{"type":"resolve_permission","id":"…","choice":"…"}` —
/// the bridge unblocks the awaiting tool call by fulfilling the held resolver.
struct PendingPermission {
    tool: String,
    args: serde_json::Value,
    resolver: oneshot::Sender<Decision>,
}

pub struct PermissionBridge {
    pending: Mutex<HashMap<String, PendingPermission>>,
    session_cache: Option<Arc<SessionCache>>,
}

impl PermissionBridge {
    pub fn new() -> Self {
        Self {
            pending: Mutex::new(HashMap::new()),
            session_cache: None,
        }
    }

    pub fn with_session_cache(session_cache: Arc<SessionCache>) -> Self {
        Self {
            pending: Mutex::new(HashMap::new()),
            session_cache: Some(session_cache),
        }
    }

    /// Process one `UiEvent` on the way to stdout. For
    /// `PermissionRequested`, capture the resolver under a fresh id and
    /// return a wire-form `permission_requested` JSON line (no resolver,
    /// `id` injected). For every other event, encode it normally via
    /// `protocol::encode_event`.
    pub fn intercept(&self, event: UiEvent) -> String {
        if let UiEvent::PermissionRequested {
            tool,
            args,
            resolver,
        } = event
        {
            let id = capo_agent::SessionId::new().into_string();
            // Stash the resolver — we'll fulfill it from `resolve()` later.
            if let Ok(mut pending) = self.pending.lock() {
                pending.insert(
                    id.clone(),
                    PendingPermission {
                        tool: tool.clone(),
                        args: args.clone(),
                        resolver,
                    },
                );
            }
            // Build the wire form by hand (the in-process event has no `id`).
            let value = serde_json::json!({
                "type": "permission_requested",
                "id": id,
                "payload": { "tool": tool, "args": args },
            });
            serde_json::to_string(&value).unwrap_or_else(|e| {
                format!(r#"{{"type":"error","payload":"permission encode failed: {e}"}}"#)
            })
        } else {
            capo_agent::protocol::encode_event(&event)
        }
    }

    /// Fulfill the resolver registered under `id`. No-op if `id` is
    /// unknown (e.g. duplicate response, or the response arrived after
    /// the resolver was dropped).
    pub fn resolve(&self, id: &str, choice: PermissionChoice) {
        let pending = match self.pending.lock() {
            Ok(mut pending) => pending.remove(id),
            Err(_) => return,
        };
        if let Some(pending) = pending {
            let decision = match choice {
                PermissionChoice::AllowOnce | PermissionChoice::AllowSession => Decision::Allowed,
                PermissionChoice::Deny => Decision::Denied("denied by client".into()),
            };
            if matches!(choice, PermissionChoice::AllowSession) {
                if let Some(cache) = &self.session_cache {
                    let key = SessionCache::key(&pending.tool, &pending.args);
                    cache.insert(key, Decision::Allowed);
                }
            }
            // Receiver may already be dropped (turn cancelled); ignore.
            let _ = pending.resolver.send(decision);
        }
    }
}

impl Default for PermissionBridge {
    fn default() -> Self {
        Self::new()
    }
}

/// Drain `ui_rx`, route each event through the bridge, write the JSONL
/// line + `\n` to `out`, flush. Exits cleanly when `ui_rx` closes.
async fn write_event_line<W>(
    out: &mut W,
    bridge: &PermissionBridge,
    event: UiEvent,
) -> io::Result<()>
where
    W: AsyncWrite + Unpin,
{
    let line = bridge.intercept(event);
    out.write_all(line.as_bytes()).await?;
    out.write_all(b"\n").await?;
    out.flush().await
}

#[cfg_attr(not(test), allow(dead_code))]
pub async fn writer_task<W>(
    mut out: W,
    mut ui_rx: mpsc::Receiver<UiEvent>,
    bridge: Arc<PermissionBridge>,
) -> io::Result<()>
where
    W: AsyncWrite + Unpin,
{
    while let Some(event) = ui_rx.recv().await {
        write_event_line(&mut out, &bridge, event).await?;
    }
    Ok(())
}

/// Drain `ui_rx` until either the channel closes or `shutdown` fires. On
/// shutdown, consume all events already queued before returning; callers use
/// this after the command forwarder has drained the active turn but the App
/// still owns an idle permission-prompt sender.
pub async fn writer_task_until_shutdown<W>(
    mut out: W,
    mut ui_rx: mpsc::Receiver<UiEvent>,
    bridge: Arc<PermissionBridge>,
    mut shutdown: oneshot::Receiver<()>,
) -> io::Result<()>
where
    W: AsyncWrite + Unpin,
{
    loop {
        tokio::select! {
            event = ui_rx.recv() => {
                let Some(event) = event else {
                    return Ok(());
                };
                write_event_line(&mut out, &bridge, event).await?;
            }
            _ = &mut shutdown => {
                while let Ok(event) = ui_rx.try_recv() {
                    write_event_line(&mut out, &bridge, event).await?;
                }
                return Ok(());
            }
        }
    }
}

/// Read JSONL from `input` line by line. `resolve_permission` lines go to
/// the bridge; everything else is decoded as a `Command` and pushed to
/// `cmd_tx`. Bad lines emit a `UiEvent::Error` and the loop continues.
/// Exits cleanly on EOF.
pub async fn reader_task<R>(
    mut input: BufReader<R>,
    cmd_tx: mpsc::Sender<Command>,
    ui_tx: mpsc::Sender<UiEvent>,
    bridge: Arc<PermissionBridge>,
) -> io::Result<()>
where
    R: AsyncRead + Unpin,
{
    let mut line = String::new();
    loop {
        line.clear();
        let n = input.read_line(&mut line).await?;
        if n == 0 {
            let _ = cmd_tx.send(Command::Quit).await;
            return Ok(());
        }
        let trimmed = line.trim_end_matches(['\r', '\n']);
        if trimmed.is_empty() {
            continue;
        }
        // Peek the `type` to decide: bridge or Command decode.
        let value: serde_json::Value = match serde_json::from_str(trimmed) {
            Ok(v) => v,
            Err(e) => {
                let _ = ui_tx
                    .send(UiEvent::Error(format!("invalid json: {e}")))
                    .await;
                continue;
            }
        };
        let type_tag = value.get("type").and_then(|v| v.as_str()).unwrap_or("");
        if type_tag == "resolve_permission" {
            let id = value.get("id").and_then(|v| v.as_str()).unwrap_or("");
            let choice = match value.get("choice").and_then(|v| v.as_str()).unwrap_or("") {
                "allow_once" => PermissionChoice::AllowOnce,
                "allow_session" => PermissionChoice::AllowSession,
                "deny" => PermissionChoice::Deny,
                other => {
                    let _ = ui_tx
                        .send(UiEvent::Error(format!(
                            "resolve_permission: unknown choice '{other}'"
                        )))
                        .await;
                    continue;
                }
            };
            if id.is_empty() {
                let _ = ui_tx
                    .send(UiEvent::Error("resolve_permission: missing id".into()))
                    .await;
                continue;
            }
            bridge.resolve(id, choice);
            continue;
        }
        match capo_agent::protocol::decode_command(trimmed) {
            Ok(cmd) => {
                let is_quit = matches!(cmd, Command::Quit);
                if cmd_tx.send(cmd).await.is_err() {
                    // Forwarder gone — exit cleanly, don't error.
                    return Ok(());
                }
                if is_quit {
                    return Ok(());
                }
                // Give the forwarder a chance to observe turn-starting commands
                // before a following line (notably `quit`) is routed.
                tokio::task::yield_now().await;
            }
            Err(e) => {
                let _ = ui_tx
                    .send(UiEvent::Error(format!("decode_command: {e}")))
                    .await;
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use std::sync::Arc;

    use super::*;
    use tokio::io::{AsyncReadExt, AsyncWriteExt, BufReader};
    use tokio::sync::mpsc;

    #[tokio::test]
    async fn intercept_passes_through_non_permission_events() {
        let bridge = PermissionBridge::new();
        let line = bridge.intercept(UiEvent::AgentThinking);
        assert_eq!(line, r#"{"type":"agent_thinking"}"#);
    }

    #[tokio::test]
    async fn intercept_emits_id_and_resolve_fulfills_the_resolver() {
        let bridge = PermissionBridge::new();
        let (tx, rx) = oneshot::channel::<Decision>();
        let event = UiEvent::PermissionRequested {
            tool: "bash".into(),
            args: serde_json::json!({"command": "rm -rf /tmp/x"}),
            resolver: tx,
        };

        let line = bridge.intercept(event);
        let value: serde_json::Value =
            serde_json::from_str(&line).expect("intercept line should be JSON");
        assert_eq!(value["type"], "permission_requested");
        let id = value["id"].as_str().expect("id present").to_string();
        assert_eq!(value["payload"]["tool"], "bash");
        assert!(value.get("resolver").is_none(), "resolver leaked: {line}");

        bridge.resolve(&id, PermissionChoice::AllowOnce);
        let decision = tokio::time::timeout(std::time::Duration::from_millis(100), rx)
            .await
            .expect("resolver not fulfilled")
            .expect("resolver dropped");
        assert!(matches!(decision, Decision::Allowed));
    }

    #[tokio::test]
    async fn resolve_with_unknown_id_is_a_safe_noop() {
        let bridge = PermissionBridge::new();
        // Does not panic, does not error.
        bridge.resolve("no-such-id", PermissionChoice::Deny);
    }

    #[tokio::test]
    async fn deny_choice_maps_to_decision_denied() {
        let bridge = PermissionBridge::new();
        let (tx, rx) = oneshot::channel::<Decision>();
        let line = bridge.intercept(UiEvent::PermissionRequested {
            tool: "write".into(),
            args: serde_json::json!({"path": "/etc/x"}),
            resolver: tx,
        });
        let id = serde_json::from_str::<serde_json::Value>(&line).expect("json")["id"]
            .as_str()
            .expect("id")
            .to_string();
        bridge.resolve(&id, PermissionChoice::Deny);
        let decision = rx.await.expect("resolver dropped");
        assert!(matches!(decision, Decision::Denied(_)));
    }

    #[tokio::test]
    async fn allow_session_choice_updates_session_cache_when_configured() {
        let cache = Arc::new(capo_agent::permissions::SessionCache::new());
        let bridge = PermissionBridge::with_session_cache(Arc::clone(&cache));
        let args = serde_json::json!({"command": "ls /etc"});
        let (tx, rx) = oneshot::channel::<Decision>();
        let line = bridge.intercept(UiEvent::PermissionRequested {
            tool: "bash".into(),
            args: args.clone(),
            resolver: tx,
        });
        let id = serde_json::from_str::<serde_json::Value>(&line).expect("json")["id"]
            .as_str()
            .expect("id")
            .to_string();

        bridge.resolve(&id, PermissionChoice::AllowSession);
        let decision = rx.await.expect("resolver dropped");
        assert!(matches!(decision, Decision::Allowed));
        let key = capo_agent::permissions::SessionCache::key("bash", &args);
        assert!(matches!(cache.get(&key), Some(Decision::Allowed)));
    }

    #[tokio::test]
    async fn writer_task_writes_a_jsonl_line_per_event_via_the_bridge() {
        let bridge = Arc::new(PermissionBridge::new());
        let (ui_tx, ui_rx) = mpsc::channel::<UiEvent>(8);

        let (mut client_read, server_write) = tokio::io::duplex(4096);
        let writer = tokio::spawn(writer_task(server_write, ui_rx, Arc::clone(&bridge)));

        ui_tx.send(UiEvent::AgentThinking).await.expect("send");
        ui_tx
            .send(UiEvent::AgentTextDelta("hi".into()))
            .await
            .expect("send");
        drop(ui_tx);
        writer
            .await
            .expect("writer task panicked")
            .expect("writer io");

        let mut buf = String::new();
        client_read.read_to_string(&mut buf).await.expect("read");
        let lines: Vec<&str> = buf.lines().collect();
        assert_eq!(lines.len(), 2);
        assert_eq!(lines[0], r#"{"type":"agent_thinking"}"#);
        assert!(lines[1].contains(r#""type":"agent_text_delta""#));
    }

    #[tokio::test]
    async fn reader_task_exits_after_forwarding_quit_even_if_stdin_stays_open() {
        let bridge = Arc::new(PermissionBridge::new());
        let (cmd_tx, mut cmd_rx) = mpsc::channel::<capo_agent::Command>(4);
        let (ui_tx, _ui_rx) = mpsc::channel::<UiEvent>(4);
        let (mut client_write, server_read) = tokio::io::duplex(4096);
        let reader = tokio::spawn(reader_task(
            BufReader::new(server_read),
            cmd_tx,
            ui_tx,
            Arc::clone(&bridge),
        ));

        client_write
            .write_all(b"{\"type\":\"quit\"}\n")
            .await
            .expect("write");

        tokio::time::timeout(std::time::Duration::from_millis(200), reader)
            .await
            .expect("reader did not exit after quit")
            .expect("reader panicked")
            .expect("reader io");
        assert!(matches!(
            cmd_rx.recv().await,
            Some(capo_agent::Command::Quit)
        ));
    }

    #[tokio::test]
    async fn reader_task_decodes_commands_to_the_command_channel() {
        let bridge = Arc::new(PermissionBridge::new());
        let (cmd_tx, mut cmd_rx) = mpsc::channel::<capo_agent::Command>(8);
        let (ui_tx, mut ui_rx) = mpsc::channel::<UiEvent>(8);

        let (client_write, server_read) = tokio::io::duplex(4096);
        let reader = tokio::spawn(reader_task(
            BufReader::new(server_read),
            cmd_tx,
            ui_tx,
            Arc::clone(&bridge),
        ));

        let mut client_write = client_write;
        client_write
            .write_all(b"{\"type\":\"cancel_agent\"}\n")
            .await
            .expect("write");
        client_write
            .write_all(b"{\"type\":\"send_user_message\",\"payload\":\"hi\"}\n")
            .await
            .expect("write");
        drop(client_write);
        reader
            .await
            .expect("reader task panicked")
            .expect("reader io");

        assert!(matches!(
            cmd_rx.recv().await,
            Some(capo_agent::Command::CancelAgent)
        ));
        match cmd_rx.recv().await {
            Some(capo_agent::Command::SendUserMessage(text)) => assert_eq!(text, "hi"),
            other => panic!("expected SendUserMessage, got {other:?}"),
        }
        // No errors emitted for valid input.
        assert!(ui_rx.try_recv().is_err());
    }

    #[tokio::test]
    async fn reader_task_routes_resolve_permission_to_the_bridge() {
        let bridge = Arc::new(PermissionBridge::new());
        // Pre-arm the bridge by intercepting a synthetic event.
        let (resolver_tx, resolver_rx) = oneshot::channel::<Decision>();
        let line = bridge.intercept(UiEvent::PermissionRequested {
            tool: "bash".into(),
            args: serde_json::json!({"command": "ls"}),
            resolver: resolver_tx,
        });
        let id = serde_json::from_str::<serde_json::Value>(&line).expect("json")["id"]
            .as_str()
            .expect("id")
            .to_string();

        let (cmd_tx, mut cmd_rx) = mpsc::channel::<capo_agent::Command>(4);
        let (ui_tx, _ui_rx) = mpsc::channel::<UiEvent>(4);
        let (client_write, server_read) = tokio::io::duplex(4096);
        let reader = tokio::spawn(reader_task(
            BufReader::new(server_read),
            cmd_tx,
            ui_tx,
            Arc::clone(&bridge),
        ));

        let mut client_write = client_write;
        let payload = format!(
            "{{\"type\":\"resolve_permission\",\"id\":\"{id}\",\"choice\":\"allow_once\"}}\n"
        );
        client_write
            .write_all(payload.as_bytes())
            .await
            .expect("write");

        let decision = tokio::time::timeout(std::time::Duration::from_millis(100), resolver_rx)
            .await
            .expect("resolver not fulfilled")
            .expect("resolver dropped");
        assert!(matches!(decision, Decision::Allowed));
        // resolve_permission itself must NOT produce a Command.
        assert!(cmd_rx.try_recv().is_err());

        drop(client_write);
        reader.await.expect("reader panicked").expect("reader io");
        // EOF is independently treated as quit.
        assert!(matches!(cmd_rx.try_recv(), Ok(Command::Quit)));
    }

    #[tokio::test]
    async fn reader_task_emits_error_event_on_bad_line_and_keeps_serving() {
        let bridge = Arc::new(PermissionBridge::new());
        let (cmd_tx, mut cmd_rx) = mpsc::channel::<capo_agent::Command>(4);
        let (ui_tx, mut ui_rx) = mpsc::channel::<UiEvent>(4);
        let (client_write, server_read) = tokio::io::duplex(4096);
        let reader = tokio::spawn(reader_task(
            BufReader::new(server_read),
            cmd_tx,
            ui_tx,
            Arc::clone(&bridge),
        ));

        let mut client_write = client_write;
        client_write.write_all(b"not json\n").await.expect("write");
        client_write
            .write_all(b"{\"type\":\"cancel_agent\"}\n")
            .await
            .expect("write");
        drop(client_write);
        reader.await.expect("reader panicked").expect("reader io");

        // First line errored; second line still processed.
        let evt = ui_rx.recv().await.expect("error event");
        assert!(matches!(evt, UiEvent::Error(_)), "got {evt:?}");
        assert!(matches!(
            cmd_rx.recv().await,
            Some(capo_agent::Command::CancelAgent)
        ));
    }
}