canic-core 0.28.3

Canic — a canister orchestration and management toolkit for the Internet Computer
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
use super::proof_store::AudienceBindingFailureStage;
use super::*;
use crate::cdk::types::Principal;
use crate::config::schema::{CanisterKind, DelegatedAuthCanisterConfig};
use crate::dto::auth::{
    DelegatedToken, DelegatedTokenClaims, DelegationAudience, DelegationCert, DelegationProof,
    DelegationProofInstallIntent, DelegationVerifierProofPushRequest,
};
use crate::dto::error::ErrorCode;
use crate::ops::auth::{DelegatedTokenOpsError, DelegationExpiryError, DelegationValidationError};
use crate::ops::storage::registry::subnet::SubnetRegistryOps;
use crate::storage::stable::env::{Env, EnvRecord};
use crate::test::config::ConfigTestBuilder;
use crate::{InternalErrorOrigin, ids::SubnetRole};
use futures::executor::block_on;
use std::cell::Cell;

#[test]
fn verify_role_attestation_with_single_refresh_accepts_without_refresh() {
    let verify_calls = Cell::new(0usize);
    let refresh_calls = Cell::new(0usize);

    let result = block_on(verify_flow::verify_role_attestation_with_single_refresh(
        || {
            verify_calls.set(verify_calls.get() + 1);
            Ok(())
        },
        || {
            refresh_calls.set(refresh_calls.get() + 1);
            std::future::ready(Ok(()))
        },
    ));

    assert!(result.is_ok());
    assert_eq!(verify_calls.get(), 1, "verify must run exactly once");
    assert_eq!(refresh_calls.get(), 0, "refresh must not run");
}

#[test]
fn verify_role_attestation_with_single_refresh_retries_once_on_unknown_key() {
    let verify_calls = Cell::new(0usize);
    let refresh_calls = Cell::new(0usize);

    let result = block_on(verify_flow::verify_role_attestation_with_single_refresh(
        || {
            let attempt = verify_calls.get();
            verify_calls.set(attempt + 1);
            if attempt == 0 {
                Err(DelegationValidationError::AttestationUnknownKeyId { key_id: 7 }.into())
            } else {
                Ok(())
            }
        },
        || {
            refresh_calls.set(refresh_calls.get() + 1);
            std::future::ready(Ok(()))
        },
    ));

    assert!(result.is_ok());
    assert_eq!(verify_calls.get(), 2, "verify must run exactly twice");
    assert_eq!(refresh_calls.get(), 1, "refresh must run exactly once");
}

#[test]
fn verify_role_attestation_with_single_refresh_fails_closed_on_refresh_error() {
    let verify_calls = Cell::new(0usize);
    let refresh_calls = Cell::new(0usize);

    let result = block_on(verify_flow::verify_role_attestation_with_single_refresh(
        || {
            verify_calls.set(verify_calls.get() + 1);
            Err(DelegationValidationError::AttestationUnknownKeyId { key_id: 9 }.into())
        },
        || {
            refresh_calls.set(refresh_calls.get() + 1);
            std::future::ready(Err(crate::InternalError::infra(
                InternalErrorOrigin::Infra,
                "refresh failed",
            )))
        },
    ));

    match result {
        Err(verify_flow::RoleAttestationVerifyFlowError::Refresh {
            trigger:
                DelegatedTokenOpsError::Validation(DelegationValidationError::AttestationUnknownKeyId {
                    key_id,
                }),
            ..
        }) => assert_eq!(key_id, 9),
        other => panic!("expected refresh failure for unknown key, got: {other:?}"),
    }

    assert_eq!(
        verify_calls.get(),
        1,
        "verify must not retry after refresh failure"
    );
    assert_eq!(refresh_calls.get(), 1, "refresh must run once");
}

#[test]
fn verify_role_attestation_with_single_refresh_does_not_refresh_on_non_unknown_error() {
    let verify_calls = Cell::new(0usize);
    let refresh_calls = Cell::new(0usize);

    let result = block_on(verify_flow::verify_role_attestation_with_single_refresh(
        || {
            verify_calls.set(verify_calls.get() + 1);
            Err(DelegationExpiryError::AttestationEpochRejected {
                epoch: 1,
                min_accepted_epoch: 2,
            }
            .into())
        },
        || {
            refresh_calls.set(refresh_calls.get() + 1);
            std::future::ready(Ok(()))
        },
    ));

    match result {
        Err(verify_flow::RoleAttestationVerifyFlowError::Initial(
            DelegatedTokenOpsError::Expiry(DelegationExpiryError::AttestationEpochRejected {
                epoch,
                min_accepted_epoch,
            }),
        )) => {
            assert_eq!(epoch, 1);
            assert_eq!(min_accepted_epoch, 2);
        }
        other => panic!("expected initial epoch rejection, got: {other:?}"),
    }

    assert_eq!(verify_calls.get(), 1, "verify must run once");
    assert_eq!(refresh_calls.get(), 0, "refresh must not run");
}

#[test]
fn verify_role_attestation_with_single_refresh_only_attempts_one_refresh() {
    let verify_calls = Cell::new(0usize);
    let refresh_calls = Cell::new(0usize);

    let result = block_on(verify_flow::verify_role_attestation_with_single_refresh(
        || {
            let attempt = verify_calls.get();
            verify_calls.set(attempt + 1);
            if attempt == 0 {
                Err(DelegationValidationError::AttestationUnknownKeyId { key_id: 5 }.into())
            } else {
                Err(DelegationValidationError::AttestationUnknownKeyId { key_id: 6 }.into())
            }
        },
        || {
            refresh_calls.set(refresh_calls.get() + 1);
            std::future::ready(Ok(()))
        },
    ));

    match result {
        Err(verify_flow::RoleAttestationVerifyFlowError::PostRefresh(
            DelegatedTokenOpsError::Validation(
                DelegationValidationError::AttestationUnknownKeyId { key_id },
            ),
        )) => assert_eq!(key_id, 6),
        other => panic!("expected post-refresh unknown-key rejection, got: {other:?}"),
    }

    assert_eq!(verify_calls.get(), 2, "verify must run exactly twice");
    assert_eq!(refresh_calls.get(), 1, "refresh must run exactly once");
}

#[test]
fn resolve_min_accepted_epoch_prefers_explicit_argument() {
    assert_eq!(verify_flow::resolve_min_accepted_epoch(7, Some(3)), 7);
    assert_eq!(verify_flow::resolve_min_accepted_epoch(5, None), 5);
}

#[test]
fn resolve_min_accepted_epoch_falls_back_to_config_or_zero() {
    assert_eq!(verify_flow::resolve_min_accepted_epoch(0, Some(4)), 4);
    assert_eq!(verify_flow::resolve_min_accepted_epoch(0, None), 0);
}

fn p(id: u8) -> Principal {
    Principal::from_slice(&[id; 29])
}

struct EnvRestore(EnvRecord);

impl Drop for EnvRestore {
    fn drop(&mut self) {
        Env::import(self.0.clone());
    }
}

fn verifier_cfg() -> crate::config::schema::CanisterConfig {
    let mut cfg = ConfigTestBuilder::canister_config(CanisterKind::Singleton);
    cfg.delegated_auth = DelegatedAuthCanisterConfig {
        signer: false,
        verifier: true,
    };
    cfg
}

fn install_proof_audience_test_context() -> EnvRestore {
    let _config = ConfigTestBuilder::new()
        .with_prime_canister(
            CanisterRole::ROOT,
            ConfigTestBuilder::canister_config(CanisterKind::Root),
        )
        .with_prime_canister(CanisterRole::new("project_hub"), verifier_cfg())
        .with_prime_canister(CanisterRole::new("admin"), verifier_cfg())
        .install();

    let root_pid = p(1);
    if SubnetRegistryOps::get(root_pid).is_none() {
        SubnetRegistryOps::register_root(root_pid, 1);
    }
    for (pid, role) in [
        (p(3), CanisterRole::new("project_hub")),
        (p(4), CanisterRole::new("project_hub")),
        (p(9), CanisterRole::new("admin")),
    ] {
        if SubnetRegistryOps::get(pid).is_none() {
            SubnetRegistryOps::register_unchecked(
                pid,
                &role,
                root_pid,
                vec![],
                u64::from(pid.as_slice()[0]),
            )
            .expect("register verifier test canister");
        }
    }

    let original = Env::export();
    Env::import(EnvRecord {
        root_pid: Some(root_pid),
        subnet_role: Some(SubnetRole::PRIME),
        canister_role: Some(CanisterRole::ROOT),
        ..EnvRecord::default()
    });
    EnvRestore(original)
}

fn sample_claims() -> DelegatedTokenClaims {
    DelegatedTokenClaims {
        sub: p(9),
        shard_pid: p(2),
        scopes: vec!["verify".to_string()],
        aud: DelegationAudience::Roles(vec![CanisterRole::new("app")]),
        iat: 100,
        exp: 120,
        ext: None,
    }
}

fn sample_proof() -> DelegationProof {
    DelegationProof {
        cert: DelegationCert {
            root_pid: p(1),
            shard_pid: p(2),
            issued_at: 90,
            expires_at: 130,
            scopes: vec!["verify".to_string(), "read".to_string()],
            aud: DelegationAudience::Roles(vec![
                CanisterRole::new("app"),
                CanisterRole::new("api"),
                CanisterRole::new("project_hub"),
            ]),
        },
        cert_sig: vec![1, 2, 3],
    }
}

fn sample_token() -> DelegatedToken {
    DelegatedToken {
        claims: sample_claims(),
        proof: sample_proof(),
        token_sig: vec![4, 5, 6],
    }
}

#[test]
fn canonicalize_claims_for_proof_rebases_to_fresh_proof_window() {
    let claims = sample_claims();
    let proof = DelegationProof {
        cert: DelegationCert {
            issued_at: 101,
            expires_at: 121,
            ..sample_proof().cert
        },
        ..sample_proof()
    };

    let canonical = DelegationApi::canonicalize_claims_for_proof(claims, &proof);
    assert_eq!(canonical.iat, 101);
    assert_eq!(canonical.exp, 121);
}

#[test]
fn canonicalize_claims_for_proof_keeps_valid_existing_window() {
    let claims = sample_claims();
    let proof = sample_proof();

    let canonical = DelegationApi::canonicalize_claims_for_proof(claims.clone(), &proof);
    assert_eq!(canonical.sub, claims.sub);
    assert_eq!(canonical.shard_pid, claims.shard_pid);
    assert_eq!(canonical.scopes, claims.scopes);
    assert_eq!(canonical.aud, claims.aud);
    assert_eq!(canonical.iat, claims.iat);
    assert_eq!(canonical.exp, claims.exp);
}

#[test]
fn normalize_audience_accepts_roles_and_dedupes() {
    let audience = DelegationApi::normalize_audience(DelegationAudience::Roles(vec![
        CanisterRole::new("app"),
        CanisterRole::new("api"),
        CanisterRole::new("app"),
    ]))
    .expect("role audience is valid");

    assert_eq!(
        audience,
        DelegationAudience::Roles(vec![CanisterRole::new("app"), CanisterRole::new("api")])
    );
}

#[test]
fn normalize_audience_accepts_any_registered_verifier() {
    let audience = DelegationApi::normalize_audience(DelegationAudience::Any)
        .expect("wildcard audience is valid");

    assert_eq!(audience, DelegationAudience::Any);
}

#[test]
fn normalize_audience_rejects_empty_role_list() {
    let err = DelegationApi::normalize_audience(DelegationAudience::Roles(Vec::new()))
        .expect_err("empty role audience must fail");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(
        err.message.contains("audience"),
        "expected audience message, got: {err:?}"
    );
}

#[test]
fn merge_audience_for_reissue_preserves_existing_order() {
    let merged = DelegationApi::merge_audience_for_reissue(
        DelegationAudience::Roles(vec![CanisterRole::new("app"), CanisterRole::new("api")]),
        DelegationAudience::Roles(vec![CanisterRole::new("api"), CanisterRole::new("admin")]),
    );

    assert_eq!(
        merged,
        DelegationAudience::Roles(vec![
            CanisterRole::new("app"),
            CanisterRole::new("api"),
            CanisterRole::new("admin")
        ])
    );
}

#[test]
fn reissue_claims_allowed_accepts_scope_subset_and_changed_ext() {
    let mut old_claims = sample_claims();
    old_claims.scopes = vec!["verify".to_string(), "read".to_string()];
    let mut replacement = old_claims.clone();
    replacement.aud = DelegationAudience::Roles(vec![CanisterRole::new("api")]);
    replacement.scopes = vec!["read".to_string()];
    replacement.ext = Some(vec![1, 2, 3]);

    DelegationApi::ensure_reissue_claims_allowed(&old_claims, &replacement)
        .expect("subset scope and app-owned ext replacement must be accepted");
}

#[test]
fn reissue_claims_reject_expiry_extension() {
    let old_claims = sample_claims();
    let mut replacement = old_claims.clone();
    replacement.exp = old_claims.exp + 1;

    let err = DelegationApi::ensure_reissue_claims_allowed(&old_claims, &replacement)
        .expect_err("default reissue must not renew the session");

    assert_eq!(err.code, ErrorCode::Forbidden);
    assert!(
        err.message.contains("expiry must not exceed"),
        "expected expiry cap message, got: {err:?}"
    );
}

#[test]
fn reissue_claims_reject_scope_expansion() {
    let old_claims = sample_claims();
    let mut replacement = old_claims.clone();
    replacement.scopes.push("admin".to_string());

    let err = DelegationApi::ensure_reissue_claims_allowed(&old_claims, &replacement)
        .expect_err("scope expansion must be rejected");

    assert_eq!(err.code, ErrorCode::Forbidden);
    assert!(
        err.message.contains("scopes must be a subset"),
        "expected scope subset message, got: {err:?}"
    );
}

#[test]
fn reissue_claims_reject_subject_change() {
    let old_claims = sample_claims();
    let mut replacement = old_claims.clone();
    replacement.sub = p(8);

    let err = DelegationApi::ensure_reissue_claims_allowed(&old_claims, &replacement)
        .expect_err("reissue must stay bound to the same subject");

    assert_eq!(err.code, ErrorCode::Forbidden);
    assert!(
        err.message.contains("subject"),
        "expected subject mismatch message, got: {err:?}"
    );
}

#[test]
fn reissue_claims_reject_shard_change() {
    let old_claims = sample_claims();
    let mut replacement = old_claims.clone();
    replacement.shard_pid = p(8);

    let err = DelegationApi::ensure_reissue_claims_allowed(&old_claims, &replacement)
        .expect_err("reissue must stay bound to the same shard");

    assert_eq!(err.code, ErrorCode::Forbidden);
    assert!(
        err.message.contains("shard"),
        "expected shard mismatch message, got: {err:?}"
    );
}

#[test]
fn reissue_claims_reject_empty_audience() {
    let old_claims = sample_claims();
    let mut replacement = old_claims.clone();
    replacement.aud = DelegationAudience::Roles(Vec::new());

    let err = DelegationApi::ensure_reissue_claims_allowed(&old_claims, &replacement)
        .expect_err("replacement audience must not be empty");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(
        err.message.contains("audience"),
        "expected audience message, got: {err:?}"
    );
}

#[test]
fn canonicalize_reissue_claims_caps_expiry_to_old_token() {
    let mut claims = sample_claims();
    claims.iat = 100;
    claims.exp = 125;
    let mut proof = sample_proof();
    proof.cert.issued_at = 105;
    proof.cert.expires_at = 140;

    let canonical = DelegationApi::canonicalize_reissue_claims_for_proof(claims, &proof, 120)
        .expect("valid proof window must be accepted");

    assert_eq!(canonical.iat, 105);
    assert_eq!(canonical.exp, 120);
}

#[test]
fn canonicalize_reissue_claims_caps_expiry_to_proof() {
    let mut claims = sample_claims();
    claims.iat = 100;
    claims.exp = 120;
    let mut proof = sample_proof();
    proof.cert.issued_at = 100;
    proof.cert.expires_at = 115;

    let canonical = DelegationApi::canonicalize_reissue_claims_for_proof(claims, &proof, 120)
        .expect("proof expiry should clamp replacement token");

    assert_eq!(canonical.exp, 115);
}

#[test]
fn canonicalize_reissue_claims_rejects_proof_window_after_session_expiry() {
    let mut claims = sample_claims();
    claims.iat = 100;
    claims.exp = 120;
    let mut proof = sample_proof();
    proof.cert.issued_at = 121;
    proof.cert.expires_at = 140;

    let err = DelegationApi::canonicalize_reissue_claims_for_proof(claims, &proof, 120)
        .expect_err("proof starting after old expiry must fail closed");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(
        err.message.contains("proof window"),
        "expected proof-window message, got: {err:?}"
    );
}

#[test]
fn proof_is_reusable_for_claims_accepts_valid_subset_and_time_window() {
    let claims = sample_claims();
    let proof = sample_proof();
    assert!(DelegatedTokenOps::proof_reusable_for_claims(
        &proof, &claims, 110
    ));
}

#[test]
fn proof_is_reusable_for_claims_rejects_expired_cert() {
    let claims = sample_claims();
    let proof = sample_proof();
    assert!(!DelegatedTokenOps::proof_reusable_for_claims(
        &proof, &claims, 131
    ));
}

#[test]
fn proof_is_reusable_for_claims_rejects_scope_mismatch() {
    let mut claims = sample_claims();
    claims.scopes = vec!["admin".to_string()];
    let proof = sample_proof();
    assert!(!DelegatedTokenOps::proof_reusable_for_claims(
        &proof, &claims, 110
    ));
}

#[test]
fn ensure_token_claim_audience_subset_accepts_subset() {
    let token = sample_token();

    DelegationApi::ensure_token_claim_audience_subset(&token)
        .expect("subset audience must be accepted");
}

#[test]
fn ensure_token_claim_audience_subset_uses_set_semantics() {
    let mut token = sample_token();
    token.claims.aud = DelegationAudience::Roles(vec![
        CanisterRole::new("api"),
        CanisterRole::new("app"),
        CanisterRole::new("app"),
    ]);

    DelegationApi::ensure_token_claim_audience_subset(&token)
        .expect("duplicate and reordered audience entries must be accepted");
}

#[test]
fn ensure_token_claim_audience_subset_rejects_empty_claim_audience() {
    let mut token = sample_token();
    token.claims.aud = DelegationAudience::Roles(Vec::new());

    let err = DelegationApi::ensure_token_claim_audience_subset(&token)
        .expect_err("empty claims audience must fail");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("must not be empty"));
}

#[test]
fn ensure_token_claim_audience_subset_rejects_claim_outside_proof_audience() {
    let mut token = sample_token();
    token.claims.aud = DelegationAudience::Roles(vec![CanisterRole::new("admin")]);

    let err = DelegationApi::ensure_token_claim_audience_subset(&token)
        .expect_err("claims audience outside proof audience must fail");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("is not a subset of proof audience"));
}

#[test]
fn ensure_token_claim_audience_subset_rejects_empty_proof_audience() {
    let mut token = sample_token();
    token.proof.cert.aud = DelegationAudience::Roles(Vec::new());

    let err = DelegationApi::ensure_token_claim_audience_subset(&token)
        .expect_err("empty proof audience must fail");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("is not a subset of proof audience"));
}

#[test]
fn normalize_explicit_verifier_push_request_dedupes_targets() {
    let _env = install_proof_audience_test_context();
    let root_pid = p(1);
    let verifier_a = p(3);
    let verifier_b = p(4);

    let normalized = DelegationApi::normalize_explicit_verifier_push_request_with(
        DelegationVerifierProofPushRequest {
            proof: sample_proof(),
            verifier_targets: vec![verifier_a, verifier_a, verifier_b],
        },
        root_pid,
        |principal| principal == verifier_a || principal == verifier_b,
    )
    .expect("normalization should succeed");

    assert_eq!(normalized.verifier_targets, vec![verifier_a, verifier_b]);
}

#[test]
fn normalize_explicit_verifier_push_request_rejects_signer_target() {
    let err = DelegationApi::normalize_explicit_verifier_push_request_with(
        DelegationVerifierProofPushRequest {
            proof: sample_proof(),
            verifier_targets: vec![sample_proof().cert.shard_pid],
        },
        p(1),
        |_principal| true,
    )
    .expect_err("signer target must fail");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("must not match signer shard"));
}

#[test]
fn normalize_explicit_verifier_push_request_rejects_root_target() {
    let root_pid = p(1);

    let err = DelegationApi::normalize_explicit_verifier_push_request_with(
        DelegationVerifierProofPushRequest {
            proof: sample_proof(),
            verifier_targets: vec![root_pid],
        },
        root_pid,
        |_principal| true,
    )
    .expect_err("root target must fail");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("must not match root canister"));
}

#[test]
fn normalize_explicit_verifier_push_request_rejects_unregistered_target() {
    let err = DelegationApi::normalize_explicit_verifier_push_request_with(
        DelegationVerifierProofPushRequest {
            proof: sample_proof(),
            verifier_targets: vec![p(99)],
        },
        p(1),
        |_principal| false,
    )
    .expect_err("unregistered target must fail");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("is not registered"));
}

#[test]
fn normalize_explicit_verifier_push_request_rejects_target_not_in_audience() {
    let _env = install_proof_audience_test_context();
    let root_pid = p(1);
    let verifier_a = p(3);
    let verifier_b = p(4);
    let out_of_audience = p(9);

    let err = DelegationApi::normalize_explicit_verifier_push_request_with(
        DelegationVerifierProofPushRequest {
            proof: sample_proof(),
            verifier_targets: vec![verifier_a, verifier_b, out_of_audience],
        },
        root_pid,
        |_principal| true,
    )
    .expect_err("target outside proof audience must fail");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("is not in proof audience"));
}

#[test]
fn normalize_explicit_verifier_push_request_is_idempotent() {
    let _env = install_proof_audience_test_context();
    let root_pid = p(1);
    let verifier_a = p(3);
    let verifier_b = p(4);
    let request = DelegationVerifierProofPushRequest {
        proof: sample_proof(),
        verifier_targets: vec![verifier_a, verifier_a, verifier_b],
    };

    let once = DelegationApi::normalize_explicit_verifier_push_request_with(
        request,
        root_pid,
        |principal| principal == verifier_a || principal == verifier_b,
    )
    .expect("first normalization should succeed");

    let twice = DelegationApi::normalize_explicit_verifier_push_request_with(
        once.clone(),
        root_pid,
        |principal| principal == verifier_a || principal == verifier_b,
    )
    .expect("second normalization should succeed");

    assert_eq!(once, twice, "normalization must be idempotent");
}

#[test]
fn normalize_explicit_verifier_push_request_rejects_mixed_targets_without_partial_apply() {
    let root_pid = p(1);
    let verifier_a = p(3);
    let verifier_b = p(4);
    let invalid = p(99);

    let err = DelegationApi::normalize_explicit_verifier_push_request_with(
        DelegationVerifierProofPushRequest {
            proof: sample_proof(),
            verifier_targets: vec![verifier_a, invalid, verifier_b],
        },
        root_pid,
        |principal| principal == verifier_a || principal == verifier_b,
    )
    .expect_err("mixed valid/invalid targets must fail before fanout");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("is not registered"));
}

#[test]
fn repair_requires_existing_local_proof() {
    let err = DelegationApi::ensure_repair_push_proof_is_locally_available_with(
        &sample_proof(),
        |_proof| Ok(None),
    )
    .expect_err("repair must fail when no local proof exists");

    assert_eq!(err.code, ErrorCode::NotFound);
    assert!(err.message.contains("requires an existing local proof"));
}

#[test]
fn repair_rejects_mismatched_local_proof() {
    let proof = sample_proof();
    let mut stored = sample_proof();
    stored.cert_sig = vec![9, 9, 9];

    let err =
        DelegationApi::ensure_repair_push_proof_is_locally_available_with(&proof, |_candidate| {
            Ok(Some(stored))
        })
        .expect_err("repair must fail when stored proof differs");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("must match the existing local proof"));
}

#[test]
fn repair_accepts_existing_identical_local_proof() {
    let proof = sample_proof();

    DelegationApi::ensure_repair_push_proof_is_locally_available_with(&proof, |_candidate| {
        Ok(Some(proof.clone()))
    })
    .expect("repair should accept identical stored proof");
}

#[test]
fn ensure_target_in_proof_audience_accepts_allowed_verifier() {
    let _env = install_proof_audience_test_context();
    DelegationApi::ensure_target_in_proof_audience(
        &sample_proof(),
        p(3),
        DelegationProofInstallIntent::Repair,
        AudienceBindingFailureStage::PostNormalization,
    )
    .expect("audience-bound target should succeed");
}

#[test]
fn ensure_target_in_proof_audience_rejects_target_outside_audience() {
    let _env = install_proof_audience_test_context();
    let err = DelegationApi::ensure_target_in_proof_audience(
        &sample_proof(),
        p(9),
        DelegationProofInstallIntent::Repair,
        AudienceBindingFailureStage::PostNormalization,
    )
    .expect_err("target outside audience must fail");

    assert_eq!(err.code, ErrorCode::InvalidInput);
    assert!(err.message.contains("is not in proof audience"));
}

#[test]
fn clamp_delegated_session_expires_at_clamps_to_token_expiry() {
    let expires_at = DelegationApi::clamp_delegated_session_expires_at(100, 130, 600, Some(500))
        .expect("clamp should succeed");
    assert_eq!(expires_at, 130);
}

#[test]
fn clamp_delegated_session_expires_at_clamps_to_configured_max_ttl() {
    let expires_at = DelegationApi::clamp_delegated_session_expires_at(100, 900, 60, Some(500))
        .expect("clamp should succeed");
    assert_eq!(expires_at, 160);
}

#[test]
fn clamp_delegated_session_expires_at_clamps_to_requested_ttl() {
    let expires_at = DelegationApi::clamp_delegated_session_expires_at(100, 900, 600, Some(30))
        .expect("clamp should succeed");
    assert_eq!(expires_at, 130);
}

#[test]
fn clamp_delegated_session_expires_at_rejects_zero_requested_ttl() {
    let err = DelegationApi::clamp_delegated_session_expires_at(100, 900, 600, Some(0))
        .expect_err("zero requested ttl must fail");
    assert_eq!(err.code, crate::dto::error::ErrorCode::InvalidInput);
}

#[test]
fn clamp_delegated_session_expires_at_rejects_expired_token() {
    let err = DelegationApi::clamp_delegated_session_expires_at(100, 100, 600, Some(30))
        .expect_err("expired token must fail");
    assert_eq!(err.code, crate::dto::error::ErrorCode::Forbidden);
}