bzr 0.4.3

A CLI for Bugzilla, inspired by gh
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166

//! ISO-8601 date / datetime validation for Bugzilla search filters.
//!
//! Accepts four shapes (lengths fully constrain the format):
//!   * `YYYY-MM-DD`            (10 chars) — canonicalized to `YYYY-MM-DDT00:00:00Z`
//!   * `YYYY-MM-DDTHH:MM:SS`   (19 chars) — sent verbatim; server treats as UTC
//!   * `YYYY-MM-DDTHH:MM:SSZ`  (20 chars) — sent verbatim
//!   * `YYYY-MM-DDTHH:MM:SS±HH:MM` (25 chars) — sent verbatim
//!
//! Fractional seconds, week dates (`2026-W18-3`), and ordinal dates
//! (`2026-128`) are rejected: they are valid ISO-8601 but the server
//! is not guaranteed to accept them, and we'd rather fail fast at the
//! CLI than ship a malformed payload.

use crate::error::{BzrError, Result};

/// Validate an ISO-8601 datetime or bare date for use as a Bugzilla
/// search filter. On success, returns the canonical form sent to the
/// server (bare dates are expanded to `YYYY-MM-DDT00:00:00Z`).
///
/// `flag` is the CLI flag name (e.g. "--created-since") and is
/// included in the error message so callers can locate the offending
/// input when multiple date flags are in play.
pub fn parse_iso8601_or_date(s: &str, flag: &str) -> Result<String> {
    match try_canonicalize(s) {
        Some(canon) => Ok(canon),
        None => Err(BzrError::InputValidation(format!(
            "{flag}: '{s}' is not a valid ISO-8601 date or datetime.\n\
             Expected: YYYY-MM-DD, YYYY-MM-DDTHH:MM:SS, \
             YYYY-MM-DDTHH:MM:SSZ, or YYYY-MM-DDTHH:MM:SS±HH:MM"
        ))),
    }
}

/// Validate a bare `YYYY-MM-DD` date, returning it unchanged on success.
///
/// Unlike [`parse_iso8601_or_date`], this does **not** expand the value to a
/// datetime — it is for date-only fields such as the bug deadline, which
/// Bugzilla stores and echoes back as `YYYY-MM-DD`. `flag` is the CLI flag
/// name included in the error message.
pub fn parse_date_only(s: &str, flag: &str) -> Result<String> {
    if s.is_ascii() && s.len() == 10 && parse_date(s).is_some() {
        Ok(s.to_string())
    } else {
        Err(BzrError::InputValidation(format!(
            "{flag}: '{s}' is not a valid date. Expected: YYYY-MM-DD"
        )))
    }
}

fn try_canonicalize(s: &str) -> Option<String> {
    // Length-check first; this also gates the byte-indexing below
    // (each branch knows the input is exactly that many bytes long).
    // ASCII-only because every accepted character is in [-+:0-9TZ].
    if !s.is_ascii() {
        return None;
    }
    match s.len() {
        10 => parse_date(s).map(|()| format!("{s}T00:00:00Z")),
        19 => parse_datetime_naive(s).map(|()| s.to_string()),
        20 => parse_datetime_z(s).map(|()| s.to_string()),
        25 => parse_datetime_offset(s).map(|()| s.to_string()),
        _ => None,
    }
}

fn parse_date(s: &str) -> Option<()> {
    let bytes = s.as_bytes();
    if bytes[4] != b'-' || bytes[7] != b'-' {
        return None;
    }
    if !bytes[..4].iter().all(u8::is_ascii_digit)
        || !bytes[5..7].iter().all(u8::is_ascii_digit)
        || !bytes[8..10].iter().all(u8::is_ascii_digit)
    {
        return None;
    }
    let month: u32 = s[5..7].parse().ok()?;
    let day: u32 = s[8..10].parse().ok()?;
    let year: u32 = s[..4].parse().ok()?;
    let max_day = days_in_month(year, month)?;
    if day == 0 || day > max_day {
        return None;
    }
    Some(())
}

fn days_in_month(year: u32, month: u32) -> Option<u32> {
    let days = match month {
        1 | 3 | 5 | 7 | 8 | 10 | 12 => 31,
        4 | 6 | 9 | 11 => 30,
        2 if is_leap_year(year) => 29,
        2 => 28,
        _ => return None,
    };
    Some(days)
}

fn is_leap_year(year: u32) -> bool {
    year.is_multiple_of(4) && (!year.is_multiple_of(100) || year.is_multiple_of(400))
}

fn parse_time(s: &str) -> Option<()> {
    debug_assert_eq!(s.len(), 8, "parse_time requires exactly 8 bytes (HH:MM:SS)");
    let bytes = s.as_bytes();
    if bytes[2] != b':' || bytes[5] != b':' {
        return None;
    }
    if !bytes[..2].iter().all(u8::is_ascii_digit)
        || !bytes[3..5].iter().all(u8::is_ascii_digit)
        || !bytes[6..8].iter().all(u8::is_ascii_digit)
    {
        return None;
    }
    let h: u32 = s[..2].parse().ok()?;
    let m: u32 = s[3..5].parse().ok()?;
    let sec: u32 = s[6..8].parse().ok()?;
    // Allow second == 60 for leap seconds.
    if h > 23 || m > 59 || sec > 60 {
        return None;
    }
    Some(())
}

fn parse_datetime_naive(s: &str) -> Option<()> {
    if s.as_bytes()[10] != b'T' {
        return None;
    }
    parse_date(&s[..10])?;
    parse_time(&s[11..19])?;
    Some(())
}

fn parse_datetime_z(s: &str) -> Option<()> {
    if !s.ends_with('Z') {
        return None;
    }
    parse_datetime_naive(&s[..19])?;
    Some(())
}

fn parse_datetime_offset(s: &str) -> Option<()> {
    parse_datetime_naive(&s[..19])?;
    let bytes = s.as_bytes();
    let sign = bytes[19];
    if sign != b'+' && sign != b'-' {
        return None;
    }
    if bytes[22] != b':' {
        return None;
    }
    if !bytes[20..22].iter().all(u8::is_ascii_digit)
        || !bytes[23..25].iter().all(u8::is_ascii_digit)
    {
        return None;
    }
    let h: u32 = s[20..22].parse().ok()?;
    let m: u32 = s[23..25].parse().ok()?;
    if h > 14 || m > 59 || (h == 14 && m > 0) {
        return None;
    }
    Some(())
}

#[cfg(test)]
#[path = "datetime_tests.rs"]
mod tests;