bytehaul 0.1.9

Async HTTP download library with resume, multi-connection, rate limiting, and checksum verification
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
use std::collections::HashMap;
use std::sync::Arc;
use std::time::Duration;

use hyper::header::LOCATION;
use hyper::{HeaderMap, StatusCode};
use tokio::sync::Mutex;
use url::Url;

use crate::config::DownloadSpec;
use crate::error::DownloadError;
use crate::http::request;
use crate::http::response::ResponseMeta;
use crate::http::HttpResponse;
use crate::network::BytehaulClient;

/// HTTP worker responsible for sending requests and validating responses.
#[derive(Clone)]
pub(crate) struct HttpWorker {
    client: BytehaulClient,
    url: String,
    headers: HashMap<String, String>,
    timeout: Duration,
    final_url: Arc<Mutex<Option<String>>>,
}

impl HttpWorker {
    pub fn new(client: BytehaulClient, spec: &DownloadSpec) -> Self {
        Self {
            client,
            url: spec.url.clone(),
            headers: spec.headers.clone(),
            timeout: spec.read_timeout,
            final_url: Arc::new(Mutex::new(None)),
        }
    }

    pub async fn final_url(&self) -> Result<String, DownloadError> {
        if let Some(url) = self.cached_final_url().await {
            return Ok(url);
        }

        let resolved = self.resolve_redirects(&self.url).await?;
        self.set_final_url(resolved.clone()).await;
        Ok(resolved)
    }

    /// Send an initial GET request (no Range) and validate the response.
    pub async fn send_get(&self) -> Result<(HttpResponse, ResponseMeta), DownloadError> {
        let start_url = self
            .cached_final_url()
            .await
            .unwrap_or_else(|| self.url.clone());
        let can_refresh = start_url != self.url;
        match self.send_get_following_redirects(&start_url).await {
            Err(error) if can_refresh && is_stale_redirect_target_error(&error) => {
                self.clear_final_url().await;
                self.send_get_following_redirects(&self.url).await
            }
            result => result,
        }
    }

    /// Send a Range GET request and validate the 206 response.
    pub async fn send_range(
        &self,
        start: u64,
        end: u64,
    ) -> Result<(HttpResponse, ResponseMeta), DownloadError> {
        let start_url = self
            .cached_final_url()
            .await
            .unwrap_or_else(|| self.url.clone());
        let can_refresh = start_url != self.url;
        match self
            .send_range_following_redirects(&start_url, start, end)
            .await
        {
            Err(error) if can_refresh && is_stale_redirect_target_error(&error) => {
                self.clear_final_url().await;
                self.send_range_following_redirects(&self.url, start, end)
                    .await
            }
            result => result,
        }
    }

    async fn cached_final_url(&self) -> Option<String> {
        self.final_url.lock().await.clone()
    }

    async fn set_final_url(&self, url: String) {
        *self.final_url.lock().await = Some(url);
    }

    async fn clear_final_url(&self) {
        *self.final_url.lock().await = None;
    }

    async fn send_get_following_redirects(
        &self,
        start_url: &str,
    ) -> Result<(HttpResponse, ResponseMeta), DownloadError> {
        let mut current = parse_download_url(start_url)?;

        for _ in 0..10 {
            tracing::debug!(url = %current, "sending GET request");
            let req = request::build_get_request(&current, &self.headers);
            let response = self.client.request_with_timeout(req, self.timeout).await?;
            let status = response.status();
            tracing::debug!(status = status.as_u16(), "GET response received");

            if status.is_redirection() {
                current = redirect_location(&current, response.headers(), status)?;
                continue;
            }

            self.set_final_url(current.clone()).await;
            if !status.is_success() {
                return Err(make_http_error(response.headers(), status.as_u16()));
            }

            let meta = ResponseMeta::from_parts(status, response.headers(), None);
            return Ok((response, meta));
        }

        too_many_redirects_error()
    }

    async fn send_range_following_redirects(
        &self,
        start_url: &str,
        start: u64,
        end: u64,
    ) -> Result<(HttpResponse, ResponseMeta), DownloadError> {
        let mut current = parse_download_url(start_url)?;

        for _ in 0..10 {
            let req = request::build_range_request(&current, &self.headers, start, end);
            let response = self.client.request_with_timeout(req, self.timeout).await?;

            let status = response.status();
            tracing::debug!(status = status.as_u16(), start = start, end = end, url = %current, "Range response received");

            if status.is_redirection() {
                current = redirect_location(&current, response.headers(), status)?;
                continue;
            }

            self.set_final_url(current.clone()).await;
            if status.as_u16() == 200 {
                let meta = ResponseMeta::from_parts(status, response.headers(), None);
                return Ok((response, meta));
            }
            if status.as_u16() != 206 {
                return Err(make_http_error(response.headers(), status.as_u16()));
            }

            let meta = ResponseMeta::from_parts(status, response.headers(), None);
            return Ok((response, meta));
        }

        too_many_redirects_error()
    }

    async fn resolve_redirects(&self, url: &str) -> Result<String, DownloadError> {
        let mut current = parse_download_url(url)?;

        for _ in 0..10 {
            let req = request::build_get_request(&current, &self.headers);
            let response = self.client.request_with_timeout(req, self.timeout).await?;
            let status = response.status();
            if !status.is_redirection() {
                return Ok(current);
            }

            current = redirect_location(&current, response.headers(), status)?;
        }

        too_many_redirects_error()
    }
}

fn parse_download_url(url: &str) -> Result<String, DownloadError> {
    validate_redirect_target(Url::parse(url).map_err(|error| {
        DownloadError::InvalidConfig(format!("invalid download URL '{url}': {error}"))
    })?)
    .map(|url| url.to_string())
}

fn validate_redirect_target(url: Url) -> Result<Url, DownloadError> {
    if matches!(url.scheme(), "http" | "https") {
        Ok(url)
    } else {
        Err(DownloadError::InvalidConfig(format!(
            "redirect target '{url}' must use http or https"
        )))
    }
}

fn resolve_redirect_target(current_url: &str, location: &str) -> Result<String, DownloadError> {
    let base = Url::parse(current_url).map_err(|error| {
        DownloadError::InvalidConfig(format!(
            "invalid redirect base URL '{current_url}': {error}"
        ))
    })?;
    let target = match Url::parse(location) {
        Ok(url) => url,
        Err(url::ParseError::RelativeUrlWithoutBase) => base.join(location).map_err(|error| {
            DownloadError::InvalidConfig(format!(
                "invalid redirect location '{location}' from '{current_url}': {error}"
            ))
        })?,
        Err(error) => {
            return Err(DownloadError::InvalidConfig(format!(
                "invalid redirect location '{location}': {error}"
            )))
        }
    };
    Ok(validate_redirect_target(target)?.to_string())
}

fn redirect_location(
    current_url: &str,
    headers: &HeaderMap,
    status: StatusCode,
) -> Result<String, DownloadError> {
    let location = headers
        .get(LOCATION)
        .and_then(|value| value.to_str().ok())
        .ok_or_else(|| DownloadError::HttpStatus {
            status: status.as_u16(),
            message: "redirect response missing Location header".into(),
        })?;
    resolve_redirect_target(current_url, location)
}

fn too_many_redirects_error<T>() -> Result<T, DownloadError> {
    Err(DownloadError::HttpStatus {
        status: StatusCode::LOOP_DETECTED.as_u16(),
        message: "too many redirects".into(),
    })
}

fn is_stale_redirect_target_error(error: &DownloadError) -> bool {
    matches!(
        error,
        DownloadError::HttpStatus {
            status: 403 | 404,
            ..
        }
    )
}

/// Build an appropriate HttpStatus error, embedding Retry-After hint for 429/503.
fn make_http_error(headers: &HeaderMap, status: u16) -> DownloadError {
    let retry_after = headers
        .get("retry-after")
        .and_then(|value| value.to_str().ok())
        .and_then(|value| value.trim().parse::<u64>().ok());

    let message = match retry_after {
        Some(seconds) => format!("retry-after:{seconds}"),
        None => StatusCode::from_u16(status)
            .ok()
            .and_then(|code| code.canonical_reason().map(str::to_string))
            .unwrap_or_else(|| "unknown".to_string()),
    };

    DownloadError::HttpStatus { status, message }
}

#[cfg(test)]
mod tests {
    use super::*;
    use bytes::Bytes;
    use http_body_util::Empty;
    use hyper::Response;
    use std::sync::atomic::{AtomicUsize, Ordering};
    use std::sync::Arc;
    use warp::Filter;

    fn worker_for(url: String) -> HttpWorker {
        let mut spec = DownloadSpec::new(url).output_path("unused.bin");
        spec.read_timeout = Duration::from_secs(5);
        let client = crate::network::ClientNetworkConfig::default()
            .build_client()
            .unwrap();
        HttpWorker::new(client, &spec)
    }

    #[tokio::test]
    async fn send_get_returns_response_metadata() {
        let route = warp::path("file").map(|| {
            warp::http::Response::builder()
                .status(200)
                .header("content-length", "4")
                .header("accept-ranges", "bytes")
                .header("etag", "\"etag-1\"")
                .header("last-modified", "Thu, 01 Jan 2026 00:00:00 GMT")
                .body("test")
                .unwrap()
        });
        let (addr, server) = warp::serve(route).bind_ephemeral(([127, 0, 0, 1], 0));
        tokio::spawn(server);

        let worker = worker_for(format!("http://{addr}/file"));
        let (_, meta) = worker.send_get().await.unwrap();

        assert_eq!(meta.content_length, Some(4));
        assert!(meta.accept_ranges);
        assert_eq!(meta.etag.as_deref(), Some("\"etag-1\""));
        assert_eq!(
            meta.last_modified.as_deref(),
            Some("Thu, 01 Jan 2026 00:00:00 GMT")
        );
    }

    #[tokio::test]
    async fn send_range_returns_partial_content_metadata() {
        let route = warp::path("range").map(|| {
            warp::http::Response::builder()
                .status(206)
                .header("content-length", "3")
                .header("content-range", "bytes 2-4/10")
                .header("accept-ranges", "bytes")
                .body("cde")
                .unwrap()
        });
        let (addr, server) = warp::serve(route).bind_ephemeral(([127, 0, 0, 1], 0));
        tokio::spawn(server);

        let worker = worker_for(format!("http://{addr}/range"));
        let (_, meta) = worker.send_range(2, 4).await.unwrap();

        assert_eq!(meta.content_length, Some(3));
        assert_eq!(meta.content_range_start, Some(2));
        assert_eq!(meta.content_range_end, Some(4));
        assert_eq!(meta.content_range_total, Some(10));
    }

    #[tokio::test]
    async fn send_range_accepts_full_content_when_server_ignores_range() {
        let route = warp::path("range-fallback").map(|| {
            warp::http::Response::builder()
                .status(200)
                .header("content-length", "10")
                .body("0123456789")
                .unwrap()
        });
        let (addr, server) = warp::serve(route).bind_ephemeral(([127, 0, 0, 1], 0));
        tokio::spawn(server);

        let worker = worker_for(format!("http://{addr}/range-fallback"));
        let (_, meta) = worker.send_range(2, 4).await.unwrap();

        assert_eq!(meta.content_length, Some(10));
        assert_eq!(meta.content_range_start, None);
        assert_eq!(meta.content_range_end, None);
        assert_eq!(meta.content_range_total, None);
    }

    #[tokio::test]
    async fn send_get_caches_final_url_after_redirect() {
        let redirect = warp::path("redirect")
            .map(|| warp::redirect::temporary(warp::http::Uri::from_static("/target")));
        let target = warp::path("target").map(|| {
            warp::http::Response::builder()
                .status(200)
                .header("content-length", "4")
                .body("done")
                .unwrap()
        });
        let routes = redirect.or(target);
        let (addr, server) = warp::serve(routes).bind_ephemeral(([127, 0, 0, 1], 0));
        tokio::spawn(server);

        let worker = worker_for(format!("http://{addr}/redirect"));
        worker.send_get().await.unwrap();

        assert_eq!(
            worker.final_url().await.unwrap(),
            format!("http://{addr}/target")
        );
    }

    #[tokio::test]
    async fn send_range_refreshes_stale_redirect_target_after_404() {
        let active_asset = Arc::new(AtomicUsize::new(1));
        let active_for_redirect = active_asset.clone();
        let active_for_asset = active_asset.clone();

        let release = warp::path("release").map(move || {
            let active = active_for_redirect.load(Ordering::SeqCst);
            let location = format!("/asset/{active}");
            warp::http::Response::builder()
                .status(302)
                .header("location", location)
                .body(Vec::<u8>::new())
                .unwrap()
        });
        let asset = warp::path!("asset" / usize)
            .and(warp::header::optional::<String>("range"))
            .map(move |asset_id: usize, _range: Option<String>| {
                if asset_id != active_for_asset.load(Ordering::SeqCst) {
                    return warp::http::Response::builder()
                        .status(404)
                        .body(Vec::<u8>::new())
                        .unwrap();
                }

                active_for_asset.store(asset_id + 1, Ordering::SeqCst);
                warp::http::Response::builder()
                    .status(206)
                    .header("content-length", "3")
                    .header("content-range", "bytes 0-2/3")
                    .header("accept-ranges", "bytes")
                    .body(b"abc".to_vec())
                    .unwrap()
            });
        let routes = release.or(asset);
        let (addr, server) = warp::serve(routes).bind_ephemeral(([127, 0, 0, 1], 0));
        tokio::spawn(server);

        let worker = worker_for(format!("http://{addr}/release"));
        let (_, meta) = worker.send_range(0, 2).await.unwrap();
        assert_eq!(meta.content_range_total, Some(3));

        let (_, meta) = worker.send_range(0, 2).await.unwrap();
        assert_eq!(meta.content_range_total, Some(3));
        assert_eq!(
            worker.final_url().await.unwrap(),
            format!("http://{addr}/asset/2")
        );
    }

    #[tokio::test]
    async fn send_get_includes_retry_after_in_http_status_error() {
        let route = warp::path("busy").map(|| {
            warp::http::Response::builder()
                .status(503)
                .header("retry-after", "7")
                .body(Vec::<u8>::new())
                .unwrap()
        });
        let (addr, server) = warp::serve(route).bind_ephemeral(([127, 0, 0, 1], 0));
        tokio::spawn(server);

        let worker = worker_for(format!("http://{addr}/busy"));
        let err = worker.send_get().await.unwrap_err();

        match err {
            DownloadError::HttpStatus { status, message } => {
                assert_eq!(status, 503);
                assert_eq!(message, "retry-after:7");
            }
            other => panic!("expected HttpStatus, got {other:?}"),
        }
    }

    #[test]
    fn make_http_error_falls_back_to_canonical_reason() {
        let response = Response::builder()
            .status(404)
            .body(Empty::<Bytes>::new())
            .unwrap();
        let (parts, _) = response.into_parts();

        let err = make_http_error(&parts.headers, 404);
        match err {
            DownloadError::HttpStatus { status, message } => {
                assert_eq!(status, 404);
                assert_eq!(message, "Not Found");
            }
            other => panic!("expected HttpStatus, got {other:?}"),
        }
    }

    #[test]
    fn resolve_redirect_target_rejects_non_http_scheme() {
        let err = resolve_redirect_target("https://example.com/file", "file:///tmp/secret")
            .unwrap_err()
            .to_string();
        assert!(err.contains("must use http or https"));
    }

    #[tokio::test]
    async fn send_get_fails_with_too_many_redirects() {
        let route = warp::path("loop-redirect").map(|| {
            warp::http::Response::builder()
                .status(302)
                .header("location", "/loop-redirect")
                .body(Vec::<u8>::new())
                .unwrap()
        });
        let (addr, server) = warp::serve(route).bind_ephemeral(([127, 0, 0, 1], 0));
        tokio::spawn(server);

        let worker = worker_for(format!("http://{addr}/loop-redirect"));
        let err = worker.send_get().await.unwrap_err();
        match err {
            DownloadError::HttpStatus {
                status,
                ref message,
            } => {
                assert_eq!(status, StatusCode::LOOP_DETECTED.as_u16());
                assert!(message.contains("too many redirects"), "msg: {message}");
            }
            other => panic!("expected HttpStatus LOOP_DETECTED, got {other:?}"),
        }
    }

    #[tokio::test]
    async fn send_get_fails_when_redirect_missing_location_header() {
        let route = warp::path("no-location").map(|| {
            warp::http::Response::builder()
                .status(301)
                .body(Vec::<u8>::new())
                .unwrap()
        });
        let (addr, server) = warp::serve(route).bind_ephemeral(([127, 0, 0, 1], 0));
        tokio::spawn(server);

        let worker = worker_for(format!("http://{addr}/no-location"));
        let err = worker.send_get().await.unwrap_err();
        match err {
            DownloadError::HttpStatus {
                status,
                ref message,
            } => {
                assert_eq!(status, 301);
                assert!(
                    message.contains("missing Location header"),
                    "msg: {message}"
                );
            }
            other => panic!("expected HttpStatus 301 missing Location, got {other:?}"),
        }
    }

    #[test]
    fn resolve_redirect_target_rejects_unparseable_location() {
        let err = resolve_redirect_target("https://example.com/", "https://[::1")
            .unwrap_err()
            .to_string();
        assert!(err.contains("invalid redirect location"), "got: {err}");
    }

    #[test]
    fn resolve_redirect_target_rejects_invalid_base_url() {
        let err = resolve_redirect_target("not a url", "/target")
            .unwrap_err()
            .to_string();
        assert!(err.contains("invalid redirect base URL"), "got: {err}");
    }

    #[test]
    fn resolve_redirect_target_preserves_literal_relative_path() {
        let resolved = resolve_redirect_target("https://example.com/file", "%zz").unwrap();
        assert_eq!(resolved, "https://example.com/%zz");
    }
}