1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
use crate::ast::*;
use crate::error::{LintError, LintWarning};
use crate::validation::{ValidationContext, ValidationResult, ValidationRule};
// Wildcard performance validation rule
pub struct WildcardPerformanceRule;
impl ValidationRule for WildcardPerformanceRule {
fn name(&self) -> &'static str {
"wildcard-performance"
}
fn validate(&self, expr: &Expression, _ctx: &ValidationContext) -> ValidationResult {
match expr {
Expression::Term { term, span } => {
match term {
Term::Wildcard { value } => {
let mut result = ValidationResult::new();
// Check for wildcards at the beginning
if value.starts_with('*') {
result
.errors
.push(LintError::InvalidWildcardPlacement { span: span.clone() });
}
// Check for short wildcard terms
let parts: Vec<&str> = value.split('*').collect();
for part in parts {
if !part.is_empty() && part.len() < 3 {
result.warnings.push(LintWarning::PerformanceWarning {
span: span.clone(),
message: "Short wildcard terms may impact performance"
.to_string(),
});
break;
}
}
result
}
Term::Replacement { value } => {
let question_count = value.chars().filter(|&c| c == '?').count();
if question_count > 3 {
ValidationResult::with_warning(LintWarning::PerformanceWarning {
span: span.clone(),
message: "Multiple replacement characters may impact performance"
.to_string(),
})
} else {
ValidationResult::new()
}
}
_ => ValidationResult::new(),
}
}
Expression::BooleanOp {
operator: BooleanOperator::Or,
left,
right,
span,
} => {
// Warn about multiple wildcards in OR operations
if let (
Expression::Term {
term: Term::Wildcard { .. },
..
},
Some(right_expr),
) = (left.as_ref(), right.as_ref())
{
if let Expression::Term {
term: Term::Wildcard { .. },
..
} = right_expr.as_ref()
{
return ValidationResult::with_warning(LintWarning::PerformanceWarning {
span: span.clone(),
message: "Multiple wildcards in OR operations may significantly impact performance".to_string(),
});
}
}
ValidationResult::new()
}
_ => ValidationResult::new(),
}
}
fn can_validate(&self, expr: &Expression) -> bool {
match expr {
Expression::Term { term, .. } => {
matches!(term, Term::Wildcard { .. } | Term::Replacement { .. })
}
Expression::BooleanOp {
operator: BooleanOperator::Or,
..
} => true,
_ => false,
}
}
}
// Proximity distance performance validation rule
pub struct ProximityDistanceRule;
impl ValidationRule for ProximityDistanceRule {
fn name(&self) -> &'static str {
"proximity-distance"
}
fn validate(&self, expr: &Expression, _ctx: &ValidationContext) -> ValidationResult {
if let Expression::Proximity { operator, span, .. } = expr {
match operator {
ProximityOperator::Near { distance }
| ProximityOperator::NearForward { distance } => {
if *distance > 100 {
ValidationResult::with_warning(LintWarning::PerformanceWarning {
span: span.clone(),
message: "Very large proximity distances may impact performance"
.to_string(),
})
} else {
ValidationResult::new()
}
}
ProximityOperator::Proximity {
distance: Some(distance),
} => {
if *distance > 100 {
ValidationResult::with_warning(LintWarning::PerformanceWarning {
span: span.clone(),
message: "Very large proximity distances may impact performance"
.to_string(),
})
} else {
ValidationResult::new()
}
}
_ => ValidationResult::new(),
}
} else {
ValidationResult::new()
}
}
fn can_validate(&self, expr: &Expression) -> bool {
matches!(expr, Expression::Proximity { .. })
}
}
// Short term performance validation rule
pub struct ShortTermRule;
impl ValidationRule for ShortTermRule {
fn name(&self) -> &'static str {
"short-term"
}
fn validate(&self, expr: &Expression, _ctx: &ValidationContext) -> ValidationResult {
match expr {
Expression::Term { term, span } => {
match term {
Term::Word { value } => {
let mut result = ValidationResult::new();
// Check for empty terms
if value.trim().is_empty() {
result.errors.push(LintError::ValidationError {
span: span.clone(),
message: "Word cannot be empty".to_string(),
});
}
// Check for single character terms
if value.len() == 1 {
result.warnings.push(LintWarning::PerformanceWarning {
span: span.clone(),
message: "Single character terms may impact performance"
.to_string(),
});
}
// Check for potential field syntax errors
if value.contains(':') {
let parts: Vec<&str> = value.split(':').collect();
if parts.len() == 2 {
let field_part = parts[0];
if !field_part.is_empty()
&& FieldType::from_str(field_part).is_none()
{
result.errors.push(LintError::ValidationError {
span: span.clone(),
message: format!("Unknown field type: {}", field_part),
});
}
}
}
result
}
Term::Phrase { value } => {
if value.trim().is_empty() {
ValidationResult::with_error(LintError::ValidationError {
span: span.clone(),
message: "Quoted phrase cannot be empty".to_string(),
})
} else {
ValidationResult::new()
}
}
Term::Hashtag { value } => {
if value.trim().is_empty() {
ValidationResult::with_error(LintError::ValidationError {
span: span.clone(),
message: "Hashtag cannot be empty".to_string(),
})
} else {
ValidationResult::new()
}
}
Term::Mention { value } => {
if value.trim().is_empty() {
ValidationResult::with_error(LintError::ValidationError {
span: span.clone(),
message: "Mention cannot be empty".to_string(),
})
} else {
ValidationResult::new()
}
}
Term::CaseSensitive { value } => {
if value.chars().all(|c| c.is_lowercase())
|| value.chars().all(|c| c.is_uppercase())
{
ValidationResult::with_warning(LintWarning::PerformanceWarning {
span: span.clone(),
message:
"Case-sensitive matching is unnecessary for single-case terms"
.to_string(),
})
} else {
ValidationResult::new()
}
}
_ => ValidationResult::new(),
}
}
Expression::Comment { text, span } => {
if text.trim().is_empty() {
ValidationResult::with_warning(LintWarning::PerformanceWarning {
span: span.clone(),
message: "Empty comment".to_string(),
})
} else {
ValidationResult::new()
}
}
_ => ValidationResult::new(),
}
}
fn can_validate(&self, expr: &Expression) -> bool {
matches!(expr, Expression::Term { .. } | Expression::Comment { .. })
}
}
// Range performance validation rule
pub struct RangePerformanceRule;
impl ValidationRule for RangePerformanceRule {
fn name(&self) -> &'static str {
"range-performance"
}
fn validate(&self, expr: &Expression, _ctx: &ValidationContext) -> ValidationResult {
if let Expression::Range {
field: Some(FieldType::AuthorFollowers),
start,
end,
span,
} = expr
{
if let (Ok(start_num), Ok(end_num)) = (start.parse::<i64>(), end.parse::<i64>()) {
let mut result = ValidationResult::new();
if start_num < 0 || end_num < 0 {
result.errors.push(LintError::ValidationError {
span: span.clone(),
message: "Follower counts cannot be negative".to_string(),
});
}
if end_num > 1_000_000_000 {
result.warnings.push(LintWarning::PerformanceWarning {
span: span.clone(),
message: "Very large follower counts may not match any results".to_string(),
});
}
result
} else {
ValidationResult::new()
}
} else {
ValidationResult::new()
}
}
fn can_validate(&self, expr: &Expression) -> bool {
matches!(
expr,
Expression::Range {
field: Some(FieldType::AuthorFollowers),
..
}
)
}
}