1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
use core::cell::Cell;
use bun_core::{Global, Output};
use bun_paths::dirname;
use bun_paths::platform;
use bun_paths::resolve_path::join_abs_string_z;
use bun_semver::{ExternalString, String as SemverString};
use bun_sys as sys;
use crate::bun_json as json;
use crate::bun_json::Expr;
use crate::lockfile_real::StringBuilder;
use crate::lockfile_real::package::{Package, PackageColumns, ResolverContext, Scripts};
use crate::package_manager_real::options::LogLevel;
use crate::package_manager_real::{
PackageManager, TaskCallbackList, enqueue, resolution as pm_resolution,
};
use crate::repository_real::{Repository, RepositoryExt as _};
use crate::resolution::{ResolutionType, Tag as ResolutionTag, TaggedValue};
use crate::{
DependencyID, ExtractData, Features, INVALID_PACKAGE_ID, PackageID, Resolution,
TaskCallbackContext, initialize_store,
};
// ──────────────────────────────────────────────────────────────────────────
// GitResolver
// ──────────────────────────────────────────────────────────────────────────
pub struct GitResolver<'a> {
pub resolved: &'a [u8],
pub resolution: &'a Resolution,
pub dep_id: DependencyID,
/// Zig: `new_name: []u8 = ""` — owned scratch buffer that
/// `Package::parse_with_json` may assign when the package.json `name`
/// field is missing (see `ResolverContext::set_new_name`).
pub new_name: Vec<u8>,
}
impl<'a> ResolverContext for GitResolver<'a> {
const IS_GIT_RESOLVER: bool = true;
fn check_bundled_dependencies() -> bool {
true
}
fn count(&mut self, builder: &mut StringBuilder<'_>, _json: &Expr) {
builder.count(self.resolved);
}
fn resolve(
&mut self,
builder: &mut StringBuilder<'_>,
_json: &Expr,
) -> Result<ResolutionType<u64>, bun_core::Error> {
// Zig: `var resolution = this.resolution.*;
// resolution.value.github.resolved = builder.append(String, this.resolved);`
// `git` and `github` share the `Repository` payload in the value union,
// so writing through `.github` is correct for both tags.
// SAFETY: caller guarantees `tag` is `.git` or `.github` (see
// `process_extracted_tarball_package`); both store a `Repository`.
let mut repo = *self.resolution.repository();
repo.resolved = builder.append::<SemverString>(self.resolved);
Ok(ResolutionType::init(match self.resolution.tag {
ResolutionTag::Git => TaggedValue::Git(repo),
ResolutionTag::Github => TaggedValue::Github(repo),
// Only constructed inside the `.git | .github` arm of
// `process_extracted_tarball_package`; any other tag is a bug.
_ => unreachable!(),
}))
}
fn resolution(&self) -> &Resolution {
self.resolution
}
fn dep_id(&self) -> DependencyID {
self.dep_id
}
fn new_name(&self) -> &[u8] {
&self.new_name
}
fn set_new_name(&mut self, name: Vec<u8>) {
self.new_name = name;
}
fn take_new_name(&mut self) -> Vec<u8> {
core::mem::take(&mut self.new_name)
}
}
// ──────────────────────────────────────────────────────────────────────────
// TarballResolver
// ──────────────────────────────────────────────────────────────────────────
struct TarballResolver<'a> {
url: &'a [u8],
resolution: &'a Resolution,
}
impl<'a> ResolverContext for TarballResolver<'a> {
fn check_bundled_dependencies() -> bool {
true
}
fn count(&mut self, builder: &mut StringBuilder<'_>, _json: &Expr) {
builder.count(self.url);
}
fn resolve(
&mut self,
builder: &mut StringBuilder<'_>,
_json: &Expr,
) -> Result<ResolutionType<u64>, bun_core::Error> {
Ok(ResolutionType::<u64>::init(match self.resolution.tag {
ResolutionTag::LocalTarball => {
TaggedValue::LocalTarball(builder.append::<SemverString>(self.url))
}
ResolutionTag::RemoteTarball => {
TaggedValue::RemoteTarball(builder.append::<SemverString>(self.url))
}
_ => unreachable!(),
}))
}
}
// ──────────────────────────────────────────────────────────────────────────
// PackageManager impl
// ──────────────────────────────────────────────────────────────────────────
impl PackageManager {
/// Returns true if we need to drain dependencies
pub fn process_extracted_tarball_package(
&mut self,
package_id: &mut PackageID,
dep_id: DependencyID,
resolution: &Resolution,
data: &ExtractData,
log_level: LogLevel,
) -> Option<Package> {
match resolution.tag {
ResolutionTag::Git | ResolutionTag::Github => {
let mut package = 'package: {
let mut resolver = GitResolver {
resolved: &data.resolved,
resolution,
dep_id,
new_name: Vec::new(),
};
let mut pkg = Package::default();
if let Some(json) = &data.json {
let package_json_source =
&bun_ast::Source::init_path_string_interned_owned(&json.path, json.buf.clone());
// SAFETY: `self` is a live `&mut PackageManager`; the callee
// split-borrows `self.lockfile` / `self.log` (separate
// allocations) alongside `self` for the call's duration.
if let Err(err) = unsafe {
pkg.parse_from_real_manager(
std::ptr::from_mut::<PackageManager>(self),
package_json_source,
&mut resolver,
Features::NPM,
)
} {
if log_level != LogLevel::Silent {
let string_buf = self.lockfile.buffers.string_bytes.as_slice();
Output::err(
err,
"failed to parse package.json for <b>{}<r>",
format_args!("{}", resolution.fmt_url(string_buf)),
);
}
Global::crash();
}
let has_scripts = pkg.scripts.has_any() || {
let dir = dirname(&json.path).unwrap_or(b"");
let binding_dot_gyp_path = join_abs_string_z::<platform::Auto>(
dir,
&[b"binding.gyp" as &[u8]],
);
sys::exists(binding_dot_gyp_path.as_bytes())
};
pkg.meta.set_has_install_script(has_scripts);
break 'package pkg;
}
// package.json doesn't exist, no dependencies to worry about but we need to decide on a name for the dependency
// tag is `.git` or `.github`; both store `Repository`.
let repo = *resolution.repository();
let new_name = Repository::create_dependency_name_from_version_literal(
&repo,
self.lockfile.buffers.string_bytes.as_slice(),
&self.lockfile.buffers.dependencies[dep_id as usize],
);
// `defer manager.allocator.free(new_name)` — `new_name: Vec<u8>` drops at scope end.
{
let mut builder = self.lockfile.string_builder();
builder.count(&new_name);
// Zig passed `undefined` for the unused `JSAst.Expr` arg.
resolver.count(&mut builder, &Expr::default());
bun_core::handle_oom(builder.allocate());
let name = builder.append::<ExternalString>(&new_name);
pkg.name = name.value;
pkg.name_hash = name.hash;
pkg.resolution = resolver
.resolve(&mut builder, &Expr::default())
.expect("unreachable");
}
pkg
};
// Store the tarball integrity hash so the lockfile can pin the
// exact content downloaded from the remote (GitHub) server.
if data.integrity.tag.is_supported() {
package.meta.integrity = data.integrity;
}
package = self.lockfile.append_package(&package).expect("unreachable");
*package_id = package.meta.id;
if package.dependencies.len > 0 {
bun_core::handle_oom(
self.lockfile
.scratch
.dependency_list_queue
.write_item(package.dependencies),
);
}
Some(package)
}
ResolutionTag::LocalTarball | ResolutionTag::RemoteTarball => {
let json = data.json.as_ref().unwrap();
let package_json_source =
&bun_ast::Source::init_path_string_interned_owned(&json.path, json.buf.clone());
let mut package = Package::default();
let mut resolver = TarballResolver {
url: &data.url,
resolution,
};
// SAFETY: `self` is a live `&mut PackageManager`; the callee
// split-borrows `self.lockfile` / `self.log` (separate
// allocations) alongside `self` for the call's duration.
if let Err(err) = unsafe {
package.parse_from_real_manager(
std::ptr::from_mut::<PackageManager>(self),
package_json_source,
&mut resolver,
Features::NPM,
)
} {
if log_level != LogLevel::Silent {
let string_buf = self.lockfile.buffers.string_bytes.as_slice();
Output::pretty_errorln(format_args!(
"<r><red>error:<r> expected package.json in <b>{}<r> to be a JSON file: {}\n",
resolution.fmt_url(string_buf),
err.name(),
));
}
Global::crash();
}
let has_scripts = package.scripts.has_any() || {
let dir = dirname(&json.path).unwrap_or(b"");
let binding_dot_gyp_path =
join_abs_string_z::<platform::Auto>(dir, &[b"binding.gyp" as &[u8]]);
sys::exists(binding_dot_gyp_path.as_bytes())
};
package.meta.set_has_install_script(has_scripts);
if data.integrity.tag.is_supported() {
package.meta.integrity = data.integrity;
}
package = self.lockfile.append_package(&package).expect("unreachable");
*package_id = package.meta.id;
if package.dependencies.len > 0 {
bun_core::handle_oom(
self.lockfile
.scratch
.dependency_list_queue
.write_item(package.dependencies),
);
}
Some(package)
}
_ => {
if !data.json.as_ref().unwrap().buf.is_empty() {
let json = data.json.as_ref().unwrap();
let package_json_source =
&bun_ast::Source::init_path_string_interned_owned(&json.path, json.buf.clone());
initialize_store();
// SAFETY: `self.log` is set once by `PackageManager::init()` and
// never null while tasks run (mirrors Zig's non-optional `*logger.Log`).
let log = self.log_mut();
let bump = bun_alloc::Arena::new();
let json_root = match json::parse_package_json_utf8(
package_json_source,
log,
&bump,
) {
Ok(v) => v,
Err(err) => {
if log_level != LogLevel::Silent {
let string_buf = self.lockfile.buffers.string_bytes.as_slice();
Output::pretty_errorln(format_args!(
"<r><red>error:<r> expected package.json in <b>{}<r> to be a JSON file: {}\n",
resolution.fmt_url(string_buf),
err.name(),
));
}
Global::crash();
}
};
// PORT NOTE (spec parity): Zig writes
// var scripts = manager.lockfile.packages.items(.scripts)[package_id.*];
// which COPIES the `Scripts` struct into a local; the
// subsequent `parseAlloc` / `.filled = true` mutate the
// local and are never stored back, so
// `lockfile.packages[id].scripts` is not updated. This is
// a latent dead-store bug in processDependencyList.zig,
// but we match it exactly so .rs/.zig observable behavior
// agree. The `builder` appends still land in
// `lockfile.buffers.string_bytes`, preserving that side
// effect. (Hoisted above `string_builder()` for borrowck —
// `parse_count`/`allocate` don't touch `packages`.)
debug_assert!(*package_id != INVALID_PACKAGE_ID);
let mut scripts: Scripts =
self.lockfile.packages.items_scripts()[*package_id as usize];
let mut builder = self.lockfile.string_builder();
Scripts::parse_count(&mut builder, json_root);
builder.allocate().expect("unreachable");
scripts.parse_alloc(&mut builder, json_root);
scripts.filled = true;
let _ = scripts;
}
None
}
}
}
pub fn process_dependency_list_item(
&mut self,
item: &TaskCallbackContext,
any_root: Option<&Cell<bool>>,
install_peer: bool,
) -> Result<(), bun_core::Error> {
match *item {
TaskCallbackContext::Dependency(dependency_id) => {
// PORT NOTE: reshaped for borrowck — clone the dependency row
// out of the buffer before re-borrowing `self` for enqueue.
let dependency = Clone::clone(
&self.lockfile.buffers.dependencies.as_slice()[dependency_id as usize],
);
let resolution =
self.lockfile.buffers.resolutions.as_slice()[dependency_id as usize];
enqueue::enqueue_dependency_with_main(
self,
dependency_id,
&dependency,
resolution,
install_peer,
)?;
}
TaskCallbackContext::RootDependency(dependency_id) => {
let dependency = Clone::clone(
&self.lockfile.buffers.dependencies.as_slice()[dependency_id as usize],
);
let resolution =
self.lockfile.buffers.resolutions.as_slice()[dependency_id as usize];
enqueue::enqueue_dependency_with_main_and_success_fn(
self,
dependency_id,
&dependency,
resolution,
install_peer,
pm_resolution::assign_root_resolution,
Some(PackageManager::fail_root_resolution),
true,
)?;
if let Some(ptr) = any_root {
let new_resolution_id =
self.lockfile.buffers.resolutions.as_slice()[dependency_id as usize];
if new_resolution_id != resolution {
ptr.set(true);
}
}
}
_ => {}
}
Ok(())
}
pub fn process_peer_dependency_list(&mut self) -> Result<(), bun_core::Error> {
while let Some(peer_dependency_id) = self.peer_dependencies.read_item() {
// PORT NOTE: reshaped for borrowck — clone the dependency row out
// of the buffer before re-borrowing `self` for enqueue.
let dependency = Clone::clone(
&self.lockfile.buffers.dependencies.as_slice()[peer_dependency_id as usize],
);
let resolution =
self.lockfile.buffers.resolutions.as_slice()[peer_dependency_id as usize];
enqueue::enqueue_dependency_with_main(
self,
peer_dependency_id,
&dependency,
resolution,
true,
)?;
}
Ok(())
}
/// Zig: `callbacks` was `comptime anytype` with a
/// `@TypeOf(callbacks) != void and @TypeOf(callbacks.onResolve) != void`
/// check. Modeled as `Option<impl FnOnce(C)>` — only `onResolve` is ever
/// read, and the void path is `None`.
pub fn process_dependency_list<C>(
&mut self,
dep_list: TaskCallbackList,
ctx: C,
on_resolve: Option<impl FnOnce(C)>,
install_peer: bool,
) -> Result<(), bun_core::Error> {
if !dep_list.is_empty() {
let dependency_list = dep_list;
let any_root = Cell::new(false);
for item in dependency_list.iter() {
self.process_dependency_list_item(item, Some(&any_root), install_peer)?;
}
if let Some(on_resolve) = on_resolve {
if any_root.get() {
on_resolve(ctx);
}
}
// `dependency_list.deinit(this.allocator)` — owned `Vec`; drops here.
drop(dependency_list);
}
Ok(())
}
}
// ──────────────────────────────────────────────────────────────────────────
// Free-function re-export surface — Zig declares these at file scope with an
// explicit `*PackageManager` first param. Thin shims over the
// `impl PackageManager` bodies above so `pub use process_dependency_list::{…}`
// in `PackageManager.rs` resolves (matching the directories/enqueue pattern).
// ──────────────────────────────────────────────────────────────────────────
#[inline]
pub fn process_extracted_tarball_package(
manager: &mut PackageManager,
package_id: &mut PackageID,
dep_id: DependencyID,
resolution: &Resolution,
data: &ExtractData,
log_level: LogLevel,
) -> Option<Package> {
manager.process_extracted_tarball_package(package_id, dep_id, resolution, data, log_level)
}
#[inline]
pub fn process_dependency_list_item(
this: &mut PackageManager,
item: &TaskCallbackContext,
any_root: Option<&Cell<bool>>,
install_peer: bool,
) -> Result<(), bun_core::Error> {
this.process_dependency_list_item(item, any_root, install_peer)
}
#[inline]
pub fn process_peer_dependency_list(this: &mut PackageManager) -> Result<(), bun_core::Error> {
this.process_peer_dependency_list()
}
#[inline]
pub fn process_dependency_list<C>(
this: &mut PackageManager,
dep_list: TaskCallbackList,
ctx: C,
on_resolve: Option<impl FnOnce(C)>,
install_peer: bool,
) -> Result<(), bun_core::Error> {
this.process_dependency_list(dep_list, ctx, on_resolve, install_peer)
}