1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
// (c) Copyright 2025 Helsing GmbH. All rights reserved.
use std::{
collections::{HashMap, HashSet, VecDeque},
path::{Path, PathBuf},
};
use async_recursion::async_recursion;
use miette::{Context as _, Diagnostic, bail};
use semver::VersionReq;
use thiserror::Error;
use crate::{
cache::Cache,
credentials::Credentials,
lock::Lockfile,
manifest::{
Dependency, DependencyManifest, LocalDependencyManifest, MANIFEST_FILE, Manifest,
PackagesManifest,
},
operations::install::NetworkMode,
package::{PackageName, PackageType},
registry::{Artifactory, RegistryUri},
};
/// Models the source of a dependency
#[derive(Debug, Clone)]
pub enum DependencySource {
/// A local dependencies, expressed by it's path
Local {
/// Local path
path: PathBuf,
},
/// A remote dependencies, expressed by it's repo & registry
Remote {
/// Registry
registry: RegistryUri,
/// Repository name
repository: String,
},
}
/// Represents metadata about a dependency in the graph
#[derive(Debug, Clone)]
pub struct DependencyNode {
/// The package name
pub name: PackageName,
/// Package type (api or lib)
pub package_type: Option<PackageType>,
/// Where this dependency comes from
pub source: DependencySource,
/// Packages that this package depends on
pub dependencies: Vec<PackageName>,
/// Version requirement
pub version: VersionReq,
}
/// Maps a package name to metadata describing the package
pub type MetadataMap = HashMap<PackageName, DependencyNode>;
/// Represents a resolved dependency with its name and metadata
#[derive(Debug)]
pub struct DependencyDetails {
/// The package name
pub name: PackageName,
/// The dependency node containing metadata
pub node: DependencyNode,
}
/// A dependency graph containing nodes and edges
#[derive(Debug)]
pub struct DependencyGraph {
/// Map of package names to their metadata
pub nodes: MetadataMap,
/// Whether network access was allowed when building this graph
pub network_mode: NetworkMode,
}
impl DependencyGraph {
/// Build a dependency graph from a manifest
///
/// Downloads remote packages to discover their transitive dependencies.
/// If `network_mode` is [`NetworkMode::Offline`], only cached packages are used
/// and a [`DependencyError::Offline`] is returned when a download would be
/// needed.
pub async fn build(
manifest: &PackagesManifest,
base_path: &Path,
credentials: &Credentials,
lockfile: Option<Lockfile>,
network_mode: NetworkMode,
) -> miette::Result<Self> {
let mut builder =
GraphBuilder::new(base_path.to_path_buf(), credentials, lockfile, network_mode);
// Get the parent package type from the manifest
let parent_package_type = manifest.package.as_ref().map(|p| p.kind);
// Add root dependencies
for dependency in manifest.dependencies.iter().flatten() {
builder
.add_dependency(dependency, parent_package_type)
.await
.wrap_err_with(|| {
format!(
"while resolving dependencies of {}",
manifest
.package
.as_ref()
.map(|p| p.name.to_string())
.unwrap_or_else(|| "root".to_string())
)
})?;
}
Ok(Self {
nodes: builder.nodes,
network_mode,
})
}
/// Returns dependencies in topological order (dependencies before dependents)
///
/// This is a convenience method that combines topological_sort with node lookup
pub fn ordered_dependencies(&self) -> Result<Vec<DependencyDetails>, DependencyError> {
let sorted_names = self.topological_sort()?;
Ok(sorted_names
.into_iter()
.filter_map(|name| {
self.nodes.get(&name).map(|node| DependencyDetails {
name: name.clone(),
node: node.clone(),
})
})
.collect())
}
/// Perform topological sort on the dependency graph
///
/// Returns packages in installation order (dependencies before dependents)
/// Detects cycles and returns an error if found
///
/// Implements Kahn's algorithm
pub fn topological_sort(&self) -> Result<Vec<PackageName>, DependencyError> {
let mut in_degree: HashMap<PackageName, usize> = HashMap::new();
let mut adj_list: HashMap<PackageName, Vec<PackageName>> = HashMap::new();
// Initialize in-degree and adjacency list
// For topological sort: process dependencies before dependents
// in_degree[A] = number of packages A depends on
// adj_list[A] = list of packages that depend on A
for (name, node) in &self.nodes {
in_degree.entry(name.clone()).or_insert(0);
for dep in &node.dependencies {
// name depends on dep, so increment names in-degree
*in_degree.entry(name.clone()).or_insert(0) += 1;
// Add name to dep's dependents list
adj_list.entry(dep.clone()).or_default().push(name.clone());
}
}
// Initialize queue with V that don't depend on any other node.
// At least one such E needs exist, otherwise a cycle exists
let mut queue: VecDeque<PackageName> = in_degree
.iter()
.filter(|&(_, degree)| *degree == 0)
.map(|(name, _)| name.clone())
.collect();
let mut sorted = Vec::new();
// Process queue, add process V to sorted list
while let Some(node) = queue.pop_front() {
sorted.push(node.clone());
if let Some(neighbors) = adj_list.get(&node) {
for neighbor in neighbors {
if let Some(degree) = in_degree.get_mut(neighbor) {
*degree -= 1;
let no_incoming_edges = *degree == 0;
if no_incoming_edges {
queue.push_back(neighbor.clone());
}
}
}
}
}
// Cycles should not happen since we check during graph constructon, but
if sorted.len() != self.nodes.len() {
let unprocessed: Vec<_> = self
.nodes
.keys()
.filter(|name| !sorted.contains(name))
.map(|n| n.to_string())
.collect();
return Err(DependencyError::CircularDependency(
unprocessed.join(" -> "),
));
}
Ok(sorted)
}
/// Gets the number of packages that depend on a package
pub fn dependants_count_of(&self, package_name: &PackageName) -> usize {
self.nodes
.values()
.filter(|node| node.dependencies.contains(package_name))
.count()
}
}
/// Internal builder for constructing the dependency graph
struct GraphBuilder<'a> {
nodes: HashMap<PackageName, DependencyNode>,
base_path: PathBuf,
/// Track which packages we're currently visiting to detect cycles during construction
visiting: HashSet<PackageName>,
credentials: &'a Credentials,
lockfile: Option<Lockfile>,
registry_clients: HashMap<RegistryUri, Artifactory>,
network_mode: NetworkMode,
}
impl<'a> GraphBuilder<'a> {
fn new(
base_path: PathBuf,
credentials: &'a Credentials,
lockfile: Option<Lockfile>,
network_mode: NetworkMode,
) -> Self {
Self {
nodes: HashMap::new(),
base_path,
visiting: HashSet::new(),
credentials,
lockfile,
registry_clients: HashMap::new(),
network_mode,
}
}
#[async_recursion]
async fn add_dependency(
&mut self,
dependency: &Dependency,
parent_type: Option<PackageType>,
) -> miette::Result<()> {
let package_name = &dependency.package;
// Check for cycle during traversal
if self.visiting.contains(package_name) {
bail!(DependencyError::CircularDependency(format!(
"detected while processing {}",
package_name
)));
}
// If already processed, just validate compatibility
if let Some(existing) = self.nodes.get(package_name) {
self.validate_compatibility(dependency, existing)
.wrap_err_with(|| format!("conflicting dependency on {}", package_name))?;
return Ok(());
}
// Mark as visiting
self.visiting.insert(package_name.clone());
match &dependency.manifest {
DependencyManifest::Local(local) => {
self.add_local_dependency(dependency, local, parent_type)
.await?;
}
DependencyManifest::Remote(remote) => {
self.add_remote_dependency(dependency, remote, parent_type)
.await?;
}
}
// Unmark as visiting
self.visiting.remove(package_name);
Ok(())
}
async fn add_local_dependency(
&mut self,
dependency: &Dependency,
local_manifest: &LocalDependencyManifest,
parent_type: Option<PackageType>,
) -> miette::Result<()> {
let resolved_path = self.base_path.join(&local_manifest.path);
let manifest_path = resolved_path.join(MANIFEST_FILE);
let manifest = Manifest::require_package_manifest(&manifest_path).await?;
let package_type = manifest.package.as_ref().map(|p| p.kind);
Self::ensure_lib_not_depends_on_api(dependency, parent_type, package_type)?;
let sub_dependencies: Vec<PackageName> = manifest.get_dependency_package_names();
// Add node
self.nodes.insert(
dependency.package.clone(),
DependencyNode {
name: dependency.package.clone(),
package_type,
source: DependencySource::Local {
path: resolved_path.clone(),
},
dependencies: sub_dependencies.clone(),
version: VersionReq::STAR,
},
);
// Recursively process dependencies with the new base path
for sub_dep in manifest.dependencies.unwrap_or_default() {
// We need to update the base path for sub-dependencies
let old_base = self.base_path.clone();
self.base_path = resolved_path.clone();
self.add_dependency(&sub_dep, package_type)
.await
.wrap_err_with(|| {
format!("while resolving dependencies of {}", dependency.package)
})?;
self.base_path = old_base;
}
Ok(())
}
/// Ensures that a lib package doesn't depend on an api package
fn ensure_lib_not_depends_on_api(
dependency: &Dependency,
parent_type: Option<PackageType>,
package_type: Option<PackageType>,
) -> miette::Result<()> {
// Validate package type constraint
if let Some(PackageType::Lib) = parent_type
&& let Some(PackageType::Api) = package_type
{
bail!(DependencyError::InvalidPackageTypeDependency {
parent: PackageName::unchecked("parent"),
dependency: dependency.package.clone(),
});
}
Ok(())
}
async fn add_remote_dependency(
&mut self,
dependency: &Dependency,
remote_manifest: &crate::manifest::RemoteDependencyManifest,
parent_type: Option<PackageType>,
) -> miette::Result<()> {
let package_name = &dependency.package;
let registry = &remote_manifest.registry;
let repository = &remote_manifest.repository;
let version = &remote_manifest.version;
let package = {
let reformatted = version
.to_string()
.chars()
.skip_while(|c| *c == '=')
.collect::<String>();
let version = reformatted
.parse()
.map_err(|e| miette::miette!("{e}"))
.wrap_err_with(|| {
format!("expected only exact version requirements: {package_name}@{version}")
})?;
let mut cached_package = None;
// Try to resolve from lockfile + cache first
if let Some(lockfile) = &self.lockfile
&& let Some(file_req) = lockfile.get(package_name, &version)
{
// Verify registry matches (lockfile vs manifest)
if file_req.url().as_str().starts_with(registry.as_str()) {
let cache = Cache::open().await?;
if let Ok(Some(pkg)) = cache.get(file_req).await {
tracing::debug!("resolved {}@{} from local cache", package_name, version);
cached_package = Some(pkg);
}
}
}
match (cached_package, self.network_mode) {
(Some(pkg), _) => pkg,
(None, NetworkMode::Online) => {
tracing::debug!("downloading {}@{} from registry", package_name, version);
// Reuse or create artifactory client
let artifactory = if let Some(client) = self.registry_clients.get(registry) {
client.clone()
} else {
let client = Artifactory::new(registry.clone(), self.credentials)
.wrap_err_with(|| {
format!("failed to initialize registry {}", registry)
})?;
self.registry_clients
.insert(registry.clone(), client.clone());
client
};
artifactory.download(dependency.clone()).await?
}
(None, NetworkMode::Offline) => {
bail!(DependencyError::Offline {
name: package_name.clone(),
version: remote_manifest.version.clone(),
});
}
}
};
// Read the package manifest to discover dependencies and package type
let manifest = package.manifest;
let package_type = manifest.package.as_ref().map(|p| p.kind);
Self::ensure_lib_not_depends_on_api(dependency, parent_type, package_type)?;
let sub_dependencies: Vec<PackageName> = manifest.get_dependency_package_names();
// Add node with discovered metadata
self.nodes.insert(
package_name.clone(),
DependencyNode {
name: package_name.clone(),
package_type,
source: DependencySource::Remote {
registry: registry.clone(),
repository: repository.clone(),
},
dependencies: sub_dependencies.clone(),
version: version.clone(),
},
);
// Recursively process transitive dependencies
for sub_dep in manifest.dependencies.unwrap_or_default() {
self.add_dependency(&sub_dep, package_type)
.await
.wrap_err_with(|| format!("while resolving dependencies of {}", package_name))?;
}
Ok(())
}
fn validate_compatibility(
&self,
dependency: &Dependency,
existing: &DependencyNode,
) -> miette::Result<()> {
// Check for local/remote conflicts
self.validate_manifest_conflicts(dependency, existing)?;
// Check for version conflicts on remote dependencies
self.validate_version_compatibility(dependency, existing)?;
Ok(())
}
/// Validates that version requirements are compatible when the same package is requested multiple times
fn validate_version_compatibility(
&self,
dependency: &Dependency,
existing: &DependencyNode,
) -> miette::Result<()> {
// Only check version compatibility for remote dependencies
if let (DependencyManifest::Remote(new_remote), DependencySource::Remote { .. }) =
(&dependency.manifest, &existing.source)
{
// For now, buffrs only supports pinned versions (see TODO #205)
// We check if the version requirements are equal since they should be exact pins
// In the future with dynamic version resolution, this would need to check for compatibility
if new_remote.version != existing.version {
bail!(DependencyError::VersionConflict {
package: dependency.package.clone(),
required_version: new_remote.version.clone(),
existing_version: existing.version.clone(),
});
}
}
Ok(())
}
/// Checks for conflicting dependencies between local / remote deps in the dependency tree
fn validate_manifest_conflicts(
&self,
dependency: &Dependency,
existing: &DependencyNode,
) -> miette::Result<()> {
match (&dependency.manifest, &existing.source) {
(DependencyManifest::Local(_), DependencySource::Remote { .. }) => {
bail!(DependencyError::LocalRemoteConflict {
package: dependency.package.clone(),
});
}
(DependencyManifest::Remote(_), DependencySource::Local { .. }) => {
bail!(DependencyError::LocalRemoteConflict {
package: dependency.package.clone(),
});
}
_ => {}
}
Ok(())
}
}
/// Errors that can occur during dependency resolution
#[derive(Error, Diagnostic, Debug)]
pub enum DependencyError {
/// A local dependency conflicts with a remote dependency
#[error("local/remote dependency conflict for package {package}")]
LocalRemoteConflict {
/// The package that has the conflict
package: PackageName,
},
/// A lib package cannot depend on an api package
#[error("package of type lib cannot depend on package of type api: {parent} -> {dependency}")]
InvalidPackageTypeDependency {
/// The parent lib package
parent: PackageName,
/// The api package being depended on
dependency: PackageName,
},
/// A circular dependency was detected in the dependency graph
#[error("circular dependency detected: {0}")]
CircularDependency(String),
/// Version conflict between multiple dependants
#[error(
"version conflict for {package}: requires {required_version} but already resolved to {existing_version}"
)]
VersionConflict {
/// The package with conflicting versions
package: PackageName,
/// The version requirement that conflicts
required_version: VersionReq,
/// The version already resolved in the graph
existing_version: VersionReq,
},
/// Failed to download a dependency from the registry
#[error("failed to download dependency {name}@{version} from the registry")]
DownloadError {
/// Package name
name: PackageName,
/// Version requirement
version: VersionReq,
},
/// A network request was needed but --offline mode is active
#[error("cannot fetch {name}@{version} in offline mode")]
#[diagnostic(help(
"run `buffrs install` without --offline to cache {name}@{version},\n
or set BUFFRS_CACHE to a pre-populated cache directory"
))]
Offline {
/// Package name
name: PackageName,
/// Version requirement
version: VersionReq,
},
}