btctax-cli 0.13.0

btctax — an offline, single-user US Bitcoin tax ledger (CLI: import, reconcile, and compute).
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
//! Defensive Filing Wizard, sub-project-2 Phase P-A, Task 1 — the PROMOTE chokepoint: a reusable
//! plan/confirm/apply pipeline extracted VERBATIM from the shipped CLI verb
//! (`cmd::promote::promote_tranche`, Approach-B Task 10, `cmd/promote.rs:364-488`) so a future TUI can
//! drive the EXACT SAME gated pipeline as the CLI. `cmd::promote::promote_tranche` is now a thin driver
//! over this module: `Session::open` → build args → `plan_promote` (map `Refusal` → `CliError`) →
//! `println!("{}", render_consent(&plan))` → prompt/collect ack → `apply_promote`.
//!
//! **Gate ordering (DFW-D2) MUST match `cmd/promote.rs:378-485` exactly:** resolve-live → BG-D5
//! provenance → BG-D7 Part II → BG-D3 floor/coverage → BG-D6 `consent_terms` → synthetic-promote advisory
//! → gift-only relabel → consent render (incl. `wide_window_note`) → **ack inside `apply_promote`,
//! fail-closed** → `would_conflict` → append.
//!
//! ★ **I-1 (byte-parity):** the shipped verb prints, IN ORDER (`promote.rs:443-455`), the
//! synthetic-promote ADVISORY (pre-consent) → `render_consent(&terms, &gift_only_years)` → the
//! `wide_window_note` (post-consent). `PromotePlan` therefore carries THREE ordered pieces
//! (`advisory_lines`, `gift_only_years`, `post_consent_note`) so this module's `render_consent(&plan)`
//! reproduces `advisory → consent → note` byte-for-byte when printed via a single `println!` — a single
//! flat `Vec` cannot place `terms` BETWEEN the pre-advisory and the note; do NOT collapse the three. The
//! shipped `render_consent(terms, gift_only_years)` stays in `cmd::promote` (still `pub` — external KATs
//! in `tests/promote_cli.rs` call it directly — and is invoked from here); `gift_only_flagged_years`/
//! `wide_window_note` move HERE.
//!
//! ★ **DFW-D6 (the ONE intended behavior change — the sub-1 pseudo-off fix):** `plan_promote` forces
//! `cfg.pseudo_reconcile = false` on its own COPY (`ProjectionConfig` is `Copy`) before `consent_terms` /
//! `promote_prior_year_advisory` / `gift_only_flagged_years` — mirroring `would_conflict`
//! (`project/mod.rs:118`). Without this, a pseudo-active vault's consent screen — and the RECORDED
//! `Acknowledgment.shown_terms`, the §6664(c) good-faith artifact — could fold in a synthetic default that
//! was never persisted, misstating what the filer actually acknowledged.
//!
//! ★ **arch-m-6/tax-N-1:** `Refusal::Target` covers the resolve-live gate — unknown/voided/wrong-type
//! target only (`resolve_live_tranche`). Already-promoted (a DOUBLE promote) is NOT caught here; it
//! surfaces as `would_conflict` at APPLY time (a `CliError`, never a plan `Refusal`) — mirroring
//! `promote.rs:475-483`.
//!
//! ★ **arch-m-new-3:** `plan_promote` takes no `Session`/`state` — the shipped pipeline rebuilds
//! everything from `events` (`promote.rs:364-488`) — so a caller (CLI or future TUI) supplies its own
//! already-loaded `events`/`prices`/`cfg`.
//!
//! **Task 2 — the DECLARE chokepoint:** `plan_declare`/`apply_declare`, extracted from the shipped
//! `cmd::tranche::declare_tranche` (`tranche.rs:120-175`). `plan_declare` gates on the shipped set
//! (`sat>0`, `ws<=we`, `guard_tranche_vs_allocation` — the LAST one stays defined in `cmd::tranche`, not
//! duplicated here) ALWAYS; **iff `target_shortfall = Some(id)`** it ALSO runs the DFW-D5.2 target-scoped
//! clearance shadow: append the candidate `DeclareTranche` → re-project (pseudo FORCED off, mirroring
//! `would_conflict`) → assert no `BlockerKind::UncoveredDisposal` remains on `id`; else `Refusal::Coverage`.
//! `target_shortfall = None` (the CLI free-form path) is the shipped `declare_tranche` gate set,
//! BYTE-FOR-BYTE (DFW-D8/SPEC §5) — no clearance shadow runs at all. `apply_declare` is a plain
//! append+save (declaring is `$0`/revocable/no-Form-8275 — DFW-D8 — so unlike promote there is no
//! acknowledgment gate and no `would_conflict` pre-check; the shipped verb never ran one either).
//!
//! ★ **Refusal-variant note:** the shared `Refusal` enum stays CLOSED at the four Task-1 variants (the
//! plan review explicitly rejected adding a new `Conflict` variant for this task). The shipped-set gates
//! (sat/window/allocation) have no promote-shaped variant of their own, so — like the new clearance
//! failure the brief names explicitly — they map to `Refusal::Coverage`. Every variant collapses to the
//! identical `CliError::Usage(msg)` via `From<Refusal>` (below), so this is a pure internal-taxonomy
//! choice: the filer-facing message text is unchanged from the shipped verb either way.

use crate::cmd::promote::{
    render_consent as render_consent_terms, ProvenanceKind, PROMOTE_ACK_PHRASE, PROVENANCE_TEXT,
    PROVENANCE_VERSION,
};
use crate::{CliError, Session};
use btctax_core::conservative::{self, Direction};
use btctax_core::conservative_promote::{self, PromoteRefusal};
use btctax_core::conventions::tax_date;
use btctax_core::event::{
    Acknowledgment, ConsentTerm, DeclareTranche, EventPayload, FloorMethod, PromoteTranche,
};
use btctax_core::persistence::{append_decision, load_all};
use btctax_core::price::PriceProvider;
use btctax_core::project::ProjectionConfig;
use btctax_core::state::BlockerKind;
use btctax_core::{
    project, EventId, LedgerEvent, LedgerState, RemovalKind, Sat, TaxDate, Usd, WalletId,
};
use std::collections::BTreeSet;
use time::{OffsetDateTime, UtcOffset};

/// Everything computed BEFORE the filer types the acknowledgment phrase (the `PromoteTranche` decision
/// id, `target`, is not yet known — it is assigned at `apply_promote`'s `append_decision`). ★ I-1: the
/// three ordered fields (`advisory_lines`, `gift_only_years`, `post_consent_note`) let `render_consent`
/// reproduce the shipped verb's `advisory → consent → note` byte order — do NOT collapse them into one
/// `Vec` or pre-render `gift_only_years` into a string.
#[derive(Debug, Clone)]
pub struct PromotePlan {
    /// The `DeclareTranche` decision this promotes (BG-D1) — the `PromoteTranche.target` field.
    pub target: EventId,
    /// BG-D6 `consent_terms` output — ALSO snapshotted verbatim onto `payload`'s
    /// `Acknowledgment.shown_terms` (the §6664(c) good-faith artifact).
    pub terms: Vec<ConsentTerm>,
    /// The PRE-consent synthetic-promote advisory lines (`promote.rs:443`, `for line in &advisory`).
    pub advisory_lines: Vec<String>,
    /// T9 handoff: an INPUT to the shipped `render_consent(terms, gift_only_years)`
    /// (`promote.rs:333`/`:453`) — NOT a pre-rendered string.
    pub gift_only_years: BTreeSet<i32>,
    /// `wide_window_note`, printed AFTER the consent screen (`promote.rs:454`).
    pub post_consent_note: Option<String>,
    /// The `PromoteTranche` payload `apply_promote` appends on a successful acknowledgment.
    pub payload: EventPayload,
}

/// A `plan_promote` refusal — fail-closed, BEFORE any computation past the failing gate. Each variant
/// carries the exact filer-facing message (byte-identical to the shipped verb's `CliError::Usage` text),
/// so mapping to `CliError` (the thin CLI driver) or a distinct TUI error surface is trivial either way.
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum Refusal {
    /// The resolve-live gate (`resolve_live_tranche`): `target` is absent, wrong-type, or voided.
    Target(String),
    /// BG-D5: a non-`Purchase` provenance.
    Provenance(String),
    /// BG-D3 (promote): `filed_basis_for` could not produce a trustworthy floor
    /// (`NoCoverage`/`PartialCoverage`). ALSO (Task 2, declare): the shipped-set gates (`sat>0`, `ws<=we`,
    /// `guard_tranche_vs_allocation`) AND the DFW-D5.2 target-scoped clearance shadow (a candidate tranche
    /// that does not clear the named shortfall) — see the module doc's "Refusal-variant note".
    Coverage(String),
    /// BG-D7: an empty/whitespace Form 8275 Part II narrative.
    PartII(String),
}

impl From<Refusal> for CliError {
    fn from(r: Refusal) -> CliError {
        let msg = match r {
            Refusal::Target(m) => m,
            Refusal::Provenance(m) => m,
            Refusal::Coverage(m) => m,
            Refusal::PartII(m) => m,
        };
        CliError::Usage(msg)
    }
}

/// True iff a live (non-voided) `VoidDecisionEvent` names `id`. Moved verbatim from `cmd/promote.rs`.
fn is_voided(events: &[LedgerEvent], id: &EventId) -> bool {
    events.iter().any(
        |e| matches!(&e.payload, EventPayload::VoidDecisionEvent(v) if v.target_event_id == *id),
    )
}

/// Resolve `target_event_id` to a LIVE (present, non-voided) `DeclareTranche`, or `Refusal::Target`. A
/// record-time convenience guard — the engine's own `DecisionConflict` adjudication is the backstop for
/// any target this misses (moved verbatim from `cmd/promote.rs::resolve_live_tranche`, DFW-D2 gate 1).
fn resolve_live_tranche(
    events: &[LedgerEvent],
    target_event_id: &EventId,
) -> Result<DeclareTranche, Refusal> {
    let not_live = || {
        Refusal::Target(format!(
            "{} is not a live DeclareTranche (absent, wrong type, or voided) — see `btctax events list` \
             for event refs + decision status",
            target_event_id.canonical()
        ))
    };
    if is_voided(events, target_event_id) {
        return Err(not_live());
    }
    events
        .iter()
        .find(|e| e.id == *target_event_id)
        .and_then(|e| match &e.payload {
            EventPayload::DeclareTranche(t) => Some(t.clone()),
            _ => None,
        })
        .ok_or_else(not_live)
}

/// BG-D5: refuse a non-`Purchase` provenance — the closed enumeration, fail-closed, before any
/// computation. Moved verbatim from `cmd/promote.rs::refuse_non_purchase`.
fn refuse_non_purchase(provenance: ProvenanceKind) -> Refusal {
    Refusal::Provenance(format!(
        "promote-tranche requires purchase provenance: {PROVENANCE_TEXT}. This tranche was declared as \
         acquired by {label} — a {label} recipient already has a documented, real basis (income \
         FMV-at-receipt; a §1015 donor carryover for a gift; a §1014 date-of-death basis for an \
         inheritance) — model the real acquisition instead (a documented \
         Acquire/Income/gift-received event), not a conservative-filing tranche promote.",
        label = provenance.label(),
    ))
}

/// BG-D3: translate a `filed_basis_for` refusal into a record-time message. Moved verbatim from
/// `cmd/promote.rs::refuse_no_floor`.
fn refuse_no_floor(e: PromoteRefusal, window_start: TaxDate, window_end: TaxDate) -> Refusal {
    let detail = match e {
        PromoteRefusal::NoCoverage => {
            "no bundled daily-close price exists anywhere in the window — never fabricate a floor over a \
             total data gap"
        }
        PromoteRefusal::PartialCoverage => {
            "the window has a gap in bundled daily-close data — the covered-part minimum is not provably \
             the window's true minimum, so it cannot be filed as a trustworthy floor"
        }
    };
    Refusal::Coverage(format!(
        "cannot compute a promotion floor for the window [{window_start}, {window_end}]: {detail}. \
         Narrow the window to a fully-covered range, or leave this tranche at its filed $0 basis."
    ))
}

/// A filer-facing caution (SPEC §1, "two honest limits"): a wide acquisition window yields a LOW
/// ("trivial") floor relative to a tight one. Purely informational, non-gating; conditioned on the
/// window exceeding one year. Moved verbatim from `cmd/promote.rs::wide_window_note`.
fn wide_window_note(window_start: TaxDate, window_end: TaxDate) -> Option<String> {
    let days = (window_end - window_start).whole_days();
    if days > 365 {
        Some(format!(
            "note: this tranche's declared window spans {days} days (over a year). A WIDE window tends \
             to produce a LOW (\"trivial\") floor relative to a tight one — for some filers it may be \
             simpler, and just as conservative, to leave this tranche at its filed $0 basis and skip the \
             Form 8275 disclosure surface entirely."
        ))
    } else {
        None
    }
}

/// Thread ONE synthetic `PromoteTranche(tranche_id, filed_basis)` onto `events` (mirrors
/// `conservative_promote::with_synthetic_promote`, private there). Moved verbatim from
/// `cmd/promote.rs::with_synthetic_promote`.
fn with_synthetic_promote(
    events: &[LedgerEvent],
    tranche_id: &EventId,
    filed_basis: Usd,
    now: OffsetDateTime,
) -> Vec<LedgerEvent> {
    let seq = events
        .iter()
        .filter_map(|e| match e.id {
            EventId::Decision { seq } => Some(seq),
            _ => None,
        })
        .max()
        .map_or(1, |m| m + 1);
    let mut out = events.to_vec();
    out.push(LedgerEvent {
        id: EventId::decision(seq),
        utc_timestamp: now,
        original_tz: UtcOffset::UTC,
        wallet: None,
        payload: EventPayload::PromoteTranche(PromoteTranche {
            target: tranche_id.clone(),
            method: FloorMethod::WindowLowClose,
            filed_basis,
            coverage: conservative::Coverage::Full,
            provenance_attested: true,
            acknowledgment: Acknowledgment {
                phrase: String::new(),
                shown_terms: Vec::new(),
                provenance_text: String::new(),
                provenance_version: String::new(),
            },
            part_ii_narrative: String::new(),
        }),
    });
    out
}

/// T9 handoff (progress.md Task 9): `consent_terms`/`Uncomputable` sum the §170(e) charitable-deduction
/// change and the §1015 gift-basis change into ONE `deduction_delta_usd` figure per year. This re-derives
/// which flagged years are GIFT-only directly from the SAME with/without fold pair the T8 advisory
/// already builds. Moved verbatim from `cmd/promote.rs::gift_only_flagged_years`.
fn gift_only_flagged_years(
    prices: &dyn PriceProvider,
    config: &ProjectionConfig,
    events: &[LedgerEvent],
    with_events: &[LedgerEvent],
) -> BTreeSet<i32> {
    let without_state = project(events, prices, config);
    let with_state = project(with_events, prices, config);

    let mut years: BTreeSet<i32> = BTreeSet::new();
    for st in [&with_state, &without_state] {
        for r in &st.removals {
            years.insert(r.removed_at.year());
        }
    }

    let rem =
        |st: &btctax_core::LedgerState, y: i32, k: RemovalKind| -> Vec<btctax_core::Removal> {
            st.removals
                .iter()
                .filter(|r| r.removed_at.year() == y && r.kind == k)
                .cloned()
                .collect()
        };

    years
        .into_iter()
        .filter(|&y| {
            let gift_changed =
                rem(&with_state, y, RemovalKind::Gift) != rem(&without_state, y, RemovalKind::Gift);
            let don_changed = rem(&with_state, y, RemovalKind::Donation)
                != rem(&without_state, y, RemovalKind::Donation);
            gift_changed && !don_changed
        })
        .collect()
}

/// The acknowledgment gate (BG-D6) — a PURE exact-compare, no I/O (mirrors `require_attestation`,
/// `lib.rs:208`). Moved verbatim from `cmd/promote.rs::require_promote_ack`; now called from
/// `apply_promote`, fail-closed, BEFORE `would_conflict`/append.
fn require_promote_ack(acknowledge: Option<&str>) -> Result<(), CliError> {
    match acknowledge.map(str::trim) {
        Some(p) if p == PROMOTE_ACK_PHRASE => Ok(()),
        Some(_) => Err(CliError::Usage(format!(
            "the acknowledgment phrase did not match. Type it EXACTLY (trimmed, case-sensitive): {PROMOTE_ACK_PHRASE:?}."
        ))),
        None => Err(CliError::Usage(format!(
            "promote-tranche requires acknowledging the estimated-basis risk shown above — pass \
             --i-acknowledge {PROMOTE_ACK_PHRASE:?} (or type it at the interactive prompt)."
        ))),
    }
}

/// Plan a `PromoteTranche` decision — the DFW-D2 gate order, everything computable BEFORE the filer types
/// the acknowledgment phrase: resolve-live → BG-D5 provenance → BG-D7 Part II → BG-D3 floor/coverage →
/// BG-D6 `consent_terms` → synthetic-promote advisory → gift-only relabel. `events`/`prices`/`cfg` are the
/// caller's own already-loaded state (arch-m-new-3: no `Session` here — the CLI's thin driver and a
/// future TUI each supply their own).
pub fn plan_promote(
    events: &[LedgerEvent],
    prices: &dyn PriceProvider,
    cfg: &ProjectionConfig,
    target: &EventId,
    provenance: ProvenanceKind,
    part_ii: &str,
    now: OffsetDateTime,
) -> Result<PromotePlan, Refusal> {
    // Resolve + assert live (BG-D1).
    let tranche = resolve_live_tranche(events, target)?;

    // BG-D5: purchase provenance only — fail-closed, before any computation.
    if provenance != ProvenanceKind::Purchase {
        return Err(refuse_non_purchase(provenance));
    }

    // BG-D7: an empty/whitespace Part II narrative is refused at record time (present-by-construction).
    if part_ii.trim().is_empty() {
        return Err(Refusal::PartII(
            "promote-tranche requires a non-empty Form 8275 Part II narrative (filer facts, Reg. \
             §1.6662-4(f) — 'in sufficient detail') — pass --part-ii-file pointing at a file with real \
             acquisition/window facts, not an empty or blank file"
                .into(),
        ));
    }

    // BG-D3: the computed whole-tranche filed_basis floor — hard-refuse on Partial/No coverage.
    let floor = conservative_promote::filed_basis_for(
        prices,
        tranche.sat,
        tranche.window_start,
        tranche.window_end,
    )
    .map_err(|e| refuse_no_floor(e, tranche.window_start, tranche.window_end))?;

    // ★ DFW-D6 (the ONE intended behavior change): force pseudo OFF on an own COPY (ProjectionConfig is
    // Copy) before consent_terms / promote_prior_year_advisory / gift_only_flagged_years — mirrors
    // `would_conflict` (`project/mod.rs:118`). The recorded Acknowledgment.shown_terms must always
    // reflect the HONEST (non-synthetic) figures, never a pseudo-active default folded in.
    let mut honest_cfg = *cfg;
    honest_cfg.pseudo_reconcile = false;

    let tables = btctax_adapters::BundledTaxTables::load();
    // A single stored TaxProfile cannot fit the multi-year span this consent/advisory ranges over, so
    // `None` is passed throughout — mirrors the void-direction path (`cmd/reconcile.rs`
    // `promote_void_advisory_lines`): the tax-Δ arm falls back to the gain/deduction-Δ sign, and the
    // amend direction is still correct.
    let terms = conservative_promote::consent_terms(
        events,
        prices,
        &honest_cfg,
        target,
        floor.filed_basis,
        None,
        &tables,
    );

    // Thread ONE synthetic promote so the Direction::Promote advisory AND this layer's own
    // gift-vs-donation year classification (T9 handoff) see the SAME post-promote fold.
    let with_events = with_synthetic_promote(events, target, floor.filed_basis, now);
    let synthetic_id = with_events
        .last()
        .expect("with_synthetic_promote always pushes exactly one event")
        .id
        .clone();

    // T8 handoff (progress.md): `current` is the injected `now`'s tax year (the BTCTAX_NOW seam) — NEVER
    // a wall clock. Years `< current` are presumed already filed; the year still being authored
    // (>= current) is excluded, so it is never told it needs an amended return.
    let current = tax_date(now, UtcOffset::UTC).year();
    let advisory_lines = conservative::promote_prior_year_advisory(
        &with_events,
        prices,
        &honest_cfg,
        &synthetic_id,
        Direction::Promote,
        None,
        &tables,
        current,
    );

    // T9 handoff: which flagged years are GIFT-ONLY (no donation) — relabels that year's deduction/basis-Δ
    // as a §1015 donee-basis change, never Schedule-A, in the consent screen below.
    let gift_only_years = gift_only_flagged_years(prices, &honest_cfg, events, &with_events);

    let payload = EventPayload::PromoteTranche(PromoteTranche {
        target: target.clone(),
        method: FloorMethod::WindowLowClose,
        filed_basis: floor.filed_basis,
        coverage: floor.coverage,
        provenance_attested: true,
        acknowledgment: Acknowledgment {
            phrase: PROMOTE_ACK_PHRASE.to_string(),
            shown_terms: terms.clone(),
            provenance_text: PROVENANCE_TEXT.to_string(),
            provenance_version: PROVENANCE_VERSION.to_string(),
        },
        part_ii_narrative: part_ii.to_string(),
    });

    Ok(PromotePlan {
        target: target.clone(),
        terms,
        advisory_lines,
        gift_only_years,
        post_consent_note: wide_window_note(tranche.window_start, tranche.window_end),
        payload,
    })
}

/// Re-emit the shipped verb's ordered filer-visible text: `advisory_lines` → the shipped
/// `render_consent(&plan.terms, &plan.gift_only_years)` (`cmd::promote`) → `post_consent_note` — ★ I-1:
/// byte-identical to `promote.rs:443-455` when the RESULT is printed via a single
/// `println!("{}", render_consent(&plan))` (the shipped verb instead used three separate `println!`
/// calls; a single combined string reproduces the exact same stdout bytes because `println!` always adds
/// exactly one trailing `\n`). Do NOT collapse this into `plan.terms`/`plan.gift_only_years` alone — the
/// pre-advisory must land BEFORE the consent screen and the note AFTER it.
pub fn render_consent(plan: &PromotePlan) -> String {
    let mut out = String::new();
    for line in &plan.advisory_lines {
        out.push_str(line);
        out.push('\n');
    }
    out.push_str(&render_consent_terms(&plan.terms, &plan.gift_only_years));
    if let Some(note) = &plan.post_consent_note {
        out.push('\n');
        out.push_str(note);
    }
    out
}

/// Apply a planned promote: the acknowledgment gate (BG-D6, fail-closed, INSIDE apply) → `would_conflict`
/// pre-check (BG-D9 — a second live promote on this target, or any other resolver-level conflict; refuses
/// BEFORE appending, NOT last-wins) → append + save. Reloads `events`/`cfg` fresh from `session`
/// (arch-m-new-3: `plan_promote` took no `Session`) — a single synchronous CLI/TUI invocation cannot
/// append anything between `plan_promote` and `apply_promote`, so this is behavior-preserving.
pub fn apply_promote(
    session: &mut Session,
    plan: PromotePlan,
    acknowledge: Option<&str>,
    now: OffsetDateTime,
) -> Result<EventId, CliError> {
    require_promote_ack(acknowledge)?;

    let events = load_all(session.conn())?;
    let cfg = session.config()?.to_projection();

    // BG-D9: pre-check `would_conflict` (a second live promote on this target, or any other resolver-level
    // conflict, e.g. UX-P4-3) — refuse BEFORE appending (fail-closed). NOT last-wins.
    if let Some(detail) =
        btctax_core::would_conflict(&events, session.prices(), &cfg, &plan.payload, now)
    {
        return Err(CliError::Usage(format!(
            "cannot record this promote — a decision conflict: {detail}"
        )));
    }

    let id = append_decision(session.conn(), plan.payload, now, UtcOffset::UTC, None)?;
    session.save()?;
    Ok(id)
}

// ════════════════════════════════════════════════════════════════════════════════════════════════
// Task 2 — the DECLARE chokepoint: `plan_declare`/`apply_declare` (module doc has the full contract).
// ════════════════════════════════════════════════════════════════════════════════════════════════

/// Everything needed to append a `DeclareTranche` decision. Unlike `PromotePlan`, declaring has no
/// acknowledgment gate or consent screen (DFW-D8 — a plain `$0`, revocable confirmation) — so there is
/// nothing else to carry beside the payload itself.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct DeclarePlan {
    /// The `EventPayload::DeclareTranche` `apply_declare` appends verbatim.
    pub payload: EventPayload,
}

/// Plan a `DeclareTranche` decision. Gates on the shipped set ALWAYS — `sat>0`, `ws<=we`,
/// `guard_tranche_vs_allocation` (`cmd::tranche`, the single source of that guard for all four allocation
/// append sites — NOT duplicated here) — replicating `cmd/tranche.rs:134-154` exactly (arch-m-new-3: no
/// `Session` — the caller supplies its own already-loaded `events`/`prices`/`cfg`, mirroring
/// `plan_promote`).
///
/// **Iff `target_shortfall = Some(id)`**, ALSO runs the DFW-D5.2 target-scoped clearance shadow: append
/// the candidate `DeclareTranche` → re-project (pseudo FORCED off on a config COPY, mirroring
/// `would_conflict`, `project/mod.rs:118`) → assert no `BlockerKind::UncoveredDisposal` remains on `id`;
/// else `Refusal::Coverage`. **Forcing pseudo off here is load-bearing (arch-I-5):** a synthetic
/// `SelfTransferMine{$0}` pseudo default must never stand in for a real, documented cover — else a
/// dashboard candidate could be reported as "clears the shortfall" when only a fictional, non-persisted
/// default actually covered it.
///
/// `target_shortfall = None` (the CLI free-form `declare-tranche` path) never runs the clearance shadow —
/// the shipped verb's gate set, byte-for-byte (DFW-D8/SPEC §5).
#[allow(clippy::too_many_arguments)]
pub fn plan_declare(
    events: &[LedgerEvent],
    prices: &dyn PriceProvider,
    cfg: &ProjectionConfig,
    sat: Sat,
    wallet: WalletId,
    window_start: TaxDate,
    window_end: TaxDate,
    target_shortfall: Option<EventId>,
    now: OffsetDateTime,
) -> Result<DeclarePlan, Refusal> {
    // The shipped gate set (cmd/tranche.rs:134-154), byte-for-byte.
    if sat <= 0 {
        // A `sat <= 0` tranche would bump `stats.sigma_in` by a non-positive amount (fold.rs),
        // corrupting Σ-conservation; there is no such thing as declaring zero/negative undocumented BTC.
        return Err(Refusal::Coverage(format!(
            "tranche amount must be > 0 sat (got {sat})"
        )));
    }
    if window_start > window_end {
        return Err(Refusal::Coverage(format!(
            "tranche window_start ({window_start}) must be <= window_end ({window_end})"
        )));
    }
    crate::cmd::tranche::guard_tranche_vs_allocation(events, window_end).map_err(|e| match e {
        CliError::Usage(m) => Refusal::Coverage(m),
        other => Refusal::Coverage(other.to_string()), // unreachable today (the guard only ever returns Usage)
    })?;

    let payload = EventPayload::DeclareTranche(DeclareTranche {
        sat,
        wallet,
        window_start,
        window_end,
    });

    // DFW-D5.2: the target-scoped clearance shadow — ONLY when the caller names a shortfall to cover.
    if let Some(id) = target_shortfall {
        // ★ arch-I-5: pseudo FORCED off on a COPY (ProjectionConfig is Copy) — mirrors `would_conflict`
        // (project/mod.rs:118). Without this, a pseudo-active vault could report a candidate as clearing
        // a shortfall that only a synthetic, non-persisted SelfTransferMine{$0} default actually covered.
        let mut honest_cfg = *cfg;
        honest_cfg.pseudo_reconcile = false;

        // Append the candidate as the resolver would (the next decision seq — mirrors `would_conflict`
        // and `with_synthetic_promote` above).
        let next_seq = events
            .iter()
            .filter_map(|e| match e.id {
                EventId::Decision { seq } => Some(seq),
                _ => None,
            })
            .max()
            .map_or(1, |m| m + 1);
        let candidate = LedgerEvent {
            id: EventId::decision(next_seq),
            utc_timestamp: now,
            original_tz: UtcOffset::UTC,
            wallet: None,
            payload: payload.clone(),
        };
        let mut with_candidate = events.to_vec();
        with_candidate.push(candidate);

        let state = project(&with_candidate, prices, &honest_cfg);
        let still_uncovered = state
            .blockers
            .iter()
            .any(|b| b.kind == BlockerKind::UncoveredDisposal && b.event.as_ref() == Some(&id));
        if still_uncovered {
            return Err(Refusal::Coverage(format!(
                "this candidate tranche does not clear the shortfall on {} — after adding it, an \
                 UncoveredDisposal blocker still remains on that event. A tranche's synthetic acquisition \
                 lands at window_end and sorts AFTER a same-instant import, so window_end must be \
                 STRICTLY BEFORE the short event's date (and the wallet/sat must actually cover it) to \
                 clear it.",
                id.canonical()
            )));
        }
    }

    Ok(DeclarePlan { payload })
}

/// Apply a planned declare: append + save. No acknowledgment gate and no `would_conflict` pre-check
/// (DFW-D8 — declaring is a plain `$0`, revocable confirmation, unlike promote's typed-phrase tier; the
/// shipped verb never ran a `would_conflict` check either — `cmd/tranche.rs:166-174` appends immediately
/// once `guard_tranche_vs_allocation` passes).
pub fn apply_declare(
    session: &mut Session,
    plan: DeclarePlan,
    now: OffsetDateTime,
) -> Result<EventId, CliError> {
    let id = append_decision(session.conn(), plan.payload, now, UtcOffset::UTC, None)?;
    session.save()?;
    Ok(id)
}

// ════════════════════════════════════════════════════════════════════════════════════════════════
// 8275-completeness year enumeration. (This sat inside the Task-3 EXPORT region until 0.13.0; the
// composed multi-year export trio around it was deleted, but this helper is a LIVE `pub(crate)`
// dependency of `cmd/admin.rs`'s `promote_export_gate` and keeps its own unit test below.)

/// BG-D8's 8275-completeness year enumeration ONLY — extracted verbatim from `promote_export_gate`'s
/// `None` arm (`cmd/admin.rs`) so the gate and any other 8275-completeness caller single-source it (SPEC
/// DFW-D11: "single-sourced ... but it is NOT the export set"). A year is included iff a PROMOTED
/// disposal leg (`lot_id.origin_event_id ∈ state.promoted_origins`) files in it — DISPOSAL legs only; a
/// promote's REMOVAL (donation/gift) reorder is invisible here by design — that is exactly what
/// `flagged_years` (`btctax_core::conservative`), below, exists to also catch.
///
/// ★ whole-branch arch M-2: `pub(crate)`, not `pub`. Its only production caller is in-crate
/// (`cmd/admin.rs`'s `promote_export_gate`); it was `pub` solely to serve one integration test, which
/// would have put it on btctax-cli's v0.10.0 PUBLIC API for good. Public API is far cheaper to narrow
/// before the first release than after. The disposal-legs-only contract is pinned by the in-crate unit
/// test below instead.
pub(crate) fn promoted_filing_years(state: &LedgerState) -> BTreeSet<i32> {
    let mut years = BTreeSet::new();
    for d in &state.disposals {
        if d.legs
            .iter()
            .any(|l| state.promoted_origins.contains(&l.lot_id.origin_event_id))
        {
            years.insert(d.disposed_at.year());
        }
    }
    years
}

#[cfg(test)]
mod tests {
    use super::*;
    use btctax_core::state::{Disposal, DisposalLeg, Term};
    use btctax_core::{BasisSource, DisposeKind, LotId};
    use rust_decimal_macros::dec;
    use time::macros::date;

    fn wallet() -> WalletId {
        WalletId::SelfCustody {
            label: "pfy".into(),
        }
    }

    fn leg(origin: EventId) -> DisposalLeg {
        DisposalLeg {
            lot_id: LotId {
                origin_event_id: origin,
                split_sequence: 0,
            },
            sat: 1_000_000,
            proceeds: dec!(100),
            basis: dec!(0),
            gain: dec!(100),
            term: Term::LongTerm,
            basis_source: BasisSource::EstimatedConservative,
            gift_zone: None,
            acquired_at: date!(2016 - 03 - 31),
            wallet: wallet(),
            pseudo: false,
        }
    }

    fn disposal(year: i32, origin: EventId) -> Disposal {
        Disposal {
            event: EventId::decision(90 + year as u64 % 10),
            kind: DisposeKind::Sell,
            disposed_at: time::Date::from_calendar_date(year, time::Month::June, 1).unwrap(),
            legs: vec![leg(origin)],
            fee_mini_disposition: false,
        }
    }

    /// ★ whole-branch arch M-2 (replaces the cross-crate assertion that forced `promoted_filing_years`
    /// onto btctax-cli's PUBLIC API): the BG-D8 8275-completeness enumeration is DISPOSAL-LEG-scoped and
    /// PROMOTE-scoped — a year files here iff a disposal leg in it draws a lot whose origin is in
    /// `state.promoted_origins`. A year whose only change is a REMOVAL (donation/gift) reorder, or whose
    /// disposal legs draw an UNPROMOTED origin, is correctly absent — that is precisely the gap
    /// `conservative::flagged_years` (the DFW-D11 export set) exists to cover, and why the gate's set is
    /// explicitly NOT the export set.
    ///
    /// Mutation: drop the `promoted_origins` membership test (enumerate every disposal year) → 2024
    /// appears → reds.
    #[test]
    fn promoted_filing_years_enumerates_promoted_disposal_legs_only() {
        let promoted = EventId::decision(1);
        let unpromoted = EventId::decision(2);

        let state = LedgerState {
            disposals: vec![
                disposal(2024, unpromoted.clone()),
                disposal(2025, promoted.clone()),
            ],
            promoted_origins: [promoted].into_iter().collect(),
            ..Default::default()
        };

        let years = promoted_filing_years(&state);
        assert_eq!(
            years.iter().copied().collect::<Vec<_>>(),
            vec![2025],
            "only the year holding a PROMOTED disposal leg is enumerated: {years:?}"
        );
        assert!(
            !years.contains(&2024),
            "an unpromoted disposal leg's year must NOT enter the 8275-completeness set: {years:?}"
        );
    }
}