bssh 1.7.0

Parallel SSH command execution tool for cluster management
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98

use bssh::config::Config;

#[tokio::test]
async fn test_config_timeout_parsing() {
    let yaml = r#"
defaults:
  timeout: 120

clusters:
  production:
    nodes:
      - host1.example.com
    timeout: 60
  
  staging:
    nodes:
      - host2.example.com
"#;

    let config: Config = serde_yaml::from_str(yaml).unwrap();

    // Test default timeout
    assert_eq!(config.defaults.timeout, Some(120));

    // Test cluster-specific timeout
    assert_eq!(config.get_timeout(Some("production")), Some(60));

    // Test cluster without timeout (falls back to default)
    assert_eq!(config.get_timeout(Some("staging")), Some(120));

    // Test unknown cluster (falls back to default)
    assert_eq!(config.get_timeout(Some("unknown")), Some(120));

    // Test no cluster specified (uses default)
    assert_eq!(config.get_timeout(None), Some(120));
}

#[tokio::test]
async fn test_config_no_timeout() {
    let yaml = r#"
clusters:
  production:
    nodes:
      - host1.example.com
"#;

    let config: Config = serde_yaml::from_str(yaml).unwrap();

    // Test no timeout configured anywhere
    assert_eq!(config.defaults.timeout, None);
    assert_eq!(config.get_timeout(Some("production")), None);
}

#[tokio::test]
async fn test_config_zero_timeout() {
    let yaml = r#"
defaults:
  timeout: 0

clusters:
  production:
    nodes:
      - host1.example.com
"#;

    let config: Config = serde_yaml::from_str(yaml).unwrap();

    // Test timeout 0 (unlimited)
    assert_eq!(config.defaults.timeout, Some(0));
    assert_eq!(config.get_timeout(Some("production")), Some(0));
}

/// Test that --timeout 0 is correctly parsed as Some(0) for unlimited timeout
/// This is the fix for GitHub issue #112
#[test]
fn test_cli_timeout_zero_is_unlimited() {
    use bssh::cli::Cli;
    use clap::Parser;

    // Test --timeout 0 is parsed as Some(0), meaning unlimited
    let args = vec!["bssh", "-H", "user@host", "--timeout", "0", "echo", "test"];
    let cli = Cli::try_parse_from(args).expect("Should parse --timeout 0");
    assert_eq!(
        cli.timeout,
        Some(0),
        "--timeout 0 should be Some(0) for unlimited"
    );

    // Test --timeout with non-zero value
    let args = vec!["bssh", "-H", "user@host", "--timeout", "60", "echo", "test"];
    let cli = Cli::try_parse_from(args).expect("Should parse --timeout 60");
    assert_eq!(cli.timeout, Some(60), "--timeout 60 should be Some(60)");

    // Test no --timeout flag results in None (will use config or default)
    let args = vec!["bssh", "-H", "user@host", "echo", "test"];
    let cli = Cli::try_parse_from(args).expect("Should parse without --timeout");
    assert_eq!(cli.timeout, None, "No --timeout should be None");
}