brows3 0.2.46

Premium, Secure S3 Browser for macOS, Windows, and Linux.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
use crate::commands::profiles::ProfileState;
use crate::error::Result;
use crate::s3::{FolderContent, S3Object, S3State};
use aws_sdk_s3::Client;
use serde::{Deserialize, Serialize};
use std::collections::HashSet;
use tauri::State;

const MAX_SORTABLE_FOLDER_ITEMS: usize = 100_000;
const MAX_COMPLETE_LIST_REQUESTS: usize = 100;
const MAX_SEARCH_SCANNED_OBJECTS: u64 = 100_000;
const MAX_SEARCH_RESULTS: usize = 10_000;
const MAX_SEARCH_REQUESTS: usize = 100;
const DEFAULT_MAX_TEXT_PREVIEW_BYTES: u64 = 2 * 1024 * 1024;
const MAX_TEXT_PREVIEW_BYTES: u64 = 100 * 1024 * 1024;

fn normalized_text_preview_limit(max_bytes: Option<u64>) -> u64 {
    max_bytes
        .unwrap_or(DEFAULT_MAX_TEXT_PREVIEW_BYTES)
        .clamp(1, MAX_TEXT_PREVIEW_BYTES)
}

fn text_preview_size_error(actual_bytes: Option<u64>, max_bytes: u64) -> crate::error::AppError {
    let limit_mb = max_bytes as f64 / 1024.0 / 1024.0;
    let message = if let Some(actual_bytes) = actual_bytes {
        format!(
            "Object is too large to preview as text ({:.2} MB; configured limit {:.0} MB). Increase the text preview limit in Settings or download it.",
            actual_bytes as f64 / 1024.0 / 1024.0,
            limit_mb
        )
    } else {
        format!(
            "Object exceeds the configured text preview limit of {:.0} MB. Increase the limit in Settings or download it.",
            limit_mb
        )
    };

    crate::error::AppError::InvalidContent(message)
}

fn preview_chunk_fits(current_bytes: usize, chunk_bytes: usize, max_bytes: u64) -> bool {
    (chunk_bytes as u64) <= max_bytes.saturating_sub(current_bytes as u64)
}

fn is_likely_binary_text_mismatch(bytes: &[u8]) -> bool {
    if bytes.is_empty() {
        return false;
    }

    let mut control_count = 0usize;
    for &byte in bytes {
        if byte == 0 {
            return true;
        }

        if byte < 0x20 && !matches!(byte, b'\n' | b'\r' | b'\t' | 0x0c) {
            control_count += 1;
        }
    }

    control_count.saturating_mul(100) > bytes.len().saturating_mul(5)
}

#[derive(Debug, Serialize, Deserialize)]
pub struct ListObjectsResult {
    pub objects: Vec<S3Object>,
    pub common_prefixes: Vec<String>,
    pub next_continuation_token: Option<String>,
    pub is_truncated: bool,
    pub prefix: String,
    pub bucket_region: Option<String>,
}

#[derive(Debug, Serialize, Deserialize)]
pub struct SearchObjectsResult {
    pub objects: Vec<S3Object>,
    pub scanned_objects: u64,
    pub is_truncated: bool,
}

fn normalize_sort_field(sort_field: Option<String>) -> Option<String> {
    match sort_field.as_deref() {
        Some("name") | Some("size") | Some("date") | Some("class") => sort_field,
        _ => None,
    }
}

fn normalize_sort_direction(sort_direction: Option<String>) -> String {
    match sort_direction.as_deref() {
        Some("desc") => "desc".to_string(),
        _ => "asc".to_string(),
    }
}

fn paginate_folder_content(
    content: &FolderContent,
    prefix: String,
    bucket_region: Option<String>,
    continuation_token: Option<String>,
    max_keys: Option<i32>,
) -> Result<ListObjectsResult> {
    let expired = || {
        crate::error::AppError::ConfigError(
            "This listing has changed. Refresh the folder to continue.".to_string(),
        )
    };
    let offset = match continuation_token {
        Some(token) => {
            let (generation, offset) = token.split_once(':').ok_or_else(expired)?;
            if generation != content.generation {
                return Err(expired());
            }
            offset.parse::<usize>().map_err(|_| expired())?
        }
        None => 0,
    };
    if offset > content.objects.len() {
        return Err(expired());
    }
    let max = max_keys.unwrap_or(1000).max(1) as usize;
    let end = offset.saturating_add(max).min(content.objects.len());
    let next_token = if end < content.objects.len() {
        Some(format!("{}:{end}", content.generation))
    } else {
        None
    };

    Ok(ListObjectsResult {
        objects: content.objects[offset..end].to_vec(),
        common_prefixes: if offset == 0 {
            content.common_prefixes.clone()
        } else {
            Vec::new()
        },
        next_continuation_token: next_token.clone(),
        is_truncated: next_token.is_some(),
        prefix,
        bucket_region,
    })
}

async fn list_complete_folder_content(
    client: &Client,
    bucket_name: &str,
    prefix: &str,
    delimiter: &str,
) -> Result<FolderContent> {
    let mut objects = Vec::new();
    let mut common_prefixes = Vec::new();
    let mut seen_prefixes = HashSet::new();
    let mut continuation_token: Option<String> = None;
    let mut request_count = 0usize;

    loop {
        if request_count >= MAX_COMPLETE_LIST_REQUESTS {
            return Err(crate::error::AppError::ConfigError(format!(
                "This folder requires more than {} S3 LIST requests for complete-result sorting. Use name ascending or narrow the prefix.",
                MAX_COMPLETE_LIST_REQUESTS
            )));
        }

        let mut request = client
            .list_objects_v2()
            .bucket(bucket_name)
            .prefix(prefix)
            .max_keys(1000);

        if !delimiter.is_empty() {
            request = request.delimiter(delimiter);
        }

        if let Some(token) = &continuation_token {
            request = request.continuation_token(token);
        }

        let output = request
            .send()
            .await
            .map_err(|err| crate::error::AppError::S3Error(err.to_string()))?;
        request_count += 1;

        for obj in output.contents() {
            let key = obj.key().unwrap_or_default();
            let size = obj.size().unwrap_or(0);
            if !delimiter.is_empty() && key.ends_with('/') && size == 0 {
                continue;
            }

            objects.push(S3Object {
                key: key.to_string(),
                last_modified: obj.last_modified().map(|d| d.to_string()),
                size,
                storage_class: obj.storage_class().map(|s| s.as_str().to_string()),
            });
        }

        for common_prefix in output.common_prefixes() {
            let prefix = common_prefix.prefix().unwrap_or_default().to_string();
            if seen_prefixes.insert(prefix.clone()) {
                common_prefixes.push(prefix);
            }
        }

        if objects.len().saturating_add(common_prefixes.len()) > MAX_SORTABLE_FOLDER_ITEMS {
            return Err(crate::error::AppError::ConfigError(format!(
                "This folder exceeds the {}-item safety limit for complete-result sorting. Use name ascending or narrow the prefix.",
                MAX_SORTABLE_FOLDER_ITEMS
            )));
        }

        if output.is_truncated().unwrap_or(false) {
            continuation_token = Some(
                output
                    .next_continuation_token()
                    .ok_or_else(|| {
                        crate::error::AppError::S3Error(
                            "S3 returned a truncated sorted listing without a continuation token"
                                .to_string(),
                        )
                    })?
                    .to_string(),
            );
        } else {
            break;
        }
    }

    Ok(FolderContent {
        generation: uuid::Uuid::new_v4().to_string(),
        objects,
        common_prefixes,
    })
}

fn sort_folder_content(content: &mut FolderContent, sort_field: &str, sort_direction: &str) {
    content.common_prefixes.sort();
    if sort_direction == "desc" {
        content.common_prefixes.reverse();
    }

    content.objects.sort_by(|a, b| {
        let ordering = match sort_field {
            "size" => a.size.cmp(&b.size).then_with(|| a.key.cmp(&b.key)),
            "date" => a
                .last_modified
                .cmp(&b.last_modified)
                .then_with(|| a.key.cmp(&b.key)),
            "class" => a
                .storage_class
                .cmp(&b.storage_class)
                .then_with(|| a.key.cmp(&b.key)),
            _ => a.key.cmp(&b.key),
        };

        if sort_direction == "desc" {
            ordering.reverse()
        } else {
            ordering
        }
    });
}

#[allow(clippy::too_many_arguments)]
#[tauri::command]
pub async fn list_objects(
    bucket_name: String,
    bucket_region: Option<String>,
    prefix: Option<String>,
    delimiter: Option<String>,
    continuation_token: Option<String>,
    max_keys: Option<i32>,
    bypass_cache: Option<bool>,
    sort_field: Option<String>,
    sort_direction: Option<String>,
    expected_profile_id: String,
    profile_state: State<'_, ProfileState>,
    s3_state: State<'_, S3State>,
) -> Result<ListObjectsResult> {
    let prefix_str = prefix.clone().unwrap_or_default();
    let delimiter_str = delimiter.unwrap_or_else(|| "/".to_string());
    let requested_bucket_region = bucket_region.clone();
    let sort_field = normalize_sort_field(sort_field);
    let sort_direction = normalize_sort_direction(sort_direction);
    let uses_complete_sort = sort_field
        .as_deref()
        .map(|field| field != "name" || sort_direction == "desc")
        .unwrap_or(false)
        && !delimiter_str.is_empty();

    // Get active profile
    let profile_manager = profile_state.read().await;
    let active_profile = profile_manager
        .get_active_profile()
        .await?
        .ok_or_else(|| crate::error::AppError::ProfileNotFound("No active profile".into()))?;
    drop(profile_manager);
    super::operations::validate_operation_profile(Some(&expected_profile_id), &active_profile.id)?;

    // 1. Try Read Lock first for Cache (highly concurrent)
    {
        let s3_manager = s3_state.read().await;
        let cached_bucket_region = s3_manager
            .get_bucket_region(&active_profile, &bucket_name)
            .or(requested_bucket_region.clone());
        if uses_complete_sort && !bypass_cache.unwrap_or(false) {
            if let Some(field) = sort_field.as_deref() {
                if let Some(content) = s3_manager.get_sorted_folder_content(
                    &active_profile.cache_identity(),
                    &bucket_name,
                    &prefix_str,
                    field,
                    &sort_direction,
                ) {
                    return paginate_folder_content(
                        content,
                        prefix_str,
                        cached_bucket_region,
                        continuation_token,
                        max_keys,
                    );
                }
            }
        }
    }

    if uses_complete_sort && continuation_token.is_some() {
        return Err(crate::error::AppError::ConfigError(
            "This listing has expired. Refresh the folder to continue.".to_string(),
        ));
    }

    // If bypassing cache, we should invalidate the existing cache for this bucket
    if bypass_cache.unwrap_or(false) {
        let mut s3_manager = s3_state.write().await;
        s3_manager.remove_bucket_cache(&active_profile.id, &bucket_name);
    }

    // Check cache for bucket region first
    let mut resolved_bucket_region = {
        let s3_manager = s3_state.read().await;
        s3_manager.get_bucket_region(&active_profile, &bucket_name)
    }
    .or(bucket_region);

    let client = {
        let mut s3_manager = s3_state.write().await;
        if let Some(ref region) = resolved_bucket_region {
            s3_manager
                .get_client_for_region(&active_profile, region)
                .await?
                .clone()
        } else {
            s3_manager.get_client(&active_profile).await?.clone()
        }
    };

    if uses_complete_sort {
        let field = sort_field.clone().unwrap_or_else(|| "name".to_string());
        let mut content =
            match list_complete_folder_content(&client, &bucket_name, &prefix_str, &delimiter_str)
                .await
            {
                Ok(content) => content,
                Err(err) => {
                    if matches!(&err, crate::error::AppError::ConfigError(_)) {
                        return Err(err);
                    }

                    log::warn!(
                        "Sorted list_objects failed, attempting region discovery: {}",
                        err
                    );
                    let detected_region = {
                        let retry_client = {
                            let mut s3_manager = s3_state.write().await;
                            s3_manager.get_client(&active_profile).await?.clone()
                        };
                        crate::s3::get_bucket_region(&retry_client, &bucket_name)
                            .await
                            .ok()
                    };

                    if let Some(new_region) = detected_region {
                        let new_client = {
                            let mut s3_manager = s3_state.write().await;
                            s3_manager.set_bucket_region(
                                &active_profile,
                                &bucket_name,
                                new_region.clone(),
                            );
                            s3_manager
                                .get_client_for_region(&active_profile, &new_region)
                                .await?
                                .clone()
                        };
                        resolved_bucket_region = Some(new_region);
                        list_complete_folder_content(
                            &new_client,
                            &bucket_name,
                            &prefix_str,
                            &delimiter_str,
                        )
                        .await?
                    } else {
                        return Err(err);
                    }
                }
            };

        sort_folder_content(&mut content, &field, &sort_direction);

        {
            let mut s3_manager = s3_state.write().await;
            s3_manager.set_sorted_folder_content(
                &active_profile.cache_identity(),
                &bucket_name,
                &prefix_str,
                &field,
                &sort_direction,
                content.clone(),
            );
        }

        return paginate_folder_content(
            &content,
            prefix_str,
            resolved_bucket_region.or(requested_bucket_region),
            continuation_token,
            max_keys,
        );
    }

    // 3. Perform network IO outside of locks, including retry logic
    let mut request = client
        .list_objects_v2()
        .bucket(&bucket_name)
        .prefix(&prefix_str);

    // Only set delimiter if it's non-empty - empty/omitted delimiter returns ALL nested objects (recursive)
    if !delimiter_str.is_empty() {
        request = request.delimiter(&delimiter_str);
    }

    if let Some(token) = &continuation_token {
        request = request.continuation_token(token);
    }
    if let Some(max) = max_keys {
        request = request.max_keys(max);
    }

    let result = request.send().await;

    // Handle the result, implementing retry logic on error
    let output = match result {
        Ok(out) => out,
        Err(err) => {
            log::warn!("Initial list_objects failed: {}", err);
            // Attempt to detect region and retry
            let detected_region = {
                // ... (Region detection logic remains the same, we trust get_bucket_region works on any client usually)
                let retry_client = {
                    let s3_manager = s3_state.read().await;
                    // Use default region client to ask about location
                    // We don't need write lock just to get a client that might already exist
                    // Wait, get_client requires &mut Self. Okay, we need write lock.
                    drop(s3_manager);
                    let mut s3_manager = s3_state.write().await;
                    s3_manager.get_client(&active_profile).await?.clone()
                };

                match crate::s3::get_bucket_region(&retry_client, &bucket_name).await {
                    Ok(region) => {
                        log::info!(
                            "Detected correct region for bucket '{}': {}",
                            bucket_name,
                            region
                        );
                        Some(region)
                    }
                    Err(e) => {
                        log::error!("Failed to detect bucket region: {}", e);
                        None
                    }
                }
            };

            if let Some(new_region) = detected_region {
                // Get NEW client for this region
                let new_client = {
                    let mut s3_manager = s3_state.write().await;
                    s3_manager
                        .get_client_for_region(&active_profile, &new_region)
                        .await?
                        .clone()
                };

                // Retry request
                let mut retry_req = new_client
                    .list_objects_v2()
                    .bucket(&bucket_name)
                    .prefix(&prefix_str);

                // Only set delimiter if it's non-empty
                if !delimiter_str.is_empty() {
                    retry_req = retry_req.delimiter(&delimiter_str);
                }

                if let Some(token) = &continuation_token {
                    retry_req = retry_req.continuation_token(token);
                }
                if let Some(max) = max_keys {
                    retry_req = retry_req.max_keys(max);
                }

                // Update the region we will return and use for fallback
                resolved_bucket_region = Some(new_region.clone());

                // Cache the discovered region for future requests
                {
                    let mut s3_manager = s3_state.write().await;
                    s3_manager.set_bucket_region(&active_profile, &bucket_name, new_region);
                }

                retry_req
                    .send()
                    .await
                    .map_err(|e| crate::error::AppError::S3Error(format!("Retry failed: {}", e)))?
            } else {
                return Err(crate::error::AppError::S3Error(err.to_string()));
            }
        }
    };

    // Map objects, filtering out folder markers (zero-byte objects ending with /)
    let mut objects: Vec<S3Object> = output
        .contents()
        .iter()
        .filter(|obj| {
            let key = obj.key().unwrap_or_default();
            let size = obj.size().unwrap_or(0);

            // Exclude folder markers (zero-byte objects ending with '/') ONLY if we are using a delimiter (structured view).
            // In recursive view (no delimiter), we want ALL markers so they can be managed/deleted.
            if !delimiter_str.is_empty() && key.ends_with('/') && size == 0 {
                return false;
            }
            true
        })
        .map(|obj| S3Object {
            key: obj.key().unwrap_or_default().to_string(),
            last_modified: obj.last_modified().map(|d| d.to_string()),
            size: obj.size().unwrap_or(0),
            storage_class: obj.storage_class().map(|s| s.as_str().to_string()),
        })
        .collect();

    // Map common prefixes (folders)
    let common_prefixes: Vec<String> = output
        .common_prefixes()
        .iter()
        .map(|cp| cp.prefix().unwrap_or_default().to_string())
        .collect();

    // Fallback: If empty, try HeadObject to see if it's a direct file reference
    // We strip the trailing slash because some systems/users append it accidentally to files
    if objects.is_empty()
        && common_prefixes.is_empty()
        && !prefix_str.is_empty()
        && !prefix_str.ends_with('/')
    {
        let clean_key = prefix_str.trim_end_matches('/').to_string();
        if !clean_key.is_empty() {
            let client = {
                let mut s3_manager = s3_state.write().await;
                if let Some(ref region) = resolved_bucket_region {
                    s3_manager
                        .get_client_for_region(&active_profile, region)
                        .await?
                        .clone()
                } else {
                    s3_manager.get_client(&active_profile).await?.clone()
                }
            };

            if let Ok(head_output) = client
                .head_object()
                .bucket(&bucket_name)
                .key(&clean_key)
                .send()
                .await
            {
                objects.push(S3Object {
                    key: clean_key,
                    last_modified: head_output.last_modified().map(|d| d.to_string()),
                    size: head_output.content_length().unwrap_or(0),
                    storage_class: head_output.storage_class().map(|s| s.as_str().to_string()),
                });
            }
        }
    }

    Ok(ListObjectsResult {
        objects,
        common_prefixes,
        next_continuation_token: output.next_continuation_token().map(|s| s.to_string()),
        is_truncated: output.is_truncated().unwrap_or(false),
        prefix: prefix_str,
        bucket_region: resolved_bucket_region.or(requested_bucket_region),
    })
}

#[tauri::command]
pub async fn search_objects(
    bucket_name: String,
    bucket_region: Option<String>,
    prefix: Option<String>,
    query: String,
    expected_profile_id: String,
    profile_state: State<'_, ProfileState>,
    s3_state: State<'_, S3State>,
) -> Result<SearchObjectsResult> {
    let profile_manager = profile_state.read().await;
    let active_profile = profile_manager
        .get_active_profile()
        .await?
        .ok_or_else(|| crate::error::AppError::ProfileNotFound("No active profile".into()))?;
    drop(profile_manager);
    super::operations::validate_operation_profile(Some(&expected_profile_id), &active_profile.id)?;

    let prefix_str = prefix.unwrap_or_default();
    let query_lower = query.to_lowercase();

    // Check cache for bucket region first
    let bucket_region = {
        let s3_manager = s3_state.read().await;
        s3_manager.get_bucket_region(&active_profile, &bucket_name)
    }
    .or(bucket_region);

    let mut client = {
        let mut s3_manager = s3_state.write().await;
        if let Some(ref region) = bucket_region {
            s3_manager
                .get_client_for_region(&active_profile, region)
                .await?
                .clone()
        } else {
            s3_manager.get_client(&active_profile).await?.clone()
        }
    };

    let mut objects = Vec::new();
    let mut continuation_token = None;
    let mut calls = 0;
    let mut scanned_objects = 0u64;
    let mut is_truncated = false;

    loop {
        let mut req = client
            .list_objects_v2()
            .bucket(&bucket_name)
            .prefix(&prefix_str)
            .max_keys(1000); // Respect prefix context

        if let Some(ref token) = continuation_token {
            req = req.continuation_token(token);
        }

        let result = req.send().await;

        // implement region detection and retry on error
        let output = match result {
            Ok(out) => out,
            Err(err) => {
                log::warn!("Search list_objects failed: {}", err);
                if calls > 0 {
                    return Err(crate::error::AppError::S3Error(format!(
                        "Search failed after reading {} S3 pages: {}",
                        calls, err
                    )));
                }

                // Attempt to detect region and retry (only if this is the first call)
                let detected_region = {
                    let retry_client = {
                        let mut s3_manager = s3_state.write().await;
                        s3_manager.get_client(&active_profile).await?.clone()
                    };
                    crate::s3::get_bucket_region(&retry_client, &bucket_name)
                        .await
                        .ok()
                };

                if let Some(new_region) = detected_region {
                    let new_client = {
                        let mut s3_manager = s3_state.write().await;
                        s3_manager.set_bucket_region(
                            &active_profile,
                            &bucket_name,
                            new_region.clone(),
                        );
                        s3_manager
                            .get_client_for_region(&active_profile, &new_region)
                            .await?
                            .clone()
                    };
                    client = new_client.clone();

                    let mut retry_req = new_client
                        .list_objects_v2()
                        .bucket(&bucket_name)
                        .prefix(&prefix_str)
                        .max_keys(1000);

                    if let Some(token) = &continuation_token {
                        retry_req = retry_req.continuation_token(token);
                    }

                    retry_req.send().await.map_err(|e| {
                        crate::error::AppError::S3Error(format!("Search retry failed: {}", e))
                    })?
                } else {
                    return Err(crate::error::AppError::S3Error(err.to_string()));
                }
            }
        };

        calls += 1;

        for obj in output.contents() {
            if scanned_objects >= MAX_SEARCH_SCANNED_OBJECTS {
                is_truncated = true;
                break;
            }
            scanned_objects += 1;

            let key = obj.key().unwrap_or_default();
            let size = obj.size().unwrap_or(0);
            // Skip folder markers (zero-byte objects ending with /)
            if key.ends_with('/') && size == 0 {
                continue;
            }
            if key.to_lowercase().contains(&query_lower) {
                objects.push(S3Object {
                    key: key.to_string(),
                    size,
                    last_modified: obj.last_modified().map(|d| d.to_string()),
                    storage_class: obj.storage_class().map(|s| s.as_str().to_string()),
                });

                if objects.len() >= MAX_SEARCH_RESULTS {
                    is_truncated = true;
                    break;
                }
            }
        }

        if output.is_truncated().unwrap_or(false) && calls >= MAX_SEARCH_REQUESTS {
            is_truncated = true;
        }

        if is_truncated {
            log::warn!(
                "Deep search in bucket '{}' stopped at safety limits ({} scanned, {} results)",
                bucket_name,
                scanned_objects,
                objects.len()
            );
            break;
        }

        if !output.is_truncated().unwrap_or(false) {
            break;
        }
        continuation_token = Some(
            output
                .next_continuation_token()
                .ok_or_else(|| {
                    crate::error::AppError::S3Error(
                        "S3 returned a truncated search listing without a continuation token"
                            .to_string(),
                    )
                })?
                .to_string(),
        );
    }

    Ok(SearchObjectsResult {
        objects,
        scanned_objects,
        is_truncated,
    })
}

#[tauri::command]
pub async fn get_presigned_url(
    bucket_name: String,
    bucket_region: Option<String>,
    key: String,
    expires_in: u64,
    expected_profile_id: String,
    profile_state: State<'_, ProfileState>,
    s3_state: State<'_, S3State>,
) -> Result<String> {
    use aws_sdk_s3::presigning::PresigningConfig;
    use std::time::Duration;

    let profile_manager = profile_state.read().await;
    let active_profile = profile_manager
        .get_active_profile()
        .await?
        .ok_or_else(|| crate::error::AppError::ProfileNotFound("No active profile".into()))?;
    drop(profile_manager);
    super::operations::validate_operation_profile(Some(&expected_profile_id), &active_profile.id)?;

    let bucket_region = {
        let s3_manager = s3_state.read().await;
        s3_manager.get_bucket_region(&active_profile, &bucket_name)
    }
    .or(bucket_region);

    let client = {
        let mut s3_manager = s3_state.write().await;
        if let Some(ref region) = bucket_region {
            s3_manager
                .get_client_for_region(&active_profile, region)
                .await?
                .clone()
        } else {
            s3_manager.get_client(&active_profile).await?.clone()
        }
    };

    let presigning_config_result = PresigningConfig::expires_in(Duration::from_secs(expires_in))
        .map_err(|e| crate::error::AppError::S3Error(e.to_string()));

    let mut get_obj_builder = client
        .get_object()
        .bucket(&bucket_name)
        .key(&key)
        .response_content_disposition("inline");

    // Force PDF content type if extension matches, ensuring browser renders it
    if key.to_lowercase().ends_with(".pdf") {
        get_obj_builder = get_obj_builder.response_content_type("application/pdf");
    }

    let presigned_request_result = match presigning_config_result {
        Ok(config) => get_obj_builder
            .presigned(config)
            .await
            .map_err(|e| crate::error::AppError::S3Error(e.to_string())),
        Err(e) => Err(e),
    };

    match presigned_request_result {
        Ok(req) => Ok(req.uri().to_string()),
        Err(err) => {
            log::warn!("Presigning failed, attempting region discovery: {}", err);
            let detected_region = {
                let retry_client = {
                    let mut s3_manager = s3_state.write().await;
                    s3_manager.get_client(&active_profile).await?.clone()
                };
                crate::s3::get_bucket_region(&retry_client, &bucket_name)
                    .await
                    .ok()
            };

            if let Some(new_region) = detected_region {
                let new_client = {
                    let mut s3_manager = s3_state.write().await;
                    s3_manager.set_bucket_region(&active_profile, &bucket_name, new_region.clone());
                    s3_manager
                        .get_client_for_region(&active_profile, &new_region)
                        .await?
                        .clone()
                };

                let mut get_obj = new_client
                    .get_object()
                    .bucket(&bucket_name)
                    .key(&key)
                    .response_content_disposition("inline");

                if key.to_lowercase().ends_with(".pdf") {
                    get_obj = get_obj.response_content_type("application/pdf");
                }

                let presigning_config =
                    PresigningConfig::expires_in(Duration::from_secs(expires_in))
                        .map_err(|e| crate::error::AppError::S3Error(e.to_string()))?;

                let req = get_obj.presigned(presigning_config).await.map_err(|e| {
                    crate::error::AppError::S3Error(format!("Retry presign failed: {}", e))
                })?;
                Ok(req.uri().to_string())
            } else {
                Err(err)
            }
        }
    }
}

#[derive(Serialize)]
pub struct ObjectText {
    content: String,
    e_tag: Option<String>,
    profile_id: String,
}

#[tauri::command]
pub async fn get_object_content(
    bucket_name: String,
    bucket_region: Option<String>,
    key: String,
    max_bytes: Option<u64>,
    expected_profile_id: String,
    profile_state: State<'_, ProfileState>,
    s3_state: State<'_, S3State>,
) -> Result<ObjectText> {
    let max_bytes = normalized_text_preview_limit(max_bytes);
    let profile_manager = profile_state.read().await;
    let active_profile = profile_manager
        .get_active_profile()
        .await?
        .ok_or_else(|| crate::error::AppError::ProfileNotFound("No active profile".into()))?;
    drop(profile_manager);
    super::operations::validate_operation_profile(Some(&expected_profile_id), &active_profile.id)?;

    let bucket_region = {
        let s3_manager = s3_state.read().await;
        s3_manager.get_bucket_region(&active_profile, &bucket_name)
    }
    .or(bucket_region);

    let client = {
        let mut s3_manager = s3_state.write().await;
        if let Some(ref region) = bucket_region {
            s3_manager
                .get_client_for_region(&active_profile, region)
                .await?
                .clone()
        } else {
            s3_manager.get_client(&active_profile).await?.clone()
        }
    };

    let result = client
        .get_object()
        .bucket(&bucket_name)
        .key(&key)
        .send()
        .await;

    let response = match result {
        Ok(res) => res,
        Err(err) => {
            log::warn!(
                "get_object_content failed, attempting region discovery: {}",
                err
            );
            let detected_region = {
                let retry_client = {
                    let mut s3_manager = s3_state.write().await;
                    s3_manager.get_client(&active_profile).await?.clone()
                };
                crate::s3::get_bucket_region(&retry_client, &bucket_name)
                    .await
                    .ok()
            };

            if let Some(new_region) = detected_region {
                let new_client = {
                    let mut s3_manager = s3_state.write().await;
                    s3_manager.set_bucket_region(&active_profile, &bucket_name, new_region.clone());
                    s3_manager
                        .get_client_for_region(&active_profile, &new_region)
                        .await?
                        .clone()
                };
                new_client
                    .get_object()
                    .bucket(&bucket_name)
                    .key(&key)
                    .send()
                    .await
                    .map_err(|e| {
                        crate::error::AppError::S3Error(format!("Retry get content failed: {}", e))
                    })?
            } else {
                return Err(crate::error::AppError::S3Error(err.to_string()));
            }
        }
    };

    let content_length = response
        .content_length()
        .and_then(|length| u64::try_from(length).ok());
    if content_length.is_some_and(|length| length > max_bytes) {
        return Err(text_preview_size_error(content_length, max_bytes));
    }

    let initial_capacity = content_length
        .unwrap_or(0)
        .min(max_bytes)
        .try_into()
        .unwrap_or(0);
    let mut bytes = Vec::with_capacity(initial_capacity);
    let e_tag = response.e_tag.clone();
    let mut body = response.body;

    while let Some(chunk) = body
        .try_next()
        .await
        .map_err(|e| crate::error::AppError::S3Error(e.to_string()))?
    {
        if !preview_chunk_fits(bytes.len(), chunk.len(), max_bytes) {
            return Err(text_preview_size_error(None, max_bytes));
        }
        bytes.extend_from_slice(&chunk);
    }

    if is_likely_binary_text_mismatch(&bytes) {
        return Err(crate::error::AppError::InvalidContent(
            "This object appears to contain binary data and cannot be edited safely in the text editor. Download it to inspect locally.".to_string(),
        ));
    }

    let content = String::from_utf8(bytes).map_err(|_| {
        crate::error::AppError::InvalidContent(
            "This object is not readable as UTF-8 text. Download it to inspect locally."
                .to_string(),
        )
    })?;
    Ok(ObjectText {
        content,
        e_tag,
        profile_id: active_profile.id,
    })
}

#[tauri::command]
#[allow(clippy::too_many_arguments)]
pub async fn put_object_content(
    bucket_name: String,
    bucket_region: Option<String>,
    key: String,
    content: String,
    expected_etag: String,
    expected_profile_id: String,
    profile_state: State<'_, ProfileState>,
    s3_state: State<'_, S3State>,
) -> Result<Option<String>> {
    let profile_manager = profile_state.read().await;
    let active_profile = profile_manager
        .get_active_profile()
        .await?
        .ok_or_else(|| crate::error::AppError::ProfileNotFound("No active profile".into()))?;
    drop(profile_manager);
    super::operations::validate_operation_profile(Some(&expected_profile_id), &active_profile.id)?;

    let bucket_region = {
        let s3_manager = s3_state.read().await;
        s3_manager.get_bucket_region(&active_profile, &bucket_name)
    }
    .or(bucket_region);

    let client = {
        let mut s3_manager = s3_state.write().await;
        if let Some(ref region) = bucket_region {
            s3_manager
                .get_client_for_region(&active_profile, region)
                .await?
                .clone()
        } else {
            s3_manager.get_client(&active_profile).await?.clone()
        }
    };

    let result =
        super::operations::save_object_text(&client, &bucket_name, &key, content, &expected_etag)
            .await;

    {
        let mut s3_manager = s3_state.write().await;
        s3_manager.remove_bucket_cache(&active_profile.id, &bucket_name);
    }

    result
}

#[cfg(test)]
mod preview_tests {
    use super::{
        normalized_text_preview_limit, preview_chunk_fits, DEFAULT_MAX_TEXT_PREVIEW_BYTES,
        MAX_TEXT_PREVIEW_BYTES,
    };

    #[test]
    fn text_preview_limit_has_a_safe_default_and_upper_bound() {
        assert_eq!(
            normalized_text_preview_limit(None),
            DEFAULT_MAX_TEXT_PREVIEW_BYTES
        );
        assert_eq!(normalized_text_preview_limit(Some(0)), 1);
        assert_eq!(
            normalized_text_preview_limit(Some(MAX_TEXT_PREVIEW_BYTES + 1)),
            MAX_TEXT_PREVIEW_BYTES
        );
    }

    #[test]
    fn streamed_preview_never_crosses_the_configured_limit() {
        assert!(preview_chunk_fits(6, 4, 10));
        assert!(!preview_chunk_fits(6, 5, 10));
        assert!(!preview_chunk_fits(usize::MAX, 1, 10));
    }
}

#[cfg(test)]
mod pagination_tests {
    use super::*;

    fn content(count: usize) -> FolderContent {
        FolderContent {
            generation: "snapshot".to_string(),
            objects: (0..count)
                .map(|index| S3Object {
                    key: index.to_string(),
                    size: 0,
                    last_modified: None,
                    storage_class: None,
                })
                .collect(),
            common_prefixes: vec!["folder/".to_string()],
        }
    }

    #[test]
    fn sorted_pages_preserve_objects_and_only_return_folders_once() {
        let content = content(3);
        let first = paginate_folder_content(&content, String::new(), None, None, Some(2)).unwrap();
        assert_eq!(first.objects.len(), 2);
        assert_eq!(first.common_prefixes.len(), 1);
        let last = paginate_folder_content(
            &content,
            String::new(),
            None,
            first.next_continuation_token,
            Some(2),
        )
        .unwrap();
        assert_eq!(last.objects[0].key, "2");
        assert!(last.common_prefixes.is_empty());
        assert!(!last.is_truncated);
    }

    #[test]
    fn stale_and_malformed_sorted_cursors_return_errors() {
        for token in [
            "1000",
            "old:1",
            "snapshot:no",
            "snapshot:1000",
            "snapshot:18446744073709551615",
        ] {
            assert!(paginate_folder_content(
                &content(999),
                String::new(),
                None,
                Some(token.to_string()),
                None
            )
            .is_err());
        }
        let empty = paginate_folder_content(&content(0), String::new(), None, None, None).unwrap();
        assert!(empty.objects.is_empty());
        assert!(!empty.is_truncated);
    }
}