1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
use super::*;
impl HostState {
/// Returns true once shutdown has drained persistence and the host loop may
/// stop.
pub(super) async fn handle(&mut self, event: HostEvent) -> bool {
match event {
HostEvent::View {
session_id,
snapshot,
prompt_driven,
} => self.observe(session_id, snapshot, prompt_driven).await,
HostEvent::Retain { live } => self.retain_sessions(&live),
HostEvent::Start {
session_id,
manual,
reply,
} => self.begin(session_id, manual, reply),
HostEvent::Prepared {
session_id,
manual,
reply,
prepared,
} => self.prepared(session_id, manual, reply, prepared),
HostEvent::RecoveryPrepared {
session_id,
prepared,
} => self.recovery_prepared(session_id, prepared),
HostEvent::StateSaved {
session_id,
completion,
result,
} => self.state_saved(session_id, completion, result),
HostEvent::Resolve {
session_id,
resolution,
reply,
} => {
let answer = self.resolve(&session_id, resolution);
let _ = reply.send(answer);
}
HostEvent::Step {
session_id,
epoch,
step,
} => self.step(session_id, epoch, step),
HostEvent::Interrupted { interrupted } => {
for session_id in interrupted {
self.recovery_candidates.insert(session_id.clone());
if self.sessions.get(&session_id).is_some_and(|watch| {
matches!(watch.execution, MaterializedExecutionState::Idle)
}) {
self.begin_recovery(&session_id);
}
}
}
HostEvent::Shutdown { reply } => {
let result = self.shutdown().await;
let _ = reply.send(result);
return true;
}
}
false
}
/// Applies one asynchronous result to the review that asked for it.
pub(super) fn step(&mut self, session_id: String, epoch: u64, step: ReviewStep) {
// A result from a review that has since been cancelled, resolved, or
// replaced is not this review's business.
if self.reviews.get(&session_id).map(|slot| slot.epoch) != Some(epoch) {
return;
}
match step {
ReviewStep::Delta(result) => {
let requests = match result {
Ok(deltas) => self
.reviews
.get_mut(&session_id)
.map(|slot| slot.driver.delta_captured(deltas))
.unwrap_or_default(),
Err(error) => {
self.fail(
&session_id,
format!("the change could not be captured: {error}"),
);
return;
}
};
self.run(&session_id, requests);
}
ReviewStep::Analysis(result) => {
let requests = self
.reviews
.get_mut(&session_id)
.map(|slot| slot.driver.analysis_completed(result))
.unwrap_or_default();
self.run(&session_id, requests);
}
ReviewStep::RoleStarted { role, result } => {
let requests = match self.reviews.get_mut(&session_id) {
Some(slot) => match result {
Ok(()) => slot.driver.role_started(&role),
// A lane that cannot start is a coverage gap the
// supervisor is told about; any other role failing to
// start fails the review.
Err(error) if mj_review::lanes::lane_by_id(&role).is_some() => {
slot.driver.lane_failed(&role, error)
}
Err(error)
if matches!(
slot.driver.phase(),
TurnReviewPhase::Forwarding { .. }
) =>
{
tracing::debug!(
session_id = %session_id,
role = %role,
%error,
"ignoring a late reviewer start result during primary handoff"
);
return;
}
Err(error) => {
self.fail(&session_id, error);
return;
}
},
None => return,
};
self.run(&session_id, requests);
}
ReviewStep::RolePrompted { role, result } => {
if let Err(error) = result {
if self.reviews.get(&session_id).is_some_and(|slot| {
matches!(slot.driver.phase(), TurnReviewPhase::Forwarding { .. })
}) {
// Role cleanup can report after the primary handoff
// has begun. It is unrelated to that handoff and must
// not release its prompt hold or replace its findings.
tracing::debug!(
session_id = %session_id,
role = %role,
%error,
"ignoring a late reviewer-role result during primary handoff"
);
return;
}
self.fail(
&session_id,
format!("reviewing role {role:?} could not be prompted: {error}"),
);
}
}
ReviewStep::PrimaryPrompted(result) => {
let requests = match result {
Ok(()) => self
.reviews
.get_mut(&session_id)
.map(|slot| slot.driver.forward_succeeded())
.unwrap_or_default(),
Err(error) => self
.reviews
.get_mut(&session_id)
.map(|slot| slot.driver.forward_failed(error))
.unwrap_or_default(),
};
self.run(&session_id, requests);
}
ReviewStep::RoleEvents { role, result } => self.role_events(session_id, role, result),
ReviewStep::Dispatches(result) => {
let requests = match result {
Ok(requests) => self
.reviews
.get_mut(&session_id)
.map(|slot| slot.driver.lanes_dispatched(requests))
.unwrap_or_default(),
// A dropped dispatch would leave the supervisor waiting for
// lanes that never run, so it fails the review rather than
// stalling it.
Err(error) => {
if self.reviews.get(&session_id).is_some_and(|slot| {
matches!(slot.driver.phase(), TurnReviewPhase::Forwarding { .. })
}) {
tracing::debug!(
session_id = %session_id,
%error,
"ignoring a late lane dispatch result during primary handoff"
);
return;
}
self.fail(
&session_id,
format!(
"the review could not collect the supervisor's specialists: {error}"
),
);
return;
}
};
self.run(&session_id, requests);
}
}
}
/// Release the retained last-view for every session no longer in the live
/// set, so a stopped or destroyed session's `MaterializedSession` (its full
/// transcript) does not linger. The in-flight review state in `reviews`/
/// `closing` is separate and keeps its own lifetime.
pub(super) fn retain_sessions(&mut self, live: &std::collections::BTreeSet<String>) {
self.sessions
.retain(|session_id, _| live.contains(session_id));
}
}