brokk_bifrost_cpp/

identity.rs

//! Which C++ callable is which: declaration/definition roles, the linkage
//! evidence that unifies a header declaration with its `.cpp` definition, and
//! the #1134 resolution-time identity reconciliation built on top of both.
//!
//! Two things stay in `analyzer/cpp/identity.rs` on purpose:
//!
//! * [`cpp_header_body_files_are_related`] here reads the include closure off a
//!   [`CppSource`]. The analysis wrapper of the same name owns the
//!   `resolve_analyzer::<CppAnalyzer>` downcast that produces one, because the
//!   searchtools identity block reaches this predicate through `&dyn IAnalyzer`
//!   and no capability carries the include graph.
//! * The moka cells that memoize [`cpp_reconcile_candidates`] per member
//!   identifier and [`cpp_reconcile_group`] per [`CppReconcileGroupKey`] stay
//!   on the analyzer, as does every other cache, so `IAnalyzer::update` keeps
//!   rebuilding them wholesale.

use crate::declarations::{
    CppRecoveredExportClassIndex, cpp_member_fq, extract_function_declarator, node_text,
    recovered_callable_body_at, recovered_class_body_at,
};
use crate::graph::CppGraphSource;
use crate::graph::resolver::{
    VisibilityIndex, cpp_include_closure_reaches, cpp_name_component_nodes, declarator_name_node,
    lexical_component_tiers, qualified_owner_components,
};
use crate::graph_support::CppSource;
use crate::reconcile::{ReconciledIdentity, VisibleClass, reconcile_out_of_line_member_identity};
use brokk_bifrost_core::analyzer::fq_name::{SegmentKind, segment_interner};
use brokk_bifrost_core::analyzer::model::{CallableLinkage, Range, SignatureMetadata};
use brokk_bifrost_core::analyzer::query_token::QueryToken;
use brokk_bifrost_core::analyzer::symbol_path::parse_symbol_path_fq;
use brokk_bifrost_core::analyzer::tree_walk::{node_for_exact_range, subtree_contains};
pub use brokk_bifrost_core::analyzer::usages::common::same_node as cpp_same_node;
use brokk_bifrost_core::analyzer::{CodeUnit, CodeUnitIndex, Language, ProjectFile};
use brokk_bifrost_core::hash::HashMap;
use brokk_bifrost_core::path_utils::rel_path_string;
use brokk_bifrost_core::profiling;
use std::sync::Arc;
use tree_sitter::Node;
use tree_sitter::{Parser, Tree};

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum CppCallableUnitRole {
    DeclarationOnly,
    Definition,
    Both,
    Unknown,
}

pub use brokk_bifrost_core::analyzer::cpp_facts::CppOccurrenceRole;
pub struct CppOccurrenceClassifier {
    tree: Tree,
    /// The parsed text. A class role reads the recovered export-macro shapes,
    /// and those are named from source text the tree alone does not carry.
    source: String,
    /// Resolved once for the whole tree rather than per classified occurrence
    /// (#1496).
    recovered_export_classes: CppRecoveredExportClassIndex,
}

impl CppOccurrenceClassifier {
    pub fn new(source: &str) -> Option<Self> {
        let mut parser = Parser::new();
        parser
            .set_language(&tree_sitter_cpp::LANGUAGE.into())
            .ok()?;
        parser.parse(source, None).map(|tree| {
            let recovered_export_classes =
                CppRecoveredExportClassIndex::build(tree.root_node(), source);
            Self {
                tree,
                source: source.to_owned(),
                recovered_export_classes,
            }
        })
    }

    pub fn classify(&self, candidate: &CodeUnit, range: &Range) -> CppOccurrenceRole {
        cpp_occurrence_role_for_range(
            &self.recovered_export_classes,
            self.tree.root_node(),
            &self.source,
            candidate,
            range,
        )
    }
}

pub fn cpp_callable_unit_role(
    index: &dyn CodeUnitIndex,
    callable: &CodeUnit,
) -> CppCallableUnitRole {
    cpp_callable_unit_role_from_metadata(callable, index.signature_metadata(callable))
}

fn cpp_callable_unit_role_from_metadata(
    callable: &CodeUnit,
    metadata: impl IntoIterator<Item = SignatureMetadata>,
) -> CppCallableUnitRole {
    if !callable.is_callable() {
        return CppCallableUnitRole::Unknown;
    }
    let mut declaration = false;
    let mut definition = false;
    for metadata in metadata {
        if metadata.is_declaration_only() {
            declaration = true;
        } else {
            definition = true;
        }
    }
    match (declaration, definition) {
        (true, false) => CppCallableUnitRole::DeclarationOnly,
        (false, true) => CppCallableUnitRole::Definition,
        (true, true) => CppCallableUnitRole::Both,
        (false, false) => CppCallableUnitRole::Unknown,
    }
}

pub fn cpp_indexed_callable_linkage(
    index: &dyn CodeUnitIndex,
    callable: &CodeUnit,
) -> Option<CallableLinkage> {
    cpp_callable_linkage_from_metadata(index.signature_metadata(callable))
}

pub fn cpp_callable_linkage_from_metadata(
    metadata: impl IntoIterator<Item = SignatureMetadata>,
) -> Option<CallableLinkage> {
    let mut external = false;
    for metadata in metadata {
        match metadata.callable_linkage() {
            Some(CallableLinkage::Internal) => return Some(CallableLinkage::Internal),
            Some(CallableLinkage::External) => external = true,
            None => {}
        }
    }
    external.then_some(CallableLinkage::External)
}

/// Whether `left` and `right` are the same callable seen twice.
///
/// `header_body_related` is the include-evidence predicate; the analysis wrapper
/// supplies it because reaching the include graph needs the analyzer downcast
/// this crate cannot perform.
pub fn cpp_callable_definitions_share_identity_evidence(
    index: &dyn CodeUnitIndex,
    left: &CodeUnit,
    right: &CodeUnit,
    header_body_related: impl Fn(&ProjectFile, &ProjectFile) -> bool,
) -> bool {
    left.fq_name() == right.fq_name()
        && left.signature() == right.signature()
        && (left.source() == right.source()
            || (matches!(
                cpp_indexed_callable_linkage(index, left),
                Some(CallableLinkage::External)
            ) && matches!(
                cpp_indexed_callable_linkage(index, right),
                Some(CallableLinkage::External)
            ) && header_body_related(left.source(), right.source())))
}

/// The same evidence, with the signature-string conjunct answered by the
/// resolved parameter comparison instead.
///
/// The persisted signature embeds each parameter type exactly as it was
/// spelled, and a header declaration and its out-of-line body routinely spell
/// one type two ways - `msg_t *` inside `namespace zmq` against `zmq::msg_t *`
/// at file scope - so string equality alone refuses to unify the very pair this
/// predicate exists to unify (#2010). [`VisibilityIndex::same_logical_callable`]
/// compares the strings first and resolves the written parameter names only
/// when they differ, so this is strictly the wider relation; every other
/// conjunct - equal `fq_name`, external linkage on both sides, and the include
/// evidence relating the two files - is unchanged.
///
/// Definition lookup uses this variant. The workspace-scale scans keep the
/// string form above, where the candidate set is the whole index.
pub fn cpp_callable_definitions_share_identity_evidence_with_visibility(
    analyzer: &CppGraphSource<'_>,
    visibility: &VisibilityIndex<'_>,
    left: &CodeUnit,
    right: &CodeUnit,
    header_body_related: impl Fn(&ProjectFile, &ProjectFile) -> bool,
) -> bool {
    left.fq_name() == right.fq_name()
        && visibility.same_logical_callable(analyzer, left, right)
        && (left.source() == right.source()
            || (matches!(
                visibility.callable_linkage(left),
                Some(CallableLinkage::External)
            ) && matches!(
                visibility.callable_linkage(right),
                Some(CallableLinkage::External)
            ) && header_body_related(left.source(), right.source())))
}

/// Return whether `node` is one of the names declared by a range-for
/// declarator. Follow only declarator fields. This keeps identifiers in array
/// bounds and attributes in the range-for header as references.
pub fn cpp_is_range_for_binding_name(node: Node<'_>) -> bool {
    let mut current = Some(node);
    while let Some(candidate) = current {
        let Some(parent) = candidate.parent() else {
            return false;
        };
        if parent.kind() == "for_range_loop" {
            return parent
                .child_by_field_name("declarator")
                .is_some_and(|declarator| {
                    cpp_range_for_declarator_contains_name(declarator, node)
                });
        }
        current = Some(parent);
    }
    false
}

/// Return whether `node` is part of a conversion operator's target type.
///
/// A C++ conversion operator has no return type. Its target is part of the
/// operator declaration identity, so inverse usage analysis deliberately does
/// not report it as a type reference (#1489). Keep census probes on the same
/// semantic surface by recognizing only components structurally contained by
/// tree-sitter's `operator_cast` node. Types used in the function body and
/// ordinary or overloaded-operator return types never cross that node.
pub fn cpp_is_conversion_operator_target_type(mut node: Node<'_>) -> bool {
    while let Some(parent) = node.parent() {
        if parent.kind() == "operator_cast" {
            return true;
        }
        if matches!(
            parent.kind(),
            "function_declarator" | "declaration" | "function_definition" | "translation_unit"
        ) {
            return false;
        }
        node = parent;
    }
    false
}

/// Return whether `node` is a character token that C++ recovery parsed as an
/// unnamed parameter type in a class-scope macro invocation.
///
/// Tree-sitter does not expand macros. A call such as `STRING_(Name, 'x')`
/// where declarations are expected can therefore become a malformed function
/// declaration. Its character argument has an exact CST shape: the opening and
/// closing quote are separate direct `ERROR` siblings around an otherwise
/// clean `parameter_declaration(type_identifier)`. That middle identifier is
/// neither a declaration nor a reference.
pub fn cpp_is_recovered_macro_character_token_type(node: Node<'_>) -> bool {
    if node.kind() != "type_identifier" {
        return false;
    }
    let Some(parameter) = node.parent() else {
        return false;
    };
    if parameter.kind() != "parameter_declaration"
        || parameter.child_by_field_name("type") != Some(node)
        || parameter.child_by_field_name("declarator").is_some()
        || parameter
            .parent()
            .is_none_or(|parent| parent.kind() != "parameter_list")
    {
        return false;
    }

    parameter
        .prev_named_sibling()
        .is_some_and(cpp_is_recovered_character_quote)
        && parameter
            .next_named_sibling()
            .is_some_and(cpp_is_recovered_character_quote)
}

fn cpp_is_recovered_character_quote(node: Node<'_>) -> bool {
    node.is_error()
        && node.child_count() == 1
        && node
            .child(0)
            .is_some_and(|quote| !quote.is_named() && quote.kind() == "'")
}

/// Return whether `node` is the declarator name of a constructor or destructor
/// -- the declaration occurrence itself, never a reference to one.
///
/// A declaration site is not a usage probe, so the reference differential must
/// not seed one (#1834). The indexed-declaration-name filter the seeder already
/// applies misses these two shapes:
///
/// * The identifier inside a `destructor_name`. The census proposes both
///   `~Foo` and its inner `Foo`, while the indexed declaration name range
///   covers only the `~Foo` span, so the inner identifier survives the filter.
/// * A declarator the parse never recovered as a declaration. `class MACRO Foo
///   { ... }` and a bare `MACRO_NAMESPACE_BEGIN` before `class Foo { ... }`
///   both recover as a `function_definition` whose declarator is a lone
///   identifier -- a shape valid C++ cannot produce -- with the class body as
///   its `compound_statement`. Every declaration inside it that the grammar can
///   read as an expression becomes one, so `Foo();` reads as a call of `Foo`,
///   which the census then grades as a tier-1 forward gap.
///
/// Both tests are structural. Constructor calls stay references: `new Foo(...)`
/// is a `new_expression` type, `Foo x(...)` is a declaration whose type field
/// holds the name, and `: base_(x)` is a `field_initializer`. None of them is a
/// `function_declarator` declarator or a callee inside a recovered class body.
pub fn cpp_is_constructor_or_destructor_declarator_name(node: Node<'_>, source: &str) -> bool {
    cpp_is_declared_constructor_or_destructor_name(node)
        || cpp_is_recovered_constructor_or_destructor_name(node, source)
}

/// The parsed-as-declared shape: the grammar's `constructor_or_destructor_
/// declaration` and `constructor_or_destructor_definition`, both aliased to
/// `declaration`/`function_definition` and both recognizable by the absence of
/// a `type` field -- exactly what distinguishes a constructor or destructor
/// from every other C++ callable, which must name a return type.
fn cpp_is_declared_constructor_or_destructor_name(node: Node<'_>) -> bool {
    let mut name = node;
    if let Some(parent) = name.parent()
        && parent.kind() == "destructor_name"
    {
        name = parent;
    }
    // `Foo::Foo`, `A::B::Foo` and `Foo<T>::~Foo` reach the declarator through
    // the qualified name's `name` field. The `scope` segments stay references:
    // they name the owning type.
    while let Some(parent) = name.parent() {
        if parent.kind() != "qualified_identifier"
            || parent.child_by_field_name("name") != Some(name)
        {
            break;
        }
        name = parent;
    }
    let Some(declarator) = name.parent() else {
        return false;
    };
    if declarator.kind() != "function_declarator"
        || declarator.child_by_field_name("declarator") != Some(name)
    {
        return false;
    }
    let Some(owner) = declarator.parent() else {
        return false;
    };
    matches!(owner.kind(), "declaration" | "function_definition")
        && owner.child_by_field_name("declarator") == Some(declarator)
        && owner.child_by_field_name("type").is_none()
}

/// The recovered shape: a callee that names the class whose body the parse
/// turned into a `compound_statement`.
///
/// Two conditions hold together, and both are needed. The nearest enclosing
/// `function_definition` must declare a bare `identifier` -- valid C++ always
/// declares a `function_declarator` there, so this shape only ever comes out of
/// the class-body recovery. And the callee must name one of the identifiers in
/// that recovery's header, which is where the class name is: `class MACRO Foo`
/// and `class MACRO Foo : public Base` both keep `Foo` in the header even
/// though the second leaves `Base` as the recovered declarator.
///
/// Together they keep genuine calls references. A recursive `f(n - 1);` sits in
/// a real body, whose declarator is a `function_declarator`. A method body
/// inside the recovered class body is itself a real `function_definition`, so
/// `RAPIDJSON_ASSERT(false)` inside one keeps its own nearest owner. A macro
/// invocation such as `DISALLOW_COPY_AND_ASSIGN(Foo);` in the recovered body
/// does not name the class, so it stays proposed.
fn cpp_is_recovered_constructor_or_destructor_name(node: Node<'_>, source: &str) -> bool {
    if node.kind() != "identifier" {
        return false;
    }
    let Some(call) = node.parent() else {
        return false;
    };
    if call.kind() != "call_expression" || call.child_by_field_name("function") != Some(node) {
        return false;
    }
    let mut current = call.parent();
    while let Some(ancestor) = current {
        if ancestor.kind() == "function_definition" {
            return ancestor
                .child_by_field_name("declarator")
                .is_some_and(|declarator| declarator.kind() == "identifier")
                && cpp_recovered_class_header_names(ancestor, node_text(node, source), source);
        }
        current = ancestor.parent();
    }
    false
}

/// Whether `name` is spelled by an identifier in the recovered class header --
/// everything the recovery kept before the body it mistook for a function body.
fn cpp_recovered_class_header_names(definition: Node<'_>, name: &str, source: &str) -> bool {
    let header_end = definition
        .child_by_field_name("body")
        .map_or_else(|| definition.end_byte(), |body| body.start_byte());
    let mut stack = vec![definition];
    while let Some(node) = stack.pop() {
        if node.start_byte() >= header_end {
            continue;
        }
        if matches!(
            node.kind(),
            "identifier" | "type_identifier" | "namespace_identifier"
        ) && node_text(node, source) == name
        {
            return true;
        }
        let mut cursor = node.walk();
        for child in node.named_children(&mut cursor) {
            stack.push(child);
        }
    }
    false
}

fn cpp_range_for_declarator_contains_name(declarator: Node<'_>, target: Node<'_>) -> bool {
    let mut pending = vec![declarator];
    while let Some(candidate) = pending.pop() {
        match candidate.kind() {
            "identifier" | "field_identifier" => {
                if cpp_same_node(candidate, target) {
                    return true;
                }
            }
            "structured_binding_declarator" => {
                let mut cursor = candidate.walk();
                if candidate
                    .named_children(&mut cursor)
                    .any(|name| cpp_same_node(name, target))
                {
                    return true;
                }
            }
            "pointer_declarator"
            | "reference_declarator"
            | "array_declarator"
            | "attributed_declarator"
            | "parenthesized_declarator"
            | "function_declarator"
            | "init_declarator" => {
                if let Some(inner) = cpp_range_for_inner_declarator(candidate) {
                    pending.push(inner);
                }
            }
            _ => {}
        }
    }
    false
}

fn cpp_range_for_inner_declarator(node: Node<'_>) -> Option<Node<'_>> {
    node.child_by_field_name("declarator").or_else(|| {
        let mut cursor = node.walk();
        node.named_children(&mut cursor).find(|child| {
            matches!(
                child.kind(),
                "identifier"
                    | "field_identifier"
                    | "structured_binding_declarator"
                    | "pointer_declarator"
                    | "reference_declarator"
                    | "array_declarator"
                    | "attributed_declarator"
                    | "parenthesized_declarator"
                    | "function_declarator"
                    | "init_declarator"
            )
        })
    })
}

/// Include evidence relates one header declaration to one implementation file
/// without pretending that every external name in a workspace belongs to one
/// linker unit.
///
/// The question is whether the implementation file's translation unit sees the
/// declaring header at all, and a translation unit sees every header in its
/// `#include` closure, not only the ones it names itself. `llama-vocab.cpp`
/// defines `llama_tokenize`, declared in `llama.h`, while including only
/// `llama-vocab.h`, which includes `llama.h`; reading the direct include list
/// refused that pair and left definition navigation with a bodiless
/// declaration (#2909).
///
/// [`cpp_include_closure_reaches`] is that closure. It resolves each include
/// the way visibility does, to a unique target or to nothing, so two headers
/// sharing a basename still relate only to the translation units that
/// unambiguously name them.
///
/// A body can also live in a header: fmt's `format-inl.h` defines
/// `detail::vformat_to`, declared in `base.h`, and includes `format.h`, which
/// includes `base.h`. Every translation unit that compiles that body also sees
/// the body file's include closure, so the same closure proves the pair. For
/// two headers either closure may reach the other, because a declaring header
/// can instead include its inline-implementation header at its end (#6138).
/// Two implementation files still never relate: neither is part of the other's
/// translation unit.
pub fn cpp_header_body_files_are_related(
    source: &dyn CppSource,
    token: QueryToken<'_>,
    left: &ProjectFile,
    right: &ProjectFile,
) -> bool {
    match (
        cpp_source_path_is_header(left),
        cpp_source_path_is_header(right),
    ) {
        (true, false) => cpp_include_closure_reaches(source, token, right, left),
        (false, true) => cpp_include_closure_reaches(source, token, left, right),
        (true, true) => {
            cpp_include_closure_reaches(source, token, left, right)
                || cpp_include_closure_reaches(source, token, right, left)
        }
        (false, false) => false,
    }
}

pub fn cpp_source_path_is_header(source: &ProjectFile) -> bool {
    let path = rel_path_string(source).to_ascii_lowercase();
    matches!(
        path.rsplit('.').next(),
        Some("h" | "hin" | "hh" | "hpp" | "hxx")
    )
}

pub(crate) fn cpp_occurrence_role_for_node(
    node: Node<'_>,
    source: &str,
    candidate: &CodeUnit,
) -> CppOccurrenceRole {
    if !candidate.is_callable() && !candidate.is_class() {
        return CppOccurrenceRole::Both;
    }
    if candidate.is_callable() {
        return if subtree_contains(node, |descendant| {
            descendant.kind() == "function_definition"
                && descendant.child_by_field_name("body").is_some()
        }) {
            CppOccurrenceRole::Definition
        } else {
            CppOccurrenceRole::DeclarationOnly
        };
    }
    // A typedef or `using` declaration both declares and defines the alias it
    // names, even when it mentions a bodiless elaborated type such as
    // `typedef struct node_t *node;` (#2430).
    if cpp_node_declares_alias(node, source, candidate) {
        return CppOccurrenceRole::Both;
    }
    if node.kind() == "function_definition" && node.child_by_field_name("body").is_some() {
        return CppOccurrenceRole::Definition;
    }
    if !subtree_contains(node, |descendant| {
        matches!(
            descendant.kind(),
            "class_specifier" | "struct_specifier" | "union_specifier" | "enum_specifier"
        )
    }) {
        return CppOccurrenceRole::Both;
    }
    if subtree_contains(node, |descendant| {
        matches!(
            descendant.kind(),
            "class_specifier" | "struct_specifier" | "union_specifier" | "enum_specifier"
        ) && descendant.child_by_field_name("body").is_some()
    }) {
        CppOccurrenceRole::Definition
    } else {
        CppOccurrenceRole::DeclarationOnly
    }
}

pub fn cpp_occurrence_role_for_range(
    recovered_export_classes: &CppRecoveredExportClassIndex,
    root: Node<'_>,
    source: &str,
    candidate: &CodeUnit,
    range: &Range,
) -> CppOccurrenceRole {
    if !candidate.is_callable() && !candidate.is_class() {
        return CppOccurrenceRole::Both;
    }
    let Some(node) = cpp_declaration_node_for_range(root, range) else {
        return CppOccurrenceRole::Unknown;
    };
    if candidate.is_callable()
        && subtree_contains(node, |descendant| {
            descendant.kind() == "function_definition"
                && descendant.child_by_field_name("body").is_some()
        })
    {
        return CppOccurrenceRole::Definition;
    }
    // A callable recovered from a mangled region owns no node of its own,
    // so the climb above landed on the container the parser left -- an
    // access label, an `ERROR`, a statement -- and the scan answered for
    // whatever else that container holds. Ask the recovery about this exact
    // range instead, the same way a recovered class is asked below. An
    // ordinary declaration lands on a declaration node and never gets here.
    if candidate.is_callable()
        && !matches!(
            node.kind(),
            "declaration" | "field_declaration" | "function_definition"
        )
        && let Some(has_body) = recovered_callable_body_at(source, range)
    {
        return if has_body {
            CppOccurrenceRole::Definition
        } else {
            CppOccurrenceRole::DeclarationOnly
        };
    }
    if candidate.is_class()
        && node.kind() == "function_definition"
        && node.child_by_field_name("body").is_some()
    {
        return CppOccurrenceRole::Definition;
    }
    // A recovered export-macro class owns no node of its own, so the fallback
    // climb lands on the enclosing container and the specifier scan below would
    // answer for whatever else that container holds. In a header where every
    // class is macro decorated, no plain specifier has a body and the scan
    // calls every class a forward declaration. Ask the recovery shapes about
    // this exact range first; they are the same answer the resolver's
    // declaration strength uses.
    if candidate.is_class()
        && let Some(has_body) = recovered_class_body_at(
            recovered_export_classes,
            root,
            source,
            candidate.identifier(),
            range,
        )
    {
        return if has_body {
            CppOccurrenceRole::Definition
        } else {
            CppOccurrenceRole::DeclarationOnly
        };
    }
    cpp_occurrence_role_for_node(node, source, candidate)
}

/// Whether `node` is the typedef or `using` alias declaration of `candidate`.
fn cpp_node_declares_alias(node: Node<'_>, source: &str, candidate: &CodeUnit) -> bool {
    match node.kind() {
        "alias_declaration" => {
            node.child_by_field_name("name")
                .and_then(|name| name.utf8_text(source.as_bytes()).ok())
                == Some(candidate.identifier())
        }
        "type_definition" => {
            let mut cursor = node.walk();
            node.children_by_field_name("declarator", &mut cursor)
                .any(|declarator| {
                    crate::declarations::extract_typedef_declarator_name(declarator, source)
                        .as_deref()
                        == Some(candidate.identifier())
                })
        }
        _ => false,
    }
}

/// Whether the occurrence at `range` is a pure-virtual member declaration
/// (`virtual T f() = 0;`).
///
/// A pure virtual is the C++ spelling of an abstract method: `= 0` says the
/// declaration has no body, so the declaration is itself the definition site.
/// Definition navigation answers with it the way the JVM adapters answer an
/// interface method with its declaration, instead of reporting that the
/// candidates hold no implementation body (#2178). A pure virtual may still
/// carry an out-of-line body; that occurrence is a real definition and is
/// selected on its own role.
pub fn cpp_range_is_pure_virtual_declaration(root: Node<'_>, source: &str, range: &Range) -> bool {
    let Some(node) = cpp_declaration_node_for_range(root, range) else {
        return false;
    };
    let mut current = Some(node);
    while let Some(node) = current {
        match node.kind() {
            "field_declaration" => {
                // `int data = 0;` and `int (*hook)() = 0;` share this
                // `default_value` shape, so the declarator has to be a real
                // function declarator rather than a function-pointer member.
                return node
                    .child_by_field_name("default_value")
                    .is_some_and(|value| {
                        value.kind() == "number_literal" && node_text(value, source) == "0"
                    })
                    && node
                        .child_by_field_name("declarator")
                        .and_then(extract_function_declarator)
                        .is_some();
            }
            // Anything at or above the member list is a different construct:
            // the occurrence range names the declaration or one of its parts.
            "field_declaration_list" | "function_definition" | "translation_unit" => return false,
            _ => current = node.parent(),
        }
    }
    false
}

fn cpp_declaration_node_for_range<'tree>(root: Node<'tree>, range: &Range) -> Option<Node<'tree>> {
    node_for_exact_range(root, range).or_else(|| {
        root.descendant_for_byte_range(range.start_byte, range.end_byte)
            .and_then(|mut node| {
                while node.start_byte() > range.start_byte || node.end_byte() < range.end_byte {
                    node = node.parent()?;
                }
                Some(node)
            })
    })
}

/// The #1134 resolution-time identity-reconciliation overlay for one queried
/// canonical `fq_name`.
///
/// For each out-of-line member definition whose per-file provisional identity
/// the include-visible class table re-keys to this name, it holds a *re-keyed*
/// `CodeUnit` -- a synthetic unit carrying the canonical identity but the
/// definition's real `.cpp` source -- so a canonical query resolves the
/// definition alongside its header declaration across every resolution surface
/// (`definitions`, source blocks, occurrence roles, canonical selectors). The
/// re-keyed unit is not in the store, so `provisional_of` maps it back to the
/// stored provisional unit for range and signature-metadata lookups.
#[derive(Default)]
pub struct CppReconciledDefinitionIndex {
    /// Re-keyed definitions belonging under the queried canonical `fq_name`.
    pub rekeyed: Vec<CodeUnit>,
    /// Re-keyed unit -> the stored provisional unit its indexed data lives under.
    pub provisional_of: HashMap<CodeUnit, CodeUnit>,
}

/// One bounded reconciliation cohort, with both identity directions. Physical
/// units remain the keys of immutable extraction facts; canonical units retain
/// their source, signature and synthetic provenance.
#[derive(Default)]
pub struct CppReconciledGroup {
    pub by_name: HashMap<String, Arc<CppReconciledDefinitionIndex>>,
    pub canonical_of: HashMap<CodeUnit, CodeUnit>,
}

/// Derive a cohort from recorded segment boundaries. Physical declarations
/// must use this path instead of re-parsing their rendered protocol name.
pub fn cpp_reconcile_group_key_for_fq(
    fq: &brokk_bifrost_core::analyzer::fq_name::FqName,
) -> Option<CppReconcileGroupKey> {
    let interner = segment_interner();
    let (member_identifier, _) = interner.resolve(fq.last()?);
    if member_identifier.is_empty() {
        return None;
    }
    let owner_terminal = fq
        .segments()
        .len()
        .checked_sub(2)
        .map(|index| interner.resolve(fq.segments()[index]).0.to_string());
    Some(CppReconcileGroupKey {
        member_identifier: member_identifier.to_string(),
        owner_terminal,
    })
}

/// Which candidates one reconcile group covers: a member identifier, and the
/// terminal owner component that #1566's pre-filter admits.
///
/// This -- not the queried fq name -- is the unit reconciliation is a function
/// of, and keying the memo by it is the #1908 fix. The old key was the queried
/// fq name, so a bare identifier that 1,277 distinct owners answer produced
/// 1,277 distinct keys, none of which ever hit, each re-running the identical
/// `lookup_candidates_by_identifier` store read and re-scanning the identical
/// 2,898-candidate set: 3.70M candidate evaluations for one request.
///
/// The owner terminal stays in the key rather than being dropped for a plain
/// per-identifier map. Dropping it would mean reconciling every same-named
/// candidate in the workspace on the first query for that identifier, which is
/// exactly the cost #1566 removed -- chromium paid ~75 s per member query that
/// way. `reconcile_skips_same_named_members_of_unrelated_classes_1566` pins it.
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct CppReconcileGroupKey {
    /// The queried name's terminal segment: the member identifier the
    /// persisted identifier index is probed with.
    pub member_identifier: String,
    /// The terminal component of the queried name's penultimate segment, or
    /// `None` for a single-segment (bare) query, where #1566's pre-filter is
    /// inert and every candidate has to be reconciled.
    pub owner_terminal: Option<String>,
}

/// Which member identifier and owner terminal a queried canonical name asks
/// about, or `None` when the name has no terminal segment to probe with.
///
/// Parsed through the sanctioned input-edge parser rather than split here, and
/// note `$` is not a segment boundary for it -- a nested owner chain stays one
/// segment, so the terminal really is the member.
pub fn cpp_reconcile_group_key(fq_name: &str) -> Option<CppReconcileGroupKey> {
    let interner = segment_interner();
    let query_fq = parse_symbol_path_fq(Language::Cpp, fq_name, interner);
    let (member_identifier, _) = interner.resolve(query_fq.last()?);
    if member_identifier.is_empty() {
        return None;
    }
    // #1566 owner-terminal pre-filter: the reconciler only re-partitions a
    // candidate's qualifier -- the class chain it emits is always a suffix
    // of the candidate's owner segments (`reconcile.rs`) -- so the terminal
    // `$` component of any identity it can produce equals the candidate's
    // terminal owner segment. A candidate whose terminal owner differs
    // from the queried name's penultimate segment can therefore never
    // re-key onto it, and skipping it avoids the role check and, on
    // whale repos, an include-closure class-table build per same-named
    // candidate in the repo.
    let owner_terminal = query_fq.segments().len().checked_sub(2).map(|penultimate| {
        let (text, _) = interner.resolve(query_fq.segments()[penultimate]);
        // fqname-M4: the input-edge parser above deliberately keeps a nested
        // owner chain as one `$`-joined segment (no structured sub-segments
        // exist at this surface), so the terminal component must come from
        // the raw text.
        text.rsplit_once('$')
            .map_or(text, |(_, tail)| tail)
            .to_string()
    });
    Some(CppReconcileGroupKey {
        member_identifier: member_identifier.to_string(),
        owner_terminal,
    })
}

/// Every callable declaration in the workspace sharing one member identifier,
/// bucketed by its terminal owner segment.
///
/// One store read and one pass over the candidate set per identifier, memoized
/// on the analyzer. Before #1908 both were re-run once per queried fq name.
pub struct CppReconcileCandidates {
    by_owner_terminal: HashMap<String, Vec<CodeUnit>>,
    /// Every bucketed candidate, in the order the sorted candidate set
    /// produced them. What a bare query has to reconcile, since #1566's
    /// pre-filter cannot narrow it.
    all: Vec<CodeUnit>,
}

impl CppReconcileCandidates {
    /// The candidates a group key admits: one owner-terminal bucket, or every
    /// candidate for a bare query.
    fn for_group(&self, key: &CppReconcileGroupKey) -> &[CodeUnit] {
        match &key.owner_terminal {
            Some(owner_terminal) => self
                .by_owner_terminal
                .get(owner_terminal)
                .map_or(&[][..], Vec::as_slice),
            None => &self.all,
        }
    }

    /// Every bucketed candidate, once. What a cache weigher has to charge for.
    pub fn iter(&self) -> impl Iterator<Item = &CodeUnit> {
        self.all.iter()
    }

    /// How many bucket entries reference those candidates. A candidate with no
    /// owner segment is in no bucket, so this is not `len`.
    pub fn bucketed_len(&self) -> usize {
        self.by_owner_terminal.values().map(Vec::len).sum()
    }
}

/// Bucket an already-retrieved identifier cohort for reconciliation.
///
/// The analysis crate's relational executor obtains this cohort in the same
/// batch as the caller's questions. Keeping retrieval outside this semantic
/// function prevents the C++ crate from choosing a second, legacy data-access
/// path while preserving one implementation of the structured owner bucketing.
pub fn cpp_reconcile_candidates_from_units(
    candidates: impl IntoIterator<Item = CodeUnit>,
    keep_going: &dyn Fn() -> bool,
) -> Option<CppReconcileCandidates> {
    let mut candidates = candidates.into_iter().collect::<Vec<_>>();
    candidates.sort();
    candidates.dedup();
    let interner = segment_interner();
    let mut by_owner_terminal: HashMap<String, Vec<CodeUnit>> = HashMap::default();
    let mut all = Vec::new();
    for (index, unit) in candidates.into_iter().enumerate() {
        // Bucketing is a segment walk per candidate, cheap next to the role
        // check and class-table build the groups pay, so the poll runs per
        // batch rather than per candidate.
        if index % CANDIDATE_BUCKETING_POLL_STRIDE == 0 && !keep_going() {
            return None;
        }
        if !unit.is_callable() {
            continue;
        }
        let owner_terminal = unit
            .fq()
            .segments()
            .iter()
            .filter_map(|&segment| {
                let (text, kind) = interner.resolve(segment);
                // Candidate fq segments carry real boundaries (each nested
                // class is its own `SegmentKind::Nested` segment), so the
                // segment text is already the terminal component.
                matches!(
                    kind,
                    SegmentKind::Package | SegmentKind::Type | SegmentKind::Nested
                )
                .then_some(text)
            })
            .last();
        if let Some(owner_terminal) = owner_terminal {
            by_owner_terminal
                .entry(owner_terminal.to_string())
                .or_default()
                .push(unit.clone());
        }
        all.push(unit);
    }
    // The final batch can be shorter than the polling stride, or empty.
    // Refuse publication when its deadline expires after the last loop poll.
    if !keep_going() {
        return None;
    }
    Some(CppReconcileCandidates {
        by_owner_terminal,
        all,
    })
}

/// How many candidates the bucketing pass walks between deadline polls.
const CANDIDATE_BUCKETING_POLL_STRIDE: usize = 256;

/// Reconcile every candidate one group key admits, grouped by the canonical
/// `fq_name` each re-keyed definition belongs under.
///
/// Deliberately **not** a workspace-wide index: building one would need a full
/// declaration scan, and a warm forward lookup must not trigger one
/// (`tests/analyzer_persistence.rs`'s candidate-bounded contract). Instead each
/// group reconciles only the candidates the persisted terminal identifier
/// index already offers, which is the same bounded lookup the ordinary
/// resolution path uses.
///
/// A definition whose reconciled identity equals its provisional one (the
/// overwhelming majority, including genuine `ns1::ns2::Klass::method` namespace
/// chains) contributes nothing.
///
/// `None` means `keep_going` went false mid-scan. Nothing may be memoized
/// then; see [`cpp_reconcile_candidates`].
pub fn cpp_reconcile_group(
    cpp: &dyn CppSource,
    token: QueryToken<'_>,
    key: &CppReconcileGroupKey,
    candidates: &CppReconcileCandidates,
    keep_going: &dyn Fn() -> bool,
    on_candidate: &dyn Fn(),
) -> Option<CppReconciledGroup> {
    let _scope = profiling::scope_with(|| {
        format!(
            "cpp.reconciled.build[{}#{}]",
            key.member_identifier,
            key.owner_terminal.as_deref().unwrap_or("*")
        )
    });
    let mut groups: HashMap<String, CppReconciledDefinitionIndex> = HashMap::default();
    let mut using_by_file: HashMap<ProjectFile, Arc<Vec<String>>> = HashMap::default();
    for unit in candidates.for_group(key) {
        // Per candidate, not per batch: each iteration below can run a role
        // check (0.265 ms mean in the #1908 trace) and an include-visible
        // class-table read, so an atomic load per iteration is free by
        // comparison.
        if !keep_going() {
            return None;
        }
        on_candidate();
        // Lazy: `fq_name` clones a String, and this loop runs once per
        // same-named candidate the group admits.
        let _candidate =
            profiling::scope_with(|| format!("cpp.reconcile.candidate[{}]", unit.fq_name()));
        let role = {
            let _role = profiling::scope("cpp.reconcile.role");
            cpp.stored_callable_unit_role(unit)
        };
        if !matches!(
            role,
            CppCallableUnitRole::Definition | CppCallableUnitRole::Both
        ) {
            continue;
        }
        let Some(reconciled) =
            cpp_reconcile_definition_identity(cpp, token, unit, &mut using_by_file, keep_going)
        else {
            continue;
        };
        let canonical_fq = reconciled.fq_name();
        // A candidate that already carries the canonical identity is the
        // stored declaration, not a re-keying of it. Before #1908 this read
        // `unit.fq_name() == fq_name` against the queried name, checked before
        // the reconcile; against the group's canonical key it is the same
        // predicate for the same (query, candidate) pair, because a candidate
        // only ever lands under its own reconciled identity.
        if unit.fq_name() == canonical_fq {
            continue;
        }
        // Re-key onto the canonical identity while keeping the definition's
        // real `.cpp` source and signature, so it resolves as a definition
        // alongside its header declaration under the canonical `fq_name`.
        // The structured `FqName` is rebuilt from the *canonical* package and
        // owner chain through the same emission helper extraction uses, so
        // the re-keyed unit carries real segment boundaries: owner lookup
        // (`default_parent_fq_name`) is a pure segment pop, where an empty
        // `fq` would mean "no owner" rather than "not yet migrated".
        let short_name = format!("{}.{}", reconciled.owner_chain, reconciled.member);
        let fq = cpp_member_fq(&reconciled.package, &short_name);
        let rekeyed = CodeUnit::with_signature_and_fq(
            unit.source().clone(),
            unit.kind(),
            reconciled.package,
            short_name,
            unit.signature().map(str::to_string),
            unit.is_synthetic(),
            fq,
        );
        let index = groups.entry(canonical_fq).or_default();
        index.rekeyed.push(rekeyed.clone());
        index.provisional_of.insert(rekeyed, unit.clone());
    }
    let canonical_of = groups
        .values()
        .flat_map(|index| {
            index
                .provisional_of
                .iter()
                .map(|(canonical, physical)| (physical.clone(), canonical.clone()))
        })
        .collect();
    let group = CppReconciledGroup {
        canonical_of,
        by_name: groups
            .into_iter()
            .map(|(canonical_fq, index)| (canonical_fq, Arc::new(index)))
            .collect(),
    };
    // A deadline can expire in the last candidate or provenance assembly.
    // The cache must receive only a fully completed, uncancelled cohort.
    keep_going().then_some(group)
}

/// Reconcile one out-of-line member definition's provisional identity against
/// the class table visible to its file. Returns `None` for anything that is
/// not a re-keyable out-of-line member or that the class table does not
/// confirm. A one-segment class qualifier is valid when a structured using
/// namespace and the visible class table confirm its package.
fn cpp_reconcile_definition_identity(
    cpp: &dyn CppSource,
    token: QueryToken<'_>,
    unit: &CodeUnit,
    using_by_file: &mut HashMap<ProjectFile, Arc<Vec<String>>>,
    keep_going: &dyn Fn() -> bool,
) -> Option<ReconciledIdentity> {
    // Read the full source-order qualifier off the definition's *structured*
    // `FqName` -- the namespace (`Package`) segments followed by the
    // class-nesting (`Type`/`Nested`) ones, with the terminal `Member` as the
    // member name. The segment boundaries were recorded at extraction, so
    // nothing here re-infers them by splitting the rendered name on a guessed
    // delimiter (the shape `tests/no_stringly_name_parsing.rs` guards). The
    // reconciler then re-partitions this whole sequence against the class
    // table, so extraction need not have decided where the namespace ends and
    // the class chain begins.
    let interner = segment_interner();
    let mut provisional_owner_segments: Vec<&str> = Vec::new();
    let mut member: Option<&str> = None;
    for &segment in unit.fq().segments() {
        let (text, kind) = interner.resolve(segment);
        match kind {
            SegmentKind::Package | SegmentKind::Type | SegmentKind::Nested => {
                // A `Member` is always terminal in a cpp callable's chain; a
                // qualifier segment after one would mean the identity is not
                // the plain `namespace... class... member` shape this handles.
                if member.is_some() {
                    return None;
                }
                if !text.is_empty() {
                    provisional_owner_segments.push(text);
                }
            }
            SegmentKind::Member => member = Some(text),
            _ => return None,
        }
    }
    let member = member?;
    // Keep multi-owner/template reconciliation on the existing provisional
    // structured chain. A single written owner needs independent lexical proof
    // before replacing that chain (which may include a guessed using package).
    let single_owner = cpp_single_owner_context(cpp, token, unit, keep_going)?;
    let owner_segments = single_owner.as_ref().map_or_else(
        || provisional_owner_segments,
        |context| vec![context.owner.as_str()],
    );
    if owner_segments.is_empty() {
        return None;
    }

    let visible = {
        let _visible = profiling::scope_with(|| {
            format!("cpp.reconcile.visible[{}]", rel_path_string(unit.source()))
        });
        cpp.visible_type_units(unit.source())
    };
    let class_table: Vec<VisibleClass> = visible
        .iter()
        .filter(|candidate| candidate.is_class())
        .map(|candidate| VisibleClass {
            package: candidate.package_name(),
            nested_short_name: candidate.short_name(),
        })
        .collect();

    if let Some(context) = &single_owner {
        if context.global {
            // Leading :: excludes lexical and using-namespace candidates.
            return keep_going().then(|| {
                reconcile_out_of_line_member_identity(&owner_segments, member, &[""], &class_table)
            })?;
        }
        // Namespace proof is not a guessed class-owner chain. Keep each
        // namespace tier separate from the written owner, so a global nested
        // class cannot win by repartitioning those proven namespace segments.
        for tier in
            lexical_component_tiers(&[], false, &context.lexical).take(context.lexical.len())
        {
            if !keep_going() {
                return None;
            }
            let namespace = tier.join("::");
            if let Some(identity) = reconcile_out_of_line_member_identity(
                &owner_segments,
                member,
                &[namespace.as_str()],
                &class_table,
            ) {
                return keep_going().then_some(identity);
            }
        }
    }
    if !keep_going() {
        return None;
    }
    let using = using_by_file
        .entry(unit.source().clone())
        .or_insert_with(|| {
            Arc::new(
                cpp.declaration_source_facts(token, unit.source())
                    .map(|source| {
                        source
                            .facts
                            .using_namespaces
                            .iter()
                            .map(|(_, name)| name.clone())
                            .collect()
                    })
                    .unwrap_or_default(),
            )
        })
        .clone();
    let mut namespace_candidates: Vec<&str> = vec![""];
    namespace_candidates.extend(using.iter().map(String::as_str));

    reconcile_out_of_line_member_identity(
        &owner_segments,
        member,
        &namespace_candidates,
        &class_table,
    )
}

#[derive(PartialEq, Eq)]
struct CppSingleOwnerContext {
    owner: String,
    global: bool,
    lexical: Vec<String>,
}

/// Exact physical declaration/name anchors prove namespace context, never a
/// guessed Package or a containing malformed wrapper. All records must agree.
fn cpp_single_owner_context(
    cpp: &dyn CppSource,
    token: QueryToken<'_>,
    unit: &CodeUnit,
    keep_going: &dyn Fn() -> bool,
) -> Option<Option<CppSingleOwnerContext>> {
    let facts = cpp.declaration_source_facts(token, unit.source())?;
    // Some(None) keeps the legacy multi-owner/template path unchanged. Once
    // any record supplies a single owner, every applicable record must prove
    // that same owner/context; missing or conflicting records cannot fall back.
    let mut has_single = false;
    for fact in facts.for_unit(unit) {
        if !keep_going() {
            return None;
        }
        has_single |= fact.written_owner.len() == 1;
    }
    if !has_single {
        return keep_going().then_some(None);
    }
    let syntax = cpp.prepared_syntax(token, unit.source())?;
    if !keep_going() {
        return None;
    }
    let scopes = cpp.orphaned_namespace_scopes(token, unit.source());
    let root = syntax.tree().root_node();
    let source = syntax.source();
    let mut agreed = None;
    for fact in facts.for_unit(unit) {
        if !keep_going() {
            return None;
        }
        let declaration = facts.source.declaration(fact.declaration);
        let occurrence = facts.source.occurrence(declaration.occurrence).range;
        let name_range = facts.source.occurrence(declaration.name?).range;
        let mut node =
            root.descendant_for_byte_range(occurrence.start_byte, occurrence.end_byte)?;
        // Exact spans can be shared by declarator wrappers. Ascend only along
        // that span; accepting a larger containing envelope is not proof.
        let selected = loop {
            if !keep_going()
                || node.start_byte() != occurrence.start_byte
                || node.end_byte() != occurrence.end_byte
            {
                return None;
            }
            if matches!(
                node.kind(),
                "function_definition" | "function_declarator" | "declaration" | "field_declaration"
            ) {
                break node;
            }
            node = node.parent()?;
        };
        let callable = if selected.kind() == "function_declarator" {
            selected
        } else {
            selected
                .child_by_field_name("declarator")
                .and_then(extract_function_declarator)?
        };
        let name = declarator_name_node(callable)?;
        let terminal = cpp_name_component_nodes(name)?.pop()?;
        if name.is_missing()
            || name.has_error()
            || terminal.is_missing()
            || terminal.start_byte() != name_range.start_byte
            || terminal.end_byte() != name_range.end_byte
            || node_text(terminal, source) != unit.identifier()
        {
            return None;
        }
        let qualified = qualified_owner_components(name, source)?;
        if qualified.names.len() != 1 || qualified.names != fact.written_owner {
            return None;
        }
        let proof = CppSingleOwnerContext {
            owner: qualified.names.into_iter().next()?,
            global: qualified.global,
            lexical: scopes.enclosing_namespace_components(selected, source),
        };
        if !keep_going() || agreed.as_ref().is_some_and(|prior| prior != &proof) {
            return None;
        }
        agreed = Some(proof);
    }
    if !keep_going() {
        return None;
    }
    Some(Some(agreed?))
}

#[cfg(test)]
mod tests {
    use super::*;
    use brokk_bifrost_test_macros::hardwon;

    #[test]
    fn physical_identity_cohorts_keep_recorded_owner_and_member_boundaries() {
        use brokk_bifrost_core::analyzer::fq_name::FqName;
        let mut fq = FqName::new();
        for (text, kind) in [
            ("ns", SegmentKind::Package),
            ("Owner$Literal", SegmentKind::Type),
            ("operator std::string", SegmentKind::Member),
        ] {
            fq.push(segment_interner().intern(text, kind));
        }
        let key = cpp_reconcile_group_key_for_fq(&fq).unwrap();
        assert_eq!(key.owner_terminal.as_deref(), Some("Owner$Literal"));
        assert_eq!(key.member_identifier, "operator std::string");
    }

    #[test]
    #[hardwon("#2488: terminal cancellation must not publish identity cohorts")]
    fn candidate_cohorts_recheck_terminal_cancellation_before_publish() {
        use std::cell::Cell;

        let unit = CodeUnit::new(
            ProjectFile::new(std::env::temp_dir(), "identity-cancellation.cpp"),
            brokk_bifrost_core::analyzer::model::CodeUnitType::Function,
            "",
            "Owner.run",
        );
        let cancel_after_last_candidate = {
            let active = Cell::new(true);
            move || active.replace(false)
        };
        assert!(
            cpp_reconcile_candidates_from_units(
                std::iter::once(unit.clone()),
                &cancel_after_last_candidate,
            )
            .is_none(),
            "a cancellation observed after the last sub-256 candidate must prevent publication"
        );

        let candidates = (0..=CANDIDATE_BUCKETING_POLL_STRIDE)
            .map(|index| {
                CodeUnit::new(
                    ProjectFile::new(std::env::temp_dir(), "identity-cancellation.cpp"),
                    brokk_bifrost_core::analyzer::model::CodeUnitType::Function,
                    "",
                    format!("Owner{index}.run"),
                )
            })
            .collect::<Vec<_>>();
        let cancel_at_bucket_boundary = {
            let active = Cell::new(true);
            move || active.replace(false)
        };
        assert!(
            cpp_reconcile_candidates_from_units(candidates, &cancel_at_bucket_boundary).is_none(),
            "a cancellation at the bucket boundary must prevent a partial cohort from publishing"
        );

        let cancelled = || false;
        assert!(
            cpp_reconcile_candidates_from_units(Vec::<CodeUnit>::new(), &cancelled).is_none(),
            "an empty cancelled cohort must not publish"
        );
    }

    fn parse_cpp(source: &str) -> Tree {
        crate::diagnostics::parse_cpp_tree(source)
    }

    fn is_declarator_name(tree: &Tree, source: &str, start: usize, text: &str) -> bool {
        let end = start + text.len();
        assert_eq!(&source[start..end], text, "the probe must name the token");
        let node = tree
            .root_node()
            .named_descendant_for_byte_range(start, end)
            .expect("a node spans the probed range");
        assert_eq!(
            (node.start_byte(), node.end_byte()),
            (start, end),
            "the probed range must be exactly one node: {}",
            node.to_sexp()
        );
        cpp_is_constructor_or_destructor_declarator_name(node, source)
    }

    fn is_conversion_target(tree: &Tree, source: &str, start: usize, text: &str) -> bool {
        let end = start + text.len();
        assert_eq!(&source[start..end], text, "the probe must name the token");
        let node = tree
            .root_node()
            .named_descendant_for_byte_range(start, end)
            .expect("a node spans the probed range");
        assert_eq!(
            (node.start_byte(), node.end_byte()),
            (start, end),
            "the probed range must be exactly one node: {}",
            node.to_sexp()
        );
        cpp_is_conversion_operator_target_type(node)
    }

    fn is_recovered_macro_character_type(
        tree: &Tree,
        source: &str,
        start: usize,
        text: &str,
    ) -> bool {
        let end = start + text.len();
        assert_eq!(&source[start..end], text, "the probe must name the token");
        let node = tree
            .root_node()
            .named_descendant_for_byte_range(start, end)
            .expect("a node spans the probed range");
        cpp_is_recovered_macro_character_token_type(node)
    }

    #[test]
    #[hardwon(
        "b114d87215ca: C++ FIRD census assigned a declaration token the wrong reference/definition role"
    )]
    fn recovered_macro_character_tokens_are_not_type_references() {
        let source = concat!(
            "struct I {};\n",
            "#define STRING_TOKEN_(name, ...)\n",
            "struct Schema {\n",
            "  STRING_TOKEN_(MaxItems, 'm', 'I')\n",
            "  void ordinary(I value);\n",
            "  void malformed(I value, @);\n",
            "  void use() { I value; consume('I'); }\n",
            "};\n",
        );
        let tree = parse_cpp(source);
        let recovered_m = source.find("'m'").expect("recovered m") + 1;
        let recovered_i = source.find("'I'").expect("recovered I") + 1;
        for (label, start, text) in [
            ("lowercase character token", recovered_m, "m"),
            ("uppercase character token", recovered_i, "I"),
        ] {
            assert!(
                is_recovered_macro_character_type(&tree, source, start, text),
                "{label} must match the exact recovery role"
            );
        }

        let macro_first_argument = source.find("MaxItems").expect("macro first argument");
        let ordinary = source.find("ordinary(I").expect("ordinary parameter") + "ordinary(".len();
        let malformed =
            source.find("malformed(I").expect("malformed parameter") + "malformed(".len();
        let local = source
            .find("I value; consume")
            .expect("local type reference");
        let expression_character = source.rfind("'I'").expect("expression character") + 1;
        for (label, start, text) in [
            ("unquoted macro argument", macro_first_argument, "MaxItems"),
            ("ordinary parameter type", ordinary, "I"),
            ("parameter beside another error", malformed, "I"),
            ("local type reference", local, "I"),
            ("expression character literal", expression_character, "I"),
        ] {
            assert!(
                !is_recovered_macro_character_type(&tree, source, start, text),
                "{label} must remain outside the recovery role"
            );
        }
    }

    #[test]
    #[hardwon(
        "0733cadab142: C++ FIRD census assigned a declaration token the wrong reference/definition role"
    )]
    fn conversion_operator_target_components_are_identity_syntax_only() {
        let source = concat!(
            "namespace other { struct Target {}; template<class T> struct Box {}; }\n",
            "using other::Target;\n",
            "struct Source {\n",
            "  operator Target() const;\n",
            "  operator other::Target() const { return other::Target{}; }\n",
            "  template<class T> operator other::Box<T>() const { return {}; }\n",
            "  operator other::Target const&() const;\n",
            "  operator other::Target*() const;\n",
            "  other::Target ordinary() const {\n",
            "    return reinterpret_cast<other::Target&>(*this);\n",
            "  }\n",
            "  other::Target operator+() const { return {}; }\n",
            "};\n",
        );
        let tree = parse_cpp(source);

        let bare = source.find("operator Target").expect("bare target") + "operator ".len();
        let qualified = source
            .find("operator other::Target()")
            .expect("qualified target")
            + "operator ".len();
        let template = source
            .find("operator other::Box<T>")
            .expect("template target")
            + "operator ".len();
        let cv_reference = source
            .find("operator other::Target const&")
            .expect("cv-reference target")
            + "operator other::".len();
        let pointer = source
            .find("operator other::Target*")
            .expect("pointer target")
            + "operator other::".len();

        for (label, start, text) in [
            ("bare target", bare, "Target"),
            ("qualified target scope", qualified, "other"),
            (
                "qualified target name",
                qualified + "other::".len(),
                "Target",
            ),
            ("template target scope", template, "other"),
            ("template target name", template + "other::".len(), "Box"),
            (
                "template target argument",
                template + "other::Box<".len(),
                "T",
            ),
            ("cv-reference target", cv_reference, "Target"),
            ("pointer target", pointer, "Target"),
        ] {
            assert!(
                is_conversion_target(&tree, source, start, text),
                "the {label} at byte {start} belongs to the conversion identity"
            );
        }

        let ordinary_return = source
            .find("other::Target ordinary")
            .expect("ordinary return");
        let body_cast = source
            .find("reinterpret_cast<other::Target")
            .expect("body cast")
            + "reinterpret_cast<".len();
        let overloaded_return = source
            .find("other::Target operator+")
            .expect("overloaded operator return");
        for (label, start) in [
            ("ordinary return type", ordinary_return),
            ("body cast target", body_cast),
            ("overloaded-operator return type", overloaded_return),
        ] {
            assert!(
                !is_conversion_target(&tree, source, start, "other"),
                "the {label} at byte {start} stays a reference"
            );
        }
    }

    /// The parsed-as-declared shape, in class and out of line. The names that
    /// surround a declarator stay references: the owning scope of an out-of-line
    /// definition, a parameter type that happens to be the class, and the class
    /// name itself.
    #[test]
    #[hardwon(
        "246fc91b2fb6: C++ FIRD census assigned a declaration token the wrong reference/definition role"
    )]
    fn declared_constructor_and_destructor_declarator_names_are_not_references() {
        let source = concat!(
            "class Foo {\n",
            "public:\n",
            "  Foo();\n",
            "  Foo(const Foo&);\n",
            "  ~Foo();\n",
            "  void m();\n",
            "};\n",
            "Foo::Foo() {}\n",
            "Foo::~Foo() {}\n",
            "void Foo::m() {}\n",
        );
        let tree = parse_cpp(source);

        for (label, start, text) in [
            (
                "constructor declaration",
                source.find("Foo();").expect("ctor"),
                "Foo",
            ),
            (
                "copy constructor declaration",
                source.find("Foo(const Foo&);").expect("copy ctor"),
                "Foo",
            ),
            (
                "destructor name",
                source.find("~Foo();").expect("dtor"),
                "~Foo",
            ),
            (
                "identifier inside the destructor name",
                source.find("~Foo();").expect("dtor") + "~".len(),
                "Foo",
            ),
            (
                "out-of-line constructor definition name",
                source.find("Foo::Foo() {}").expect("out-of-line ctor") + "Foo::".len(),
                "Foo",
            ),
            (
                "out-of-line destructor definition name",
                source.find("Foo::~Foo() {}").expect("out-of-line dtor") + "Foo::".len(),
                "~Foo",
            ),
        ] {
            assert!(
                is_declarator_name(&tree, source, start, text),
                "the {label} at byte {start} is a declaration occurrence"
            );
        }

        for (label, start, text) in [
            (
                "class name",
                source.find("class Foo {").expect("class") + "class ".len(),
                "Foo",
            ),
            (
                "parameter type",
                source.find("const Foo&").expect("parameter type") + "const ".len(),
                "Foo",
            ),
            (
                "owning scope of an out-of-line constructor",
                source.find("Foo::Foo() {}").expect("out-of-line ctor"),
                "Foo",
            ),
            (
                "owning scope of an out-of-line destructor",
                source.find("Foo::~Foo() {}").expect("out-of-line dtor"),
                "Foo",
            ),
            (
                "out-of-line method name",
                source.find("void Foo::m() {}").expect("out-of-line method") + "void Foo::".len(),
                "m",
            ),
        ] {
            assert!(
                !is_declarator_name(&tree, source, start, text),
                "the {label} at byte {start} stays a reference"
            );
        }
    }

    /// Constructor CALL sites are references. `new D(...)`, the direct
    /// initialization `D x(...)`, a member initializer and a bare temporary
    /// statement all name the type, and none of them is a declarator.
    #[test]
    #[hardwon(
        "246fc91b2fb6: C++ FIRD census assigned a declaration token the wrong reference/definition role"
    )]
    fn constructor_call_sites_stay_references() {
        let source = concat!(
            "struct B { B(int); };\n",
            "struct D : B {\n",
            "  D(int x) : B(x), base_(x) {}\n",
            "  int base_;\n",
            "};\n",
            "void g() {\n",
            "  D* p = new D(1);\n",
            "  D x(2);\n",
            "  D(3);\n",
            "  g();\n",
            "}\n",
        );
        let tree = parse_cpp(source);

        let inline_declarator = source.find("D(int x)").expect("inline constructor");
        assert!(
            is_declarator_name(&tree, source, inline_declarator, "D"),
            "an inline constructor definition name is still a declarator"
        );

        for (label, start, text) in [
            (
                "base member initializer",
                source.find(": B(x)").expect("base initializer") + ": ".len(),
                "B",
            ),
            (
                "field member initializer",
                source.find("base_(x) {}").expect("field initializer"),
                "base_",
            ),
            (
                "new expression type",
                source.find("new D(1)").expect("new expression") + "new ".len(),
                "D",
            ),
            (
                "direct initialization type",
                source.find("D x(2)").expect("direct initialization"),
                "D",
            ),
            (
                "temporary construction statement",
                source.find("D(3)").expect("temporary"),
                "D",
            ),
            (
                "recursive call in a real body",
                source.find("g();").expect("recursive call"),
                "g",
            ),
        ] {
            assert!(
                !is_declarator_name(&tree, source, start, text),
                "the {label} at byte {start} is a reference"
            );
        }
    }

    /// The recovered shape (#1834): an export macro between `class` and the
    /// class name makes the parse read the class body as a function body and
    /// every constructor declaration in it as a call of the class's own name.
    /// The bodies the recovery left intact keep their references.
    #[test]
    #[hardwon(
        "246fc91b2fb6: C++ FIRD census assigned a declaration token the wrong reference/definition role"
    )]
    fn a_constructor_declarator_the_parse_read_as_a_call_is_not_a_reference() {
        let source = concat!(
            "class SAMPLE_EXPORT Properties {\n",
            "  public:\n",
            "    Properties();\n",
            "    DISALLOW_COPY_AND_ASSIGN(Properties);\n",
            "    int size() const;\n",
            "    int total() { return size(); }\n",
            "};\n",
        );
        let tree = parse_cpp(source);

        let recovered = source.find("Properties();").expect("recovered constructor");
        assert!(
            is_declarator_name(&tree, source, recovered, "Properties"),
            "a constructor declaration the parse read as a call is still a declarator"
        );

        for (label, start, text) in [
            (
                "class name in the recovered header",
                source
                    .find("class SAMPLE_EXPORT Properties")
                    .expect("class")
                    + "class SAMPLE_EXPORT ".len(),
                "Properties",
            ),
            (
                "macro invocation in the recovered body",
                source
                    .find("DISALLOW_COPY_AND_ASSIGN(Properties);")
                    .expect("macro invocation"),
                "DISALLOW_COPY_AND_ASSIGN",
            ),
            (
                "call inside a method body the recovery kept",
                source.find("return size();").expect("member call") + "return ".len(),
                "size",
            ),
        ] {
            assert!(
                !is_declarator_name(&tree, source, start, text),
                "the {label} at byte {start} stays a reference"
            );
        }
    }

    /// Every class role in one file, so a header can be classified with no
    /// ordinary body-bearing class in it.
    fn class_roles(source: &str, name: &str) -> Vec<CppOccurrenceRole> {
        let tree = parse_cpp(source);
        let file = ProjectFile::new(std::env::temp_dir(), "occurrence-role.hpp");
        let parsed = crate::adapter::parse_cpp_file(&file, source, &tree);
        let unit = parsed
            .declarations()
            .iter()
            .find(|unit| unit.is_class() && unit.fq_name() == name)
            .unwrap_or_else(|| panic!("missing class {name}: {parsed:#?}"));
        let ranges = parsed.declaration_ranges(unit);
        assert!(!ranges.is_empty(), "{name} must have a declaration range");
        ranges
            .iter()
            .map(|range| {
                cpp_occurrence_role_for_range(
                    &CppRecoveredExportClassIndex::build(tree.root_node(), source),
                    tree.root_node(),
                    source,
                    unit,
                    range,
                )
            })
            .collect()
    }

    /// #2557: the role of a recovered `class MACRO(2, 0) Name` comes from the
    /// recovery itself. The fallback climb lands on the enclosing container, so
    /// a header whose classes are all export-macro decorated used to hold no
    /// body-bearing `class_specifier` at all and every class in it read as a
    /// forward declaration, which dropped it from navigation.
    #[test]
    #[hardwon(
        "ec6b972248cc: C++ FIRD census assigned a declaration token the wrong reference/definition role"
    )]
    fn recovered_export_macro_classes_are_definitions_without_an_ordinary_class() {
        let source = concat!(
            "namespace api {\n",
            "class PROJECT_PUBLIC_API(2, 0) Name final {\n",
            "  public:\n",
            "    Name();\n",
            "};\n",
            "class PROJECT_PUBLIC_API(2, 0) Other : public Name {\n",
            "  public:\n",
            "    Other();\n",
            "};\n",
            "} // namespace api\n",
        );
        for name in ["api.Name", "api.Other"] {
            assert_eq!(
                class_roles(source, name),
                vec![CppOccurrenceRole::Definition],
                "{name} is a complete recovered definition"
            );
        }
    }

    #[test]
    #[hardwon(
        "ec6b972248cc: C++ FIRD census assigned a declaration token the wrong reference/definition role"
    )]
    fn ordinary_class_roles_keep_their_plain_specifier_reading() {
        assert_eq!(
            class_roles("class Plain;\n", "Plain"),
            vec![CppOccurrenceRole::DeclarationOnly],
            "a forward declaration stays a declaration"
        );
        assert_eq!(
            class_roles("class Plain { };\n", "Plain"),
            vec![CppOccurrenceRole::Definition],
            "a complete class stays a definition"
        );
    }
}