1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
//! Links [`StoryData`] into an executable [`Program`].
use alloc::string::String;
use alloc::vec::Vec;
use brink_format::{DefinitionId, NameId, StoryData};
use crate::collections::{Map as HashMap, map_with_capacity};
use crate::error::RuntimeError;
use crate::program::{
ExternalFnEntry, GlobalSlot, LinkedContainer, ListDefEntry, ListItemEntry, PathTarget, Program,
StructShapeEntry,
};
/// Look up a `NameId` in `StoryData::name_table`, failing cleanly on an
/// out-of-range index instead of panicking. `NameId`s embedded in
/// malformed/adversarial bytecode are not guaranteed to be in range — this
/// is the linker's own validation, the sanctioned way for such a program to
/// stop (never an unchecked index panic).
fn resolve_name(data: &StoryData, name_id: NameId) -> Result<String, RuntimeError> {
data.name_table
.get(name_id.0 as usize)
.cloned()
.ok_or(RuntimeError::InvalidNameId(name_id.0))
}
/// Link a [`StoryData`] into an executable [`Program`].
///
/// Builds lookup tables mapping [`DefinitionId`]s to flat array indices.
/// The root container is `containers[0]` by convention — the brink compiler
/// emits the root first.
#[expect(clippy::cast_possible_truncation, clippy::too_many_lines)]
pub fn link(
data: &StoryData,
) -> Result<(Program, Vec<Vec<brink_format::LineEntry>>), RuntimeError> {
let mut container_map = map_with_capacity(data.containers.len());
for (i, cdef) in data.containers.iter().enumerate() {
let idx = i as u32;
container_map.insert(cdef.id, idx);
}
// Build scope line tables and a map from scope_id → table index.
let mut scope_table_map: HashMap<DefinitionId, u32> = map_with_capacity(data.line_tables.len());
let mut line_tables: Vec<Vec<brink_format::LineEntry>> =
Vec::with_capacity(data.line_tables.len());
let mut scope_ids: Vec<DefinitionId> = Vec::with_capacity(data.line_tables.len());
for lt in &data.line_tables {
let idx = line_tables.len() as u32;
scope_table_map.insert(lt.scope_id, idx);
scope_ids.push(lt.scope_id);
line_tables.push(lt.lines.clone());
}
// Build containers with scope_table_idx.
let mut containers = Vec::with_capacity(data.containers.len());
for cdef in &data.containers {
let scope_table_idx = scope_table_map.get(&cdef.scope_id).copied().unwrap_or(0);
containers.push(LinkedContainer {
id: cdef.id,
bytecode: cdef.bytecode.clone(),
counting_flags: cdef.counting_flags,
path_hash: cdef.path_hash,
param_count: cdef.param_count,
params: cdef.params.clone(),
scope_table_idx,
});
}
// Build globals.
let mut globals = Vec::with_capacity(data.variables.len());
let mut global_map = map_with_capacity(data.variables.len());
for (i, gvar) in data.variables.iter().enumerate() {
let idx = i as u32;
global_map.insert(gvar.id, idx);
globals.push(GlobalSlot {
id: gvar.id,
name: gvar.name,
default: gvar.default_value.clone(),
local: gvar.local,
});
}
// Build unified address map from containers and address defs.
// Containers get offset 0 (primary addresses).
let mut address_map = map_with_capacity(data.containers.len() + data.addresses.len());
for (i, cdef) in data.containers.iter().enumerate() {
address_map.insert(cdef.id, (i as u32, 0usize));
}
// Address defs add intra-container targets (and primary addresses from converter).
for addr in &data.addresses {
let container_idx = container_map
.get(&addr.container_id)
.copied()
.ok_or(RuntimeError::UnresolvedDefinition(addr.container_id))?;
address_map.insert(addr.id, (container_idx, addr.byte_offset as usize));
}
// Root container is always the first entry by convention.
if data.containers.is_empty() {
return Err(RuntimeError::NoRootContainer);
}
let root_idx = 0;
let name_table = data.name_table.clone();
// Build list item map.
let mut list_item_map = map_with_capacity(data.list_items.len());
for li in &data.list_items {
list_item_map.insert(
li.id,
ListItemEntry {
name: li.name,
ordinal: li.ordinal,
origin: li.origin,
},
);
}
// Build list defs and list def map.
let mut list_defs = Vec::with_capacity(data.list_defs.len());
let mut list_def_map = map_with_capacity(data.list_defs.len());
for ldef in &data.list_defs {
let idx = list_defs.len();
// Collect all items belonging to this list, sorted by ordinal.
let mut items: Vec<_> = data
.list_items
.iter()
.filter(|li| li.origin == ldef.id)
.collect();
items.sort_by_key(|li| li.ordinal);
let item_ids: Vec<_> = items.iter().map(|li| li.id).collect();
list_def_map.insert(ldef.id, idx);
list_defs.push(ListDefEntry {
name: ldef.name,
items: item_ids,
});
}
// Clone list literals.
let list_literals = data.list_literals.clone();
// Clone the T1b literal pool (`PushLiteral(idx)` targets).
let literal_pool = data.literal_pool.clone();
// Build the TM-4 struct shape table, indexed by `ShapeId` (contiguous
// small-integer ids assigned at codegen time — a plain `Vec` indexed by
// `shape.0` mirrors `literal_pool`'s `u32`-indexed layout, no `HashMap`
// involved).
let mut struct_shapes: Vec<StructShapeEntry> = Vec::with_capacity(data.struct_shapes.len());
for shape in &data.struct_shapes {
let idx = shape.id.0 as usize;
if struct_shapes.len() <= idx {
struct_shapes.resize_with(idx + 1, || StructShapeEntry {
name: NameId(0),
fields: Vec::new(),
});
}
struct_shapes[idx] = StructShapeEntry {
name: shape.name,
fields: shape.fields.clone(),
};
}
// Build external function map.
let mut external_fns = map_with_capacity(data.externals.len());
for ext in &data.externals {
external_fns.insert(
ext.id,
ExternalFnEntry {
name: ext.name,
fallback: ext.fallback,
},
);
}
// Build the path → address lookup used by `Program::find_address`.
//
// When the program carries an explicit `address_paths` table (compiler
// output), it is the source of truth: each entry's qualified path maps to
// its target, resolved through `address_map`. This is what enables
// qualified addressing of scopes (`knot`, `knot.stitch`) and author labels
// (`knot.label`, `knot.stitch.label`).
//
// When the table is empty (legacy `.inkb` or converter output, which does
// not emit it), fall back to deriving scope paths from container names —
// the previous behavior, which already qualifies knot/stitch scope names.
let mut address_by_path: HashMap<String, PathTarget> = HashMap::new();
if data.address_paths.is_empty() {
// `BTreeMap` has no `reserve` — no-op under `no_std`.
#[cfg(feature = "std")]
address_by_path.reserve(data.containers.len());
for (i, cdef) in data.containers.iter().enumerate() {
if let Some(name_id) = cdef.name {
let name = resolve_name(data, name_id)?;
address_by_path.insert(
name,
PathTarget {
id: cdef.id,
container_idx: i as u32,
byte_offset: 0,
},
);
}
}
} else {
// `BTreeMap` has no `reserve` — no-op under `no_std`.
#[cfg(feature = "std")]
address_by_path.reserve(data.address_paths.len());
for ap in &data.address_paths {
// Resolve the target through the address map; skip anything
// unresolvable (defensive — should not happen for valid output).
if let Some(&(idx, offset)) = address_map.get(&ap.target) {
let name = resolve_name(data, ap.path)?;
address_by_path.insert(
name,
PathTarget {
id: ap.target,
container_idx: idx,
byte_offset: offset,
},
);
}
}
}
// Compiled `#@local` knot/stitch defaults — the base layer of policy
// resolution. Sorted by path so a knot expands before its stitches.
let mut local_scope_defaults: Vec<(String, DefinitionId)> = Vec::new();
for cdef in data.containers.iter().filter(|c| c.local) {
if let Some(n) = cdef.name {
local_scope_defaults.push((resolve_name(data, n)?, cdef.id));
}
}
local_scope_defaults.sort();
// M-2b (`docs/modules-spec.md` §4): the `#@private` definition set, used
// only to refuse host semantic access. Empty for the all-public world.
// Sorted so `Program::is_private` can binary-search (the compiler already
// emits it sorted; re-sort defensively for hand-built/legacy `StoryData`).
let mut private_defs: Vec<DefinitionId> = data.private_defs.clone();
private_defs.sort_by_key(|d| d.to_raw());
// M-3 (`docs/modules-spec.md` §5): the compiled alias table, sorted by
// `old` for `Program::resolve_alias`'s binary search. Sorted again here
// rather than trusted as-is — malformed/adversarial `.inkb` bytes are
// not guaranteed to preserve the compiler's ordering invariant.
let mut alias_table = data.alias_table.clone();
alias_table.sort_unstable();
let program = Program {
containers,
address_map,
scope_ids,
source_checksum: data.source_checksum,
globals,
global_map,
name_table,
address_by_path,
root_idx,
list_literals,
literal_pool,
list_item_map,
list_defs,
list_def_map,
external_fns,
local_scope_defaults,
struct_shapes,
private_defs,
alias_table,
};
Ok((program, line_tables))
}
#[cfg(test)]
mod tests {
use super::*;
/// Regression for a fuzzer-discovered panic (`vm_no_panic`, PR #672
/// workstream C): a `NameId` outside `StoryData::name_table`'s range —
/// reachable from arbitrary/malformed `.inkb` bytes, not just
/// well-formed compiler output — indexed the table directly and
/// panicked (`index out of bounds`). Linking such a program must fail
/// cleanly instead.
fn story_with_out_of_range_address_path_name() -> StoryData {
let mut data = brink_compiler::compile("main.ink", |_p| {
Ok("=== knot ===\nHello.\n-> END\n".to_owned())
})
.unwrap()
.data;
assert!(
!data.address_paths.is_empty(),
"compiler output should carry an address_paths table"
);
data.address_paths[0].path = NameId(u16::MAX);
data
}
#[test]
fn link_rejects_out_of_range_address_path_name_id() {
let data = story_with_out_of_range_address_path_name();
let result = link(&data);
assert!(
matches!(result, Err(RuntimeError::InvalidNameId(id)) if id == u16::MAX),
"out-of-range NameId must not link"
);
}
}