brainwires-agents 0.10.0

Agent orchestration, coordination, and lifecycle management for the Brainwires Agent Framework
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
//! SEAL (Self-Evolving Agentic Learning) Integration Module
//!
//! This module implements techniques from the SEAL paper to enhance
//! conversational question answering, semantic parsing, and self-evolving
//! agent capabilities in brainwires-cli.
//!
//! ## Components
//!
//! - **Coreference Resolution**: Resolves pronouns and elliptical references
//!   ("it", "the file", "that function") to concrete entities from dialog history.
//!
//! - **Query Core Extraction**: Extracts structured S-expression-like query cores
//!   from natural language for graph traversal and code understanding.
//!
//! - **Self-Evolving Learning**: Learns from successful interactions without
//!   retraining, building a library of effective patterns.
//!
//! - **Reflection Module**: Post-execution analysis and error correction
//!   to improve response quality.
//!
//! ## Architecture
//!
//! ```text
//! User Input
//!//!//! ┌─────────────────────────┐
//! │ Coreference Resolution  │──► Resolves "it", "the file", etc.
//! └────────────┬────────────┘
//!//!//! ┌─────────────────────────┐
//! │ Query Core Extraction   │──► Creates structured query
//! └────────────┬────────────┘
//!//!//! ┌─────────────────────────┐
//! │ Learning Coordinator    │──► Checks for learned patterns
//! └────────────┬────────────┘
//!//!//! ┌─────────────────────────┐
//! │   Query Execution       │──► Runs against RelationshipGraph
//! └────────────┬────────────┘
//!//!//! ┌─────────────────────────┐
//! │   Reflection Module     │──► Validates and corrects
//! └─────────────────────────┘
//! ```
//!
//! ## Usage
//!
//! ```rust,ignore
//! use brainwires_agents::seal::{SealProcessor, SealConfig};
//!
//! let config = SealConfig::default();
//! let mut processor = SealProcessor::new(config);
//!
//! // Process a user message with SEAL enhancements
//! let result = processor.process(
//!     "What uses it?",  // User's query with unresolved reference
//!     &dialog_state,
//!     &entity_store,
//!     Some(&relationship_graph),
//! )?;
//!
//! // result.resolved_query might be: "What uses [main.rs]?"
//! // result.query_core might be: QueryCore { op: DependsOn, ... }
//! ```

pub mod coreference;
#[cfg(feature = "seal-feedback")]
pub mod feedback_bridge;
#[cfg(feature = "seal-knowledge")]
pub mod knowledge_integration;
pub mod learning;
pub mod query_core;
pub mod reflection;

pub use coreference::{
    CoreferenceResolver, DialogState, ReferenceType, ResolvedReference, SalienceScore,
    UnresolvedReference,
};
#[cfg(feature = "seal-feedback")]
pub use feedback_bridge::{FeedbackBridge, FeedbackProcessingStats};
#[cfg(feature = "seal-knowledge")]
pub use knowledge_integration::{
    EntityResolutionStrategy, IntegrationConfig, SealKnowledgeCoordinator,
};
pub use learning::{
    GlobalMemory, LearningCoordinator, LocalMemory, PatternHint, QueryPattern, TrackedEntity,
};
pub use query_core::{
    FilterPredicate, QueryCore, QueryCoreExtractor, QueryExpr, QueryOp, QueryResult, QuestionType,
    RelationType, SuperlativeDir,
};
pub use reflection::{
    CorrectionRecord, ErrorType, Issue, ReflectionConfig, ReflectionModule, ReflectionReport,
    Severity, SuggestedFix,
};

use anyhow::Result;
use brainwires_core::graph::{EntityStoreT, RelationshipGraphT};

/// Configuration for the SEAL processor
#[derive(Debug, Clone)]
pub struct SealConfig {
    /// Enable coreference resolution
    pub enable_coreference: bool,
    /// Enable query core extraction
    pub enable_query_cores: bool,
    /// Enable self-evolving learning
    pub enable_learning: bool,
    /// Enable reflection module
    pub enable_reflection: bool,
    /// Maximum retry attempts for reflection correction
    pub max_reflection_retries: u32,
    /// Minimum confidence score for coreference resolution
    pub min_coreference_confidence: f32,
    /// Minimum pattern reliability for learning
    pub min_pattern_reliability: f32,
}

impl Default for SealConfig {
    fn default() -> Self {
        Self {
            enable_coreference: true,
            enable_query_cores: true,
            enable_learning: true,
            enable_reflection: true,
            max_reflection_retries: 2,
            min_coreference_confidence: 0.5,
            min_pattern_reliability: 0.7,
        }
    }
}

/// Result of SEAL processing pipeline
#[derive(Debug, Clone)]
pub struct SealProcessingResult {
    /// Original user query
    pub original_query: String,
    /// Query with resolved coreferences
    pub resolved_query: String,
    /// Extracted query core (if any)
    pub query_core: Option<QueryCore>,
    /// Matched learning pattern (if any)
    pub matched_pattern: Option<String>,
    /// Coreference resolutions made
    pub resolutions: Vec<ResolvedReference>,
    /// Quality score from reflection (0.0-1.0)
    pub quality_score: f32,
    /// Any issues detected by reflection
    pub issues: Vec<Issue>,
}

impl SealProcessingResult {
    /// Create a new SealProcessingResult with the given quality score and resolved query
    pub fn new(quality_score: f32, resolved_query: String) -> Self {
        Self {
            original_query: resolved_query.clone(),
            resolved_query,
            query_core: None,
            matched_pattern: None,
            resolutions: Vec::new(),
            quality_score,
            issues: Vec::new(),
        }
    }
}

/// Main SEAL processor that orchestrates all components
pub struct SealProcessor {
    config: SealConfig,
    coreference_resolver: CoreferenceResolver,
    query_extractor: QueryCoreExtractor,
    learning_coordinator: LearningCoordinator,
    reflection_module: ReflectionModule,
}

impl SealProcessor {
    /// Create a new SEAL processor with the given configuration
    pub fn new(config: SealConfig) -> Self {
        Self {
            coreference_resolver: CoreferenceResolver::new(),
            query_extractor: QueryCoreExtractor::new(),
            learning_coordinator: LearningCoordinator::new(String::new()),
            reflection_module: ReflectionModule::new(ReflectionConfig::default()),
            config,
        }
    }

    /// Create a new SEAL processor with default configuration
    pub fn with_defaults() -> Self {
        Self::new(SealConfig::default())
    }

    /// Initialize the learning coordinator with a conversation ID
    pub fn init_conversation(&mut self, conversation_id: &str) {
        self.learning_coordinator = LearningCoordinator::new(conversation_id.to_string());
    }

    /// Process a user query through the SEAL pipeline
    pub fn process(
        &mut self,
        query: &str,
        dialog_state: &DialogState,
        entity_store: &dyn EntityStoreT,
        graph: Option<&dyn RelationshipGraphT>,
    ) -> Result<SealProcessingResult> {
        let mut result = SealProcessingResult {
            original_query: query.to_string(),
            resolved_query: query.to_string(),
            query_core: None,
            matched_pattern: None,
            resolutions: Vec::new(),
            quality_score: 1.0,
            issues: Vec::new(),
        };

        // Step 1: Coreference Resolution
        if self.config.enable_coreference {
            let references = self.coreference_resolver.detect_references(query);
            if !references.is_empty() {
                let resolutions = self.coreference_resolver.resolve(
                    &references,
                    dialog_state,
                    entity_store,
                    graph,
                );

                // Filter by confidence threshold
                let confident_resolutions: Vec<_> = resolutions
                    .into_iter()
                    .filter(|r| r.confidence >= self.config.min_coreference_confidence)
                    .collect();

                if !confident_resolutions.is_empty() {
                    result.resolved_query = self
                        .coreference_resolver
                        .rewrite_with_resolutions(query, &confident_resolutions);
                    result.resolutions = confident_resolutions;
                }
            }
        }

        // Step 2: Query Core Extraction
        if self.config.enable_query_cores {
            // Get entities from entity store for extraction
            let entities: Vec<_> = entity_store.top_entity_info(50);

            result.query_core = self
                .query_extractor
                .extract(&result.resolved_query, &entities);

            // If coreference resolution changed the query, track both versions
            if let Some(ref mut core) = result.query_core
                && result.resolved_query != query
            {
                core.resolved = Some(result.resolved_query.clone());
            }
        }

        // Step 3: Check Learning Coordinator for patterns
        if self.config.enable_learning
            && let Some(pattern) = self.learning_coordinator.process_query(
                query,
                &result.resolved_query,
                result.query_core.clone(),
                dialog_state.current_turn,
            )
        {
            result.matched_pattern = Some(pattern.id.clone());
        }

        // Step 4: Reflection analysis (if we have a query core)
        if self.config.enable_reflection && result.query_core.is_some() {
            // Reflection will be applied after execution in a follow-up call
            // For now, just validate the query core structure
            if let Some(ref core) = result.query_core {
                result.issues = self.reflection_module.validate_query_core(core);
                result.quality_score = if result.issues.is_empty() {
                    1.0
                } else {
                    0.8 - (result.issues.len() as f32 * 0.1).min(0.5)
                };
            }
        }

        Ok(result)
    }

    /// Record the outcome of a query execution for learning
    pub fn record_outcome(
        &mut self,
        pattern_id: Option<&str>,
        success: bool,
        result_count: usize,
        query_core: Option<&QueryCore>,
        execution_time_ms: u64,
    ) {
        if self.config.enable_learning {
            self.learning_coordinator.record_outcome(
                pattern_id,
                success,
                result_count,
                query_core,
                execution_time_ms,
            );
        }
    }

    /// Analyze execution result with reflection module
    pub fn reflect(
        &mut self,
        query_core: &QueryCore,
        result: &QueryResult,
        graph: &dyn RelationshipGraphT,
    ) -> ReflectionReport {
        self.reflection_module.analyze(query_core, result, graph)
    }

    /// Get learning context for prompt injection
    pub fn get_learning_context(&self) -> String {
        self.learning_coordinator.get_context_for_prompt()
    }

    /// Get access to the coreference resolver
    pub fn coreference(&self) -> &CoreferenceResolver {
        &self.coreference_resolver
    }

    /// Get access to the query extractor
    pub fn query_extractor(&self) -> &QueryCoreExtractor {
        &self.query_extractor
    }

    /// Get mutable access to the learning coordinator
    pub fn learning_mut(&mut self) -> &mut LearningCoordinator {
        &mut self.learning_coordinator
    }

    /// Get access to the reflection module
    pub fn reflection(&self) -> &ReflectionModule {
        &self.reflection_module
    }

    /// Get the current configuration
    pub fn config(&self) -> &SealConfig {
        &self.config
    }

    /// Record MDAP execution metrics for learning
    ///
    /// This method records MDAP execution patterns to help improve
    /// future task decomposition and voting strategies.
    #[cfg(feature = "seal-mdap")]
    pub fn record_mdap_metrics(&mut self, metrics: &crate::mdap::MdapMetrics) {
        if !self.config.enable_learning {
            return;
        }

        // Record overall success/failure pattern
        self.learning_coordinator.record_outcome(
            None,
            metrics.final_success,
            metrics.completed_steps as usize,
            None,
            0, // MDAP metrics don't track individual query timing
        );

        // Could add more sophisticated learning here:
        // - Track which decomposition strategies work best
        // - Learn red-flag patterns that are too strict/relaxed
        // - Optimize k values based on historical data
        // For now, we just record the basic outcome
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_seal_processor_creation() {
        let processor = SealProcessor::with_defaults();
        assert!(processor.config.enable_coreference);
        assert!(processor.config.enable_query_cores);
        assert!(processor.config.enable_learning);
        assert!(processor.config.enable_reflection);
    }

    #[test]
    fn test_seal_config_default() {
        let config = SealConfig::default();
        assert!(config.enable_coreference);
        assert_eq!(config.max_reflection_retries, 2);
        assert!(config.min_coreference_confidence > 0.0);
    }

    #[test]
    fn test_init_conversation() {
        let mut processor = SealProcessor::with_defaults();
        processor.init_conversation("test-conv-123");
        // Verify the conversation ID is set
        assert_eq!(
            processor.learning_coordinator.local.conversation_id,
            "test-conv-123"
        );
    }
}