use std::collections::HashMap;
use std::path::Path;
use serde::{Deserialize, Serialize};
pub const ASKED: &str = "asked";
pub const CORRECTED: &str = "asked_then_corrected";
pub const NOT_CORRECTED: &str = "asked_not_corrected";
pub const CHANGED: &str = "asked_then_changed";
pub const IGNORED: &str = "asked_ignored";
pub const GRADED: &str = "graded";
pub const MISSED: &str = "applied_then_corrected";
pub const VETOED: &str = "vetoed";
pub const REGRETTED: &str = "regretted";
pub const TESTED: &str = "tested";
pub const UNCLEAR: &str = "asked_unclear";
pub const DELIVERY: &str = "delivery";
pub const ENDED: &str = "ended";
pub const PLACEBO: &str = "placebo";
#[must_use]
pub fn is_result(o: &Outcome) -> bool {
o.channel != PLACEBO && o.kind != UNCLEAR
}
pub const UNJUDGED_NONE: &str = "judged";
pub const UNJUDGED_TRIES: &str = "tries";
pub const UNJUDGED_SLOTS: &str = "slots";
pub const UNJUDGED_FAILED: &str = "failed";
pub const UNJUDGED_NO_CALL: &str = "no_call";
pub const UNJUDGED_LATER: &str = "later";
pub const DECIDED_BUSY: &str = "lock_busy";
pub const DECIDED_NO_LOCK: &str = "lock_failed";
pub const DECIDED_NO_RECORD: &str = "unrecorded";
pub const CORRECTED_W: u32 = 2;
pub const IDLE_MS: i64 = crate::clock::DAY_MS;
#[derive(Debug, Clone, Default, PartialEq, Serialize, Deserialize)]
pub struct Outcome {
pub kind: String,
pub session: String,
pub lessons: Vec<String>,
pub ms: i64,
pub repo: String,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub groups: Vec<Vec<String>>,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub channel: String,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub grades: Vec<u8>,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub ranks: Vec<u16>,
#[serde(default, skip_serializing_if = "is_zero")]
pub applied: u16,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub chosen: Vec<String>,
#[serde(default, skip_serializing_if = "std::ops::Not::not")]
pub explore: bool,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub cause: String,
#[serde(default, skip_serializing_if = "is_zero_f")]
pub credit: f64,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub p: Vec<f64>,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub pool: Vec<String>,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub base: Vec<f64>,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub scoped: Vec<bool>,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub check: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub policy: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub fit: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub seen: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub source: String,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub free: Vec<String>,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub pf: Vec<f64>,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub placebo: Vec<String>,
#[serde(default, skip_serializing_if = "is_default")]
pub psi: f64,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub nofree: Vec<String>,
#[serde(default, skip_serializing_if = "Option::is_none")]
pub xk: Option<u32>,
#[serde(default, skip_serializing_if = "Option::is_none")]
pub xs: Option<u32>,
#[serde(default, skip_serializing_if = "Option::is_none")]
pub alpha: Option<f64>,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub tail: Vec<String>,
#[serde(default, skip_serializing_if = "is_default")]
pub pt: f64,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub rel: Vec<f64>,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub route: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub reason: String,
#[serde(default, skip_serializing_if = "is_default")]
pub eligible: u32,
#[serde(default, skip_serializing_if = "is_default")]
pub shown: u32,
#[serde(default, skip_serializing_if = "is_default")]
pub tokens: u32,
#[serde(default, skip_serializing_if = "is_default")]
pub budget: u32,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub fill: Vec<u16>,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub model: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub prompt_hash: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub harness: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub version: String,
#[serde(default, skip_serializing_if = "is_default")]
pub dur_ms: u64,
#[serde(default, skip_serializing_if = "std::ops::Not::not")]
pub failed: bool,
#[serde(default, skip_serializing_if = "is_default")]
pub usd: f64,
#[serde(default, skip_serializing_if = "is_default")]
pub judge: u8,
#[serde(default, skip_serializing_if = "std::ops::Not::not")]
pub stripped: bool,
}
pub const ROUTE_ASKED: &str = "asked";
pub const ROUTE_FREE: &str = "free";
pub const ROUTE_PLACEBO: &str = "placebo";
pub const ROUTE_DROPPED_DONE: &str = "dropped_done";
pub const ROUTE_DROPPED_CHARS: &str = "dropped_chars";
pub const ROUTE_NEVER: &str = "never_delivered";
pub const ROUTES: [&str; 6] = [ROUTE_ASKED, ROUTE_FREE, ROUTE_PLACEBO, ROUTE_DROPPED_DONE, ROUTE_DROPPED_CHARS, ROUTE_NEVER];
#[must_use]
pub fn policy_of(o: &Outcome) -> &str {
match o.policy.as_str() {
"" if o.explore || o.p.iter().any(|p| *p > 0.0 && *p < 1.0) => "attention",
"" => "fixed",
p => p,
}
}
#[must_use]
pub fn free_of(o: &Outcome) -> Vec<String> {
use crate::conscience::{self, Challenge};
if !o.policy.is_empty() || o.grades.len() != o.lessons.len() {
return o.free.clone();
}
if o.grades.contains(&3) {
return match policy_of(o) {
"attention" => o.lessons.iter().filter(|l| !o.chosen.contains(l)).take(conscience::CAP).cloned().collect(),
_ => Vec::new(),
};
}
let ls: Vec<Challenge> = o.lessons.iter().map(|id| Challenge { id: id.clone(), ..Default::default() }).collect();
let applied: Vec<(&Challenge, u8)> = ls.iter().zip(o.grades.iter().copied()).collect();
conscience::graded_capped(&applied, None).1.into_iter().map(|c| c.id.clone()).collect()
}
fn is_default<T: Default + PartialEq>(v: &T) -> bool {
*v == T::default()
}
pub fn round_p(p: f64) -> f64 {
(p * 1e4).round() / 1e4
}
fn is_zero(v: &u16) -> bool {
*v == 0
}
fn is_zero_f(v: &f64) -> bool {
*v == 0.0
}
pub fn path_beside(lessons: &Path) -> std::path::PathBuf {
lessons.with_file_name("outcomes.jsonl")
}
pub const TEAM_FILE: &str = "outcomes-team.jsonl";
pub const PUBLISHED: &str = "outcomes-team.published";
pub const SHARED_KINDS: [&str; 9] = [ASKED, CHANGED, IGNORED, CORRECTED, NOT_CORRECTED, MISSED, VETOED, REGRETTED, TESTED];
pub fn tag(s: &str) -> String {
let mut h = blake3::Hasher::new();
h.update(b"borg-outcome-v1\0");
h.update(s.as_bytes());
h.finalize().to_hex()[..32].to_string()
}
fn tag_repo(repo: &str) -> String {
if repo.is_empty() { String::new() } else { tag(repo) }
}
#[derive(Debug, Clone, Default, PartialEq, Serialize, Deserialize)]
pub struct Shared {
pub kind: String,
pub s: String,
pub lessons: Vec<String>,
pub ms: i64,
pub node: String,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub p: Vec<f64>,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub channel: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub r: String,
#[serde(default, skip_serializing_if = "String::is_empty")]
pub c: String,
#[serde(default, skip_serializing_if = "is_zero_f")]
pub credit: f64,
}
pub fn share(o: &Outcome, node: &str) -> Option<Shared> {
(SHARED_KINDS.contains(&o.kind.as_str()) && is_result(o)).then(|| Shared {
kind: o.kind.clone(),
s: tag(&o.session),
lessons: o.lessons.clone(),
ms: o.ms,
node: node.into(),
p: o.p.clone(),
channel: o.channel.clone(),
r: tag_repo(&o.repo),
c: tag_repo(&o.cause),
credit: o.credit,
})
}
pub fn on() -> bool {
std::env::var("BORG_SHARE_OUTCOMES").as_deref() != Ok("off")
}
pub fn publish(home: &Path) -> usize {
let local = home.join("outcomes.jsonl");
let team = home.join(TEAM_FILE);
let mark = home.join(PUBLISHED);
let len = std::fs::metadata(&local).map_or(0, |m| m.len());
if !on() || len == 0 {
return 0;
}
let published = std::fs::read_to_string(&mark).ok().and_then(|t| t.trim().parse::<u64>().ok());
if team.exists() && published == Some(len) {
return 0;
}
let mine = std::fs::read_to_string(&local).unwrap_or_default();
let node = crate::stats::node(home);
let text = std::fs::read_to_string(&team).unwrap_or_default();
let mut have: std::collections::HashSet<String> = text.lines().map(str::to_string).collect();
let mut out = String::new();
let personal = crate::reach::personal_ids(home);
let records = mine.lines().filter_map(|l| serde_json::from_str::<Outcome>(l).ok()).filter_map(|mut o| {
let named = !o.lessons.is_empty();
o.lessons.retain(|id| !personal.contains(id));
(!named || !o.lessons.is_empty()).then_some(o)
});
for line in records.filter_map(|o| share(&o, &node)).filter_map(|x| serde_json::to_string(&x).ok()) {
if have.insert(line.clone()) {
out.push_str(&line);
out.push('\n');
}
}
if out.is_empty() {
let _ = std::fs::write(&mark, mine.len().to_string());
return 0;
}
use std::io::Write;
let open = text.as_bytes().last().is_some_and(|c| *c != b'\n');
let written = std::fs::OpenOptions::new()
.create(true)
.append(true)
.open(&team)
.and_then(|mut f| f.write_all(format!("{}{out}", if open { "\n" } else { "" }).as_bytes()));
if written.is_err() {
return 0;
}
let _ = std::fs::write(&mark, mine.len().to_string());
out.lines().count()
}
pub fn read_team(lessons: &Path) -> Vec<Outcome> {
team_view(lessons, on())
}
pub fn team_view(lessons: &Path, on: bool) -> Vec<Outcome> {
let (mut out, team) = team_parts(lessons, on);
if on {
for o in &mut out {
o.repo = tag_repo(&o.repo);
o.cause = tag_repo(&o.cause);
}
}
out.extend(team);
out
}
pub fn team_parts(lessons: &Path, on: bool) -> (Vec<Outcome>, Vec<Outcome>) {
let local = read(&path_beside(lessons));
if !on {
return (local, Vec::new());
}
let mine: std::collections::HashSet<String> = local.iter().map(|o| tag(&o.session)).collect();
let text = std::fs::read_to_string(lessons.with_file_name(TEAM_FILE)).unwrap_or_default();
let lines: Vec<Shared> = text.lines().filter_map(|l| serde_json::from_str::<Shared>(l).ok()).collect();
let mut given: std::collections::HashMap<&str, std::collections::HashSet<&str>> = std::collections::HashMap::new();
for x in lines.iter().filter(|x| SHARED_KINDS.contains(&x.kind.as_str()) && x.kind != TESTED) {
given.entry(x.s.as_str()).or_default().extend(x.lessons.iter().map(String::as_str));
}
let mut seen: std::collections::HashSet<(String, String, Vec<String>, i64, String)> = std::collections::HashSet::new();
let mut team = Vec::new();
for x in lines.iter() {
if !SHARED_KINDS.contains(&x.kind.as_str()) || mine.contains(&x.s) || !seen.insert((x.kind.clone(), x.s.clone(), x.lessons.clone(), x.ms, x.c.clone()))
{
continue;
}
if x.kind == TESTED && !x.lessons.iter().all(|l| given.get(x.s.as_str()).is_some_and(|g| g.contains(l.as_str()))) {
continue;
}
team.push(Outcome {
kind: x.kind.clone(),
session: x.s.clone(),
lessons: x.lessons.clone(),
ms: x.ms,
repo: x.r.clone(),
p: x.p.clone(),
channel: x.channel.clone(),
cause: x.c.clone(),
credit: x.credit,
..Default::default()
});
}
(local, team)
}
pub fn read(path: &Path) -> Vec<Outcome> {
std::fs::read_to_string(path).unwrap_or_default().lines().filter_map(|l| serde_json::from_str(l).ok()).collect()
}
pub fn append(path: &Path, o: &Outcome) -> std::io::Result<()> {
crate::learn::append_jsonl(path, o)?;
if let Some(home) = path.parent() {
count_result(home, o);
}
Ok(())
}
pub fn count_result(home: &Path, o: &Outcome) {
if !is_result(o) {
return;
}
let kind = match o.kind.as_str() {
CHANGED => crate::stats::CHANGED,
IGNORED => crate::stats::IGNORED,
CORRECTED => crate::stats::CORRECTED,
NOT_CORRECTED => crate::stats::NOT_CORRECTED,
REGRETTED => crate::stats::REGRETTED,
TESTED => crate::stats::TESTED,
_ => return,
};
crate::stats::count(home, kind, &o.session, |e| {
e.repo = o.repo.clone();
e.lessons = o.lessons.clone();
e.channel = o.channel.clone();
});
}
pub fn asked_before(outcomes: &[Outcome], session: &str, lesson: &str, ms: i64) -> bool {
outcomes.iter().any(|o| o.kind == ASKED && o.session == session && o.ms < ms && o.lessons.iter().any(|l| l == lesson))
}
pub fn has(outcomes: &[Outcome], kind: &str, session: &str, lesson: &str) -> bool {
outcomes.iter().any(|o| o.kind == kind && o.session == session && o.lessons.iter().any(|l| l == lesson))
}
pub fn contradicted(outcomes: &[Outcome], session: &str, ms: i64, target: Option<&str>, supersedes: &[String]) -> Vec<String> {
let mut out: Vec<String> = supersedes.to_vec();
if let Some(t) = target {
let sides: Vec<String> = outcomes
.iter()
.filter(|o| o.kind == ASKED && o.session == session && o.ms < ms)
.flat_map(|o| &o.groups)
.filter(|g| g.iter().any(|x| x == t))
.flatten()
.filter(|x| *x != t)
.cloned()
.collect();
match sides.is_empty() {
true => out.push(t.to_string()),
false => out.extend(sides),
}
}
out.retain(|l| asked_before(outcomes, session, l, ms) && !has(outcomes, CORRECTED, session, l) && !has(outcomes, VETOED, session, l));
out.sort();
out.dedup();
out
}
pub fn free(o: &Outcome) -> bool {
o.channel == "early" || o.channel == "queued"
}
pub fn missed(outcomes: &[Outcome], session: &str, ms: i64, target: Option<&str>, supersedes: &[String]) -> Vec<String> {
let mut out: Vec<String> = supersedes.iter().cloned().chain(target.map(str::to_string)).collect();
let applied_unchosen = |l: &str| {
outcomes.iter().any(|o| o.kind == GRADED && o.session == session && o.ms < ms && o.lessons.iter().any(|x| x == l) && !o.chosen.iter().any(|x| x == l))
};
let questioned = |l: &str| outcomes.iter().any(|o| o.kind == ASKED && !free(o) && o.session == session && o.ms < ms && o.lessons.iter().any(|x| x == l));
out.retain(|l| applied_unchosen(l) && !questioned(l) && !has(outcomes, MISSED, session, l));
out.sort();
out.dedup();
out
}
fn credited(outcomes: &[Outcome], cause: &str, lesson: &str) -> bool {
outcomes.iter().any(|o| o.kind == REGRETTED && o.cause == cause && o.lessons.iter().any(|l| l == lesson))
}
#[allow(clippy::too_many_arguments)]
pub fn regretted(outcomes: &[Outcome], session: &str, before_ms: i64, cause: &str, target: &[String], strength: f64, ms: i64, repo: &str) -> Vec<Outcome> {
if session.is_empty() || before_ms <= 0 || strength <= 0.0 {
return Vec::new();
}
let mut asked: Vec<&str> =
outcomes.iter().filter(|o| o.kind == ASKED && o.session == session && o.ms < before_ms).flat_map(|o| o.lessons.iter().map(String::as_str)).collect();
asked.sort_unstable();
asked.dedup();
if asked.iter().any(|l| target.iter().any(|t| t == l)) {
asked.retain(|l| target.iter().any(|t| t == l));
}
asked.retain(|l| !has(outcomes, CORRECTED, session, l) && !has(outcomes, VETOED, session, l));
let credit = (strength / asked.len().max(1) as f64).min(1.0);
asked
.into_iter()
.filter(|l| !credited(outcomes, cause, l))
.map(|l| Outcome {
kind: REGRETTED.into(),
session: session.into(),
lessons: vec![l.into()],
ms,
repo: repo.into(),
cause: cause.into(),
credit,
..Default::default()
})
.collect()
}
pub fn tested(outcomes: &[Outcome], session: &str, tests: &str) -> Vec<Outcome> {
let mut runs: Vec<(i64, bool)> = tests
.lines()
.filter_map(|l| l.split_once(' '))
.filter_map(|(w, m)| Some((m.trim().parse::<i64>().ok()?, matches!(w, "pass" | "fail").then_some(w == "pass")?)))
.collect();
runs.sort_unstable();
let mut first: HashMap<&str, (i64, &str)> = HashMap::new();
for o in outcomes.iter().filter(|o| o.kind == ASKED && !free(o) && o.session == session) {
for l in &o.lessons {
let e = first.entry(l.as_str()).or_insert((o.ms, o.repo.as_str()));
if o.ms < e.0 {
*e = (o.ms, o.repo.as_str());
}
}
}
let mut out: Vec<Outcome> = first
.into_iter()
.filter(|(l, _)| ![TESTED, CORRECTED, VETOED, IGNORED].iter().any(|k| has(outcomes, k, session, l)))
.filter_map(|(l, (at, repo))| {
let after = &runs[runs.partition_point(|r| r.0 <= at)..];
let &(ms, pass) = after.last()?;
(pass && (after.iter().any(|r| !r.1) || has(outcomes, CHANGED, session, l))).then(|| Outcome {
kind: TESTED.into(),
session: session.into(),
lessons: vec![l.into()],
ms,
repo: repo.into(),
..Default::default()
})
})
.collect();
out.sort_by(|a, b| a.lessons.cmp(&b.lessons));
out
}
pub fn settle(outcomes: &[Outcome], session: &str, ms: i64) -> Vec<Outcome> {
settle_with(outcomes, session, ms, &|_| UNJUDGED_NO_CALL)
}
pub fn settle_with(outcomes: &[Outcome], session: &str, ms: i64, unjudged: &dyn Fn(&str) -> &'static str) -> Vec<Outcome> {
let mine: Vec<&Outcome> = outcomes.iter().filter(|o| o.session == session).collect();
let resolved: std::collections::HashSet<&str> = mine.iter().filter(|o| resolves(o)).flat_map(|o| o.lessons.iter().map(String::as_str)).collect();
let mut verdicts: HashMap<&str, Vec<(i64, &str, bool)>> = HashMap::new();
for o in mine.iter().filter(|o| (o.kind == CHANGED || o.kind == IGNORED) && is_result(o)) {
for l in &o.lessons {
verdicts.entry(l.as_str()).or_default().push((o.ms, o.check.as_str(), free(o)));
}
}
let mut asked: std::collections::BTreeMap<&str, (&str, i64, &str, bool)> = std::collections::BTreeMap::new();
let mut latest: HashMap<&str, i64> = HashMap::new();
for o in mine.iter().filter(|o| o.kind == ASKED || is_placebo(o)) {
for l in o.lessons.iter().map(String::as_str) {
let t = latest.entry(l).or_insert(o.ms);
*t = (*t).max(o.ms);
if o.kind != ASKED || resolved.contains(l) {
continue;
}
let e = asked.entry(l).or_insert((o.repo.as_str(), o.ms, o.check.as_str(), free(o)));
e.0 = e.0.min(o.repo.as_str());
if o.ms >= e.1 {
(e.1, e.2, e.3) = (o.ms, o.check.as_str(), free(o));
}
}
}
let judged = |l: &str, at: i64, check: &str, as_free: bool| {
verdicts.get(l).is_some_and(|v| v.iter().any(|&(t, c, f)| f == as_free && (t > at || (!check.is_empty() && c == check))))
};
let mut out: Vec<Outcome> = asked
.into_iter()
.map(|(l, (repo, at, check, as_free))| Outcome {
kind: NOT_CORRECTED.into(),
session: session.into(),
lessons: vec![l.into()],
ms,
repo: repo.into(),
check: check.into(),
reason: if judged(l, at, check, as_free) { UNJUDGED_NONE } else { unjudged(l) }.into(),
version: env!("CARGO_PKG_VERSION").into(),
..Default::default()
})
.collect();
let mut placebos: Vec<Outcome> = open_placebos(&mine)
.into_iter()
.map(|(l, d)| Outcome {
kind: NOT_CORRECTED.into(),
session: session.into(),
lessons: vec![l.into()],
ms,
repo: d.repo.clone(),
channel: PLACEBO.into(),
check: d.check.clone(),
reason: if latest.get(l).is_some_and(|&t| t > d.ms) { UNJUDGED_LATER } else { unjudged(l) }.into(),
..Default::default()
})
.collect();
placebos.sort_by(|a, b| (&a.lessons, &a.check).cmp(&(&b.lessons, &b.check)));
out.extend(placebos);
out
}
fn resolves(o: &Outcome) -> bool {
matches!(o.kind.as_str(), CORRECTED | NOT_CORRECTED | VETOED) && o.channel != PLACEBO
}
fn is_placebo(o: &Outcome) -> bool {
o.kind == DELIVERY && o.route == ROUTE_PLACEBO
}
fn closes(r: &Outcome, d: &Outcome) -> bool {
match r.kind.as_str() {
NOT_CORRECTED => r.check == d.check,
CHANGED | IGNORED if r.check.is_empty() || d.check.is_empty() => r.ms > d.ms,
CHANGED | IGNORED => r.check == d.check,
_ => false,
}
}
fn open_placebos<'a>(mine: &[&'a Outcome]) -> Vec<(&'a str, &'a Outcome)> {
let mut closers: HashMap<&str, Vec<&Outcome>> = HashMap::new();
for &o in mine.iter().filter(|o| o.channel == PLACEBO && !is_placebo(o)) {
for l in &o.lessons {
closers.entry(l.as_str()).or_default().push(o);
}
}
mine.iter()
.copied()
.filter(|o| is_placebo(o))
.flat_map(|d| d.lessons.iter().map(move |l| (l.as_str(), d)))
.filter(|&(l, d)| !closers.get(l).is_some_and(|rs| rs.iter().any(|r| closes(r, d))))
.collect()
}
pub fn idle_sessions<'a>(outcomes: &'a [Outcome], last_episode: &HashMap<String, i64>, now: i64) -> Vec<&'a str> {
let mut newest: HashMap<&str, i64> = HashMap::new();
let (mut asked, mut resolved) = (std::collections::HashSet::new(), std::collections::HashSet::new());
let mut placebos: HashMap<&str, Vec<&Outcome>> = HashMap::new();
for o in outcomes {
if o.channel == PLACEBO || is_placebo(o) {
placebos.entry(o.session.as_str()).or_default().push(o);
}
if o.kind == ASKED || is_placebo(o) {
let m = newest.entry(o.session.as_str()).or_insert(o.ms);
*m = (*m).max(o.ms);
}
let into = match o.kind.as_str() {
ASKED => &mut asked,
_ if resolves(o) => &mut resolved,
_ => continue,
};
into.extend(o.lessons.iter().map(|l| (o.session.as_str(), l.as_str())));
}
let mut open: std::collections::HashSet<&str> = asked.difference(&resolved).map(|(s, _)| *s).collect();
open.extend(placebos.iter().filter(|(_, rs)| !open_placebos(rs).is_empty()).map(|(s, _)| *s));
let mut idle: Vec<&str> = newest
.into_iter()
.filter(|&(s, ms)| open.contains(s) && ms.max(last_episode.get(s).copied().unwrap_or(i64::MIN)) <= now - IDLE_MS)
.map(|(s, _)| s)
.collect();
idle.sort();
idle
}
pub fn weight(not_corrected: u32, corrected: u32) -> f64 {
let (n, c) = (not_corrected as f64, corrected as f64);
(1.0 + n) / (1.0 + n + f64::from(CORRECTED_W) * c)
}
pub fn weights(outcomes: &[Outcome]) -> HashMap<String, f64> {
counts(outcomes).into_iter().map(|(l, (n, c))| (l, weight(n, c))).collect()
}
pub fn counts(outcomes: &[Outcome]) -> HashMap<String, (u32, u32)> {
sessions(outcomes).into_iter().map(|(l, ss)| (l.to_string(), tally(ss.values(), i64::MIN))).collect()
}
pub fn sessions(outcomes: &[Outcome]) -> HashMap<&str, HashMap<&str, (bool, i64)>> {
let mut out: HashMap<&str, HashMap<&str, (bool, i64)>> = HashMap::new();
for o in outcomes.iter().filter(|o| is_result(o)) {
let corrected = match o.kind.as_str() {
CORRECTED | VETOED => true,
NOT_CORRECTED => false,
_ => continue,
};
for l in &o.lessons {
let r = out.entry(l.as_str()).or_default().entry(o.session.as_str()).or_insert((corrected, o.ms));
r.0 |= corrected;
r.1 = r.1.min(o.ms);
}
}
out
}
pub fn tally<'a>(sessions: impl IntoIterator<Item = &'a (bool, i64)>, since: i64) -> (u32, u32) {
sessions.into_iter().filter(|(_, ms)| *ms > since).fold((0, 0), |(n, c), (corrected, _)| match corrected {
true => (n, c + 1),
false => (n + 1, c),
})
}
#[cfg(test)]
mod tests {
use super::*;
fn o(kind: &str, session: &str, lessons: &[&str], ms: i64) -> Outcome {
Outcome {
kind: kind.into(),
session: session.into(),
lessons: lessons.iter().map(|l| l.to_string()).collect(),
ms,
repo: "r".into(),
..Default::default()
}
}
#[test]
fn missed_is_an_applied_unasked_lesson_a_later_correction_lands_on() {
let graded = |ms: i64, chosen: &[&str]| Outcome {
kind: GRADED.into(),
session: "s".into(),
lessons: vec!["A".into(), "B".into()],
ms,
chosen: chosen.iter().map(|x| x.to_string()).collect(),
..Default::default()
};
let none: Vec<String> = Vec::new();
let log = vec![graded(10, &["B"])];
assert_eq!(missed(&log, "s", 20, Some("A"), &none), ["A"]);
assert_eq!(missed(&log, "s", 20, None, &["A".into(), "B".into()]), ["A"], "B was chosen");
assert!(missed(&log, "s", 5, Some("A"), &none).is_empty(), "a correction before the check");
assert!(missed(&log, "t", 20, Some("A"), &none).is_empty(), "another session");
assert!(missed(&log, "s", 20, Some("C"), &none).is_empty(), "never applied");
let mut asked = log.clone();
asked.push(o(ASKED, "s", &["A"], 15));
assert!(missed(&asked, "s", 20, Some("A"), &none).is_empty(), "asked later in the session: not a miss");
let mut free = log.clone();
free.push(Outcome { channel: "queued".into(), ..o(ASKED, "s", &["A"], 15) });
free.push(Outcome { channel: "early".into(), ..o(ASKED, "s", &["A"], 16) });
assert_eq!(missed(&free, "s", 20, Some("A"), &none), ["A"], "handed over free, never asked: still a miss");
let mut done = log.clone();
done.push(o(MISSED, "s", &["A"], 18));
assert!(missed(&done, "s", 20, Some("A"), &none).is_empty(), "recorded once");
}
#[test]
fn weight_formula() {
assert_eq!(weight(0, 0), 1.0);
assert_eq!(weight(5, 0), 1.0);
assert!((weight(0, 1) - 1.0 / 3.0).abs() < 1e-12);
assert_eq!(weight(1, 1), 0.5);
assert!(weight(0, 3) < weight(0, 1));
}
#[test]
fn weights_count_each_session_once_and_corrected_wins() {
let all = vec![
o(ASKED, "s1", &["A", "B"], 10),
o(CORRECTED, "s1", &["A"], 20),
o(CORRECTED, "s1", &["A"], 30), o(NOT_CORRECTED, "s1", &["A"], 40), o(NOT_CORRECTED, "s1", &["B"], 40),
o(NOT_CORRECTED, "s2", &["A"], 50),
];
let w = weights(&all);
assert_eq!(w["A"], weight(1, 1));
assert_eq!(w["B"], 1.0);
assert!(!w.contains_key("C"));
}
#[test]
fn a_session_whose_tests_go_green_after_an_ask_credits_it_once() {
let mut log = vec![o(ASKED, "s", &["A", "B"], 10), o(ASKED, "t", &["A"], 10)];
let got = tested(&log, "s", "fail 20\npass 30\n");
assert_eq!(got.iter().map(|x| (x.kind.as_str(), x.lessons[0].as_str(), x.ms)).collect::<Vec<_>>(), [(TESTED, "A", 30), (TESTED, "B", 30)]);
log.extend(got);
assert!(tested(&log, "s", "fail 20\npass 30\n").is_empty());
assert!(tested(&log, "t", "").is_empty(), "no tests file: nothing");
}
#[test]
fn a_green_run_credits_only_after_the_ask_and_with_a_reason() {
let log = vec![o(ASKED, "s", &["A"], 50)];
assert!(tested(&log, "s", "fail 20\npass 30\n").is_empty(), "red and green before the ask");
assert!(tested(&log, "s", "fail 20\npass 60\n").is_empty(), "the failure before the ask: green proves nothing new");
assert!(tested(&log, "s", "fail 60\npass 70\nfail 80\n").is_empty(), "last run red");
assert!(tested(&log, "s", "pass 60\n").is_empty(), "green alone, nothing changed");
assert!(tested(&log, "s", "pass 60\npass 70 \ngarbage\n").is_empty());
let early = [Outcome { channel: "early".into(), ..o(ASKED, "e", &["A"], 10) }];
assert!(tested(&early, "e", "fail 20\npass 30\n").is_empty(), "a free delivery asked nothing");
let changed = [log.clone(), vec![o(CHANGED, "s", &["A"], 55)]].concat();
assert_eq!(tested(&changed, "s", "pass 60\n").len(), 1);
for k in [CORRECTED, VETOED, IGNORED] {
let worse = [log.clone(), vec![o(k, "s", &["A"], 55)]].concat();
assert!(tested(&worse, "s", "fail 60\npass 70\n").is_empty(), "{k}");
}
let twice = [log.clone(), vec![o(ASKED, "s", &["A"], 65)]].concat();
assert_eq!(tested(&twice, "s", "pass 70\nfail 60\n")[0].ms, 70);
}
#[test]
fn settle_marks_only_unresolved_asks_of_this_session() {
let all = vec![o(ASKED, "s1", &["B", "A"], 10), o(ASKED, "s1", &["A", "C"], 15), o(CORRECTED, "s1", &["A"], 20), o(ASKED, "s2", &["D"], 10)];
let settled = settle(&all, "s1", 99);
assert_eq!(settled, vec![unjudged("s1", "B", UNJUDGED_NO_CALL), unjudged("s1", "C", UNJUDGED_NO_CALL)]);
assert!(asked_before(&all, "s1", "A", 11) && !asked_before(&all, "s1", "C", 15) && !asked_before(&all, "s2", "A", 99));
}
fn unjudged(session: &str, lesson: &str, reason: &str) -> Outcome {
Outcome { reason: reason.into(), version: env!("CARGO_PKG_VERSION").into(), ..o(NOT_CORRECTED, session, &[lesson], 99) }
}
#[test]
fn a_settled_lesson_says_why_it_had_no_verdict_and_names_its_latest_check() {
let ask = |lessons: &[&str], ms: i64, check: &str| Outcome { check: check.into(), ..o(ASKED, "s", lessons, ms) };
let placebo = Outcome { channel: PLACEBO.into(), ..o(CHANGED, "s", &["C"], 30) };
let all = vec![ask(&["A", "B", "C"], 10, "c1"), ask(&["B"], 20, "c2"), o(IGNORED, "s", &["A"], 25), placebo];
let why = |l: &str| if l == "B" { UNJUDGED_TRIES } else { UNJUDGED_SLOTS };
let got = settle_with(&all, "s", 99, &why);
let want = |l: &str, reason: &str, check: &str| Outcome { check: check.into(), ..unjudged("s", l, reason) };
assert_eq!(got, vec![want("A", UNJUDGED_NONE, "c1"), want("B", UNJUDGED_TRIES, "c2"), want("C", UNJUDGED_SLOTS, "c1")], "a placebo's verdict is none");
}
#[test]
fn a_verdict_on_an_earlier_delivery_leaves_the_later_question_unjudged() {
let ask = |channel: &str, ms: i64, check: &str| Outcome { channel: channel.into(), check: check.into(), ..o(ASKED, "s", &["L"], ms) };
let verdict = |channel: &str, ms: i64, check: &str| Outcome { channel: channel.into(), check: check.into(), ..o(IGNORED, "s", &["L"], ms) };
let why = |log: &[Outcome]| settle_with(log, "s", 99, &|_| UNJUDGED_NO_CALL).into_iter().map(|x| (x.reason, x.check)).collect::<Vec<_>>();
let said = |reason: &str, check: &str| vec![(reason.to_string(), check.to_string())];
let free_then_asked = vec![ask("queued", 10, "cF"), verdict("queued", 20, "cF"), ask("stop", 20, "cS")];
assert_eq!(why(&free_then_asked), said(UNJUDGED_NO_CALL, "cS"));
let answered = [free_then_asked, vec![verdict("stop", 30, "cS")]].concat();
assert_eq!(why(&answered), said(UNJUDGED_NONE, "cS"));
assert_eq!(why(&[ask("stop", 20, "cS"), verdict("stop", 30, "cL")]), said(UNJUDGED_NONE, "cS"));
assert_eq!(why(&[ask("stop", 20, "cS"), verdict("stop", 15, "cS")]), said(UNJUDGED_NONE, "cS"));
}
#[test]
fn a_free_deliverys_verdict_after_a_later_question_leaves_the_question_unjudged() {
let ask = |channel: &str, ms: i64, check: &str| Outcome { channel: channel.into(), check: check.into(), ..o(ASKED, "s", &["L"], ms) };
let verdict = |channel: &str, ms: i64, check: &str| Outcome { channel: channel.into(), check: check.into(), ..o(CHANGED, "s", &["L"], ms) };
let why = |log: &[Outcome]| settle_with(log, "s", 99, &|_| UNJUDGED_TRIES).into_iter().map(|x| (x.reason, x.check)).collect::<Vec<_>>();
let said = |reason: &str, check: &str| vec![(reason.to_string(), check.to_string())];
let stuck = vec![ask("queued", 10, "cA"), ask("live", 20, "cB"), verdict("queued", 30, "cA")];
assert_eq!(why(&stuck), said(UNJUDGED_TRIES, "cB"));
let early = vec![ask("early", 10, "cA"), ask("stop", 20, "cB"), verdict("early", 30, "cA")];
assert_eq!(why(&early), said(UNJUDGED_TRIES, "cB"));
assert_eq!(why(&[stuck.clone(), vec![verdict("live", 40, "cB")]].concat()), said(UNJUDGED_NONE, "cB"), "the question's own verdict");
assert_eq!(why(&[ask("queued", 10, "cA"), verdict("queued", 30, "cA")]), said(UNJUDGED_NONE, "cA"), "a free delivery's own");
use crate::select::{
Route,
summary::{Label, Summary, fold},
};
let graded = |check: &str, ms: i64, channel: &str| Outcome {
grades: vec![3],
ranks: vec![0],
applied: 1,
channel: channel.into(),
check: check.into(),
..o(GRADED, "s", &["L"], ms)
};
let mut log = vec![Outcome { free: vec!["L".into()], ..graded("cA", 5, "live") }, Outcome { chosen: vec!["L".into()], ..graded("cB", 15, "live") }];
log.extend(stuck);
log.extend(settle_with(&log, "s", 99, &|_| UNJUDGED_TRIES));
let text: String = log.iter().map(|x| format!("{}\n", serde_json::to_string(x).unwrap())).collect();
let s = fold(&text, Summary::default());
let label = |route: Route| s.applies.iter().find(|a| a.route == route).map(|a| a.label);
assert_eq!(label(Route::Ask), Some(Label::Censored), "{:?}", s.applies);
}
#[test]
fn a_settle_leaves_no_delivery_of_its_lesson_open() {
use crate::select::{
Route,
summary::{Label, Summary, fold},
};
let graded = |check: &str, ms: i64, ask: bool| Outcome {
grades: vec![2],
ranks: vec![0],
applied: 1,
channel: "live".into(),
check: check.into(),
chosen: if ask { vec!["L".into()] } else { Vec::new() },
free: if ask { Vec::new() } else { vec!["L".into()] },
..o(GRADED, "s", &["L"], ms)
};
let asked = |channel: &str, ms: i64, check: &str| Outcome { channel: channel.into(), check: check.into(), ..o(ASKED, "s", &["L"], ms) };
let verdict = |channel: &str, check: &str| Outcome { channel: channel.into(), check: check.into(), ..o(CHANGED, "s", &["L"], 40) };
for (first_ask, channels) in [(false, ["queued", "live"]), (true, ["live", "queued"])] {
let mut log = vec![graded("cA", 5, first_ask), asked(channels[0], 10, "cA"), graded("cB", 15, !first_ask), asked(channels[1], 20, "cB")];
log.push(verdict(channels[1], "cB"));
let settled = settle_with(&log, "s", 99, &|_| UNJUDGED_TRIES);
assert_eq!(settled.iter().map(|x| (x.reason.as_str(), x.check.as_str())).collect::<Vec<_>>(), [(UNJUDGED_NONE, "cB")]);
log.extend(settled);
let text: String = log.iter().map(|x| format!("{}\n", serde_json::to_string(x).unwrap())).collect();
let s = fold(&text, Summary::default());
let label = |route: Route| s.applies.iter().find(|a| a.route == route).map(|a| a.label);
let (a, b) = if first_ask { (Route::Ask, Route::Free) } else { (Route::Free, Route::Ask) };
assert_eq!((label(a), label(b)), (Some(Label::Censored), Some(Label::Changed)), "first asked {first_ask}: {:?}", s.applies);
}
let mut log = vec![graded("cA", 5, false), asked("queued", 10, "cA"), graded("cB", 15, true), asked("live", 20, "cB"), verdict("queued", "cA")];
log.push(Outcome { reason: UNJUDGED_NONE.into(), check: "cB".into(), ..o(NOT_CORRECTED, "s", &["L"], 99) });
let text: String = log.iter().map(|x| format!("{}\n", serde_json::to_string(x).unwrap())).collect();
let s = fold(&text, Summary::default());
let labels: Vec<(Route, Label)> = s.applies.iter().map(|a| (a.route, a.label)).collect();
assert_eq!(labels, [(Route::Free, Label::Changed), (Route::Ask, Label::Open)]);
}
fn placebo(lessons: &[&str], check: &str, ms: i64) -> Outcome {
Outcome { channel: PLACEBO.into(), check: check.into(), route: ROUTE_PLACEBO.into(), ..o(DELIVERY, "s", lessons, ms) }
}
#[test]
fn an_unjudged_placebo_settles_on_its_own_channel() {
let on = |kind: &str, lesson: &str, check: &str, ms: i64| Outcome { channel: PLACEBO.into(), check: check.into(), ..o(kind, "s", &[lesson], ms) };
let log = vec![
placebo(&["A", "B"], "p1", 10),
on(IGNORED, "A", "p1", 15),
on(UNCLEAR, "B", "p1", 15),
placebo(&["C"], "p2", 20),
Outcome { channel: "queued".into(), check: "c3".into(), ..o(ASKED, "s", &["C"], 30) },
Outcome { route: ROUTE_DROPPED_DONE.into(), ..placebo(&["D"], "p4", 40) },
];
let why = |l: &str| if l == "B" { UNJUDGED_TRIES } else { UNJUDGED_NO_CALL };
let got = settle_with(&log, "s", 99, &why);
let closed =
|l: &str, check: &str, reason: &str| Outcome { channel: PLACEBO.into(), check: check.into(), version: String::new(), ..unjudged("s", l, reason) };
let asked = Outcome { check: "c3".into(), ..unjudged("s", "C", UNJUDGED_NO_CALL) };
let want = vec![asked, closed("B", "p1", UNJUDGED_TRIES), closed("C", "p2", UNJUDGED_LATER)];
assert_eq!(got, want, "A has its verdict; D never reached the judge's queue");
assert!(got[1..].iter().all(|x| !is_result(x) && share(x, "n1").is_none()), "no result, never shared");
let mut resumed = [log, got].concat();
assert!(settle_with(&resumed, "s", 120, &why).is_empty());
resumed.extend([Outcome { channel: "stop".into(), check: "c5".into(), ..o(ASKED, "s", &["B"], 110) }, placebo(&["E"], "p6", 111)]);
let again: Vec<(String, String, String)> =
settle_with(&resumed, "s", 120, &why).into_iter().map(|x| (x.lessons.join(","), x.channel, x.check)).collect();
assert_eq!(again, [("B".to_string(), String::new(), "c5".to_string()), ("E".to_string(), PLACEBO.to_string(), "p6".to_string())]);
}
#[test]
fn idle_sessions_wait_for_open_placebos() {
let only = vec![placebo(&["A"], "p1", 0)];
assert_eq!(idle_sessions(&only, &HashMap::new(), IDLE_MS + 10), ["s"]);
assert!(idle_sessions(&only, &HashMap::new(), IDLE_MS - 10).is_empty(), "the placebo is the session's newest activity");
let settled = [only.clone(), settle(&only, "s", 5)].concat();
assert!(idle_sessions(&settled, &HashMap::new(), IDLE_MS + 10).is_empty());
}
#[test]
fn the_selection_summary_censors_a_settled_placebo() {
use crate::select::summary::{Label, Summary, fold};
let graded = Outcome {
grades: vec![1, 1],
ranks: vec![0, 1],
applied: 2,
channel: "stop".into(),
check: "p1".into(),
policy: "learned".into(),
placebo: vec!["A".into(), "B".into()],
..o(GRADED, "s", &["A", "B"], 5)
};
let mut log = vec![graded, placebo(&["A", "B"], "p1", 10), Outcome { channel: PLACEBO.into(), check: "p1".into(), ..o(IGNORED, "s", &["A"], 15) }];
log.extend(settle(&log, "s", 99));
let text: String = log.iter().map(|x| format!("{}\n", serde_json::to_string(x).unwrap())).collect();
let s = fold(&text, Summary::default());
let label = |l: &str| s.applies.iter().find(|a| s.lessons[a.lesson as usize] == l).map(|a| a.label);
assert_eq!((label("A"), label("B")), (Some(Label::Ignored), Some(Label::Censored)));
}
#[test]
fn contradicted_marks_superseded_asks_and_the_other_sides_of_a_disagreement() {
let mut ask = o(ASKED, "s1", &["A", "B", "C", "D"], 10);
ask.groups = vec![vec!["A".into(), "B".into()]];
let all = vec![ask, o(ASKED, "s1", &["E"], 30), o(CORRECTED, "s1", &["D"], 15)];
let ids = |v: &[&str]| v.iter().map(|x| x.to_string()).collect::<Vec<_>>();
assert_eq!(contradicted(&all, "s1", 20, Some("C"), &[]), ["C"]);
assert_eq!(contradicted(&all, "s1", 20, Some("A"), &[]), ["B"]);
assert_eq!(contradicted(&all, "s1", 20, None, &ids(&["C", "E", "D", "Z"])), ["C"]);
assert!(contradicted(&all, "s2", 20, Some("C"), &ids(&["A"])).is_empty(), "another session asked nothing");
let mut vetoed = all.clone();
vetoed.push(o(VETOED, "s1", &["C"], 12));
assert!(contradicted(&vetoed, "s1", 20, Some("C"), &[]).is_empty(), "a vetoed lesson already has the stronger result");
}
#[test]
fn a_placebo_or_unclear_result_is_no_result_for_any_reader() {
let placebo = |kind: &str| Outcome { channel: PLACEBO.into(), ..o(kind, "s", &["A"], 5) };
let unclear = Outcome { channel: "stop".into(), ..o(UNCLEAR, "s", &["A"], 5) };
for x in [placebo(CHANGED), placebo(IGNORED), placebo(UNCLEAR), unclear.clone()] {
assert!(!is_result(&x), "{x:?}");
assert!(share(&x, "n1").is_none(), "never shared: {x:?}");
}
assert!(is_result(&Outcome { channel: "queued".into(), ..o(CHANGED, "s", &["A"], 5) }));
assert!(!SHARED_KINDS.contains(&UNCLEAR) && !SHARED_KINDS.contains(&DELIVERY));
let all = [placebo(CORRECTED), placebo(NOT_CORRECTED), o(NOT_CORRECTED, "t", &["A"], 6)];
assert_eq!(tally(sessions(&all)["A"].values(), i64::MIN), (1, 0));
let d = tmp("placebo-stats");
append(&d.join("outcomes.jsonl"), &placebo(CHANGED)).unwrap();
append(&d.join("outcomes.jsonl"), &unclear).unwrap();
append(&d.join("outcomes.jsonl"), &Outcome { channel: "stop".into(), ..o(CHANGED, "s", &["B"], 7) }).unwrap();
let kinds: Vec<String> = crate::stats::events(&d).into_iter().map(|e| e.kind).collect();
assert_eq!(kinds, [crate::stats::CHANGED], "{kinds:?}");
let _ = std::fs::remove_dir_all(d);
}
#[test]
fn a_vetoed_lesson_is_not_settled_and_counts_as_corrected() {
let all = vec![o(ASKED, "s1", &["A", "B"], 10), o(VETOED, "s1", &["A"], 20)];
assert_eq!(settle(&all, "s1", 99), vec![unjudged("s1", "B", UNJUDGED_NO_CALL)]);
assert_eq!(sessions(&all)["A"]["s1"], (true, 20));
assert_eq!(weights(&all)["A"], weight(0, 1));
}
#[test]
fn sessions_keep_the_earliest_result_and_tally_filters_by_it() {
let all =
vec![o(NOT_CORRECTED, "s1", &["A"], 10), o(CORRECTED, "s2", &["A"], 20), o(NOT_CORRECTED, "s2", &["A"], 25), o(NOT_CORRECTED, "s3", &["A"], 30)];
let s = sessions(&all);
assert_eq!(s["A"]["s2"], (true, 20));
assert_eq!(tally(s["A"].values(), i64::MIN), (2, 1));
assert_eq!(tally(s["A"].values(), 20), (1, 0));
}
#[test]
fn idle_sessions_need_old_asks_and_old_episodes() {
let all = vec![o(ASKED, "old", &["A"], 0), o(ASKED, "busy", &["A"], 0), o(ASKED, "fresh", &["A"], 50), o(CORRECTED, "x", &["A"], 0)];
let episodes = HashMap::from([("busy".to_string(), 60)]);
assert_eq!(idle_sessions(&all, &episodes, IDLE_MS + 10), ["old"]);
assert_eq!(idle_sessions(&all, &episodes, IDLE_MS + 60), ["busy", "fresh", "old"]);
}
#[test]
fn idle_sessions_skip_settled_ones() {
let all = vec![
o(ASKED, "done", &["A", "B"], 0),
o(NOT_CORRECTED, "done", &["A"], 1),
o(CORRECTED, "done", &["B"], 1),
o(ASKED, "vetoed", &["A"], 0),
o(VETOED, "vetoed", &["A"], 1),
o(ASKED, "half", &["A", "B"], 0),
o(NOT_CORRECTED, "half", &["A"], 1),
];
assert_eq!(idle_sessions(&all, &HashMap::new(), IDLE_MS + 10), ["half"], "every ask of the others has its result");
}
#[test]
fn regretted_blames_asks_before_the_decision_shared_or_by_target() {
let mut graded = o(GRADED, "s", &["G"], 5);
graded.chosen = vec![];
let log = vec![graded, o(ASKED, "s", &["B", "A"], 10), o(ASKED, "s", &["C"], 30), o(ASKED, "t", &["D"], 10)];
let ids = |v: &[&str]| v.iter().map(|x| x.to_string()).collect::<Vec<_>>();
let blame = |log: &[Outcome], target: &[String]| regretted(log, "s", 20, "R1", target, 0.5, 99, "r");
let got = blame(&log, &[]);
let want = |l: &str, credit: f64| Outcome { cause: "R1".into(), credit, ..o(REGRETTED, "s", &[l], 99) };
assert_eq!(got, vec![want("A", 0.25), want("B", 0.25)], "shared; C was asked after the decision, G never shown");
assert_eq!(blame(&log, &ids(&["B", "Z"])), vec![want("B", 0.5)], "the merge target takes it all");
assert_eq!(blame(&log, &ids(&["Z"])), got, "a target not asked: shared");
let mut corrected = log.clone();
corrected.push(o(CORRECTED, "s", &["B"], 15));
assert_eq!(blame(&corrected, &[]), vec![want("A", 0.5)], "corrected outranks regretted");
let mut vetoed = log.clone();
vetoed.push(o(VETOED, "s", &["B"], 15));
assert_eq!(blame(&vetoed, &[]), vec![want("A", 0.5)], "vetoed outranks regretted");
assert!(blame(&corrected, &ids(&["B"])).is_empty(), "the target took it as a correction: nobody else is blamed");
assert!(blame(&vetoed, &ids(&["B", "Z"])).is_empty(), "the target took it as a veto: nobody else is blamed");
assert_eq!(blame(&corrected, &ids(&["A", "B"])), vec![want("A", 0.5)], "the uncorrected target keeps its share");
let mut again = log.clone();
again.extend(got.clone());
assert!(blame(&again, &[]).is_empty(), "credited once per cause");
let mut half = log.clone();
half.push(got[0].clone());
assert_eq!(blame(&half, &[]), vec![want("B", 0.25)], "a partial run completes with the same share");
assert_eq!(regretted(&again, "s", 20, "R2", &[], 0.5, 99, "r").len(), 2, "another regret blames again");
assert!(regretted(&log, "u", 20, "R1", &[], 0.5, 99, "r").is_empty(), "another session asked nothing");
assert!(regretted(&log, "", 20, "R1", &[], 0.5, 99, "r").is_empty());
assert!(regretted(&log, "s", 0, "R1", &[], 0.5, 99, "r").is_empty(), "no decision time");
assert!(regretted(&log, "s", 20, "R1", &[], 0.0, 99, "r").is_empty(), "not strong");
let old: Outcome = serde_json::from_str(r#"{"kind":"asked","session":"s","lessons":["A"],"ms":1,"repo":"r"}"#).unwrap();
assert_eq!(old, o(ASKED, "s", &["A"], 1));
assert!(!serde_json::to_string(&old).unwrap().contains("credit"));
let line = serde_json::to_string(&got[0]).unwrap();
assert!(line.contains(r#""cause":"R1","credit":0.25"#), "{line}");
assert_eq!(serde_json::from_str::<Outcome>(&line).unwrap(), got[0]);
}
#[test]
fn a_line_from_before_propensities_reads_and_writes_back_unchanged() {
let line = r#"{"kind":"asked","session":"s","lessons":["A","B"],"ms":1,"repo":"r","channel":"stop","grades":[3,1],"ranks":[0,1],"applied":2}"#;
let o: Outcome = serde_json::from_str(line).unwrap();
assert!(o.p.is_empty());
assert_eq!(serde_json::to_string(&o).unwrap(), line);
let with = Outcome { p: vec![round_p(1.0), round_p(1.0 / 3.0)], ..o };
assert!(serde_json::to_string(&with).unwrap().ends_with(r#""applied":2,"p":[1.0,0.3333]}"#));
}
#[test]
fn a_graded_line_from_before_select_reads_and_writes_back_unchanged() {
let line = r#"{"kind":"graded","session":"s","lessons":["A","B"],"ms":1,"repo":"r","channel":"live","grades":[3,1],"ranks":[0,1],"applied":2,"chosen":["A","B"],"explore":true,"p":[1.0,0.1]}"#;
let o: Outcome = serde_json::from_str(line).unwrap();
assert!(o.check.is_empty() && o.policy.is_empty() && o.free.is_empty() && o.pf.is_empty() && o.judge == 0 && !o.failed);
assert!(o.nofree.is_empty() && o.tail.is_empty() && o.pt == 0.0 && o.rel.is_empty());
assert_eq!(serde_json::to_string(&o).unwrap(), line);
for line in [
r#"{"kind":"graded","session":"s","lessons":["A","B","C"],"ms":1,"repo":"r","channel":"stop","grades":[2,1,1],"ranks":[0,1,2],"applied":3,"p":[0.0,0.0,0.0],"check":"0123456789ab","policy":"learned","fit":"120-ab12","seen":"9-abcdef01","source":"fixed","free":["A","B"],"pf":[1.0,1.0,0.0],"placebo":["C"],"psi":1.0,"eligible":40,"shown":30,"tokens":12000,"fill":[0,4,7],"model":"m","version":"0.6.0","dur_ms":9000,"usd":0.01}"#,
r#"{"kind":"asked","session":"s","lessons":["A","B"],"ms":2,"repo":"r","channel":"early","p":[1.0,0.5],"route":"asked"}"#,
] {
let o: Outcome = serde_json::from_str(line).unwrap();
assert!(o.nofree.is_empty() && o.tail.is_empty() && o.pt == 0.0 && o.rel.is_empty(), "{line}");
assert_eq!((o.xk, o.xs), (None, None), "{line}");
assert_eq!(serde_json::to_string(&o).unwrap(), line);
}
}
#[test]
fn the_selection_fields_round_trip_and_stay_local() {
let g = Outcome {
check: "0123456789ab".into(),
policy: "learned".into(),
fit: "120-ab12".into(),
free: vec!["B".into()],
pf: vec![0.0, 1.0, 0.0],
placebo: vec!["C".into()],
psi: 0.5,
nofree: vec!["N9".into()],
xk: Some(2),
xs: Some(0),
tail: vec!["T9".into()],
pt: 0.125,
eligible: 40,
shown: 30,
tokens: 12_000,
fill: vec![0, 4, 7],
model: "m".into(),
prompt_hash: "ph".into(),
harness: "claude".into(),
version: "0.6.0".into(),
dur_ms: 9_000,
failed: true,
..o(GRADED, "s", &["A", "B", "C"], 5)
};
let delivered = Outcome { check: "0123456789ab".into(), route: ROUTE_DROPPED_CHARS.into(), reason: "budget".into(), ..o(ASKED, "s", &["B"], 6) };
let judged = Outcome { check: "0123456789ab".into(), judge: 2, stripped: true, ..o(CHANGED, "s", &["A"], 7) };
let early = Outcome { channel: "early".into(), rel: vec![0.75], ..o(ASKED, "s", &["D"], 8) };
let carried = Outcome { nofree: g.nofree.clone(), xk: g.xk, xs: g.xs, tail: g.tail.clone(), pt: g.pt, rel: vec![0.75], ..judged.clone() };
for x in [&g, &delivered, &judged, &early, &carried] {
let line = serde_json::to_string(x).unwrap();
assert_eq!(&serde_json::from_str::<Outcome>(&line).unwrap(), x, "round trip");
}
assert!(serde_json::to_string(&g).unwrap().contains(r#""xk":2,"xs":0"#));
assert!(share(&g, "n1").is_none(), "graded stays local");
for x in [&delivered, &judged, &early, &carried] {
let shared = serde_json::to_string(&share(x, "n1").unwrap()).unwrap();
for field in
["check", "0123456789ab", "route", "reason", "judge", "stripped", "nofree", "N9", "xk", "xs", "tail", "T9", "pt", "0.125", "rel", "0.75"]
{
assert!(!shared.contains(field), "{field}: {shared}");
}
}
assert!(ROUTES.iter().all(|r| !r.is_empty() && !r.contains(' ')), "one word each");
}
#[test]
fn an_older_graded_record_is_the_fixed_rule_unless_it_shows_the_cut() {
let graded = |grades: &[u8], chosen: &[&str], p: &[f64]| Outcome {
lessons: (0..grades.len()).map(|i| format!("L{i:02}")).collect(),
grades: grades.to_vec(),
chosen: chosen.iter().map(|c| c.to_string()).collect(),
p: p.to_vec(),
..o(GRADED, "s", &[], 1)
};
let soft: Vec<u8> = [vec![1; 6], vec![2; 6]].concat();
let old = graded(&soft, &[], &[0.0; 12]);
assert_eq!(policy_of(&old), "fixed");
let want: Vec<String> = (6..12).chain(0..4).map(|i| format!("L{i:02}")).collect();
assert_eq!(free_of(&old), want);
let block = graded(&[3, 1], &["L00", "L01"], &[1.0, 1.0]);
assert_eq!((policy_of(&block), free_of(&block)), ("fixed", Vec::<String>::new()));
let cut = graded(&[3, 1, 1, 1], &["L00", "L01"], &[1.0, 1.0, 0.1, 0.1]);
assert_eq!((policy_of(&cut), free_of(&cut)), ("attention", vec!["L02".to_string(), "L03".into()]));
let explored = Outcome { explore: true, ..graded(&[3, 1, 1], &["L00", "L01", "L02"], &[1.0, 1.0, 1.0]) };
assert_eq!((policy_of(&explored), free_of(&explored)), ("attention", Vec::<String>::new()));
let named = Outcome { policy: "learned".into(), free: vec!["L01".into()], ..graded(&[3, 1], &["L00"], &[1.0, 0.0]) };
assert_eq!((policy_of(&named), free_of(&named)), ("learned", vec!["L01".to_string()]));
}
fn tmp(name: &str) -> std::path::PathBuf {
let d = std::env::temp_dir().join(format!("borg-outcome-{name}-{}", std::process::id()));
let _ = std::fs::remove_dir_all(&d);
std::fs::create_dir_all(&d).unwrap();
d
}
fn lines(path: &Path, v: &[String]) {
std::fs::write(path, v.iter().map(|l| format!("{l}\n")).collect::<String>()).unwrap();
}
fn changed(team: &[Outcome], lesson: &str) -> u32 {
let ls = [crate::conscience::Challenge { id: lesson.into(), ..Default::default() }];
crate::memory::derive(team, &ls, None)[lesson].changed
}
#[test]
fn share_redacts() {
let mut a = o(ASKED, "session-raw", &["A"], 5);
a.repo = "secret-repo".into();
a.groups = vec![vec!["A".into(), "B".into()]];
a.grades = vec![3];
a.ranks = vec![0];
a.p = vec![0.5];
let x = share(&a, "n1").unwrap();
let line = serde_json::to_string(&x).unwrap();
for raw in ["session-raw", "secret-repo", "groups", "grades", "ranks", "\"id\"", "version"] {
assert!(!line.contains(raw), "{raw} in {line}");
}
assert_eq!((x.s, x.r, x.p, x.node), (tag("session-raw"), tag("secret-repo"), vec![0.5], "n1".to_string()));
assert_eq!(tag("s").len(), 32);
for kind in [GRADED, "veto"] {
assert!(share(&o(kind, "s", &["A"], 1), "n1").is_none(), "{kind} is not shared");
}
let regret = share(&Outcome { cause: "episode-raw".into(), credit: 0.25, ..o(REGRETTED, "s", &["A"], 1) }, "n1").unwrap();
let line = serde_json::to_string(®ret).unwrap();
assert!(!line.contains("episode-raw") && line.contains(&tag("episode-raw")) && line.contains(r#""credit":0.25"#), "{line}");
}
#[test]
fn pool_fields_stay_local() {
let a = Outcome { pool: vec!["A".into(), "B".into()], base: vec![1.25, 0.5], scoped: vec![true, false], p: vec![0.5], ..o(ASKED, "s", &["A"], 5) };
let line = serde_json::to_string(&a).unwrap();
assert_eq!(serde_json::from_str::<Outcome>(&line).unwrap(), a, "round trip");
let shared = serde_json::to_string(&share(&a, "n1").unwrap()).unwrap();
for field in ["pool", "base", "scoped"] {
assert!(line.contains(field) && !shared.contains(field), "{field}: {shared}");
}
assert!(!serde_json::to_string(&o(ASKED, "s", &["A"], 5)).unwrap().contains("pool"), "empty: not written");
}
#[test]
fn publish_is_idempotent() {
let home = tmp("publish");
assert_eq!(publish(&home), 0, "no outcomes, nothing to publish");
let mut asked = o(ASKED, "s1", &["A"], 1);
asked.p = vec![1.0];
lines(&home.join("outcomes.jsonl"), &[asked, o(GRADED, "s1", &["A"], 1), o(CHANGED, "s1", &["A"], 2)].map(|x| serde_json::to_string(&x).unwrap()));
assert_eq!(publish(&home), 2, "graded stays local");
let first = std::fs::read_to_string(home.join(TEAM_FILE)).unwrap();
assert_eq!(publish(&home), 0);
assert_eq!(std::fs::read_to_string(home.join(TEAM_FILE)).unwrap(), first);
assert!(first.contains(r#""p":[1.0]"#) && !first.contains("\"s1\""), "{first}");
assert_eq!(std::fs::read_to_string(home.join(PUBLISHED)).unwrap(), std::fs::metadata(home.join("outcomes.jsonl")).unwrap().len().to_string());
std::fs::OpenOptions::new()
.append(true)
.open(home.join("outcomes.jsonl"))
.and_then(|mut f| std::io::Write::write_all(&mut f, format!("{}\n", serde_json::to_string(&o(IGNORED, "s2", &["A"], 3)).unwrap()).as_bytes()))
.unwrap();
assert_eq!(publish(&home), 1);
assert_eq!(publish(&home), 0);
std::fs::remove_file(home.join(TEAM_FILE)).unwrap();
assert_eq!(publish(&home), 3);
let _ = std::fs::remove_dir_all(home);
}
fn team_store(name: &str, shuffle: bool) -> std::path::PathBuf {
let home = tmp(name);
let mut local = o(CHANGED, "s1", &["L1"], 10);
local.repo = "app".into();
lines(&home.join("outcomes.jsonl"), &[serde_json::to_string(&local).unwrap()]);
let remote = |kind: &str, s: &str, node: &str| {
serde_json::to_string(&Shared {
kind: kind.into(),
s: s.into(),
lessons: vec!["L1".into()],
ms: 20,
node: node.into(),
r: tag("web"),
..Default::default()
})
.unwrap()
};
let mut team = vec![
serde_json::to_string(&share(&local, "me").unwrap()).unwrap(),
remote(CHANGED, "x", "n2"),
remote(CHANGED, "x", "n3"),
remote("hacked", "y", "n2"),
remote("veto", "z", "n2"),
];
if shuffle {
team.reverse();
team.swap(0, 2);
}
lines(&home.join(TEAM_FILE), &team);
home
}
#[test]
fn read_team_drops_own_copies_and_keeps_remote() {
let home = team_store("team", false);
let team = team_view(&home.join("lessons.jsonl"), true);
assert_eq!(changed(&team, "L1"), 2, "{team:?}");
assert_eq!(team.iter().filter(|o| o.session == "x").count(), 1, "one remote line per (kind, session, lessons, ms)");
assert!(team.iter().all(|o| o.kind != "hacked" && o.kind != "veto"), "unshared kinds, an older peer's hive verdict among them, are ignored");
assert!(team.iter().all(|o| o.repo != "app"), "local repos compare as tags");
let _ = std::fs::remove_dir_all(home);
}
#[test]
fn read_team_is_order_independent() {
let (a, b) = (team_store("order-a", false), team_store("order-b", true));
let ls = [crate::conscience::Challenge { id: "L1".into(), ..Default::default() }];
let m = |h: &Path| crate::memory::derive(&team_view(&h.join("lessons.jsonl"), true), &ls, None);
assert_eq!(m(&a), m(&b));
let _ = std::fs::remove_dir_all(a);
let _ = std::fs::remove_dir_all(b);
}
#[test]
fn a_peer_derives_the_same_memory_from_the_team_file() {
let (a, b) = (tmp("fold-a"), tmp("fold-b"));
let regret = Outcome { cause: "episode-1".into(), credit: 0.5, ..o(REGRETTED, "s2", &["L1"], 40) };
let log = [
o(GRADED, "s0", &["L1"], 5),
o(ASKED, "s1", &["L1"], 10),
o(CHANGED, "s1", &["L1"], 20),
o(VETOED, "s1", &["L1"], 30),
o(ASKED, "s2", &["L1"], 35),
regret,
];
lines(&a.join("outcomes.jsonl"), &log.map(|x| serde_json::to_string(&x).unwrap()));
publish(&a);
std::fs::copy(a.join(TEAM_FILE), b.join(TEAM_FILE)).unwrap();
let ls = [crate::conscience::Challenge { id: "L1".into(), origin_ms: 1, ..Default::default() }];
let m = |h: &Path| crate::memory::derive(&team_view(&h.join("lessons.jsonl"), true), &ls, None);
let (here, there) = (m(&a), m(&b));
assert_eq!((here["L1"].vetoed, here["L1"].changed, here["L1"].regretted), (1, 0, 0.5), "{here:?}");
assert_eq!(here, there);
let _ = std::fs::remove_dir_all(a);
let _ = std::fs::remove_dir_all(b);
}
#[test]
fn a_remote_line_under_a_local_tag_counts_on_peers_only() {
let (victim, peer) = (tmp("forged-victim"), tmp("forged-peer"));
let own = o(CHANGED, "s1", &["L1"], 10);
let forged = Shared { kind: CORRECTED.into(), s: tag("s1"), lessons: vec!["L1".into()], ms: 11, node: "n2".into(), ..Default::default() };
let team = [serde_json::to_string(&share(&own, "me").unwrap()).unwrap(), serde_json::to_string(&forged).unwrap()];
lines(&victim.join("outcomes.jsonl"), &[serde_json::to_string(&own).unwrap()]);
lines(&victim.join(TEAM_FILE), &team);
lines(&peer.join(TEAM_FILE), &team);
let ls = [crate::conscience::Challenge { id: "L1".into(), ..Default::default() }];
let m = |h: &Path| crate::memory::derive(&team_view(&h.join("lessons.jsonl"), true), &ls, None).remove("L1").unwrap();
assert_eq!((m(&victim).changed, m(&victim).corrected), (1, 0), "the victim never sees the override");
assert_eq!((m(&peer).changed, m(&peer).corrected), (0, 1), "a peer counts the forged correction");
let _ = std::fs::remove_dir_all(victim);
let _ = std::fs::remove_dir_all(peer);
}
#[test]
fn a_peer_green_run_counts_only_for_lessons_its_session_was_given() {
let home = tmp("tested-team");
let asked = share(&o(ASKED, "p1", &["L1"], 10), "peer").unwrap();
let ok = share(&o(TESTED, "p1", &["L1"], 20), "peer").unwrap();
let stray = share(&o(TESTED, "p1", &["L2"], 20), "peer").unwrap();
let alone = share(&o(TESTED, "p2", &["L1"], 20), "peer").unwrap();
let verdict = Shared { kind: "verified".into(), ..share(&o(ASKED, "p3", &["L1"], 10), "peer").unwrap() };
let unbacked = share(&o(TESTED, "p3", &["L1"], 20), "peer").unwrap();
let all = [&asked, &ok, &stray, &alone, &verdict, &unbacked];
lines(&home.join(TEAM_FILE), &all.map(|x| serde_json::to_string(x).unwrap()));
let ls = ["L1", "L2"].map(|id| crate::conscience::Challenge { id: id.into(), ..Default::default() });
let m = crate::memory::derive(&team_view(&home.join("lessons.jsonl"), true), &ls, None);
assert_eq!((m["L1"].tested, m["L2"].tested), (1, 0), "{m:?}");
let _ = std::fs::remove_dir_all(home);
}
#[test]
fn off_keeps_beliefs_local() {
let home = team_store("off", false);
let local = team_view(&home.join("lessons.jsonl"), false);
assert_eq!(local, read(&home.join("outcomes.jsonl")));
assert_eq!(changed(&local, "L1"), 1);
let _ = std::fs::remove_dir_all(home);
}
#[test]
fn concurrent_appends_keep_every_record() {
let home = tmp("concurrent");
let p = home.join("outcomes.jsonl");
let (writers, each) = (8, 2000);
std::thread::scope(|scope| {
for w in 0..writers {
let p = &p;
scope.spawn(move || (0..each).for_each(|i| append(p, &o(ASKED, &format!("s{w}"), &["A"], i)).unwrap()));
}
});
assert_eq!(read(&p).len(), writers * each as usize);
let _ = std::fs::remove_dir_all(home);
}
#[test]
fn append_and_read_round_trip() {
let dir = std::env::temp_dir().join(format!("borg-outcome-{}", std::process::id()));
let p = dir.join("outcomes.jsonl");
let _ = std::fs::remove_file(&p);
append(&p, &o(ASKED, "s", &["A"], 1)).unwrap();
append(&p, &o(CORRECTED, "s", &["A"], 2)).unwrap();
assert_eq!(read(&p), vec![o(ASKED, "s", &["A"], 1), o(CORRECTED, "s", &["A"], 2)]);
let _ = std::fs::remove_dir_all(dir);
}
}