blvm-protocol 0.1.4

Bitcoin Commons BLVM: Bitcoin protocol abstraction layer for multiple variants and evolution
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
//! Error Handling Tests
//!
//! Tests for handling malformed messages, protocol mismatches,
//! invalid data, and error recovery scenarios.

use blvm_consensus::{BlockHeader, Hash};
use blvm_protocol::network::{
    process_network_message, AddrMessage, GetDataMessage, GetHeadersMessage, HeadersMessage,
    InvMessage, NetworkAddress, NetworkMessage, NetworkResponse, PeerState, RejectMessage,
    VersionMessage,
};
use blvm_protocol::{BitcoinProtocolEngine, ProtocolVersion};

fn create_test_engine() -> BitcoinProtocolEngine {
    BitcoinProtocolEngine::new(ProtocolVersion::BitcoinV1).unwrap()
}

fn create_test_peer_state() -> PeerState {
    PeerState::new()
}

// ============================================================================
// Phase 1: Malformed Version Message Tests
// ============================================================================

#[test]
fn test_version_message_too_old() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let version = VersionMessage {
        version: 60000, // Too old (minimum is 70001)
        services: 1,
        timestamp: 1234567890,
        addr_recv: NetworkAddress {
            services: 1,
            ip: [0u8; 16],
            port: 8333,
        },
        addr_from: NetworkAddress {
            services: 1,
            ip: [0u8; 16],
            port: 8333,
        },
        nonce: 12345,
        user_agent: "test/1.0".to_string(),
        start_height: 0,
        relay: true,
    };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Version(version),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    match response {
        NetworkResponse::Reject(reason) => {
            assert!(reason.contains("version") || reason.contains("old"));
        }
        _ => panic!("Expected Reject for old version"),
    }
}

#[test]
fn test_version_message_invalid_user_agent_length() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let long_user_agent = "a".repeat(10000); // Exceeds protocol limit

    let version = VersionMessage {
        version: 70015,
        services: 1,
        timestamp: 1234567890,
        addr_recv: NetworkAddress {
            services: 1,
            ip: [0u8; 16],
            port: 8333,
        },
        addr_from: NetworkAddress {
            services: 1,
            ip: [0u8; 16],
            port: 8333,
        },
        nonce: 12345,
        user_agent: long_user_agent,
        start_height: 0,
        relay: true,
    };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Version(version),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    match response {
        NetworkResponse::Reject(reason) => {
            assert!(
                reason.contains("user_agent")
                    || reason.contains("too long")
                    || reason.contains("256")
            );
        }
        _ => panic!("Expected Reject for invalid user agent length"),
    }
}

// ============================================================================
// Phase 2: Malformed Address Message Tests
// ============================================================================

#[test]
fn test_addr_message_too_many_addresses() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let addresses: Vec<NetworkAddress> = (0..1001)
        .map(|i| NetworkAddress {
            services: 1,
            ip: [i as u8; 16],
            port: 8333,
        })
        .collect();

    let addr = AddrMessage { addresses };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Addr(addr),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    match response {
        NetworkResponse::Reject(reason) => {
            assert!(reason.contains("Too many addresses") || reason.contains("limit"));
        }
        _ => panic!("Expected Reject for too many addresses"),
    }
}

// ============================================================================
// Phase 3: Malformed Inventory Message Tests
// ============================================================================

#[test]
fn test_inv_message_too_many_items() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let inventory: Vec<blvm_protocol::network::InventoryVector> = (0..50001)
        .map(|i| blvm_protocol::network::InventoryVector {
            inv_type: 1,
            hash: [i as u8; 32],
        })
        .collect();

    let inv = InvMessage { inventory };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Inv(inv),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    match response {
        NetworkResponse::Reject(reason) => {
            assert!(reason.contains("Too many") || reason.contains("inventory"));
        }
        _ => panic!("Expected Reject for too many inventory items"),
    }
}

#[test]
fn test_inv_message_invalid_type() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let inventory = vec![blvm_protocol::network::InventoryVector {
        inv_type: 99, // Invalid type (valid: 1=tx, 2=block, 3=filtered block, 4=compact block)
        hash: [0u8; 32],
    }];

    let inv = InvMessage { inventory };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Inv(inv),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    // Should handle gracefully (may reject or ignore)
    match response {
        NetworkResponse::Reject(_) | NetworkResponse::Ok => {}
        _ => panic!("Expected Reject or Ok for invalid inventory type"),
    }
}

// ============================================================================
// Phase 4: Malformed GetData Message Tests
// ============================================================================

#[test]
fn test_getdata_message_too_many_items() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let inventory: Vec<blvm_protocol::network::InventoryVector> = (0..50001)
        .map(|i| blvm_protocol::network::InventoryVector {
            inv_type: 1,
            hash: [i as u8; 32],
        })
        .collect();

    let getdata = GetDataMessage { inventory };

    let response = process_network_message(
        &engine,
        &NetworkMessage::GetData(getdata),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    match response {
        NetworkResponse::Reject(reason) => {
            assert!(reason.contains("Too many") || reason.contains("getdata"));
        }
        _ => panic!("Expected Reject for too many getdata items"),
    }
}

// ============================================================================
// Phase 5: Malformed Headers Message Tests
// ============================================================================

#[test]
fn test_headers_message_too_many_headers() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let headers: Vec<BlockHeader> = (0..2001)
        .map(|i| BlockHeader {
            version: 1,
            prev_block_hash: [i as u8; 32],
            merkle_root: [0u8; 32],
            timestamp: 1231006505 + (i as u64),
            bits: 0x1d00ffff,
            nonce: 0,
        })
        .collect();

    let headers_msg = HeadersMessage { headers };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Headers(headers_msg),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    match response {
        NetworkResponse::Reject(reason) => {
            assert!(reason.contains("Too many headers") || reason.contains("limit"));
        }
        _ => panic!("Expected Reject for too many headers"),
    }
}

#[test]
fn test_getheaders_message_too_many_locators() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let locator: Vec<Hash> = (0..101)
        .map(|i| {
            let mut hash = [0u8; 32];
            hash[0] = i as u8;
            hash
        })
        .collect();

    let getheaders = GetHeadersMessage {
        version: 70015,
        block_locator_hashes: locator,
        hash_stop: [0u8; 32],
    };

    let response = process_network_message(
        &engine,
        &NetworkMessage::GetHeaders(getheaders),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    match response {
        NetworkResponse::Reject(reason) => {
            assert!(reason.contains("Too many locator") || reason.contains("max 100"));
        }
        _ => panic!("Expected Reject for too many locators"),
    }
}

// ============================================================================
// Phase 6: Malformed Reject Message Tests
// ============================================================================

#[test]
fn test_reject_message_invalid_name_length() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let reject = RejectMessage {
        message: "verylongmessagename".to_string(), // > 12 chars
        code: 0x10,
        reason: "Invalid".to_string(),
        extra_data: None,
    };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Reject(reject),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    match response {
        NetworkResponse::Reject(reason) => {
            assert!(reason.contains("message name") || reason.contains("too long"));
        }
        _ => panic!("Expected Reject for invalid message name length"),
    }
}

#[test]
fn test_reject_message_reason_too_long() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let long_reason = "a".repeat(1000); // Exceeds protocol limit

    let reject = RejectMessage {
        message: "block".to_string(),
        code: 0x10,
        reason: long_reason,
        extra_data: None,
    };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Reject(reject),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    match response {
        NetworkResponse::Reject(reason) => {
            assert!(reason.contains("reason") || reason.contains("too long"));
        }
        _ => panic!("Expected Reject for reason too long"),
    }
}

// ============================================================================
// Phase 7: Protocol Mismatch Tests
// ============================================================================

#[test]
fn test_version_message_wrong_network() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    // Test with testnet engine but mainnet version message
    // (In practice, this would be caught by magic bytes, but we test the version handling)
    let version = VersionMessage {
        version: 70015,
        services: 1,
        timestamp: 1234567890,
        addr_recv: NetworkAddress {
            services: 1,
            ip: [0u8; 16],
            port: 8333,
        },
        addr_from: NetworkAddress {
            services: 1,
            ip: [0u8; 16],
            port: 8333,
        },
        nonce: 12345,
        user_agent: "test/1.0".to_string(),
        start_height: 0,
        relay: true,
    };

    // Should accept valid version regardless of network (network is determined by magic bytes)
    let response = process_network_message(
        &engine,
        &NetworkMessage::Version(version),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    // Should return VerAck for valid version
    match response {
        NetworkResponse::SendMessage(_) | NetworkResponse::Ok => {}
        _ => panic!("Expected SendMessage or Ok for valid version"),
    }
}

// ============================================================================
// Phase 8: Edge Case Error Recovery Tests
// ============================================================================

#[test]
fn test_empty_inventory_message() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let inv = InvMessage {
        inventory: vec![], // Empty inventory
    };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Inv(inv),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    // Should handle empty inventory gracefully
    assert!(matches!(response, NetworkResponse::Ok));
}

#[test]
fn test_empty_getdata_message() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let getdata = GetDataMessage {
        inventory: vec![], // Empty inventory
    };

    let response = process_network_message(
        &engine,
        &NetworkMessage::GetData(getdata),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    // Should handle empty getdata gracefully
    assert!(matches!(response, NetworkResponse::Ok));
}

#[test]
fn test_empty_headers_message() {
    let engine = create_test_engine();
    let mut peer_state = create_test_peer_state();

    let headers_msg = HeadersMessage {
        headers: vec![], // Empty headers
    };

    let response = process_network_message(
        &engine,
        &NetworkMessage::Headers(headers_msg),
        &mut peer_state,
        None,
        None,
        None,
    )
    .unwrap();

    // Should handle empty headers gracefully
    assert!(matches!(response, NetworkResponse::Ok));
}