blvm-node 0.1.2

Bitcoin Commons BLVM: Minimal Bitcoin node implementation using blvm-protocol and blvm-consensus
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
//! Configuration tests for payment system
//!
//! Tests PaymentConfig and RestApiConfig validation, defaults, and behavior.

use blvm_node::config::{PaymentConfig, RestApiConfig};
use blvm_node::payment::processor::{PaymentError, PaymentProcessor};

#[test]
fn test_payment_config_defaults() {
    // Test default configuration values
    let config = PaymentConfig::default();
    assert_eq!(config.p2p_enabled, true, "P2P should be enabled by default");
    assert_eq!(
        config.http_enabled, false,
        "HTTP should be disabled by default"
    );
    assert_eq!(
        config.module_payments_enabled, true,
        "Module payments should be enabled by default"
    );
    assert_eq!(
        config.payment_store_path, "data/payments",
        "Default payment store path should be 'data/payments'"
    );
    assert_eq!(
        config.merchant_key, None,
        "Merchant key should be None by default"
    );
    assert_eq!(
        config.network,
        Some("mainnet".to_string()),
        "Network should default to mainnet"
    );
}

#[test]
fn test_rest_api_config_defaults() {
    // Test default REST API configuration values
    let config = RestApiConfig::default();
    assert_eq!(
        config.enabled, false,
        "REST API should be disabled by default"
    );
    assert_eq!(
        config.payment_endpoints_enabled, false,
        "Payment endpoints should be disabled by default"
    );
}

#[tokio::test]
async fn test_payment_config_validation_p2p_only() {
    // Test P2P-only configuration (valid, default)
    let config = PaymentConfig {
        p2p_enabled: true,
        http_enabled: false,
        ..Default::default()
    };
    let result = PaymentProcessor::new(config);
    assert!(result.is_ok(), "P2P-only configuration should be valid");
}

#[tokio::test]
async fn test_payment_config_validation_http_requires_feature() {
    // Test HTTP requires feature flag
    let config = PaymentConfig {
        p2p_enabled: false,
        http_enabled: true,
        ..Default::default()
    };

    #[cfg(not(feature = "bip70-http"))]
    {
        let result = PaymentProcessor::new(config.clone());
        assert!(
            result.is_err(),
            "HTTP should require bip70-http feature flag"
        );
        if let Err(PaymentError::FeatureNotEnabled(_)) = result {
            // Expected error
        } else {
            // Verify it's still an error (could be FeatureNotEnabled for rest-api)
            let result2 = PaymentProcessor::new(config);
            assert!(result2.is_err(), "Should still be an error");
        }
    }

    #[cfg(feature = "bip70-http")]
    {
        // With feature enabled, HTTP-only should work
        let result = PaymentProcessor::new(config);
        assert!(
            result.is_ok(),
            "HTTP-only configuration should work with bip70-http feature"
        );
    }
}

#[tokio::test]
async fn test_payment_config_validation_http_requires_rest_api() {
    // Test HTTP also requires rest-api feature
    let config = PaymentConfig {
        p2p_enabled: false,
        http_enabled: true,
        ..Default::default()
    };

    #[cfg(not(feature = "rest-api"))]
    {
        let result = PaymentProcessor::new(config.clone());
        assert!(result.is_err(), "HTTP should require rest-api feature flag");
        if let Err(PaymentError::FeatureNotEnabled(_)) = result {
            // Expected error
        } else {
            // Verify it's still an error
            let result2 = PaymentProcessor::new(config);
            assert!(result2.is_err(), "Should still be an error");
        }
    }
}

#[tokio::test]
async fn test_payment_config_validation_no_transport() {
    // Test that at least one transport must be enabled
    let config = PaymentConfig {
        p2p_enabled: false,
        http_enabled: false,
        ..Default::default()
    };
    let result = PaymentProcessor::new(config);
    assert!(
        result.is_err(),
        "Configuration with no transports enabled should fail"
    );
    let err = match result {
        Err(e) => e,
        Ok(_) => panic!("Expected error but got Ok"),
    };
    match err {
        PaymentError::NoTransportEnabled => {
            // Expected error
        }
        _ => panic!("Expected NoTransportEnabled error"),
    }
}

#[tokio::test]
async fn test_payment_config_validation_both_transports() {
    // Test that both transports can be enabled (if features are available)
    let config = PaymentConfig {
        p2p_enabled: true,
        http_enabled: true,
        ..Default::default()
    };

    #[cfg(all(feature = "bip70-http", feature = "rest-api"))]
    {
        let result = PaymentProcessor::new(config);
        assert!(
            result.is_ok(),
            "Both transports enabled should work with required features"
        );
    }

    #[cfg(not(all(feature = "bip70-http", feature = "rest-api")))]
    {
        let result = PaymentProcessor::new(config);
        assert!(
            result.is_err(),
            "Both transports enabled should fail without required features"
        );
    }
}

#[test]
fn test_payment_config_custom_store_path() {
    // Test custom payment store path
    let config = PaymentConfig {
        payment_store_path: "custom/payments/path".to_string(),
        ..Default::default()
    };
    assert_eq!(
        config.payment_store_path, "custom/payments/path",
        "Custom payment store path should be set"
    );
}

#[test]
fn test_payment_config_merchant_key() {
    // Test merchant key configuration
    let test_key = "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef";
    let config = PaymentConfig {
        merchant_key: Some(test_key.to_string()),
        ..Default::default()
    };
    assert_eq!(
        config.merchant_key,
        Some(test_key.to_string()),
        "Merchant key should be set"
    );
}

#[test]
fn test_payment_config_module_payments_disabled() {
    // Test disabling module payments
    let config = PaymentConfig {
        module_payments_enabled: false,
        ..Default::default()
    };
    assert_eq!(
        config.module_payments_enabled, false,
        "Module payments should be disabled"
    );
}

#[test]
fn test_rest_api_config_enabled() {
    // Test enabling REST API
    let config = RestApiConfig {
        enabled: true,
        payment_endpoints_enabled: false,
    };
    assert_eq!(config.enabled, true, "REST API should be enabled");
    assert_eq!(
        config.payment_endpoints_enabled, false,
        "Payment endpoints should still be disabled"
    );
}

#[test]
fn test_rest_api_config_payment_endpoints_enabled() {
    // Test enabling payment endpoints
    let config = RestApiConfig {
        enabled: true,
        payment_endpoints_enabled: true,
    };
    assert_eq!(config.enabled, true, "REST API should be enabled");
    assert_eq!(
        config.payment_endpoints_enabled, true,
        "Payment endpoints should be enabled"
    );
}

#[test]
fn test_payment_config_serialization() {
    // Test that PaymentConfig can be serialized/deserialized
    use serde_json;

    let config = PaymentConfig {
        p2p_enabled: true,
        http_enabled: false,
        network: Some("testnet".to_string()),
        merchant_key: Some("test_key".to_string()),
        payment_store_path: "test/path".to_string(),
        module_payments_enabled: true,
        node_payment_address: None,
        safe_confirmation_depth: 6,
    };

    let serialized = serde_json::to_string(&config).expect("Should serialize");
    let deserialized: PaymentConfig =
        serde_json::from_str(&serialized).expect("Should deserialize");

    assert_eq!(deserialized.p2p_enabled, config.p2p_enabled);
    assert_eq!(deserialized.http_enabled, config.http_enabled);
    assert_eq!(deserialized.network, config.network);
    assert_eq!(deserialized.merchant_key, config.merchant_key);
    assert_eq!(deserialized.payment_store_path, config.payment_store_path);
    assert_eq!(
        deserialized.module_payments_enabled,
        config.module_payments_enabled
    );
}

#[test]
fn test_rest_api_config_serialization() {
    // Test that RestApiConfig can be serialized/deserialized
    use serde_json;

    let config = RestApiConfig {
        enabled: true,
        payment_endpoints_enabled: true,
    };

    let serialized = serde_json::to_string(&config).expect("Should serialize");
    let deserialized: RestApiConfig =
        serde_json::from_str(&serialized).expect("Should deserialize");

    assert_eq!(deserialized.enabled, config.enabled);
    assert_eq!(
        deserialized.payment_endpoints_enabled,
        config.payment_endpoints_enabled
    );
}

#[test]
fn test_payment_config_toml_parsing() {
    // Test parsing PaymentConfig from TOML
    use toml;

    let toml_str = r#"
        p2p_enabled = true
        http_enabled = false
        network = "regtest"
        payment_store_path = "custom/path"
        module_payments_enabled = true
    "#;

    let config: PaymentConfig = toml::from_str(toml_str).expect("Should parse TOML");
    assert_eq!(config.p2p_enabled, true);
    assert_eq!(config.http_enabled, false);
    assert_eq!(config.network, Some("regtest".to_string()));
    assert_eq!(config.payment_store_path, "custom/path");
    assert_eq!(config.module_payments_enabled, true);
}

#[test]
fn test_payment_config_toml_with_defaults() {
    // Test TOML parsing with missing fields (should use defaults)
    use toml;

    let toml_str = r#"
        p2p_enabled = false
    "#;

    let config: PaymentConfig = toml::from_str(toml_str).expect("Should parse TOML");
    assert_eq!(config.p2p_enabled, false);
    assert_eq!(
        config.http_enabled, false,
        "Should use default for missing field"
    );
    assert_eq!(
        config.payment_store_path, "data/payments",
        "Should use default for missing field"
    );
    assert_eq!(
        config.module_payments_enabled, true,
        "Should use default for missing field"
    );
    assert_eq!(
        config.network,
        Some("mainnet".to_string()),
        "Should use default network (mainnet) for missing field"
    );
}

#[test]
fn test_rest_api_config_toml_parsing() {
    // Test parsing RestApiConfig from TOML
    use toml;

    let toml_str = r#"
        enabled = true
        payment_endpoints_enabled = true
    "#;

    let config: RestApiConfig = toml::from_str(toml_str).expect("Should parse TOML");
    assert_eq!(config.enabled, true);
    assert_eq!(config.payment_endpoints_enabled, true);
}

#[test]
fn test_rest_api_config_toml_with_defaults() {
    // Test TOML parsing with missing fields (should use defaults)
    use toml;

    let toml_str = r#"
        enabled = true
    "#;

    let config: RestApiConfig = toml::from_str(toml_str).expect("Should parse TOML");
    assert_eq!(config.enabled, true);
    assert_eq!(
        config.payment_endpoints_enabled, false,
        "Should use default for missing field"
    );
}

#[tokio::test]
async fn test_payment_processor_with_custom_config() {
    // Test that PaymentProcessor works with custom configuration
    let config = PaymentConfig {
        p2p_enabled: true,
        http_enabled: false,
        network: Some("testnet".to_string()),
        payment_store_path: "test/payments".to_string(),
        module_payments_enabled: true,
        merchant_key: None,
        node_payment_address: None,
        safe_confirmation_depth: 6,
    };

    let _processor = PaymentProcessor::new(config).expect("Should create processor");
    // Processor is created successfully, config is stored internally
    // We can't directly access config, but we can verify processor works
    // by checking it doesn't panic
}

#[tokio::test]
async fn test_payment_processor_config_immutability() {
    // Test that PaymentProcessor configuration is immutable after creation
    let config1 = PaymentConfig {
        p2p_enabled: true,
        http_enabled: false,
        ..Default::default()
    };

    let config2 = PaymentConfig {
        p2p_enabled: true,
        http_enabled: false,
        payment_store_path: "different/path".to_string(),
        ..Default::default()
    };

    let _processor1 = PaymentProcessor::new(config1).expect("Should create processor 1");
    let _processor2 = PaymentProcessor::new(config2).expect("Should create processor 2");

    // Both processors should work independently
    // (We can't directly compare configs, but both should function)
    // This test mainly ensures that different configs create different processors
    // without errors
}