bloomcraft 0.1.1

Production-grade Bloom filter library for Rust with concurrent variants and optimal performance
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
//! False positive rate tracking with optional sliding-window monitoring.
//!
//! [`FalsePositiveTracker`] maintains two counter groups:
//! * **All-time** — atomic u64 totals for positives, true positives, negatives.
//! * **Sliding window** — recent FP samples gated by a `Mutex`-protected ring buffer.
//!
//! The all-time rate is lock-free. The window rate acquires a short-lived mutex.

use std::sync::atomic::{AtomicU64, Ordering};
use std::sync::{Arc, Mutex};

/// Configuration for [`FalsePositiveTracker`].
#[derive(Debug, Clone)]
pub struct FpTrackerConfig {
    /// Maximum number of samples in the sliding window.
    pub window_size: usize,
    /// Expected false positive rate used by [`is_alert`](FalsePositiveTracker::is_alert).
    pub expected_fp_rate: f64,
    /// Multiplier applied to `expected_fp_rate` to set the alert threshold.
    pub alert_threshold: f64,
}

impl Default for FpTrackerConfig {
    fn default() -> Self {
        Self {
            window_size: 1000,
            expected_fp_rate: 0.01,
            alert_threshold: 1.5,
        }
    }
}

/// Tracks false positive rate with both all-time and sliding-window views.
///
/// # Thread safety
///
/// * `record_positive`, `record_true_positive`, `record_negative`, `current_fp_rate` — lock-free.
/// * `record_confirmed`, `window_fp_rate`, `snapshot`, `reset` — acquire the window mutex.
///
/// # Clone semantics
///
/// Cloning copies the all-time atomics but starts with an **empty** sliding window.
pub struct FalsePositiveTracker {
    /// Total positive queries (filter said "yes")
    total_positives: AtomicU64,
    /// True positive queries (actually in set)
    true_positives: AtomicU64,
    /// Total negative queries (filter said "no")
    total_negatives: AtomicU64,
    /// Configuration
    config: FpTrackerConfig,
    /// Sliding window of recent FP rates (protected by mutex)
    window: Arc<Mutex<SlidingWindow>>,
}

/// Sliding window for tracking recent false positive rates.
struct SlidingWindow {
    samples: Vec<bool>,
    pos: usize,
    size: usize,
}

impl SlidingWindow {
    fn new(size: usize) -> Self {
        Self {
            samples: Vec::with_capacity(size),
            pos: 0,
            size,
        }
    }

    fn push(&mut self, is_false_positive: bool) {
        if self.samples.len() < self.size {
            self.samples.push(is_false_positive);
        } else {
            self.samples[self.pos] = is_false_positive;
            self.pos = (self.pos + 1) % self.size;
        }
    }

    fn false_positive_rate(&self) -> f64 {
        if self.samples.is_empty() {
            return 0.0;
        }
        let fp_count = self.samples.iter().filter(|&&x| x).count();
        fp_count as f64 / self.samples.len() as f64
    }

    fn count(&self) -> usize {
        self.samples.len()
    }
}

impl FalsePositiveTracker {
    /// Create a new tracker with default configuration.
    ///
    /// # Examples
    ///
    /// ```
    /// use bloomcraft::metrics::FalsePositiveTracker;
    ///
    /// let tracker = FalsePositiveTracker::new(1000);
    /// ```
    pub fn new(expected_items: usize) -> Self {
        Self::with_config(FpTrackerConfig {
            window_size: expected_items.min(10_000),
            ..Default::default()
        })
    }

    /// Create a tracker with custom configuration.
    pub fn with_config(config: FpTrackerConfig) -> Self {
        Self {
            total_positives: AtomicU64::new(0),
            true_positives: AtomicU64::new(0),
            total_negatives: AtomicU64::new(0),
            window: Arc::new(Mutex::new(SlidingWindow::new(config.window_size))),
            config,
        }
    }

    /// Record a positive query result (filter returned "may contain").
    pub fn record_positive(&self) {
        self.total_positives.fetch_add(1, Ordering::Relaxed);
    }

    /// Record a true positive (actually in set).
    ///
    /// Call this after confirming the item is actually in the set.
    pub fn record_true_positive(&self) {
        self.true_positives.fetch_add(1, Ordering::Relaxed);
    }

    /// Record a negative query (filter said "no").
    pub fn record_negative(&self) {
        self.total_negatives.fetch_add(1, Ordering::Relaxed);
    }

    /// Record a query with known ground truth.
    ///
    /// When `filter_result` is `true` and `actually_present` is `false`,
    /// the event is pushed into the sliding window as a false positive.
    ///
    /// The window mutex is acquired. If the lock is poisoned, the sample is
    /// silently dropped.
    pub fn record_confirmed(&self, filter_result: bool, actually_present: bool) {
        if filter_result {
            self.record_positive();
            if actually_present {
                self.record_true_positive();
            } else {
                // False positive
                if let Ok(mut window) = self.window.lock() {
                    window.push(true);
                }
            }
        } else {
            self.record_negative();
            // Negative results are never false (no false negatives in Bloom filters)
        }
    }

    /// All-time false positive rate: `(positives - true_positives) / positives`.
    ///
    /// Returns `0.0` when no positives have been recorded.
    pub fn current_fp_rate(&self) -> f64 {
        let total_pos = self.total_positives.load(Ordering::Relaxed);
        let true_pos = self.true_positives.load(Ordering::Relaxed);

        if total_pos == 0 {
            return 0.0;
        }

        let false_pos = total_pos.saturating_sub(true_pos);
        false_pos as f64 / total_pos as f64
    }

    /// False positive rate over the sliding window only.
    ///
    /// More responsive to recent behavior than [`current_fp_rate`](Self::current_fp_rate).
    /// Returns `0.0` if the window is empty or the lock is poisoned.
    pub fn window_fp_rate(&self) -> f64 {
        self.window
            .lock()
            .map(|w| w.false_positive_rate())
            .unwrap_or(0.0)
    }

    /// Get expected false positive rate from configuration.
    pub fn expected_fp_rate(&self) -> f64 {
        self.config.expected_fp_rate
    }

    /// Check if current FP rate exceeds alert threshold.
    pub fn is_alert(&self) -> bool {
        let current = self.window_fp_rate();
        let threshold = self.config.expected_fp_rate * self.config.alert_threshold;
        current > threshold
    }

    /// Get total number of queries.
    pub fn total_queries(&self) -> u64 {
        self.total_positives.load(Ordering::Relaxed) + self.total_negatives.load(Ordering::Relaxed)
    }

    /// Get total positive queries.
    pub fn total_positives(&self) -> u64 {
        self.total_positives.load(Ordering::Relaxed)
    }

    /// Get total true positives.
    pub fn total_true_positives(&self) -> u64 {
        self.true_positives.load(Ordering::Relaxed)
    }

    /// Get total false positives (estimated).
    pub fn total_false_positives(&self) -> u64 {
        let total_pos = self.total_positives.load(Ordering::Relaxed);
        let true_pos = self.true_positives.load(Ordering::Relaxed);
        total_pos.saturating_sub(true_pos)
    }

    /// Get snapshot of all statistics.
    pub fn snapshot(&self) -> FpTrackerSnapshot {
        FpTrackerSnapshot {
            total_queries: self.total_queries(),
            total_positives: self.total_positives(),
            true_positives: self.total_true_positives(),
            false_positives: self.total_false_positives(),
            current_fp_rate: self.current_fp_rate(),
            window_fp_rate: self.window_fp_rate(),
            expected_fp_rate: self.expected_fp_rate(),
            is_alert: self.is_alert(),
            window_sample_count: self.window.lock().map(|w| w.count()).unwrap_or(0),
        }
    }

    /// Reset all counters.
    pub fn reset(&self) {
        self.total_positives.store(0, Ordering::Relaxed);
        self.true_positives.store(0, Ordering::Relaxed);
        self.total_negatives.store(0, Ordering::Relaxed);

        if let Ok(mut window) = self.window.lock() {
            *window = SlidingWindow::new(self.config.window_size);
        }
    }
}

impl Clone for FalsePositiveTracker {
    fn clone(&self) -> Self {
        Self {
            total_positives: AtomicU64::new(self.total_positives.load(Ordering::Relaxed)),
            true_positives: AtomicU64::new(self.true_positives.load(Ordering::Relaxed)),
            total_negatives: AtomicU64::new(self.total_negatives.load(Ordering::Relaxed)),
            config: self.config.clone(),
            window: Arc::new(Mutex::new(SlidingWindow::new(self.config.window_size))),
        }
    }
}

/// Snapshot of false positive tracker statistics.
#[derive(Debug, Clone)]
pub struct FpTrackerSnapshot {
    /// Total number of queries (positive + negative).
    pub total_queries: u64,
    /// Total positive queries (filter said "yes").
    pub total_positives: u64,
    /// True positive queries (actually in set).
    pub true_positives: u64,
    /// False positive queries (not in set but filter said "yes").
    pub false_positives: u64,
    /// Current all-time false positive rate.
    pub current_fp_rate: f64,
    /// False positive rate from sliding window (recent behavior).
    pub window_fp_rate: f64,
    /// Expected false positive rate from configuration.
    pub expected_fp_rate: f64,
    /// Whether the current FP rate exceeds the alert threshold.
    pub is_alert: bool,
    /// Number of samples in the sliding window.
    pub window_sample_count: usize,
}

impl FpTrackerSnapshot {
    /// Get deviation from expected rate (as percentage).
    pub fn deviation_percent(&self) -> f64 {
        if self.expected_fp_rate == 0.0 {
            return 0.0;
        }
        ((self.window_fp_rate - self.expected_fp_rate) / self.expected_fp_rate) * 100.0
    }

    /// Check if tracker has sufficient samples for reliable statistics.
    pub fn has_sufficient_samples(&self) -> bool {
        self.window_sample_count >= 100
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_new_tracker() {
        let tracker = FalsePositiveTracker::new(1000);
        assert_eq!(tracker.total_queries(), 0);
        assert_eq!(tracker.current_fp_rate(), 0.0);
    }

    #[test]
    fn test_record_operations() {
        let tracker = FalsePositiveTracker::new(1000);

        tracker.record_positive();
        tracker.record_true_positive();
        tracker.record_negative();

        assert_eq!(tracker.total_positives(), 1);
        assert_eq!(tracker.total_true_positives(), 1);
        assert_eq!(tracker.total_queries(), 2);
    }

    #[test]
    fn test_zero_false_positives() {
        let tracker = FalsePositiveTracker::new(1000);

        for _ in 0..100 {
            tracker.record_positive();
            tracker.record_true_positive();
        }

        assert_eq!(tracker.current_fp_rate(), 0.0);
        assert_eq!(tracker.total_false_positives(), 0);
    }

    #[test]
    fn test_false_positive_calculation() {
        let tracker = FalsePositiveTracker::new(1000);

        // 10 positives, 9 true = 1 false positive
        for _ in 0..10 {
            tracker.record_positive();
        }
        for _ in 0..9 {
            tracker.record_true_positive();
        }

        assert_eq!(tracker.total_false_positives(), 1);
        assert!((tracker.current_fp_rate() - 0.10).abs() < 0.01);
    }

    #[test]
    fn test_confirmed_recording() {
        let tracker = FalsePositiveTracker::new(1000);

        // True positive
        tracker.record_confirmed(true, true);
        assert_eq!(tracker.total_positives(), 1);
        assert_eq!(tracker.total_true_positives(), 1);

        // False positive
        tracker.record_confirmed(true, false);
        assert_eq!(tracker.total_positives(), 2);
        assert_eq!(tracker.total_true_positives(), 1);

        // True negative
        tracker.record_confirmed(false, false);
        assert_eq!(tracker.total_negatives.load(Ordering::Relaxed), 1);
    }

    #[test]
    fn test_sliding_window() {
        let tracker = FalsePositiveTracker::with_config(FpTrackerConfig {
            window_size: 10,
            expected_fp_rate: 0.01,
            alert_threshold: 1.5,
        });

        // Fill window with false positives
        for _ in 0..10 {
            tracker.record_confirmed(true, false);
        }

        // Window should show 100% FP rate
        assert!((tracker.window_fp_rate() - 1.0).abs() < 0.01);
        assert!(tracker.is_alert());
    }

    #[test]
    fn test_alert_threshold() {
        let tracker = FalsePositiveTracker::with_config(FpTrackerConfig {
            window_size: 100,
            expected_fp_rate: 0.01,
            alert_threshold: 2.0,
        });

        // Below threshold
        for _ in 0..100 {
            tracker.record_confirmed(true, true);
        }
        assert!(!tracker.is_alert());

        // Above threshold (simulate 5% FP rate)
        for _ in 0..100 {
            tracker.record_confirmed(true, false);
        }
        assert!(tracker.is_alert());
    }

    #[test]
    fn test_snapshot() {
        let tracker = FalsePositiveTracker::new(1000);

        for _ in 0..10 {
            tracker.record_positive();
        }
        for _ in 0..9 {
            tracker.record_true_positive();
        }

        let snapshot = tracker.snapshot();
        assert_eq!(snapshot.total_positives, 10);
        assert_eq!(snapshot.true_positives, 9);
        assert_eq!(snapshot.false_positives, 1);
        assert!((snapshot.current_fp_rate - 0.10).abs() < 0.01);
    }

    #[test]
    fn test_reset() {
        let tracker = FalsePositiveTracker::new(1000);

        tracker.record_positive();
        tracker.record_true_positive();

        assert_eq!(tracker.total_queries(), 1);

        tracker.reset();

        assert_eq!(tracker.total_queries(), 0);
        assert_eq!(tracker.current_fp_rate(), 0.0);
    }

    #[test]
    fn test_deviation_percent() {
        let snapshot = FpTrackerSnapshot {
            total_queries: 100,
            total_positives: 10,
            true_positives: 9,
            false_positives: 1,
            current_fp_rate: 0.10,
            window_fp_rate: 0.015,
            expected_fp_rate: 0.01,
            is_alert: true,
            window_sample_count: 100,
        };

        let deviation = snapshot.deviation_percent();
        assert!((deviation - 50.0).abs() < 1.0); // 50% over expected
    }

    #[test]
    fn test_concurrent_access() {
        use std::sync::Arc;
        use std::thread;

        let tracker = Arc::new(FalsePositiveTracker::new(10_000));
        let mut handles = vec![];

        for _ in 0..10 {
            let tracker_clone = Arc::clone(&tracker);
            let handle = thread::spawn(move || {
                for _ in 0..1000 {
                    tracker_clone.record_positive();
                    tracker_clone.record_true_positive();
                }
            });
            handles.push(handle);
        }

        for handle in handles {
            handle.join().unwrap();
        }

        assert_eq!(tracker.total_positives(), 10_000);
        assert_eq!(tracker.total_true_positives(), 10_000);
    }

    #[test]
    fn test_clone() {
        let tracker = FalsePositiveTracker::new(1000);
        tracker.record_positive();
        tracker.record_true_positive();

        let cloned = tracker.clone();
        assert_eq!(cloned.total_positives(), 1);
        assert_eq!(cloned.total_true_positives(), 1);
    }
}