bitrouter 1.0.0-alpha.32

//! Auth tests: the `skip_auth` truth table and the `brvk_` validation flow.

use sea_orm::sea_query::Expr;
use sea_orm::{ColumnTrait, DatabaseConnection, EntityTrait, QueryFilter};

use crate::auth::entities::api_keys;

use bitrouter_sdk::caller::CallerContext;
use bitrouter_sdk::language_model::{
    GenerationParams, HookDecision, Message, PipelineContext, PipelineRequest, PreRequestHook,
    Prompt, Role,
};
use bitrouter_sdk::mcp::{McpContext, McpRequest};

use crate::auth::db::{self, NewApiKey};
use crate::auth::events::{ApiPrincipalEstablished, Authenticated};
use crate::auth::hook::AuthHook;
use crate::auth::keys;

async fn pool() -> DatabaseConnection {
    let db = crate::db::connect("sqlite::memory:").await.unwrap();
    crate::db::run_migrations(&db).await.unwrap();
    db
}

fn prompt() -> Prompt {
    Prompt {
        model: "m".to_string(),
        system: None,
        system_provider_metadata: Default::default(),
        messages: vec![Message::text(Role::User, "hi")],
        tools: Vec::new(),
        params: GenerationParams::default(),
        response_format: None,
        tool_choice: None,
        stream: false,
    }
}

/// Build a context whose caller is the given one, with an optional bearer
/// credential header.
fn ctx_with(caller: CallerContext, bearer: Option<&str>) -> PipelineContext {
    let mut req = PipelineRequest::new("m", caller, prompt());
    if let Some(token) = bearer {
        req.headers
            .insert("authorization", format!("Bearer {token}").parse().unwrap());
    }
    PipelineContext::new(req)
}

fn mcp_ctx_with(caller: CallerContext, bearer: Option<&str>) -> McpContext {
    let mut request = McpRequest::direct("catalog", "tools/list", serde_json::json!({}), caller);
    if let Some(token) = bearer {
        request
            .headers
            .insert("authorization", format!("Bearer {token}").parse().unwrap());
    }
    McpContext::new(request)
}

/// Insert a fresh active key, returning its plaintext secret + id.
async fn insert_active_key(pool: &DatabaseConnection, user: &str) -> (String, String) {
    db::upsert_user(pool, user).await.unwrap();
    let key = keys::generate();
    let id = format!("key_{user}");
    db::insert_api_key(
        pool,
        &NewApiKey {
            id: id.clone(),
            key_hash: key.hash.clone(),
            user_id: user.to_string(),
            spend_limit_micro_usd: Some(1_000_000),
            rpm_limit: Some(60),
            policy_id: Some("pol_default".to_string()),
        },
    )
    .await
    .unwrap();
    (key.secret, id)
}

#[tokio::test]
async fn valid_key_authenticates_and_emits_event() {
    let pool = pool().await;
    let (secret, key_id) = insert_active_key(&pool, "u1").await;
    let hook = AuthHook::new(pool);

    let mut ctx = ctx_with(CallerContext::anonymous(), Some(&secret));
    let decision = hook.check(&mut ctx).await.unwrap();
    assert!(matches!(decision, HookDecision::Allow));

    // caller upgraded from anonymous to the real identity
    assert_eq!(ctx.caller().api_key_id(), key_id);
    assert_eq!(ctx.caller().user_id(), "u1");
    assert!(!ctx.caller().is_anonymous());

    // the Authenticated event is broadcast for downstream hooks
    let event = ctx.get_event::<Authenticated>().expect("event emitted");
    assert_eq!(event.api_key_id, key_id);
    assert_eq!(event.policy_id.as_deref(), Some("pol_default"));
    assert_eq!(
        ctx.get_event::<ApiPrincipalEstablished>()
            .expect("route principal event")
            .route_scope_id,
        keys::hash_key(&secret)
    );
}

#[tokio::test]
async fn valid_key_authenticates_mcp_and_emits_identity_events() {
    let pool = pool().await;
    let (secret, key_id) = insert_active_key(&pool, "mcp-user").await;
    let hook = AuthHook::new(pool);
    let mut ctx = mcp_ctx_with(CallerContext::anonymous(), Some(&secret));

    let decision = bitrouter_sdk::mcp::PreRequestHook::check(&hook, &mut ctx)
        .await
        .unwrap();
    assert!(matches!(decision, HookDecision::Allow));
    assert_eq!(ctx.caller().api_key_id(), key_id);
    assert_eq!(ctx.caller().user_id(), "mcp-user");
    assert!(ctx.has_event::<Authenticated>());
    assert!(ctx.has_event::<ApiPrincipalEstablished>());
}

#[tokio::test]
async fn anonymous_mcp_request_is_denied_when_auth_is_enabled() {
    let hook = AuthHook::new(pool().await);
    let mut ctx = mcp_ctx_with(CallerContext::anonymous(), None);

    let decision = bitrouter_sdk::mcp::PreRequestHook::check(&hook, &mut ctx)
        .await
        .unwrap();
    let HookDecision::Deny(reason) = decision else {
        panic!("anonymous MCP request must be denied");
    };
    let error: bitrouter_sdk::BitrouterError = reason.into();
    assert_eq!(error.status(), 401);
}

#[tokio::test]
async fn skip_auth_keeps_declared_controller_headers_on_the_local_principal() {
    let pool = pool().await;
    let hook = AuthHook::new(pool);
    let mut request = PipelineRequest::new("m", CallerContext::local(), prompt());
    request
        .headers
        .insert("authorization", "Bearer forged".parse().unwrap());
    request
        .headers
        .insert("x-bitrouter-controller-id", "brc_victim".parse().unwrap());
    let mut ctx = PipelineContext::new(request);

    assert!(matches!(
        hook.check(&mut ctx).await.unwrap(),
        HookDecision::Allow
    ));
    assert!(ctx.caller().is_local());
    assert!(ctx.get_event::<ApiPrincipalEstablished>().is_none());
}

#[tokio::test]
async fn unknown_key_is_denied_401() {
    let pool = pool().await;
    let hook = AuthHook::new(pool);
    let fresh = keys::generate(); // never inserted
    let mut ctx = ctx_with(CallerContext::anonymous(), Some(&fresh.secret));
    match hook.check(&mut ctx).await.unwrap() {
        HookDecision::Deny(reason) => {
            let err: bitrouter_sdk::BitrouterError = reason.into();
            assert_eq!(err.status(), 401);
        }
        HookDecision::Allow => panic!("unknown key must be denied"),
    }
}

#[tokio::test]
async fn non_virtual_key_is_denied() {
    let pool = pool().await;
    let hook = AuthHook::new(pool);
    // an OpenAI-style key — v1 has no JWT / sk- path
    let mut ctx = ctx_with(CallerContext::anonymous(), Some("sk-not-a-brvk-key"));
    assert!(matches!(
        hook.check(&mut ctx).await.unwrap(),
        HookDecision::Deny(_)
    ));
}

// ===== skip_auth truth table =====

#[tokio::test]
async fn truth_table_no_skip_auth_no_credential_denies() {
    // skip_auth=false → caller is anonymous; no credential → 401
    let pool = pool().await;
    let hook = AuthHook::new(pool);
    let mut ctx = ctx_with(CallerContext::anonymous(), None);
    assert!(matches!(
        hook.check(&mut ctx).await.unwrap(),
        HookDecision::Deny(_)
    ));
}

#[tokio::test]
async fn truth_table_skip_auth_no_credential_allows_local() {
    // skip_auth=true → server synthesised a local caller; no credential → Allow
    let pool = pool().await;
    let hook = AuthHook::new(pool);
    let mut ctx = ctx_with(CallerContext::local(), None);
    assert!(matches!(
        hook.check(&mut ctx).await.unwrap(),
        HookDecision::Allow
    ));
    // the local caller is left intact
    assert!(ctx.caller().is_local());
}

#[tokio::test]
async fn truth_table_skip_auth_with_valid_brvk_still_admits_as_local() {
    // skip_auth=true admits every inbound request as the synthesised
    // local caller — even ones carrying a real virtual key. The point
    // of skip_auth is "fully open local-first"; clients like Claude
    // Code that auto-inject placeholder tokens must not be rejected.
    let pool = pool().await;
    let (secret, _key_id) = insert_active_key(&pool, "u2").await;
    let hook = AuthHook::new(pool);
    let mut ctx = ctx_with(CallerContext::local(), Some(&secret));
    assert!(matches!(
        hook.check(&mut ctx).await.unwrap(),
        HookDecision::Allow
    ));
    assert!(ctx.caller().is_local());
}

#[tokio::test]
async fn truth_table_skip_auth_with_bad_credential_admits_as_local() {
    // skip_auth=true also accepts garbage credentials — the local
    // caller passes through regardless. Tools like Claude Code /
    // litellm always inject an `Authorization: Bearer …` header even
    // when bitrouter doesn't require one, and the value is often a
    // placeholder. Validating it would silently break the zero-config
    // story.
    let pool = pool().await;
    let hook = AuthHook::new(pool);
    let mut ctx = ctx_with(CallerContext::local(), Some("sk-bad"));
    assert!(matches!(
        hook.check(&mut ctx).await.unwrap(),
        HookDecision::Allow
    ));
    assert!(ctx.caller().is_local());
}

#[tokio::test]
async fn inactive_key_is_denied() {
    let pool = pool().await;
    db::upsert_user(&pool, "u3").await.unwrap();
    let key = keys::generate();
    db::insert_api_key(
        &pool,
        &NewApiKey {
            id: "key_inactive".to_string(),
            key_hash: key.hash.clone(),
            user_id: "u3".to_string(),
            spend_limit_micro_usd: None,
            rpm_limit: None,
            policy_id: None,
        },
    )
    .await
    .unwrap();
    // flip it inactive
    api_keys::Entity::update_many()
        .col_expr(api_keys::Column::Active, Expr::value(0))
        .filter(api_keys::Column::Id.eq("key_inactive"))
        .exec(&pool)
        .await
        .unwrap();

    let hook = AuthHook::new(pool);
    let mut ctx = ctx_with(CallerContext::anonymous(), Some(&key.secret));
    assert!(matches!(
        hook.check(&mut ctx).await.unwrap(),
        HookDecision::Deny(_)
    ));
}

#[tokio::test]
async fn upsert_user_rejects_reserved_synthesised_ids() {
    // `local` / `anonymous` are owned by CallerContext::local() / ::anonymous();
    // accepting an upsert under those ids would let a skip_auth=true request
    // silently merge with a real account holder.
    let pool = pool().await;
    for reserved in ["local", "anonymous"] {
        let err = db::upsert_user(&pool, reserved).await.unwrap_err();
        assert!(
            err.to_string().contains("reserved"),
            "expected reservation rejection, got: {err}"
        );
    }
    // Normal ids still work.
    db::upsert_user(&pool, "alice").await.unwrap();
}

#[test]
fn is_reserved_user_id_recognises_synthesised_ids() {
    assert!(db::is_reserved_user_id("local"));
    assert!(db::is_reserved_user_id("anonymous"));
    assert!(!db::is_reserved_user_id("alice"));
    assert!(!db::is_reserved_user_id("Local")); // case-sensitive on purpose
}