bird 0.2.0

X API CLI with entity caching, search, threads, and watchlists
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
//! Entity-aware transport layer over xurl with optional BirdDb cache.
//! Handles UTC-day freshness, batch ID splitting, entity decomposition, and response merging.

mod entity;
mod get;
mod write;

use crate::cost;
use crate::requirements::AuthType;
use crate::transport::Transport;

use super::normalize_endpoint;
use super::store::BirdDb;

use std::borrow::Cow;
use std::fmt;
use std::io::Write;
use std::path::{Path, PathBuf};
use std::sync::{Arc, Mutex};

// -- Shared types (re-exported from db::mod) --

/// Request context for usage logging and auth tracking.
pub struct RequestContext<'a> {
    pub auth_type: &'a AuthType,
    pub username: Option<&'a str>,
}

/// Store control options from CLI flags.
/// Flag precedence (silent): `no_store` wins all; `cache_only` suppresses `refresh`.
#[derive(Default)]
pub struct CacheOpts {
    /// --no-cache: disable store entirely (no reads, no writes)
    pub no_store: bool,
    /// --refresh: skip store reads, still write entities
    pub refresh: bool,
    /// --cache-only: serve from store only, no API calls
    pub cache_only: bool,
}

/// Response from BirdClient (covers both store hits and fresh API responses).
///
/// `cached_body` holds the authoritative bytes-as-stored when available —
/// today, only the `raw_responses` cache hit populates it, preserving the
/// exact bytes the API emitted. Every other constructor leaves it `None`;
/// `body()` derives the string lazily from `json` on the rare caller (error
/// formatting, fallback) that still needs `&str`.
///
/// When Transport begins returning raw bytes (a future redesign), `xurl_get`
/// is expected to populate `cached_body` alongside `json`; `body()` will then
/// take the borrowed branch. Until then, only raw_responses cache hits set it.
pub struct ApiResponse {
    pub status: u16,
    pub(super) cached_body: Option<String>,
    pub cache_hit: bool,
    /// Pre-parsed JSON body (populated by transport methods to avoid double-parse).
    pub json: Option<serde_json::Value>,
}

impl ApiResponse {
    pub fn is_success(&self) -> bool {
        (200..300).contains(&self.status)
    }

    /// Test-only constructor mirroring a `raw_responses` cache hit whose
    /// stored bytes don't parse as JSON. Used by `raw.rs::tests` to
    /// exercise the `into_body()` fallback without standing up a full DB.
    #[cfg(test)]
    pub(crate) fn for_test_raw_body(body: impl Into<String>) -> Self {
        Self {
            status: 200,
            cached_body: Some(body.into()),
            cache_hit: true,
            json: None,
        }
    }

    /// Borrow the response body as `&str`.
    ///
    /// Returns `Cow::Borrowed` when a raw payload is stored (raw_responses
    /// cache hits today); other paths serialize lazily from `json` into
    /// `Cow::Owned`. The optimization wins because the common caller never
    /// reaches `body()` at all — they read `self.json` directly.
    pub fn body(&self) -> Cow<'_, str> {
        debug_assert!(
            self.cached_body.is_some() || self.json.is_some(),
            "ApiResponse with no body and no json"
        );
        if let Some(ref s) = self.cached_body {
            Cow::Borrowed(s.as_str())
        } else if let Some(ref jv) = self.json {
            Cow::Owned(serde_json::to_string(jv).unwrap_or_default())
        } else {
            Cow::Borrowed("")
        }
    }

    /// Consume the response and yield an owned body `String`.
    ///
    /// Delegates to `body()`; the borrowed branch incurs one `String`
    /// allocation, the owned branch is a direct move. Used by the `raw.rs`
    /// fallback when `json` is absent (raw_responses cache hits with a
    /// non-JSON BLOB payload).
    pub fn into_body(self) -> String {
        self.body().into_owned()
    }
}

impl fmt::Debug for ApiResponse {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        // Avoid serializing `json` just to measure length: when `cached_body`
        // is absent (the common path — every fresh request and every
        // freshness cache hit) report `None` instead of paying for a
        // discarded `serde_json::to_string`. The Debug contract here is
        // redaction + sizing, not faithful body reproduction.
        let body_len: Option<usize> = self.cached_body.as_ref().map(|s| s.len());
        f.debug_struct("ApiResponse")
            .field("status", &self.status)
            .field("cache_hit", &self.cache_hit)
            .field("body_len", &body_len)
            .field("json_present", &self.json.is_some())
            .finish()
    }
}

// -- BirdClient --

// Compile-time guard that BirdClient: Send + Sync. A future field with a
// non-Sync type (RefCell, Rc, bare rusqlite::Connection) fails this assertion
// at build time.
const _: fn() = || {
    fn _assert_send_sync<T: Send + Sync>() {}
    _assert_send_sync::<BirdClient>();
};

/// Entity-aware transport layer. Wraps xurl transport + optional BirdDb.
/// If BirdDb is unavailable (corrupted, disk error), degrades to direct transport.
pub struct BirdClient {
    pub(super) transport: Box<dyn Transport>,
    pub(super) db: Option<BirdDb>,
    pub(super) cache_opts: CacheOpts,
    /// Username for xurl -u flag (multi-user token selection)
    pub(super) username: Option<String>,
    /// Suppress informational stderr output. Stored on the struct (unlike `use_color`
    /// which is parameter-passed) because 7+ internal methods emit diagnostics and
    /// threading through every method signature would be excessive.
    pub quiet: bool,
    /// Shared writer handle for diagnostic output. `Arc::clone` of this is
    /// passed into `BirdDb::open` so both layers emit through the same sink.
    /// Read by the internal diagnostic sites under the `if !self.quiet` gate
    /// — the lock is acquired only when emission is required, so suppressed
    /// paths pay zero.
    pub(crate) stderr: Arc<Mutex<dyn Write + Send>>,
}

impl BirdClient {
    /// Create a new BirdClient. If entity store cannot be opened, degrades to no-store.
    ///
    /// `stderr` is the shared writer handle: `Arc::clone` is forwarded to
    /// `BirdDb::open` so both layers emit through the same sink. Internal
    /// diagnostic sites lock the shared handle under the `if !self.quiet`
    /// gate.
    pub fn new(
        transport: Box<dyn Transport>,
        store_path: &Path,
        cache_opts: CacheOpts,
        max_size_mb: u64,
        username: Option<String>,
        quiet: bool,
        stderr: Arc<Mutex<dyn Write + Send>>,
    ) -> Self {
        if cache_opts.no_store {
            return Self {
                transport,
                db: None,
                cache_opts,
                username,
                quiet,
                stderr,
            };
        }
        let db = match BirdDb::open(store_path, max_size_mb, Arc::clone(&stderr), quiet) {
            Ok(db) => {
                // Migrate usage data from old cache.db on first run
                if let Some(parent) = store_path.parent() {
                    let old_cache = parent.join("cache.db");
                    if old_cache.exists() {
                        db.migrate_usage_from_cache(&old_cache);
                    }
                }
                // Prune stale raw_responses and oversized entity tables
                if let Err(e) = db.prune_if_needed()
                    && !quiet
                {
                    let mut w = stderr.lock().unwrap();
                    writeln!(*w, "[store] warning: pruning failed: {e}").ok();
                }
                Some(db)
            }
            Err(e) => {
                if !quiet {
                    let mut w = stderr.lock().unwrap();
                    writeln!(*w, "[store] warning: failed to open entity store: {e}").ok();
                    writeln!(*w, "[store] Run `bird cache clear` to reset the store.").ok();
                }
                None
            }
        };
        Self {
            transport,
            db,
            cache_opts,
            username,
            quiet,
            stderr,
        }
    }

    /// Test-only constructor with explicit transport and in-memory DB.
    /// Uses `io::sink()` as the stderr writer so tests don't capture internal
    /// diagnostic output.
    #[cfg(test)]
    pub(crate) fn new_test(transport: Box<dyn Transport>, db: super::store::BirdDb) -> Self {
        Self {
            transport,
            db: Some(db),
            cache_opts: CacheOpts::default(),
            username: None,
            quiet: true,
            stderr: Arc::new(Mutex::new(std::io::sink())),
        }
    }

    /// Resolved xurl binary path, when the live transport spawns one. Mock
    /// transports return `None`. Surfaced for direct call sites (`bird login`,
    /// `bird doctor`'s `whoami`, write commands) that need the path without
    /// going through [`Transport::request`].
    pub fn xurl_path(&self) -> Option<&Path> {
        self.transport.xurl_path()
    }

    /// Direct-trait request, used by handlers (`bird doctor whoami`, write
    /// verbs) that need to pass argv through to xurl without the entity-store
    /// pipeline.
    pub fn transport_request(
        &self,
        args: &[String],
    ) -> Result<serde_json::Value, Box<dyn std::error::Error + Send + Sync>> {
        self.transport.request(args)
    }

    /// Get entity store stats (None if store unavailable).
    pub fn db_stats(&self) -> Option<Result<super::store::StoreStats, rusqlite::Error>> {
        self.db.as_ref().map(|db| db.stats())
    }

    /// Clear entity data (None if store unavailable).
    pub fn db_clear(&self) -> Option<Result<u64, rusqlite::Error>> {
        self.db.as_ref().map(|db| db.clear())
    }

    /// Get the store DB path.
    pub fn db_path(&self) -> Option<PathBuf> {
        self.db.as_ref().and_then(|db| db.path())
    }

    /// Access the underlying BirdDb (for usage queries).
    pub fn db(&self) -> Option<&BirdDb> {
        self.db.as_ref()
    }

    /// Whether store is explicitly disabled (--no-cache flag).
    pub fn db_disabled(&self) -> bool {
        self.cache_opts.no_store
    }

    /// Log an API call to the usage database. Non-fatal: errors are warned to stderr.
    pub fn log_api_call(
        &mut self,
        url: &str,
        method: &str,
        json: Option<&serde_json::Value>,
        cache_hit: bool,
        username: Option<&str>,
    ) {
        let Some(ref mut db) = self.db else { return };
        let endpoint = normalize_endpoint(url);
        let null = serde_json::Value::Null;
        let json = json.unwrap_or(&null);
        let estimate = cost::estimate_raw_cost(json, &endpoint);
        let object_type = if estimate.users_read > 0 && estimate.tweets_read == 0 {
            "user"
        } else if estimate.tweets_read > 0 {
            "tweet"
        } else {
            "none"
        };
        if let Err(e) = db.log_usage(&super::UsageLogEntry {
            endpoint: &endpoint,
            method,
            object_type,
            object_count: (estimate.tweets_read + estimate.users_read) as i64,
            estimated_cost: estimate.estimated_usd,
            cache_hit,
            username,
        }) && !self.quiet
        {
            let mut w = self.stderr.lock().unwrap();
            writeln!(*w, "[usage] warning: failed to log API call: {e}").ok();
        }
    }
}

#[cfg(test)]
mod tests {
    use super::super::store::BirdDb;
    use super::*;
    use crate::transport::tests::MockTransport;

    pub(super) fn test_client_with_db(db: BirdDb) -> BirdClient {
        BirdClient {
            transport: Box::new(MockTransport::new(vec![])),
            db: Some(db),
            cache_opts: CacheOpts::default(),
            username: None,
            quiet: false,
            stderr: Arc::new(Mutex::new(std::io::sink())),
        }
    }

    #[test]
    fn api_response_debug_redacts_body() {
        let response = ApiResponse {
            status: 200,
            cached_body: Some("sensitive data here".to_string()),
            cache_hit: true,
            json: None,
        };
        let debug = format!("{:?}", response);
        assert!(!debug.contains("sensitive data here"));
        assert!(debug.contains("body_len"));
    }

    /// Documents the empty-body contract: an `ApiResponse` with neither
    /// `cached_body` nor `json` returns `""` from `body()` in release
    /// builds. Production paths never construct such a response — the
    /// `debug_assert!` in `body()` would fire — so this test is
    /// release-only.
    #[cfg(not(debug_assertions))]
    #[test]
    fn empty_body_fallback_returns_empty_string() {
        let resp = ApiResponse {
            status: 200,
            cached_body: None,
            cache_hit: false,
            json: None,
        };
        assert_eq!(resp.body(), "");
        assert_eq!(resp.into_body(), "");
    }

    /// Asserts the `body()` debug_assert fires when both bodies are absent.
    /// Debug-only counterpart to `empty_body_fallback_returns_empty_string`.
    #[cfg(debug_assertions)]
    #[test]
    fn empty_body_triggers_debug_assert() {
        let result = std::panic::catch_unwind(|| {
            let resp = ApiResponse {
                status: 200,
                cached_body: None,
                cache_hit: false,
                json: None,
            };
            let _ = resp.body();
        });
        assert!(
            result.is_err(),
            "body() must debug_assert when no body is present"
        );
    }

    #[test]
    fn cache_opts_default() {
        let opts = CacheOpts::default();
        assert!(!opts.no_store);
        assert!(!opts.refresh);
        assert!(!opts.cache_only);
    }

    /// Full workflow integration: search → profile → bookmarks → thread → usage.
    /// Simulates the entity store lifecycle across multiple command paths.
    #[test]
    fn full_workflow_entity_lifecycle() {
        use super::super::store::{BookmarkRow, in_memory_db};
        use super::super::unix_now;

        let db = in_memory_db();
        let mut client = test_client_with_db(db);

        // --- Step 1: Search stores tweet + user entities ---
        let search_response = serde_json::json!({
            "data": [
                {"id": "t1", "text": "hello rust", "author_id": "u1", "conversation_id": "t1"},
                {"id": "t2", "text": "hello world", "author_id": "u2", "conversation_id": "t2"}
            ],
            "includes": {
                "users": [
                    {"id": "u1", "username": "alice", "name": "Alice"},
                    {"id": "u2", "username": "bob", "name": "Bob"}
                ]
            }
        });
        client.decompose_and_upsert("https://api.x.com/2/tweets/search/recent", &search_response);

        let db = client.db.as_ref().expect("test");
        assert!(
            db.get_tweet("t1").expect("test").is_some(),
            "search should store tweet t1"
        );
        assert!(
            db.get_tweet("t2").expect("test").is_some(),
            "search should store tweet t2"
        );
        assert!(
            db.get_user_by_username("alice").expect("test").is_some(),
            "search should store included user alice"
        );
        assert!(
            db.get_user_by_username("bob").expect("test").is_some(),
            "search should store included user bob"
        );

        // --- Step 2: Profile lookup finds stored user (freshness check) ---
        let alice_resp = super::get::check_user_freshness(db, "alice");
        assert!(
            alice_resp.is_some(),
            "profile should find fresh user alice from store"
        );
        let alice_resp = alice_resp.expect("test");
        assert!(alice_resp.cache_hit, "profile user should be a cache hit");
        assert!(
            alice_resp.body().contains("alice"),
            "profile response should contain username"
        );

        // --- Step 3: Bookmark storage with tweet entities ---
        let bookmark_rows = vec![
            BookmarkRow {
                username: "alice".into(),
                tweet_id: "t1".into(),
                position: 0,
                refreshed_at: unix_now(),
            },
            BookmarkRow {
                username: "alice".into(),
                tweet_id: "t2".into(),
                position: 1,
                refreshed_at: unix_now(),
            },
        ];
        db.replace_bookmarks("alice", &bookmark_rows).expect("test");
        let stored_bookmarks = db.get_bookmarks("alice").expect("test");
        assert_eq!(stored_bookmarks.len(), 2, "should store 2 bookmarks");
        assert_eq!(
            stored_bookmarks[0].tweet_id, "t1",
            "bookmark ordering preserved"
        );
        assert_eq!(
            stored_bookmarks[1].tweet_id, "t2",
            "bookmark ordering preserved"
        );

        // --- Step 4: Thread lookup — root tweet from store, conversation via partition ---
        let root_resp = super::get::check_tweet_freshness(db, "t1");
        assert!(root_resp.is_some(), "thread root tweet should be in store");
        assert!(
            root_resp.expect("test").cache_hit,
            "thread root should be cache hit"
        );

        // Partition IDs: t1 is fresh, t3 is missing
        let (from_store, to_fetch) = db.partition_ids(&["t1", "t3"]).expect("test");
        assert_eq!(from_store.len(), 1, "t1 should be fresh in store");
        assert_eq!(from_store[0].id, "t1");
        assert_eq!(to_fetch.len(), 1, "t3 should need fetching");
        assert_eq!(to_fetch[0], "t3");

        // --- Step 5: Usage logging ---
        let db_mut = client.db.as_mut().expect("test");
        db_mut
            .log_usage(&super::super::usage::UsageLogEntry {
                endpoint: "/2/tweets/search/recent",
                method: "GET",
                object_type: "tweets",
                object_count: 2,
                estimated_cost: 0.01,
                cache_hit: false,
                username: Some("alice"),
            })
            .expect("test");
        let summary = db_mut.query_usage_summary(0).expect("test");
        assert_eq!(summary.total_calls, 1, "usage should be logged");
        assert_eq!(summary.total_cost, 0.01);

        // --- Step 6: Stats reflect all stored entities ---
        let stats = db_mut.stats().expect("test");
        assert_eq!(stats.tweet_count, 2, "should have 2 tweets");
        assert_eq!(stats.user_count, 2, "should have 2 users");
        assert_eq!(stats.bookmark_count, 2, "should have 2 bookmarks");
    }
}