1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
//! `Cognitive` implementation for Java.
#![allow(
clippy::enum_glob_use,
clippy::match_same_arms,
clippy::needless_pass_by_value,
clippy::wildcard_imports
)]
#![allow(
clippy::cast_precision_loss,
clippy::cast_possible_truncation,
clippy::cast_sign_loss
)]
use super::*;
impl Cognitive for JavaCode {
fn compute<'a>(
node: &Node<'a>,
_code: &'a [u8],
ancestors: Ancestors<'a, '_>,
stats: &mut Stats,
nesting_map: &mut NestingMap,
) {
use Java::*;
let mut nesting = get_nesting_from_map(node, nesting_map);
match node.kind_id().into() {
IfStatement if !Self::is_else_if(node, ancestors) => {
increase_nesting(stats, &mut nesting);
}
ForStatement | EnhancedForStatement | WhileStatement | DoStatement | SwitchBlock
| CatchClause | TernaryExpression => {
increase_nesting(stats, &mut nesting);
}
// `Else` here is the `else` keyword token, which the grammar
// also emits for the `else` of an `else if` — so this arm
// covers both.
Else => {
increment_by_one(stats);
}
// Per SonarSource Cognitive Complexity §B2, labeled `break LABEL`
// and `continue LABEL` each add +1 for breaking the structured
// control flow. Plain `break;` / `continue;` are not penalized.
BreakStatement | ContinueStatement if node.is_child(Identifier as u16) => {
increment_by_one(stats);
}
BinaryExpression => {
compute_booleans(node, stats, AMPAMP, PIPEPIPE);
}
LambdaExpression => {
nesting.lambda += 1;
}
// At a (possibly nested) method / constructor boundary, reset
// structural nesting to zero and bump the function-depth
// surcharge when this declaration is itself nested inside
// another — matching Rust and the 9-of-13 sibling
// families. Without this, a method declared inside a control
// construct (Java local / member classes) inherited the
// enclosing nesting and every nested method missed the
// SonarSource B-nesting amplification (#696).
//
// A record's compact constructor is its own kind
// (`compact_constructor_declaration`) rather than a
// `constructor_declaration`, so it needs listing in both the
// arm and the `stops` set — otherwise its body's control flow
// is charged to the enclosing class space (#1160).
// `static { … }` joins them for the same reason (#1184): it
// opens a `FuncSpace`, so without this arm an initialiser
// written inside a nested class inherited the enclosing
// nesting.
MethodDeclaration
| ConstructorDeclaration
| CompactConstructorDeclaration
| StaticInitializer => {
enter_function_boundary(
&mut nesting,
node,
ancestors,
&[
MethodDeclaration,
ConstructorDeclaration,
CompactConstructorDeclaration,
StaticInitializer,
],
);
}
_ => {}
}
nesting_map.insert(node.id(), nesting);
}
}