bext-waf 0.2.0

Web Application Firewall for bext — rate limiting, IP filtering, GeoIP, rule engine
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
//! Token-bucket rate limiting with per-rule path matching.
//!
//! Each [`RateLimitRule`] targets a URL pattern and enforces requests-per-minute
//! with burst capacity.  Keys can be extracted from the client IP (with IPv6 /64
//! normalisation), a named header, or a cookie.  The limiter emits standard
//! `RateLimit-Limit`, `RateLimit-Remaining`, and `Retry-After` response headers.
//! Bucket count is capped at 100 000 to bound memory usage.

use std::collections::HashMap;
use std::time::{Duration, Instant};

use dashmap::DashMap;
use serde::{Deserialize, Serialize};

use crate::{WafDecision, WafRequest};

const MAX_BUCKETS: usize = 100_000;

/// Source for the rate-limit key.
#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
#[serde(rename_all = "snake_case")]
pub enum KeySource {
    /// Key by client IP address.
    #[default]
    Ip,
    /// Key by a specific header value.
    Header(String),
    /// Key by a specific cookie value.
    Cookie(String),
}

/// Delay mode when rate limit is approached.
#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
#[serde(rename_all = "snake_case")]
pub enum DelayMode {
    /// Reject immediately when over limit.
    #[default]
    NoDelay,
    /// Delay the response (not implemented at WAF layer — signals the server to add delay).
    Delay,
}

/// A single rate-limiting rule.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct RateLimitRule {
    /// Rule name for identification.
    pub name: String,
    /// Path glob pattern to match.
    pub pattern: String,
    /// Requests per minute (sustained rate).
    pub rpm: u32,
    /// Burst allowance above rpm.
    #[serde(default)]
    pub burst: u32,
    /// What to key on.
    #[serde(default)]
    pub key_source: KeySource,
    /// Delay mode.
    #[serde(default)]
    pub delay_mode: DelayMode,
}

/// Token bucket state for a single key.
struct TokenBucket {
    tokens: f64,
    max_tokens: f64,
    refill_rate: f64, // tokens per second
    last_refill: Instant,
}

impl TokenBucket {
    fn new(rpm: u32, burst: u32) -> Self {
        let max_tokens = (rpm + burst) as f64;
        let refill_rate = rpm as f64 / 60.0;
        Self {
            tokens: max_tokens,
            max_tokens,
            refill_rate,
            last_refill: Instant::now(),
        }
    }

    /// Try to consume one token. Returns (allowed, remaining, reset_after_secs).
    fn try_consume(&mut self) -> (bool, u32, u64) {
        let now = Instant::now();
        let elapsed = now.duration_since(self.last_refill).as_secs_f64();
        self.last_refill = now;

        // Refill tokens.
        self.tokens = (self.tokens + elapsed * self.refill_rate).min(self.max_tokens);

        if self.tokens >= 1.0 {
            self.tokens -= 1.0;
            let remaining = self.tokens.floor() as u32;
            // Reset is when bucket would be full again.
            let deficit = self.max_tokens - self.tokens;
            let reset_secs = if self.refill_rate > 0.0 {
                (deficit / self.refill_rate).ceil() as u64
            } else {
                60
            };
            (true, remaining, reset_secs)
        } else {
            // Time until next token.
            let wait = if self.refill_rate > 0.0 {
                ((1.0 - self.tokens) / self.refill_rate).ceil() as u64
            } else {
                60
            };
            (false, 0, wait)
        }
    }
}

/// Enhanced rate limiter with per-rule token buckets.
pub struct EnhancedRateLimiter {
    rules: Vec<RateLimitRule>,
    // Key: "rule_name:client_key" → TokenBucket
    buckets: DashMap<String, TokenBucket>,
}

impl EnhancedRateLimiter {
    pub fn new(rules: Vec<RateLimitRule>) -> Self {
        Self {
            rules,
            buckets: DashMap::new(),
        }
    }

    /// Extract the rate-limit key for a given rule and request.
    ///
    /// For IP-based keys, IPv6 addresses are normalized to their /64 prefix
    /// to prevent rate-limit bypass via IPv6 address rotation (an attacker
    /// with a /64 block has 2^64 individual addresses).
    fn extract_key(&self, rule: &RateLimitRule, req: &WafRequest) -> String {
        let client_key = match &rule.key_source {
            KeySource::Ip => normalize_ip_for_rate_limit(req.client_ip),
            KeySource::Header(name) => {
                let lower = name.to_lowercase();
                req.headers
                    .iter()
                    .find(|(k, _)| k.to_lowercase() == lower)
                    .map(|(_, v)| v.clone())
                    .unwrap_or_else(|| req.client_ip.to_string())
            }
            KeySource::Cookie(name) => {
                extract_cookie(&req.headers, name).unwrap_or_else(|| req.client_ip.to_string())
            }
        };
        format!("{}:{}", rule.name, client_key)
    }

    /// Check a request against all rate-limit rules.
    /// Returns `(decision, response_headers)`.
    pub fn check(&self, req: &WafRequest) -> Option<(WafDecision, Vec<(String, String)>)> {
        for rule in &self.rules {
            if !path_matches(&rule.pattern, &req.path) {
                continue;
            }

            let bucket_key = self.extract_key(rule, req);

            // Guard against unbounded DashMap growth
            if !self.buckets.contains_key(&bucket_key) && self.buckets.len() >= MAX_BUCKETS {
                self.cleanup(std::time::Duration::from_secs(60));
                if self.buckets.len() >= MAX_BUCKETS {
                    let limit = rule.rpm + rule.burst;
                    return Some((
                        WafDecision::RateLimit { retry_after: 1 },
                        vec![
                            ("RateLimit-Limit".into(), limit.to_string()),
                            ("RateLimit-Remaining".into(), "0".to_string()),
                            ("RateLimit-Reset".into(), "1".to_string()),
                            ("Retry-After".into(), "1".to_string()),
                        ],
                    ));
                }
            }

            let mut entry = self
                .buckets
                .entry(bucket_key)
                .or_insert_with(|| TokenBucket::new(rule.rpm, rule.burst));

            let (allowed, remaining, reset_secs) = entry.try_consume();
            let limit = rule.rpm + rule.burst;

            let headers = vec![
                ("RateLimit-Limit".into(), limit.to_string()),
                ("RateLimit-Remaining".into(), remaining.to_string()),
                ("RateLimit-Reset".into(), reset_secs.to_string()),
            ];

            if !allowed {
                let mut hdrs = headers;
                hdrs.push(("Retry-After".into(), reset_secs.to_string()));

                return Some((
                    WafDecision::RateLimit {
                        retry_after: reset_secs,
                    },
                    hdrs,
                ));
            }

            // If allowed, we still might want to return headers for the first matching rule.
            // But per the API contract, we return None for allow.
            // We'll return headers only on rate limit.
        }

        None
    }

    /// Clean up stale buckets that haven't been accessed recently.
    pub fn cleanup(&self, max_age: Duration) {
        let now = Instant::now();
        self.buckets
            .retain(|_, bucket| now.duration_since(bucket.last_refill) < max_age);
    }
}

/// Normalize an IP address for rate-limit keying.
///
/// IPv6 addresses are masked to their /64 prefix so that all addresses
/// within the same /64 block share a single rate-limit bucket. This
/// prevents bypass via IPv6 address rotation (a /64 has 2^64 addresses).
/// IPv4 addresses are returned as-is.
fn normalize_ip_for_rate_limit(ip: std::net::IpAddr) -> String {
    match ip {
        std::net::IpAddr::V4(v4) => v4.to_string(),
        std::net::IpAddr::V6(v6) => {
            let octets = v6.octets();
            // Zero out the interface identifier (last 8 bytes) to get /64 prefix.
            let prefix = std::net::Ipv6Addr::new(
                u16::from_be_bytes([octets[0], octets[1]]),
                u16::from_be_bytes([octets[2], octets[3]]),
                u16::from_be_bytes([octets[4], octets[5]]),
                u16::from_be_bytes([octets[6], octets[7]]),
                0,
                0,
                0,
                0,
            );
            format!("{prefix}/64")
        }
    }
}

/// Extract a cookie value from headers.
fn extract_cookie(headers: &HashMap<String, String>, cookie_name: &str) -> Option<String> {
    let cookie_header = headers
        .iter()
        .find(|(k, _)| k.eq_ignore_ascii_case("cookie"))
        .map(|(_, v)| v)?;

    for part in cookie_header.split(';') {
        let trimmed = part.trim();
        if let Some((name, value)) = trimmed.split_once('=') {
            if name.trim() == cookie_name {
                return Some(value.trim().to_string());
            }
        }
    }
    None
}

/// Simple path matching: supports exact match, prefix with `*`, and glob `**`.
fn path_matches(pattern: &str, path: &str) -> bool {
    if pattern == "*" || pattern == "/**" {
        return true;
    }
    if let Some(prefix) = pattern.strip_suffix("/**") {
        return path == prefix || path.starts_with(&format!("{prefix}/"));
    }
    if let Some(prefix) = pattern.strip_suffix("/*") {
        if !path.starts_with(&format!("{prefix}/")) && path != prefix {
            return false;
        }
        // Must be exactly one segment after prefix.
        let rest = &path[prefix.len()..];
        return rest.matches('/').count() <= 1;
    }
    pattern == path
}

#[cfg(test)]
mod tests {
    use super::*;

    fn make_req(ip: &str, path: &str) -> WafRequest {
        WafRequest {
            client_ip: ip.parse().unwrap(),
            method: "GET".into(),
            path: path.into(),
            query: None,
            headers: HashMap::new(),
            body: None,
            user_agent: Some("Mozilla/5.0".into()),
        }
    }

    fn make_req_with_headers(ip: &str, path: &str, headers: Vec<(&str, &str)>) -> WafRequest {
        WafRequest {
            client_ip: ip.parse().unwrap(),
            method: "GET".into(),
            path: path.into(),
            query: None,
            headers: headers
                .into_iter()
                .map(|(k, v)| (k.into(), v.into()))
                .collect(),
            body: None,
            user_agent: Some("Mozilla/5.0".into()),
        }
    }

    #[test]
    fn no_rules_allows_all() {
        let limiter = EnhancedRateLimiter::new(vec![]);
        assert!(limiter.check(&make_req("10.0.0.1", "/api/data")).is_none());
    }

    #[test]
    fn within_limit_allows() {
        let rules = vec![RateLimitRule {
            name: "api".into(),
            pattern: "/api/**".into(),
            rpm: 60,
            burst: 10,
            key_source: KeySource::Ip,
            delay_mode: DelayMode::NoDelay,
        }];
        let limiter = EnhancedRateLimiter::new(rules);
        let req = make_req("10.0.0.1", "/api/data");
        assert!(limiter.check(&req).is_none());
    }

    #[test]
    fn exceeds_limit_blocks() {
        let rules = vec![RateLimitRule {
            name: "strict".into(),
            pattern: "/api/**".into(),
            rpm: 2,
            burst: 0,
            key_source: KeySource::Ip,
            delay_mode: DelayMode::NoDelay,
        }];
        let limiter = EnhancedRateLimiter::new(rules);
        let req = make_req("10.0.0.1", "/api/data");

        // First 2 requests: allowed (initial tokens = rpm + burst = 2).
        assert!(limiter.check(&req).is_none());
        assert!(limiter.check(&req).is_none());

        // Third request: should be rate limited.
        let result = limiter.check(&req);
        assert!(result.is_some());
        let (decision, headers) = result.unwrap();
        assert!(matches!(decision, WafDecision::RateLimit { .. }));
        assert!(headers.iter().any(|(k, _)| k == "Retry-After"));
        assert!(headers.iter().any(|(k, _)| k == "RateLimit-Limit"));
        assert!(headers.iter().any(|(k, _)| k == "RateLimit-Remaining"));
    }

    #[test]
    fn burst_allows_extra() {
        let rules = vec![RateLimitRule {
            name: "burst-test".into(),
            pattern: "/**".into(),
            rpm: 2,
            burst: 3,
            key_source: KeySource::Ip,
            delay_mode: DelayMode::NoDelay,
        }];
        let limiter = EnhancedRateLimiter::new(rules);
        let req = make_req("10.0.0.1", "/page");

        // Should allow rpm + burst = 5 requests.
        for _ in 0..5 {
            assert!(limiter.check(&req).is_none());
        }

        // 6th should be limited.
        assert!(limiter.check(&req).is_some());
    }

    #[test]
    fn different_ips_have_separate_limits() {
        let rules = vec![RateLimitRule {
            name: "per-ip".into(),
            pattern: "/**".into(),
            rpm: 1,
            burst: 0,
            key_source: KeySource::Ip,
            delay_mode: DelayMode::NoDelay,
        }];
        let limiter = EnhancedRateLimiter::new(rules);

        // ip1 uses its one token.
        assert!(limiter.check(&make_req("10.0.0.1", "/")).is_none());
        assert!(limiter.check(&make_req("10.0.0.1", "/")).is_some());

        // ip2 should have its own bucket.
        assert!(limiter.check(&make_req("10.0.0.2", "/")).is_none());
    }

    #[test]
    fn non_matching_path_skipped() {
        let rules = vec![RateLimitRule {
            name: "api-only".into(),
            pattern: "/api/**".into(),
            rpm: 1,
            burst: 0,
            key_source: KeySource::Ip,
            delay_mode: DelayMode::NoDelay,
        }];
        let limiter = EnhancedRateLimiter::new(rules);

        // /static/ doesn't match /api/**.
        assert!(limiter
            .check(&make_req("10.0.0.1", "/static/file.js"))
            .is_none());
        assert!(limiter
            .check(&make_req("10.0.0.1", "/static/file.js"))
            .is_none());
    }

    #[test]
    fn header_key_source() {
        let rules = vec![RateLimitRule {
            name: "by-api-key".into(),
            pattern: "/**".into(),
            rpm: 1,
            burst: 0,
            key_source: KeySource::Header("X-API-Key".into()),
            delay_mode: DelayMode::NoDelay,
        }];
        let limiter = EnhancedRateLimiter::new(rules);

        let req1 = make_req_with_headers("10.0.0.1", "/api", vec![("X-API-Key", "key-a")]);
        let req2 = make_req_with_headers("10.0.0.2", "/api", vec![("X-API-Key", "key-b")]);

        // key-a uses its token.
        assert!(limiter.check(&req1).is_none());
        assert!(limiter.check(&req1).is_some());

        // key-b has its own limit.
        assert!(limiter.check(&req2).is_none());
    }

    #[test]
    fn cookie_key_source() {
        let rules = vec![RateLimitRule {
            name: "by-session".into(),
            pattern: "/**".into(),
            rpm: 1,
            burst: 0,
            key_source: KeySource::Cookie("session_id".into()),
            delay_mode: DelayMode::NoDelay,
        }];
        let limiter = EnhancedRateLimiter::new(rules);

        let req = make_req_with_headers(
            "10.0.0.1",
            "/",
            vec![("Cookie", "session_id=abc123; other=val")],
        );
        assert!(limiter.check(&req).is_none());
        assert!(limiter.check(&req).is_some());
    }

    #[test]
    fn path_matching() {
        assert!(path_matches("/api/**", "/api/users"));
        assert!(path_matches("/api/**", "/api/users/123/details"));
        assert!(path_matches("/api/**", "/api"));
        assert!(!path_matches("/api/**", "/static/file"));
        assert!(path_matches("/**", "/anything"));
        assert!(path_matches("*", "/anything"));
        assert!(path_matches("/health", "/health"));
        assert!(!path_matches("/health", "/healthz"));
    }

    #[test]
    fn extract_cookie_works() {
        let mut headers = HashMap::new();
        headers.insert("Cookie".into(), "a=1; session_id=abc; b=2".into());
        assert_eq!(extract_cookie(&headers, "session_id"), Some("abc".into()));
        assert_eq!(extract_cookie(&headers, "a"), Some("1".into()));
        assert_eq!(extract_cookie(&headers, "missing"), None);
    }

    #[test]
    fn cleanup_removes_stale_buckets() {
        let rules = vec![RateLimitRule {
            name: "test".into(),
            pattern: "/**".into(),
            rpm: 60,
            burst: 0,
            key_source: KeySource::Ip,
            delay_mode: DelayMode::NoDelay,
        }];
        let limiter = EnhancedRateLimiter::new(rules);
        let req = make_req("10.0.0.1", "/");
        limiter.check(&req);
        assert!(!limiter.buckets.is_empty());

        // Cleanup with zero duration removes everything.
        limiter.cleanup(Duration::from_secs(0));
        assert!(limiter.buckets.is_empty());
    }

    #[test]
    fn rate_limit_headers_correct() {
        let rules = vec![RateLimitRule {
            name: "strict".into(),
            pattern: "/**".into(),
            rpm: 1,
            burst: 0,
            key_source: KeySource::Ip,
            delay_mode: DelayMode::NoDelay,
        }];
        let limiter = EnhancedRateLimiter::new(rules);
        let req = make_req("10.0.0.1", "/");

        // Use the one token.
        limiter.check(&req);
        // Now limited.
        let (_, headers) = limiter.check(&req).unwrap();

        let limit = headers
            .iter()
            .find(|(k, _)| k == "RateLimit-Limit")
            .unwrap();
        assert_eq!(limit.1, "1"); // rpm + burst = 1

        let remaining = headers
            .iter()
            .find(|(k, _)| k == "RateLimit-Remaining")
            .unwrap();
        assert_eq!(remaining.1, "0");

        let retry = headers.iter().find(|(k, _)| k == "Retry-After").unwrap();
        assert!(!retry.1.is_empty());
    }
}