bevy_tasks 0.19.0

A task executor for Bevy Engine
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
//! Alternative to `async_executor` based on [`edge_executor`] by Ivan Markov.
//!
//! It has been vendored along with its tests to update several outdated dependencies.
//!
//! [`async_executor`]: https://github.com/smol-rs/async-executor
//! [`edge_executor`]: https://github.com/ivmarkov/edge-executor

#![expect(unsafe_code, reason = "original implementation relies on unsafe")]
#![expect(
    dead_code,
    reason = "keeping methods from original implementation for transparency"
)]

// TODO: Create a more tailored replacement, possibly integrating [Fotre](https://github.com/NthTensor/Forte)

use alloc::rc::Rc;
use core::{
    future::{poll_fn, Future},
    marker::PhantomData,
    task::{Context, Poll},
};

use async_task::{Runnable, Task};
use atomic_waker::AtomicWaker;
use bevy_platform::sync::{Arc, LazyLock};
use futures_lite::FutureExt;

/// An async executor.
///
/// # Examples
///
/// A multi-threaded executor:
///
/// ```ignore
/// use async_channel::unbounded;
/// use easy_parallel::Parallel;
///
/// use edge_executor::{Executor, block_on};
///
/// let ex: Executor = Default::default();
/// let (signal, shutdown) = unbounded::<()>();
///
/// Parallel::new()
///     // Run four executor threads.
///     .each(0..4, |_| block_on(ex.run(shutdown.recv())))
///     // Run the main future on the current thread.
///     .finish(|| block_on(async {
///         println!("Hello world!");
///         drop(signal);
///     }));
/// ```
pub struct Executor<'a, const C: usize = 64> {
    state: LazyLock<Arc<State<C>>>,
    _invariant: PhantomData<core::cell::UnsafeCell<&'a ()>>,
}

impl<'a, const C: usize> Executor<'a, C> {
    /// Creates a new executor.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::Executor;
    ///
    /// let ex: Executor = Default::default();
    /// ```
    pub const fn new() -> Self {
        Self {
            state: LazyLock::new(|| Arc::new(State::new())),
            _invariant: PhantomData,
        }
    }

    /// Spawns a task onto the executor.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::Executor;
    ///
    /// let ex: Executor = Default::default();
    ///
    /// let task = ex.spawn(async {
    ///     println!("Hello world");
    /// });
    /// ```
    ///
    /// Note that if the executor's queue size is equal to the number of currently
    /// spawned and running tasks, spawning this additional task might cause the executor to panic
    /// later, when the task is scheduled for polling.
    pub fn spawn<F>(&self, fut: F) -> Task<F::Output>
    where
        F: Future + Send + 'a,
        F::Output: Send + 'a,
    {
        // SAFETY: Original implementation missing safety documentation
        unsafe { self.spawn_unchecked(fut) }
    }

    /// Attempts to run a task if at least one is scheduled.
    ///
    /// Running a scheduled task means simply polling its future once.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::Executor;
    ///
    /// let ex: Executor = Default::default();
    /// assert!(!ex.try_tick()); // no tasks to run
    ///
    /// let task = ex.spawn(async {
    ///     println!("Hello world");
    /// });
    /// assert!(ex.try_tick()); // a task was found
    /// ```    
    pub fn try_tick(&self) -> bool {
        if let Some(runnable) = self.try_runnable() {
            runnable.run();

            true
        } else {
            false
        }
    }

    /// Runs a single task asynchronously.
    ///
    /// Running a task means simply polling its future once.
    ///
    /// If no tasks are scheduled when this method is called, it will wait until one is scheduled.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::{Executor, block_on};
    ///
    /// let ex: Executor = Default::default();
    ///
    /// let task = ex.spawn(async {
    ///     println!("Hello world");
    /// });
    /// block_on(ex.tick()); // runs the task
    /// ```
    pub async fn tick(&self) {
        self.runnable().await.run();
    }

    /// Runs the executor asynchronously until the given future completes.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::{Executor, block_on};
    ///
    /// let ex: Executor = Default::default();
    ///
    /// let task = ex.spawn(async { 1 + 2 });
    /// let res = block_on(ex.run(async { task.await * 2 }));
    ///
    /// assert_eq!(res, 6);
    /// ```
    pub async fn run<F>(&self, fut: F) -> F::Output
    where
        F: Future + Send + 'a,
    {
        // SAFETY: Original implementation missing safety documentation
        unsafe { self.run_unchecked(fut).await }
    }

    /// Waits for the next runnable task to run.
    async fn runnable(&self) -> Runnable {
        poll_fn(|ctx| self.poll_runnable(ctx)).await
    }

    /// Polls the first task scheduled for execution by the executor.
    fn poll_runnable(&self, ctx: &Context<'_>) -> Poll<Runnable> {
        self.state().waker.register(ctx.waker());

        if let Some(runnable) = self.try_runnable() {
            Poll::Ready(runnable)
        } else {
            Poll::Pending
        }
    }

    /// Pops the first task scheduled for execution by the executor.
    ///
    /// Returns
    /// - `None` - if no task was scheduled for execution
    /// - `Some(Runnable)` - the first task scheduled for execution. Calling `Runnable::run` will
    ///   execute the task. In other words, it will poll its future.
    fn try_runnable(&self) -> Option<Runnable> {
        let runnable;

        #[cfg(all(
            target_has_atomic = "8",
            target_has_atomic = "16",
            target_has_atomic = "32",
            target_has_atomic = "64",
            target_has_atomic = "ptr"
        ))]
        {
            runnable = self.state().queue.pop();
        }

        #[cfg(not(all(
            target_has_atomic = "8",
            target_has_atomic = "16",
            target_has_atomic = "32",
            target_has_atomic = "64",
            target_has_atomic = "ptr"
        )))]
        {
            runnable = self.state().queue.dequeue();
        }

        runnable
    }

    /// # Safety
    ///
    /// Original implementation missing safety documentation
    unsafe fn spawn_unchecked<F>(&self, fut: F) -> Task<F::Output>
    where
        F: Future,
    {
        let schedule = {
            let state = self.state().clone();

            move |runnable| {
                #[cfg(all(
                    target_has_atomic = "8",
                    target_has_atomic = "16",
                    target_has_atomic = "32",
                    target_has_atomic = "64",
                    target_has_atomic = "ptr"
                ))]
                {
                    state.queue.push(runnable).unwrap();
                }

                #[cfg(not(all(
                    target_has_atomic = "8",
                    target_has_atomic = "16",
                    target_has_atomic = "32",
                    target_has_atomic = "64",
                    target_has_atomic = "ptr"
                )))]
                {
                    state.queue.enqueue(runnable).unwrap();
                }

                if let Some(waker) = state.waker.take() {
                    waker.wake();
                }
            }
        };

        // SAFETY: Original implementation missing safety documentation
        let (runnable, task) = unsafe { async_task::spawn_unchecked(fut, schedule) };

        runnable.schedule();

        task
    }

    /// # Safety
    ///
    /// Original implementation missing safety documentation
    async unsafe fn run_unchecked<F>(&self, fut: F) -> F::Output
    where
        F: Future,
    {
        let run_forever = async {
            loop {
                self.tick().await;
            }
        };

        run_forever.or(fut).await
    }

    /// Returns a reference to the inner state.
    fn state(&self) -> &Arc<State<C>> {
        &self.state
    }
}

impl<'a, const C: usize> Default for Executor<'a, C> {
    fn default() -> Self {
        Self::new()
    }
}

// SAFETY: Original implementation missing safety documentation
unsafe impl<'a, const C: usize> Send for Executor<'a, C> {}
// SAFETY: Original implementation missing safety documentation
unsafe impl<'a, const C: usize> Sync for Executor<'a, C> {}

/// A thread-local executor.
///
/// The executor can only be run on the thread that created it.
///
/// # Examples
///
/// ```ignore
/// use edge_executor::{LocalExecutor, block_on};
///
/// let local_ex: LocalExecutor = Default::default();
///
/// block_on(local_ex.run(async {
///     println!("Hello world!");
/// }));
/// ```
pub struct LocalExecutor<'a, const C: usize = 64> {
    executor: Executor<'a, C>,
    _not_send: PhantomData<core::cell::UnsafeCell<&'a Rc<()>>>,
}

impl<'a, const C: usize> LocalExecutor<'a, C> {
    /// Creates a single-threaded executor.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::LocalExecutor;
    ///
    /// let local_ex: LocalExecutor = Default::default();
    /// ```
    pub const fn new() -> Self {
        Self {
            executor: Executor::<C>::new(),
            _not_send: PhantomData,
        }
    }

    /// Spawns a task onto the executor.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::LocalExecutor;
    ///
    /// let local_ex: LocalExecutor = Default::default();
    ///
    /// let task = local_ex.spawn(async {
    ///     println!("Hello world");
    /// });
    /// ```
    ///
    /// Note that if the executor's queue size is equal to the number of currently
    /// spawned and running tasks, spawning this additional task might cause the executor to panic
    /// later, when the task is scheduled for polling.
    pub fn spawn<F>(&self, fut: F) -> Task<F::Output>
    where
        F: Future + 'a,
        F::Output: 'a,
    {
        // SAFETY: Original implementation missing safety documentation
        unsafe { self.executor.spawn_unchecked(fut) }
    }

    /// Attempts to run a task if at least one is scheduled.
    ///
    /// Running a scheduled task means simply polling its future once.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::LocalExecutor;
    ///
    /// let local_ex: LocalExecutor = Default::default();
    /// assert!(!local_ex.try_tick()); // no tasks to run
    ///
    /// let task = local_ex.spawn(async {
    ///     println!("Hello world");
    /// });
    /// assert!(local_ex.try_tick()); // a task was found
    /// ```    
    pub fn try_tick(&self) -> bool {
        self.executor.try_tick()
    }

    /// Runs a single task asynchronously.
    ///
    /// Running a task means simply polling its future once.
    ///
    /// If no tasks are scheduled when this method is called, it will wait until one is scheduled.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::{LocalExecutor, block_on};
    ///
    /// let local_ex: LocalExecutor = Default::default();
    ///
    /// let task = local_ex.spawn(async {
    ///     println!("Hello world");
    /// });
    /// block_on(local_ex.tick()); // runs the task
    /// ```
    pub async fn tick(&self) {
        self.executor.tick().await;
    }

    /// Runs the executor asynchronously until the given future completes.
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use edge_executor::{LocalExecutor, block_on};
    ///
    /// let local_ex: LocalExecutor = Default::default();
    ///
    /// let task = local_ex.spawn(async { 1 + 2 });
    /// let res = block_on(local_ex.run(async { task.await * 2 }));
    ///
    /// assert_eq!(res, 6);
    /// ```
    pub async fn run<F>(&self, fut: F) -> F::Output
    where
        F: Future,
    {
        // SAFETY: Original implementation missing safety documentation
        unsafe { self.executor.run_unchecked(fut) }.await
    }
}

impl<'a, const C: usize> Default for LocalExecutor<'a, C> {
    fn default() -> Self {
        Self::new()
    }
}

struct State<const C: usize> {
    #[cfg(all(
        target_has_atomic = "8",
        target_has_atomic = "16",
        target_has_atomic = "32",
        target_has_atomic = "64",
        target_has_atomic = "ptr"
    ))]
    queue: crossbeam_queue::ArrayQueue<Runnable>,
    #[cfg(not(all(
        target_has_atomic = "8",
        target_has_atomic = "16",
        target_has_atomic = "32",
        target_has_atomic = "64",
        target_has_atomic = "ptr"
    )))]
    queue: heapless::mpmc::Queue<Runnable, C>,
    waker: AtomicWaker,
}

impl<const C: usize> State<C> {
    fn new() -> Self {
        Self {
            #[cfg(all(
                target_has_atomic = "8",
                target_has_atomic = "16",
                target_has_atomic = "32",
                target_has_atomic = "64",
                target_has_atomic = "ptr"
            ))]
            queue: crossbeam_queue::ArrayQueue::new(C),
            #[cfg(not(all(
                target_has_atomic = "8",
                target_has_atomic = "16",
                target_has_atomic = "32",
                target_has_atomic = "64",
                target_has_atomic = "ptr"
            )))]
            #[allow(deprecated)]
            queue: heapless::mpmc::Queue::new(),
            waker: AtomicWaker::new(),
        }
    }
}

#[cfg(test)]
mod different_executor_tests {
    use core::cell::Cell;

    use bevy_tasks::{
        block_on,
        futures_lite::{pending, poll_once},
    };
    use futures_lite::pin;

    use super::LocalExecutor;

    #[test]
    fn shared_queue_slot() {
        block_on(async {
            let was_polled = Cell::new(false);
            let future = async {
                was_polled.set(true);
                pending::<()>().await;
            };

            let ex1: LocalExecutor = Default::default();
            let ex2: LocalExecutor = Default::default();

            // Start the futures for running forever.
            let (run1, run2) = (ex1.run(pending::<()>()), ex2.run(pending::<()>()));
            pin!(run1);
            pin!(run2);
            assert!(poll_once(run1.as_mut()).await.is_none());
            assert!(poll_once(run2.as_mut()).await.is_none());

            // Spawn the future on executor one and then poll executor two.
            ex1.spawn(future).detach();
            assert!(poll_once(run2).await.is_none());
            assert!(!was_polled.get());

            // Poll the first one.
            assert!(poll_once(run1).await.is_none());
            assert!(was_polled.get());
        });
    }
}

#[cfg(test)]
mod drop_tests {
    use alloc::string::String;
    use core::mem;
    use core::sync::atomic::{AtomicUsize, Ordering};
    use core::task::{Poll, Waker};
    use std::sync::Mutex;

    use bevy_platform::sync::LazyLock;
    use futures_lite::future;

    use super::{Executor, Task};

    #[test]
    fn leaked_executor_leaks_everything() {
        static DROP: AtomicUsize = AtomicUsize::new(0);
        static WAKER: LazyLock<Mutex<Option<Waker>>> = LazyLock::new(Default::default);

        let ex: Executor = Default::default();

        let task = ex.spawn(async {
            let _guard = CallOnDrop(|| {
                DROP.fetch_add(1, Ordering::SeqCst);
            });

            future::poll_fn(|cx| {
                *WAKER.lock().unwrap() = Some(cx.waker().clone());
                Poll::Pending::<()>
            })
            .await;
        });

        future::block_on(ex.tick());
        assert!(WAKER.lock().unwrap().is_some());
        assert_eq!(DROP.load(Ordering::SeqCst), 0);

        mem::forget(ex);
        assert_eq!(DROP.load(Ordering::SeqCst), 0);

        assert!(future::block_on(future::poll_once(task)).is_none());
        assert_eq!(DROP.load(Ordering::SeqCst), 0);
    }

    #[test]
    fn await_task_after_dropping_executor() {
        let s: String = "hello".into();

        let ex: Executor = Default::default();
        let task: Task<&str> = ex.spawn(async { &*s });
        assert!(ex.try_tick());

        drop(ex);
        assert_eq!(future::block_on(task), "hello");
        drop(s);
    }

    #[test]
    fn drop_executor_and_then_drop_finished_task() {
        static DROP: AtomicUsize = AtomicUsize::new(0);

        let ex: Executor = Default::default();
        let task = ex.spawn(async {
            CallOnDrop(|| {
                DROP.fetch_add(1, Ordering::SeqCst);
            })
        });
        assert!(ex.try_tick());

        assert_eq!(DROP.load(Ordering::SeqCst), 0);
        drop(ex);
        assert_eq!(DROP.load(Ordering::SeqCst), 0);
        drop(task);
        assert_eq!(DROP.load(Ordering::SeqCst), 1);
    }

    #[test]
    fn drop_finished_task_and_then_drop_executor() {
        static DROP: AtomicUsize = AtomicUsize::new(0);

        let ex: Executor = Default::default();
        let task = ex.spawn(async {
            CallOnDrop(|| {
                DROP.fetch_add(1, Ordering::SeqCst);
            })
        });
        assert!(ex.try_tick());

        assert_eq!(DROP.load(Ordering::SeqCst), 0);
        drop(task);
        assert_eq!(DROP.load(Ordering::SeqCst), 1);
        drop(ex);
        assert_eq!(DROP.load(Ordering::SeqCst), 1);
    }

    struct CallOnDrop<F: Fn()>(F);

    impl<F: Fn()> Drop for CallOnDrop<F> {
        fn drop(&mut self) {
            (self.0)();
        }
    }
}

#[cfg(test)]
mod local_queue {
    use alloc::boxed::Box;

    use futures_lite::{future, pin};

    use super::Executor;

    #[test]
    fn two_queues() {
        future::block_on(async {
            // Create an executor with two runners.
            let ex: Executor = Default::default();
            let (run1, run2) = (
                ex.run(future::pending::<()>()),
                ex.run(future::pending::<()>()),
            );
            let mut run1 = Box::pin(run1);
            pin!(run2);

            // Poll them both.
            assert!(future::poll_once(run1.as_mut()).await.is_none());
            assert!(future::poll_once(run2.as_mut()).await.is_none());

            // Drop the first one, which should leave the local queue in the `None` state.
            drop(run1);
            assert!(future::poll_once(run2.as_mut()).await.is_none());
        });
    }
}