bevy-agent-feedback-plugin 0.2.3

Bevy plugin for Pi/Codex-driven input and screenshot feedback.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
use bevy_agent_feedback_plugin::client::{AgentClient, AgentClientConfig};
use serde_json::Value;
use std::{
    fs::{self, File},
    io::{self, BufRead, BufReader, Read, Seek, SeekFrom, Write},
    path::{Path, PathBuf},
    process::{Child, Command, ExitCode, ExitStatus, Stdio},
    sync::{
        Arc, Mutex,
        atomic::{AtomicBool, Ordering},
    },
    thread,
    time::{Duration, Instant, SystemTime, UNIX_EPOCH},
};

fn main() -> ExitCode {
    match real_main() {
        Ok(()) => ExitCode::SUCCESS,
        Err(error) => {
            eprintln!("bevy-feedback: {error}");
            ExitCode::from(1)
        }
    }
}

fn real_main() -> Result<(), String> {
    let args = std::env::args().skip(1).collect::<Vec<_>>();
    let args = parse_args(&args)?;
    fs::create_dir_all(&args.artifacts).map_err(|error| error.to_string())?;
    if let Some(parent) = args.protocol_file.parent()
        && !parent.as_os_str().is_empty()
    {
        fs::create_dir_all(parent).map_err(|error| error.to_string())?;
    }
    let _ = fs::remove_file(&args.protocol_file);

    let game_log = args.artifacts.join("game.log");
    let log_file = Arc::new(Mutex::new(
        File::create(&game_log).map_err(|error| error.to_string())?,
    ));
    let capture_dir = args.artifacts.join("captures");
    fs::create_dir_all(&capture_dir).map_err(|error| error.to_string())?;
    let transcript_file = args.artifacts.join("transcript.jsonl");
    File::create(&transcript_file).map_err(|error| error.to_string())?;
    let mut game = spawn_command(&args.game, &args, &capture_dir, &transcript_file, true)?;
    stream_child_logs(&mut game, log_file);

    let stop = Arc::new(AtomicBool::new(false));
    let stop_for_signal = stop.clone();
    ctrlc::set_handler(move || stop_for_signal.store(true, Ordering::Relaxed))
        .map_err(|error| error.to_string())?;

    let ready = match wait_ready(&args.protocol_file, args.ready_timeout, &mut game, &stop) {
        Ok(ready) => ready,
        Err(error) => {
            let _ = game.kill();
            let _ = game.wait();
            copy_if_exists(&args.protocol_file, &args.artifacts.join("protocol.json"));
            copy_captures(&capture_dir, &args.artifacts.join("screenshots"));
            return fail_run(
                &args.artifacts,
                &game_log,
                &capture_dir,
                format!("{error}\n"),
            );
        }
    };
    println!(
        "bevy-feedback ready: session={} socket={} protocol={}",
        ready.session_id,
        ready.socket_addr,
        args.protocol_file.display()
    );

    let mut game_status = None;
    let mut failure_summary = String::new();
    let mut driver_failed = false;
    if let Some(driver) = &args.driver {
        let mut driver = spawn_command(driver, &args, &capture_dir, &transcript_file, false)?;
        match wait_child(&mut driver, args.driver_timeout).map_err(|error| error.to_string())? {
            Some(status) => {
                driver_failed = !status.success();
                if driver_failed {
                    failure_summary.push_str(&format!("driver exited with status {status}\n"));
                }
            }
            None => {
                driver_failed = true;
                failure_summary.push_str(&format!(
                    "driver timed out after {} ms\n",
                    args.driver_timeout.as_millis()
                ));
                let _ = driver.kill();
                let _ = driver.wait();
            }
        }
    } else {
        game_status = wait_game_or_signal(&mut game, &stop).map_err(|error| error.to_string())?;
    }

    copy_if_exists(&args.protocol_file, &args.artifacts.join("protocol.json"));
    shutdown_game(&args.protocol_file, &transcript_file);
    if game_status.is_none() {
        game_status =
            wait_child(&mut game, args.shutdown_timeout).map_err(|error| error.to_string())?;
    }
    if game_status.is_none() {
        let _ = game.kill();
        game_status = game.wait().ok();
    }
    copy_captures(&capture_dir, &args.artifacts.join("screenshots"));

    let game_failed = game_status.as_ref().is_some_and(|status| !status.success());
    if game_failed && let Some(status) = &game_status {
        failure_summary.push_str(&format!("game exited with status {status}\n"));
    }
    if driver_failed || game_failed {
        return fail_run(&args.artifacts, &game_log, &capture_dir, failure_summary);
    }
    println!("bevy-feedback artifacts: {}", args.artifacts.display());
    Ok(())
}

#[derive(Debug, PartialEq, Eq)]
struct RunArgs {
    protocol_file: PathBuf,
    artifacts: PathBuf,
    ready_timeout: Duration,
    shutdown_timeout: Duration,
    driver_timeout: Duration,
    game: Vec<String>,
    driver: Option<Vec<String>>,
}

fn parse_args(args: &[String]) -> Result<RunArgs, String> {
    parse_args_with_env(args, |name| std::env::var_os(name))
}

fn parse_args_with_env(
    args: &[String],
    get_env: impl Fn(&str) -> Option<std::ffi::OsString>,
) -> Result<RunArgs, String> {
    if args.first().map(String::as_str) != Some("run") {
        return Err(usage());
    }
    let mut protocol_file = get_env("BEVY_FEEDBACK_PROTOCOL")
        .map(PathBuf::from)
        .unwrap_or_else(|| PathBuf::from("target/agent-feedback/agent-feedback.json"));
    let mut artifacts = get_env("BEVY_FEEDBACK_ARTIFACTS")
        .map(PathBuf::from)
        .unwrap_or_else(|| {
            PathBuf::from(format!("target/agent-feedback/artifacts/run-{}", unix_ms()))
        });
    let mut ready_timeout = default_timeout(
        "ready timeout",
        "BEVY_FEEDBACK_READY_TIMEOUT_MS",
        60_000,
        &get_env,
    )?;
    let mut driver_timeout = default_timeout(
        "driver timeout",
        "BEVY_FEEDBACK_DRIVER_TIMEOUT_MS",
        300_000,
        &get_env,
    )?;
    let mut shutdown_timeout = default_timeout(
        "shutdown timeout",
        "BEVY_FEEDBACK_SHUTDOWN_TIMEOUT_MS",
        5_000,
        &get_env,
    )?;
    let mut index = 1;
    while index < args.len() {
        match args[index].as_str() {
            "--protocol" => {
                index += 1;
                protocol_file = args.get(index).map(PathBuf::from).ok_or_else(usage)?;
                index += 1;
            }
            "--artifacts" => {
                index += 1;
                artifacts = args.get(index).map(PathBuf::from).ok_or_else(usage)?;
                index += 1;
            }
            "--ready-timeout" => {
                index += 1;
                let value = args.get(index).ok_or_else(usage)?;
                ready_timeout = parse_timeout_ms(value, "ready timeout")?;
                index += 1;
            }
            "--driver-timeout" => {
                index += 1;
                let value = args.get(index).ok_or_else(usage)?;
                driver_timeout = parse_timeout_ms(value, "driver timeout")?;
                index += 1;
            }
            "--shutdown-timeout" => {
                index += 1;
                let value = args.get(index).ok_or_else(usage)?;
                shutdown_timeout = parse_timeout_ms(value, "shutdown timeout")?;
                index += 1;
            }
            "--game" => {
                return parse_game_driver(
                    &args[index + 1..],
                    protocol_file,
                    artifacts,
                    ready_timeout,
                    shutdown_timeout,
                    driver_timeout,
                );
            }
            "--" => {
                let game = args[index + 1..].to_vec();
                if game.is_empty() {
                    return Err(usage());
                }
                return Ok(RunArgs {
                    protocol_file,
                    artifacts,
                    ready_timeout,
                    shutdown_timeout,
                    driver_timeout,
                    game,
                    driver: None,
                });
            }
            _ => return Err(usage()),
        }
    }
    Err(usage())
}

fn parse_timeout_ms(value: &str, name: &str) -> Result<Duration, String> {
    let milliseconds = value
        .parse::<u64>()
        .ok()
        .filter(|milliseconds| *milliseconds > 0)
        .ok_or_else(|| format!("{name} must be a positive integer number of milliseconds"))?;
    Ok(Duration::from_millis(milliseconds))
}

fn default_timeout(
    name: &str,
    env_name: &str,
    default_ms: u64,
    get_env: &impl Fn(&str) -> Option<std::ffi::OsString>,
) -> Result<Duration, String> {
    let Some(value) = get_env(env_name) else {
        return Ok(Duration::from_millis(default_ms));
    };
    let value = value
        .into_string()
        .map_err(|_| format!("{env_name} must be valid UTF-8"))?;
    parse_timeout_ms(&value, name)
}

fn parse_game_driver(
    args: &[String],
    protocol_file: PathBuf,
    artifacts: PathBuf,
    ready_timeout: Duration,
    shutdown_timeout: Duration,
    driver_timeout: Duration,
) -> Result<RunArgs, String> {
    let driver_index = args.iter().position(|arg| arg == "--driver");
    let (game, driver) = match driver_index {
        Some(index) => (&args[..index], Some(args[index + 1..].to_vec())),
        None => (args, None),
    };
    if game.is_empty() || driver.as_ref().is_some_and(Vec::is_empty) {
        return Err(usage());
    }
    Ok(RunArgs {
        protocol_file,
        artifacts,
        ready_timeout,
        shutdown_timeout,
        driver_timeout,
        game: game.to_vec(),
        driver,
    })
}

fn usage() -> String {
    "usage:
  bevy-feedback run [--protocol FILE] [--artifacts DIR] [--ready-timeout MS] [--driver-timeout MS] [--shutdown-timeout MS] -- <game command...>
  bevy-feedback run [--protocol FILE] [--artifacts DIR] [--ready-timeout MS] [--driver-timeout MS] [--shutdown-timeout MS] --game <game...> --driver <driver...>

env:
  BEVY_FEEDBACK_PROTOCOL            protocol file (default target/agent-feedback/agent-feedback.json)
  BEVY_FEEDBACK_ARTIFACTS           artifact dir (default target/agent-feedback/artifacts/run-<unix-ms>)
  BEVY_FEEDBACK_READY_TIMEOUT_MS    readiness timeout in milliseconds (default 60000)
  BEVY_FEEDBACK_DRIVER_TIMEOUT_MS   driver timeout in milliseconds (default 300000)
  BEVY_FEEDBACK_SHUTDOWN_TIMEOUT_MS shutdown timeout in milliseconds (default 5000)
  BEVY_FEEDBACK_CAPTURE_DIR         exported to game/driver as the capture dir
  BEVY_FEEDBACK_TRANSCRIPT          exported to game/driver as transcript.jsonl

timeouts:
  readiness 60s, driver 300s, shutdown 5s"
        .to_string()
}

fn spawn_command(
    command: &[String],
    args: &RunArgs,
    capture_dir: &Path,
    transcript_file: &Path,
    piped_logs: bool,
) -> Result<Child, String> {
    let mut child = Command::new(&command[0]);
    child
        .args(&command[1..])
        .env("BEVY_FEEDBACK_PROTOCOL", &args.protocol_file)
        .env("BEVY_FEEDBACK_CAPTURE_DIR", capture_dir)
        .env("BEVY_FEEDBACK_ARTIFACTS", &args.artifacts)
        .env("BEVY_FEEDBACK_TRANSCRIPT", transcript_file);
    if piped_logs {
        child.stdout(Stdio::piped()).stderr(Stdio::piped());
    }
    child
        .spawn()
        .map_err(|error| format!("spawn {:?}: {error}", command))
}

fn stream_child_logs(child: &mut Child, log_file: Arc<Mutex<File>>) {
    if let Some(stdout) = child.stdout.take() {
        stream_log(stdout, false, log_file.clone());
    }
    if let Some(stderr) = child.stderr.take() {
        stream_log(stderr, true, log_file);
    }
}

fn stream_log(pipe: impl Read + Send + 'static, stderr: bool, log_file: Arc<Mutex<File>>) {
    thread::spawn(move || {
        let mut reader = BufReader::new(pipe);
        let mut line = String::new();
        while reader.read_line(&mut line).unwrap_or(0) > 0 {
            if stderr {
                eprint!("{line}");
            } else {
                print!("{line}");
            }
            if let Ok(mut file) = log_file.lock() {
                let _ = file.write_all(line.as_bytes());
                let _ = file.flush();
            }
            line.clear();
        }
    });
}

#[derive(Debug)]
struct ReadyInfo {
    session_id: String,
    socket_addr: String,
}

fn wait_ready(
    protocol_file: &Path,
    timeout: Duration,
    game: &mut Child,
    stop: &AtomicBool,
) -> Result<ReadyInfo, String> {
    let start = Instant::now();
    while start.elapsed() < timeout && !stop.load(Ordering::Relaxed) {
        if let Some(status) = game.try_wait().map_err(|error| error.to_string())? {
            return Err(format!("game exited before protocol was ready: {status}"));
        }
        if protocol_file.exists() && AgentClient::connect(protocol_file).is_ok() {
            let protocol: Value = serde_json::from_slice(
                &fs::read(protocol_file).map_err(|error| error.to_string())?,
            )
            .map_err(|error| error.to_string())?;
            return Ok(ReadyInfo {
                session_id: protocol["session_id"]
                    .as_str()
                    .unwrap_or("unknown")
                    .to_string(),
                socket_addr: protocol["socket_addr"]
                    .as_str()
                    .unwrap_or("unknown")
                    .to_string(),
            });
        }
        thread::sleep(Duration::from_millis(100));
    }
    let _ = game.kill();
    Err(format!(
        "protocol was not ready within {} ms; increase with --ready-timeout MS or BEVY_FEEDBACK_READY_TIMEOUT_MS if the game is still compiling",
        timeout.as_millis()
    ))
}

fn wait_game_or_signal(game: &mut Child, stop: &AtomicBool) -> io::Result<Option<ExitStatus>> {
    while !stop.load(Ordering::Relaxed) {
        if let Some(status) = game.try_wait()? {
            return Ok(Some(status));
        }
        thread::sleep(Duration::from_millis(100));
    }
    Ok(None)
}

fn shutdown_game(protocol_file: &Path, transcript_file: &Path) {
    let config = AgentClientConfig {
        protocol_file: protocol_file.to_path_buf(),
        transcript_file: Some(transcript_file.to_path_buf()),
        timeout: Duration::from_secs(2),
        ..Default::default()
    };
    if let Ok(mut client) = AgentClient::with_config(config) {
        let _ = client.release_all_inputs();
        let _ = client.shutdown();
    }
}

fn wait_child(child: &mut Child, timeout: Duration) -> io::Result<Option<ExitStatus>> {
    let start = Instant::now();
    while start.elapsed() < timeout {
        if let Some(status) = child.try_wait()? {
            return Ok(Some(status));
        }
        thread::sleep(Duration::from_millis(100));
    }
    Ok(None)
}

fn fail_run(
    artifacts: &Path,
    game_log: &Path,
    capture_dir: &Path,
    mut failure_summary: String,
) -> Result<(), String> {
    append_failure_context(&mut failure_summary, game_log, capture_dir);
    fs::write(artifacts.join("failure-summary.txt"), &failure_summary)
        .map_err(|error| error.to_string())?;
    Err(format!(
        "run failed; artifacts: {}\n{}",
        artifacts.display(),
        failure_summary.trim_end()
    ))
}

fn append_failure_context(failure_summary: &mut String, game_log: &Path, capture_dir: &Path) {
    failure_summary.push_str(&format!("game log: {}\n", game_log.display()));
    if let Some(capture) = newest_png(capture_dir) {
        failure_summary.push_str(&format!("newest capture: {}\n", capture.display()));
    }
    if let Ok(lines) = tail_lines(game_log, 20)
        && !lines.is_empty()
    {
        failure_summary.push_str("last 20 game.log lines:\n");
        failure_summary.push_str(&lines);
        failure_summary.push('\n');
    }
}

fn tail_lines(path: &Path, max_lines: usize) -> io::Result<String> {
    let mut file = File::open(path)?;
    let length = file.metadata()?.len();
    file.seek(SeekFrom::Start(length.saturating_sub(64 * 1024)))?;
    let mut bytes = Vec::new();
    file.read_to_end(&mut bytes)?;
    let text = String::from_utf8_lossy(&bytes);
    let mut lines = text.lines().rev().take(max_lines).collect::<Vec<_>>();
    lines.reverse();
    Ok(lines.join("\n"))
}

fn newest_png(dir: &Path) -> Option<PathBuf> {
    let mut newest = None;
    for entry in fs::read_dir(dir).ok()?.flatten() {
        let path = entry.path();
        if path.extension().and_then(|extension| extension.to_str()) != Some("png") {
            continue;
        }
        let modified = entry
            .metadata()
            .and_then(|metadata| metadata.modified())
            .unwrap_or(UNIX_EPOCH);
        match &newest {
            Some((newest_modified, _)) if modified <= *newest_modified => {}
            _ => newest = Some((modified, path)),
        }
    }
    newest.map(|(_, path)| path)
}

fn copy_if_exists(from: &Path, to: &Path) {
    if from.exists() {
        let _ = fs::copy(from, to);
    }
}

fn copy_captures(from: &Path, to: &Path) {
    let Ok(entries) = fs::read_dir(from) else {
        return;
    };
    let _ = fs::create_dir_all(to);
    for entry in entries.flatten() {
        let path = entry.path();
        if path.extension().and_then(|extension| extension.to_str()) == Some("png")
            && let Some(file_name) = path.file_name()
        {
            let _ = fs::copy(&path, to.join(file_name));
        }
    }
}

fn unix_ms() -> u128 {
    SystemTime::now()
        .duration_since(UNIX_EPOCH)
        .unwrap_or_default()
        .as_millis()
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn parses_game_only_command() {
        let args = parse_args(&[
            "run".into(),
            "--".into(),
            "cargo".into(),
            "run".into(),
            "--example".into(),
            "minimal".into(),
        ])
        .expect("args");

        assert_eq!(args.game, ["cargo", "run", "--example", "minimal"]);
        assert_eq!(args.driver, None);
    }

    #[test]
    fn parses_game_and_driver_command() {
        let args = parse_args(&[
            "run".into(),
            "--protocol".into(),
            "target/agent.json".into(),
            "--game".into(),
            "cargo".into(),
            "run".into(),
            "--driver".into(),
            "python3".into(),
            "drive.py".into(),
        ])
        .expect("args");

        assert_eq!(args.protocol_file, PathBuf::from("target/agent.json"));
        assert_eq!(args.game, ["cargo", "run"]);
        assert_eq!(args.driver, Some(vec!["python3".into(), "drive.py".into()]));
    }

    #[test]
    fn parses_timeout_flags_for_game_only_command() {
        let args = parse_args(&[
            "run".into(),
            "--ready-timeout".into(),
            "120000".into(),
            "--driver-timeout".into(),
            "400000".into(),
            "--shutdown-timeout".into(),
            "9000".into(),
            "--".into(),
            "cargo".into(),
            "run".into(),
        ])
        .expect("args");

        assert_eq!(args.ready_timeout, Duration::from_millis(120_000));
        assert_eq!(args.driver_timeout, Duration::from_millis(400_000));
        assert_eq!(args.shutdown_timeout, Duration::from_millis(9_000));
    }

    #[test]
    fn parses_timeout_flags_for_game_and_driver_command() {
        let args = parse_args(&[
            "run".into(),
            "--ready-timeout".into(),
            "120000".into(),
            "--driver-timeout".into(),
            "400000".into(),
            "--shutdown-timeout".into(),
            "9000".into(),
            "--game".into(),
            "cargo".into(),
            "run".into(),
            "--driver".into(),
            "python3".into(),
            "drive.py".into(),
        ])
        .expect("args");

        assert_eq!(args.ready_timeout, Duration::from_millis(120_000));
        assert_eq!(args.driver_timeout, Duration::from_millis(400_000));
        assert_eq!(args.shutdown_timeout, Duration::from_millis(9_000));
        assert_eq!(args.game, ["cargo", "run"]);
        assert_eq!(args.driver, Some(vec!["python3".into(), "drive.py".into()]));
    }

    #[test]
    fn rejects_zero_timeout() {
        let error = parse_args(&[
            "run".into(),
            "--ready-timeout".into(),
            "0".into(),
            "--".into(),
            "cargo".into(),
            "run".into(),
        ])
        .expect_err("zero timeout should be rejected");

        assert!(error.contains("ready timeout must be a positive integer number of milliseconds"));
    }

    #[test]
    fn uses_timeout_env_defaults() {
        let args = parse_args_with_env(
            &["run".into(), "--".into(), "cargo".into(), "run".into()],
            |name| match name {
                "BEVY_FEEDBACK_READY_TIMEOUT_MS" => Some(std::ffi::OsString::from("120000")),
                "BEVY_FEEDBACK_DRIVER_TIMEOUT_MS" => Some(std::ffi::OsString::from("400000")),
                "BEVY_FEEDBACK_SHUTDOWN_TIMEOUT_MS" => Some(std::ffi::OsString::from("9000")),
                _ => None,
            },
        )
        .expect("args");

        assert_eq!(args.ready_timeout, Duration::from_millis(120_000));
        assert_eq!(args.driver_timeout, Duration::from_millis(400_000));
        assert_eq!(args.shutdown_timeout, Duration::from_millis(9_000));
    }
}