better-auth-api 1.0.0-alpha.5

Plugin implementations for better-auth
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
#![allow(
    clippy::expect_used,
    reason = "Fixture setup and response assertions require successful fallible construction."
)]
#![expect(
    clippy::unwrap_used,
    clippy::panic_in_result_fn,
    reason = "Native JWT contracts fail immediately when a complete fixture or verified payload is missing."
)]

use super::*;
use base64::{Engine as _, engine::general_purpose::URL_SAFE_NO_PAD};
use better_auth_core::{
    Jwk as StoredJwk, SchemaValue,
    store::{AuthStore, EphemeralStore, StatelessSchema},
};
use std::sync::{
    Arc,
    atomic::{AtomicUsize, Ordering},
};

fn key(algorithm: JwtAlgorithm) -> AuthResult<StoredJwk> {
    let private = algorithm.generate(2048).map_err(jose_error)?;
    Ok(StoredJwk {
        id: SchemaValue::from_field(17.0.into()),
        public_key: private
            .to_public_key()
            .map_err(jose_error)?
            .to_string()
            .into(),
        private_key: private.to_string().into(),
        created_at: better_auth_core::FieldDate::from(Utc::now()).into(),
        alg: Some(algorithm.name().to_owned()).into(),
        ..Default::default()
    })
}

#[test]
fn native_json_source_preserves_surrogates_without_repairing_invalid_escapes() -> AuthResult<()> {
    let valid = better_auth_core::Utf16String::from_units(vec![34, 0xd800, 34]);
    assert_eq!(
        keys::parse_json(&valid.into())?,
        better_auth_core::Utf16String::from_units(vec![0xd800]).into()
    );
    for source in [
        vec![34, 92, 0xd800, 34],
        vec![0xd800],
        vec![34, 92, 117, 0xd800, 34],
    ] {
        assert!(
            keys::parse_json(&better_auth_core::Utf16String::from_units(source).into()).is_err()
        );
    }
    Ok(())
}

async fn context(
    plugin: &JwtPlugin,
    rows: Vec<StoredJwk>,
) -> AuthResult<(Arc<AuthContext<StatelessSchema>>, Arc<AtomicUsize>)> {
    let mut config = crate::plugins::test_helpers::create_test_config();
    if plugin.config.session_cookie_cache {
        config.session.cookie_cache = Some(better_auth_core::config::CookieCacheConfig {
            enabled: Some(true),
            strategy: Some(better_auth_core::config::CookieCacheStrategy::Jwt),
            ..Default::default()
        });
    }
    let config = Arc::new(config);
    let store: Arc<dyn AuthStore<StatelessSchema>> = Arc::new(EphemeralStore::new(config.clone()));
    let mut model_fields = better_auth_core::plugin_runtime::ModelFields::default();
    let mut init =
        AuthInitContext::new(config.clone(), store.clone()).expect("fixture context initializes");
    better_auth_core::AuthPlugin::<better_auth_core::store::StatelessSchema>::schema(
        plugin,
        &mut model_fields,
    )?;
    plugin.on_init(&mut init).await?;
    let runtime = init.runtime();
    let parts = init.into_parts();
    let store = store.with_runtime(config.clone(), parts.database_hooks, model_fields)?;
    let mut context = AuthContext::new(config, store).expect("fixture context initializes");
    context.extensions = parts.extensions;
    let reads = Arc::new(AtomicUsize::new(0));
    let calls = reads.clone();
    context.extensions.insert(Arc::new(
        JwtCallbacks::<StatelessSchema>::default().get_jwks(move |_| {
            let rows = rows.clone();
            calls.fetch_add(1, Ordering::SeqCst);
            Box::pin(async move { Ok(Some(rows)) })
        }),
    ));
    let context = Arc::new(context);
    runtime.bind(&context)?;
    Ok((context, reads))
}

#[tokio::test]
async fn numeric_key_id_signs_and_verifies_without_weakening_header_or_signature_checks()
-> AuthResult<()> {
    let plugin = JwtPlugin::new().disable_private_key_encryption(true);
    let (ctx, _) = context(&plugin, vec![key(JwtAlgorithm::EdDsa)?]).await?;
    let payload = serde_json::from_value(json!({"sub":"owner"}))?;
    let token = plugin.sign(payload, &ctx).await?;
    assert_eq!(tests::header(&token)["kid"], 17.0);
    assert_eq!(
        plugin.verify(&token, None, &ctx).await?.unwrap()["sub"],
        "owner"
    );
    let (body, _) = token.rsplit_once('.').unwrap();
    assert!(
        plugin
            .verify(&format!("{body}.AA"), None, &ctx)
            .await?
            .is_none()
    );
    for header in [
        json!({"crit":["unsupported"],"unsupported":true}),
        json!({"crit":["b64"],"b64":false}),
        json!({"crit":["b64","b64"],"b64":true}),
        json!({"crit":["b64"]}),
    ] {
        let error = plugin
            .sign_with_options(
                Map::new(),
                &JwtSigningOptions {
                    header: serde_json::from_value(header)?,
                    ..Default::default()
                },
                &ctx,
            )
            .await;
        assert!(error.is_err());
    }
    let options = JwtSigningOptions {
        header: serde_json::from_value(json!({"b64":false}))?,
        ..Default::default()
    };
    let token = plugin
        .sign_with_options(
            serde_json::from_value(json!({"sub":"owner"}))?,
            &options,
            &ctx,
        )
        .await?;
    assert!(plugin.verify(&token, None, &ctx).await?.is_some());
    Ok(())
}

#[tokio::test]
async fn native_public_key_import_rejects_private_material() -> AuthResult<()> {
    let mut row = key(JwtAlgorithm::EdDsa)?;
    let plugin = JwtPlugin::new().disable_private_key_encryption(true);
    let (ctx, _) = context(&plugin, vec![row.clone()]).await?;
    let token = plugin
        .sign(serde_json::from_value(json!({"sub":"owner"}))?, &ctx)
        .await?;
    assert!(plugin.verify(&token, None, &ctx).await?.is_some());
    row.public_key = row.private_key.clone();
    let (ctx, reads) = context(&plugin, vec![row]).await?;
    assert!(plugin.verify(&token, None, &ctx).await?.is_none());
    assert_eq!(reads.load(Ordering::SeqCst), 1);
    Ok(())
}

#[tokio::test]
async fn native_header_values_retain_adapter_reads() -> AuthResult<()> {
    use better_auth_core::session::{SessionCookieContext, SessionCookieSigner};
    let plugin = JwtPlugin::new().session_cookie_cache(true);
    let (ctx, reads) = context(&plugin, vec![key(JwtAlgorithm::EdDsa)?]).await?;
    let request = AuthRequest::new(HttpMethod::Get, "/get-session");
    let verifier = ctx
        .extensions
        .get::<Arc<dyn SessionCookieSigner<StatelessSchema>>>()
        .unwrap();
    for source in [
        r#"{"alg":"EdDSA","typ":"better-auth.session-cache+jwt","kid":"missing","\ud800":7}"#,
        r#"{"alg":"EdDSA","typ":"better-auth.session-cache+jwt","kid":{"\ud800":7}}"#,
        r#"{"alg":"EdDSA","typ":"better-auth.session-cache+jwt","kid":1e309}"#,
        r#"{"alg":"EdDSA","typ":"better-auth.session-cache+jwt","kid":-1e309}"#,
    ] {
        let token = format!("{}.e30.AA", URL_SAFE_NO_PAD.encode(source));
        let before = reads.load(Ordering::SeqCst);
        assert!(plugin.verify(&token, None, &ctx).await?.is_none());
        assert_eq!(reads.load(Ordering::SeqCst), before + 1);
        assert!(
            verifier
                .verify(
                    &token,
                    SessionCookieContext {
                        request: &request,
                        config: &ctx.config,
                        transaction: None
                    }
                )
                .await?
                .is_none()
        );
        assert_eq!(reads.load(Ordering::SeqCst), before + 2);
    }
    Ok(())
}

#[tokio::test]
async fn cookie_verification_retains_its_decoder_and_original_protected_bytes() -> AuthResult<()> {
    use better_auth_core::session::{SessionCookieContext, SessionCookieSigner};
    let row = key(JwtAlgorithm::EdDsa)?;
    let private = Jwk::from_bytes(row.private_key.typed()?).map_err(jose_error)?;
    let signer = jws::EdDSA.signer_from_jwk(&private).map_err(jose_error)?;
    let plugin = JwtPlugin::new().session_cookie_cache(true);
    let (ctx, reads) = context(&plugin, vec![row]).await?;
    let request = AuthRequest::new(HttpMethod::Get, "/get-session");
    let verifier = ctx
        .extensions
        .get::<Arc<dyn SessionCookieSigner<StatelessSchema>>>()
        .unwrap();
    let cookie_context = || SessionCookieContext {
        request: &request,
        config: &ctx.config,
        transaction: None,
    };
    let header = URL_SAFE_NO_PAD
        .encode(r#"{"alg":"EdDSA","kid":17,"typ":"better-auth.session-cache+jwt","\ud800":7}"#);
    let now = Utc::now().timestamp();
    let payload = json!({"user":{"id":"owner"},"session":{"token":"session-token"},"sub":"owner","sid":"session-token","iss":ctx.config.base_url.as_static().unwrap(),"aud":"better-auth:session-cache","iat":now,"exp":now + 60});
    let input = format!(
        " \t{header} .{}",
        URL_SAFE_NO_PAD.encode(serde_json::to_vec(&payload)?)
    );
    let signature = URL_SAFE_NO_PAD.encode(signer.sign(input.as_bytes()).map_err(jose_error)?);
    let token = format!("{input}.{signature}");
    assert_eq!(
        verifier.verify(&token, cookie_context()).await?.unwrap(),
        payload.as_object().unwrap().clone()
    );
    assert_eq!(reads.load(Ordering::SeqCst), 1);
    let tampered = token.replace(" \t", "").replace(" .", ".");
    assert!(
        verifier
            .verify(&tampered, cookie_context())
            .await?
            .is_none()
    );
    assert_eq!(reads.load(Ordering::SeqCst), 2);
    assert!(plugin.verify(&token, None, &ctx).await?.is_none());
    assert_eq!(reads.load(Ordering::SeqCst), 2);
    Ok(())
}

#[tokio::test]
async fn discovery_spreads_native_public_payload_and_overwrites_kid_even_when_undefined()
-> AuthResult<()> {
    let plugin = JwtPlugin::new();
    let mut row = key(JwtAlgorithm::EdDsa)?;
    row.alg = SchemaValue::from_field(vec![FieldValue::from("native")].into());
    row.crv = SchemaValue::from_field(12.0.into());
    row.public_key = "{\"alg\":\"public-alg\",\"crv\":null,\"kid\":\"public-id\"}"
        .to_owned()
        .into();
    row.id = SchemaValue::Undefined;
    let mut primitive = row.clone();
    primitive.id = SchemaValue::from_field(19.0.into());
    primitive.public_key = "[\"public-entry\"]".to_owned().into();
    let (ctx, _) = context(&plugin, vec![row, primitive]).await?;
    let response = plugin
        .jwks(&EndpointContext::native(None, None, FieldValue::Null, &ctx))
        .await?;
    let body: Value = serde_json::from_slice(&response.body.bytes()?)?;
    assert_eq!(
        body,
        json!({"keys":[{"alg":"public-alg","crv":null},{"0":"public-entry","alg":["native"],"crv":12,"kid":19}]})
    );
    Ok(())
}

#[tokio::test]
async fn selection_filters_native_algorithm_before_dates_and_defers_single_row_created_at()
-> AuthResult<()> {
    let plugin = JwtPlugin::new().disable_private_key_encryption(true);
    let mut selected = key(JwtAlgorithm::EdDsa)?;
    selected.created_at = SchemaValue::from_field("not-a-date".into());
    selected.expires_at = SchemaValue::from_field("8640000000000000".into());
    let mut skipped = selected.clone();
    skipped.alg = SchemaValue::from_field(vec![FieldValue::from("EdDSA")].into());
    skipped.expires_at = SchemaValue::from_field(
        FieldMap::from([
            ("toString".into(), false.into()),
            ("valueOf".into(), false.into()),
        ])
        .into(),
    );
    let (ctx, reads) = context(&plugin, vec![skipped, selected.clone()]).await?;
    let token = plugin.sign(Map::new(), &ctx).await?;
    assert_eq!(tests::header(&token)["kid"], 17.0);
    assert_eq!(reads.load(Ordering::SeqCst), 1);
    let discovery = plugin
        .jwks(&EndpointContext::native(None, None, FieldValue::Null, &ctx))
        .await;
    assert!(
        matches!(discovery, Err(AuthError::TypeError(message)) if message == "key.expiresAt.getTime is not a function")
    );
    let mut second = selected.clone();
    second.created_at = better_auth_core::FieldDate::from(Utc::now()).into();
    let rows = [selected, second]
        .iter()
        .map(|key| better_auth_core::AuthRecordFields::field_values(key).map(FieldValue::from))
        .collect::<AuthResult<Vec<_>>>()?;
    assert!(
        keys::latest(
            rows.into(),
            Some("EdDSA".into()),
            "EdDSA".into(),
            (Utc::now().timestamp_millis() as f64).into()
        )
        .is_err()
    );
    Ok(())
}

#[tokio::test]
async fn native_algorithm_reaches_import_only_after_plain_or_encrypted_json_consumption()
-> AuthResult<()> {
    let mut row = key(JwtAlgorithm::EdDsa)?;
    row.alg = SchemaValue::from_field(vec![FieldValue::from("EdDSA")].into());
    row.crv = SchemaValue::from_field(FieldMap::new().into());
    let plugin = JwtPlugin::new().disable_private_key_encryption(true);
    let (ctx, reads) = context(&plugin, vec![row.clone()]).await?;
    let result = plugin.sign(Map::new(), &ctx).await;
    assert!(
        matches!(result, Err(AuthError::Internal(message)) if message == "Invalid or unsupported JWK \"alg\" (Algorithm) Parameter value")
    );
    assert_eq!(reads.load(Ordering::SeqCst), 2);
    for (private, decrypt_error) in [("invalid-json", false), ("null", true), ("17", true)] {
        row.private_key = private.to_owned().into();
        let plugin = JwtPlugin::new();
        let (ctx, _) = context(&plugin, vec![row.clone()]).await?;
        let error = plugin.sign(Map::new(), &ctx).await.unwrap_err();
        assert_eq!(
            error
                .instrumentation_message()?
                .contains("Failed to decrypt private key"),
            decrypt_error
        );
        if decrypt_error {
            assert_eq!(
                error.into_thrown_value()?.model_property("name")?,
                "BetterAuthError".into()
            );
        }
    }
    Ok(())
}

#[tokio::test]
async fn cookie_verification_uses_header_algorithm_only_when_configuration_and_row_omit_algorithm()
-> AuthResult<()> {
    use better_auth_core::session::{SessionCookieContext, SessionCookieSigner};
    let mut row = key(JwtAlgorithm::Es256)?;
    let plugin = JwtPlugin::new()
        .disable_private_key_encryption(true)
        .session_cookie_cache(true);
    let (signing_ctx, _) = context(&plugin, vec![row.clone()]).await?;
    let request = AuthRequest::new(HttpMethod::Get, "/get-session");
    let signer = signing_ctx
        .extensions
        .get::<Arc<dyn SessionCookieSigner<StatelessSchema>>>()
        .unwrap();
    let token = signer
        .sign(
            FieldMap::from_json(serde_json::from_value(
                json!({"user":{"id":"owner"},"session":{"token":"session-token"}}),
            )?)?,
            60.0,
            SessionCookieContext {
                request: &request,
                config: &signing_ctx.config,
                transaction: None,
            },
        )
        .await?;
    row.alg = SchemaValue::Undefined;
    for (configured, accepted) in [(None, true), (Some(JwtAlgorithm::EdDsa), false)] {
        let verify_plugin = JwtPlugin::with_config(JwtPluginConfig {
            algorithm: configured,
            session_cookie_cache: true,
            ..Default::default()
        });
        let (ctx, _) = context(&verify_plugin, vec![row.clone()]).await?;
        let verifier = ctx
            .extensions
            .get::<Arc<dyn SessionCookieSigner<StatelessSchema>>>()
            .unwrap();
        let verified = verifier
            .verify(
                &token,
                SessionCookieContext {
                    request: &request,
                    config: &ctx.config,
                    transaction: None,
                },
            )
            .await?;
        assert_eq!(verified.is_some(), accepted);
        assert!(verify_plugin.verify(&token, None, &ctx).await?.is_none());
    }
    Ok(())
}

#[path = "native_json_tests.rs"]
mod json_tests;

#[path = "native_date_tests.rs"]
mod date_tests;