bestool-alertd 6.0.0

(Internal) BES tooling: Alert daemon
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
use std::{
	collections::{HashMap, HashSet},
	path::PathBuf,
	sync::Arc,
	time::Duration,
};

use jiff::Timestamp;
use miette::Result;
use tokio::{
	sync::{Mutex, Notify, RwLock},
	task::JoinHandle,
	time::{interval, sleep},
};
use tracing::{debug, error, info, warn};

use crate::{
	EmailConfig, LogError,
	alert::{AlertDefinition, InternalContext, TicketSource},
	events::{EventContext, EventManager, EventType},
	glob_resolver::{GlobResolver, ResolvedPaths},
	loader::{LoadedAlerts, load_alerts_from_paths},
	metrics,
	state_file::{PersistedAlertState, PersistedState},
	targets::ResolvedTarget,
};

#[derive(Debug, Clone)]
pub struct AlertState {
	pub definition: AlertDefinition,
	pub resolved_targets: Vec<ResolvedTarget>,
	pub triggered_at: Option<Timestamp>,
	pub last_sent_at: Option<Timestamp>,
	pub last_output: Option<String>,
	pub paused_until: Option<Timestamp>,
	/// Was the last source read for this alert an error?
	///
	/// Used to detect the transition error → OK so a clearing canopy event
	/// can be sent for the source-error issue.
	pub source_was_erroring: bool,
}

impl AlertState {
	pub fn new(definition: AlertDefinition, resolved_targets: Vec<ResolvedTarget>) -> Self {
		Self {
			definition,
			resolved_targets,
			triggered_at: None,
			last_sent_at: None,
			last_output: None,
			paused_until: None,
			source_was_erroring: false,
		}
	}

	pub fn preserve_state_from(&mut self, old_state: &AlertState) {
		self.triggered_at = old_state.triggered_at;
		self.last_sent_at = old_state.last_sent_at;
		self.last_output = old_state.last_output.clone();
		self.paused_until = old_state.paused_until;
		self.source_was_erroring = old_state.source_was_erroring;
	}

	pub fn hydrate_from_persisted(&mut self, entry: &PersistedAlertState) {
		self.triggered_at = entry.triggered_at;
		self.last_sent_at = entry.last_sent_at;
		self.last_output = entry.last_output.clone();
		self.paused_until = entry.paused_until;
		self.source_was_erroring = entry.source_was_erroring;
	}

	pub fn to_persisted(&self) -> PersistedAlertState {
		PersistedAlertState {
			triggered_at: self.triggered_at,
			last_sent_at: self.last_sent_at,
			last_output: self.last_output.clone(),
			paused_until: self.paused_until,
			source_was_erroring: self.source_was_erroring,
		}
	}
}

pub struct Scheduler {
	glob_resolver: GlobResolver,
	resolved_paths: Arc<RwLock<ResolvedPaths>>,
	ctx: Arc<InternalContext>,
	email: Option<EmailConfig>,
	dry_run: bool,
	alerts: Arc<RwLock<HashMap<PathBuf, Arc<RwLock<AlertState>>>>>,
	tasks: Arc<RwLock<HashMap<PathBuf, JoinHandle<()>>>>,
	event_manager: Arc<RwLock<Option<EventManager>>>,
	external_targets:
		Arc<RwLock<std::collections::HashMap<String, Vec<crate::targets::ExternalTarget>>>>,
	state_dirty: Arc<Notify>,
	pending_hydration: Arc<Mutex<Option<PersistedState>>>,
	/// Files that errored during definition loading on the previous
	/// scheduling pass. Used to detect recovery so we can clear the
	/// corresponding canopy issue.
	last_definition_error_files: Arc<RwLock<HashSet<PathBuf>>>,
	/// Mirrors the daemon's database-down tracking.
	///
	/// Kept on the scheduler so it can be persisted in the state snapshot
	/// and restored on the next start — that way a recovery that happens
	/// while the daemon was down still produces a canopy clear.
	database_was_down: Arc<RwLock<bool>>,
	/// Configured Tamanu server kind, threaded into the loader so alerts
	/// whose `target:` doesn't match get dropped at load time.
	server_kind: Option<String>,
}

impl Scheduler {
	pub fn new(
		alert_globs: Vec<String>,
		ctx: Arc<InternalContext>,
		email: Option<EmailConfig>,
		dry_run: bool,
		server_kind: Option<String>,
	) -> Self {
		let glob_resolver = GlobResolver::new(alert_globs);
		Self {
			glob_resolver,
			resolved_paths: Arc::new(RwLock::new(ResolvedPaths {
				dirs: Vec::new(),
				files: Vec::new(),
			})),
			ctx,
			email,
			dry_run,
			alerts: Arc::new(RwLock::new(HashMap::new())),
			tasks: Arc::new(RwLock::new(HashMap::new())),
			event_manager: Arc::new(RwLock::new(None)),
			external_targets: Arc::new(RwLock::new(HashMap::new())),
			state_dirty: Arc::new(Notify::new()),
			pending_hydration: Arc::new(Mutex::new(None)),
			last_definition_error_files: Arc::new(RwLock::new(HashSet::new())),
			database_was_down: Arc::new(RwLock::new(false)),
			server_kind,
		}
	}

	/// Read the persisted database-down flag.
	pub async fn database_was_down(&self) -> bool {
		*self.database_was_down.read().await
	}

	/// Update the persisted database-down flag.
	pub async fn set_database_was_down(&self, value: bool) {
		*self.database_was_down.write().await = value;
		self.state_dirty.notify_one();
	}

	/// Handle used by the persistence task to wake when alert state changes.
	pub fn state_dirty(&self) -> Arc<Notify> {
		self.state_dirty.clone()
	}

	/// Seed the next `load_and_schedule_alerts` call with persisted state.
	///
	/// Consumed on the next load (cold start). Reload calls leave previously
	/// in-memory state in place via `preserve_state_from`, so hydration is a
	/// cold-start-only concern.
	pub async fn set_pending_hydration(&self, state: PersistedState) {
		*self.pending_hydration.lock().await = Some(state);
	}

	pub fn get_event_manager(&self) -> Arc<RwLock<Option<EventManager>>> {
		self.event_manager.clone()
	}

	pub async fn get_loaded_alerts(&self) -> Vec<PathBuf> {
		let alerts = self.alerts.read().await;
		let mut files: Vec<PathBuf> = alerts.keys().cloned().collect();
		files.sort();
		files
	}

	pub async fn get_alert_states(&self) -> HashMap<PathBuf, AlertState> {
		let alerts = self.alerts.read().await;
		let mut states = HashMap::new();
		for (path, state_lock) in alerts.iter() {
			let state = state_lock.read().await;
			states.insert(path.clone(), state.clone());
		}
		states
	}

	pub async fn pause_alert(&self, path: &PathBuf, until: Timestamp) -> Result<bool> {
		let alerts = self.alerts.read().await;
		if let Some(alert_state) = alerts.get(path) {
			let mut state = alert_state.write().await;
			state.paused_until = Some(until);
			info!(?path, until = %until, "paused alert");
			drop(state);
			self.state_dirty.notify_one();
			Ok(true)
		} else {
			Ok(false)
		}
	}

	/// Snapshot the in-memory state for serialisation by the persistence task.
	pub async fn snapshot_for_persistence(&self) -> PersistedState {
		let alerts = self.alerts.read().await;
		let mut out = HashMap::with_capacity(alerts.len());
		for (path, state_lock) in alerts.iter() {
			let state = state_lock.read().await;
			out.insert(path.clone(), state.to_persisted());
		}
		PersistedState {
			saved_at: Some(Timestamp::now()),
			alerts: out,
			database_was_down: *self.database_was_down.read().await,
			definition_error_files: self.last_definition_error_files.read().await.clone(),
		}
	}

	pub async fn get_external_targets(
		&self,
	) -> std::collections::HashMap<String, Vec<crate::targets::ExternalTarget>> {
		self.external_targets.read().await.clone()
	}

	pub async fn load_and_schedule_alerts(&self) -> Result<()> {
		info!("resolving glob patterns and loading alerts");

		// Consume any pending hydration first so subsequent code can rely on
		// hydrated daemon-level state (database_was_down, last definition
		// errors). Per-alert hydration happens later from the same value.
		let hydration = self.pending_hydration.lock().await.take();
		if let Some(ref h) = hydration {
			*self.database_was_down.write().await = h.database_was_down;
			*self.last_definition_error_files.write().await = h.definition_error_files.clone();
		}

		let resolved = self.glob_resolver.resolve()?;
		debug!(
			dirs = resolved.dirs.len(),
			files = resolved.files.len(),
			"resolved paths from globs"
		);

		let canopy_available = self.ctx.canopy_client.is_some();
		let LoadedAlerts {
			alerts,
			external_targets,
			definition_errors,
		} = load_alerts_from_paths(&resolved, canopy_available, self.server_kind.as_deref())?;

		// Update resolved paths
		*self.resolved_paths.write().await = resolved;

		// Separate event alerts from regular alerts
		let (event_alerts, regular_alerts): (Vec<_>, Vec<_>) = alerts
			.into_iter()
			.partition(|(alert, _)| matches!(alert.source, TicketSource::Event { .. }));

		// Store external targets
		*self.external_targets.write().await = external_targets.clone();

		// Create event manager with event alerts and external targets
		let event_manager = EventManager::new(event_alerts, &external_targets);
		*self.event_manager.write().await = Some(event_manager.clone());

		// Send definition error events for any failed alert loads
		if !definition_errors.is_empty() {
			info!(
				count = definition_errors.len(),
				"triggering definition-error events for failed alerts"
			);
		}
		let new_error_files: HashSet<PathBuf> =
			definition_errors.iter().map(|e| e.file.clone()).collect();
		for def_err in definition_errors {
			info!(
				file = %def_err.file.display(),
				"triggering definition-error event"
			);
			let entity_key = def_err.file.display().to_string();
			let event_context = EventContext::DefinitionError {
				alert_file: entity_key.clone(),
				error_message: def_err.error.clone(),
			};
			if let Err(err) = event_manager
				.trigger_event(
					EventType::DefinitionError,
					&self.ctx,
					self.email.as_ref(),
					self.dry_run,
					event_context,
					Some(&entity_key),
				)
				.await
			{
				error!(
					"failed to trigger definition-error event: {}",
					LogError(&err)
				);
			}
		}

		// Clear definition-error events for files that errored last time but
		// loaded cleanly this time.
		let mut last_def_errors = self.last_definition_error_files.write().await;
		for recovered in last_def_errors.difference(&new_error_files) {
			info!(
				file = %recovered.display(),
				"clearing definition-error event (file now loads cleanly)"
			);
			let entity_key = recovered.display().to_string();
			if let Err(err) = event_manager
				.trigger_clear(
					EventType::DefinitionError,
					&self.ctx,
					self.dry_run,
					Some(&entity_key),
				)
				.await
			{
				error!("failed to clear definition-error event: {}", LogError(&err));
			}
		}
		*last_def_errors = new_error_files;
		drop(last_def_errors);

		if regular_alerts.is_empty() {
			warn!("no regular alerts found");
			return Ok(());
		}

		info!(count = regular_alerts.len(), "scheduling regular alerts");

		// Get old alerts to preserve state across hot reload.
		let old_alerts = self.alerts.read().await.clone();

		// Hydration was taken at the top of this method; reuse it here for
		// per-alert state. On subsequent reloads it'll be None and
		// preserve_state_from carries in-memory state forward instead.
		let mut hydrated_count = 0usize;

		let mut new_alerts = HashMap::new();
		let mut tasks = HashMap::new();

		for (definition, resolved_targets) in regular_alerts {
			let file = definition.file.clone();

			// Create new alert state
			let mut new_state = AlertState::new(definition.clone(), resolved_targets.clone());

			if let Some(old_alert_lock) = old_alerts.get(&file) {
				let old_state = old_alert_lock.read().await;
				new_state.preserve_state_from(&old_state);
			} else if let Some(entry) = hydration.as_ref().and_then(|h| h.alerts.get(&file)) {
				new_state.hydrate_from_persisted(entry);
				hydrated_count += 1;
			}

			let state_lock = Arc::new(RwLock::new(new_state));
			let task = self.spawn_alert_task(state_lock.clone());

			new_alerts.insert(file.clone(), state_lock);
			tasks.insert(file, task);
		}

		if hydrated_count > 0 {
			info!(count = hydrated_count, "hydrated alert state from disk");
		}

		// Update alerts and tasks atomically
		*self.alerts.write().await = new_alerts;
		*self.tasks.write().await = tasks;

		// Update metrics with count of loaded alerts
		metrics::set_alerts_loaded(self.alerts.read().await.len());

		Ok(())
	}

	pub async fn execute_all_alerts_once(&self) -> Result<()> {
		info!("executing all alerts once");

		let resolved = self.glob_resolver.resolve()?;
		let canopy_available = self.ctx.canopy_client.is_some();
		let LoadedAlerts {
			alerts,
			external_targets,
			definition_errors,
		} = load_alerts_from_paths(&resolved, canopy_available, self.server_kind.as_deref())?;

		// Separate event alerts from regular alerts
		let (event_alerts, regular_alerts): (Vec<_>, Vec<_>) = alerts
			.into_iter()
			.partition(|(alert, _)| matches!(alert.source, TicketSource::Event { .. }));

		// Store external targets
		*self.external_targets.write().await = external_targets.clone();

		// Update event manager
		let event_manager = EventManager::new(event_alerts, &external_targets);
		*self.event_manager.write().await = Some(event_manager.clone());

		// Send definition error events for any failed alert loads
		if !definition_errors.is_empty() {
			info!(
				count = definition_errors.len(),
				"triggering definition-error events for failed alerts"
			);
		}
		for def_err in definition_errors {
			info!(
				file = %def_err.file.display(),
				"triggering definition-error event"
			);
			let entity_key = def_err.file.display().to_string();
			let event_context = EventContext::DefinitionError {
				alert_file: entity_key.clone(),
				error_message: def_err.error.clone(),
			};
			if let Err(err) = event_manager
				.trigger_event(
					EventType::DefinitionError,
					&self.ctx,
					self.email.as_ref(),
					self.dry_run,
					event_context,
					Some(&entity_key),
				)
				.await
			{
				error!(
					"failed to trigger definition-error event: {}",
					LogError(&err)
				);
			}
		}

		if regular_alerts.is_empty() {
			warn!("no regular alerts found");
			return Ok(());
		}

		info!(count = regular_alerts.len(), "executing alerts");

		for (alert, resolved_targets) in regular_alerts {
			let ctx = self.ctx.clone();
			let email = self.email.clone();
			let dry_run = self.dry_run;
			let file = alert.file.clone();

			debug!(?file, "executing alert");
			if let Err(err) = alert
				.execute(ctx, email.as_ref(), dry_run, &resolved_targets)
				.await
			{
				error!(?file, "error executing alert: {}", LogError(&err));
			}
		}

		Ok(())
	}

	pub async fn check_and_reload_if_paths_changed(&self) -> Result<()> {
		debug!("checking if resolved paths have changed");

		let new_resolved = self.glob_resolver.resolve()?;
		let old_resolved = self.resolved_paths.read().await;

		if new_resolved.differs_from(&old_resolved) {
			drop(old_resolved); // Release read lock before reloading
			info!("resolved paths have changed, reloading alerts");
			self.reload_alerts().await?;
		}

		Ok(())
	}

	pub async fn get_resolved_paths(&self) -> Vec<PathBuf> {
		let resolved = self.resolved_paths.read().await;
		resolved
			.all_paths()
			.iter()
			.map(|p| p.to_path_buf())
			.collect()
	}

	pub async fn reload_alerts(&self) -> Result<()> {
		info!("reloading alerts");

		// Cancel all existing tasks
		{
			let mut tasks = self.tasks.write().await;
			for (path, handle) in tasks.drain() {
				debug!(?path, "cancelling alert task");
				handle.abort();
			}
		}

		// Load and schedule new alerts
		self.load_and_schedule_alerts().await
	}

	fn spawn_alert_task(&self, alert_state: Arc<RwLock<AlertState>>) -> JoinHandle<()> {
		let ctx = self.ctx.clone();
		let email = self.email.clone();
		let dry_run = self.dry_run;
		let event_manager = self.event_manager.clone();
		let state_dirty = self.state_dirty.clone();

		tokio::spawn(async move {
			// Read initial values from state
			let (file, interval_duration) = {
				let state = alert_state.read().await;
				(
					state.definition.file.clone(),
					state.definition.interval_duration,
				)
			};
			debug!(?file, ?interval_duration, "starting alert task");

			// Add a small random delay to prevent all alerts from firing at exactly the same time
			let jitter = Duration::from_millis(rand::random::<u64>() % 5000);
			sleep(jitter).await;

			let mut ticker = interval(interval_duration);
			ticker.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip);

			loop {
				ticker.tick().await;
				metrics::record_activity();

				// Check if alert is paused
				let is_paused = {
					let state = alert_state.read().await;
					if let Some(until) = state.paused_until {
						let now = Timestamp::now();
						now < until
					} else {
						false
					}
				};

				if is_paused {
					debug!(?file, "alert is paused, skipping execution");
					continue;
				}

				debug!(?file, "executing alert");

				// Get alert definition and state
				let (
					alert,
					resolved_targets,
					was_triggered,
					was_source_erroring,
					always_send,
					when_changed,
				) = {
					let state = alert_state.read().await;
					(
						state.definition.clone(),
						state.resolved_targets.clone(),
						state.triggered_at.is_some(),
						state.source_was_erroring,
						state.definition.always_send.clone(),
						state.definition.when_changed.clone(),
					)
				};

				// Check the triggering state
				let now = jiff::Timestamp::now();
				let mut tera_ctx = crate::templates::build_context(&alert, now);
				let not_before = now - alert.interval_duration;

				let mut state_changed = false;

				let is_triggering = match alert
					.read_sources(&ctx.pg_pool, not_before, &mut tera_ctx, was_triggered)
					.await
				{
					Ok(flow) => {
						// Source recovered: clear the source-error canopy issue.
						if was_source_erroring {
							info!(?file, "source recovered, clearing source-error event");
							if let Some(ref event_mgr) = *event_manager.read().await {
								let entity_key = file.display().to_string();
								if let Err(event_err) = event_mgr
									.trigger_clear(
										EventType::SourceError,
										&ctx,
										dry_run,
										Some(&entity_key),
									)
									.await
								{
									error!(
										"failed to clear source_error event: {}",
										LogError(&event_err)
									);
								}
							}
							let mut state = alert_state.write().await;
							state.source_was_erroring = false;
							state_changed = true;
						}
						flow.is_continue()
					}
					Err(err) => {
						error!(?file, "error reading sources: {}", LogError(&err));
						metrics::inc_alerts_failed();

						// Trigger source_error event
						if let Some(ref event_mgr) = *event_manager.read().await {
							let entity_key = file.display().to_string();
							let event_context = EventContext::SourceError {
								alert_file: entity_key.clone(),
								error_message: format!("{err:?}"),
							};
							if let Err(event_err) = event_mgr
								.trigger_event(
									EventType::SourceError,
									&ctx,
									email.as_ref(),
									dry_run,
									event_context,
									Some(&entity_key),
								)
								.await
							{
								error!(
									"failed to trigger source_error event: {}",
									LogError(&event_err)
								);
							}
						}
						if !was_source_erroring {
							let mut state = alert_state.write().await;
							state.source_was_erroring = true;
							state_dirty.notify_one();
						}
						continue;
					}
				};

				if is_triggering {
					// Alert is in triggering state
					let mut state = alert_state.write().await;

					let mut should_send = match &always_send {
						crate::alert::AlwaysSend::Boolean(true) => true,
						crate::alert::AlwaysSend::Boolean(false) => !was_triggered,
						crate::alert::AlwaysSend::Timed(config) => {
							// Check if enough time has passed since last send
							match state.last_sent_at {
								Some(last_sent_time) => {
									let now = Timestamp::now();
									let elapsed = now.duration_since(last_sent_time);
									if let Ok(after_duration) =
										jiff::SignedDuration::try_from(config.after_duration)
									{
										elapsed >= after_duration
									} else {
										false
									}
								}
								None => true, // Never sent before, should send
							}
						}
					};

					// Check when-changed logic if configured
					if should_send
						&& !matches!(when_changed, crate::alert::WhenChanged::Boolean(false))
					{
						let current_digest =
							digest_context_for_comparison(&tera_ctx, &when_changed);

						let output_changed = match &state.last_output {
							Some(prev_digest) => prev_digest != &current_digest,
							None => true, // First run, consider it changed
						};

						if output_changed {
							debug!(?file, "output changed, will send");
							state.last_output = Some(current_digest);
							state_changed = true;
						} else {
							debug!(?file, "output unchanged, skipping");
							should_send = false;
						}
					}

					if should_send {
						debug!(?file, "alert triggered, sending notifications");

						// Send to targets
						for target in &resolved_targets {
							if let Err(err) = target
								.send(&alert, &mut tera_ctx, email.as_ref(), &ctx, dry_run)
								.await
							{
								error!("sending: {}", LogError(&err));
							}
						}

						metrics::inc_alerts_sent();

						// Update last sent timestamp
						state.last_sent_at = Some(Timestamp::now());
						state_changed = true;
					} else {
						debug!(?file, "alert still triggered, not sending (already sent)");
					}

					// Update the triggered timestamp even if we didn't send
					if !was_triggered {
						state.triggered_at = Some(Timestamp::now());
						state_changed = true;
					}
				} else {
					// Alert is not in triggering state
					if was_triggered {
						info!(?file, "alert is no longer triggering, sending clear");
						let all_cleared =
							send_clear_to_targets(&resolved_targets, &alert, &ctx, dry_run).await;
						if all_cleared {
							let mut state = alert_state.write().await;
							state.triggered_at = None;
							state.last_sent_at = None;

							// Clear last output when alert clears
							if !matches!(when_changed, crate::alert::WhenChanged::Boolean(false)) {
								state.last_output = None;
							}
							state_changed = true;
						} else {
							warn!(
								?file,
								"send_clear failed for one or more targets; will retry on next tick"
							);
						}
					}
				}

				if state_changed {
					state_dirty.notify_one();
				}
			}
		})
	}

	pub async fn shutdown(&self) {
		info!("shutting down scheduler");
		let mut tasks = self.tasks.write().await;
		for (path, handle) in tasks.drain() {
			debug!(?path, "cancelling alert task");
			handle.abort();
		}
	}
}

/// Compute a stable digest of the alert's row output for `when-changed`
/// comparison. Hashing rather than storing the serialised rows keeps state.json
/// from growing without bound when a high-cardinality SQL alert holds many rows.
fn digest_context_for_comparison(
	context: &tera::Context,
	when_changed: &crate::alert::WhenChanged,
) -> String {
	use crate::alert::WhenChanged;

	let rows = match context.get("rows") {
		Some(value) => value,
		None => return blake3_hex(b""),
	};

	let rows_array = match rows.as_array() {
		Some(arr) => arr,
		None => return blake3_hex(serde_json::to_string(rows).unwrap_or_default().as_bytes()),
	};

	match when_changed {
		WhenChanged::Boolean(true) => {
			blake3_hex(serde_json::to_string(rows).unwrap_or_default().as_bytes())
		}
		WhenChanged::Boolean(false) => blake3_hex(b""),
		WhenChanged::Detailed(config) => {
			let filtered_rows: Vec<serde_json::Map<String, serde_json::Value>> = rows_array
				.iter()
				.filter_map(|row| {
					let obj = row.as_object()?;
					let mut filtered = serde_json::Map::new();
					for (key, value) in obj {
						let include = if !config.only.is_empty() {
							config.only.contains(key)
						} else if !config.except.is_empty() {
							!config.except.contains(key)
						} else {
							true
						};
						if include {
							filtered.insert(key.clone(), value.clone());
						}
					}
					Some(filtered)
				})
				.collect();
			blake3_hex(
				serde_json::to_string(&filtered_rows)
					.unwrap_or_default()
					.as_bytes(),
			)
		}
	}
}

fn blake3_hex(bytes: &[u8]) -> String {
	blake3::hash(bytes).to_hex().to_string()
}

/// Send a clear notification to every resolved target.
///
/// Returns `true` if every target's `send_clear` succeeded; `false` if any
/// failed. Caller should leave `triggered_at` set when this returns `false`
/// so the next scheduler tick retries — otherwise a transient failure
/// (network blip, canopy 5xx, TLS handshake during cert rollover) silently
/// leaves stateful targets like canopy stuck on `active=true`.
async fn send_clear_to_targets(
	targets: &[ResolvedTarget],
	alert: &AlertDefinition,
	ctx: &InternalContext,
	dry_run: bool,
) -> bool {
	let mut all_ok = true;
	for target in targets {
		if let Err(err) = target.send_clear(alert, ctx, dry_run).await {
			error!("sending clear: {}", LogError(&err));
			all_ok = false;
		}
	}
	all_ok
}

#[cfg(test)]
mod tests {
	use super::*;
	use crate::{
		canopy::{DEFAULT_CANOPY_URL, Severity},
		targets::{CanopyConfig, TargetCanopy, TargetConnection, TargetEmail},
	};

	async fn test_internal_context() -> InternalContext {
		let db_url = std::env::var("DATABASE_URL").expect("DATABASE_URL must be set for tests");
		let pg_pool = bestool_postgres::pool::create_pool(&db_url, "bestool-alertd-test")
			.await
			.unwrap();
		InternalContext {
			pg_pool,
			http_client: reqwest::Client::new(),
			canopy_client: None,
		}
	}

	fn email_target() -> ResolvedTarget {
		ResolvedTarget {
			target_id: "ops".into(),
			subject: None,
			template: "body".into(),
			conn: TargetConnection::Email(TargetEmail {
				addresses: vec!["ops@example.com".into()],
			}),
		}
	}

	fn canopy_target() -> ResolvedTarget {
		ResolvedTarget {
			target_id: "default".into(),
			subject: None,
			template: "body".into(),
			conn: TargetConnection::Canopy(TargetCanopy {
				canopy: CanopyConfig {
					url: DEFAULT_CANOPY_URL.parse().unwrap(),
					source: "test".into(),
					severity: Some(Severity::Error),
				},
			}),
		}
	}

	fn test_alert() -> AlertDefinition {
		AlertDefinition {
			file: "test.yml".into(),
			..Default::default()
		}
	}

	#[tokio::test]
	async fn send_clear_to_targets_returns_true_for_non_stateful_only() {
		let ctx = test_internal_context().await;
		let targets = vec![email_target()];
		assert!(send_clear_to_targets(&targets, &test_alert(), &ctx, false).await);
	}

	#[tokio::test]
	async fn send_clear_to_targets_returns_false_when_canopy_lacks_client() {
		// Canopy target configured but ctx.canopy_client is None — send_clear
		// returns Err and the helper should report failure so the caller
		// leaves triggered_at set and retries on the next tick.
		let ctx = test_internal_context().await;
		let targets = vec![canopy_target()];
		assert!(!send_clear_to_targets(&targets, &test_alert(), &ctx, false).await);
	}

	#[tokio::test]
	async fn send_clear_to_targets_reports_failure_even_when_only_one_target_fails() {
		// Mixed bag: email (succeeds) + canopy with no client (fails).
		// Helper must return false so the scheduler keeps the alert in the
		// triggered state and retries.
		let ctx = test_internal_context().await;
		let targets = vec![email_target(), canopy_target()];
		assert!(!send_clear_to_targets(&targets, &test_alert(), &ctx, false).await);
	}

	#[tokio::test]
	async fn send_clear_to_targets_in_dry_run_succeeds_regardless_of_canopy_client() {
		// In dry-run mode, canopy never tries to use the missing client.
		let ctx = test_internal_context().await;
		let targets = vec![canopy_target()];
		assert!(send_clear_to_targets(&targets, &test_alert(), &ctx, true).await);
	}

	#[test]
	fn digest_is_stable_hex_length() {
		let mut ctx = tera::Context::new();
		ctx.insert("rows", &serde_json::json!([{"a": 1}]));
		let d = digest_context_for_comparison(&ctx, &crate::alert::WhenChanged::Boolean(true));
		assert_eq!(d.len(), 64, "blake3 hex digest should be 64 chars");
		assert!(d.chars().all(|c| c.is_ascii_hexdigit()));
	}

	#[test]
	fn digest_does_not_grow_with_row_count() {
		// A digest of one row and a digest of ten thousand rows should both
		// be the same fixed size — this is the whole point of hashing.
		let mut small = tera::Context::new();
		small.insert("rows", &serde_json::json!([{"a": 1}]));

		let big_rows: Vec<serde_json::Value> = (0..10_000)
			.map(|i| serde_json::json!({"a": i, "b": "padding-".repeat(8)}))
			.collect();
		let mut big = tera::Context::new();
		big.insert("rows", &serde_json::Value::Array(big_rows));

		let d_small =
			digest_context_for_comparison(&small, &crate::alert::WhenChanged::Boolean(true));
		let d_big = digest_context_for_comparison(&big, &crate::alert::WhenChanged::Boolean(true));
		assert_eq!(d_small.len(), d_big.len());
		assert_ne!(d_small, d_big);
	}

	#[test]
	fn digest_changes_when_rows_change() {
		let mut a = tera::Context::new();
		a.insert("rows", &serde_json::json!([{"x": 1}]));
		let mut b = tera::Context::new();
		b.insert("rows", &serde_json::json!([{"x": 2}]));
		assert_ne!(
			digest_context_for_comparison(&a, &crate::alert::WhenChanged::Boolean(true)),
			digest_context_for_comparison(&b, &crate::alert::WhenChanged::Boolean(true)),
		);
	}

	#[test]
	fn digest_only_filter_ignores_other_columns() {
		use crate::alert::{WhenChanged, WhenChangedConfig};
		let cfg = WhenChanged::Detailed(WhenChangedConfig {
			only: vec!["id".into()],
			except: Vec::new(),
		});

		let mut a = tera::Context::new();
		a.insert("rows", &serde_json::json!([{"id": 1, "noise": "x"}]));
		let mut b = tera::Context::new();
		b.insert("rows", &serde_json::json!([{"id": 1, "noise": "y"}]));

		assert_eq!(
			digest_context_for_comparison(&a, &cfg),
			digest_context_for_comparison(&b, &cfg),
			"changes to non-`only` columns should not change the digest"
		);
	}

	#[test]
	fn digest_except_filter_ignores_named_columns() {
		use crate::alert::{WhenChanged, WhenChangedConfig};
		let cfg = WhenChanged::Detailed(WhenChangedConfig {
			except: vec!["ts".into()],
			only: Vec::new(),
		});

		let mut a = tera::Context::new();
		a.insert("rows", &serde_json::json!([{"id": 1, "ts": "2026-01-01"}]));
		let mut b = tera::Context::new();
		b.insert("rows", &serde_json::json!([{"id": 1, "ts": "2026-02-01"}]));

		assert_eq!(
			digest_context_for_comparison(&a, &cfg),
			digest_context_for_comparison(&b, &cfg),
			"changes to excluded columns should not change the digest"
		);
	}
}