1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523
use std::{
fmt::{Debug, Display, Formatter},
ops::{Index, Range, RangeBounds},
};
use itertools::Itertools;
use crate::{utils, Bell, IncompatibleStages, InvalidRowError, Row, RowBuf, Stage};
use super::DbgRow;
/// A heap-allocated buffer of [`Row`]s which are required to have the same [`Stage`]. Collecting
/// [`Row`]s of the same [`Stage`] is nearly always what we want, and having a type to enforce this
/// is convenient.
///
/// Requiring matching [`Stage`]s has useful performance benefits too. These stem from the fact
/// that the [`Row`]s can simply be stored sequentially in one [`Vec`] without any indirection or
/// extra allocations. This is both more cache-friendly and uses less memory.
///
/// Additionally, having a linear memory layout makes `SameStageVec`s extremely amenable to SIMD
/// optimisations (which haven't yet been implemented). This would allow us to do common
/// operations (like permuting all the [`Row`]s or finding the path of a [`Bell`]) extremely
/// quickly. For example, SIMD can perform permutation at 16 bells per CPU cycle (or 32 on very
/// new CPUs).
///
/// # Example
///
/// ```
/// use bellframe::{RowBuf, SameStageVec, Stage};
///
/// // Create a new `SameStageVec` for 6-bell rows
/// let mut new_buffer = SameStageVec::new(Stage::MINOR);
/// // Add some nice rows
/// new_buffer.push(&RowBuf::rounds(Stage::MINOR));
/// new_buffer.push(&RowBuf::queens(Stage::MINOR));
/// new_buffer.push(&RowBuf::backrounds(Stage::MINOR));
/// // `new_buffer` now contains 3 rows
/// assert_eq!(new_buffer.len(), 3);
/// // The 3rd row is backrounds
/// assert!(new_buffer[2].is_backrounds());
/// ```
#[derive(Clone, PartialEq, Eq, Hash)]
pub struct SameStageVec {
/// A contiguous chunk of [`Bell`]s, containing all the [`Row`]s concatenated together. For
/// example, the start of a plain course of Cambridge Surprise Minor would be stored as
/// `123456214365124635216453261435624153621435...`
/// or, with spaces inserted between rows:
/// `123456 214365 124635 216453 261435 624153 621435 ...`
///
/// **Invariant**: Each [`Stage`]-aligned segment of `bells` must form a valid [`Row`]
/// according to the Framework (see [`Row`]'s docs). A sub-slice is [`Stage`]-aligned if its
/// length is `self.stage` and its start index is an integer multiple of `self.stage`.
///
/// **Invariant**: `self.bells.len()` is an integer multiple of `self.stage`.
bells: Vec<Bell>,
/// The [`Stage`] of all the [`Row`]s in this buffer.
stage: Stage,
}
impl SameStageVec {
//////////////////
// CONSTRUCTORS //
//////////////////
/// Creates a new `SameStageVec` containing no [`Row`]s, expecting to be given [`Row`]s of a
/// given [`Stage`].
#[inline]
pub fn new(stage: Stage) -> Self {
Self {
bells: Vec::new(),
stage,
}
}
/// Creates a new `SameStageVec` that can hold `capacity` [`Row`]s without re-allocating, and
/// all the [`Row`]s are expected to have a given [`Stage`].
///
/// # Panics
///
/// Panics if `Stage::ZERO` is passed.
#[inline]
pub fn with_capacity(stage: Stage, capacity: usize) -> Self {
Self {
bells: Vec::with_capacity(capacity * stage.num_bells()),
stage,
}
}
/// Creates a `SameStageVec` containing exactly one row, reusing the allocation from an
/// existing [`RowBuf`].
#[inline]
pub fn from_row_buf(row: RowBuf) -> Self {
let stage = row.stage();
// This unsafety is OK because `row.to_bell_vec()` generates a Vec containing only one
// `Row`, which is required to be valid by `RowBuf`'s invariants
unsafe { Self::from_bell_vec_unchecked(row.into_bell_vec(), stage) }
}
/// Parse a `SameStageVec` from a [`str`]ing, where each line is parsed into a [`Row`].
pub fn parse(s: &str) -> Result<Self, ParseError> {
// Create an iterator of (line_num, line) pairs, where `line_number` is indexed from 1
let mut line_iter = s.lines().enumerate().map(|(idx, v)| (idx + 1, v));
// Parse the first line before creating the `SameStageVec` (since we need to know upfront
// what the stage is going to be).
let (_one, first_line) = line_iter.next().unwrap(); // strings always contain at least one line
let first_row =
RowBuf::parse(first_line).map_err(|err| ParseError::InvalidRow { line_num: 1, err })?;
// Create a `SameStageVec`, which starts out containing the first row
let mut new_vec = SameStageVec::from_row_buf(first_row);
// Now parse the rest of the lines into the new `SameStageVec`
for (line_num, line) in line_iter {
// Parse the line into a Row, and fail if its either invalid or doesn't match the stage
let parsed_row =
RowBuf::parse(line).map_err(|err| ParseError::InvalidRow { line_num, err })?;
new_vec.push(&parsed_row).map_err(
|IncompatibleStages {
lhs_stage,
rhs_stage,
}| ParseError::IncompatibleStages {
line_num,
first_stage: lhs_stage,
different_stage: rhs_stage,
},
)?;
}
Ok(new_vec)
}
/// Creates a `SameStageVec` from a [`Vec`] of [`Bell`]s (containing the [`Row`]s concatenated
/// together), without checking that they correspond to valid [`Row`]s.
///
/// # Safety
///
/// This function is safe if `bells` is formed of a sequence of valid [`Row`]s (each of the
/// provided [`Stage`]) concatenated together.
#[inline]
pub unsafe fn from_bell_vec_unchecked(bells: Vec<Bell>, stage: Stage) -> Self {
Self { bells, stage }
}
//////////////////
// SIZE GETTERS //
//////////////////
/// The [`Stage`] of every [`Row`] in this `SameStageVec`.
#[inline]
pub fn stage(&self) -> Stage {
self.stage
}
/// Gets the number of [`Row`]s contained in this `SameStageVec`
#[inline]
pub fn len(&self) -> usize {
// In debug builds, check that `bells` contains a whole number of rows
debug_assert!(self.bells.len() % self.stage.num_bells() == 0);
// Calculate the length
self.bells.len() / self.stage.num_bells()
}
/// Returns `true` if this `SameStageVec` contains no [`Row`]s.
#[inline]
pub fn is_empty(&self) -> bool {
self.bells.is_empty()
}
/////////////////
// ROW GETTERS //
/////////////////
/// Gets a reference to the [`Row`] at a given `index`, or `None` if `index >= self.len()`.
pub fn get(&self, index: usize) -> Option<&Row> {
let bell_slice = self.bells.get(self.get_range_of_row(index))?;
// This unsafety is OK, because we uphold an invariant that each stage-aligned segment of
// `self.bells` is a valid `Row`
Some(unsafe { Row::from_slice_unchecked(bell_slice) })
}
/// Gets a mutable reference to the [`Row`] at a given `index`, or `None` if
/// `index >= self.len()`.
pub fn get_mut(&mut self, index: usize) -> Option<&mut Row> {
let range = self.get_range_of_row(index);
let bell_slice = self.bells.get_mut(range)?;
// This unsafety is OK, because we uphold an invariant that each stage-aligned segment of
// `self.bells` is a valid `Row`
Some(unsafe { Row::from_mut_slice_unchecked(bell_slice) })
}
/// Gets a reference to the first [`Row`], if it exists.
pub fn first(&self) -> Option<&Row> {
self.get(0)
}
/// Gets a mutable reference to the first [`Row`], if it exists.
pub fn first_mut(&mut self) -> Option<&mut Row> {
self.get_mut(0)
}
/// Gets a reference to the last [`Row`], if it exists.
pub fn last(&self) -> Option<&Row> {
self.get(self.len().checked_sub(1)?)
}
/// Gets a mutable reference to the last [`Row`], if it exists.
pub fn last_mut(&mut self) -> Option<&mut Row> {
self.get_mut(self.len().checked_sub(1)?)
}
/// Returns an [`Iterator`] over the [`Row`]s in this buffer.
#[inline]
pub fn iter(&self) -> Iter {
Iter {
// The invariant on `bells_left` follows because there is an identical invariant on
// `SameStageVec.bells`
bells_left: &self.bells,
stage: self.stage,
}
}
/// Returns a [`Vec`] containing the place of a [`Bell`] in each [`Row`] in this
/// `SameStageVec`. Returns `None` if the [`Bell`] exceeds the [`Stage`] of `self`.
pub fn path_of(&self, bell: Bell) -> Option<Vec<usize>> {
(bell.index() < self.stage().num_bells()).then(
// TODO: Write a vectorised routine for this
|| self.iter().map(|r| r.place_of(bell).unwrap()).collect_vec(),
)
}
////////////////
// OPERATIONS //
////////////////
/// Adds a new [`Row`] to the end of the buffer, checking that its [`Stage`] is as expected.
#[inline]
pub fn push(&mut self, row: &Row) -> Result<(), IncompatibleStages> {
IncompatibleStages::test_err(self.stage, row.stage())?;
self.bells.extend(row.bell_iter());
Ok(())
}
/// Removes the last [`Row`] from `self` and returning if it. Returns `None` if `self`
/// contains no elements.
#[inline]
pub fn pop(&mut self) -> Option<RowBuf> {
// Compute the index of the first `Bell` in the last `Row`, and return `None` if that index
// would be negative
let start_index = self.bells.len().checked_sub(self.stage.num_bells())?;
debug_assert_eq!(start_index % self.stage.num_bells(), 0);
// This unsafety is OK because we enforce an invariant that every stage-aligned segment of
// `self.bells` is a valid `Row`.
Some(unsafe { RowBuf::from_bell_iter_unchecked(self.bells.drain(start_index..)) })
}
/// Extends this buffer with the [`Row`]s yielded by an [`Iterator`]. If any of the [`Row`]s
/// cause a [`Stage`] mismatch, an error is returned and the buffer is left unchanged.
pub fn extend<T: AsRef<Row>>(
&mut self,
row_iter: impl IntoIterator<Item = T>,
) -> Result<(), IncompatibleStages> {
let num_bells_before_extend = self.bells.len(); // Used to revert the `Bell` slice
for r in row_iter.into_iter() {
let row = r.as_ref();
if let Err(e) = IncompatibleStages::test_err(self.stage, row.stage()) {
self.bells.drain(num_bells_before_extend..); // Remove the extra bells
return Err(e); // End the iteration
}
self.bells.extend(row.bell_iter());
}
Ok(())
}
/// Extend `self` with the [`Row`]s from `other`, returning an error if the [`Stage`]s don't
/// match. `x.extend_from_buf(y)` has the same effect as `x.extend(y)` (because
/// `&SameStageVec` implements [`IntoIterator`]) but `extend_from_buf` is faster since the
/// [`Stage`] comparison is only performed once.
#[inline]
pub fn extend_from_buf(&mut self, other: &Self) -> Result<(), IncompatibleStages> {
IncompatibleStages::test_err(self.stage, other.stage)?;
self.bells.extend(other.bells.iter().copied()); // Copy bells across in one go
Ok(())
}
/// Extend `self` with the [`Row`]s from another [`SameStageVec`], pre-multiplying them all by
/// a given [`Row`].
#[inline]
pub fn extend_transposed(
&mut self,
transposition: &Row,
other: &Self,
) -> Result<(), IncompatibleStages> {
self.extend_range_transposed(transposition, other, ..)
}
/// Extend `self` with the [`Row`]s from a region of another [`SameStageVec`], pre-multiplying
/// them all by a given [`Row`].
#[inline]
pub fn extend_range_transposed(
&mut self,
transposition: &Row,
other: &Self,
range: impl RangeBounds<usize>,
) -> Result<(), IncompatibleStages> {
IncompatibleStages::test_err(self.stage, transposition.stage())?;
// TODO: Write a vectorised routine for this
self.bells.extend(
other.bells[other.to_bell_range(range)]
.iter()
.map(|b| transposition[b.index()]),
);
Ok(())
}
/// Take a range of `self`, pre-multiply all the `Row`s and extend `self` with them.
#[inline]
pub fn extend_transposed_from_within(
&mut self,
range: impl RangeBounds<usize>,
transposition: &Row,
) -> Result<(), IncompatibleStages> {
IncompatibleStages::test_err(self.stage, transposition.stage())?;
// Copy the bells one-by-one, because otherwise we'd have to borrow `self.bells` twice and
// the borrow checker doesn't like that.
for i in self.to_bell_range(range) {
let transposed_bell = transposition[self.bells[i].index()];
self.bells.push(transposed_bell);
}
Ok(())
}
/// Pre-multiplies every [`Row`] in this `Block` in-place by another [`Row`].
#[deprecated(note = "Name is ambiguous; please use `pre_multiply` instead")]
pub fn permute(&mut self, lhs_row: &Row) -> Result<(), IncompatibleStages> {
self.pre_multiply(lhs_row)
}
/// Pre-multiplies every [`Row`] in this `Block` in-place by another [`Row`].
pub fn pre_multiply(&mut self, lhs_row: &Row) -> Result<(), IncompatibleStages> {
IncompatibleStages::test_err(lhs_row.stage(), self.stage())?;
// TODO: Write vectorised routine for this
for b in &mut self.bells {
// This function is safe because:
// - We know that `self.stage() == lhs_row.stage()`
// - Because of the `Row` invariants, `b.index() < self.stage()` for all `b` in
// `self.bells`
// => `b.index() < lhs_row.stage()` for every `b`
// => calling `get_bell_unchecked` is safe
*b = unsafe { lhs_row.get_bell_unchecked(b.index()) };
}
Ok(())
}
/// Creates a copy of `self`, where every [`Row`] has been pre-multiplied by another [`Row`].
pub fn pre_multiplied(&self, lhs_row: &Row) -> Result<Self, IncompatibleStages> {
let mut new_vec = Self::new(self.stage);
new_vec.extend_transposed(lhs_row, self)?;
Ok(new_vec)
}
/// Splits `self` into two `SameStageVec`s (`a` and `b`) where:
/// - `a.len() == index`, and
/// - `self == a.extend_from_buf(&b)` (i.e. no rows are created or destroyed)
pub fn split(self, index: usize) -> Option<(Self, Self)> {
let (left_bells, right_bells) =
utils::split_vec(self.bells, index * self.stage.num_bells())?;
Some((
// Both of these are safe because we split `self.bells` at an integer multiple of
// `self.stage`, thus preserving the row boundaries and upholding the invariants
unsafe { Self::from_bell_vec_unchecked(left_bells, self.stage) },
unsafe { Self::from_bell_vec_unchecked(right_bells, self.stage) },
))
}
//////////////////////
// HELPER FUNCTIONS //
//////////////////////
/// Converts a generic [`RangeBounds`] **over [`Row`]s** into a [`Range`] **over [`Bell`]s**
/// which explicitly refers to the same region of `self`.
#[allow(clippy::let_and_return)]
fn to_bell_range(&self, range: impl RangeBounds<usize>) -> Range<usize> {
let row_range = utils::clamp_range(range, self.len());
let bell_range =
row_range.start * self.stage.num_bells()..row_range.end * self.stage.num_bells();
bell_range
}
/// Gets the [`Range`] of `self.bells` which would contain the [`Row`] at a given `index`.
fn get_range_of_row(&self, index: usize) -> Range<usize> {
let s = self.stage.num_bells();
index * s..(index + 1) * s
}
}
impl Index<usize> for SameStageVec {
type Output = Row;
fn index(&self, index: usize) -> &Self::Output {
// This unsafety is fine, because we require that every stage-aligned chunk of bells forms
// a valid row according to the Framework
unsafe { Row::from_slice_unchecked(&self.bells[self.get_range_of_row(index)]) }
}
}
impl Debug for SameStageVec {
fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
let mut formatter = f.debug_tuple("SameStageVec");
for row in self {
formatter.field(&DbgRow(row)); // Only display the bells
}
formatter.finish()
}
}
impl<'v> IntoIterator for &'v SameStageVec {
type Item = &'v Row;
type IntoIter = Iter<'v>;
fn into_iter(self) -> Self::IntoIter {
self.iter()
}
}
/// An [`Iterator`] which yields [`Row`]s from a [`SameStageVec`]
#[derive(Debug, Clone)]
pub struct Iter<'v> {
/// Invariant: Just like [`SameStageVec`], every [`Stage`]-aligned segment of `bells_left` must
/// form a valid row according to the Framework.
bells_left: &'v [Bell],
stage: Stage,
}
impl<'v> Iterator for Iter<'v> {
type Item = &'v Row;
fn next(&mut self) -> Option<Self::Item> {
if self.bells_left.is_empty() {
return None;
}
// Remove the first `self.stage` elements from `self.bells_left`. Since we've removed
// `self.stage` items, this means that the stage-aligned segments haven't changed, so the
// invariant on `self.bells_left` is still satisfied.
let (next_row, future_rows) = self.bells_left.split_at(self.stage.num_bells());
self.bells_left = future_rows;
// This unsafety is OK because the invariant on `self.bells_left` requires that `next_row`
// (a stage-aligned segment of `self.bells_left`) forms a valid row according to the
// Framework.
Some(unsafe { Row::from_slice_unchecked(next_row) })
}
// PERF: Implement better routines for methods such as `nth`, etc. for which repeatedly calling
// `next()` is unnecessarily slow.
}
impl<'v> DoubleEndedIterator for Iter<'v> {
fn next_back(&mut self) -> Option<Self::Item> {
if self.bells_left.is_empty() {
return None;
}
// Remove the last `self.stage` elements from `self.bells_left`. Since we've removed
// `self.stage` items, this means that the stage-aligned segments haven't changed, so the
// invariant on `self.bells_left` is still satisfied.
let (future_rows, next_row) = self
.bells_left
.split_at(self.bells_left.len() - self.stage.num_bells());
self.bells_left = future_rows;
// This unsafety is OK because the invariant on `self.bells_left` requires that `next_row`
// (a stage-aligned segment of `self.bells_left`) forms a valid row according to the
// Framework.
Some(unsafe { Row::from_slice_unchecked(next_row) })
}
}
impl<'v> ExactSizeIterator for Iter<'v> {
#[inline]
fn len(&self) -> usize {
self.bells_left.len() / self.stage.num_bells()
}
}
/// The possible ways that [`SameStageVec::parse`] could fail
#[derive(Debug, Clone)]
pub enum ParseError {
ZeroStage,
InvalidRow {
line_num: usize,
err: InvalidRowError,
},
IncompatibleStages {
line_num: usize,
first_stage: Stage,
different_stage: Stage,
},
}
impl Display for ParseError {
fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
match self {
ParseError::ZeroStage => write!(f, "Can't make a `SameStageVec` with stage 0"),
ParseError::InvalidRow {
line_num: line,
err,
} => {
write!(f, "Error parsing row on line {}: {}", line, err)
}
ParseError::IncompatibleStages {
line_num: line,
first_stage,
different_stage,
} => {
write!(
f,
"Row on line {} has different stage ({}) to the first stage ({})",
line, different_stage, first_stage
)
}
}
}
}
impl std::error::Error for ParseError {}