behest-runtime 0.5.9

Async runtime kernel for the behest agent runtime
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
//! Adapters that wrap existing runtime traits as [`Component`]s.
//!
//! `behest` has many long-lived trait abstractions
//! (`ChatProvider`, `SessionStore`, etc.) that predate the
//! [`Component`] trait. To make them composable with the
//! [`ComponentRegistry`](super::registry::ComponentRegistry) without
//! forcing every existing implementation to provide a `Component::init`
//! method, this module provides ready-made wrapper factories that
//! take an already-constructed `Arc<T>` and expose it as a registered
//! component.
//!
//! These wrappers are the canonical M3 deliverable: the existing trait
//! surface stays unchanged, while the runtime becomes composable on
//! top.
//!
//! # Example
//!
//! ```no_run
//! use std::sync::Arc;
//! use behest_runtime::component_factory::ChatProviderComponent;
//! use behest_runtime::registry::ComponentRegistry;
//!
//! # async fn build(registry: &ComponentRegistry) {
//! // Caller-supplied provider, pre-constructed:
//! let provider: Arc<dyn behest_provider::ChatProvider> = todo!();
//! let factory = ChatProviderComponent::new("primary", provider);
//! // ... register with ComponentRegistry via register_factory().
//! # }
//! ```

#![allow(clippy::pedantic)]

use std::any::Any;
use std::fmt;
use std::sync::Arc;

use async_trait::async_trait;
use futures_util::future::BoxFuture;
use schemars::JsonSchema;
use serde::{Deserialize, Serialize};

use super::component::{AnyComponent, AnyComponentError, Component, ComponentContext};
use super::extension::ExtensionError;
use super::registry::{ComponentDescriptor, ComponentFactory, RegistryError};
use behest_provider::{ChatProvider, EmbeddingProvider};

/// Configuration for a chat provider component wrapper. Currently
/// unused; the wrapper takes a pre-constructed provider. Exists to
/// satisfy the [`Component::Config`] bound so the wrapper can be
/// registered in a [`ComponentRegistry`](super::registry::ComponentRegistry).
#[derive(Debug, Clone, Default, Serialize, Deserialize, JsonSchema)]
pub struct EmptyConfig;

/// Error type for wrapper components: lifecycle errors only, since
/// the wrapped provider was constructed externally.
#[derive(Debug, thiserror::Error)]
#[error("provider wrapper error: {0}")]
pub struct WrapperError(pub String);

impl WrapperError {
    /// Construct a wrapper error from a displayable value.
    #[must_use]
    pub fn new(msg: impl Into<String>) -> Self {
        Self(msg.into())
    }
}

/// A [`Component`] that wraps an existing [`ChatProvider`].
pub struct ChatProviderComponent {
    name: String,
    provider: Arc<dyn ChatProvider>,
}

impl ChatProviderComponent {
    /// Construct a wrapper around a pre-built chat provider.
    #[must_use]
    pub fn new(name: impl Into<String>, provider: Arc<dyn ChatProvider>) -> Self {
        Self {
            name: name.into(),
            provider,
        }
    }

    /// Borrow the inner provider.
    #[must_use]
    pub fn provider(&self) -> &Arc<dyn ChatProvider> {
        &self.provider
    }
}

impl fmt::Debug for ChatProviderComponent {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("ChatProviderComponent")
            .field("name", &self.name)
            .field("provider_id", &self.provider.id())
            .finish()
    }
}

#[async_trait]
impl Component for ChatProviderComponent {
    const NAME: &'static str = "ChatProviderComponent";
    type Config = EmptyConfig;
    type Error = WrapperError;

    async fn init(_cfg: &Self::Config, _ctx: &ComponentContext) -> Result<Self, Self::Error> {
        Err(WrapperError::new(
            "wrapper components must be constructed via new()",
        ))
    }

    async fn start(&self) -> Result<(), Self::Error> {
        Ok(())
    }

    async fn stop(&self) -> Result<(), Self::Error> {
        Ok(())
    }

    async fn health(&self) -> behest_core::health::HealthStatus {
        behest_core::health::HealthStatus::healthy()
    }
}

/// A [`Component`] that wraps an existing [`EmbeddingProvider`].
pub struct EmbeddingProviderComponent {
    name: String,
    provider: Arc<dyn EmbeddingProvider>,
}

impl EmbeddingProviderComponent {
    /// Construct a wrapper around a pre-built embedding provider.
    #[must_use]
    pub fn new(name: impl Into<String>, provider: Arc<dyn EmbeddingProvider>) -> Self {
        Self {
            name: name.into(),
            provider,
        }
    }

    /// Borrow the inner provider.
    #[must_use]
    pub fn provider(&self) -> &Arc<dyn EmbeddingProvider> {
        &self.provider
    }
}

impl fmt::Debug for EmbeddingProviderComponent {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("EmbeddingProviderComponent")
            .field("name", &self.name)
            .field("provider_id", &self.provider.id())
            .finish()
    }
}

#[async_trait]
impl Component for EmbeddingProviderComponent {
    const NAME: &'static str = "EmbeddingProviderComponent";
    type Config = EmptyConfig;
    type Error = WrapperError;

    async fn init(_cfg: &Self::Config, _ctx: &ComponentContext) -> Result<Self, Self::Error> {
        Err(WrapperError::new(
            "wrapper components must be constructed via new()",
        ))
    }

    async fn start(&self) -> Result<(), Self::Error> {
        Ok(())
    }

    async fn stop(&self) -> Result<(), Self::Error> {
        Ok(())
    }
}

/// [`AnyComponent`] adapter for [`ChatProviderComponent`].
pub struct ChatProviderAny {
    inner: Arc<ChatProviderComponent>,
}

impl ChatProviderAny {
    /// Wrap a [`ChatProviderComponent`] as a type-erased [`AnyComponent`].
    #[must_use]
    pub fn new(inner: Arc<ChatProviderComponent>) -> Self {
        Self { inner }
    }
}

#[async_trait]
impl AnyComponent for ChatProviderAny {
    fn name(&self) -> &'static str {
        ChatProviderComponent::NAME
    }

    fn as_any_arc(&self) -> Arc<dyn Any + Send + Sync> {
        self.inner.clone()
    }

    fn start(&self) -> BoxFuture<'_, Result<(), AnyComponentError>> {
        let name = self.inner.name.clone();
        let inner = self.inner.clone();
        Box::pin(async move {
            inner
                .start()
                .await
                .map_err(|e| AnyComponentError::Component {
                    name,
                    message: e.to_string(),
                })
        })
    }

    fn stop(&self) -> BoxFuture<'_, Result<(), AnyComponentError>> {
        let name = self.inner.name.clone();
        let inner = self.inner.clone();
        Box::pin(async move {
            inner
                .stop()
                .await
                .map_err(|e| AnyComponentError::Component {
                    name,
                    message: e.to_string(),
                })
        })
    }

    fn health(&self) -> BoxFuture<'_, behest_core::health::HealthStatus> {
        let inner = self.inner.clone();
        Box::pin(async move { inner.health().await })
    }

    fn pre_replace(&self) -> BoxFuture<'_, Result<(), AnyComponentError>> {
        let name = self.inner.name.clone();
        let inner = self.inner.clone();
        Box::pin(async move {
            inner
                .pre_replace_hook()
                .await
                .map_err(|e| AnyComponentError::Component {
                    name,
                    message: e.to_string(),
                })
        })
    }

    fn post_replace(&self) -> BoxFuture<'_, Result<(), AnyComponentError>> {
        let name = self.inner.name.clone();
        let inner = self.inner.clone();
        Box::pin(async move {
            inner
                .post_replace_hook()
                .await
                .map_err(|e| AnyComponentError::Component {
                    name,
                    message: e.to_string(),
                })
        })
    }
}

/// [`AnyComponent`] adapter for [`EmbeddingProviderComponent`].
pub struct EmbeddingProviderAny {
    inner: Arc<EmbeddingProviderComponent>,
}

impl EmbeddingProviderAny {
    /// Wrap an [`EmbeddingProviderComponent`] as a type-erased [`AnyComponent`].
    #[must_use]
    pub fn new(inner: Arc<EmbeddingProviderComponent>) -> Self {
        Self { inner }
    }
}

#[async_trait]
impl AnyComponent for EmbeddingProviderAny {
    fn name(&self) -> &'static str {
        EmbeddingProviderComponent::NAME
    }

    fn as_any_arc(&self) -> Arc<dyn Any + Send + Sync> {
        self.inner.clone()
    }

    fn start(&self) -> BoxFuture<'_, Result<(), AnyComponentError>> {
        let name = self.inner.name.clone();
        let inner = self.inner.clone();
        Box::pin(async move {
            inner
                .start()
                .await
                .map_err(|e| AnyComponentError::Component {
                    name,
                    message: e.to_string(),
                })
        })
    }

    fn stop(&self) -> BoxFuture<'_, Result<(), AnyComponentError>> {
        let name = self.inner.name.clone();
        let inner = self.inner.clone();
        Box::pin(async move {
            inner
                .stop()
                .await
                .map_err(|e| AnyComponentError::Component {
                    name,
                    message: e.to_string(),
                })
        })
    }

    fn health(&self) -> BoxFuture<'_, behest_core::health::HealthStatus> {
        let inner = self.inner.clone();
        Box::pin(async move { inner.health().await })
    }

    fn pre_replace(&self) -> BoxFuture<'_, Result<(), AnyComponentError>> {
        let name = self.inner.name.clone();
        let inner = self.inner.clone();
        Box::pin(async move {
            inner
                .pre_replace_hook()
                .await
                .map_err(|e| AnyComponentError::Component {
                    name,
                    message: e.to_string(),
                })
        })
    }

    fn post_replace(&self) -> BoxFuture<'_, Result<(), AnyComponentError>> {
        let name = self.inner.name.clone();
        let inner = self.inner.clone();
        Box::pin(async move {
            inner
                .post_replace_hook()
                .await
                .map_err(|e| AnyComponentError::Component {
                    name,
                    message: e.to_string(),
                })
        })
    }
}

/// Factory for [`ChatProviderComponent`] that takes a pre-built
/// `Arc<dyn ChatProvider>` and registers it under the given name.
pub struct ChatProviderFactory {
    descriptor: ComponentDescriptor,
    provider: Arc<dyn ChatProvider>,
}

impl ChatProviderFactory {
    /// Construct a factory. The `name` is the user-assigned instance
    /// name in the registry.
    #[must_use]
    pub fn new(name: impl Into<String>, provider: Arc<dyn ChatProvider>) -> Self {
        let name = name.into();
        let descriptor = ComponentDescriptor {
            name: name.clone(),
            depends_on: Vec::new(),
            config: serde_json::json!({}),
        };
        Self {
            descriptor,
            provider,
        }
    }
}

#[async_trait]
impl ComponentFactory for ChatProviderFactory {
    fn name(&self) -> &str {
        &self.descriptor.name
    }

    fn kind(&self) -> &'static str {
        ChatProviderComponent::NAME
    }

    fn depends_on(&self) -> Vec<String> {
        self.descriptor.depends_on.clone()
    }

    async fn build(
        self: Box<Self>,
        _config: serde_json::Value,
        _ctx: &ComponentContext,
    ) -> Result<Box<dyn AnyComponent>, RegistryError> {
        let inner = Arc::new(ChatProviderComponent::new(
            self.descriptor.name.clone(),
            self.provider,
        ));
        Ok(Box::new(ChatProviderAny::new(inner)))
    }
}

/// Factory for [`EmbeddingProviderComponent`].
pub struct EmbeddingProviderFactory {
    descriptor: ComponentDescriptor,
    provider: Arc<dyn EmbeddingProvider>,
}

impl EmbeddingProviderFactory {
    /// Construct a factory.
    #[must_use]
    pub fn new(name: impl Into<String>, provider: Arc<dyn EmbeddingProvider>) -> Self {
        let name = name.into();
        let descriptor = ComponentDescriptor {
            name: name.clone(),
            depends_on: Vec::new(),
            config: serde_json::json!({}),
        };
        Self {
            descriptor,
            provider,
        }
    }
}

#[async_trait]
impl ComponentFactory for EmbeddingProviderFactory {
    fn name(&self) -> &str {
        &self.descriptor.name
    }

    fn kind(&self) -> &'static str {
        EmbeddingProviderComponent::NAME
    }

    fn depends_on(&self) -> Vec<String> {
        self.descriptor.depends_on.clone()
    }

    async fn build(
        self: Box<Self>,
        _config: serde_json::Value,
        _ctx: &ComponentContext,
    ) -> Result<Box<dyn AnyComponent>, RegistryError> {
        let inner = Arc::new(EmbeddingProviderComponent::new(
            self.descriptor.name.clone(),
            self.provider,
        ));
        Ok(Box::new(EmbeddingProviderAny::new(inner)))
    }
}

/// Convenience: re-export a name-keyed error so callers don't have to
/// import [`ExtensionError`] separately.
pub type FactoryError = ExtensionError;

#[cfg(test)]
mod tests {
    use super::*;
    use crate::lifecycle::ShutdownToken;
    use crate::registry::ComponentRegistry;
    use async_trait::async_trait;
    use behest_core::error::ProviderError;
    use behest_core::health::HealthStatus;
    use behest_provider::{
        ChatRequest, ChatResponse, ChatStream, EmbeddingRequest, EmbeddingResponse, FinishReason,
        Message, ProviderCapabilities, ProviderId, ProviderResult, TokenUsage,
    };

    struct StubChat;
    #[async_trait]
    impl ChatProvider for StubChat {
        fn id(&self) -> ProviderId {
            ProviderId::new("stub")
        }
        fn capabilities(&self) -> ProviderCapabilities {
            ProviderCapabilities::default()
        }
        async fn complete(&self, _r: ChatRequest) -> ProviderResult<ChatResponse> {
            Ok(ChatResponse {
                provider: self.id(),
                model: behest_provider::ModelName::new("stub-model"),
                message: Message::user_text(""),
                finish_reason: FinishReason::Stop,
                usage: Some(TokenUsage::new(0, 0)),
                raw: None,
            })
        }
        async fn stream(&self, _r: ChatRequest) -> ProviderResult<ChatStream> {
            Err(ProviderError::Unsupported {
                provider: self.id(),
                feature: "stream".into(),
            })
        }
    }

    struct StubEmbedding;
    #[async_trait]
    impl EmbeddingProvider for StubEmbedding {
        fn id(&self) -> ProviderId {
            ProviderId::new("stub-emb")
        }
        fn capabilities(&self) -> ProviderCapabilities {
            ProviderCapabilities::default()
        }
        async fn embed(&self, _r: EmbeddingRequest) -> ProviderResult<EmbeddingResponse> {
            Ok(EmbeddingResponse {
                provider: self.id(),
                model: behest_provider::ModelName::new("stub-emb-model"),
                embeddings: Vec::new(),
                usage: None,
                raw: None,
            })
        }
    }

    #[tokio::test]
    async fn chat_provider_wrapper_registers_with_registry() {
        let registry = ComponentRegistry::new();
        let factory = ChatProviderFactory::new("primary", Arc::new(StubChat));
        registry
            .register_factory(
                ComponentDescriptor {
                    name: "primary".into(),
                    depends_on: Vec::new(),
                    config: serde_json::json!({}),
                },
                Box::new(factory),
            )
            .unwrap_or_else(|e| panic!("{e}"));
        registry.init_all().await.unwrap_or_else(|e| panic!("{e}"));
        registry.start_all().await.unwrap_or_else(|e| panic!("{e}"));
        let c = registry
            .get::<ChatProviderComponent>("primary")
            .unwrap_or_else(|e| panic!("{e}"));
        assert_eq!(c.name, "primary");
        assert_eq!(c.provider.id().as_str(), "stub");
    }

    #[tokio::test]
    async fn embedding_provider_wrapper_registers_with_registry() {
        let registry = ComponentRegistry::new();
        let factory = EmbeddingProviderFactory::new("primary", Arc::new(StubEmbedding));
        registry
            .register_factory(
                ComponentDescriptor {
                    name: "primary".into(),
                    depends_on: Vec::new(),
                    config: serde_json::json!({}),
                },
                Box::new(factory),
            )
            .unwrap_or_else(|e| panic!("{e}"));
        registry.init_all().await.unwrap_or_else(|e| panic!("{e}"));
        let c = registry
            .get::<EmbeddingProviderComponent>("primary")
            .unwrap_or_else(|e| panic!("{e}"));
        assert_eq!(c.name, "primary");
    }

    #[tokio::test]
    async fn chat_provider_init_returns_wrapper_error() {
        let shutdown = ShutdownToken::new();
        let ctx = ComponentContext::new(shutdown);
        let cfg = EmptyConfig;
        let result = ChatProviderComponent::init(&cfg, &ctx).await;
        assert!(result.is_err());
    }

    #[tokio::test]
    async fn default_lifecycle_is_noop_for_provider_wrappers() {
        let c = ChatProviderComponent::new("x", Arc::new(StubChat));
        let _ = c.start().await;
        let _ = c.stop().await;
        let h = c.health().await;
        assert_eq!(h, HealthStatus::healthy());
    }
}