bazaar 3.5.2

Rust implementation of the Bazaar formats and protocols
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
//! Pure-logic heuristics from `_LazyGroupContentManager` and
//! `_GCGraphIndex`.
//!
//! These functions decide whether a groupcompress block needs repacking and
//! whether it is "well utilized" enough to leave alone. The corresponding
//! Python lives in `bzrformats.groupcompress._LazyGroupContentManager`.

/// Result of [`check_rebuild_action`]: what to do with the block.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum RebuildAction {
    /// The block is dense enough to keep as-is.
    Keep,
    /// The referenced bytes are packed at the front, just trim the tail.
    Trim,
    /// The referenced bytes are scattered, rebuild the block from scratch.
    Rebuild,
}

/// Decide whether a block should be repacked given the byte ranges actually
/// referenced by its factories and the total uncompressed content length.
///
/// Returns `(action, last_byte_used, total_bytes_used)`. Mirrors Python's
/// `_LazyGroupContentManager._check_rebuild_action`.
pub fn check_rebuild_action(
    factories: &[(usize, usize)],
    content_length: usize,
) -> (RebuildAction, usize, usize) {
    let mut total_bytes_used = 0;
    let mut last_byte_used = 0;
    for &(start, end) in factories {
        total_bytes_used += end - start;
        if last_byte_used < end {
            last_byte_used = end;
        }
    }
    if total_bytes_used * 2 >= content_length {
        return (RebuildAction::Keep, last_byte_used, total_bytes_used);
    }
    if total_bytes_used * 2 > last_byte_used {
        return (RebuildAction::Trim, last_byte_used, total_bytes_used);
    }
    (RebuildAction::Rebuild, last_byte_used, total_bytes_used)
}

/// Tunables for [`check_is_well_utilized`].
///
/// These mirror the class attributes on Python's `_LazyGroupContentManager`.
#[derive(Debug, Clone, Copy)]
pub struct WellUtilizedSettings {
    /// `_max_cut_fraction`: the smallest acceptable used-fraction of the block.
    pub max_cut_fraction: f64,
    /// `_full_enough_block_size`: blocks at or above this size are considered
    /// full regardless of content mix.
    pub full_enough_block_size: usize,
    /// `_full_enough_mixed_block_size`: blocks with mixed file-id content are
    /// considered full at this smaller threshold.
    pub full_enough_mixed_block_size: usize,
}

impl Default for WellUtilizedSettings {
    fn default() -> Self {
        Self {
            max_cut_fraction: 0.75,
            full_enough_block_size: 3 * 1024 * 1024,
            full_enough_mixed_block_size: 2 * 768 * 1024,
        }
    }
}

/// Decide whether a block is "well utilized" enough to leave intact during
/// pack-on-the-fly. Mirrors Python's `_LazyGroupContentManager.check_is_well_utilized`.
///
/// `factories` provides the `(start, end)` byte range and the file-id prefix
/// (everything but the last segment of the key tuple) for each record.
pub fn check_is_well_utilized<P: PartialEq>(
    factories: &[((usize, usize), P)],
    content_length: usize,
    settings: &WellUtilizedSettings,
) -> bool {
    if factories.len() == 1 {
        // A block of length 1 could always be improved by combining with
        // adjacent groups; the Python heuristic refuses to leave it alone.
        return false;
    }
    let positions: Vec<(usize, usize)> = factories.iter().map(|(p, _)| *p).collect();
    let (_action, _last, total_bytes_used) = check_rebuild_action(&positions, content_length);
    if (total_bytes_used as f64) < (content_length as f64) * settings.max_cut_fraction {
        return false;
    }
    if content_length >= settings.full_enough_block_size {
        return true;
    }
    // Mixed-prefix content gets a lower threshold.
    let mut common_prefix: Option<&P> = None;
    for (_, prefix) in factories {
        match common_prefix {
            None => common_prefix = Some(prefix),
            Some(cp) if cp != prefix => {
                return content_length >= settings.full_enough_mixed_block_size;
            }
            _ => {}
        }
    }
    false
}

/// Decoded `_GCGraphIndex._node_to_position` value: `start stop basis_end delta_end`.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub struct NodePosition {
    pub start: u64,
    pub stop: u64,
    pub basis_end: u64,
    pub delta_end: u64,
}

#[derive(Debug, PartialEq, Eq)]
pub enum NodePositionError {
    /// The value did not contain at least four space-separated integers.
    NotEnoughFields,
    /// One of the four integers could not be parsed.
    InvalidInteger,
}

impl std::fmt::Display for NodePositionError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            NodePositionError::NotEnoughFields => {
                write!(f, "node position needs four space-separated integers")
            }
            NodePositionError::InvalidInteger => {
                write!(f, "node position field is not a valid integer")
            }
        }
    }
}

impl std::error::Error for NodePositionError {}

/// Parse a `_GCGraphIndex` node value into its four position integers.
///
/// The node value is `b"start stop basis_end delta_end"` (any extra
/// whitespace-separated fields are ignored, mirroring Python's
/// `node[2].split(b" ")[:4]` behaviour).
pub fn parse_node_position(value: &[u8]) -> Result<NodePosition, NodePositionError> {
    let mut parts = value.split(|&b| b == b' ');
    let start = parts.next().ok_or(NodePositionError::NotEnoughFields)?;
    let stop = parts.next().ok_or(NodePositionError::NotEnoughFields)?;
    let basis_end = parts.next().ok_or(NodePositionError::NotEnoughFields)?;
    let delta_end = parts.next().ok_or(NodePositionError::NotEnoughFields)?;
    let parse = |b: &[u8]| -> Result<u64, NodePositionError> {
        std::str::from_utf8(b)
            .map_err(|_| NodePositionError::InvalidInteger)?
            .parse()
            .map_err(|_| NodePositionError::InvalidInteger)
    };
    Ok(NodePosition {
        start: parse(start)?,
        stop: parse(stop)?,
        basis_end: parse(basis_end)?,
        delta_end: parse(delta_end)?,
    })
}

/// Format the four positions an `_GCGraphIndex` entry stores as its
/// value field: `b"block_start block_length entry_start entry_end"`.
///
/// This is the writer side of the format that [`parse_node_position`]
/// reads back; the field names here reflect the write-time semantics
/// (a block offset + length + per-record byte range inside the block),
/// while [`NodePosition`]'s field names (`stop`, `basis_end`,
/// `delta_end`) reflect how `_node_to_position` historically named the
/// same four positional integers on read.
pub fn format_gc_node_value(
    block_start: u64,
    block_length: u64,
    entry_start: u64,
    entry_end: u64,
) -> Vec<u8> {
    format!(
        "{} {} {} {}",
        block_start, block_length, entry_start, entry_end
    )
    .into_bytes()
}

/// Per-record state held by [`LazyGroupContentManager`].
///
/// Mirrors the Python `_LazyGroupCompressFactory` attributes that affect the
/// state machine: the `(start, end)` byte range inside the underlying block,
/// an optional cached `sha1`, an optional `size`, optional cached extracted
/// `chunks`, and the `first` flag which controls the storage-kind reported
/// to consumers.
#[derive(Debug, Default, Clone)]
pub struct FactoryState {
    pub start: u64,
    pub end: u64,
    pub sha1: Option<String>,
    pub size: Option<usize>,
    pub chunks: Option<Vec<Vec<u8>>>,
    pub first: bool,
}

/// Trim `block` to its first `last_byte` bytes, returning a fresh block.
///
/// Mirrors `_LazyGroupContentManager._trim_block`. Factory offsets do not
/// need to be adjusted because the prefix is left in place.
pub fn trim_block(
    block: &mut crate::groupcompress::block::GroupCompressBlock,
    last_byte: usize,
) -> Result<crate::groupcompress::block::GroupCompressBlock, String> {
    block
        .ensure_content(Some(last_byte))
        .map_err(|e| e.to_string())?;
    let content = block.content().ok_or("block has no content")?;
    let trimmed = content[..last_byte].to_vec();
    let mut new = crate::groupcompress::block::GroupCompressBlock::new();
    new.set_content(&trimmed);
    Ok(new)
}

/// Extract one factory's chunks from `block`, populating the slot's
/// `chunks` cache.
pub fn extract_factory_chunks(
    block: &mut crate::groupcompress::block::GroupCompressBlock,
    factories: &mut [FactoryState],
    idx: usize,
) -> Result<Vec<Vec<u8>>, String> {
    if let Some(cached) = factories.get(idx).and_then(|f| f.chunks.clone()) {
        return Ok(cached);
    }
    let (start, end) = {
        let f = factories
            .get(idx)
            .ok_or_else(|| "factory index out of range".to_string())?;
        (f.start as usize, f.end as usize)
    };
    let chunks = block.extract(start, end).map_err(|e| format!("{:?}", e))?;
    if let Some(f) = factories.get_mut(idx) {
        f.chunks = Some(chunks.clone());
    }
    Ok(chunks)
}

/// Result of [`rebuild_block`].
pub struct RebuildResult {
    pub block: crate::groupcompress::block::GroupCompressBlock,
    pub last_byte: u64,
}

/// Walk every factory in order, repacking each into a fresh
/// `RabinGroupCompressor`. Updates each factory's `start`/`end`/`sha1` to
/// the new offsets and returns the freshly flushed block. Mirrors the body
/// of `_LazyGroupContentManager._rebuild_block`.
///
/// `keys` must hold one entry per factory, passed through unchanged so the
/// new block stores the real per-record key.
pub fn rebuild_block(
    block: &mut crate::groupcompress::block::GroupCompressBlock,
    factories: &mut [FactoryState],
    keys: &[Vec<Vec<u8>>],
    max_bytes_to_index: Option<usize>,
) -> Result<RebuildResult, String> {
    use crate::groupcompress::compressor::{GroupCompressor, RabinGroupCompressor};
    use crate::versionedfile::Key;

    if keys.len() != factories.len() {
        return Err(format!(
            "rebuild_block: expected {} keys, got {}",
            factories.len(),
            keys.len()
        ));
    }
    let mut compressor = RabinGroupCompressor::new(max_bytes_to_index);
    let mut end_point = 0usize;
    let factory_count = factories.len();
    for idx in 0..factory_count {
        let chunks = extract_factory_chunks(block, factories, idx)?;
        let chunks_len: usize = factories
            .get(idx)
            .and_then(|f| f.size)
            .unwrap_or_else(|| chunks.iter().map(|c| c.len()).sum::<usize>());
        let key = Key::Fixed(keys[idx].clone());
        let chunk_slices: Vec<&[u8]> = chunks.iter().map(|c| c.as_slice()).collect();
        let (sha1, start_point, new_end_point, _kind) = compressor
            .compress(&key, &chunk_slices, chunks_len, None, None, None)
            .map_err(|e| format!("compress error: {:?}", e))?;
        if let Some(f) = factories.get_mut(idx) {
            f.sha1 = Some(sha1);
            f.start = start_point as u64;
            f.end = new_end_point as u64;
            // The cached chunks are no longer relevant after a rebuild.
            f.chunks = None;
        }
        end_point = new_end_point;
    }
    let (chunks, endpoint) = compressor.flush();
    let mut new_block = crate::groupcompress::block::GroupCompressBlock::new();
    new_block.set_chunked_content(&chunks, endpoint);
    Ok(RebuildResult {
        block: new_block,
        last_byte: end_point as u64,
    })
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn keep_when_more_than_half_is_used() {
        let (action, last, total) = check_rebuild_action(&[(0, 60)], 100);
        assert_eq!(action, RebuildAction::Keep);
        assert_eq!(last, 60);
        assert_eq!(total, 60);
    }

    #[test]
    fn trim_when_used_bytes_are_at_the_front() {
        // 30 of 100 used, all at the front (last_byte = 30, total*2 > last).
        let (action, last, total) = check_rebuild_action(&[(0, 30)], 100);
        assert_eq!(action, RebuildAction::Trim);
        assert_eq!(last, 30);
        assert_eq!(total, 30);
    }

    #[test]
    fn rebuild_when_used_bytes_are_scattered() {
        // 10 of 100 used right at the end → not at the front.
        let (action, last, total) = check_rebuild_action(&[(90, 100)], 100);
        assert_eq!(action, RebuildAction::Rebuild);
        assert_eq!(last, 100);
        assert_eq!(total, 10);
    }

    #[test]
    fn keep_at_exactly_half() {
        // Exactly half: total*2 == content_length triggers Keep.
        let (action, _, _) = check_rebuild_action(&[(0, 50)], 100);
        assert_eq!(action, RebuildAction::Keep);
    }

    fn pos(start: usize, end: usize) -> ((usize, usize), &'static [u8]) {
        ((start, end), b"file-id".as_slice())
    }

    #[test]
    fn well_utilized_single_factory_is_never_well_utilized() {
        let factories = vec![pos(0, 100)];
        assert!(!check_is_well_utilized(
            &factories,
            100,
            &WellUtilizedSettings::default()
        ));
    }

    #[test]
    fn well_utilized_below_max_cut_fraction_is_not_well_utilized() {
        // 50% used, default cutoff 75% → not well utilized.
        let factories = vec![pos(0, 25), pos(25, 50)];
        assert!(!check_is_well_utilized(
            &factories,
            100,
            &WellUtilizedSettings::default()
        ));
    }

    #[test]
    fn well_utilized_full_enough_block_is_well_utilized() {
        // Block size is at the full_enough threshold; content fully used.
        let size = WellUtilizedSettings::default().full_enough_block_size;
        let factories = vec![pos(0, size / 2), pos(size / 2, size)];
        assert!(check_is_well_utilized(
            &factories,
            size,
            &WellUtilizedSettings::default()
        ));
    }

    #[test]
    fn well_utilized_mixed_content_uses_lower_threshold() {
        let settings = WellUtilizedSettings::default();
        let size = settings.full_enough_mixed_block_size;
        // Two factories with different file-id prefixes.
        let factories: Vec<((usize, usize), &[u8])> =
            vec![((0, size / 2), b"file-a"), ((size / 2, size), b"file-b")];
        assert!(check_is_well_utilized(&factories, size, &settings));
    }

    #[test]
    fn parse_node_position_decodes_four_fields() {
        let pos = parse_node_position(b"10 20 30 40").unwrap();
        assert_eq!(
            pos,
            NodePosition {
                start: 10,
                stop: 20,
                basis_end: 30,
                delta_end: 40,
            }
        );
    }

    #[test]
    fn parse_node_position_rejects_short_input() {
        assert_eq!(
            parse_node_position(b"10 20 30"),
            Err(NodePositionError::NotEnoughFields)
        );
    }

    #[test]
    fn parse_node_position_rejects_non_integer() {
        assert_eq!(
            parse_node_position(b"10 20 nope 40"),
            Err(NodePositionError::InvalidInteger)
        );
    }

    #[test]
    fn format_gc_node_value_roundtrips_through_parse_node_position() {
        let bytes = format_gc_node_value(100, 50, 7, 42);
        assert_eq!(bytes, b"100 50 7 42");
        let parsed = parse_node_position(&bytes).unwrap();
        // The reader-side field names are start/stop/basis_end/delta_end;
        // semantically they hold the four write-time integers in order.
        assert_eq!(parsed.start, 100);
        assert_eq!(parsed.stop, 50);
        assert_eq!(parsed.basis_end, 7);
        assert_eq!(parsed.delta_end, 42);
    }

    fn make_block_with_keys(
        keys: &[&[u8]],
    ) -> (
        crate::groupcompress::block::GroupCompressBlock,
        Vec<(usize, usize)>,
    ) {
        use crate::groupcompress::compressor::{GroupCompressor, RabinGroupCompressor};
        use crate::versionedfile::Key;
        let mut compressor = RabinGroupCompressor::new(None);
        let mut positions = Vec::new();
        for key_bytes in keys {
            let chunks: &[&[u8]] = &[*key_bytes];
            let length = key_bytes.len();
            let key = Key::Fixed(vec![key_bytes.to_vec()]);
            let (_sha, start, end, _kind) = compressor
                .compress(&key, chunks, length, None, None, None)
                .unwrap();
            positions.push((start, end));
        }
        let (chunks, endpoint) = compressor.flush();
        let mut block = crate::groupcompress::block::GroupCompressBlock::new();
        block.set_chunked_content(&chunks, endpoint);
        (block, positions)
    }

    fn make_factory_states(positions: &[(usize, usize)]) -> Vec<FactoryState> {
        positions
            .iter()
            .enumerate()
            .map(|(i, &(start, end))| FactoryState {
                start: start as u64,
                end: end as u64,
                first: i == 0,
                ..Default::default()
            })
            .collect()
    }

    #[test]
    fn extract_factory_chunks_round_trips_payload() {
        let (mut block, positions) = make_block_with_keys(&[b"payload\n"]);
        let mut factories = make_factory_states(&positions);
        let chunks = extract_factory_chunks(&mut block, &mut factories, 0).unwrap();
        let combined: Vec<u8> = chunks.into_iter().flatten().collect();
        assert_eq!(combined, b"payload\n");
        // Cached on the slot.
        assert!(factories[0].chunks.is_some());
    }

    #[test]
    fn rebuild_block_round_trips_factory_payloads() {
        let (mut block, positions) = make_block_with_keys(&[b"alpha\n", b"beta\n", b"gamma\n"]);
        let mut factories = make_factory_states(&positions);
        // Pretend only the first two factories survive: drop the last and
        // rebuild. The new block should still let us extract their content.
        factories.pop();
        let keys: Vec<Vec<Vec<u8>>> = vec![vec![b"alpha-key".to_vec()], vec![b"beta-key".to_vec()]];
        let result = rebuild_block(&mut block, &mut factories, &keys, None).unwrap();
        let mut new_block = result.block;

        let alpha = extract_factory_chunks(&mut new_block, &mut factories, 0).unwrap();
        let beta = extract_factory_chunks(&mut new_block, &mut factories, 1).unwrap();
        let alpha_combined: Vec<u8> = alpha.into_iter().flatten().collect();
        let beta_combined: Vec<u8> = beta.into_iter().flatten().collect();
        assert_eq!(alpha_combined, b"alpha\n");
        assert_eq!(beta_combined, b"beta\n");
    }

    #[test]
    fn trim_block_preserves_factory_offsets() {
        let (mut block, positions) = make_block_with_keys(&[b"first\n", b"second\n"]);
        let mut factories = make_factory_states(&positions);
        // Trim to just past the first factory. The first factory must still
        // extract correctly afterwards; the second one is now beyond the
        // block end and is irrelevant.
        let trim_to = positions[0].1;
        let mut trimmed = trim_block(&mut block, trim_to).unwrap();
        let chunks = extract_factory_chunks(&mut trimmed, &mut factories, 0).unwrap();
        let combined: Vec<u8> = chunks.into_iter().flatten().collect();
        assert_eq!(combined, b"first\n");
    }

    #[test]
    fn well_utilized_same_prefix_below_full_enough_is_not_well_utilized() {
        // Just under the single-prefix `full_enough` threshold: even though the
        // block is fully used, we expect the heuristic to return false because
        // it's still below the full size and not mixed.
        let settings = WellUtilizedSettings::default();
        let size = settings.full_enough_mixed_block_size; // < full_enough_block_size
        let factories = vec![pos(0, size / 2), pos(size / 2, size)];
        assert!(!check_is_well_utilized(&factories, size, &settings));
    }
}