batch-mode-batch-client 0.2.4

This crate provides a client for interacting with OpenAI's batch processing API, allowing you to manage and download batch files asynchronously. It offers functionality for managing batch statuses, uploading files, and retrieving results after batch processing.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
// ---------------- [ File: batch-mode-batch-client/src/check_and_download_output_and_error_online.rs ]
crate::ix!();

#[async_trait]
impl<E> CheckForAndDownloadOutputAndErrorOnline<E> for BatchFileTriple
where
    E: From<BatchDownloadError>
        + From<OpenAIClientError>
        + From<BatchMetadataError>
        + From<std::io::Error> 
        + Debug
        + Display,
{
    async fn check_for_and_download_output_and_error_online(
        &mut self,
        client: &dyn LanguageModelClientInterface<E>,
    ) -> Result<(), E> {
        trace!("Entered check_for_and_download_output_and_error_online.");
        info!("Checking for and downloading output/error files if available.");

        // If we are incomplete, or have a failure, check_batch_status_online returns an error.
        let status = match self.check_batch_status_online(client).await {
            Ok(s) => {
                debug!("Successfully retrieved batch status online.");
                s
            }
            Err(e) => {
                error!("Failed to retrieve batch status online. {e}");
                return Err(e);
            }
        };

        info!("Batch online status: {:?}", status);

        if status.output_file_available() {
            debug!("Output file is available; attempting to download...");
            if let Err(e) = self.download_output_file(client).await {
                error!("Failed to download output file. {e}");
                return Err(e);
            }
            debug!("Successfully downloaded output file.");
        } else {
            trace!("No output file available for download.");
        }

        if status.error_file_available() {
            debug!("Error file is available; attempting to download...");
            if let Err(e) = self.download_error_file(client).await {
                error!("Failed to download error file. {e}");
                return Err(e);
            }
            debug!("Successfully downloaded error file.");
        } else {
            trace!("No error file available for download.");
        }

        info!("Completed check_for_and_download_output_and_error_online successfully.");
        Ok(())
    }
}

#[cfg(test)]
mod check_for_and_download_output_and_error_online_tests {
    use super::*;
    use futures::executor::block_on;
    use std::fs;
    use tempfile::tempdir;
    use tracing::{debug, error, info, trace, warn};

    #[traced_test]
    async fn test_incomplete_batch_returns_error() {
        info!("Beginning test_incomplete_batch_returns_error");
        trace!("Constructing mock client for incomplete batch scenario...");
        let mock_client = MockLanguageModelClientBuilder::<MockBatchClientError>::default()
            .build()
            .unwrap();
        debug!("Mock client constructed: {:?}", mock_client);

        let batch_id = "batch_in_progress";
        trace!("Inserting mock batch with ID: {}", batch_id);
        {
            let mut guard = mock_client.batches().write().unwrap();
            guard.insert(
                batch_id.to_string(),
                Batch {
                    id: batch_id.to_string(),
                    object: "batch".to_string(),
                    endpoint: "/v1/chat/completions".to_string(),
                    errors: None,
                    input_file_id: "some_input_file".to_string(),
                    output_file_id: Some("some_output_file".to_string()),
                    completion_window: "24h".to_string(),
                    status: BatchStatus::InProgress,
                    error_file_id: None,
                    created_at: 0,
                    in_progress_at: None,
                    expires_at: None,
                    finalizing_at: None,
                    completed_at: None,
                    failed_at: None,
                    expired_at: None,
                    cancelling_at: None,
                    cancelled_at: None,
                    request_counts: None,
                    metadata: None,
                },
            );
        }
        debug!("Mock batch inserted with status: InProgress");

        trace!("Creating temp dir and saving metadata...");
        let tmp_dir = tempdir().unwrap();
        let metadata_path = tmp_dir.path().join("metadata.json");
        let metadata = BatchMetadataBuilder::default()
            .batch_id(batch_id.to_string())
            .input_file_id("some_input_file".to_string())
            .output_file_id("some_output_file".to_string())
            .error_file_id(None)
            .build()
            .unwrap();
        metadata.save_to_file(&metadata_path).await.unwrap();
        debug!("Metadata saved to {:?}", metadata_path);

        trace!("Constructing BatchFileTriple and calling check_for_and_download_output_and_error_online...");
        let mut triple = BatchFileTriple::new_for_test_with_metadata_path(metadata_path.clone());
        let result = triple
            .check_for_and_download_output_and_error_online(&mock_client)
            .await;
        debug!("Result from check call: {:?}", result);

        assert!(result.is_err(), "Should fail if batch is incomplete");
        info!("test_incomplete_batch_returns_error passed");
    }

    #[traced_test]
    async fn test_failed_batch_returns_error() {
        info!("Beginning test_failed_batch_returns_error");
        trace!("Constructing mock client for failed batch scenario...");
        let mock_client = MockLanguageModelClientBuilder::<MockBatchClientError>::default()
            .build()
            .unwrap();
        debug!("Mock client constructed: {:?}", mock_client);

        let batch_id = "batch_failed";
        trace!("Inserting mock batch with ID: {}", batch_id);
        {
            let mut guard = mock_client.batches().write().unwrap();
            guard.insert(
                batch_id.to_string(),
                Batch {
                    id: batch_id.to_string(),
                    object: "batch".to_string(),
                    endpoint: "/v1/chat/completions".to_string(),
                    errors: None,
                    input_file_id: "some_input_file".to_string(),
                    completion_window: "24h".to_string(),
                    status: BatchStatus::Failed,
                    output_file_id: Some("some_output_file".to_string()),
                    error_file_id: None,
                    created_at: 0,
                    in_progress_at: None,
                    expires_at: None,
                    finalizing_at: None,
                    completed_at: None,
                    failed_at: None,
                    expired_at: None,
                    cancelling_at: None,
                    cancelled_at: None,
                    request_counts: None,
                    metadata: None,
                },
            );
        }
        debug!("Mock batch inserted with status: Failed");

        trace!("Creating temp dir and saving metadata...");
        let tmp_dir = tempdir().unwrap();
        let metadata_path = tmp_dir.path().join("metadata.json");
        let metadata = BatchMetadataBuilder::default()
            .batch_id(batch_id.to_string())
            .input_file_id("some_input_file".to_string())
            .output_file_id("some_output_file".to_string())
            .error_file_id(None)
            .build()
            .unwrap();
        metadata.save_to_file(&metadata_path).await.unwrap();
        debug!("Metadata saved to {:?}", metadata_path);

        trace!("Constructing BatchFileTriple and calling check_for_and_download_output_and_error_online...");
        let mut triple = BatchFileTriple::new_for_test_with_metadata_path(metadata_path.clone());
        let result = triple
            .check_for_and_download_output_and_error_online(&mock_client)
            .await;
        debug!("Result from check call: {:?}", result);

        assert!(result.is_err(), "Should fail if batch status is Failed");
        info!("test_failed_batch_returns_error passed");
    }

    #[traced_test]
    async fn test_output_file_already_exists() {
        info!("Beginning test_output_file_already_exists");
        trace!("Constructing mock client for completed batch where output file already exists...");
        let mock_client = MockLanguageModelClientBuilder::<MockBatchClientError>::default()
            .build()
            .unwrap();
        debug!("Mock client constructed: {:?}", mock_client);

        let batch_id = "batch_completed_out_exists";
        let output_file_id = "mock_out_id_exists";
        trace!("Inserting mock batch with ID: {}", batch_id);
        {
            let mut guard = mock_client.batches().write().unwrap();
            guard.insert(
                batch_id.to_string(),
                Batch {
                    id: batch_id.to_string(),
                    object: "batch".to_string(),
                    endpoint: "/v1/chat/completions".to_string(),
                    errors: None,
                    input_file_id: "some_input_file".to_string(),
                    completion_window: "24h".to_string(),
                    status: BatchStatus::Completed,
                    output_file_id: Some(output_file_id.to_string()),
                    error_file_id: None,
                    created_at: 0,
                    in_progress_at: None,
                    expires_at: None,
                    finalizing_at: None,
                    completed_at: None,
                    failed_at: None,
                    expired_at: None,
                    cancelling_at: None,
                    cancelled_at: None,
                    request_counts: None,
                    metadata: None,
                },
            );
        }
        debug!("Mock batch inserted with status: Completed, output file ID: {}", output_file_id);

        trace!("Mocking file contents for output file: {}", output_file_id);
        {
            let mut files_guard = mock_client.files().write().unwrap();
            files_guard.insert(output_file_id.to_string(), Bytes::from("mock out data"));
        }

        trace!("Creating temp dir and saving metadata...");
        let tmp_dir = tempdir().unwrap();
        let metadata_path = tmp_dir.path().join("metadata.json");
        let metadata = BatchMetadataBuilder::default()
            .batch_id(batch_id.to_string())
            .input_file_id("some_input_file".to_string())
            .output_file_id(Some(output_file_id.to_string()))
            .error_file_id(None)
            .build()
            .unwrap();
        metadata.save_to_file(&metadata_path).await.unwrap();
        debug!("Metadata saved to {:?}", metadata_path);

        trace!("Constructing BatchFileTriple; simulating pre-existing output file...");
        let mut triple = BatchFileTriple::new_for_test_with_metadata_path(metadata_path.clone());
        let out_path = tmp_dir.path().join("output.json");
        fs::write(&out_path, b"Existing content").unwrap();
        triple.set_output_path(Some(out_path.clone()));
        debug!("Output file forcibly pre-created at {:?}", out_path);

        trace!("Calling check_for_and_download_output_and_error_online...");
        let result = triple
            .check_for_and_download_output_and_error_online(&mock_client)
            .await;
        debug!("Result from check call: {:?}", result);

        assert!(result.is_err(), "Should fail if output file already exists");
        info!("test_output_file_already_exists passed");
    }

    #[traced_test]
    async fn test_error_file_already_exists() {
        info!("Beginning test_error_file_already_exists");
        trace!("Constructing mock client for completed batch where error file already exists...");
        let mock_client = MockLanguageModelClientBuilder::<MockBatchClientError>::default()
            .build()
            .unwrap();
        debug!("Mock client constructed: {:?}", mock_client);

        let batch_id = "batch_completed_err_exists";
        let error_file_id = "mock_err_id_exists";
        trace!("Inserting mock batch with ID: {}", batch_id);
        {
            let mut guard = mock_client.batches().write().unwrap();
            guard.insert(
                batch_id.to_string(),
                Batch {
                    id: batch_id.to_string(),
                    object: "batch".to_string(),
                    endpoint: "/v1/chat/completions".to_string(),
                    errors: None,
                    input_file_id: "some_input_file".to_string(),
                    completion_window: "24h".to_string(),
                    status: BatchStatus::Completed,
                    output_file_id: Some("some_output_file".to_string()),
                    error_file_id: Some(error_file_id.to_string()),
                    created_at: 0,
                    in_progress_at: None,
                    expires_at: None,
                    finalizing_at: None,
                    completed_at: None,
                    failed_at: None,
                    expired_at: None,
                    cancelling_at: None,
                    cancelled_at: None,
                    request_counts: None,
                    metadata: None,
                },
            );
        }
        debug!(
            "Mock batch inserted with status: Completed, error file ID: {}",
            error_file_id
        );

        trace!("Mocking file contents for error file: {}", error_file_id);
        {
            let mut files_guard = mock_client.files().write().unwrap();
            files_guard.insert(error_file_id.to_string(), Bytes::from("mock err data"));
        }

        trace!("Creating temp dir and saving metadata...");
        let tmp_dir = tempdir().unwrap();
        let metadata_path = tmp_dir.path().join("metadata.json");
        let metadata = BatchMetadataBuilder::default()
            .batch_id(batch_id.to_string())
            .input_file_id("some_input_file".to_string())
            .output_file_id("some_output_file".to_string())
            .error_file_id(Some(error_file_id.to_string()))
            .build()
            .unwrap();
        metadata.save_to_file(&metadata_path).await.unwrap();
        debug!("Metadata saved to {:?}", metadata_path);

        trace!("Constructing BatchFileTriple; simulating pre-existing error file...");
        let mut triple = BatchFileTriple::new_for_test_with_metadata_path(metadata_path.clone());
        let err_path = tmp_dir.path().join("error.json");
        fs::write(&err_path, b"Existing error content").unwrap();
        triple.set_error_path(Some(err_path.clone()));
        debug!("Error file forcibly pre-created at {:?}", err_path);

        trace!("Calling check_for_and_download_output_and_error_online...");
        let result = triple
            .check_for_and_download_output_and_error_online(&mock_client)
            .await;
        debug!("Result from check call: {:?}", result);

        assert!(result.is_err(), "Should fail if error file already exists");
        info!("test_error_file_already_exists passed");
    }

    #[traced_test]
    async fn test_completed_no_output_no_error() {
        info!("Beginning test_completed_no_output_no_error");
        trace!("Constructing mock client for completed batch with no files...");
        let mock_client = MockLanguageModelClientBuilder::<MockBatchClientError>::default()
            .build()
            .unwrap();
        debug!("Mock client constructed: {:?}", mock_client);

        let batch_id = "batch_completed_no_files";
        trace!("Inserting mock batch with ID: {}", batch_id);
        {
            let mut guard = mock_client.batches().write().unwrap();
            guard.insert(
                batch_id.to_string(),
                Batch {
                    id: batch_id.to_string(),
                    object: "batch".to_string(),
                    endpoint: "/v1/chat/completions".to_string(),
                    errors: None,
                    input_file_id: "some_input_file".to_string(),
                    completion_window: "24h".to_string(),
                    status: BatchStatus::Completed,
                    output_file_id: None,
                    error_file_id: None,
                    created_at: 0,
                    in_progress_at: None,
                    expires_at: None,
                    finalizing_at: None,
                    completed_at: None,
                    failed_at: None,
                    expired_at: None,
                    cancelling_at: None,
                    cancelled_at: None,
                    request_counts: None,
                    metadata: None,
                },
            );
        }
        debug!("Mock batch inserted with status: Completed, no output/error files");

        trace!("Creating temp dir and saving metadata...");
        let tmp_dir = tempdir().unwrap();
        let metadata_path = tmp_dir.path().join("metadata.json");
        let metadata = BatchMetadataBuilder::default()
            .batch_id(batch_id.to_string())
            .input_file_id("some_input_file".to_string())
            .output_file_id(None)
            .error_file_id(None)
            .build()
            .unwrap();
        metadata.save_to_file(&metadata_path).await.unwrap();
        debug!("Metadata saved to {:?}", metadata_path);

        trace!("Constructing BatchFileTriple and ensuring we use the correct metadata path...");
        let mut triple = BatchFileTriple::new_for_test_with_metadata_path(metadata_path.clone());
        triple.set_metadata_path(Some(metadata_path.clone()));

        trace!("Calling check_for_and_download_output_and_error_online...");
        let result = triple
            .check_for_and_download_output_and_error_online(&mock_client)
            .await;
        debug!("Result from check call: {:?}", result);

        assert!(
            result.is_ok(),
            "Should succeed if batch is Completed with no output or error files"
        );
        info!("test_completed_no_output_no_error passed");
    }

    #[traced_test]
    async fn test_completed_with_output_only() {
        info!("Beginning test_completed_with_output_only");
        trace!("Constructing mock client for completed batch with output only...");
        let mock_client = MockLanguageModelClientBuilder::<MockBatchClientError>::default()
            .build()
            .unwrap();
        debug!("Mock client constructed: {:?}", mock_client);

        let batch_id = "batch_completed_output_only";
        {
            let mut guard = mock_client.batches().write().unwrap();
            guard.insert(
                batch_id.to_string(),
                Batch {
                    id: batch_id.to_string(),
                    object: "batch".to_string(),
                    endpoint: "/v1/chat/completions".to_string(),
                    errors: None,
                    input_file_id: "some_input_file".to_string(),
                    completion_window: "24h".to_string(),
                    status: BatchStatus::Completed,
                    output_file_id: Some("mock_output_file_id".to_string()),
                    error_file_id: None,
                    created_at: 0,
                    in_progress_at: None,
                    expires_at: None,
                    finalizing_at: None,
                    completed_at: None,
                    failed_at: None,
                    expired_at: None,
                    cancelling_at: None,
                    cancelled_at: None,
                    request_counts: None,
                    metadata: None,
                },
            );
        }
        debug!("Mock batch inserted with status: Completed, output only");

        trace!("Mocking file contents for output file: mock_output_file_id");
        {
            let mut files_guard = mock_client.files().write().unwrap();
            // The actual downloadable content:
            files_guard.insert("mock_output_file_id".to_string(), Bytes::from("mock output data"));
        }

        trace!("Creating temp dir and saving metadata...");
        let tmp_dir = tempdir().unwrap();
        let metadata_path = tmp_dir.path().join("metadata.json");
        let metadata = BatchMetadataBuilder::default()
            .batch_id(batch_id.to_string())
            .input_file_id("some_input_file".to_string())
            .output_file_id(Some("mock_output_file_id".into()))
            .error_file_id(None)
            .build()
            .unwrap();
        info!("Saving metadata at {:?}", metadata_path);
        metadata.save_to_file(&metadata_path).await.unwrap();
        debug!("Metadata saved to {:?}", metadata_path);

        trace!("Constructing BatchFileTriple and ensuring we use the correct metadata path...");
        let mut triple = BatchFileTriple::new_for_test_with_metadata_path(metadata_path.clone());
        triple.set_metadata_path(Some(metadata_path.clone()));

        // Put the output file into the temp dir
        let out_file_path = tmp_dir.path().join("downloaded_output.json");
        triple.set_output_path(Some(out_file_path.clone()));

        trace!("Calling check_for_and_download_output_and_error_online...");
        let result = triple
            .check_for_and_download_output_and_error_online(&mock_client)
            .await;
        debug!("Result from check call: {:?}", result);

        assert!(
            result.is_ok(),
            "Should succeed for completed batch with output only"
        );

        // Confirm the downloaded file has the new mock content
        let contents = fs::read_to_string(&out_file_path).unwrap();
        pretty_assert_eq!(contents, "mock output data");

        info!("test_completed_with_output_only passed");
    }

    #[traced_test]
    async fn test_completed_with_error_only() {
        info!("Beginning test_completed_with_error_only");
        trace!("Constructing mock client for completed batch with error only...");
        let mock_client = MockLanguageModelClientBuilder::<MockBatchClientError>::default()
            .build()
            .unwrap();
        debug!("Mock client constructed: {:?}", mock_client);

        let batch_id = "batch_completed_error_only";
        {
            let mut guard = mock_client.batches().write().unwrap();
            guard.insert(
                batch_id.to_string(),
                Batch {
                    id: batch_id.to_string(),
                    object: "batch".to_string(),
                    endpoint: "/v1/chat/completions".to_string(),
                    errors: None,
                    input_file_id: "some_input_file".to_string(),
                    completion_window: "24h".to_string(),
                    status: BatchStatus::Completed,
                    output_file_id: None,
                    error_file_id: Some("mock_error_file_id".to_string()),
                    created_at: 0,
                    in_progress_at: None,
                    expires_at: None,
                    finalizing_at: None,
                    completed_at: None,
                    failed_at: None,
                    expired_at: None,
                    cancelling_at: None,
                    cancelled_at: None,
                    request_counts: None,
                    metadata: None,
                },
            );
        }
        debug!("Mock batch inserted with status: Completed, error only");

        trace!("Mocking file contents for error file: mock_error_file_id");
        {
            let mut files_guard = mock_client.files().write().unwrap();
            files_guard.insert("mock_error_file_id".to_string(), Bytes::from("mock error data"));
        }

        trace!("Creating temp dir and saving metadata...");
        let tmp_dir = tempfile::tempdir().unwrap(); // unique folder for this test
        let metadata_path = tmp_dir.path().join("metadata.json");
        let metadata = BatchMetadataBuilder::default()
            .batch_id(batch_id.to_string())
            .input_file_id("some_input_file".to_string())
            .output_file_id(None)
            .error_file_id(Some("mock_error_file_id".to_string()))
            .build()
            .unwrap();
        info!("Saving metadata at {:?}", metadata_path);
        metadata.save_to_file(&metadata_path).await.unwrap();
        debug!("Metadata saved to {:?}", metadata_path);

        // Create the triple referencing that metadata.
        let mut triple = BatchFileTriple::new_for_test_with_metadata_path(metadata_path.clone());
        triple.set_metadata_path(Some(metadata_path.clone()));

        // Put the error file into the temp dir
        let error_file_path = tmp_dir.path().join("downloaded_error.json");
        triple.set_error_path(Some(error_file_path.clone()));

        trace!("Calling check_for_and_download_output_and_error_online...");
        let result = triple
            .check_for_and_download_output_and_error_online(&mock_client)
            .await;
        debug!("Result from check call: {:?}", result);

        assert!(result.is_ok(), "Should succeed for completed batch with error only");

        // Now read the file from the unique path in the temp dir
        let contents = fs::read_to_string(&error_file_path)
            .expect("Failed to read downloaded error file");
        pretty_assert_eq!(contents, "mock error data");

        info!("test_completed_with_error_only passed");
    }

    #[traced_test]
    async fn test_completed_with_both_output_and_error() {
        info!("Beginning test_completed_with_both_output_and_error");
        trace!("Constructing mock client for completed batch with both output and error...");
        let mock_client = MockLanguageModelClientBuilder::<MockBatchClientError>::default()
            .build()
            .unwrap();
        debug!("Mock client constructed: {:?}", mock_client);

        let batch_id = "batch_completed_both";
        let output_file_id = "mock_out_id";
        let error_file_id  = "mock_err_id";
        trace!("Inserting mock batch with ID: {}", batch_id);

        {
            let mut guard = mock_client.batches().write().unwrap();
            guard.insert(
                batch_id.to_string(),
                Batch {
                    id: batch_id.to_string(),
                    object: "batch".to_string(),
                    endpoint: "/v1/chat/completions".to_string(),
                    errors: None,
                    input_file_id: "some_input_file".to_string(),
                    completion_window: "24h".to_string(),
                    status: BatchStatus::Completed,
                    output_file_id: Some(output_file_id.to_string()),
                    error_file_id: Some(error_file_id.to_string()),
                    created_at: 0,
                    in_progress_at: None,
                    expires_at: None,
                    finalizing_at: None,
                    completed_at: None,
                    failed_at: None,
                    expired_at: None,
                    cancelling_at: None,
                    cancelled_at: None,
                    request_counts: None,
                    metadata: None,
                },
            );
        }
        debug!("Mock batch inserted with status: Completed, both output and error files");

        trace!("Mocking file contents for both output and error files...");
        {
            let mut files_guard = mock_client.files().write().unwrap();
            files_guard.insert(output_file_id.to_string(), Bytes::from("mock output data"));
            files_guard.insert(error_file_id.to_string(),  Bytes::from("mock error data"));
        }

        trace!("Creating temp dir and saving metadata...");
        let tmp_dir = tempfile::tempdir().unwrap(); // unique folder for this test
        let metadata_path = tmp_dir.path().join("metadata.json");
        let metadata = BatchMetadataBuilder::default()
            .batch_id(batch_id.to_string())
            .input_file_id("some_input_file".to_string())
            .output_file_id(Some(output_file_id.to_string()))
            .error_file_id(Some(error_file_id.to_string()))
            .build()
            .unwrap();
        info!("Saving metadata at {:?}", metadata_path);
        metadata.save_to_file(&metadata_path).await.unwrap();
        debug!("Metadata saved to {:?}", metadata_path);

        // Create the triple referencing that metadata
        let mut triple = BatchFileTriple::new_for_test_with_metadata_path(metadata_path.clone());
        triple.set_metadata_path(Some(metadata_path.clone()));

        // --- Put both output & error in the temp directory. ---
        let output_file_path = tmp_dir.path().join("downloaded_output.json");
        let error_file_path  = tmp_dir.path().join("downloaded_error.json");
        triple.set_output_path(Some(output_file_path.clone()));
        triple.set_error_path(Some(error_file_path.clone()));

        trace!("Calling check_for_and_download_output_and_error_online...");
        let result = triple
            .check_for_and_download_output_and_error_online(&mock_client)
            .await;
        debug!("Result from check call: {:?}", result);

        assert!(
            result.is_ok(),
            "Should succeed for completed batch with both files"
        );

        // Now read from the unique paths
        let out_contents = fs::read_to_string(&output_file_path)
            .expect("Failed to read downloaded output file");
        let err_contents = fs::read_to_string(&error_file_path)
            .expect("Failed to read downloaded error file");

        pretty_assert_eq!(out_contents, "mock output data");
        pretty_assert_eq!(err_contents, "mock error data");

        info!("test_completed_with_both_output_and_error passed");
    }
}