1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
//! Inline suppression support for bashrs warnings (Issue #70)
//!
//! Allows users to suppress specific warnings using inline comments.
//! Supports BOTH bashrs-native syntax AND shellcheck syntax for compatibility.
//!
//! # Bashrs Syntax
//!
//! - File-level: `# bashrs disable-file=SC2086,DET002`
//! - Next-line: `# bashrs disable-next-line=SC2086`
//! - Shorthand: `# bashrs disable=SEC010` (alias for disable-next-line)
//! - Inline: `command # bashrs disable-line=SC2086`
//!
//! # Shellcheck Syntax (also supported)
//!
//! - File-level: `# shellcheck disable=SC2086,SC2046` (at top of file)
//! - Next-line: `# shellcheck disable=SC2086` (before the line)
//!
//! # Examples
//!
//! ```bash
//! # bashrs disable-file=DET002
//! # Entire file exempt from DET002
//!
//! # bashrs disable-next-line=SC2086
//! echo $var # Won't trigger SC2086
//!
//! # bashrs disable=SEC010 # Shorthand syntax (Issue #70)
//! mkdir -p "${BASELINE_DIR}"
//!
//! timestamp=$(date +%s) # bashrs disable-line=DET002
//!
//! # shellcheck disable=SC2086
//! echo $var # Also suppressed (shellcheck compatibility)
//! ```
use std::collections::{HashMap, HashSet};
/// Suppression directive type
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum SuppressionType {
/// Suppress rules for entire file
File,
/// Suppress rules for next line only
NextLine,
/// Suppress rules for current line only
Line,
}
/// A suppression directive parsed from source comments
#[derive(Debug, Clone)]
pub struct Suppression {
/// Type of suppression (file/next-line/line)
pub suppression_type: SuppressionType,
/// Line number where directive appears (1-indexed)
pub line: usize,
/// Rule codes to suppress (e.g., ["SC2086", "DET002"])
pub rules: HashSet<String>,
}
/// Manages suppressions for a source file
#[derive(Debug, Default)]
pub struct SuppressionManager {
/// File-level suppressions (apply to entire file)
file_suppressions: HashSet<String>,
/// Line-specific suppressions (line number -> rule codes)
line_suppressions: HashMap<usize, HashSet<String>>,
}
impl SuppressionManager {
/// Create a new suppression manager by parsing source code
///
/// # Examples
///
/// ## File-level suppression
///
/// ```
/// use bashrs::linter::SuppressionManager;
///
/// let script = "# bashrs disable-file=SC2086,DET002\necho $var\ntimestamp=$(date +%s)";
///
/// let manager = SuppressionManager::from_source(script);
/// assert!(manager.is_suppressed("SC2086", 1));
/// assert!(manager.is_suppressed("SC2086", 2));
/// assert!(manager.is_suppressed("DET002", 3));
/// ```
///
/// ## Next-line suppression
///
/// ```
/// use bashrs::linter::SuppressionManager;
///
/// let script = "# bashrs disable-next-line=SC2086\necho $var";
///
/// let manager = SuppressionManager::from_source(script);
/// assert!(manager.is_suppressed("SC2086", 2));
/// assert!(!manager.is_suppressed("SC2086", 1));
/// ```
///
/// ## Inline suppression
///
/// ```
/// use bashrs::linter::SuppressionManager;
///
/// let script = "echo $var # bashrs disable-line=SC2086";
///
/// let manager = SuppressionManager::from_source(script);
/// assert!(manager.is_suppressed("SC2086", 1));
/// assert!(!manager.is_suppressed("SC2002", 1));
/// ```
///
/// ## Shellcheck file-level suppression (Issue #130)
///
/// Shellcheck directives at the top of a file (before any code) apply to
/// the entire file:
///
/// ```
/// use bashrs::linter::SuppressionManager;
///
/// let script = "#!/bin/bash\n# shellcheck disable=SC2086\necho $var";
///
/// let manager = SuppressionManager::from_source(script);
/// // Directive at top of file applies to all lines
/// assert!(manager.is_suppressed("SC2086", 3));
/// ```
pub fn from_source(source: &str) -> Self {
let mut manager = Self::default();
let lines: Vec<&str> = source.lines().collect();
// Issue #130: Track whether we've seen any code yet
// Shellcheck directives before any code are file-level
let mut seen_code = false;
for (line_idx, line) in lines.iter().enumerate() {
let line_num = line_idx + 1;
let trimmed = line.trim();
// Check if this line is code (not a comment, shebang, or empty)
if !trimmed.is_empty()
&& !trimmed.starts_with('#')
&& !trimmed.starts_with("set ")
&& !trimmed.starts_with("shopt ")
{
seen_code = true;
}
// Check for suppression directives
if let Some(suppression) = parse_suppression(line, line_num) {
match suppression.suppression_type {
SuppressionType::File => {
// File-level suppression applies to all lines
manager.file_suppressions.extend(suppression.rules);
}
SuppressionType::NextLine => {
// Issue #130: Shellcheck directives at top of file are file-level
// Check if we've seen code yet - if not, treat as file-level
if !seen_code && is_shellcheck_directive(line) {
manager.file_suppressions.extend(suppression.rules);
} else {
// Next-line suppression applies to line_num + 1
if line_idx + 1 < lines.len() {
manager
.line_suppressions
.entry(line_num + 1)
.or_default()
.extend(suppression.rules);
}
}
}
SuppressionType::Line => {
// Inline suppression applies to current line
manager
.line_suppressions
.entry(line_num)
.or_default()
.extend(suppression.rules);
}
}
}
}
manager
}
/// Check if a rule is suppressed at a given line
pub fn is_suppressed(&self, rule_code: &str, line: usize) -> bool {
// Check file-level suppressions first
if self.file_suppressions.contains(rule_code) {
return true;
}
// Check line-specific suppressions
if let Some(rules) = self.line_suppressions.get(&line) {
if rules.contains(rule_code) {
return true;
}
}
false
}
}
/// Issue #130: Check if line contains a shellcheck directive
fn is_shellcheck_directive(line: &str) -> bool {
line.contains("# shellcheck disable=")
}
/// Parse a suppression directive from a line
/// Supports BOTH bashrs-native syntax AND shellcheck syntax
fn parse_suppression(line: &str, line_num: usize) -> Option<Suppression> {
let trimmed = line.trim();
// =====================================================
// Bashrs-native syntax
// =====================================================
// Match patterns: # bashrs disable-file=SC2086,DET002
// Match patterns: # bashrs disable-next-line=SC2086
// Match patterns: command # bashrs disable-line=SC2086
if let Some(pos) = trimmed.find("# bashrs disable-file=") {
let rules_str = &trimmed[pos + "# bashrs disable-file=".len()..];
let rules = parse_rule_list(rules_str);
return Some(Suppression {
suppression_type: SuppressionType::File,
line: line_num,
rules,
});
}
if let Some(pos) = trimmed.find("# bashrs disable-next-line=") {
let rules_str = &trimmed[pos + "# bashrs disable-next-line=".len()..];
let rules = parse_rule_list(rules_str);
return Some(Suppression {
suppression_type: SuppressionType::NextLine,
line: line_num,
rules,
});
}
if let Some(pos) = line.find("# bashrs disable-line=") {
let rules_str = &line[pos + "# bashrs disable-line=".len()..];
let rules = parse_rule_list(rules_str);
return Some(Suppression {
suppression_type: SuppressionType::Line,
line: line_num,
rules,
});
}
// Shorthand syntax: # bashrs disable=RULE (alias for disable-next-line)
// Must check AFTER the more specific patterns to avoid matching them
if let Some(pos) = trimmed.find("# bashrs disable=") {
// Make sure it's not one of the more specific patterns
if !trimmed.contains("disable-file=")
&& !trimmed.contains("disable-next-line=")
&& !trimmed.contains("disable-line=")
{
let rules_str = &trimmed[pos + "# bashrs disable=".len()..];
let rules = parse_rule_list(rules_str);
return Some(Suppression {
suppression_type: SuppressionType::NextLine,
line: line_num,
rules,
});
}
}
// =====================================================
// Shellcheck syntax (for compatibility)
// =====================================================
// Match patterns: # shellcheck disable=SC2086,SC2046
// Shellcheck directives apply to the NEXT line (like bashrs disable-next-line)
if let Some(pos) = trimmed.find("# shellcheck disable=") {
let rules_str = &trimmed[pos + "# shellcheck disable=".len()..];
let rules = parse_rule_list(rules_str);
return Some(Suppression {
suppression_type: SuppressionType::NextLine,
line: line_num,
rules,
});
}
// Also support shellcheck source directive being ignored (not a suppression)
// # shellcheck source=./lib.sh - we don't need to handle this
None
}
/// Parse comma-separated rule list
/// Stops at parentheses and validates rule codes
fn parse_rule_list(rules_str: &str) -> HashSet<String> {
// Strip trailing explanation text:
// - "(validated via case statement)" - parenthesized explanations
// - "# $* is intentional" - hash comments
// - whitespace after rule codes
let rules_part = rules_str
.split('(')
.next()
.unwrap_or(rules_str)
.split('#')
.next()
.unwrap_or(rules_str);
rules_part
.split(',')
.map(|s| s.trim().to_string())
.filter(|s| !s.is_empty() && is_valid_rule_code(s))
.collect()
}
/// Check if string looks like a valid rule code (e.g., SC2086, DET002, SEC010)
fn is_valid_rule_code(code: &str) -> bool {
// Valid codes are uppercase letters followed by digits (e.g., SC2086, DET002)
let code = code.trim();
if code.len() < 3 || code.len() > 10 {
return false;
}
// Must start with 1-6 uppercase letters
let letter_count = code.chars().take_while(|c| c.is_ascii_uppercase()).count();
if letter_count == 0 || letter_count > 6 {
return false;
}
// Must end with 1-5 digits
let digit_part = &code[letter_count..];
!digit_part.is_empty() && digit_part.chars().all(|c| c.is_ascii_digit())
}
#[cfg(test)]
#[path = "suppression_tests_parse_file.rs"]
mod tests_extracted;