bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144

#![allow(clippy::unwrap_used)]
#![allow(clippy::expect_used)]
#![allow(non_snake_case)]
//! Provable Contract Tests: linter-docker-make-v1.yaml
//!
//! Each test pair attempts to FALSIFY a Dockerfile or Makefile linter contract.
//! SOUND: known-bad input MUST be flagged.
//! PRECISE: known-safe input must NOT be flagged.
//!
//! Reference: GH-183 (KZ-11: Missing provable contracts)

fn docker_has(source: &str, code: &str) -> bool {
    let result = bashrs::linter::rules::lint_dockerfile(source);
    result.diagnostics.iter().any(|d| d.code == code)
}

fn make_has(source: &str, code: &str) -> bool {
    let result = bashrs::linter::lint_makefile(source);
    result.diagnostics.iter().any(|d| d.code == code)
}

// ============================================================================
// DOCKER001: missing USER directive
// ============================================================================

#[test]
fn falsify_DOCKER001_SOUND_no_user() {
    assert!(
        docker_has("FROM ubuntu:latest\nRUN apt-get update", "DOCKER001"),
        "F-DOCKER001-SOUND: Dockerfile without USER MUST be flagged"
    );
}

#[test]
fn falsify_DOCKER001_PRECISE_has_user() {
    assert!(
        !docker_has("FROM ubuntu:22.04\nUSER appuser\nRUN echo hi", "DOCKER001"),
        "F-DOCKER001-PRECISE: Dockerfile with USER must NOT be flagged"
    );
}

// ============================================================================
// DOCKER002: unpinned base image
// ============================================================================

#[test]
fn falsify_DOCKER002_SOUND_latest_tag() {
    assert!(
        docker_has("FROM ubuntu:latest\nRUN echo hi", "DOCKER002"),
        "F-DOCKER002-SOUND: :latest tag MUST be flagged"
    );
}

#[test]
fn falsify_DOCKER002_PRECISE_sha256_pinned() {
    // SHA256-pinned images should not trigger DOCKER002
    assert!(
        !docker_has(
            "FROM ubuntu@sha256:abcdef1234567890abcdef1234567890\nRUN echo hi",
            "DOCKER002"
        ),
        "F-DOCKER002-PRECISE: sha256-pinned image must NOT be flagged"
    );
}

// ============================================================================
// DOCKER006: ADD vs COPY
// ============================================================================

#[test]
fn falsify_DOCKER006_SOUND_add_local() {
    assert!(
        docker_has("FROM ubuntu\nADD . /app", "DOCKER006"),
        "F-DOCKER006-SOUND: ADD for local files MUST be flagged"
    );
}

#[test]
fn falsify_DOCKER006_PRECISE_copy() {
    assert!(
        !docker_has("FROM ubuntu\nCOPY . /app", "DOCKER006"),
        "F-DOCKER006-PRECISE: COPY must NOT be flagged"
    );
}

// ============================================================================
// MAKE001: unsorted wildcard
// ============================================================================

#[test]
fn falsify_MAKE001_SOUND_bare_wildcard() {
    assert!(
        make_has("SRCS = $(wildcard *.c)", "MAKE001"),
        "F-MAKE001-SOUND: $(wildcard) without $(sort) MUST be flagged"
    );
}

#[test]
fn falsify_MAKE001_PRECISE_sorted_wildcard() {
    assert!(
        !make_has("SRCS := $(sort $(wildcard *.c))", "MAKE001"),
        "F-MAKE001-PRECISE: $(sort $(wildcard)) must NOT be flagged"
    );
}

// ============================================================================
// MAKE002: mkdir without -p
// ============================================================================

#[test]
fn falsify_MAKE002_SOUND_mkdir_bare() {
    assert!(
        make_has("all:\n\tmkdir /tmp/foo", "MAKE002"),
        "F-MAKE002-SOUND: mkdir without -p in recipe MUST be flagged"
    );
}

#[test]
fn falsify_MAKE002_PRECISE_mkdir_p() {
    assert!(
        !make_has("all:\n\tmkdir -p /tmp/foo", "MAKE002"),
        "F-MAKE002-PRECISE: mkdir -p must NOT be flagged"
    );
}

// ============================================================================
// MAKE004: missing .PHONY
// ============================================================================

#[test]
fn falsify_MAKE004_SOUND_no_phony() {
    assert!(
        make_has("all:\n\techo done", "MAKE004"),
        "F-MAKE004-SOUND: target without .PHONY MUST be flagged"
    );
}

#[test]
fn falsify_MAKE004_PRECISE_has_phony() {
    assert!(
        !make_has(".PHONY: all\nall:\n\techo done", "MAKE004"),
        "F-MAKE004-PRECISE: .PHONY target must NOT be flagged"
    );
}