1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
//! Determinism checking for bash scripts
//!
//! Detects non-deterministic patterns that violate deterministic execution:
//! - $RANDOM: Random number generation
//! - $$: Process ID
//! - Timestamps: date commands
//! - $BASHPID: Bash-specific process ID
//! - $SRANDOM: Cryptographic random (Bash 5.1+)
/// Detects non-deterministic patterns in bash scripts
#[derive(Debug, Clone, PartialEq)]
pub struct DeterminismChecker {
/// Patterns detected in the script
detections: Vec<DeterminismIssue>,
}
/// A single non-deterministic pattern detection
#[derive(Debug, Clone, PartialEq)]
pub struct DeterminismIssue {
/// Line number where pattern was found (1-indexed)
pub line: usize,
/// Type of non-deterministic pattern
pub pattern_type: NonDeterministicPattern,
/// The actual code that triggered the detection
pub code: String,
/// Human-readable explanation
pub explanation: String,
}
/// Types of non-deterministic patterns
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum NonDeterministicPattern {
/// $RANDOM variable
Random,
/// $$ (process ID)
ProcessId,
/// date command or timestamp generation
Timestamp,
/// $BASHPID variable
BashPid,
/// $SRANDOM (cryptographic random, Bash 5.1+)
SecureRandom,
}
impl DeterminismChecker {
/// Create a new determinism checker
pub fn new() -> Self {
Self {
detections: Vec::new(),
}
}
/// Scan bash script for non-deterministic patterns
///
/// Returns: List of detected issues
pub fn scan(&mut self, script: &str) -> Vec<DeterminismIssue> {
// Clear previous results
self.detections.clear();
for (line_num, line) in script.lines().enumerate() {
let line_num = line_num + 1; // 1-indexed
// Detect $RANDOM
if line.contains("$RANDOM") || line.contains("${RANDOM}") {
self.detections.push(DeterminismIssue {
line: line_num,
pattern_type: NonDeterministicPattern::Random,
code: line.to_string(),
explanation: "Uses $RANDOM which produces different values on each run"
.to_string(),
});
}
// Detect $$ (process ID)
if line.contains("$$") {
self.detections.push(DeterminismIssue {
line: line_num,
pattern_type: NonDeterministicPattern::ProcessId,
code: line.to_string(),
explanation: "Uses $$ (process ID) which changes on each execution".to_string(),
});
}
// Detect timestamps: date, $(date), `date`, etc.
if line.contains("date")
&& (line.contains("$(date")
|| line.contains("`date")
|| line.contains("date +")
|| line.contains("date -"))
{
self.detections.push(DeterminismIssue {
line: line_num,
pattern_type: NonDeterministicPattern::Timestamp,
code: line.to_string(),
explanation: "Uses date command which produces different values over time"
.to_string(),
});
}
// Detect $BASHPID
if line.contains("$BASHPID") || line.contains("${BASHPID}") {
self.detections.push(DeterminismIssue {
line: line_num,
pattern_type: NonDeterministicPattern::BashPid,
code: line.to_string(),
explanation: "Uses $BASHPID which changes on each execution".to_string(),
});
}
// Detect $SRANDOM (Bash 5.1+)
if line.contains("$SRANDOM") || line.contains("${SRANDOM}") {
self.detections.push(DeterminismIssue {
line: line_num,
pattern_type: NonDeterministicPattern::SecureRandom,
code: line.to_string(),
explanation:
"Uses $SRANDOM (cryptographic random) which produces different values on each run"
.to_string(),
});
}
}
self.detections.clone()
}
/// Check if script is deterministic (no issues found)
pub fn is_deterministic(&self) -> bool {
self.detections.is_empty()
}
/// Get count of issues by pattern type
pub fn count_by_pattern(&self, pattern: NonDeterministicPattern) -> usize {
self.detections
.iter()
.filter(|issue| issue.pattern_type == pattern)
.count()
}
}
impl Default for DeterminismChecker {
fn default() -> Self {
Self::new()
}
}
// ===== Shared data types used by replay and idempotency modules =====
/// Result of replay verification
#[derive(Debug, Clone, PartialEq)]
pub struct ReplayResult {
/// Whether all runs produced identical output
pub is_deterministic: bool,
/// Outputs from each run
pub runs: Vec<RunOutput>,
/// Lines that differ between runs (if non-deterministic)
pub differences: Vec<OutputDifference>,
}
/// Output from a single script execution
#[derive(Debug, Clone, PartialEq)]
pub struct RunOutput {
/// Run number (1-indexed)
pub run_number: usize,
/// Standard output
pub stdout: String,
/// Standard error
pub stderr: String,
/// Exit code
pub exit_code: i32,
}
/// Difference between two runs
#[derive(Debug, Clone, PartialEq)]
pub struct OutputDifference {
/// Line number where difference occurs (1-indexed)
pub line: usize,
/// Output from first run
pub run1: String,
/// Output from second run
pub run2: String,
}
// ===== TESTS =====
#[cfg(test)]
mod tests {
use super::*;
// ===== REPL-011-001: DETERMINISM CHECKER TESTS =====
/// Test: REPL-011-001-001 - Detect $RANDOM
#[test]
fn test_REPL_011_001_detect_random() {
// ARRANGE: Script with $RANDOM
let script = "SESSION_ID=$RANDOM\necho $SESSION_ID";
let mut checker = DeterminismChecker::new();
// ACT: Scan for patterns
let issues = checker.scan(script);
// ASSERT: Should detect $RANDOM
assert_eq!(issues.len(), 1, "Should find 1 issue");
assert_eq!(issues[0].line, 1);
assert_eq!(issues[0].pattern_type, NonDeterministicPattern::Random);
assert!(issues[0].explanation.contains("RANDOM"));
assert!(!checker.is_deterministic());
}
/// Test: REPL-011-001-002 - Detect $$
#[test]
fn test_REPL_011_001_detect_pid() {
// ARRANGE: Script with $$
let script = "TMPFILE=/tmp/script_$$\necho $TMPFILE";
let mut checker = DeterminismChecker::new();
// ACT: Scan for patterns
let issues = checker.scan(script);
// ASSERT: Should detect $$
assert_eq!(issues.len(), 1, "Should find 1 issue");
assert_eq!(issues[0].line, 1);
assert_eq!(issues[0].pattern_type, NonDeterministicPattern::ProcessId);
assert!(issues[0].explanation.contains("process ID"));
assert!(!checker.is_deterministic());
}
/// Test: REPL-011-001-003 - Detect date command
#[test]
fn test_REPL_011_001_detect_timestamp() {
// ARRANGE: Script with date command
let script = "RELEASE=$(date +%s)\necho $RELEASE";
let mut checker = DeterminismChecker::new();
// ACT: Scan for patterns
let issues = checker.scan(script);
// ASSERT: Should detect date command
assert_eq!(issues.len(), 1, "Should find 1 issue");
assert_eq!(issues[0].line, 1);
assert_eq!(issues[0].pattern_type, NonDeterministicPattern::Timestamp);
assert!(issues[0].explanation.contains("date"));
assert!(!checker.is_deterministic());
}
/// Test: REPL-011-001-004 - Detect $BASHPID
#[test]
fn test_REPL_011_001_detect_bashpid() {
// ARRANGE: Script with $BASHPID
let script = "echo \"Running as $BASHPID\"";
let mut checker = DeterminismChecker::new();
// ACT: Scan for patterns
let issues = checker.scan(script);
// ASSERT: Should detect $BASHPID
assert_eq!(issues.len(), 1, "Should find 1 issue");
assert_eq!(issues[0].line, 1);
assert_eq!(issues[0].pattern_type, NonDeterministicPattern::BashPid);
assert!(issues[0].explanation.contains("BASHPID"));
}
/// Test: REPL-011-001-005 - Detect $SRANDOM
#[test]
fn test_REPL_011_001_detect_srandom() {
// ARRANGE: Script with $SRANDOM (Bash 5.1+)
let script = "TOKEN=$SRANDOM\necho $TOKEN";
let mut checker = DeterminismChecker::new();
// ACT: Scan for patterns
let issues = checker.scan(script);
// ASSERT: Should detect $SRANDOM
assert_eq!(issues.len(), 1, "Should find 1 issue");
assert_eq!(issues[0].line, 1);
assert_eq!(
issues[0].pattern_type,
NonDeterministicPattern::SecureRandom
);
assert!(issues[0].explanation.contains("SRANDOM"));
}
/// Test: REPL-011-001-006 - Deterministic script passes
#[test]
fn test_REPL_011_001_deterministic_script() {
// ARRANGE: Script without non-deterministic patterns
let script = "VERSION=1.0.0\necho \"Release $VERSION\"";
let mut checker = DeterminismChecker::new();
// ACT: Scan for patterns
let issues = checker.scan(script);
// ASSERT: Should find no issues
assert_eq!(issues.len(), 0, "Should find 0 issues");
assert!(checker.is_deterministic());
}
/// Test: REPL-011-001-007 - Multiple patterns detected
#[test]
fn test_REPL_011_001_multiple_patterns() {
// ARRANGE: Script with multiple non-deterministic patterns
let script = r#"
SESSION_ID=$RANDOM
TMPFILE=/tmp/script_$$
TIMESTAMP=$(date +%s)
"#
.trim();
let mut checker = DeterminismChecker::new();
// ACT: Scan for patterns
let issues = checker.scan(script);
// ASSERT: Should detect all 3 patterns
assert_eq!(issues.len(), 3, "Should find 3 issues");
assert_eq!(checker.count_by_pattern(NonDeterministicPattern::Random), 1);
assert_eq!(
checker.count_by_pattern(NonDeterministicPattern::ProcessId),
1
);
assert_eq!(
checker.count_by_pattern(NonDeterministicPattern::Timestamp),
1
);
}
/// Test: REPL-011-001-008 - Rescan clears previous results
#[test]
fn test_REPL_011_001_rescan_clears_previous() {
// ARRANGE: Scanner with previous results
let mut checker = DeterminismChecker::new();
checker.scan("SESSION_ID=$RANDOM");
assert_eq!(checker.detections.len(), 1);
// ACT: Scan new script
let issues = checker.scan("echo 'hello'");
// ASSERT: Previous results should be cleared
assert_eq!(issues.len(), 0);
assert!(checker.is_deterministic());
}
/// Test: REPL-011-001-009 - Line numbers are correct
#[test]
fn test_REPL_011_001_line_numbers_correct() {
// ARRANGE: Multi-line script with issues on different lines
let script = "echo 'start'\nID=$RANDOM\necho 'middle'\nTMP=$$\necho 'end'";
let mut checker = DeterminismChecker::new();
// ACT: Scan for patterns
let issues = checker.scan(script);
// ASSERT: Line numbers should be correct
assert_eq!(issues.len(), 2);
assert_eq!(issues[0].line, 2); // $RANDOM on line 2
assert_eq!(issues[1].line, 4); // $$ on line 4
}
}
// ===== PROPERTY TESTS =====
#[cfg(test)]
mod property_tests {
use super::*;
use proptest::prelude::*;
proptest! {
/// Property: Scripts with $RANDOM should always be detected
#[test]
fn prop_REPL_011_001_pattern_detection_never_false_negative(
prefix in "[a-z_]{0,10}",
suffix in "[a-z_]{0,10}"
) {
// Scripts with $RANDOM should always be detected
let script = format!("{}$RANDOM{}", prefix, suffix);
let mut checker = DeterminismChecker::new();
let issues = checker.scan(&script);
prop_assert!(
issues.iter().any(|i| i.pattern_type == NonDeterministicPattern::Random),
"Should always detect $RANDOM: '{}'", script
);
}
/// Property: Simple variable assignments should be deterministic
#[test]
fn prop_REPL_011_001_deterministic_scripts_pass(
var_name in "[A-Z_]{1,10}",
value in "[a-z0-9]{1,20}"
) {
// Simple variable assignments should be deterministic
let script = format!("{}={}", var_name, value);
let mut checker = DeterminismChecker::new();
let issues = checker.scan(&script);
prop_assert_eq!(issues.len(), 0, "Simple assignments should be deterministic");
prop_assert!(checker.is_deterministic());
}
/// Property: Scanner should never panic on any input
#[test]
fn prop_REPL_011_001_scan_never_panics(script in ".*{0,1000}") {
// Scanner should never panic on any input
let mut checker = DeterminismChecker::new();
let _ = checker.scan(&script);
}
/// Property: Rescanning should always clear previous results
#[test]
fn prop_REPL_011_001_rescan_always_clears(
script1 in ".*{0,100}",
script2 in ".*{0,100}"
) {
// Rescanning should always clear previous results
let mut checker = DeterminismChecker::new();
checker.scan(&script1);
let issues2 = checker.scan(&script2);
// Second scan results should match fresh scan
let mut fresh_checker = DeterminismChecker::new();
let fresh_issues = fresh_checker.scan(&script2);
prop_assert_eq!(issues2.len(), fresh_issues.len());
}
}
}