1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
impl BashParser {
/// Issue #93: Parse a command used as a condition in if/while statements
/// Similar to parse_command but stops at `then`, `do`, and doesn't include redirections
pub(crate) fn parse_condition_command(&mut self) -> ParseResult<BashStmt> {
let env_prefixes = self.collect_env_prefixes();
let cmd_name = self.consume_command_name()?;
// Build the full name with env prefixes: "IFS= read" or "LC_ALL=C sort"
let name = if env_prefixes.is_empty() {
cmd_name
} else {
let mut full = env_prefixes.join(" ");
full.push(' ');
full.push_str(&cmd_name);
full
};
let mut args = Vec::new();
let mut redirects = Vec::new();
// Parse arguments until semicolon, newline, then, do, or special tokens
while !self.at_condition_arg_boundary() {
if let Some(redir) = self.try_parse_condition_redirect()? {
redirects.push(redir);
} else {
args.push(self.parse_expression()?);
}
}
Ok(BashStmt::Command {
name,
args,
redirects,
span: Span::new(self.current_line, 0, self.current_line, 0),
})
}
/// Collect env prefix assignments before a command: `IFS= read`, `LC_ALL=C sort`
fn collect_env_prefixes(&mut self) -> Vec<String> {
let mut env_prefixes = Vec::new();
while matches!(self.peek(), Some(Token::Identifier(_)))
&& self.peek_ahead(1) == Some(&Token::Assign)
{
let var_name = if let Some(Token::Identifier(n)) = self.peek() {
n.clone()
} else {
break;
};
self.advance(); // consume identifier
let assign_idx = self.position;
self.advance(); // consume =
let value = self.consume_adjacent_value(assign_idx);
if value.is_empty() {
env_prefixes.push(format!("{var_name}="));
} else {
env_prefixes.push(format!("{var_name}={value}"));
}
}
env_prefixes
}
/// Consume an adjacent token value for env prefix assignments.
/// Returns empty string if no adjacent value.
fn consume_adjacent_value(&mut self, assign_idx: usize) -> String {
if !self.tokens_adjacent(assign_idx) {
return String::new();
}
match self.peek() {
Some(Token::Identifier(id)) => {
let v = id.clone();
self.advance();
v
}
Some(Token::String(s)) => {
let v = s.clone();
self.advance();
v
}
Some(Token::Number(n)) => {
let v = n.to_string();
self.advance();
v
}
_ => String::new(),
}
}
/// Consume and return the command name token.
fn consume_command_name(&mut self) -> ParseResult<String> {
match self.peek() {
Some(Token::Identifier(n)) => {
let cmd = n.clone();
self.advance();
Ok(cmd)
}
Some(Token::String(s)) => {
let cmd = s.clone();
self.advance();
Ok(cmd)
}
Some(Token::Variable(v)) => {
let cmd = format!("${v}");
self.advance();
Ok(cmd)
}
_ => Err(self.syntax_error("command name")),
}
}
/// Check if we've reached a boundary token that ends condition command arguments.
/// Stop at standalone & (background) but NOT &> (combined redirect).
fn at_condition_arg_boundary(&self) -> bool {
if self.is_at_end() {
return true;
}
match self.peek() {
Some(
Token::Newline
| Token::Semicolon
| Token::Then
| Token::Do
| Token::Pipe
| Token::And
| Token::Or
| Token::RightParen
| Token::Comment(_),
) => true,
Some(Token::Ampersand) => !matches!(self.peek_ahead(1), Some(Token::Gt)),
_ => false,
}
}
/// Try to parse a redirection at the current position.
/// Returns `Ok(Some(redirect))` if a redirect was parsed,
/// `Ok(None)` if no redirect pattern matched (caller should parse an argument).
fn try_parse_condition_redirect(&mut self) -> ParseResult<Option<Redirect>> {
// fd>& fd duplication: 2>&1
if matches!(self.peek(), Some(Token::Number(_)))
&& matches!(self.peek_ahead(1), Some(Token::Gt))
&& matches!(self.peek_ahead(2), Some(Token::Ampersand))
&& matches!(self.peek_ahead(3), Some(Token::Number(_)))
{
return self.parse_fd_to_fd_redirect().map(Some);
}
// fd> redirect: 2>file
if matches!(self.peek(), Some(Token::Number(_)))
&& matches!(self.peek_ahead(1), Some(Token::Gt))
{
self.advance();
self.advance();
let target = self.parse_redirect_target()?;
return Ok(Some(Redirect::Error { target }));
}
// &> combined redirect
if matches!(self.peek(), Some(Token::Ampersand))
&& matches!(self.peek_ahead(1), Some(Token::Gt))
{
self.advance();
self.advance();
let target = self.parse_redirect_target()?;
return Ok(Some(Redirect::Combined { target }));
}
// >&fd duplication shorthand: >&2
if matches!(self.peek(), Some(Token::Gt))
&& matches!(self.peek_ahead(1), Some(Token::Ampersand))
&& matches!(self.peek_ahead(2), Some(Token::Number(_)))
{
return self.parse_gt_ampersand_fd_redirect().map(Some);
}
// Simple > redirect
if matches!(self.peek(), Some(Token::Gt)) {
self.advance();
let target = self.parse_redirect_target()?;
return Ok(Some(Redirect::Output { target }));
}
// >> append redirect
if matches!(self.peek(), Some(Token::GtGt)) {
self.advance();
let target = self.parse_redirect_target()?;
return Ok(Some(Redirect::Append { target }));
}
// < input redirect
if matches!(self.peek(), Some(Token::Lt)) {
self.advance();
let target = self.parse_redirect_target()?;
return Ok(Some(Redirect::Input { target }));
}
Ok(None)
}
/// Parse `N>&M` fd-to-fd duplication redirect.
fn parse_fd_to_fd_redirect(&mut self) -> ParseResult<Redirect> {
let from_fd = if let Some(Token::Number(n)) = self.peek() {
*n as i32
} else {
unreachable!()
};
self.advance(); // number
self.advance(); // >
self.advance(); // &
let to_fd = if let Some(Token::Number(n)) = self.peek() {
*n as i32
} else {
unreachable!()
};
self.advance();
Ok(Redirect::Duplicate { from_fd, to_fd })
}
/// Parse `>&N` fd duplication shorthand (stdout to fd N).
fn parse_gt_ampersand_fd_redirect(&mut self) -> ParseResult<Redirect> {
self.advance(); // consume '>'
self.advance(); // consume '&'
let to_fd = if let Some(Token::Number(n)) = self.peek() {
*n as i32
} else {
unreachable!()
};
self.advance();
Ok(Redirect::Duplicate { from_fd: 1, to_fd })
}
pub(crate) fn parse_test_condition(&mut self) -> ParseResult<TestExpr> {
// Issue #62: Handle negation operator ! at the start of test condition
if self.check(&Token::Not) {
self.advance(); // consume '!'
let inner = self.parse_test_condition()?;
return Ok(TestExpr::Not(Box::new(inner)));
}
// Check for unary test operators first (operators are tokenized as Identifier)
if let Some(Token::Identifier(op)) = self.peek() {
let operator = op.clone();
match operator.as_str() {
"-n" => {
self.advance(); // consume operator
let expr = self.parse_expression()?;
return Ok(TestExpr::StringNonEmpty(expr));
}
"-z" => {
self.advance();
let expr = self.parse_expression()?;
return Ok(TestExpr::StringEmpty(expr));
}
"-f" | "-e" | "-s" | "-v" | "-L" | "-h" | "-p" | "-b" | "-c" | "-g" | "-k"
| "-u" | "-t" | "-O" | "-G" | "-N" => {
// File test operators: -f, -e, -s, -L/-h, -p, -b, -c,
// -g, -k, -u, -t, -O, -G, -N, -v
self.advance();
let expr = self.parse_expression()?;
return Ok(TestExpr::FileExists(expr));
}
"-d" => {
self.advance();
let expr = self.parse_expression()?;
return Ok(TestExpr::FileDirectory(expr));
}
"-r" => {
self.advance();
let expr = self.parse_expression()?;
return Ok(TestExpr::FileReadable(expr));
}
"-w" => {
self.advance();
let expr = self.parse_expression()?;
return Ok(TestExpr::FileWritable(expr));
}
"-x" => {
self.advance();
let expr = self.parse_expression()?;
return Ok(TestExpr::FileExecutable(expr));
}
_ => {
// Not a unary operator, continue with binary operator parsing
}
}
}
// Parse left operand for binary operators
let left = self.parse_expression()?;
// Check for binary operators
match self.peek() {
Some(Token::Assign | Token::Eq) => {
// Both = (Token::Assign) and == (Token::Eq) are string equality in tests
self.advance();
let right = self.parse_expression()?;
Ok(TestExpr::StringEq(left, right))
}
Some(Token::Ne) => {
self.advance();
let right = self.parse_expression()?;
Ok(TestExpr::StringNe(left, right))
}
Some(Token::Lt) => {
self.advance();
let right = self.parse_expression()?;
Ok(TestExpr::IntLt(left, right))
}
Some(Token::Gt) => {
self.advance();
let right = self.parse_expression()?;
Ok(TestExpr::IntGt(left, right))
}
// =~ regex match: [[ str =~ pattern ]] — pattern is embedded in token
Some(Token::Identifier(op)) if op.starts_with("=~ ") => {
let pattern = op.strip_prefix("=~ ").unwrap_or("").to_string();
self.advance();
// Treat as string equality test with the regex pattern as literal
// (bash regex semantics can't be fully represented in POSIX)
Ok(TestExpr::StringEq(left, BashExpr::Literal(pattern)))
}
Some(Token::Identifier(op))
if matches!(op.as_str(), "-eq" | "-ne" | "-lt" | "-le" | "-gt" | "-ge") =>
{
let operator = op.clone();
self.advance();
let right = self.parse_expression()?;
match operator.as_str() {
"-eq" => Ok(TestExpr::IntEq(left, right)),
"-ne" => Ok(TestExpr::IntNe(left, right)),
"-lt" => Ok(TestExpr::IntLt(left, right)),
"-le" => Ok(TestExpr::IntLe(left, right)),
"-gt" => Ok(TestExpr::IntGt(left, right)),
"-ge" => Ok(TestExpr::IntGe(left, right)),
_ => unreachable!(),
}
}
_ => Ok(TestExpr::StringNonEmpty(left)),
}
}
}