basemind 0.24.0

Full AI context layer over MCP — tree-sitter code-map, document RAG (PDF/Office/HTML/email + OCR + reranker), shared agent memory, on-demand web crawl, git history + blame + per-symbol diff. 300+ languages, 10+ coding-agent harnesses, content-addressed Fjall + LanceDB.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
//! The `shell` domain dispatcher and its helper bodies.
//!
//! [`run_shell`] is what the `#[tool]` shim and the CLI both call: it validates the flat
//! [`ShellParams`] against the selected [`ShellMode`] and delegates to the per-mode body. Each
//! body resolves the embedded [`crate::shells::ShellRuntime`] off `ServerState`, drives one rmux
//! operation (spawn / send / capture / kill / list / broadcast), and returns a JSON
//! [`CallToolResult`]. The whole module is gated on `feature = "shells"`.

#![cfg(feature = "shells")]

use rmcp::ErrorData as McpError;
use rmcp::model::CallToolResult;

use super::ServerState;
use super::helpers::json_result;
use super::mode::{ShellMode, reject_unsupported};
use super::types_shells::{
    ShellBroadcastParams, ShellBroadcastResponse, ShellCaptureParams, ShellCaptureResponse, ShellEnv, ShellKillParams,
    ShellKillResponse, ShellListParams, ShellListResponse, ShellParams, ShellSendParams, ShellSendResponse,
    ShellSessionView, ShellSpawnParams, ShellSpawnResponse,
};
use crate::shells::SessionId;
use crate::shells::session::ShellCommand;

/// Map an internal `anyhow` failure to an MCP internal error with a prefix.
fn mcp_internal(prefix: &str, err: impl std::fmt::Display) -> McpError {
    McpError::internal_error(format!("{prefix}: {err}"), None)
}

/// Reconstruct a [`SessionId`] from the caller-supplied string. The id is opaque
/// to the client, so any non-empty string is accepted here and resolution
/// against the shared daemon's live session set decides validity.
fn parse_session_id(raw: &str) -> Result<SessionId, McpError> {
    if raw.trim().is_empty() {
        return Err(McpError::invalid_params("session_id must not be empty", None));
    }
    Ok(SessionId::new(raw))
}

/// The `invalid_params` message for an id the daemon listed but does not hold.
fn unknown_session_error(raw: &str) -> McpError {
    McpError::invalid_params(
        format!("unknown session_id {raw:?}; it may have been killed or never existed"),
        None,
    )
}

/// Resolve a `session_id` to its rmux session name against the shared daemon.
///
/// The two failure modes stay deliberately distinct: a daemon that is unreachable or
/// erroring surfaces as an internal error naming the transport failure, while a
/// successful listing that lacks the id is `invalid_params`. Collapsing them makes a
/// broken daemon look like a stale id and hides the outage from the caller.
async fn require_session(state: &ServerState, raw: &str) -> Result<(SessionId, rmux_sdk::SessionName), McpError> {
    let id = parse_session_id(raw)?;
    let resolved = state
        .shared
        .shell_runtime
        .resolve(&id)
        .await
        .map_err(|e| mcp_internal("resolve session against the embedded shell daemon", e))?;
    resolved
        .map(|name| (id, name))
        .ok_or_else(|| unknown_session_error(raw))
}

/// Fail a mode that was given a field belonging to some other mode.
///
/// Inverted against `allowed` rather than listing every rejected field per mode: with six modes
/// and nine sibling fields, an explicit per-mode reject list is where a newly added field silently
/// becomes accept-everywhere.
fn reject_foreign_fields(mode: ShellMode, present: &[(&str, bool)], allowed: &[&str]) -> Result<(), McpError> {
    let foreign: Vec<(&str, bool)> = present
        .iter()
        .filter(|(field, _)| !allowed.contains(field))
        .copied()
        .collect();
    reject_unsupported(ShellMode::DOMAIN, mode.as_str(), &foreign)
}

/// Unwrap a field this mode cannot run without, naming the exact `mode`/field pair.
fn require_field<T>(mode: ShellMode, field: &str, value: Option<T>) -> Result<T, McpError> {
    value
        .ok_or_else(|| McpError::invalid_params(format!("`shell` mode=\"{}\" requires `{field}`", mode.as_str()), None))
}

/// The fields each mode accepts. Everything else on [`ShellParams`] is rejected for that mode.
fn allowed_fields(mode: ShellMode) -> &'static [&'static str] {
    match mode {
        ShellMode::Spawn => &["command", "cwd", "env", "title"],
        ShellMode::Send => &["session_id", "text", "enter"],
        ShellMode::Capture => &["session_id", "lines"],
        ShellMode::Kill => &["session_id"],
        ShellMode::List => &[],
        ShellMode::Broadcast => &["session_ids", "text", "enter"],
    }
}

/// Dispatch the single `shell` tool onto the per-operation body its `mode` selects.
///
/// Fields belonging to another mode are rejected rather than dropped: a silently ignored `lines`
/// on a `send` call reads to an agent as a successful send that also captured output.
pub(super) async fn run_shell(state: &ServerState, params: ShellParams) -> Result<CallToolResult, McpError> {
    let ShellParams {
        mode,
        command,
        cwd,
        env,
        title,
        session_id,
        session_ids,
        text,
        enter,
        lines,
    } = params;
    let present = [
        ("command", command.is_some()),
        ("cwd", cwd.is_some()),
        ("env", env.is_some()),
        ("title", title.is_some()),
        ("session_id", session_id.is_some()),
        ("session_ids", session_ids.is_some()),
        ("text", text.is_some()),
        ("enter", enter.is_some()),
        ("lines", lines.is_some()),
    ];
    reject_foreign_fields(mode, &present, allowed_fields(mode))?;

    match mode {
        ShellMode::Spawn => {
            run_shell_spawn(
                state,
                ShellSpawnParams {
                    command: require_field(mode, "command", command)?,
                    cwd,
                    env,
                    title,
                },
            )
            .await
        }
        ShellMode::Send => {
            run_shell_send(
                state,
                ShellSendParams {
                    session_id: require_field(mode, "session_id", session_id)?,
                    text: require_field(mode, "text", text)?,
                    enter: enter.unwrap_or(true),
                },
            )
            .await
        }
        ShellMode::Capture => {
            run_shell_capture(
                state,
                ShellCaptureParams {
                    session_id: require_field(mode, "session_id", session_id)?,
                    lines,
                },
            )
            .await
        }
        ShellMode::Kill => {
            run_shell_kill(
                state,
                ShellKillParams {
                    session_id: require_field(mode, "session_id", session_id)?,
                },
            )
            .await
        }
        ShellMode::List => run_shell_list(state, ShellListParams {}).await,
        ShellMode::Broadcast => {
            run_shell_broadcast(
                state,
                ShellBroadcastParams {
                    session_ids: require_field(mode, "session_ids", session_ids)?,
                    text: require_field(mode, "text", text)?,
                    enter: enter.unwrap_or(true),
                },
            )
            .await
        }
    }
}

/// `shell` mode `spawn`: create a detached headless shell session.
///
/// When the server is built with comms enabled (`feature = "comms"`, unix), the spawn is coupled
/// to a comms THREAD so the parent (this server) and the spawned child can talk bidirectionally: a
/// thread with explicit members `[parent, child]` (plus a subject, satisfying the ≥2-of-3
/// addressing rule) is started BEFORE the shell starts, and the child inherits `BASEMIND_THREAD_ID`
/// / `BASEMIND_PARENT_AGENT_ID` / `BASEMIND_AGENT_ID` in its environment. Because the child is an
/// explicit member, the thread already surfaces in its inbox — no auto-join. The coupling is
/// created atomically before the spawn: a failure aborts the spawn, so no thread-less session
/// leaks. When comms is disabled the tool behaves headless and `room_id` / `child_agent` are `None`.
pub(super) async fn run_shell_spawn(state: &ServerState, params: ShellSpawnParams) -> Result<CallToolResult, McpError> {
    if !state.shared.config.shells.enabled {
        return Err(McpError::invalid_params(
            "shells are disabled in config ([shells].enabled = false)",
            None,
        ));
    }

    let cwd = resolve_shell_cwd(&state.shared.root, params.cwd).await?;

    let session_id = state.shared.shell_runtime.mint_session_id();

    #[cfg_attr(not(all(feature = "comms", any(unix, windows))), allow(unused_mut))]
    let mut environment = build_environment(params.env.unwrap_or_default())?;

    #[cfg(all(feature = "comms", any(unix, windows)))]
    let (room_id, child_agent) = couple_session_room(state, session_id.as_str(), &mut environment).await?;
    #[cfg(not(all(feature = "comms", any(unix, windows))))]
    let (room_id, child_agent): (Option<String>, Option<String>) = (None, None);

    let spawned = state
        .shared
        .shell_runtime
        .spawn(
            session_id.clone(),
            ShellCommand::Shell(params.command),
            Some(cwd),
            environment,
            state.shared.config.shells.default_cols,
            state.shared.config.shells.default_rows,
        )
        .await;

    let (session_id, name) = match spawned {
        Ok(pair) => pair,
        Err(error) => {
            #[cfg(all(feature = "comms", any(unix, windows)))]
            if let Some(room) = room_id.as_deref() {
                rollback_session_room(state, room).await;
            }
            return Err(mcp_internal("spawn shell session", error));
        }
    };

    let target = crate::shells::launcher::AttachTarget {
        session_name: name.as_str().to_string(),
        socket_path: state.shared.shell_runtime.socket_path().to_path_buf(),
        cols: state.shared.config.shells.default_cols,
        rows: state.shared.config.shells.default_rows,
        exe: std::env::current_exe().unwrap_or_else(|_| std::path::PathBuf::from("basemind")),
    };
    let attach_command = target.attach_command();

    let visual = state.shared.config.shells.visual;
    if visual != crate::config::VisualMode::Headless {
        let terminal = state.shared.config.shells.terminal;
        if let Err(error) = crate::shells::launcher::present(visual, terminal, &target) {
            return Err(presentation_error(error, &session_id, &attach_command));
        }
    }

    let response = ShellSpawnResponse {
        session_id: session_id.to_string(),
        attach_command,
        room_id,
        child_agent,
    };
    json_result(&response)
}

async fn resolve_shell_cwd(root: &std::path::Path, cwd: Option<crate::path::RelPath>) -> Result<String, McpError> {
    let canonical_root = tokio::fs::canonicalize(root)
        .await
        .map_err(|error| mcp_internal("resolve workspace root", error))?;
    let candidate = match cwd {
        Some(rel) => {
            let raw = rel
                .as_str()
                .ok_or_else(|| McpError::invalid_params("cwd is not valid UTF-8", None))?;
            let relative = std::path::Path::new(raw);
            if relative.is_absolute() {
                return Err(McpError::invalid_params("cwd must be repository-relative", None));
            }
            root.join(relative)
        }
        None => root.to_path_buf(),
    };
    let absolute = tokio::fs::canonicalize(candidate)
        .await
        .map_err(|error| McpError::invalid_params(format!("cwd cannot be resolved: {error}"), None))?;
    let metadata = tokio::fs::metadata(&absolute)
        .await
        .map_err(|error| McpError::invalid_params(format!("cwd cannot be inspected: {error}"), None))?;
    if !absolute.starts_with(&canonical_root) || !metadata.is_dir() {
        return Err(McpError::invalid_params(
            "cwd must resolve to a directory inside the repository root",
            None,
        ));
    }
    absolute
        .to_str()
        .map(ToOwned::to_owned)
        .ok_or_else(|| McpError::invalid_params("cwd is not valid UTF-8", None))
}

/// Turn a failed visual presentation into the error the caller sees.
///
/// The caller asked for a *visible* session; answering `Ok` with an `attach_command` after the
/// terminal never launched reports a running command that nobody can see — the second half of the
/// "opens a shell but launches nothing in it" bug. The session itself is genuinely alive and may
/// already have side effects, so it is left running rather than torn down: the error carries the
/// `session_id` and the attach command, and mode `list` (daemon-backed) still shows it, so every
/// recovery path — capture, kill, manual attach — stays open.
fn presentation_error(error: anyhow::Error, session_id: &SessionId, attach_command: &str) -> McpError {
    mcp_internal(
        "present shell session",
        format!("{error}; session {session_id} is live — attach with: {attach_command}"),
    )
}

/// Loader-injection env vars worth a heads-up when a caller supplies them: they let the child
/// preload arbitrary shared objects. We warn rather than reject — a legitimate caller may need
/// them — so the spawn still proceeds.
const LOADER_VARS: [&str; 5] = [
    "LD_PRELOAD",
    "LD_AUDIT",
    "DYLD_INSERT_LIBRARIES",
    "DYLD_LIBRARY_PATH",
    "DYLD_FALLBACK_LIBRARY_PATH",
];

/// Validate + sanitize the caller-supplied env entries, then render them as `KEY=VALUE` strings.
///
/// Rejects a key that is empty or contains `=` / NUL / newline / carriage return (any of which
/// would let the entry smuggle an extra variable or a control char into the process env), and a
/// value containing NUL / newline / carriage return. A loader-injection var (`LD_PRELOAD` etc.) is
/// allowed but logged at WARN.
fn build_environment(env: Vec<ShellEnv>) -> Result<Vec<String>, McpError> {
    let mut out = Vec::with_capacity(env.len());
    for kv in env {
        if kv.key.is_empty() {
            return Err(McpError::invalid_params("env key must not be empty", None));
        }
        if kv.key.contains(['=', '\0', '\n', '\r']) {
            return Err(McpError::invalid_params(
                format!(
                    "env key {:?} must not contain '=', NUL, newline, or carriage return",
                    kv.key
                ),
                None,
            ));
        }
        if kv.value.contains(['\0', '\n', '\r']) {
            return Err(McpError::invalid_params(
                format!(
                    "env value for key {:?} must not contain NUL, newline, or carriage return",
                    kv.key
                ),
                None,
            ));
        }
        if LOADER_VARS.contains(&kv.key.as_str()) {
            tracing::warn!(
                key = %kv.key,
                "shell_spawn: caller supplied a loader-injection env var; passing it through"
            );
        }
        out.push(format!("{}={}", kv.key, kv.value));
    }
    Ok(out)
}

/// Best-effort comms coupling for a spawned session. Derives the child agent from the parent +
/// the pre-minted `session_id`, starts a THREAD with members `[parent, child]` + a subject, and
/// injects the child's identity env (plus `BASEMIND_THREAD_ID`) into `environment` BEFORE the shell
/// is spawned. Returns `(thread_id, child_agent)` on success.
///
/// The coupling is OPTIONAL: comms is an add-on, so a broker that is unreachable / down must not
/// fail the shell spawn. A comms failure is logged and the function returns `(None, None)`, leaving
/// `environment` untouched so the session spawns headless.
///
/// # Threat model
/// The child's identity is asserted purely through inherited `BASEMIND_*` env vars. A spawned child
/// is free to overwrite `BASEMIND_AGENT_ID` and claim another agent's id — the broker does not
/// cross-check. Acceptable for a local single-user dev tool (every process runs as the same uid).
#[cfg(all(feature = "comms", any(unix, windows)))]
async fn couple_session_room(
    state: &ServerState,
    session_id: &str,
    environment: &mut Vec<String>,
) -> Result<(Option<String>, Option<String>), McpError> {
    match try_couple_session_thread(state, session_id, environment).await {
        Ok((thread_id, child_agent)) => Ok((Some(thread_id), Some(child_agent))),
        Err(error) => {
            tracing::warn!(
                error = %error,
                "shell_spawn: comms coupling unavailable; spawning the session headless"
            );
            Ok((None, None))
        }
    }
}

/// The fallible inner body of [`couple_session_room`]. On `Ok`, the thread exists (with the parent
/// and child as members), and the child's identity env + `BASEMIND_THREAD_ID` have been appended.
#[cfg(all(feature = "comms", any(unix, windows)))]
async fn try_couple_session_thread(
    state: &ServerState,
    session_id: &str,
    environment: &mut Vec<String>,
) -> Result<(String, String), McpError> {
    use super::helpers_comms::{comms_err, resolve_comms_client};
    use crate::comms::ids::AgentId;

    let parent = &state.agent_id;
    let comms_session_id = session_id.to_string();

    let child_candidate = format!("{parent}-{comms_session_id}");
    let child_agent = match AgentId::parse(child_candidate.clone()) {
        Ok(id) => id,
        Err(error) => {
            let fallback = format!("shell-{comms_session_id}");
            let fallback_id = AgentId::parse(fallback.clone()).map_err(|fallback_err| {
                comms_err(format!(
                    "derive child agent id: candidate {child_candidate:?} rejected ({error}) and \
                     fallback {fallback:?} also rejected ({fallback_err})"
                ))
            })?;
            tracing::warn!(
                error = %error,
                rejected_candidate_len = child_candidate.len(),
                fallback = %fallback,
                "shell_spawn: derived child agent id rejected by AgentId::parse; using fallback"
            );
            fallback_id
        }
    };

    let subject = format!("shell session {comms_session_id} ({parent} -> {child_agent})");
    let thread_id = {
        let handle = resolve_comms_client(state, None).await?;
        let mut client = handle.lock().await;
        let thread = client
            .start_thread(Some(subject), None, vec![child_agent.clone()])
            .await
            .map_err(comms_err)?;
        thread.id.into_string()
    };

    const IDENTITY_KEYS: [&str; 3] = ["BASEMIND_AGENT_ID", "BASEMIND_PARENT_AGENT_ID", "BASEMIND_THREAD_ID"];
    environment.retain(|entry| {
        let key = entry.split('=').next().unwrap_or(entry);
        !IDENTITY_KEYS.contains(&key)
    });
    environment.push(format!("BASEMIND_AGENT_ID={child_agent}"));
    environment.push(format!("BASEMIND_PARENT_AGENT_ID={parent}"));
    environment.push(format!("BASEMIND_THREAD_ID={thread_id}"));

    Ok((thread_id, child_agent.into_string()))
}

/// Roll back the orphaned coupling thread after the spawn failed: the parent (its creator) archives
/// it so it does not linger as an active, member-less-child thread. Best-effort — a failure is
/// logged at WARN (naming the orphan thread id) and swallowed so the original spawn error propagates.
#[cfg(all(feature = "comms", any(unix, windows)))]
async fn rollback_session_room(state: &ServerState, thread_id: &str) {
    use super::helpers_comms::resolve_comms_client;
    use crate::comms::ids::ThreadId;

    let Ok(thread) = ThreadId::parse(thread_id.to_string()) else {
        tracing::warn!(thread_id = %thread_id, "shell_spawn rollback: orphan thread id is unparsable");
        return;
    };
    let archive = async {
        let handle = resolve_comms_client(state, None).await?;
        let mut client = handle.lock().await;
        client
            .archive_thread(thread)
            .await
            .map_err(super::helpers_comms::comms_err)
    };
    if let Err(error) = archive.await {
        tracing::warn!(
            error = %error,
            thread_id = %thread_id,
            "shell_spawn rollback: failed to archive orphaned coupling thread; it may leak"
        );
    }
}

/// `shell` mode `send`: write text (optionally with a newline) to a session's stdin.
pub(super) async fn run_shell_send(state: &ServerState, params: ShellSendParams) -> Result<CallToolResult, McpError> {
    let (id, name) = require_session(state, &params.session_id).await?;
    let session = state
        .shared
        .shell_runtime
        .rmux()
        .await
        .map_err(|e| mcp_internal("connect embedded shell daemon", e))?
        .session(name)
        .await
        .map_err(|e| mcp_internal("open shell session", e))?;
    crate::shells::session::send_text(&session, &params.text, params.enter)
        .await
        .map_err(|e| mcp_internal("send to shell session", e))?;
    json_result(&ShellSendResponse {
        session_id: id.to_string(),
        sent: true,
    })
}

/// `shell` mode `capture`: return the visible screen text of a session's primary pane.
pub(super) async fn run_shell_capture(
    state: &ServerState,
    params: ShellCaptureParams,
) -> Result<CallToolResult, McpError> {
    if params
        .lines
        .is_some_and(|line_count| line_count > crate::shells::session::MAX_CAPTURE_LINES)
    {
        return Err(McpError::invalid_params(
            format!("lines must be at most {}", crate::shells::session::MAX_CAPTURE_LINES),
            None,
        ));
    }
    let (_id, name) = require_session(state, &params.session_id).await?;
    let session = state
        .shared
        .shell_runtime
        .rmux()
        .await
        .map_err(|e| mcp_internal("connect embedded shell daemon", e))?
        .session(name)
        .await
        .map_err(|e| mcp_internal("open shell session", e))?;
    let text = crate::shells::session::capture(&session, params.lines)
        .await
        .map_err(|e| mcp_internal("capture shell output", e))?;
    json_result(&ShellCaptureResponse { text })
}

/// `shell` mode `kill`: terminate a session.
///
/// Nothing is unregistered afterwards: the daemon's live session set is the only registry, so the
/// killed session stops resolving as soon as the daemon drops it.
pub(super) async fn run_shell_kill(state: &ServerState, params: ShellKillParams) -> Result<CallToolResult, McpError> {
    let (id, name) = require_session(state, &params.session_id).await?;
    let session = state
        .shared
        .shell_runtime
        .rmux()
        .await
        .map_err(|e| mcp_internal("connect embedded shell daemon", e))?
        .session(name)
        .await
        .map_err(|e| mcp_internal("open shell session", e))?;
    let killed = crate::shells::session::kill_session(&session)
        .await
        .map_err(|e| mcp_internal("kill shell session", e))?;

    json_result(&ShellKillResponse {
        session_id: id.to_string(),
        killed,
    })
}

/// `shell` mode `broadcast`: send the same input to many sessions' primary panes.
pub(super) async fn run_shell_broadcast(
    state: &ServerState,
    params: ShellBroadcastParams,
) -> Result<CallToolResult, McpError> {
    if params.session_ids.is_empty() {
        return Err(McpError::invalid_params("session_ids must not be empty", None));
    }
    let mut ids = Vec::with_capacity(params.session_ids.len());
    for raw in &params.session_ids {
        ids.push(parse_session_id(raw)?);
    }
    // `broadcast` resolves every id against one daemon snapshot and reports an unknown id as an
    // opaque `anyhow` failure. Listing once here keeps "no such session" an `invalid_params` answer
    // without paying a daemon round-trip per id.
    let live = state
        .shared
        .shell_runtime
        .list()
        .await
        .map_err(|e| mcp_internal("list shell sessions", e))?;
    let live_ids: ahash::AHashSet<&str> = live.iter().map(|info| info.session_id.as_str()).collect();
    if let Some(unknown) = ids.iter().find(|id| !live_ids.contains(id.as_str())) {
        return Err(unknown_session_error(unknown.as_str()));
    }
    let delivered = state
        .shared
        .shell_runtime
        .broadcast(&ids, &params.text, params.enter)
        .await
        .map_err(|e| mcp_internal("broadcast to shell sessions", e))?;
    json_result(&ShellBroadcastResponse { delivered })
}

/// `shell` mode `list`: enumerate every session the shared shell daemon currently holds, each flagged by
/// its liveness.
///
/// The daemon is the registry, so sessions spawned by another basemind process (a CLI invocation or
/// a second `serve`) are listed here too. Completed retained sessions report `alive=false`; when a
/// transient rmux inspection cannot determine liveness, the runtime conservatively reports known
/// sessions as live rather than failing the whole list. The thread-model comms broker keeps no
/// session-lineage keyspace, so the `parent_agent` / `child_agent` / `room_id` fields on each row
/// stay `None`; a spawned session's coupling thread is surfaced by mode `spawn`'s own response.
pub(super) async fn run_shell_list(state: &ServerState, _params: ShellListParams) -> Result<CallToolResult, McpError> {
    let runtime = state
        .shared
        .shell_runtime
        .list()
        .await
        .map_err(|e| mcp_internal("list shell sessions", e))?;

    let mut sessions: Vec<ShellSessionView> = runtime
        .into_iter()
        .map(|info| ShellSessionView {
            session_id: info.session_id.to_string(),
            name: info.name.as_str().to_string(),
            alive: info.alive,
            parent_agent: None,
            child_agent: None,
            room_id: None,
        })
        .collect();
    sessions.sort_by(|a, b| a.session_id.cmp(&b.session_id));
    json_result(&ShellListResponse { sessions })
}

#[cfg(test)]
mod cwd_tests {
    use super::resolve_shell_cwd;
    use crate::path::RelPath;

    #[tokio::test]
    async fn shell_cwd_rejects_absolute_path_outside_workspace() {
        let root = tempfile::tempdir().expect("workspace tempdir");
        let outside = tempfile::tempdir().expect("outside tempdir");
        let result = resolve_shell_cwd(
            root.path(),
            Some(RelPath::from(outside.path().to_string_lossy().as_ref())),
        )
        .await;
        assert!(result.is_err(), "absolute cwd outside the workspace must be rejected");
    }

    #[cfg(unix)]
    #[tokio::test]
    async fn shell_cwd_rejects_symlink_escape() {
        let root = tempfile::tempdir().expect("workspace tempdir");
        let outside = tempfile::tempdir().expect("outside tempdir");
        std::os::unix::fs::symlink(outside.path(), root.path().join("outside-link")).expect("create escaping symlink");

        let result = resolve_shell_cwd(root.path(), Some(RelPath::from("outside-link"))).await;
        assert!(result.is_err(), "symlink cwd outside the workspace must be rejected");
    }
}