bartos 1.4.7

A bartos server records information from bartoc instances and serves as a central hub for job scheduling
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127

// Copyright (c) 2025 barto developers
//
// Licensed under the Apache License, Version 2.0
// <LICENSE-APACHE or https://www.apache.org/licenses/LICENSE-2.0> or the MIT
// license <LICENSE-MIT or https://opensource.org/licenses/MIT>, at your
// option. All files in the project carrying such notice may not be copied,
// modified, or distributed except according to those terms.

mod cli;
mod worker;

use actix_web::{
    HttpRequest,
    web::{ServiceConfig, get},
};
use serde::Deserialize;
use subtle::ConstantTimeEq as _;

#[derive(Deserialize)]
pub(crate) struct Name {
    name: Option<String>,
}

impl Name {
    pub(crate) fn describe(&self, request: &HttpRequest) -> String {
        let conn_info = request.connection_info();
        let ip = conn_info
            .realip_remote_addr()
            .map_or_else(Self::unknown, ToString::to_string);
        let name = self
            .name
            .as_deref()
            .map_or_else(Self::unknown, ToString::to_string);
        format!("{name} ({ip})")
    }

    pub(crate) fn name(&self) -> String {
        self.name.clone().unwrap_or_else(Self::unknown)
    }

    pub(crate) fn ip(request: &HttpRequest) -> String {
        let conn_info = request.connection_info();
        conn_info
            .realip_remote_addr()
            .map_or_else(Self::unknown, ToString::to_string)
    }

    fn unknown() -> String {
        String::from("Unknown")
    }
}

/// Returns `true` if the request carries a valid `Authorization: Bearer <token>` header
/// matching `expected`, using a constant-time comparison to prevent timing attacks.
/// Returns `true` unconditionally when `expected` is `None` (no auth configured).
pub(crate) fn bearer_auth_ok(request: &HttpRequest, expected: Option<&str>) -> bool {
    let Some(expected) = expected else {
        return true;
    };
    let Some(header_val) = request.headers().get("Authorization") else {
        return false;
    };
    let Ok(header_str) = header_val.to_str() else {
        return false;
    };
    let Some(token) = header_str.strip_prefix("Bearer ") else {
        return false;
    };
    token.as_bytes().ct_eq(expected.as_bytes()).into()
}

pub(crate) fn insecure_config(cfg: &mut ServiceConfig) {
    _ = cfg
        .route("/ws/cli", get().to(cli::cli))
        .route("/ws/worker", get().to(worker::worker));
}

#[cfg(test)]
mod tests {
    use actix_web::test::TestRequest;

    use super::bearer_auth_ok;

    #[test]
    fn no_api_key_configured_always_passes() {
        let req = TestRequest::get().to_http_request();
        assert!(bearer_auth_ok(&req, None));
    }

    #[test]
    fn correct_bearer_token_passes() {
        let req = TestRequest::get()
            .insert_header(("Authorization", "Bearer my-secret"))
            .to_http_request();
        assert!(bearer_auth_ok(&req, Some("my-secret")));
    }

    #[test]
    fn wrong_token_rejected() {
        let req = TestRequest::get()
            .insert_header(("Authorization", "Bearer wrong-token"))
            .to_http_request();
        assert!(!bearer_auth_ok(&req, Some("my-secret")));
    }

    #[test]
    fn missing_header_rejected() {
        let req = TestRequest::get().to_http_request();
        assert!(!bearer_auth_ok(&req, Some("my-secret")));
    }

    #[test]
    fn non_bearer_scheme_rejected() {
        let req = TestRequest::get()
            .insert_header(("Authorization", "Basic my-secret"))
            .to_http_request();
        assert!(!bearer_auth_ok(&req, Some("my-secret")));
    }

    #[test]
    fn empty_token_rejected() {
        let req = TestRequest::get()
            .insert_header(("Authorization", "Bearer "))
            .to_http_request();
        assert!(!bearer_auth_ok(&req, Some("my-secret")));
    }
}