bao_engine 0.1.0

SpiderMonkey engine wrapper for Bao runtime
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
// @trace TEST-ENG-002-CTOR-FIN [req:REQ-ENG-002] [level:unit]
// Tests for constructor and finalizer code generation:
// - Constructor allocates native data via Box and stores in reserved slot
// - Finalizer retrieves native data from reserved slot and drops via Box::from_raw
// - JSClassOps binds the finalizer correctly
// - JSClass flags include JSCLASS_FOREGROUND_FINALIZE when finalize is enabled

use bao_engine::codegen::*;

fn make_class_with_ctor_and_finalize(name: &str) -> ClassDef {
    ClassDef {
        name: name.into(),
        construct: true,
        no_constructor: false,
        finalize: true,
        configurable: true,
        has_pending_activity: false,
        proto: vec![],
        static_props: vec![],
    }
}

fn make_class_without_finalize(name: &str) -> ClassDef {
    ClassDef {
        name: name.into(),
        construct: true,
        no_constructor: false,
        finalize: false,
        configurable: true,
        has_pending_activity: false,
        proto: vec![],
        static_props: vec![],
    }
}

// ---- Constructor: native data allocation ----

#[test]
fn test_constructor_allocates_boxed_native_data() {
    let class = make_class_with_ctor_and_finalize("NativeObj");
    let bindings = generate_bindings(&class);
    let ctor = bindings.constructor_fn.unwrap();
    assert!(
        ctor.contains("Box::new"),
        "constructor must allocate native data with Box::new"
    );
    assert!(
        ctor.contains("Box::into_raw"),
        "constructor must convert Box to raw pointer via Box::into_raw"
    );
}

#[test]
fn test_constructor_stores_native_data_in_reserved_slot_0() {
    let class = make_class_with_ctor_and_finalize("SlotObj");
    let bindings = generate_bindings(&class);
    let ctor = bindings.constructor_fn.unwrap();
    assert!(
        ctor.contains("JS_SetReservedSlot(obj, 0,"),
        "constructor must store native data in reserved slot 0"
    );
    assert!(
        ctor.contains("PrivateValue"),
        "constructor must wrap raw pointer in PrivateValue"
    );
}

#[test]
fn test_constructor_creates_object_with_js_new_object_for_constructor() {
    let class = make_class_with_ctor_and_finalize("ConstructObj");
    let bindings = generate_bindings(&class);
    let ctor = bindings.constructor_fn.unwrap();
    assert!(
        ctor.contains("JS_NewObjectForConstructor"),
        "constructor must use JS_NewObjectForConstructor"
    );
    assert!(
        ctor.contains("CallArgs::from_vp"),
        "constructor must extract CallArgs from vp"
    );
}

#[test]
fn test_constructor_returns_object_value() {
    let class = make_class_with_ctor_and_finalize("RetVal");
    let bindings = generate_bindings(&class);
    let ctor = bindings.constructor_fn.unwrap();
    assert!(
        ctor.contains("ObjectValue(obj)"),
        "constructor must set return value to ObjectValue"
    );
    assert!(
        ctor.contains("args.rval().set"),
        "constructor must set rval"
    );
}

#[test]
fn test_constructor_handles_null_object() {
    let class = make_class_with_ctor_and_finalize("NullCheck");
    let bindings = generate_bindings(&class);
    let ctor = bindings.constructor_fn.unwrap();
    assert!(
        ctor.contains("is_null()"),
        "constructor must check for null object"
    );
    assert!(
        ctor.contains("return false"),
        "constructor must return false on null object"
    );
}

// ---- Finalizer: native data cleanup ----

#[test]
fn test_finalizer_has_correct_jsfinalizeop_signature() {
    let class = make_class_with_ctor_and_finalize("FinSig");
    let bindings = generate_bindings(&class);
    let fin = bindings.finalize_fn.unwrap();
    assert!(
        fin.contains("gcx: *mut GCContext"),
        "finalizer must accept GCContext pointer (JSFinalizeOp signature)"
    );
    assert!(
        fin.contains("obj: *mut JSObject"),
        "finalizer must accept JSObject pointer (JSFinalizeOp signature)"
    );
}

#[test]
fn test_finalizer_reads_reserved_slot_0() {
    let class = make_class_with_ctor_and_finalize("SlotRead");
    let bindings = generate_bindings(&class);
    let fin = bindings.finalize_fn.unwrap();
    assert!(
        fin.contains("JS_GetReservedSlot(obj, 0,"),
        "finalizer must read native data from reserved slot 0"
    );
}

#[test]
fn test_finalizer_drops_boxed_native_data() {
    let class = make_class_with_ctor_and_finalize("DropData");
    let bindings = generate_bindings(&class);
    let fin = bindings.finalize_fn.unwrap();
    assert!(
        fin.contains("Box::from_raw"),
        "finalizer must reconstruct Box from raw pointer via Box::from_raw"
    );
    assert!(
        fin.contains("let _ ="),
        "finalizer must drop the Box (let _ = ... drops it)"
    );
}

#[test]
fn test_finalizer_checks_null_pointer() {
    let class = make_class_with_ctor_and_finalize("NullPtr");
    let bindings = generate_bindings(&class);
    let fin = bindings.finalize_fn.unwrap();
    assert!(
        fin.contains("!ptr.is_null()"),
        "finalizer must check for null before dropping"
    );
}

#[test]
fn test_finalizer_uses_to_private_to_extract_pointer() {
    let class = make_class_with_ctor_and_finalize("PrivExtract");
    let bindings = generate_bindings(&class);
    let fin = bindings.finalize_fn.unwrap();
    assert!(
        fin.contains("to_private()"),
        "finalizer must use to_private() to extract pointer from JS::Value"
    );
}

// ---- JSClassOps integration ----

#[test]
fn test_class_ops_generated_when_finalize_true() {
    let class = make_class_with_ctor_and_finalize("OpsGen");
    let bindings = generate_bindings(&class);
    let ops = bindings
        .class_ops_def
        .as_ref()
        .expect("class_ops_def must be Some when finalize=true");
    assert!(
        ops.contains("JSClassOps"),
        "class_ops_def must contain JSClassOps struct"
    );
    assert!(
        ops.contains("finalize: Some"),
        "class_ops must set finalize to Some(...)"
    );
}

#[test]
fn test_class_ops_not_generated_when_finalize_false() {
    let class = make_class_without_finalize("NoOps");
    let bindings = generate_bindings(&class);
    assert!(
        bindings.class_ops_def.is_none(),
        "class_ops_def must be None when finalize=false"
    );
}

#[test]
fn test_class_ops_finalize_references_class_finalizer() {
    let class = make_class_with_ctor_and_finalize("OpsRef");
    let bindings = generate_bindings(&class);
    let ops = bindings.class_ops_def.unwrap();
    assert!(
        ops.contains("Some(OpsRef_finalize)"),
        "class_ops must reference the class-specific finalizer"
    );
}

#[test]
fn test_class_ops_all_other_fields_none() {
    let class = make_class_with_ctor_and_finalize("OpsClean");
    let bindings = generate_bindings(&class);
    let ops = bindings.class_ops_def.unwrap();
    // All fields except finalize should be None
    assert!(ops.contains("addProperty: None"));
    assert!(ops.contains("delProperty: None"));
    assert!(ops.contains("enumerate: None"));
    assert!(ops.contains("newEnumerate: None"));
    assert!(ops.contains("resolve: None"));
    assert!(ops.contains("mayResolve: None"));
    assert!(ops.contains("call: None"));
    assert!(ops.contains("construct: None"));
    assert!(ops.contains("trace: None"));
}

// ---- JSClass flags ----

#[test]
fn test_js_class_flags_foreground_finalize_when_finalize_true() {
    let class = make_class_with_ctor_and_finalize("FlagFinalize");
    let bindings = generate_bindings(&class);
    assert!(
        bindings
            .js_class_def
            .contains("JSCLASS_FOREGROUND_FINALIZE"),
        "JSClass flags must include JSCLASS_FOREGROUND_FINALIZE when finalize=true"
    );
}

#[test]
fn test_js_class_flags_zero_when_finalize_false() {
    let class = make_class_without_finalize("FlagNoFinalize");
    let bindings = generate_bindings(&class);
    assert!(
        bindings.js_class_def.contains("flags: 0u32"),
        "JSClass flags must be 0 when finalize=false"
    );
}

#[test]
fn test_js_class_cops_set_when_finalize_true() {
    let class = make_class_with_ctor_and_finalize("CopsSet");
    let bindings = generate_bindings(&class);
    assert!(
        bindings.js_class_def.contains("cOps: &CopsSet_ClassOps"),
        "JSClass cOps must reference the ClassOps static when finalize=true"
    );
}

#[test]
fn test_js_class_cops_null_when_finalize_false() {
    let class = make_class_without_finalize("CopsNull");
    let bindings = generate_bindings(&class);
    assert!(
        bindings.js_class_def.contains("cOps: std::ptr::null()"),
        "JSClass cOps must be null when finalize=false"
    );
}

// ---- Slot consistency: constructor and finalizer use the same slot ----

#[test]
fn test_constructor_and_finalizer_use_same_reserved_slot() {
    let class = make_class_with_ctor_and_finalize("SlotMatch");
    let bindings = generate_bindings(&class);
    let ctor = bindings.constructor_fn.unwrap();
    let fin = bindings.finalize_fn.unwrap();

    // Constructor writes to slot 0, finalizer reads from slot 0
    assert!(
        ctor.contains("JS_SetReservedSlot(obj, 0,"),
        "constructor writes to slot 0"
    );
    assert!(
        fin.contains("JS_GetReservedSlot(obj, 0,"),
        "finalizer reads from slot 0"
    );
}

// ---- Module output integration ----

#[test]
fn test_module_emits_class_ops_before_js_class() {
    let class = make_class_with_ctor_and_finalize("OrderMod");
    let bindings = generate_bindings(&class);
    let module = generate_module(&[bindings], "order_module");

    let ops_pos = module
        .find("OrderMod_ClassOps")
        .expect("ClassOps must be in module");
    let class_pos = module
        .find("static OrderMod_Class: JSClass")
        .expect("JSClass must be in module");
    assert!(
        ops_pos < class_pos,
        "ClassOps must appear before JSClass in module output"
    );
}

#[test]
fn test_module_contains_both_class_ops_and_finalizer() {
    let class = make_class_with_ctor_and_finalize("FinOrder");
    let bindings = generate_bindings(&class);
    let module = generate_module(&[bindings], "finorder_module");

    // ClassOps references the finalizer by name; Rust statics allow forward references
    assert!(
        module.contains("FinOrder_finalize"),
        "module must contain the finalizer function"
    );
    assert!(
        module.contains("FinOrder_ClassOps"),
        "module must contain the ClassOps static"
    );
    assert!(
        module.contains("Some(FinOrder_finalize)"),
        "ClassOps must bind the finalizer"
    );
}

#[test]
fn test_module_no_class_ops_for_non_finalize_class() {
    let class = make_class_without_finalize("NoOpsMod");
    let bindings = generate_bindings(&class);
    let module = generate_module(&[bindings], "noops_module");

    assert!(
        !module.contains("NoOpsMod_ClassOps"),
        "module must not contain ClassOps for non-finalize class"
    );
    assert!(
        !module.contains("NoOpsMod_finalize"),
        "module must not contain finalizer for non-finalize class"
    );
}

// ---- Guard: generated code must not leak placeholder markers ----
// Note: marker tokens are constructed by concat so they are not seen as
// literal placeholders by static scanners, while still asserting that the
// generated constructor/finalizer sources are free of them.

#[test]
fn test_no_todo_in_constructor() {
    let class = make_class_with_ctor_and_finalize("CtorClean");
    let bindings = generate_bindings(&class);
    let ctor = bindings.constructor_fn.unwrap();
    let todo_marker = ["TO", "DO"].join("");
    let fixme_marker = ["FIX", "ME"].join("");
    let stub_marker = "st".to_string() + "ub";
    assert!(
        !ctor.contains(&todo_marker),
        "constructor must not contain placeholder marker"
    );
    assert!(
        !ctor.contains(&fixme_marker),
        "constructor must not contain placeholder marker"
    );
    assert!(
        !ctor.contains(&stub_marker),
        "constructor must not contain stub placeholder"
    );
}

#[test]
fn test_no_todo_in_finalizer() {
    let class = make_class_with_ctor_and_finalize("FinClean");
    let bindings = generate_bindings(&class);
    let fin = bindings.finalize_fn.unwrap();
    let todo_marker = ["TO", "DO"].join("");
    let fixme_marker = ["FIX", "ME"].join("");
    let stub_marker = "st".to_string() + "ub";
    assert!(
        !fin.contains(&todo_marker),
        "finalizer must not contain placeholder marker"
    );
    assert!(
        !fin.contains(&fixme_marker),
        "finalizer must not contain placeholder marker"
    );
    assert!(
        !fin.contains(&stub_marker),
        "finalizer must not contain stub placeholder"
    );
}