1use async_trait::async_trait;
2use bamboo_agent_core::{Tool, ToolCtx, ToolError, ToolOutcome, ToolResult};
3use serde::Deserialize;
4use serde_json::json;
5use std::collections::HashSet;
6use std::path::Path;
7
8use super::read_tracker::{BaselineAdvance, ReadState};
9use super::{content_diagnostics, file_change, read_tracker};
10
11const MAX_PATCH_BYTES: usize = 256 * 1024;
12const MAX_PATCH_BLOCKS: usize = 128;
13const MAX_PATCH_BLOCK_BYTES: usize = 64 * 1024;
14const MAX_SAFE_EDIT_SCOPE_LINES: usize = 120;
15const MAX_SAFE_REPLACE_ALL_OCCURRENCES: usize = 8;
16const MAX_SAFE_REPLACE_ALL_SCOPE_LINES: usize = 80;
17const MIN_REPLACE_ALL_NON_WHITESPACE_CHARS: usize = 2;
18const MIN_REPLACE_ALL_LINES: usize = 1;
19
20#[derive(Debug, Deserialize)]
21struct EditArgs {
22 file_path: String,
23 #[serde(default)]
24 old_string: Option<String>,
25 #[serde(default)]
26 new_string: Option<String>,
27 #[serde(default)]
28 replace_all: Option<bool>,
29 #[serde(default)]
30 patch: Option<String>,
31 #[serde(default)]
32 line_number: Option<usize>,
33}
34
35pub struct EditTool;
36
37#[derive(Debug, Clone)]
38struct ReplacementCandidate {
39 start: usize,
40 matched_len: usize,
41 replacement: String,
42 start_line: usize,
43 end_line: usize,
44}
45
46#[derive(Debug, Clone)]
47struct AppliedEdit {
48 updated: String,
49 replacements: usize,
50}
51
52impl EditTool {
53 pub fn new() -> Self {
54 Self
55 }
56
57 fn to_lf(value: &str) -> String {
58 value.replace("\r\n", "\n")
59 }
60
61 fn to_crlf(value: &str) -> String {
62 Self::to_lf(value).replace('\n', "\r\n")
63 }
64
65 fn has_meaningful_optional_text(value: Option<&str>) -> bool {
66 value.is_some_and(|text| !text.is_empty())
67 }
68
69 fn line_starts(content: &str) -> Vec<usize> {
70 let mut starts = vec![0usize];
71 for (idx, byte) in content.bytes().enumerate() {
72 if byte == b'\n' && idx + 1 < content.len() {
73 starts.push(idx + 1);
74 }
75 }
76 starts
77 }
78
79 fn line_for_offset(line_starts: &[usize], offset: usize) -> usize {
80 line_starts.partition_point(|line_start| *line_start <= offset)
81 }
82
83 fn has_candidate_containing_line(
84 candidates: &[ReplacementCandidate],
85 line_number: usize,
86 ) -> bool {
87 candidates.iter().any(|candidate| {
88 candidate.start_line <= line_number && line_number <= candidate.end_line
89 })
90 }
91
92 fn validate_replace_all_scope(old_string: &str) -> Result<(), ToolError> {
93 let non_whitespace_chars = old_string.chars().filter(|ch| !ch.is_whitespace()).count();
94 if non_whitespace_chars < MIN_REPLACE_ALL_NON_WHITESPACE_CHARS {
95 return Err(ToolError::InvalidArguments(format!(
96 "replace_all requires old_string to contain at least {} non-whitespace characters",
97 MIN_REPLACE_ALL_NON_WHITESPACE_CHARS
98 )));
99 }
100
101 let non_empty_lines = old_string
102 .lines()
103 .filter(|line| !line.trim().is_empty())
104 .count();
105 if non_empty_lines < MIN_REPLACE_ALL_LINES {
106 return Err(ToolError::InvalidArguments(
107 "replace_all requires old_string to contain at least one non-empty line"
108 .to_string(),
109 ));
110 }
111
112 Ok(())
113 }
114
115 fn ensure_safe_scope(
116 replace_all: bool,
117 replacements: usize,
118 touched_lines: usize,
119 ) -> Result<(), ToolError> {
120 if replace_all && replacements > MAX_SAFE_REPLACE_ALL_OCCURRENCES {
121 return Err(ToolError::Execution(format!(
122 "replace_all would modify {} occurrences, exceeding the safe limit of {}; provide a more specific old_string or use patch mode",
123 replacements, MAX_SAFE_REPLACE_ALL_OCCURRENCES
124 )));
125 }
126
127 let max_scope = if replace_all {
128 MAX_SAFE_REPLACE_ALL_SCOPE_LINES
129 } else {
130 MAX_SAFE_EDIT_SCOPE_LINES
131 };
132
133 if touched_lines > max_scope {
134 let guidance = if replace_all {
135 "provide a more specific old_string or use patch mode"
136 } else {
137 "split the change into smaller patches or use Write for intentional full-file rewrites"
138 };
139 return Err(ToolError::Execution(format!(
140 "Edit would touch {} diff lines, exceeding the safe limit of {}; {}",
141 touched_lines, max_scope, guidance
142 )));
143 }
144
145 Ok(())
146 }
147
148 fn replacement_variants(
149 content: &str,
150 old_text: &str,
151 new_text: &str,
152 ) -> Vec<(String, String)> {
153 let mut variants: Vec<(String, String)> = Vec::new();
154 let mut seen_variants: HashSet<(String, String)> = HashSet::new();
155 let mut push_variant = |search: String, replace: String| {
156 if seen_variants.insert((search.clone(), replace.clone())) {
157 variants.push((search, replace));
158 }
159 };
160
161 push_variant(old_text.to_string(), new_text.to_string());
162 push_variant(Self::to_lf(old_text), Self::to_lf(new_text));
163 if content.contains("\r\n") {
164 push_variant(Self::to_crlf(old_text), Self::to_crlf(new_text));
165 }
166
167 variants
168 }
169
170 fn collect_candidates(
171 content: &str,
172 old_text: &str,
173 new_text: &str,
174 ) -> Vec<ReplacementCandidate> {
175 let variants = Self::replacement_variants(content, old_text, new_text);
176 let line_starts = Self::line_starts(content);
177 let mut out: Vec<ReplacementCandidate> = Vec::new();
178 let mut seen_matches: HashSet<(usize, usize, String)> = HashSet::new();
179
180 for (search, replacement) in variants {
181 if search.is_empty() {
182 continue;
183 }
184 for (start, _) in content.match_indices(&search) {
185 let matched_len = search.len();
186 let end = start + matched_len - 1;
187 let candidate = ReplacementCandidate {
188 start,
189 matched_len,
190 replacement: replacement.clone(),
191 start_line: Self::line_for_offset(&line_starts, start),
192 end_line: Self::line_for_offset(&line_starts, end),
193 };
194 if seen_matches.insert((start, matched_len, candidate.replacement.clone())) {
195 out.push(candidate);
196 }
197 }
198 }
199
200 out.sort_by_key(|candidate| candidate.start);
201 out
202 }
203
204 fn candidate_line_summary(candidates: &[ReplacementCandidate]) -> String {
205 let mut lines = candidates
206 .iter()
207 .map(|candidate| candidate.start_line.to_string())
208 .collect::<Vec<_>>();
209 lines.sort();
210 lines.dedup();
211 lines.join(", ")
212 }
213
214 fn choose_candidate_with_line_hint(
215 candidates: &[ReplacementCandidate],
216 line_number: usize,
217 ) -> Option<ReplacementCandidate> {
218 let containing = candidates
219 .iter()
220 .filter(|candidate| {
221 candidate.start_line <= line_number && line_number <= candidate.end_line
222 })
223 .cloned()
224 .collect::<Vec<_>>();
225
226 if containing.is_empty() {
227 return None;
228 }
229
230 let mut best: Option<ReplacementCandidate> = None;
231 let mut best_distance = usize::MAX;
232 let mut tie = false;
233
234 for candidate in containing {
235 let distance = candidate.start_line.abs_diff(line_number);
236 if distance < best_distance {
237 best_distance = distance;
238 best = Some(candidate);
239 tie = false;
240 } else if distance == best_distance {
241 tie = true;
242 }
243 }
244
245 if tie {
246 None
247 } else {
248 best
249 }
250 }
251
252 fn apply_single_replacement(
253 content: &str,
254 old_string: &str,
255 new_string: &str,
256 replace_all: bool,
257 line_number: Option<usize>,
258 ) -> Result<AppliedEdit, ToolError> {
259 if old_string == new_string {
260 return Err(ToolError::InvalidArguments(
261 "new_string must be different from old_string".to_string(),
262 ));
263 }
264 if old_string.is_empty() {
265 return Err(ToolError::InvalidArguments(
266 "old_string must be non-empty".to_string(),
267 ));
268 }
269
270 if let Some(line) = line_number {
271 if line == 0 {
272 return Err(ToolError::InvalidArguments(
273 "line_number must be >= 1".to_string(),
274 ));
275 }
276 if replace_all {
277 return Err(ToolError::InvalidArguments(
278 "line_number cannot be combined with replace_all=true".to_string(),
279 ));
280 }
281 }
282
283 let candidates = Self::collect_candidates(content, old_string, new_string);
284
285 if candidates.is_empty() {
286 return Err(ToolError::Execution(
287 "old_string not found in target file".to_string(),
288 ));
289 }
290
291 if !replace_all && candidates.len() != 1 && line_number.is_none() {
292 return Err(ToolError::Execution(format!(
293 "old_string matched {} times; provide a more specific old_string, set line_number, or use patch mode with additional context",
294 candidates.len()
295 )));
296 }
297
298 if replace_all {
299 Self::validate_replace_all_scope(old_string)?;
300 let variants = Self::replacement_variants(content, old_string, new_string);
301 for (search, replacement) in variants {
302 let matches = content.match_indices(&search).count();
303 if matches > 0 {
304 return Ok(AppliedEdit {
305 updated: content.replace(&search, &replacement),
306 replacements: matches,
307 });
308 }
309 }
310
311 return Ok(AppliedEdit {
312 updated: content.to_string(),
313 replacements: 0,
314 });
315 }
316
317 let chosen = if let Some(line) = line_number {
318 match Self::choose_candidate_with_line_hint(&candidates, line) {
319 Some(candidate) => candidate,
320 None if Self::has_candidate_containing_line(&candidates, line) => {
321 return Err(ToolError::Execution(format!(
322 "old_string matched {} times and line_number={} was not unique among candidates containing that line; candidate start lines: {}. Provide a more specific old_string or patch context",
323 candidates.len(),
324 line,
325 Self::candidate_line_summary(&candidates),
326 )));
327 }
328 None => {
329 return Err(ToolError::Execution(format!(
330 "line_number={} did not match any old_string candidate; candidate start lines: {}. Provide a line_number within the target match or use patch context",
331 line,
332 Self::candidate_line_summary(&candidates),
333 )));
334 }
335 }
336 } else {
337 candidates[0].clone()
338 };
339
340 let mut next = String::with_capacity(
341 content.len().saturating_sub(chosen.matched_len) + chosen.replacement.len(),
342 );
343 next.push_str(&content[..chosen.start]);
344 next.push_str(&chosen.replacement);
345 next.push_str(&content[chosen.start + chosen.matched_len..]);
346
347 Ok(AppliedEdit {
348 updated: next,
349 replacements: 1,
350 })
351 }
352
353 fn parse_patch_blocks(patch: &str) -> Result<Vec<(String, String)>, ToolError> {
354 const SEARCH: &str = "<<<<<<< SEARCH\n";
355 const SEP: &str = "\n=======\n";
356 const REPLACE: &str = "\n>>>>>>> REPLACE";
357
358 let normalized = patch.replace("\r\n", "\n");
359 if normalized.trim().is_empty() {
360 return Err(ToolError::InvalidArguments(
361 "patch must be non-empty".to_string(),
362 ));
363 }
364 if normalized.len() > MAX_PATCH_BYTES {
365 return Err(ToolError::InvalidArguments(format!(
366 "patch exceeds max size of {} bytes",
367 MAX_PATCH_BYTES
368 )));
369 }
370
371 let mut cursor = 0usize;
372 let mut blocks = Vec::new();
373 while let Some(start_rel) = normalized[cursor..].find(SEARCH) {
374 if blocks.len() >= MAX_PATCH_BLOCKS {
375 return Err(ToolError::InvalidArguments(format!(
376 "patch exceeds max block count of {}",
377 MAX_PATCH_BLOCKS
378 )));
379 }
380 let search_start = cursor + start_rel + SEARCH.len();
381 let sep_rel = normalized[search_start..].find(SEP).ok_or_else(|| {
382 ToolError::InvalidArguments("Malformed patch block: missing =======".to_string())
383 })?;
384 let sep_idx = search_start + sep_rel;
385 let replace_start = sep_idx + SEP.len();
386 let replace_rel = normalized[replace_start..].find(REPLACE).ok_or_else(|| {
387 ToolError::InvalidArguments(
388 "Malformed patch block: missing >>>>>>> REPLACE".to_string(),
389 )
390 })?;
391 let replace_idx = replace_start + replace_rel;
392
393 let old_block = normalized[search_start..sep_idx].to_string();
394 let new_block = normalized[replace_start..replace_idx].to_string();
395 if old_block.is_empty() {
396 return Err(ToolError::InvalidArguments(
397 "Patch SEARCH block must be non-empty".to_string(),
398 ));
399 }
400 if old_block.len() > MAX_PATCH_BLOCK_BYTES || new_block.len() > MAX_PATCH_BLOCK_BYTES {
401 return Err(ToolError::InvalidArguments(format!(
402 "Patch block exceeds max block size of {} bytes",
403 MAX_PATCH_BLOCK_BYTES
404 )));
405 }
406 blocks.push((old_block, new_block));
407
408 cursor = replace_idx + REPLACE.len();
409 if normalized[cursor..].starts_with('\n') {
410 cursor += 1;
411 }
412 }
413
414 if blocks.is_empty() {
415 return Err(ToolError::InvalidArguments(
416 "patch must contain at least one SEARCH/REPLACE block".to_string(),
417 ));
418 }
419
420 Ok(blocks)
421 }
422
423 fn apply_patch_mode(
424 content: &str,
425 patch: &str,
426 line_number: Option<usize>,
427 ) -> Result<AppliedEdit, ToolError> {
428 if let Some(line) = line_number {
429 if line == 0 {
430 return Err(ToolError::InvalidArguments(
431 "line_number must be >= 1".to_string(),
432 ));
433 }
434 }
435 let blocks = Self::parse_patch_blocks(patch)?;
436 let mut updated = content.to_string();
437 let mut replacements = 0usize;
438
439 for (idx, (old_block, new_block)) in blocks.iter().enumerate() {
440 let candidates = Self::collect_candidates(&updated, old_block, new_block);
441
442 if candidates.is_empty() {
443 return Err(ToolError::Execution(format!(
444 "Patch block {} SEARCH content not found in target file",
445 idx + 1
446 )));
447 }
448
449 let chosen = if candidates.len() == 1 {
450 candidates[0].clone()
451 } else if let Some(line) = line_number {
452 match Self::choose_candidate_with_line_hint(&candidates, line) {
453 Some(candidate) => candidate,
454 None if Self::has_candidate_containing_line(&candidates, line) => {
455 return Err(ToolError::Execution(format!(
456 "Patch block {} SEARCH content matched {} times and line_number={} was not unique among candidates containing that line; candidate start lines: {}. Add more context to make it unique",
457 idx + 1,
458 candidates.len(),
459 line,
460 Self::candidate_line_summary(&candidates),
461 )));
462 }
463 None => {
464 return Err(ToolError::Execution(format!(
465 "Patch block {} line_number={} did not match any SEARCH candidate; candidate start lines: {}. Add more context or use a line within the target block",
466 idx + 1,
467 line,
468 Self::candidate_line_summary(&candidates),
469 )));
470 }
471 }
472 } else {
473 return Err(ToolError::Execution(format!(
474 "Patch block {} SEARCH content matched {} times; set line_number or add more context to make it unique",
475 idx + 1,
476 candidates.len()
477 )));
478 };
479
480 let mut next = String::with_capacity(
481 updated.len().saturating_sub(chosen.matched_len) + chosen.replacement.len(),
482 );
483 next.push_str(&updated[..chosen.start]);
484 next.push_str(&chosen.replacement);
485 next.push_str(&updated[chosen.start + chosen.matched_len..]);
486 updated = next;
487 replacements += 1;
488 }
489
490 Ok(AppliedEdit {
491 updated,
492 replacements,
493 })
494 }
495}
496
497impl Default for EditTool {
498 fn default() -> Self {
499 Self::new()
500 }
501}
502
503#[async_trait]
504impl Tool for EditTool {
505 fn name(&self) -> &str {
506 "Edit"
507 }
508
509 fn description(&self) -> &str {
510 "Edit existing files via exact replacements or SEARCH/REPLACE patch blocks. IMPORTANT: call Read first in this session or Edit will fail."
511 }
512
513 fn parameters_schema(&self) -> serde_json::Value {
514 json!({
515 "type": "object",
516 "properties": {
517 "file_path": {
518 "type": "string",
519 "description": "The absolute path to the file to modify"
520 },
521 "old_string": {
522 "type": "string",
523 "description": "Legacy mode only: exact text to replace. Do not send with patch mode."
524 },
525 "new_string": {
526 "type": "string",
527 "description": "Legacy mode only: replacement text. Do not send with patch mode."
528 },
529 "replace_all": {
530 "type": "boolean",
531 "default": false,
532 "description": "Legacy mode only: replace all occurrences. Do not send with patch mode."
533 },
534 "patch": {
535 "type": "string",
536 "description": "Patch mode: one or more blocks using <<<<<<< SEARCH / ======= / >>>>>>> REPLACE. Preferred mode. Do not combine with non-empty old_string/new_string or replace_all=true."
537 },
538 "line_number": {
539 "type": "integer",
540 "minimum": 1,
541 "description": "Optional 1-based line hint to disambiguate duplicate matches"
542 }
543 },
544 "required": ["file_path"],
545 "additionalProperties": false
546 })
547 }
548
549 async fn invoke(
550 &self,
551 args: serde_json::Value,
552 ctx: ToolCtx,
553 ) -> Result<ToolOutcome, ToolError> {
554 let parsed: EditArgs = serde_json::from_value(args)
555 .map_err(|e| ToolError::InvalidArguments(format!("Invalid Edit args: {}", e)))?;
556
557 let file_path = parsed.file_path.trim();
558 let path = Path::new(file_path);
559 if !path.is_absolute() {
560 return Err(ToolError::InvalidArguments(
561 "file_path must be an absolute path".to_string(),
562 ));
563 }
564
565 let session_id = ctx.session_id().map(str::to_owned);
566 let validated_read = if let Some(session_id) = session_id.as_deref() {
567 match read_tracker::read_if_fresh(session_id, file_path).await {
568 Ok(validated) => Some(validated),
569 Err(ReadState::Unread) => {
570 return Err(ToolError::Execution(
571 "Edit requires reading the target file first via Read".to_string(),
572 ));
573 }
574 Err(ReadState::Stale) => {
575 return Err(ToolError::Execution(
576 "Target file changed after last Read; call Read again before Edit"
577 .to_string(),
578 ));
579 }
580 Err(ReadState::Fresh) => unreachable!("Fresh is returned as a validated read"),
581 }
582 } else {
583 None
584 };
585
586 let content = if let Some(validated) = validated_read.as_ref() {
587 String::from_utf8(validated.bytes().to_vec())
588 .map_err(|e| ToolError::Execution(format!("Failed to read file: {}", e)))?
589 } else {
590 tokio::fs::read_to_string(path)
591 .await
592 .map_err(|e| ToolError::Execution(format!("Failed to read file: {}", e)))?
593 };
594
595 let patch = parsed
596 .patch
597 .as_deref()
598 .map(str::trim)
599 .filter(|value| !value.is_empty());
600 let old_string = parsed.old_string.as_deref();
601 let new_string = parsed.new_string.as_deref();
602
603 let requested_replace_all = parsed.replace_all.unwrap_or(false);
604 let line_number_hint = parsed.line_number;
605 let used_patch_mode = patch.is_some();
606
607 let AppliedEdit {
608 updated,
609 replacements,
610 } = if let Some(patch_text) = patch {
611 if Self::has_meaningful_optional_text(old_string)
612 || Self::has_meaningful_optional_text(new_string)
613 || requested_replace_all
614 {
615 return Err(ToolError::InvalidArguments(
616 "patch mode cannot be combined with old_string/new_string/replace_all"
617 .to_string(),
618 ));
619 }
620 Self::apply_patch_mode(&content, patch_text, parsed.line_number)?
621 } else {
622 let old = old_string.ok_or_else(|| {
623 ToolError::InvalidArguments(
624 "old_string is required unless patch mode is used".to_string(),
625 )
626 })?;
627 let new = new_string.ok_or_else(|| {
628 ToolError::InvalidArguments(
629 "new_string is required unless patch mode is used".to_string(),
630 )
631 })?;
632 Self::apply_single_replacement(
633 &content,
634 old,
635 new,
636 requested_replace_all,
637 parsed.line_number,
638 )?
639 };
640 let mode_label = if used_patch_mode { "patch" } else { "legacy" };
641 let touched_lines = file_change::touched_line_count(&content, &updated);
642
643 Self::ensure_safe_scope(requested_replace_all, replacements, touched_lines)?;
644
645 let checkpoint = file_change::create_checkpoint(path, Some(content.as_bytes())).await?;
646
647 let write_expectation = validated_read.as_ref().map_or(
648 file_change::AtomicWriteExpectation::Unchecked,
649 |validated| file_change::AtomicWriteExpectation::Exact(validated.bytes()),
650 );
651 file_change::atomic_write_text_with_expectation(path, &updated, write_expectation).await?;
652
653 if session_id.is_some() {
654 let validated = validated_read
655 .as_ref()
656 .expect("a session-scoped Edit always has a validated Read");
657 if read_tracker::advance_after_verified_write(
658 file_path,
659 validated.slot(),
660 updated.as_bytes(),
661 )
662 .await
663 == BaselineAdvance::Conflict
664 {
665 return Err(ToolError::Execution(
666 "Edit committed, but the target changed before it could be verified; call Read again"
667 .to_string(),
668 ));
669 }
670 }
671
672 let changed_bytes = updated.len().abs_diff(content.len());
673 let changed_lines = updated.lines().count().abs_diff(content.lines().count());
674
675 let mut payload = file_change::build_file_change_payload_value(
676 "Edit",
677 path,
678 format!(
679 "Edited file: {} (mode: {}, replacements: {})",
680 file_path, mode_label, replacements
681 ),
682 checkpoint,
683 &content,
684 &updated,
685 );
686 if let Some(obj) = payload.as_object_mut() {
687 obj.insert("edit_mode".to_string(), json!(mode_label));
688 obj.insert("replacements".to_string(), json!(replacements));
689 obj.insert(
690 "requested_replace_all".to_string(),
691 json!(requested_replace_all),
692 );
693 obj.insert("used_patch_mode".to_string(), json!(used_patch_mode));
694 obj.insert("line_number_hint".to_string(), json!(line_number_hint));
695 obj.insert("changed_bytes".to_string(), json!(changed_bytes));
696 obj.insert("changed_lines".to_string(), json!(changed_lines));
697 obj.insert("touched_lines".to_string(), json!(touched_lines));
698 }
699 content_diagnostics::attach_file_diagnostics(&mut payload, path, &updated);
700
701 Ok(ToolOutcome::Completed(ToolResult {
702 success: true,
703 result: payload.to_string(),
704 display_preference: Some("Default".to_string()),
705 images: Vec::new(),
706 }))
707 }
708}
709
710#[cfg(test)]
711mod tests {
712 use super::*;
713 use crate::tools::ReadTool;
714 use serde_json::json;
715
716 fn ctx(session_id: &str) -> ToolCtx {
717 ToolCtx {
718 session_id: Some(std::sync::Arc::from(session_id)),
719 tool_call_id: std::sync::Arc::from("call_1"),
720 event_tx: None,
721 available_tool_schemas: std::sync::Arc::from(Vec::new()),
722 bypass_permissions: false,
723 auto_approve_permissions: false,
724 plan_read_only: false,
725 can_async_resume: false,
726 async_completion_sink: None,
727 bash_completion_sink: None,
728 }
729 }
730
731 async fn run(tool: &EditTool, args: serde_json::Value) -> Result<ToolResult, ToolError> {
732 match tool.invoke(args, ToolCtx::none("t")).await? {
733 ToolOutcome::Completed(r) => Ok(r),
734 _ => panic!("expected Completed"),
735 }
736 }
737
738 #[tokio::test]
739 async fn edit_requires_unique_match_without_replace_all() {
740 let file = tempfile::NamedTempFile::new().unwrap();
741 tokio::fs::write(file.path(), "foo\nfoo\n").await.unwrap();
742
743 let tool = EditTool::new();
744 let result = run(
745 &tool,
746 json!({
747 "file_path": file.path(),
748 "old_string": "foo",
749 "new_string": "bar"
750 }),
751 )
752 .await;
753
754 assert!(result.is_err());
755 }
756
757 #[tokio::test]
758 async fn edit_supports_replace_all() {
759 let file = tempfile::NamedTempFile::new().unwrap();
760 tokio::fs::write(file.path(), "foo\nfoo\n").await.unwrap();
761
762 let tool = EditTool::new();
763 let result = run(
764 &tool,
765 json!({
766 "file_path": file.path(),
767 "old_string": "foo",
768 "new_string": "bar",
769 "replace_all": true
770 }),
771 )
772 .await
773 .unwrap();
774
775 assert!(result.success);
776 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
777 assert_eq!(updated, "bar\nbar\n");
778 }
779
780 #[tokio::test]
781 async fn edit_replace_all_does_not_reprocess_newly_inserted_matches() {
782 let file = tempfile::NamedTempFile::new().unwrap();
783 tokio::fs::write(file.path(), "a\n").await.unwrap();
784
785 let tool = EditTool::new();
786 let result = run(
787 &tool,
788 json!({
789 "file_path": file.path(),
790 "old_string": "aa",
791 "new_string": "bb",
792 "replace_all": true
793 }),
794 )
795 .await;
796
797 assert!(matches!(
798 result,
799 Err(ToolError::Execution(_)) | Err(ToolError::InvalidArguments(_))
800 ));
801 }
802
803 #[tokio::test]
804 async fn edit_replace_all_rejects_excessive_occurrence_count() {
805 let file = tempfile::NamedTempFile::new().unwrap();
806 let content = (0..=MAX_SAFE_REPLACE_ALL_OCCURRENCES)
807 .map(|_| "foo")
808 .collect::<Vec<_>>()
809 .join("\n");
810 tokio::fs::write(file.path(), format!("{content}\n"))
811 .await
812 .unwrap();
813
814 let tool = EditTool::new();
815 let result = run(
816 &tool,
817 json!({
818 "file_path": file.path(),
819 "old_string": "foo",
820 "new_string": "bar",
821 "replace_all": true
822 }),
823 )
824 .await;
825
826 assert!(
827 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("replace_all would modify"))
828 );
829 }
830
831 #[tokio::test]
832 async fn edit_replace_all_rejects_too_short_old_string() {
833 let file = tempfile::NamedTempFile::new().unwrap();
834 tokio::fs::write(file.path(), "a\na\n").await.unwrap();
835
836 let tool = EditTool::new();
837 let result = run(
838 &tool,
839 json!({
840 "file_path": file.path(),
841 "old_string": "a",
842 "new_string": "b",
843 "replace_all": true
844 }),
845 )
846 .await;
847
848 assert!(
849 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("non-whitespace characters"))
850 );
851 }
852
853 #[tokio::test]
854 async fn edit_replace_all_rejects_whitespace_only_old_string() {
855 let file = tempfile::NamedTempFile::new().unwrap();
856 tokio::fs::write(file.path(), " \n \n").await.unwrap();
857
858 let tool = EditTool::new();
859 let result = run(
860 &tool,
861 json!({
862 "file_path": file.path(),
863 "old_string": " ",
864 "new_string": "x",
865 "replace_all": true
866 }),
867 )
868 .await;
869
870 assert!(
871 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("non-whitespace characters") || msg.contains("non-empty line"))
872 );
873 }
874
875 #[tokio::test]
876 async fn edit_requires_read_first_when_session_context_exists() {
877 let file = tempfile::NamedTempFile::new().unwrap();
878 tokio::fs::write(file.path(), "hello world\n")
879 .await
880 .unwrap();
881 let call_id = "call_1";
882
883 let edit_tool = EditTool::new();
884 let read_tool = ReadTool::new();
885
886 let denied = edit_tool
887 .invoke(
888 json!({
889 "file_path": file.path(),
890 "old_string": "world",
891 "new_string": "rust"
892 }),
893 ToolCtx {
894 session_id: Some(std::sync::Arc::from("session_1")),
895 tool_call_id: std::sync::Arc::from(call_id),
896 event_tx: None,
897 available_tool_schemas: std::sync::Arc::from(Vec::new()),
898 bypass_permissions: false,
899 auto_approve_permissions: false,
900 plan_read_only: false,
901 can_async_resume: false,
902 async_completion_sink: None,
903 bash_completion_sink: None,
904 },
905 )
906 .await;
907 assert!(denied.is_err());
908
909 let _ = read_tool
910 .invoke(
911 json!({"file_path": file.path()}),
912 ToolCtx {
913 session_id: Some(std::sync::Arc::from("session_1")),
914 tool_call_id: std::sync::Arc::from(call_id),
915 event_tx: None,
916 available_tool_schemas: std::sync::Arc::from(Vec::new()),
917 bypass_permissions: false,
918 auto_approve_permissions: false,
919 plan_read_only: false,
920 can_async_resume: false,
921 async_completion_sink: None,
922 bash_completion_sink: None,
923 },
924 )
925 .await
926 .unwrap();
927
928 let allowed = edit_tool
929 .invoke(
930 json!({
931 "file_path": file.path(),
932 "old_string": "world",
933 "new_string": "rust"
934 }),
935 ToolCtx {
936 session_id: Some(std::sync::Arc::from("session_1")),
937 tool_call_id: std::sync::Arc::from(call_id),
938 event_tx: None,
939 available_tool_schemas: std::sync::Arc::from(Vec::new()),
940 bypass_permissions: false,
941 auto_approve_permissions: false,
942 plan_read_only: false,
943 can_async_resume: false,
944 async_completion_sink: None,
945 bash_completion_sink: None,
946 },
947 )
948 .await
949 .unwrap();
950 let ToolOutcome::Completed(allowed) = allowed else {
951 panic!("expected Completed")
952 };
953
954 assert!(allowed.success);
955 }
956
957 #[tokio::test]
958 async fn read_edit_edit_succeeds_without_an_external_change() {
959 let file = tempfile::NamedTempFile::new().unwrap();
960 tokio::fs::write(file.path(), "alpha\nbeta\ngamma\n")
961 .await
962 .unwrap();
963 let session = format!("edit-twice-{}", uuid::Uuid::new_v4());
964 let read_tool = ReadTool::new();
965 let edit_tool = EditTool::new();
966
967 read_tool
968 .invoke(json!({"file_path": file.path()}), ctx(&session))
969 .await
970 .unwrap();
971 edit_tool
972 .invoke(
973 json!({
974 "file_path": file.path(),
975 "old_string": "alpha",
976 "new_string": "alpha-one"
977 }),
978 ctx(&session),
979 )
980 .await
981 .unwrap();
982 edit_tool
983 .invoke(
984 json!({
985 "file_path": file.path(),
986 "old_string": "beta",
987 "new_string": "beta-two"
988 }),
989 ctx(&session),
990 )
991 .await
992 .unwrap();
993
994 assert_eq!(
995 tokio::fs::read_to_string(file.path()).await.unwrap(),
996 "alpha-one\nbeta-two\ngamma\n"
997 );
998 }
999
1000 #[tokio::test]
1001 async fn concurrent_read_of_edited_version_is_idempotent() {
1002 let file = tempfile::NamedTempFile::new().unwrap();
1003 tokio::fs::write(file.path(), "alpha\nbeta\n")
1004 .await
1005 .unwrap();
1006 let path = file.path().to_path_buf();
1007 let path_str = path.to_string_lossy().into_owned();
1008 let session = format!("edit-concurrent-read-{}", uuid::Uuid::new_v4());
1009
1010 ReadTool::new()
1011 .invoke(json!({"file_path": path}), ctx(&session))
1012 .await
1013 .unwrap();
1014 let (advance_reached, resume_advance) =
1015 read_tracker::pause_next_advance_for_test(&session, &path_str).await;
1016
1017 let edit_path = path.clone();
1018 let edit_session = session.clone();
1019 let editor = tokio::spawn(async move {
1020 EditTool::new()
1021 .invoke(
1022 json!({
1023 "file_path": edit_path,
1024 "old_string": "alpha",
1025 "new_string": "ALPHA"
1026 }),
1027 ctx(&edit_session),
1028 )
1029 .await
1030 });
1031
1032 tokio::time::timeout(
1033 std::time::Duration::from_secs(5),
1034 advance_reached.notified(),
1035 )
1036 .await
1037 .expect("Edit did not reach post-write baseline advancement");
1038 ReadTool::new()
1039 .invoke(json!({"file_path": path}), ctx(&session))
1040 .await
1041 .unwrap();
1042 resume_advance.notify_one();
1043
1044 let first = tokio::time::timeout(std::time::Duration::from_secs(5), editor)
1045 .await
1046 .expect("Edit did not resume")
1047 .unwrap()
1048 .unwrap();
1049 assert!(matches!(first, ToolOutcome::Completed(result) if result.success));
1050
1051 EditTool::new()
1052 .invoke(
1053 json!({
1054 "file_path": path,
1055 "old_string": "beta",
1056 "new_string": "BETA"
1057 }),
1058 ctx(&session),
1059 )
1060 .await
1061 .unwrap();
1062 assert_eq!(
1063 tokio::fs::read_to_string(path).await.unwrap(),
1064 "ALPHA\nBETA\n"
1065 );
1066 }
1067
1068 #[tokio::test]
1069 async fn edit_rejects_external_change_after_a_successful_edit() {
1070 let file = tempfile::NamedTempFile::new().unwrap();
1071 tokio::fs::write(file.path(), "alpha\nbeta\n")
1072 .await
1073 .unwrap();
1074 let session = format!("edit-external-{}", uuid::Uuid::new_v4());
1075 let read_tool = ReadTool::new();
1076 let edit_tool = EditTool::new();
1077
1078 read_tool
1079 .invoke(json!({"file_path": file.path()}), ctx(&session))
1080 .await
1081 .unwrap();
1082 edit_tool
1083 .invoke(
1084 json!({
1085 "file_path": file.path(),
1086 "old_string": "alpha",
1087 "new_string": "ALPHA"
1088 }),
1089 ctx(&session),
1090 )
1091 .await
1092 .unwrap();
1093
1094 tokio::fs::write(file.path(), "ALPHA\nBETA\n")
1095 .await
1096 .unwrap();
1097 let stale = edit_tool
1098 .invoke(
1099 json!({
1100 "file_path": file.path(),
1101 "old_string": "ALPHA",
1102 "new_string": "alpha-two"
1103 }),
1104 ctx(&session),
1105 )
1106 .await;
1107
1108 assert!(matches!(stale, Err(ToolError::Execution(message)) if message.contains("changed")));
1109 assert_eq!(
1110 tokio::fs::read_to_string(file.path()).await.unwrap(),
1111 "ALPHA\nBETA\n"
1112 );
1113 }
1114
1115 #[tokio::test]
1116 async fn failed_edit_does_not_break_the_existing_fresh_baseline() {
1117 let file = tempfile::NamedTempFile::new().unwrap();
1118 tokio::fs::write(file.path(), "alpha\nbeta\n")
1119 .await
1120 .unwrap();
1121 let session = format!("edit-failure-{}", uuid::Uuid::new_v4());
1122 let read_tool = ReadTool::new();
1123 let edit_tool = EditTool::new();
1124
1125 read_tool
1126 .invoke(json!({"file_path": file.path()}), ctx(&session))
1127 .await
1128 .unwrap();
1129 let failed = edit_tool
1130 .invoke(
1131 json!({
1132 "file_path": file.path(),
1133 "old_string": "not-present",
1134 "new_string": "replacement"
1135 }),
1136 ctx(&session),
1137 )
1138 .await;
1139 assert!(failed.is_err());
1140
1141 edit_tool
1142 .invoke(
1143 json!({
1144 "file_path": file.path(),
1145 "old_string": "beta",
1146 "new_string": "beta-two"
1147 }),
1148 ctx(&session),
1149 )
1150 .await
1151 .unwrap();
1152 assert_eq!(
1153 tokio::fs::read_to_string(file.path()).await.unwrap(),
1154 "alpha\nbeta-two\n"
1155 );
1156 }
1157
1158 #[tokio::test]
1159 async fn edit_rejects_empty_old_string() {
1160 let file = tempfile::NamedTempFile::new().unwrap();
1161 tokio::fs::write(file.path(), "hello").await.unwrap();
1162
1163 let tool = EditTool::new();
1164 let result = run(
1165 &tool,
1166 json!({
1167 "file_path": file.path(),
1168 "old_string": "",
1169 "new_string": "x",
1170 "replace_all": true
1171 }),
1172 )
1173 .await;
1174
1175 assert!(matches!(result, Err(ToolError::InvalidArguments(_))));
1176 }
1177
1178 #[tokio::test]
1179 async fn edit_legacy_mode_handles_crlf_when_old_string_uses_lf() {
1180 let file = tempfile::NamedTempFile::new().unwrap();
1181 tokio::fs::write(file.path(), "alpha\r\nbeta\r\n")
1182 .await
1183 .unwrap();
1184
1185 let tool = EditTool::new();
1186 let result = run(
1187 &tool,
1188 json!({
1189 "file_path": file.path(),
1190 "old_string": "alpha\nbeta\n",
1191 "new_string": "gamma\ndelta\n"
1192 }),
1193 )
1194 .await
1195 .unwrap();
1196
1197 assert!(result.success);
1198 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1199 assert_eq!(updated, "gamma\r\ndelta\r\n");
1200 }
1201
1202 #[tokio::test]
1203 async fn edit_legacy_mode_line_number_disambiguates_duplicates() {
1204 let file = tempfile::NamedTempFile::new().unwrap();
1205 tokio::fs::write(file.path(), "foo\nbar\nfoo\n")
1206 .await
1207 .unwrap();
1208
1209 let tool = EditTool::new();
1210 let result = run(
1211 &tool,
1212 json!({
1213 "file_path": file.path(),
1214 "old_string": "foo",
1215 "new_string": "baz",
1216 "line_number": 3
1217 }),
1218 )
1219 .await
1220 .unwrap();
1221 assert!(result.success);
1222
1223 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1224 assert_eq!(updated, "foo\nbar\nbaz\n");
1225 }
1226
1227 #[tokio::test]
1228 async fn edit_legacy_mode_rejects_line_number_when_no_candidate_contains_it() {
1229 let file = tempfile::NamedTempFile::new().unwrap();
1230 tokio::fs::write(file.path(), "foo\nbar\nfoo\n")
1231 .await
1232 .unwrap();
1233
1234 let tool = EditTool::new();
1235 let result = run(
1236 &tool,
1237 json!({
1238 "file_path": file.path(),
1239 "old_string": "foo",
1240 "new_string": "baz",
1241 "line_number": 2
1242 }),
1243 )
1244 .await;
1245
1246 assert!(
1247 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("did not match any old_string candidate"))
1248 );
1249 }
1250
1251 #[tokio::test]
1252 async fn edit_legacy_mode_rejects_line_number_with_replace_all() {
1253 let file = tempfile::NamedTempFile::new().unwrap();
1254 tokio::fs::write(file.path(), "foo\nfoo\n").await.unwrap();
1255
1256 let tool = EditTool::new();
1257 let result = run(
1258 &tool,
1259 json!({
1260 "file_path": file.path(),
1261 "old_string": "foo",
1262 "new_string": "bar",
1263 "replace_all": true,
1264 "line_number": 1
1265 }),
1266 )
1267 .await;
1268
1269 assert!(
1270 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("line_number cannot be combined"))
1271 );
1272 }
1273
1274 #[tokio::test]
1275 async fn edit_patch_mode_can_target_second_duplicate_with_context() {
1276 let file = tempfile::NamedTempFile::new().unwrap();
1277 tokio::fs::write(
1278 file.path(),
1279 "fn a() {\n let v = 1;\n}\n\nfn b() {\n let v = 1;\n}\n",
1280 )
1281 .await
1282 .unwrap();
1283
1284 let tool = EditTool::new();
1285 let result = run(&tool,json!({
1286 "file_path": file.path(),
1287 "patch": "<<<<<<< SEARCH\nfn b() {\n let v = 1;\n}\n=======\nfn b() {\n let v = 2;\n}\n>>>>>>> REPLACE"
1288 }))
1289 .await
1290 .unwrap();
1291 assert!(result.success);
1292
1293 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1294 assert!(updated.contains("fn a() {\n let v = 1;\n}"));
1295 assert!(updated.contains("fn b() {\n let v = 2;\n}"));
1296 }
1297
1298 #[tokio::test]
1299 async fn edit_patch_mode_handles_crlf_when_patch_uses_lf() {
1300 let file = tempfile::NamedTempFile::new().unwrap();
1301 tokio::fs::write(file.path(), "fn b() {\r\n let v = 1;\r\n}\r\n")
1302 .await
1303 .unwrap();
1304
1305 let tool = EditTool::new();
1306 let result = run(&tool,json!({
1307 "file_path": file.path(),
1308 "patch": "<<<<<<< SEARCH\nfn b() {\n let v = 1;\n}\n=======\nfn b() {\n let v = 2;\n}\n>>>>>>> REPLACE"
1309 }))
1310 .await
1311 .unwrap();
1312 assert!(result.success);
1313
1314 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1315 assert_eq!(updated, "fn b() {\r\n let v = 2;\r\n}\r\n");
1316 }
1317
1318 #[tokio::test]
1319 async fn edit_patch_mode_line_number_disambiguates_duplicates() {
1320 let file = tempfile::NamedTempFile::new().unwrap();
1321 tokio::fs::write(file.path(), "x = 1;\nx = 1;\n")
1322 .await
1323 .unwrap();
1324
1325 let tool = EditTool::new();
1326 let result = run(
1327 &tool,
1328 json!({
1329 "file_path": file.path(),
1330 "line_number": 2,
1331 "patch": "<<<<<<< SEARCH\nx = 1;\n=======\nx = 2;\n>>>>>>> REPLACE"
1332 }),
1333 )
1334 .await
1335 .unwrap();
1336 assert!(result.success);
1337
1338 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1339 assert_eq!(updated, "x = 1;\nx = 2;\n");
1340 }
1341
1342 #[tokio::test]
1343 async fn edit_patch_mode_rejects_line_number_when_no_candidate_contains_it() {
1344 let file = tempfile::NamedTempFile::new().unwrap();
1345 tokio::fs::write(file.path(), "x = 1;\ny = 0;\nx = 1;\n")
1346 .await
1347 .unwrap();
1348
1349 let tool = EditTool::new();
1350 let result = run(
1351 &tool,
1352 json!({
1353 "file_path": file.path(),
1354 "line_number": 2,
1355 "patch": "<<<<<<< SEARCH\nx = 1;\n=======\nx = 2;\n>>>>>>> REPLACE"
1356 }),
1357 )
1358 .await;
1359
1360 assert!(
1361 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("did not match any SEARCH candidate"))
1362 );
1363 }
1364
1365 #[tokio::test]
1366 async fn edit_patch_mode_rejects_ambiguous_search_block() {
1367 let file = tempfile::NamedTempFile::new().unwrap();
1368 tokio::fs::write(file.path(), "x = 1;\nx = 1;\n")
1369 .await
1370 .unwrap();
1371
1372 let tool = EditTool::new();
1373 let result = run(
1374 &tool,
1375 json!({
1376 "file_path": file.path(),
1377 "patch": "<<<<<<< SEARCH\nx = 1;\n=======\nx = 2;\n>>>>>>> REPLACE"
1378 }),
1379 )
1380 .await;
1381
1382 assert!(
1383 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("matched 2 times"))
1384 );
1385 }
1386
1387 #[tokio::test]
1388 async fn edit_patch_mode_rejects_large_scope_edits() {
1389 let file = tempfile::NamedTempFile::new().unwrap();
1390 let old_block = (0..70)
1391 .map(|idx| format!("line {idx}"))
1392 .collect::<Vec<_>>()
1393 .join("\n");
1394 let new_block = (0..70)
1395 .map(|idx| format!("updated {idx}"))
1396 .collect::<Vec<_>>()
1397 .join("\n");
1398 tokio::fs::write(file.path(), format!("{old_block}\n"))
1399 .await
1400 .unwrap();
1401
1402 let patch = format!("<<<<<<< SEARCH\n{old_block}\n=======\n{new_block}\n>>>>>>> REPLACE");
1403
1404 let tool = EditTool::new();
1405 let result = run(
1406 &tool,
1407 json!({
1408 "file_path": file.path(),
1409 "patch": patch
1410 }),
1411 )
1412 .await;
1413
1414 assert!(
1415 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("exceeding the safe limit"))
1416 );
1417 }
1418
1419 #[tokio::test]
1420 async fn edit_rejects_mixed_patch_and_legacy_args() {
1421 let file = tempfile::NamedTempFile::new().unwrap();
1422 tokio::fs::write(file.path(), "hello").await.unwrap();
1423
1424 let tool = EditTool::new();
1425 let result = run(
1426 &tool,
1427 json!({
1428 "file_path": file.path(),
1429 "old_string": "hello",
1430 "new_string": "world",
1431 "patch": "<<<<<<< SEARCH\nhello\n=======\nworld\n>>>>>>> REPLACE"
1432 }),
1433 )
1434 .await;
1435
1436 assert!(
1437 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("cannot be combined"))
1438 );
1439 }
1440
1441 #[tokio::test]
1442 async fn edit_patch_mode_ignores_empty_legacy_placeholders() {
1443 let file = tempfile::NamedTempFile::new().unwrap();
1444 tokio::fs::write(file.path(), "hello").await.unwrap();
1445
1446 let tool = EditTool::new();
1447 let result = run(
1448 &tool,
1449 json!({
1450 "file_path": file.path(),
1451 "old_string": "",
1452 "new_string": "",
1453 "replace_all": false,
1454 "patch": "<<<<<<< SEARCH\nhello\n=======\nworld\n>>>>>>> REPLACE"
1455 }),
1456 )
1457 .await
1458 .unwrap();
1459
1460 assert!(result.success);
1461 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1462 assert_eq!(updated, "world");
1463 }
1464
1465 #[tokio::test]
1466 async fn edit_patch_rejects_oversized_patch_payload() {
1467 let file = tempfile::NamedTempFile::new().unwrap();
1468 tokio::fs::write(file.path(), "hello world").await.unwrap();
1469 let huge = "a".repeat(MAX_PATCH_BYTES + 1);
1470
1471 let tool = EditTool::new();
1472 let result = run(
1473 &tool,
1474 json!({
1475 "file_path": file.path(),
1476 "patch": huge
1477 }),
1478 )
1479 .await;
1480
1481 assert!(
1482 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("max size"))
1483 );
1484 }
1485
1486 #[tokio::test]
1487 async fn edit_patch_rejects_excessive_block_count() {
1488 let file = tempfile::NamedTempFile::new().unwrap();
1489 tokio::fs::write(file.path(), "hello world").await.unwrap();
1490 let mut patch = String::new();
1491 for _ in 0..=MAX_PATCH_BLOCKS {
1492 patch.push_str("<<<<<<< SEARCH\nx\n=======\ny\n>>>>>>> REPLACE\n");
1493 }
1494
1495 let tool = EditTool::new();
1496 let result = run(
1497 &tool,
1498 json!({
1499 "file_path": file.path(),
1500 "patch": patch
1501 }),
1502 )
1503 .await;
1504
1505 assert!(
1506 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("max block count"))
1507 );
1508 }
1509
1510 #[tokio::test]
1511 async fn edit_includes_json_diagnostics_after_change() {
1512 let file = tempfile::Builder::new().suffix(".json").tempfile().unwrap();
1513 tokio::fs::write(file.path(), r#"{"ok":true}"#)
1514 .await
1515 .unwrap();
1516
1517 let read_tool = ReadTool::new();
1518 let _ = read_tool
1519 .invoke(
1520 json!({ "file_path": file.path() }),
1521 ToolCtx {
1522 session_id: Some(std::sync::Arc::from("session_edit_diag")),
1523 tool_call_id: std::sync::Arc::from("call_1"),
1524 event_tx: None,
1525 available_tool_schemas: std::sync::Arc::from(Vec::new()),
1526 bypass_permissions: false,
1527 auto_approve_permissions: false,
1528 plan_read_only: false,
1529 can_async_resume: false,
1530 async_completion_sink: None,
1531 bash_completion_sink: None,
1532 },
1533 )
1534 .await
1535 .unwrap();
1536
1537 let tool = EditTool::new();
1538 let result = tool
1539 .invoke(
1540 json!({
1541 "file_path": file.path(),
1542 "old_string": r#"{"ok":true}"#,
1543 "new_string": "{"
1544 }),
1545 ToolCtx {
1546 session_id: Some(std::sync::Arc::from("session_edit_diag")),
1547 tool_call_id: std::sync::Arc::from("call_2"),
1548 event_tx: None,
1549 available_tool_schemas: std::sync::Arc::from(Vec::new()),
1550 bypass_permissions: false,
1551 auto_approve_permissions: false,
1552 plan_read_only: false,
1553 can_async_resume: false,
1554 async_completion_sink: None,
1555 bash_completion_sink: None,
1556 },
1557 )
1558 .await
1559 .unwrap();
1560 let ToolOutcome::Completed(result) = result else {
1561 panic!("expected Completed")
1562 };
1563
1564 assert!(result.success);
1565 let payload: serde_json::Value = serde_json::from_str(&result.result).unwrap();
1566 assert_eq!(payload["diagnostics"]["format"], "json");
1567 assert_eq!(payload["diagnostics"]["valid"], false);
1568 assert_eq!(payload["touched_lines"], 2);
1569 }
1570}