bamboo-server 2026.8.28

HTTP server and API layer for the Bamboo agent framework
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
use actix_web::{web, HttpRequest, HttpResponse};

use super::{ChatRequest, ChatResponse};
use crate::app_state::AppState;
use bamboo_engine::config::GoldConfig;
use bamboo_engine::model_config_helper::{
    parse_session_gold_config, resolve_gold_config, GOLD_CONFIG_METADATA_KEY,
};
use bamboo_engine::session_app::chat::{parse_goal_command, GoalCommand};
use bamboo_engine::session_app::metadata::SessionMetadataService;

mod images;
mod request;

/// Publish the validated workspace after its session checkpoint is durable.
///
/// Project-context preview is AppState-scoped, so publication must use the
/// same provider pair rather than a sibling state's process-global first-wins
/// root. `workspace_source` is a non-secret diagnostic label.
fn sync_runtime_workspace(
    state: &AppState,
    session_id: &str,
    workspace_path: Option<&str>,
    workspace_source: &str,
) {
    if let Some(workspace) = workspace_path
        .map(str::trim)
        .filter(|s| !s.is_empty())
        .map(std::path::PathBuf::from)
        .and_then(|path| std::fs::canonicalize(&path).ok().or(Some(path)))
    {
        state.workspace_resolver.publish_resolved_workspace(
            session_id,
            workspace,
            workspace_source,
        );
    }
}

/// Persist and refresh the cache while the caller holds the session's
/// `LockedSessionStore` guard.
///
/// Calling `save_and_cache_session` here would try to acquire the same
/// non-reentrant lock again. A plain storage save is safe because the chat
/// transaction owns the lock from its authoritative reload through its final
/// message checkpoint.
async fn persist_and_cache_session_locked(
    state: &AppState,
    session: &bamboo_agent_core::Session,
) -> std::io::Result<()> {
    state.persistence.storage().save_session(session).await?;
    state.sessions.insert(
        session.id.clone(),
        std::sync::Arc::new(parking_lot::RwLock::new(session.clone())),
    );
    Ok(())
}

async fn save_and_cache_session_locked(
    state: &AppState,
    session: &bamboo_agent_core::Session,
) -> Result<(), HttpResponse> {
    persist_and_cache_session_locked(state, session)
        .await
        .map_err(|error| {
            HttpResponse::InternalServerError().json(serde_json::json!({
                "error": crate::error::error_value(format!(
                    "Failed to persist chat session: {error}"
                ))
            }))
        })
}

fn publish_committed_chat(state: &web::Data<AppState>, session: &bamboo_agent_core::Session) {
    if let Some(message) = session.messages.last() {
        state.account_sink.record(
            Some(&session.id),
            &bamboo_agent_core::AgentEvent::MessageAppended {
                session_id: session.id.clone(),
                message_id: message.id.clone(),
                role: message.role.clone(),
                content: message.content.clone(),
                created_at: message.created_at,
            },
        );
    }

    tracing::debug!(
        "[{}] Chat turn persisted: messages={}, last_role={:?} -> client should now POST /execute",
        session.id,
        session.messages.len(),
        session
            .messages
            .last()
            .map(|message| format!("{:?}", message.role)),
    );
    if !session.title_generated {
        crate::title_gen::spawn_title_generation(state.clone().into_inner(), session.id.clone());
    }
}

fn project_context_error_response(
    error: bamboo_engine::project_context::ProjectContextError,
) -> HttpResponse {
    use bamboo_engine::project_context::ProjectContextError;

    match error {
        ProjectContextError::WorkspaceConflict {
            workspace,
            owner_project_id,
            session_project_id,
        } => HttpResponse::Conflict().json(serde_json::json!({
            "error": {
                "type": "api_error",
                "code": "project_workspace_conflict",
                "message": "Workspace belongs to another Project"
            },
            "workspace": workspace,
            "owner_project_id": owner_project_id,
            "session_project_id": session_project_id,
        })),
        ProjectContextError::UnassignedWorkspaceConflict {
            workspace,
            owner_project_id,
        } => HttpResponse::Conflict().json(serde_json::json!({
            "error": {
                "type": "api_error",
                "code": "project_workspace_conflict",
                "message": "Workspace belongs to another Project"
            },
            "workspace": workspace,
            "owner_project_id": owner_project_id,
            "session_project_id": "unassigned",
        })),
        ProjectContextError::WorkspaceInvalid { workspace, message } => HttpResponse::BadRequest()
            .json(serde_json::json!({
                "error": {
                    "type": "api_error",
                    "code": "workspace_invalid",
                    "message": message
                },
                "workspace": workspace,
            })),
        ProjectContextError::InvalidProjectIdentity { raw, message } => HttpResponse::BadRequest()
            .json(serde_json::json!({
                "error": {
                    "type": "api_error",
                    "code": "invalid_project_identity",
                    "message": format!(
                        "Session carries an invalid Project identity '{raw}': {message}"
                    )
                }
            })),
        ProjectContextError::ProjectUnavailable { project_id } => {
            HttpResponse::Conflict().json(serde_json::json!({
                "error": {
                    "type": "api_error",
                    "code": "project_unavailable",
                    "message": "Assigned Project is unavailable"
                },
                "project_id": project_id,
            }))
        }
        ProjectContextError::ProjectPathMissing { project_id } => {
            HttpResponse::Conflict().json(serde_json::json!({
                "error": {
                    "type": "api_error",
                    "code": "project_path_missing",
                    "message": "Assigned Project has no configured project_path"
                },
                "project_id": project_id,
            }))
        }
        ProjectContextError::ProjectPathUnavailable {
            project_id,
            project_path,
            message,
        } => HttpResponse::Conflict().json(serde_json::json!({
            "error": {
                "type": "api_error",
                "code": "project_path_unavailable",
                "message": message
            },
            "project_id": project_id,
            "project_path": project_path,
        })),
        error @ (ProjectContextError::Source(_) | ProjectContextError::IdentityMismatch { .. }) => {
            tracing::error!(%error, "failed to resolve Project context");
            crate::error::json_error(
                actix_web::http::StatusCode::INTERNAL_SERVER_ERROR,
                "Failed to resolve Project context",
            )
        }
    }
}

fn workflow_selection_error_response(
    diagnostic: bamboo_skills::WorkflowActivationDiagnostic,
) -> HttpResponse {
    use bamboo_skills::WorkflowActivationErrorCode;

    let (status, code) = match diagnostic.code {
        WorkflowActivationErrorCode::RevisionMissing => (
            actix_web::http::StatusCode::CONFLICT,
            "workflow_revision_missing",
        ),
        WorkflowActivationErrorCode::RevisionMismatch => (
            actix_web::http::StatusCode::CONFLICT,
            "workflow_revision_mismatch",
        ),
        WorkflowActivationErrorCode::SourceMismatch => (
            actix_web::http::StatusCode::CONFLICT,
            "workflow_source_mismatch",
        ),
        WorkflowActivationErrorCode::ManualOnly => (
            actix_web::http::StatusCode::UNPROCESSABLE_ENTITY,
            "workflow_manual_only",
        ),
        WorkflowActivationErrorCode::InvalidSelection => (
            actix_web::http::StatusCode::UNPROCESSABLE_ENTITY,
            "workflow_selection_invalid",
        ),
        WorkflowActivationErrorCode::SnapshotUnavailable => (
            actix_web::http::StatusCode::SERVICE_UNAVAILABLE,
            "workflow_snapshot_unavailable",
        ),
        WorkflowActivationErrorCode::SnapshotTooLarge => (
            actix_web::http::StatusCode::PAYLOAD_TOO_LARGE,
            "workflow_snapshot_too_large",
        ),
        WorkflowActivationErrorCode::ProviderFailed
        | WorkflowActivationErrorCode::ProviderOutputInvalid => (
            actix_web::http::StatusCode::UNPROCESSABLE_ENTITY,
            "workflow_context_invalid",
        ),
    };
    HttpResponse::build(status).json(serde_json::json!({
        "error": {
            "type": "api_error",
            "code": code,
            "message": diagnostic.message,
            "recoverable": diagnostic.recoverable
        }
    }))
}

fn workflow_catalog_unavailable_response(error: &bamboo_skills::SkillError) -> HttpResponse {
    tracing::error!(%error, "failed to pin typed workflow catalog revision");
    workflow_selection_error_response(bamboo_skills::WorkflowActivationDiagnostic {
        code: bamboo_skills::WorkflowActivationErrorCode::SnapshotUnavailable,
        message: "Workflow catalog is temporarily unavailable; retry the request".to_string(),
        recoverable: true,
    })
}

async fn pin_explicit_workflow_candidate(
    state: &AppState,
    session: &mut bamboo_agent_core::Session,
    selection: &bamboo_skills::WorkflowSelection,
    disabled_skill_ids: &std::collections::BTreeSet<String>,
) -> Result<String, HttpResponse> {
    let selected_ids = [selection.id.clone()];
    // Resolve into an isolated staging activation. A stale/invalid request must
    // never replace or release the activation currently serving this session.
    // The staged bytes become durable authority only after the session save;
    // execute then restores them under the canonical session id.
    let staging_activation_id = format!("{}:chat-candidate:{}", session.id, uuid::Uuid::new_v4());
    let workspace = session.workspace_path_meta().map(std::path::PathBuf::from);
    let resolved_project = state
        .project_context_resolver
        .resolve(session, workspace.as_deref())
        .await
        .map_err(project_context_error_response)?;
    let (store, activation) = if let Some(context) = resolved_project {
        let store = state
            .skill_manager
            .store_for_project_workspace(
                &context.project.id,
                &context.project.home,
                context.workspace.as_deref(),
            )
            .await
            .map_err(|error| workflow_catalog_unavailable_response(&error))?;
        let activation = state
            .skill_manager
            .resolve_and_pin_activation_in_project_workspace_with_mode_and_budget(
                &context.project.id,
                &context.project.home,
                context.workspace.as_deref(),
                &staging_activation_id,
                disabled_skill_ids,
                Some(&selected_ids),
                None,
                None,
                bamboo_skills::DEFAULT_WORKFLOW_CATALOG_CONTEXT_TOKENS,
            )
            .await;
        (store, activation)
    } else if let Some(workspace) = workspace.as_deref() {
        // A session-scoped fallback is previewed without filesystem mutation.
        // Materialize it before opening the workspace catalog, but do not
        // publish it into runtime state until the base session checkpoint is
        // durable below. The resolver refuses to recreate missing paths
        // outside its authoritative root.
        state
            .workspace_resolver
            .materialize_resolved_workspace(workspace)
            .map_err(|error| {
                workflow_catalog_unavailable_response(&bamboo_skills::SkillError::Io(error))
            })?;
        let store = state
            .skill_manager
            .store_for_workspace(Some(workspace))
            .await
            .map_err(|error| workflow_catalog_unavailable_response(&error))?;
        let activation = state
            .skill_manager
            .resolve_and_pin_activation_in_workspace_with_mode_and_budget(
                workspace,
                &staging_activation_id,
                disabled_skill_ids,
                Some(&selected_ids),
                None,
                None,
                bamboo_skills::DEFAULT_WORKFLOW_CATALOG_CONTEXT_TOKENS,
            )
            .await;
        (store, activation)
    } else {
        let store = state
            .skill_manager
            .store_for_workspace(None)
            .await
            .map_err(|error| workflow_catalog_unavailable_response(&error))?;
        let activation = state
            .skill_manager
            .resolve_and_pin_activation_for_request_with_mode_and_budget(
                &staging_activation_id,
                disabled_skill_ids,
                Some(&selected_ids),
                None,
                None,
                bamboo_skills::DEFAULT_WORKFLOW_CATALOG_CONTEXT_TOKENS,
            )
            .await;
        (store, activation)
    };
    let activation = match activation {
        Ok(activation) => activation,
        Err(error) => {
            let _ = state
                .skill_manager
                .release_activation_for_workspace(&staging_activation_id, workspace.as_deref())
                .await;
            return Err(workflow_catalog_unavailable_response(&error));
        }
    };
    let snapshot = match store
        .export_activation_snapshot(&staging_activation_id)
        .await
    {
        Some(snapshot) => snapshot,
        None => {
            let _ = state
                .skill_manager
                .release_activation_for_workspace(&staging_activation_id, workspace.as_deref())
                .await;
            return Err(workflow_selection_error_response(
                bamboo_skills::WorkflowActivationDiagnostic {
                    code: bamboo_skills::WorkflowActivationErrorCode::SnapshotUnavailable,
                    message: "selected workflow snapshot could not be retained".to_string(),
                    recoverable: true,
                },
            ));
        }
    };
    if let Err(diagnostic) = bamboo_skills::persist_explicit_workflow_candidate(
        &mut session.metadata,
        selection,
        &activation,
        &snapshot,
    ) {
        let _ = state
            .skill_manager
            .release_activation_for_workspace(&staging_activation_id, workspace.as_deref())
            .await;
        return Err(workflow_selection_error_response(diagnostic));
    }
    Ok(staging_activation_id)
}

struct StagedWorkflowActivation {
    activation_id: String,
    metadata_upserts: Vec<(String, String)>,
    metadata_removals: Vec<String>,
    skill_manager: std::sync::Arc<bamboo_skills::SkillManager>,
    cleanup_armed: bool,
}

impl Drop for StagedWorkflowActivation {
    fn drop(&mut self) {
        if !self.cleanup_armed {
            return;
        }
        let skill_manager = self.skill_manager.clone();
        let activation_id = self.activation_id.clone();
        match tokio::runtime::Handle::try_current() {
            Ok(handle) => {
                let _cleanup = handle.spawn(async move {
                    if let Err(error) = skill_manager
                        .release_activation_for_workspace(&activation_id, None)
                        .await
                    {
                        tracing::error!(
                            %activation_id,
                            %error,
                            "failed to release abandoned staged Workflow activation"
                        );
                    }
                });
            }
            Err(error) => {
                tracing::error!(
                    activation_id = %self.activation_id,
                    %error,
                    "runtime unavailable while releasing staged Workflow activation"
                );
            }
        }
    }
}

#[derive(Default)]
struct WorkflowMetadataCheckpoint {
    entries: std::collections::HashMap<String, String>,
}

impl WorkflowMetadataCheckpoint {
    fn capture(session: Option<&bamboo_agent_core::Session>) -> Self {
        let entries = session
            .into_iter()
            .flat_map(|session| session.metadata.iter())
            .filter(|(key, _)| workflow_transaction_metadata_key(key))
            .map(|(key, value)| (key.clone(), value.clone()))
            .collect();
        Self { entries }
    }

    fn restore(&self, session: &mut bamboo_agent_core::Session) {
        session
            .metadata
            .retain(|key, _| !workflow_transaction_metadata_key(key));
        session.metadata.extend(self.entries.clone());
    }
}

fn workflow_transaction_metadata_key(key: &str) -> bool {
    key.starts_with("workflow.")
        || key.starts_with("skill_runtime_")
        || matches!(key, "selected_skill_ids" | "skill_mode")
}

fn workflow_runner_is_active(runner: Option<&crate::app_state::AgentRunner>) -> bool {
    runner.is_some_and(|runner| {
        matches!(
            runner.status,
            crate::app_state::AgentStatus::Pending | crate::app_state::AgentStatus::Running
        )
    })
}

fn workflow_activation_running_conflict_response(session_id: &str) -> HttpResponse {
    HttpResponse::Conflict().json(serde_json::json!({
        "error": {
            "type": "api_error",
            "code": "workflow_activation_running_conflict",
            "message": "A running or starting session cannot replace its active Workflow"
        },
        "session_id": session_id,
    }))
}

#[cfg(test)]
struct WorkflowCommitTestBarrier {
    reached: tokio::sync::Semaphore,
    resume: tokio::sync::Semaphore,
}

#[cfg(test)]
impl Default for WorkflowCommitTestBarrier {
    fn default() -> Self {
        Self {
            reached: tokio::sync::Semaphore::new(0),
            resume: tokio::sync::Semaphore::new(0),
        }
    }
}

#[cfg(test)]
static WORKFLOW_COMMIT_TEST_BARRIERS: std::sync::LazyLock<
    std::sync::Mutex<std::collections::HashMap<String, std::sync::Arc<WorkflowCommitTestBarrier>>>,
> = std::sync::LazyLock::new(|| std::sync::Mutex::new(std::collections::HashMap::new()));

#[cfg(test)]
static WORKFLOW_POST_SAVE_TEST_BARRIERS: std::sync::LazyLock<
    std::sync::Mutex<std::collections::HashMap<String, std::sync::Arc<WorkflowCommitTestBarrier>>>,
> = std::sync::LazyLock::new(|| std::sync::Mutex::new(std::collections::HashMap::new()));

#[cfg(test)]
fn install_workflow_commit_test_barrier(
    session_id: &str,
) -> std::sync::Arc<WorkflowCommitTestBarrier> {
    let barrier = std::sync::Arc::new(WorkflowCommitTestBarrier::default());
    WORKFLOW_COMMIT_TEST_BARRIERS
        .lock()
        .unwrap_or_else(|error| error.into_inner())
        .insert(session_id.to_string(), barrier.clone());
    barrier
}

#[cfg(test)]
async fn wait_at_workflow_commit_test_barrier(session_id: &str) {
    let barrier = WORKFLOW_COMMIT_TEST_BARRIERS
        .lock()
        .unwrap_or_else(|error| error.into_inner())
        .remove(session_id);
    if let Some(barrier) = barrier {
        barrier.reached.add_permits(1);
        barrier
            .resume
            .acquire()
            .await
            .expect("workflow commit test barrier remains open")
            .forget();
    }
}

#[cfg(test)]
fn install_workflow_post_save_test_barrier(
    session_id: &str,
) -> std::sync::Arc<WorkflowCommitTestBarrier> {
    let barrier = std::sync::Arc::new(WorkflowCommitTestBarrier::default());
    WORKFLOW_POST_SAVE_TEST_BARRIERS
        .lock()
        .unwrap_or_else(|error| error.into_inner())
        .insert(session_id.to_string(), barrier.clone());
    barrier
}

#[cfg(test)]
async fn wait_at_workflow_post_save_test_barrier(session_id: &str) {
    let barrier = WORKFLOW_POST_SAVE_TEST_BARRIERS
        .lock()
        .unwrap_or_else(|error| error.into_inner())
        .remove(session_id);
    if let Some(barrier) = barrier {
        barrier.reached.add_permits(1);
        barrier
            .resume
            .acquire()
            .await
            .expect("workflow post-save test barrier remains open")
            .forget();
    }
}

impl StagedWorkflowActivation {
    fn between(
        activation_id: String,
        current: &std::collections::HashMap<String, String>,
        candidate: &std::collections::HashMap<String, String>,
        skill_manager: std::sync::Arc<bamboo_skills::SkillManager>,
    ) -> Self {
        let metadata_upserts = candidate
            .iter()
            .filter(|(key, value)| {
                workflow_transaction_metadata_key(key) && current.get(*key) != Some(*value)
            })
            .map(|(key, value)| (key.clone(), value.clone()))
            .collect();
        let metadata_removals = current
            .keys()
            .filter(|key| workflow_transaction_metadata_key(key) && !candidate.contains_key(*key))
            .cloned()
            .collect();
        Self {
            activation_id,
            metadata_upserts,
            metadata_removals,
            skill_manager,
            cleanup_armed: true,
        }
    }

    fn apply(&self, metadata: &mut std::collections::HashMap<String, String>) {
        for key in &self.metadata_removals {
            metadata.remove(key);
        }
        for (key, value) in &self.metadata_upserts {
            metadata.insert(key.clone(), value.clone());
        }
    }

    async fn release(&mut self) {
        if !self.cleanup_armed {
            return;
        }
        match self
            .skill_manager
            .release_activation_for_workspace(&self.activation_id, None)
            .await
        {
            Ok(()) => self.cleanup_armed = false,
            Err(error) => tracing::error!(
                activation_id = %self.activation_id,
                %error,
                "failed to release staged Workflow activation"
            ),
        }
    }
}

#[cfg(test)]
mod tests;

/// Create a new chat message or update an existing session.
///
/// This endpoint accepts a user message and creates or updates a chat session.
/// After calling this endpoint, use the returned `stream_url` to execute
/// the agent and receive events.
pub async fn handler(
    state: web::Data<AppState>,
    http_request: HttpRequest,
    req: web::Json<ChatRequest>,
) -> HttpResponse {
    let prepared = match crate::app_state::mutation_idempotency::prepare(
        &http_request,
        "chat",
        "POST /api/v1/chat",
        &*req,
    ) {
        Ok(prepared) => prepared,
        Err(response) => return response,
    };
    let Some(prepared) = prepared else {
        return handle_chat(state, req).await;
    };
    let store = state.mutation_idempotency.clone();
    store.execute(prepared, || handle_chat(state, req)).await
}

async fn handle_chat(state: web::Data<AppState>, req: web::Json<ChatRequest>) -> HttpResponse {
    let session_id = request::resolve_session_id(req.session_id.as_deref());
    let (
        existing_session_found,
        existing_project_id,
        existing_workspace,
        existing_workspace_source,
    ) = match state.storage.load_session(&session_id).await {
        Ok(Some(existing)) => {
            let project_id = match bamboo_engine::project_context::ProjectContextResolver::session_project_identity(&existing) {
                    bamboo_engine::project_context::SessionProjectIdentity::Assigned(project_id) => Some(project_id),
                    bamboo_engine::project_context::SessionProjectIdentity::Unassigned => None,
                    bamboo_engine::project_context::SessionProjectIdentity::Invalid { raw, message } => {
                        return HttpResponse::BadRequest().json(serde_json::json!({
                            "error": {
                                "type": "api_error",
                                "code": "invalid_project_identity",
                                "message": format!(
                                    "Session carries an invalid Project identity '{raw}': {message}"
                                )
                            },
                            "session_id": session_id,
                        }));
                    }
                };
            (
                true,
                project_id,
                existing.workspace_path_meta(),
                existing
                    .metadata
                    .get(bamboo_engine::project_context::WORKSPACE_SOURCE_METADATA_KEY)
                    .cloned(),
            )
        }
        Ok(None) => (false, None, None, None),
        Err(error) => {
            tracing::error!(%error, "failed to load chat session for Project validation");
            return crate::error::json_error(
                actix_web::http::StatusCode::INTERNAL_SERVER_ERROR,
                "Failed to validate session Project membership",
            );
        }
    };
    if let Some(project_id) = req.project_id.as_ref() {
        match state.project_store.get(project_id) {
            Ok(project) if project.status == bamboo_domain::ProjectStatus::Active => {}
            Ok(_) => {
                return HttpResponse::Conflict().json(serde_json::json!({
                    "error": {
                        "type": "api_error",
                        "code": "project_archived",
                        "message": "Sessions can only be created in an active Project"
                    },
                    "project_id": project_id,
                }));
            }
            Err(bamboo_projects::ProjectStoreError::NotFound(_)) => {
                return crate::error::json_error(
                    actix_web::http::StatusCode::NOT_FOUND,
                    "target Project not found",
                );
            }
            Err(error) => {
                tracing::error!(%error, "failed to validate chat Project");
                return crate::error::json_error(
                    actix_web::http::StatusCode::INTERNAL_SERVER_ERROR,
                    "Failed to validate target Project",
                );
            }
        }
        if existing_session_found && existing_project_id.as_ref() != Some(project_id) {
            return HttpResponse::Conflict().json(serde_json::json!({
                "error": {
                    "type": "api_error",
                    "code": "session_project_reassignment_required",
                    "message": "Chat cannot change Project membership; use PATCH /sessions/{id}"
                },
                "session_id": session_id,
                "current_project_id": existing_project_id,
                "requested_project_id": project_id,
            }));
        }
    }
    let effective_project_id = req.project_id.clone().or(existing_project_id);
    let requested_workspace = req.workspace_path.as_deref();
    let fallback_workspace = || {
        request::optional_non_empty(req.workspace_path.as_deref()).or_else(|| {
            (existing_workspace_source.as_deref()
                != Some(bamboo_engine::project_context::WorkspaceSource::ProjectDefault.as_str()))
            .then_some(existing_workspace.as_deref())
            .flatten()
        })
    };
    let workspace_validation = if let Some(requested_workspace) = requested_workspace {
        crate::project_context::validate_explicit_session_workspace_with_resolver(
            &state.project_store,
            effective_project_id.as_ref(),
            requested_workspace,
            &state.workspace_resolver,
        )
        .map(Some)
        .map_err(crate::project_context::session_workspace_error_response)
    } else {
        crate::project_context::validate_workspace_assignment_with_resolver(
            &state.project_store,
            effective_project_id.as_ref(),
            fallback_workspace(),
            &state.workspace_resolver,
        )
        .map_err(|error| match error {
            crate::project_context::ProjectWorkspaceValidationError::Invalid {
                code,
                workspace,
                message,
            } => {
                let mut response = if code.starts_with("project_path_") {
                    HttpResponse::Conflict()
                } else {
                    HttpResponse::BadRequest()
                };
                response.json(serde_json::json!({
                    "error": {
                        "type": "api_error",
                        "code": code,
                        "message": message
                    },
                    "workspace": workspace,
                }))
            }
            crate::project_context::ProjectWorkspaceValidationError::Conflict {
                workspace,
                owner_project_id,
                session_project_id,
            } => HttpResponse::Conflict().json(serde_json::json!({
                "error": {
                    "type": "api_error",
                    "code": "project_workspace_conflict",
                    "message": "Workspace belongs to another Project"
                },
                "workspace": workspace,
                "owner_project_id": owner_project_id,
                "session_project_id": session_project_id,
            })),
            crate::project_context::ProjectWorkspaceValidationError::Store(error) => {
                tracing::error!(%error, "failed to validate workspace Project ownership");
                crate::error::json_error(
                    actix_web::http::StatusCode::INTERNAL_SERVER_ERROR,
                    "Failed to validate workspace Project ownership",
                )
            }
        })
    };
    let final_workspace = match workspace_validation {
        Ok(workspace) => workspace,
        Err(response) => return response,
    };
    let final_workspace_display = final_workspace
        .as_deref()
        .map(bamboo_config::paths::path_to_display_string);
    tracing::debug!(
        "[{}] Chat requested: message_len={}, is_goal_command={}, image_count={}",
        session_id,
        req.message.len(),
        parse_goal_command(&req.message).is_some(),
        req.images.as_ref().map(|i| i.len()).unwrap_or(0),
    );
    // Only resolve the server-side default (a config read + the shared
    // resolution cascade) when the request omitted `model` — the common case
    // (an explicit model) pays none of that cost. #480: fall back to the SAME
    // resolved default the connect bridge and `GET /execute/defaults` use, so
    // there is one implementation of "what model does this server default to".
    let config_snapshot = state.config.read().await.clone();
    let default_model = if request::optional_non_empty(req.model.as_deref()).is_some() {
        None
    } else {
        bamboo_engine::resolved_defaults::resolve_default_run_config(
            &config_snapshot,
            &state.provider_registry,
        )
        .model_roster
        .model
    };
    let model = match request::resolve_model(req.model.as_deref(), default_model.as_deref()) {
        Ok(model) => model,
        Err(response) => return response,
    };

    let global_default_prompt =
        bamboo_engine::prompt_defaults::read_global_default_system_prompt_template();
    let builtin_fallback_prompt = crate::app_state::DEFAULT_BASE_PROMPT;
    let configured_default_workspace = config_snapshot
        .get_default_work_area_path()
        .as_deref()
        .map(bamboo_config::paths::path_to_display_string);
    let session_fallback_path = state
        .workspace_resolver
        .preview_session_fallback(&session_id)
        .as_deref()
        .map(bamboo_config::paths::path_to_display_string);

    let data_dir = Some(state.app_data_dir.clone());
    let mut project_preflight = bamboo_agent_core::Session::new(&session_id, &model);
    if let Some(project_id) = effective_project_id.as_ref() {
        project_preflight.set_project_id_meta(project_id.to_string());
    }
    if let Some(workspace) = final_workspace_display.as_deref() {
        project_preflight.set_workspace_path_meta(workspace);
        let source = if req.workspace_path.is_some() {
            bamboo_engine::project_context::WorkspaceSource::Explicit
        } else if existing_workspace.is_some()
            && existing_workspace_source.as_deref()
                != Some(bamboo_engine::project_context::WorkspaceSource::ProjectDefault.as_str())
        {
            bamboo_engine::project_context::WorkspaceSource::Session
        } else if effective_project_id.is_some() {
            bamboo_engine::project_context::WorkspaceSource::ProjectDefault
        } else {
            bamboo_engine::project_context::WorkspaceSource::Session
        };
        project_preflight.metadata.insert(
            bamboo_engine::project_context::WORKSPACE_SOURCE_METADATA_KEY.to_string(),
            source.as_str().to_string(),
        );
    } else if let Some(workspace) = configured_default_workspace.as_deref() {
        project_preflight.set_workspace_path_meta(workspace);
    } else if let Some(workspace) = session_fallback_path.as_deref() {
        // This owning-state fallback is explicit so Project preflight cannot
        // observe a same-id runtime entry published by another AppState.
        project_preflight.set_workspace_path_meta(workspace);
    }
    if let Err(error) = state
        .project_context_resolver
        .refresh_session_prompt_read_only(&mut project_preflight)
        .await
    {
        return project_context_error_response(error);
    }
    let workspace_was_explicit = req.workspace_path.is_some();
    let requested_workflow_selection = req.workflow_selection.clone();
    let mut input = bamboo_engine::session_app::types::ChatTurnInput {
        session_id: session_id.clone(),
        project_id: effective_project_id,
        model: model.clone(),
        model_ref: req.model_ref.clone(),
        provider: req.provider.clone(),
        reasoning_effort: req.reasoning_effort,
        message: req.message.clone(),
        system_prompt: request::optional_non_empty(req.system_prompt.as_deref()).map(String::from),
        enhance_prompt: request::optional_non_empty(req.enhance_prompt.as_deref())
            .map(String::from),
        // Preserve field presence. An omitted workspace must be resolved from
        // the fresh durable session after acquiring the lock, not from this
        // lock-free preflight snapshot.
        workspace_path: workspace_was_explicit
            .then(|| project_preflight.workspace_path_meta())
            .flatten(),
        default_workspace_path: configured_default_workspace,
        selected_skill_ids: if requested_workflow_selection.is_some() {
            None
        } else {
            req.selected_skill_ids.clone()
        },
        // A typed selection is resolved into a separate candidate below. The
        // authoritative session must retain its current activation until every
        // fallible hook, attachment and message write in this request succeeds.
        workflow_selection: None,
        orchestration_opt_in: req.orchestration_opt_in,
        copilot_conclusion_with_options_enhancement_enabled: req
            .copilot_conclusion_with_options_enhancement_enabled,
        data_dir,
    };

    // Serialize the authoritative reload, Project/workspace resolution and all
    // writes for this turn. In particular, Project reassignment PATCH uses the
    // same lock and therefore cannot slip between the second load and a stale
    // chat snapshot save.
    let persistence_guard = state.persistence.acquire_lock(&session_id).await;
    // Reject an already-running session before doing catalog or hook work. A
    // second check immediately before publication below closes the race with a
    // reservation that appears while this request is being prepared.
    if requested_workflow_selection.is_some() {
        let runners = state.agent_runners.read().await;
        let runner_is_active = workflow_runner_is_active(runners.get(&session_id));
        let startup_is_active = crate::handlers::agent::events::execute_startup_is_in_flight(
            state.as_ref(),
            &session_id,
        );
        if runner_is_active || startup_is_active {
            return workflow_activation_running_conflict_response(&session_id);
        }
    }
    let authoritative_session = match state.persistence.storage().load_session(&session_id).await {
        Ok(session) => session,
        Err(error) => {
            tracing::error!(%error, "failed to load authoritative chat session");
            return crate::error::json_error(
                actix_web::http::StatusCode::INTERNAL_SERVER_ERROR,
                "Failed to load authoritative chat session",
            );
        }
    };
    let workflow_metadata_checkpoint =
        WorkflowMetadataCheckpoint::capture(authoritative_session.as_ref());
    let authoritative_workspace_present = authoritative_session.as_ref().is_some_and(|session| {
        session.workspace_path_meta().is_some()
            && session
                .metadata
                .get(bamboo_engine::project_context::WORKSPACE_SOURCE_METADATA_KEY)
                .map(String::as_str)
                != Some(bamboo_engine::project_context::WorkspaceSource::ProjectDefault.as_str())
    });
    if req.project_id.is_none() {
        input.project_id = authoritative_session.as_ref().and_then(|session| {
            match bamboo_engine::project_context::ProjectContextResolver::session_project_identity(
                session,
            ) {
                bamboo_engine::project_context::SessionProjectIdentity::Assigned(project_id) => {
                    Some(project_id)
                }
                bamboo_engine::project_context::SessionProjectIdentity::Unassigned
                | bamboo_engine::project_context::SessionProjectIdentity::Invalid { .. } => None,
            }
        });
    }
    if let Some(requested_workspace) = req.workspace_path.as_deref() {
        input.workspace_path =
            match crate::project_context::validate_explicit_session_workspace_with_resolver(
                &state.project_store,
                input.project_id.as_ref(),
                requested_workspace,
                &state.workspace_resolver,
            ) {
                Ok(workspace) => Some(bamboo_config::paths::path_to_display_string(&workspace)),
                Err(error) => {
                    return crate::project_context::session_workspace_error_response(error)
                }
            };
    } else {
        input.workspace_path = None;
    }
    let workspace_source = if workspace_was_explicit {
        "request"
    } else if authoritative_workspace_present {
        "session"
    } else if input.project_id.is_some() {
        "project_default"
    } else if input.default_workspace_path.is_some() {
        "configured_default"
    } else {
        "session_fallback"
    };
    let workspace_fallback_policy =
        bamboo_engine::session_app::types::ChatWorkspaceFallbackPolicy::Authoritative {
            session_fallback_path,
        };

    let mut session = match bamboo_engine::session_app::chat::prepare_chat_turn_from_authoritative_session_with_workspace_policy(
        authoritative_session,
        input,
        global_default_prompt.as_str(),
        builtin_fallback_prompt,
        workspace_fallback_policy,
    ) {
            Ok(session) => session,
            Err(bamboo_engine::session_app::errors::ChatError::InvalidWorkflowSelection(error)) => {
                return HttpResponse::BadRequest().json(serde_json::json!({
                    "error": crate::error::error_value(error)
                }));
            }
            Err(bamboo_engine::session_app::errors::ChatError::InvalidProjectIdentity {
                raw,
                message,
            }) => {
                return HttpResponse::BadRequest().json(serde_json::json!({
                    "error": {
                        "type": "api_error",
                        "code": "invalid_project_identity",
                        "message": format!(
                            "Session carries an invalid Project identity '{raw}': {message}"
                        )
                    },
                    "session_id": session_id,
                }));
            }
            Err(bamboo_engine::session_app::errors::ChatError::ProjectIdentityConflict {
                expected,
                actual,
            }) => {
                return HttpResponse::Conflict().json(serde_json::json!({
                    "error": {
                        "type": "api_error",
                        "code": "session_project_changed",
                        "message": "Session Project membership changed while preparing chat"
                    },
                    "session_id": session_id,
                    "expected_project_id": expected,
                    "actual_project_id": actual,
                }));
            }
            Err(error) => {
                tracing::error!("Chat turn preparation failed: {error}");
                return HttpResponse::InternalServerError().json(serde_json::json!({
                    "error": crate::error::error_value(format!("Failed to prepare chat: {error}"))
                }));
            }
        };
    let session_was_created = session
        .metadata
        .get(bamboo_engine::session_app::chat::SESSION_START_SOURCE_METADATA_KEY)
        .is_some_and(|source| source == "startup");
    if let Err(error) = state
        .project_context_resolver
        .refresh_session_prompt_read_only(&mut session)
        .await
    {
        return project_context_error_response(error);
    }
    let mut staged_workflow_activation =
        if let Some(selection) = requested_workflow_selection.as_ref() {
            let mut candidate = session.clone();
            if let Err(error) = bamboo_engine::session_app::chat::resolve_workflow_selection(
                &mut candidate,
                Some(selection),
                req.selected_skill_ids.as_deref(),
                &req.message,
            ) {
                return HttpResponse::BadRequest().json(serde_json::json!({
                    "error": crate::error::error_value(error.to_string())
                }));
            }
            let disabled_skill_ids = config_snapshot.disabled_skill_ids();
            let staging_id = match pin_explicit_workflow_candidate(
                state.as_ref(),
                &mut candidate,
                selection,
                &disabled_skill_ids,
            )
            .await
            {
                Ok(staging_id) => staging_id,
                Err(response) => return response,
            };
            Some(StagedWorkflowActivation::between(
                staging_id,
                &session.metadata,
                &candidate.metadata,
                state.skill_manager.clone(),
            ))
        } else {
            None
        };
    // Publish the prepared checkpoint without any speculative Workflow
    // normalization. The in-memory turn keeps those changes for a successful
    // final commit, while every rejected/failing path continues to expose the
    // exact pre-request Workflow authority.
    let mut durable_base = session.clone();
    workflow_metadata_checkpoint.restore(&mut durable_base);
    if let Err(response) = save_and_cache_session_locked(state.as_ref(), &durable_base).await {
        if let Some(staging) = staged_workflow_activation.as_mut() {
            staging.release().await;
        }
        return response;
    }
    sync_runtime_workspace(
        state.as_ref(),
        &session_id,
        session.workspace_path_meta().as_deref(),
        workspace_source,
    );
    if session_was_created {
        state.account_sink.record(
            Some(&session_id),
            &bamboo_agent_core::AgentEvent::SessionCreated {
                session_id: session_id.clone(),
                project_id: session.project_id_meta(),
                title: session.title.clone(),
                kind: session.kind,
                created_at: session.created_at,
            },
        );
    }

    let effective_message = match crate::lifecycle_hooks::apply_user_prompt_submit_hooks(
        &config_snapshot.lifecycle_hooks,
        Some(state.app_data_dir.clone()),
        &mut session,
        &req.message,
    )
    .await
    {
        Ok(message) => message,
        Err(reason) => {
            if let Some(staging) = staged_workflow_activation.as_mut() {
                staging.release().await;
            }
            // Persist the hook checkpoint but never the rejected user message.
            workflow_metadata_checkpoint.restore(&mut session);
            if let Err(response) = save_and_cache_session_locked(state.as_ref(), &session).await {
                return response;
            }
            return HttpResponse::BadRequest().json(serde_json::json!({
                "error": crate::error::error_value(reason),
                "hook_event": "UserPromptSubmit"
            }));
        }
    };

    // ---- Goal command interception ----
    if let Some(goal_cmd) = parse_goal_command(&req.message) {
        tracing::debug!(
            "[{}] Chat intercepted as /goal command: {:?}",
            session_id,
            goal_cmd
        );
        // Goal metadata writers acquire the same per-session lock and load the
        // latest durable session themselves. The prepared checkpoint is
        // already durable, so hand ownership over before invoking them.
        if let Some(staging) = staged_workflow_activation.as_mut() {
            staging.release().await;
        }
        drop(persistence_guard);
        return handle_goal_command(state.as_ref(), &session_id, &goal_cmd).await;
    }

    #[cfg(test)]
    wait_at_workflow_commit_test_barrier(&session_id).await;

    // A typed activation replaces both durable Workflow metadata and the
    // session-id keyed immutable skill pin. Re-check after all fallible hook
    // work, then retain the runners read guard through attachment persistence,
    // the final session save and pin handoff. The persistence lock linearizes
    // HTTP execute startup; the runners guard closes reservation races from
    // resume, schedule and connect entry points.
    let workflow_commit_guard = if staged_workflow_activation.is_some() {
        let runners = state.agent_runners.clone().read_owned().await;
        let runner_is_active = workflow_runner_is_active(runners.get(&session_id));
        let startup_is_active = crate::handlers::agent::events::execute_startup_is_in_flight(
            state.as_ref(),
            &session_id,
        );
        if runner_is_active || startup_is_active {
            if let Some(staging) = staged_workflow_activation.as_mut() {
                staging.release().await;
            }
            return workflow_activation_running_conflict_response(&session_id);
        }
        Some(runners)
    } else {
        None
    };

    // Image handling stays in the handler layer (depends on AppState attachment reader).
    if let Err(response) = images::append_user_message(
        &state,
        &mut session,
        &effective_message,
        req.images.as_deref(),
    )
    .await
    {
        if let Some(staging) = staged_workflow_activation.as_mut() {
            staging.release().await;
        }
        return response;
    }

    if let Some(mut staging) = staged_workflow_activation {
        staging.apply(&mut session.metadata);
        let commit_state = state.clone();
        let commit_session_id = session_id.clone();
        let commit = tokio::spawn(async move {
            // These owned guards make the exact save -> pin handoff
            // cancellation-resistant. Dropping the caller's HTTP future only
            // detaches this task; it cannot expose committed B metadata while
            // the session-id pin still serves A.
            let _persistence_guard = persistence_guard;
            let _workflow_commit_guard = workflow_commit_guard;
            if let Err(error) =
                persist_and_cache_session_locked(commit_state.as_ref(), &session).await
            {
                staging.release().await;
                return Err(error.to_string());
            }
            #[cfg(test)]
            wait_at_workflow_post_save_test_barrier(&commit_session_id).await;

            // The durable user turn and exact snapshot now own the next
            // execution. Only now may the prior live activation be released.
            if let Err(error) = commit_state
                .skill_manager
                .release_activation_for_workspace(&commit_session_id, None)
                .await
            {
                tracing::error!(
                    session_id = %commit_session_id,
                    %error,
                    "failed to release prior Workflow activation after commit"
                );
            }
            staging.release().await;
            publish_committed_chat(&commit_state, &session);
            Ok::<(), String>(())
        });
        match commit.await {
            Ok(Ok(())) => {}
            Ok(Err(error)) => {
                return HttpResponse::InternalServerError().json(serde_json::json!({
                    "error": crate::error::error_value(format!(
                        "Failed to persist chat session: {error}"
                    ))
                }));
            }
            Err(error) => {
                tracing::error!(%error, "typed Workflow chat commit task failed");
                return crate::error::json_error(
                    actix_web::http::StatusCode::INTERNAL_SERVER_ERROR,
                    "Failed to commit typed Workflow chat",
                );
            }
        }
    } else {
        // Re-save to persist image attachments (if any).
        if let Err(response) = save_and_cache_session_locked(state.as_ref(), &session).await {
            return response;
        }
        drop(workflow_commit_guard);
        publish_committed_chat(&state, &session);
        drop(persistence_guard);
    }

    HttpResponse::Created().json(ChatResponse {
        session_id: session_id.clone(),
        stream_url: format!("/api/v1/events/{}", session_id),
        status: "streaming".to_string(),
        goal_command: None,
    })
}

/// Additional response payload for `/goal` control commands.
#[derive(Debug, serde::Serialize)]
pub struct GoalCommandResponse {
    /// The action taken: "status", "off", "clear", "on", "set_prompt", "on_no_prompt".
    pub action: String,
    /// Whether the frontend should proceed with execute after this response.
    pub should_execute: bool,
    /// The updated (or current) gold config for this session.
    pub gold_config: Option<GoldConfig>,
}

/// Handle a parsed `/goal` command by updating session metadata and optionally
/// injecting a hidden resume message to trigger the Gold mini-loop.
async fn handle_goal_command(
    state: &AppState,
    session_id: &str,
    cmd: &GoalCommand,
) -> HttpResponse {
    let config_snapshot = state.config.read().await.clone();

    // Load current session to read the existing gold_config override.
    let session = match state.load_session_merged(session_id).await {
        Some(s) => s,
        None => {
            return HttpResponse::NotFound().json(serde_json::json!({
                "error": crate::error::error_value("Session not found"),
                "session_id": session_id
            }));
        }
    };

    // Resolve the current effective gold config (session override → global default).
    let current_json = session.metadata.get(GOLD_CONFIG_METADATA_KEY).cloned();
    let current_effective = resolve_gold_config(&config_snapshot, current_json.as_deref());

    let (new_config, should_resume) = match cmd {
        GoalCommand::Status => {
            let response_config = current_effective.clone();
            return HttpResponse::Ok().json(ChatResponse {
                session_id: session_id.to_string(),
                stream_url: format!("/api/v1/events/{}", session_id),
                status: "accepted".to_string(),
                goal_command: Some(GoalCommandResponse {
                    action: "status".to_string(),
                    should_execute: false,
                    gold_config: response_config,
                }),
            });
        }
        GoalCommand::Off => {
            let mut cfg = current_effective.unwrap_or_default();
            cfg.enabled = false;
            cfg.auto_answer_enabled = false;
            cfg.auto_continue_enabled = false;
            (cfg, false)
        }
        GoalCommand::Clear => {
            let mut cfg = current_effective.unwrap_or_default();
            cfg.enabled = false;
            cfg.auto_answer_enabled = false;
            cfg.auto_continue_enabled = false;
            cfg.goal = None;
            cfg.evaluation_prompt = None;
            (cfg, false)
        }
        GoalCommand::On => {
            let mut cfg = current_effective.unwrap_or_default();
            let has_prompt = cfg.effective_goal().is_some();
            if !has_prompt {
                return HttpResponse::Ok().json(ChatResponse {
                    session_id: session_id.to_string(),
                    stream_url: format!("/api/v1/events/{}", session_id),
                    status: "accepted".to_string(),
                    goal_command: Some(GoalCommandResponse {
                        action: "on_no_prompt".to_string(),
                        should_execute: false,
                        gold_config: Some(cfg),
                    }),
                });
            }
            cfg.enabled = true;
            cfg.auto_answer_enabled = true;
            cfg.auto_continue_enabled = true;
            (cfg, false)
        }
        GoalCommand::SetPrompt(prompt) => {
            let mut cfg = current_effective.unwrap_or_default();
            cfg.enabled = true;
            cfg.auto_answer_enabled = true;
            cfg.auto_continue_enabled = true;
            cfg.goal = Some(prompt.clone());
            (cfg, true)
        }
    };

    // Serialize the new config and persist via authoritative metadata writer.
    let new_json = serde_json::to_string(&new_config).ok();
    match SessionMetadataService::set_gold_config_json(state, session_id, new_json.clone(), None)
        .await
    {
        Ok(_) => {}
        Err(e) => {
            tracing::error!(session_id = %session_id, "Failed to persist gold_config: {e}");
            return HttpResponse::InternalServerError().json(serde_json::json!({
                "error": crate::error::error_value(format!("Failed to update goal config: {e}"))
            }));
        }
    }

    // Reset stale goal runtime state on ANY goal-config change — off / clear / on
    // / set-prompt — not just set-prompt. Otherwise a finished goal's status and
    // its double-check eval history linger in `goal.state` and keep being
    // surfaced to the frontend (and over the history API) after the goal is
    // turned off or cleared. The suspension reset + clarification turn below are
    // specific to `/goal <prompt>` and stay gated on `should_resume`.
    if let Some(mut session) = state.load_session_merged(session_id).await {
        // Drop ALL `gold.*` runtime snapshot keys by prefix — last_evaluation /
        // last_decision / last_confidence / last_reasoning / last_checkpoint /
        // last_iteration / evaluation_count (written by
        // `apply_gold_evaluation_result`) plus the legacy auto_continue_count — so
        // this list can't drift out of sync with what the evaluator writes. The
        // config lives under `gold_config` (no dot), so it is left untouched.
        session.metadata.retain(|key, _| !key.starts_with("gold."));
        // Durable goal state (status, continuation budget, declared status, and
        // the double-check eval history). Keyed by
        // `goal_state::GOAL_STATE_METADATA_KEY`.
        session.metadata.remove("goal.state");

        if should_resume {
            // Reset runtime suspension so execute can proceed.
            if let Some(runtime_state) = session.agent_runtime_state.as_mut() {
                runtime_state.status = bamboo_domain::AgentStatusState::Idle;
                runtime_state.suspension = None;
                runtime_state.waiting_for_children = None;
            }
            session.metadata.remove("runtime.suspend_reason");

            // Read the goal text back so we can echo it into the discussion turn.
            let goal_text = parse_session_gold_config(new_json.as_deref())
                .as_ref()
                .and_then(|cfg| cfg.effective_goal().map(str::to_string))
                .unwrap_or_default();

            // Inject a runtime instruction that asks the agent to discuss the
            // goal with the user before executing. The instruction itself is
            // hidden from the UI; the agent's visible reply IS the discussion.
            let instruction = format!(
                "The user has set a session goal:\n\n{goal_text}\n\nBefore taking any action, briefly confirm your understanding of this goal, surface any ambiguities or assumptions, and outline how you plan to achieve it. If anything is genuinely unclear or you need a decision from the user, ask them now. Otherwise, state your plan and begin working toward the goal."
            );
            let mut resume_msg = bamboo_domain::Message::user(instruction);
            resume_msg.metadata = Some(serde_json::json!({
                "hidden_from_ui": true,
                "runtime_kind": "gold_goal_resume"
            }));
            session.add_message(resume_msg);
            crate::handlers::agent::events::mark_pending_turn(&mut session);
        }

        state.save_and_cache_session(&mut session).await;
    }

    // Parse back the persisted config for the response.
    let response_config = parse_session_gold_config(new_json.as_deref());

    HttpResponse::Ok().json(ChatResponse {
        session_id: session_id.to_string(),
        stream_url: format!("/api/v1/events/{}", session_id),
        status: "accepted".to_string(),
        goal_command: Some(GoalCommandResponse {
            action: match cmd {
                GoalCommand::Off => "off".to_string(),
                GoalCommand::Clear => "clear".to_string(),
                GoalCommand::On => "on".to_string(),
                GoalCommand::SetPrompt(_) => "set_prompt".to_string(),
                GoalCommand::Status => unreachable!(),
            },
            should_execute: should_resume,
            gold_config: response_config,
        }),
    })
}

// Note: image attachments are stored on disk in SessionStoreV2, and message parts
// use `bamboo-attachment://<session_id>/<attachment_id>` references.