bamboo-engine 2026.7.25

Execution engine and orchestration for the Bamboo agent framework
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
use async_trait::async_trait;

use super::prompt_envelope::StablePromptFrame;
use super::prompt_setup::build_stable_prompt_frame_with_sections;
use super::tool_schemas::resolve_available_tool_schemas_for_session;
use bamboo_agent_core::agent::types::{TaskItem, TaskItemStatus, TaskList};
use bamboo_agent_core::tools::{
    FunctionSchema, ToolCall, ToolExecutionContext, ToolExecutor, ToolResult, ToolSchema,
};
use bamboo_agent_core::{Message, Session};
use bamboo_domain::RuntimeSessionPersistence;
use bamboo_skills::runtime_metadata::{
    SKILL_RUNTIME_ACTIVATION_GENERATION_KEY, SKILL_RUNTIME_SELECTED_SKILL_IDS_KEY,
    SKILL_RUNTIME_SELECTED_SKILL_REVISIONS_KEY,
};
use bamboo_skills::{SkillManager, SkillStoreConfig};
use chrono::Utc;
use std::sync::{Arc, Mutex};

const COPILOT_CONCLUSION_WITH_OPTIONS_ENHANCEMENT_METADATA_KEY: &str =
    "copilot_conclusion_with_options_enhancement_enabled";
const ASK_USER_ENHANCED_DESCRIPTION_FRAGMENT: &str =
    "If you are wrapping up a task turn, asking the user to choose next steps, or handing off execution, you must call this tool instead of ending with plain assistant text.";

struct StaticToolExecutor {
    schemas: Vec<ToolSchema>,
}

#[derive(Default)]
struct RecordingToolExecutor {
    calls: Mutex<Vec<ToolCall>>,
    schemas: Vec<ToolSchema>,
}

#[derive(Default)]
struct RecordingPersistence {
    sessions: Mutex<Vec<Session>>,
}

#[async_trait]
impl RuntimeSessionPersistence for RecordingPersistence {
    async fn save_runtime_session(&self, session: &mut Session) -> std::io::Result<()> {
        self.sessions
            .lock()
            .expect("recording lock")
            .push(session.clone());
        Ok(())
    }
}

#[async_trait]
impl ToolExecutor for StaticToolExecutor {
    async fn execute(
        &self,
        _call: &ToolCall,
    ) -> bamboo_agent_core::tools::executor::Result<ToolResult> {
        Ok(ToolResult {
            success: true,
            result: "ok".to_string(),
            display_preference: None,
            images: Vec::new(),
        })
    }

    fn list_tools(&self) -> Vec<ToolSchema> {
        self.schemas.clone()
    }
}

#[async_trait]
impl ToolExecutor for RecordingToolExecutor {
    async fn execute(
        &self,
        call: &ToolCall,
    ) -> bamboo_agent_core::tools::executor::Result<ToolResult> {
        self.calls
            .lock()
            .expect("recording tool lock")
            .push(call.clone());
        Ok(ToolResult {
            success: true,
            result: serde_json::json!({
                "skill_id": "review",
                "instructions": "REPORT_ONLY_ACTIONABLE_FINDINGS"
            })
            .to_string(),
            display_preference: Some("Collapsible".to_string()),
            images: Vec::new(),
        })
    }

    async fn execute_with_context(
        &self,
        call: &ToolCall,
        ctx: ToolExecutionContext<'_>,
    ) -> bamboo_agent_core::tools::executor::Result<ToolResult> {
        let result = self.execute(call).await?;
        ctx.emit(bamboo_agent_core::AgentEvent::WorkflowActivated {
            event_id: "test-explicit-review-activation".to_string(),
            session_id: "explicit-review".to_string(),
            workflow_id: "review".to_string(),
            revision: 1,
            invoked_by: "user".to_string(),
        })
        .await;
        Ok(result)
    }

    fn list_tools(&self) -> Vec<ToolSchema> {
        self.schemas.clone()
    }
}

fn schema(name: &str) -> ToolSchema {
    ToolSchema {
        schema_type: "function".to_string(),
        function: FunctionSchema {
            name: name.to_string(),
            description: format!("{name} tool"),
            parameters: serde_json::json!({ "type": "object", "properties": {} }),
        },
    }
}

fn mark_test_activation_current(session: &mut Session, skill_id: &str) {
    session.metadata.insert(
        bamboo_skills::runtime_metadata::LOADED_SKILL_IDS_METADATA_KEY.to_string(),
        serde_json::json!([skill_id]).to_string(),
    );
    session.metadata.insert(
        bamboo_skills::ACTIVE_WORKFLOW_METADATA_KEY.to_string(),
        serde_json::json!({
            "id": skill_id,
            "source": "builtin",
            "revision": 1,
            "kind": "instruction",
            "args": {},
            "invoked_by": "user",
            "activated_at": "2026-07-21T00:00:00Z",
            "status": "active"
        })
        .to_string(),
    );
    session.metadata.insert(
        bamboo_skills::ACTIVE_WORKFLOW_SNAPSHOT_METADATA_KEY.to_string(),
        "{}".to_string(),
    );
}

fn record_test_activation_from_pinned_snapshot(session: &mut Session, skill_id: &str) {
    session.metadata.insert(
        bamboo_skills::runtime_metadata::LOADED_SKILL_IDS_METADATA_KEY.to_string(),
        serde_json::json!([skill_id]).to_string(),
    );
    bamboo_skills::record_loaded_workflow_activation(
        &mut session.metadata,
        skill_id,
        "test-context-fingerprint".to_string(),
    )
    .expect("record pinned test activation");
    session
        .metadata
        .remove(bamboo_skills::WORKFLOW_ACTIVATION_EVENT_METADATA_KEY);
}

#[tokio::test]
async fn pending_workflow_deactivation_is_published_and_acked_exactly_once() {
    let persistence = Arc::new(RecordingPersistence::default());
    let config = crate::runtime::config::AgentLoopConfig {
        persistence: Some(persistence.clone()),
        ..Default::default()
    };
    let mut session = Session::new("deactivation-event", "model");
    session.metadata.insert(
        bamboo_skills::WORKFLOW_ACTIVATION_EVENT_METADATA_KEY.to_string(),
        serde_json::json!({
            "type": "workflow.deactivated",
            "workflow_id": "review",
            "revision": 7,
        })
        .to_string(),
    );
    let (event_tx, mut event_rx) = tokio::sync::mpsc::channel(8);
    super::publish_pending_workflow_lifecycle_event(&mut session, &config, &event_tx)
        .await
        .expect("publish pending deactivation");
    super::publish_pending_workflow_lifecycle_event(&mut session, &config, &event_tx)
        .await
        .expect("acked event is a no-op");
    assert!(matches!(
        event_rx.try_recv(),
        Ok(bamboo_agent_core::AgentEvent::WorkflowDeactivated {
            ref session_id,
            ref workflow_id,
            revision: 7,
            ..
        }) if session_id == "deactivation-event" && workflow_id == "review"
    ));
    assert!(event_rx.try_recv().is_err(), "deactivation must emit once");
    assert!(!session
        .metadata
        .contains_key(bamboo_skills::WORKFLOW_ACTIVATION_EVENT_METADATA_KEY));
    assert!(persistence
        .sessions
        .lock()
        .expect("recording lock")
        .last()
        .is_some_and(|saved| !saved
            .metadata
            .contains_key(bamboo_skills::WORKFLOW_ACTIVATION_EVENT_METADATA_KEY)));
}

#[tokio::test]
async fn lifecycle_replay_after_ack_save_failure_has_one_observable_identity() {
    struct FailingPersistence;

    #[async_trait]
    impl RuntimeSessionPersistence for FailingPersistence {
        async fn save_runtime_session(&self, _session: &mut Session) -> std::io::Result<()> {
            Err(std::io::Error::other("simulated acknowledgement crash"))
        }
    }

    let pending = serde_json::json!({
        "type": "workflow.activated",
        "workflow_id": "review",
        "revision": 7,
        "invoked_by": "model",
        "activated_at": "2026-07-20T00:00:00Z",
    })
    .to_string();
    let mut durable_before_crash = Session::new("activation-replay", "model");
    durable_before_crash.metadata.insert(
        bamboo_skills::WORKFLOW_ACTIVATION_EVENT_METADATA_KEY.to_string(),
        pending,
    );

    let mut first_attempt = durable_before_crash.clone();
    let first_config = crate::runtime::config::AgentLoopConfig {
        persistence: Some(Arc::new(FailingPersistence)),
        ..Default::default()
    };
    let (first_tx, mut first_rx) = tokio::sync::mpsc::channel(2);
    super::publish_pending_workflow_lifecycle_event(&mut first_attempt, &first_config, &first_tx)
        .await
        .expect_err("send succeeds but acknowledgement save fails");
    let first = first_rx.recv().await.expect("first delivery");

    // A process restart reloads the durable pre-ack outbox and replays it.
    let persistence = Arc::new(RecordingPersistence::default());
    let restart_config = crate::runtime::config::AgentLoopConfig {
        persistence: Some(persistence),
        ..Default::default()
    };
    let (restart_tx, mut restart_rx) = tokio::sync::mpsc::channel(2);
    super::publish_pending_workflow_lifecycle_event(
        &mut durable_before_crash,
        &restart_config,
        &restart_tx,
    )
    .await
    .expect("restart replay and ack");
    let replay = restart_rx.recv().await.expect("replayed delivery");
    let (first_id, replay_id) = match (&first, &replay) {
        (
            bamboo_agent_core::AgentEvent::WorkflowActivated {
                event_id: first_id, ..
            },
            bamboo_agent_core::AgentEvent::WorkflowActivated {
                event_id: replay_id,
                ..
            },
        ) => (first_id, replay_id),
        other => panic!("unexpected lifecycle events: {other:?}"),
    };
    assert_eq!(first_id, replay_id, "replay identity must be stable");

    let mut consumer = crate::runtime::execution::AgentRunner::new();
    consumer.push_critical_event(first);
    consumer.push_critical_event(replay);
    assert_eq!(
        consumer.last_critical_events.len(),
        1,
        "idempotent consumer exposes one state transition"
    );
}

#[tokio::test]
async fn session_setup_publishes_current_skill_allowlist_before_tool_execution() {
    let directory = tempfile::tempdir().expect("tempdir");
    let manager = Arc::new(SkillManager::with_config(SkillStoreConfig {
        skills_dir: directory.path().join("skills"),
        ..Default::default()
    }));
    manager.initialize().await.expect("initialize skills");
    let persistence = Arc::new(RecordingPersistence::default());
    let config = crate::runtime::config::AgentLoopConfig {
        skill_manager: Some(manager.clone()),
        persistence: Some(persistence.clone()),
        ..Default::default()
    };
    let tools = StaticToolExecutor {
        schemas: Vec::new(),
    };
    let mut session = Session::new("selection-publish", "model");
    let (event_tx, _event_rx) = tokio::sync::mpsc::channel(8);
    session.metadata.insert(
        "skill_runtime_loaded_skill_ids".to_string(),
        "[\"review\"]".to_string(),
    );

    super::prepare_session_for_loop(
        &mut session,
        "Review the current changes",
        &config,
        &tools,
        None,
        "selection-publish",
        &crate::runtime::runner::logging::DebugLogger::new(false),
        false,
        &event_tx,
    )
    .await
    .expect("session setup");

    let current_ids = session
        .metadata
        .get(SKILL_RUNTIME_SELECTED_SKILL_IDS_KEY)
        .unwrap_or_else(|| {
            panic!(
                "current runtime selection metadata; activation_error={:?}",
                session
                    .metadata
                    .get(bamboo_skills::runtime_metadata::SKILL_RUNTIME_ACTIVATION_ERROR_KEY)
            )
        });
    assert!(current_ids.contains("review"));
    assert!(!current_ids.contains("plan"));
    let candidate_snapshot = manager
        .store()
        .export_activation_snapshot("selection-publish")
        .await
        .expect("immutable automatic candidate pin");
    assert!(
        serde_json::to_vec(&candidate_snapshot)
            .expect("serialize candidate snapshot")
            .len()
            > bamboo_skills::MAX_DURABLE_WORKFLOW_ACTIVATION_BYTES,
        "fixture must include enough unselected builtin resources to catch candidate persistence"
    );
    assert!(
        !session
            .metadata
            .contains_key(bamboo_skills::runtime_metadata::SKILL_RUNTIME_PINNED_SNAPSHOT_KEY),
        "automatic catalog publication must remain metadata-only"
    );
    let published_catalog = session
        .metadata
        .get(bamboo_skills::runtime_metadata::SKILL_RUNTIME_SELECTED_CATALOG_KEY)
        .expect("metadata-only catalog publication");
    assert!(published_catalog.contains("review"));
    assert!(!published_catalog.contains("pinned instructions"));
    assert!(
        !session
            .metadata
            .contains_key("skill_runtime_loaded_skill_ids"),
        "a new automatic selection must not inherit the previous run's activation"
    );
    let saved = persistence.sessions.lock().expect("recording lock");
    let published = saved.last().expect("selection published");
    let ids = published
        .metadata
        .get(SKILL_RUNTIME_SELECTED_SKILL_IDS_KEY)
        .expect("runtime selection metadata");
    assert!(ids.contains("review"));
    assert!(!ids.contains("plan"));
}

#[tokio::test]
async fn session_setup_requires_model_issued_load_for_one_explicit_skill() {
    let directory = tempfile::tempdir().expect("tempdir");
    let manager = Arc::new(SkillManager::with_config(SkillStoreConfig {
        skills_dir: directory.path().join("skills"),
        ..Default::default()
    }));
    manager.initialize().await.expect("initialize skills");
    let persistence = Arc::new(RecordingPersistence::default());
    let config = crate::runtime::config::AgentLoopConfig {
        skill_manager: Some(manager),
        selected_skill_ids: Some(vec!["review".to_string()]),
        persistence: Some(persistence.clone()),
        ..Default::default()
    };
    let tools = RecordingToolExecutor {
        calls: Mutex::new(Vec::new()),
        schemas: vec![schema("load_skill")],
    };
    let mut session = Session::new("explicit-review", "model");
    let (event_tx, mut event_rx) = tokio::sync::mpsc::channel(8);

    super::prepare_session_for_loop(
        &mut session,
        "Review this change",
        &config,
        &tools,
        None,
        "explicit-review",
        &crate::runtime::runner::logging::DebugLogger::new(false),
        false,
        &event_tx,
    )
    .await
    .expect("session setup");

    let calls = tools.calls.lock().expect("recording tool lock");
    assert!(
        calls.is_empty(),
        "the runtime must not impersonate the model"
    );
    assert!(session.messages.iter().all(|message| {
        !message.content.contains("## Explicit Workflow Activated")
            && !message.content.contains("REPORT_ONLY_ACTIONABLE_FINDINGS")
    }));
    assert!(
        super::prompt_envelope::build_active_workflow_context_block(&session).is_none(),
        "the workflow is not active until the model-issued load_skill succeeds"
    );
    assert!(
        event_rx.try_recv().is_err(),
        "selection alone must not emit WorkflowActivated"
    );
    assert!(!session
        .metadata
        .contains_key("skill_runtime_loaded_skill_ids"));
    let system_prompt = session
        .messages
        .iter()
        .find(|message| matches!(message.role, bamboo_agent_core::Role::System))
        .expect("system prompt")
        .content
        .as_str();
    assert!(system_prompt.contains("## Required Explicit Workflow Activation"));
    assert!(system_prompt.contains("first response step MUST be exactly one `load_skill` call"));
    assert!(system_prompt.contains("review"));

    let saved = persistence.sessions.lock().expect("recording lock");
    assert!(saved.iter().all(|saved_session| !saved_session
        .metadata
        .contains_key("skill_runtime_loaded_skill_ids")));
}

#[tokio::test]
async fn permission_style_second_prepare_preserves_unchanged_explicit_activation() {
    let directory = tempfile::tempdir().expect("tempdir");
    let manager = Arc::new(SkillManager::with_config(SkillStoreConfig {
        skills_dir: directory.path().join("skills"),
        ..Default::default()
    }));
    manager.initialize().await.expect("initialize skills");
    let persistence = Arc::new(RecordingPersistence::default());
    let config = crate::runtime::config::AgentLoopConfig {
        skill_manager: Some(manager),
        selected_skill_ids: Some(vec!["review".to_string()]),
        persistence: Some(persistence),
        ..Default::default()
    };
    let tools = RecordingToolExecutor {
        calls: Mutex::new(Vec::new()),
        schemas: vec![schema("load_skill")],
    };
    let mut session = Session::new("explicit-review-resume", "model");
    let logger = crate::runtime::runner::logging::DebugLogger::new(false);
    let (event_tx, _event_rx) = tokio::sync::mpsc::channel(8);

    super::prepare_session_for_loop(
        &mut session,
        "Review this change",
        &config,
        &tools,
        None,
        "explicit-review-resume",
        &logger,
        false,
        &event_tx,
    )
    .await
    .expect("initial explicit setup");
    assert!(super::skill_context::explicit_activation_pending(&session));
    record_test_activation_from_pinned_snapshot(&mut session, "review");
    assert!(!super::skill_context::explicit_activation_pending(&session));

    // Mirrors re-entry after a permission/tool suspension: same session, same
    // explicit workflow, and a second prepare before the model continues.
    super::prepare_session_for_loop(
        &mut session,
        "Review this change",
        &config,
        &tools,
        None,
        "explicit-review-resume",
        &logger,
        true,
        &event_tx,
    )
    .await
    .expect("resume explicit setup");

    assert_eq!(
        session
            .metadata
            .get("skill_runtime_loaded_skill_ids")
            .map(String::as_str),
        Some("[\"review\"]")
    );
    assert!(!super::skill_context::explicit_activation_pending(&session));
    let system_prompt = session
        .messages
        .iter()
        .find(|message| matches!(message.role, bamboo_agent_core::Role::System))
        .expect("system prompt")
        .content
        .as_str();
    assert!(!system_prompt.contains("## Required Explicit Workflow Activation"));
    assert!(system_prompt.contains("## Explicit Workflow Already Activated"));
    assert!(
        system_prompt.contains("Do not call `load_skill` again solely because execution resumed")
    );
    assert!(tools.calls.lock().expect("recording tool lock").is_empty());
}

#[test]
fn activation_reset_preserves_same_explicit_and_clears_superseded_selection() {
    let explicit_review = super::skill_context::SkillContextLoadResult {
        selected_skill_ids: vec!["review".to_string()],
        selection_source: Some("explicit".to_string()),
        ..Default::default()
    };
    let mut session = Session::new("activation-reset", "model");
    mark_test_activation_current(&mut session, "review");

    super::skill_context::reset_activation_state_for_new_selection(&mut session, &explicit_review);
    assert_eq!(
        session
            .metadata
            .get("skill_runtime_loaded_skill_ids")
            .map(String::as_str),
        Some("[\"review\"]")
    );

    let explicit_plan = super::skill_context::SkillContextLoadResult {
        selected_skill_ids: vec!["plan".to_string()],
        selection_source: Some("explicit".to_string()),
        ..Default::default()
    };
    super::skill_context::reset_activation_state_for_new_selection(&mut session, &explicit_plan);
    assert!(!session
        .metadata
        .contains_key("skill_runtime_loaded_skill_ids"));

    mark_test_activation_current(&mut session, "review");
    let automatic_review = super::skill_context::SkillContextLoadResult {
        selected_skill_ids: vec!["review".to_string()],
        selection_source: Some("auto".to_string()),
        ..Default::default()
    };
    super::skill_context::reset_activation_state_for_new_selection(&mut session, &automatic_review);
    assert!(!session
        .metadata
        .contains_key("skill_runtime_loaded_skill_ids"));
}

#[tokio::test]
async fn pin_failure_clears_stale_runtime_selection_and_revision_metadata() {
    let directory = tempfile::tempdir().expect("tempdir");
    let manager = Arc::new(SkillManager::with_config(SkillStoreConfig {
        skills_dir: directory.path().join("skills"),
        ..Default::default()
    }));
    manager.initialize().await.expect("initialize skills");
    let review = vec!["review".to_string()];
    for index in 0..256 {
        manager
            .store()
            .pin_current_activation(&format!("capacity-{index}"), &review, None)
            .await
            .expect("fill active snapshot capacity");
    }
    let persistence = Arc::new(RecordingPersistence::default());
    let config = crate::runtime::config::AgentLoopConfig {
        skill_manager: Some(manager),
        selected_skill_ids: Some(review),
        persistence: Some(persistence.clone()),
        ..Default::default()
    };
    let tools = StaticToolExecutor {
        schemas: Vec::new(),
    };
    let mut session = Session::new("over-capacity", "model");
    let (event_tx, _event_rx) = tokio::sync::mpsc::channel(8);
    session.metadata.insert(
        SKILL_RUNTIME_SELECTED_SKILL_IDS_KEY.to_string(),
        r#"["plan"]"#.to_string(),
    );
    session.metadata.insert(
        SKILL_RUNTIME_ACTIVATION_GENERATION_KEY.to_string(),
        "999".to_string(),
    );
    session.metadata.insert(
        SKILL_RUNTIME_SELECTED_SKILL_REVISIONS_KEY.to_string(),
        r#"{"plan":999}"#.to_string(),
    );

    super::prepare_session_for_loop(
        &mut session,
        "review",
        &config,
        &tools,
        None,
        "over-capacity",
        &crate::runtime::runner::logging::DebugLogger::new(false),
        false,
        &event_tx,
    )
    .await
    .expect_err("capacity failure must reject the run before model execution");

    assert!(session
        .metadata
        .get(bamboo_skills::runtime_metadata::SKILL_RUNTIME_ACTIVATION_ERROR_KEY)
        .is_some_and(|message| message.contains("capacity")));
    let saved = persistence.sessions.lock().expect("recording lock");
    assert!(saved.iter().any(|published| {
        published
            .metadata
            .get(bamboo_skills::runtime_metadata::SKILL_RUNTIME_ACTIVATION_ERROR_KEY)
            .is_some_and(|message| message.contains("capacity"))
    }));
}

#[test]
fn resolve_available_tool_schemas_uses_executor_when_registry_empty() {
    let config = crate::runtime::config::AgentLoopConfig::default();
    let tools = StaticToolExecutor {
        schemas: vec![schema("z_tool"), schema("a_tool")],
    };
    let session = Session::new("session-1", "model");

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let names: Vec<&str> = resolved
        .iter()
        .map(|item| item.function.name.as_str())
        .collect();

    assert_eq!(names, vec!["a_tool", "z_tool"]);
}

#[test]
fn resolve_available_tool_schemas_dedupes_and_merges_additional_entries() {
    let config = crate::runtime::config::AgentLoopConfig {
        additional_tool_schemas: vec![schema("b_tool"), schema("a_tool")],
        ..Default::default()
    };
    let tools = StaticToolExecutor {
        schemas: vec![schema("a_tool"), schema("z_tool")],
    };
    let session = Session::new("session-1", "model");

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let names: Vec<&str> = resolved
        .iter()
        .map(|item| item.function.name.as_str())
        .collect();

    assert_eq!(names, vec!["a_tool", "b_tool", "z_tool"]);
}

#[test]
fn resolve_available_tool_schemas_excludes_disabled_tools() {
    let config = crate::runtime::config::AgentLoopConfig {
        additional_tool_schemas: vec![schema("b_tool")],
        disabled_tools: ["a_tool".to_string(), "b_tool".to_string()]
            .into_iter()
            .collect(),
        ..Default::default()
    };
    let tools = StaticToolExecutor {
        schemas: vec![schema("a_tool"), schema("z_tool")],
    };
    let session = Session::new("session-1", "model");

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let names: Vec<&str> = resolved
        .iter()
        .map(|item| item.function.name.as_str())
        .collect();

    assert_eq!(names, vec!["z_tool"]);
}

#[test]
fn resolve_available_tool_schemas_hides_load_skill_after_activation() {
    let config = crate::runtime::config::AgentLoopConfig::default();
    let tools = StaticToolExecutor {
        schemas: vec![schema("load_skill"), schema("read_skill_resource")],
    };
    let mut session = Session::new("session-loaded-skill", "model");
    session.metadata.insert(
        "skill_runtime_loaded_skill_ids".to_string(),
        "[\"review\"]".to_string(),
    );
    session.metadata.insert(
        "skill_runtime_selected_skill_ids".to_string(),
        "[\"review\"]".to_string(),
    );
    session.metadata.insert(
        "skill_runtime_selection_source".to_string(),
        "explicit".to_string(),
    );

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let names = resolved
        .iter()
        .map(|schema| schema.function.name.as_str())
        .collect::<Vec<_>>();

    assert!(!names.contains(&"load_skill"));
    assert!(names.contains(&"read_skill_resource"));
}

#[test]
fn resolve_available_tool_schemas_keeps_load_skill_for_new_automatic_selection() {
    let config = crate::runtime::config::AgentLoopConfig::default();
    let tools = StaticToolExecutor {
        schemas: vec![schema("load_skill"), schema("read_skill_resource")],
    };
    let mut session = Session::new("session-auto-after-loaded-skill", "model");
    session.metadata.insert(
        "skill_runtime_loaded_skill_ids".to_string(),
        "[\"review\"]".to_string(),
    );
    session.metadata.insert(
        "skill_runtime_selected_skill_ids".to_string(),
        "[\"debug\",\"review\"]".to_string(),
    );
    session.metadata.insert(
        "skill_runtime_selection_source".to_string(),
        "auto".to_string(),
    );

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let names = resolved
        .iter()
        .map(|schema| schema.function.name.as_str())
        .collect::<Vec<_>>();

    assert!(names.contains(&"load_skill"));
    assert!(names.contains(&"read_skill_resource"));
}

#[test]
fn explicit_activation_state_becomes_current_only_after_successful_model_load() {
    let mut session = Session::new("explicit-activation-state", "model");
    session.metadata.insert(
        "skill_runtime_selection_source".to_string(),
        "explicit".to_string(),
    );
    session.metadata.insert(
        "skill_runtime_selected_skill_ids".to_string(),
        "[\"review\"]".to_string(),
    );
    assert!(super::skill_context::explicit_activation_pending(&session));

    mark_test_activation_current(&mut session, "review");

    assert!(!super::skill_context::explicit_activation_pending(&session));
    assert_eq!(
        session
            .metadata
            .get("skill_runtime_loaded_skill_ids")
            .map(String::as_str),
        Some("[\"review\"]")
    );
}

#[test]
fn resolve_available_tool_schemas_excludes_canonicalized_disabled_tool_aliases() {
    let config = crate::runtime::config::AgentLoopConfig {
        disabled_tools: ["Bash".to_string(), "Read".to_string()]
            .into_iter()
            .collect(),
        ..Default::default()
    };
    let tools = StaticToolExecutor {
        schemas: vec![schema("Bash"), schema("Read"), schema("Write")],
    };
    let session = Session::new("session-1", "model");

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let names: Vec<&str> = resolved
        .iter()
        .map(|item| item.function.name.as_str())
        .collect();

    assert_eq!(names, vec!["Write"]);
}

#[test]
fn resolve_available_tool_schemas_hides_discoverable_tools_by_default() {
    let config = crate::runtime::config::AgentLoopConfig::default();
    let tools = StaticToolExecutor {
        schemas: vec![schema("Read"), schema("Sleep"), schema("scheduler")],
    };
    let session = Session::new("session-1", "model");

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let names: Vec<&str> = resolved
        .iter()
        .map(|item| item.function.name.as_str())
        .collect();

    assert_eq!(names, vec!["Read", "Sleep", "scheduler"]);

    // Inactive discoverable tools get shortened descriptions
    let sleep = resolved
        .iter()
        .find(|s| s.function.name == "Sleep")
        .unwrap();
    assert!(sleep.function.description.contains("Discoverable"));
    let scheduler = resolved
        .iter()
        .find(|s| s.function.name == "scheduler")
        .unwrap();
    assert!(scheduler.function.description.contains("Discoverable"));
}

#[test]
fn resolve_available_tool_schemas_includes_activated_discoverable_tools() {
    let config = crate::runtime::config::AgentLoopConfig::default();
    let tools = StaticToolExecutor {
        schemas: vec![schema("Read"), schema("Sleep"), schema("scheduler")],
    };
    let mut session = Session::new("session-1", "model");
    bamboo_tools::exposure::activate_discoverable_tools(&mut session, ["Sleep", "scheduler"]);

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let names: Vec<&str> = resolved
        .iter()
        .map(|item| item.function.name.as_str())
        .collect();

    assert_eq!(names, vec!["Read", "Sleep", "scheduler"]);

    // Activated discoverable tools keep full descriptions
    let sleep = resolved
        .iter()
        .find(|s| s.function.name == "Sleep")
        .unwrap();
    assert!(!sleep.function.description.contains("Discoverable"));
}

#[test]
fn resolve_available_tool_schemas_does_not_mutate_session_metadata() {
    let config = crate::runtime::config::AgentLoopConfig::default();
    let tools = StaticToolExecutor {
        schemas: vec![schema("Write"), schema("session_history")],
    };
    let mut session = Session::new("session-1", "gpt-4o-mini");
    session.add_message(Message::system("sys"));
    session
        .metadata
        .insert("existing".to_string(), "value".to_string());

    let resolved =
        super::tool_schemas::resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let names: Vec<&str> = resolved
        .iter()
        .map(|item| item.function.name.as_str())
        .collect();

    // All tools are available; inactive discoverable ones get shortened descriptions
    assert_eq!(names, vec!["Write", "session_history"]);
    let session_history = resolved
        .iter()
        .find(|s| s.function.name == "session_history")
        .unwrap();
    assert!(session_history
        .function
        .description
        .contains("Discoverable"));
    assert_eq!(
        session.metadata.get("existing").map(String::as_str),
        Some("value")
    );
    assert_eq!(session.metadata.len(), 1);
}

#[test]
fn resolve_available_tool_schemas_keeps_conclusion_with_options_description_neutral_when_flag_disabled(
) {
    let config = crate::runtime::config::AgentLoopConfig::default();
    let tools = StaticToolExecutor {
        schemas: vec![schema("conclusion_with_options")],
    };
    let session = Session::new("session-1", "model");

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let conclusion_with_options_schema = resolved
        .iter()
        .find(|schema| schema.function.name == "conclusion_with_options")
        .expect("conclusion_with_options schema should exist");

    assert_eq!(
        conclusion_with_options_schema.function.description,
        "conclusion_with_options tool"
    );
    assert!(!conclusion_with_options_schema
        .function
        .description
        .contains(ASK_USER_ENHANCED_DESCRIPTION_FRAGMENT));
}

#[test]
fn resolve_available_tool_schemas_strengthens_conclusion_with_options_description_when_flag_enabled(
) {
    let config = crate::runtime::config::AgentLoopConfig::default();
    let tools = StaticToolExecutor {
        schemas: vec![schema("conclusion_with_options")],
    };
    let mut session = Session::new("session-1", "model");
    session.metadata.insert(
        COPILOT_CONCLUSION_WITH_OPTIONS_ENHANCEMENT_METADATA_KEY.to_string(),
        "true".to_string(),
    );

    let resolved = resolve_available_tool_schemas_for_session(&config, &tools, &session);
    let conclusion_with_options_schema = resolved
        .iter()
        .find(|schema| schema.function.name == "conclusion_with_options")
        .expect("conclusion_with_options schema should exist");

    assert!(conclusion_with_options_schema
        .function
        .description
        .contains(ASK_USER_ENHANCED_DESCRIPTION_FRAGMENT));
    assert!(conclusion_with_options_schema
        .function
        .description
        .contains("conclusion"));
    assert!(conclusion_with_options_schema
        .function
        .description
        .contains("OK"));
}

#[test]
fn apply_system_prompt_contexts_persists_shared_prompt_snapshot() {
    let _lock = crate::runtime::tests::env_cache_lock_acquire();
    let config = bamboo_llm::Config::default();
    config.publish_env_vars();

    let loop_config = crate::runtime::config::AgentLoopConfig {
        system_prompt: Some("Base prompt".to_string()),
        ..Default::default()
    };
    let mut session = Session::new("snapshot-session", "gpt-test");
    session
        .metadata
        .insert("base_system_prompt".to_string(), "Base prompt".to_string());
    session.metadata.insert(
        "workspace_path".to_string(),
        "/tmp/snapshot-workspace".to_string(),
    );
    session.add_message(Message::system("Base prompt"));

    let _report = super::prompt_setup::apply_system_prompt_contexts(
        &mut session,
        &loop_config,
        "## Skill System\nSkill details",
        "## Tool Usage Guidelines\nTool details",
    );

    let snapshot = super::prompt_setup::read_prompt_snapshot_metadata(&session)
        .expect("runtime prompt snapshot should exist");
    assert_eq!(snapshot.base_system_prompt, "Base prompt");
    assert!(snapshot
        .skill_context
        .as_deref()
        .unwrap_or_default()
        .contains("Skill details"));
    assert!(snapshot
        .tool_guide_context
        .as_deref()
        .unwrap_or_default()
        .contains("Tool details"));
    assert!(snapshot.effective_system_prompt.contains("Base prompt"));
    assert!(snapshot.prompt_memory_observability.is_none());
}

#[test]
fn refresh_prompt_snapshot_from_session_preserves_multi_topic_memory_split_fields() {
    let mut session = Session::new("snapshot-memory-topics", "gpt-test");
    session
        .metadata
        .insert("base_system_prompt".to_string(), "Base prompt".to_string());
    session.add_message(Message::system(
        "Base prompt\n\n<!-- BAMBOO_EXTERNAL_MEMORY_START -->\n## External Memory (Persistent)\n\n### Cross-session Dream Notebook (read-only)\n````md\nDream note content\n````\n\n### Session Memory Topic: `backend-api`\n````md\n/users and /orders finalized\n````\n\n### Session Memory Topic: `ui-copy`\n````md\nCTA wording approved\n````\n<!-- BAMBOO_EXTERNAL_MEMORY_END -->"
    ));

    super::prompt_setup::refresh_prompt_snapshot_from_session(&mut session);

    let snapshot = super::prompt_setup::read_prompt_snapshot_metadata(&session)
        .expect("runtime prompt snapshot should exist");
    assert_eq!(
        snapshot.dream_notebook.as_deref(),
        Some("Dream note content")
    );
    let merged = snapshot
        .session_memory_note
        .as_deref()
        .expect("session memory note should be merged from topic blocks");
    assert!(merged.contains("### Session Memory Topic: `backend-api`"));
    assert!(merged.contains("/users and /orders finalized"));
    assert!(merged.contains("### Session Memory Topic: `ui-copy`"));
    assert!(merged.contains("CTA wording approved"));
}

#[test]
fn refresh_prompt_snapshot_from_session_supports_global_dream_fallback_heading() {
    let mut session = Session::new("snapshot-memory-fallback-dream", "gpt-test");
    session
        .metadata
        .insert("base_system_prompt".to_string(), "Base prompt".to_string());
    session.add_message(Message::system(
        "Base prompt\n\n<!-- BAMBOO_EXTERNAL_MEMORY_START -->\n## External Memory (Persistent)\n\n### Global Dream Summary (fallback)\n````md\nDream fallback content\n````\n\n### Session Memory Note (markdown)\n````md\nSession note content\n````\n<!-- BAMBOO_EXTERNAL_MEMORY_END -->"
    ));

    super::prompt_setup::refresh_prompt_snapshot_from_session(&mut session);

    let snapshot = super::prompt_setup::read_prompt_snapshot_metadata(&session)
        .expect("runtime prompt snapshot should exist");
    assert_eq!(
        snapshot.dream_notebook.as_deref(),
        Some("Dream fallback content")
    );
    assert_eq!(
        snapshot.session_memory_note.as_deref(),
        Some("Session note content")
    );
}

#[test]
fn refresh_prompt_snapshot_from_session_extracts_fine_grained_external_memory_fields() {
    let mut session = Session::new("snapshot-memory-fine-grained", "gpt-test");
    session
        .metadata
        .insert("base_system_prompt".to_string(), "Base prompt".to_string());
    session.add_message(Message::system(
        "Base prompt\n\n<!-- BAMBOO_EXTERNAL_MEMORY_START -->\n## External Memory (Persistent)\n\n### Relevant Durable Memories\nTurn-specific historical memories shortlisted for the latest user request.\n- [active][project] Release rule\n  Summary: Use the release checklist.\n\n### Project Durable Memory Index\n````md\n# Bamboo Memory Index\n- memory entry\n````\n\n### Global Dream Summary (fallback)\n````md\nDream fallback content\n````\n\n### Session Memory Note (markdown)\n````md\nSession note content\n````\n<!-- BAMBOO_EXTERNAL_MEMORY_END -->"
    ));

    super::prompt_setup::refresh_prompt_snapshot_from_session(&mut session);

    let snapshot = super::prompt_setup::read_prompt_snapshot_metadata(&session)
        .expect("runtime prompt snapshot should exist");
    assert!(snapshot
        .relevant_durable_memories
        .as_deref()
        .is_some_and(|value| value.contains("Release rule")));
    assert_eq!(
        snapshot.project_memory_index.as_deref(),
        Some("# Bamboo Memory Index\n- memory entry")
    );
    assert_eq!(
        snapshot.global_dream_fallback.as_deref(),
        Some("Dream fallback content")
    );
    assert_eq!(
        snapshot.dream_notebook.as_deref(),
        Some("Dream fallback content")
    );
    assert_eq!(
        snapshot.session_memory_note.as_deref(),
        Some("Session note content")
    );
}

#[test]
fn refresh_prompt_snapshot_from_session_restores_prompt_memory_observability_from_metadata() {
    let mut session = Session::new("snapshot-memory-observability", "gpt-test");
    session
        .metadata
        .insert("base_system_prompt".to_string(), "Base prompt".to_string());
    session.metadata.insert(
        "runtime_prompt_memory_observability".to_string(),
        serde_json::to_string(&bamboo_agent_core::PromptMemoryObservability {
            project_prompt_injection_enabled: true,
            relevant_recall_enabled: false,
            relevant_recall_rerank_enabled: false,
            project_first_dream_enabled: false,
            latest_user_query_present: true,
            resolved_project_key: Some("project-key".to_string()),
            session_notes_status: "loaded".to_string(),
            project_memory_index_status: "loaded".to_string(),
            relevant_memory_status: "disabled".to_string(),
            project_dream_status: "disabled".to_string(),
            global_dream_fallback_status: "forced_loaded".to_string(),
            dream_source: "global_fallback".to_string(),
            session_topic_count: 1,
            truncated_session_topic_count: 0,
            relevant_memory_count: 0,
            session_note_section_chars: 10,
            project_memory_index_section_chars: 20,
            relevant_memory_section_chars: 0,
            project_dream_section_chars: 0,
            global_dream_fallback_section_chars: 40,
            context_pressure_warning_chars: 0,
            external_memory_section_chars: 120,
        })
        .expect("observability should serialize"),
    );
    session.add_message(Message::system(
        "Base prompt\n\n<!-- BAMBOO_EXTERNAL_MEMORY_START -->\n## External Memory (Persistent)\n\n### Global Dream Summary (fallback)\n````md\nDream fallback content\n````\n\n### Session Memory Note (markdown)\n````md\nSession note content\n````\n<!-- BAMBOO_EXTERNAL_MEMORY_END -->"
    ));

    super::prompt_setup::refresh_prompt_snapshot_from_session(&mut session);

    let snapshot = super::prompt_setup::read_prompt_snapshot_metadata(&session)
        .expect("runtime prompt snapshot should exist");
    let observability = snapshot
        .prompt_memory_observability
        .expect("observability should be restored");
    assert!(!observability.relevant_recall_enabled);
    assert_eq!(observability.global_dream_fallback_status, "forced_loaded");
    assert_eq!(observability.dream_source, "global_fallback");
}

#[test]
fn refresh_prompt_snapshot_from_session_ignores_topic_truncation_note_outside_code_block() {
    let mut session = Session::new("snapshot-memory-topic-note", "gpt-test");
    session
        .metadata
        .insert("base_system_prompt".to_string(), "Base prompt".to_string());
    session.add_message(Message::system(
        "Base prompt\n\n<!-- BAMBOO_EXTERNAL_MEMORY_START -->\n## External Memory (Persistent)\n\n### Session Memory Topic: `backend-api`\n````md\n/users and /orders finalized\n````\n_(showing 12 of 120 chars — use action=read topic=backend-api to see full content)_\n\n### Session Memory Topic: `ui-copy`\n````md\nCTA wording approved\n````\n<!-- BAMBOO_EXTERNAL_MEMORY_END -->"
    ));

    super::prompt_setup::refresh_prompt_snapshot_from_session(&mut session);

    let snapshot = super::prompt_setup::read_prompt_snapshot_metadata(&session)
        .expect("runtime prompt snapshot should exist");
    let merged = snapshot
        .session_memory_note
        .as_deref()
        .expect("session memory note should be merged from topic blocks");
    assert!(merged.contains("### Session Memory Topic: `backend-api`"));
    assert!(merged.contains("/users and /orders finalized"));
    assert!(!merged.contains("showing 12 of 120 chars"));
    assert!(merged.contains("### Session Memory Topic: `ui-copy`"));
    assert!(merged.contains("CTA wording approved"));
}

#[test]
fn apply_system_prompt_contexts_persists_runtime_prompt_metadata() {
    let _lock = crate::runtime::tests::env_cache_lock_acquire();
    let mut config_with_env = bamboo_llm::Config::default();
    config_with_env.env_vars = vec![bamboo_config::EnvVarEntry {
        name: "TEST_TOOL_TOKEN".to_string(),
        value: "hidden-value".to_string(),
        secret: true,
        value_encrypted: None,
        credential_ref: None,
        configured: true,
        description: Some("Runtime test token".to_string()),
    }];
    config_with_env.publish_env_vars();

    let root = tempfile::tempdir().expect("temp dir");
    let workspace = root.path().join("project");
    std::fs::create_dir_all(root.path().join(".git")).expect("git marker");
    std::fs::create_dir_all(&workspace).expect("workspace dir");
    std::fs::write(root.path().join("AGENTS.md"), "Workspace policy").expect("agents file");

    let mut session = Session::new("session-1", "model");
    let env_context = crate::runtime::context::build_env_prompt_context().unwrap_or_default();
    session.add_message(Message::system(format!(
        "Base prompt\n\n{}\nWorkspace path: {}\n{}\n{}\n\n{}",
        crate::runtime::context::WORKSPACE_CONTEXT_START_MARKER,
        workspace.display(),
        crate::runtime::context::WORKSPACE_CONTEXT_END_MARKER,
        crate::runtime::context::workspace_prompt_guidance(),
        env_context,
    )));
    let config = crate::runtime::config::AgentLoopConfig::default();
    let skill_context = "## Skill System\nSkill details";
    let tool_guide_context = "## Tool Usage Guidelines\nGuide details";

    let report = super::prompt_setup::apply_system_prompt_contexts(
        &mut session,
        &config,
        skill_context,
        tool_guide_context,
    );

    assert_eq!(report.version, "bamboo.runtime-system-prompt.v3");
    assert_eq!(report.sections.len(), 6);
    assert_eq!(
        session
            .metadata
            .get("runtime_prompt_composer_version")
            .map(String::as_str),
        Some("bamboo.runtime-system-prompt.v3")
    );
    assert!(session
        .metadata
        .contains_key("runtime_prompt_component_flags"));
    assert!(session
        .metadata
        .contains_key("runtime_prompt_component_lengths"));
    assert!(session
        .metadata
        .contains_key("runtime_prompt_section_layout"));

    let base_prompt = report
        .section("base_prompt")
        .expect("base prompt section should exist");
    let workspace_context = report
        .section("workspace_context")
        .expect("workspace section should exist");
    let instruction_context = report
        .section("instruction_context")
        .expect("instruction section should exist");
    let env_context = report
        .section("env_context")
        .expect("env section should exist");
    assert!(workspace_context
        .content
        .contains(&format!("Workspace path: {}", workspace.display())));
    assert!(instruction_context.content.contains("Workspace policy"));
    assert!(env_context
        .content
        .contains("environment variables were explicitly configured by the user inside Bodhi"));
    let expected_layout = format!(
        "base_prompt:core_static:static:1:{};workspace_context:environment_workspace:dynamic:1:{};instruction_context:environment_instruction:dynamic:1:{};env_context:environment_configuration:dynamic:1:{};skill_context:skill_metadata:dynamic:1:{};tool_guide_context:capability_tool:dynamic:1:{}",
        base_prompt.len(),
        workspace_context.len(),
        instruction_context.len(),
        env_context.len(),
        skill_context.len(),
        tool_guide_context.len(),
    );
    assert_eq!(
        session
            .metadata
            .get("runtime_prompt_section_layout")
            .map(String::as_str),
        Some(expected_layout.as_str())
    );
}

#[test]
fn prompt_assembly_report_component_values_match_sections() {
    use super::prompt_setup::{PromptAssemblyReport, PromptLayer, PromptSection};

    let _lock = crate::runtime::tests::env_cache_lock_acquire();
    let mut config_with_env = bamboo_llm::Config::default();
    config_with_env.env_vars = vec![bamboo_config::EnvVarEntry {
        name: "TEST_TOOL_TOKEN".to_string(),
        value: "hidden-value".to_string(),
        secret: true,
        value_encrypted: None,
        credential_ref: None,
        configured: true,
        description: Some("Runtime test token".to_string()),
    }];
    config_with_env.publish_env_vars();

    let base_prompt = "Base prompt";
    let workspace_context = format!(
        "{}\nWorkspace path: /tmp/workspace\n{}\n{}",
        crate::runtime::context::WORKSPACE_CONTEXT_START_MARKER,
        crate::runtime::context::WORKSPACE_CONTEXT_END_MARKER,
        crate::runtime::context::workspace_prompt_guidance(),
    );
    let instruction_context = format!(
        "{}\n## AGENTS.md\nSource: /tmp/AGENTS.md\n\nWorkspace policy\n{}",
        crate::runtime::context::instruction::INSTRUCTION_CONTEXT_START_MARKER,
        crate::runtime::context::instruction::INSTRUCTION_CONTEXT_END_MARKER,
    );
    let env_context = crate::runtime::context::build_env_prompt_context().unwrap_or_default();
    let skill_context = "## Skill System\nSkill details";
    let tool_guide_context = "## Tool Usage Guidelines\nGuide details";
    let sections = vec![
        PromptSection::new("base_prompt", PromptLayer::CoreStatic, false, base_prompt),
        PromptSection::new(
            "workspace_context",
            PromptLayer::EnvironmentWorkspace,
            true,
            workspace_context.as_str(),
        ),
        PromptSection::new(
            "instruction_context",
            PromptLayer::EnvironmentInstruction,
            true,
            instruction_context.as_str(),
        ),
        PromptSection::new(
            "env_context",
            PromptLayer::EnvironmentConfiguration,
            true,
            env_context.as_str(),
        ),
        PromptSection::new(
            "skill_context",
            PromptLayer::SkillMetadata,
            true,
            skill_context,
        ),
        PromptSection::new(
            "tool_guide_context",
            PromptLayer::CapabilityTool,
            true,
            tool_guide_context,
        ),
    ];
    let final_prompt = format!(
        "{}\n\n{}\n\n{}\n\n{}\n\n<!-- BAMBOO_SKILL_CONTEXT_START -->\n{}\n<!-- BAMBOO_SKILL_CONTEXT_END -->\n\n<!-- BAMBOO_TOOL_GUIDE_START -->\n{}\n<!-- BAMBOO_TOOL_GUIDE_END -->",
        base_prompt, workspace_context, instruction_context, env_context, skill_context, tool_guide_context
    );

    let report = PromptAssemblyReport::from_sections(sections, &final_prompt);

    let expected_lengths = format!(
        "base={};workspace={};instruction={};env={};skill={};tool_guide={};external_memory={};task_list={};final={}",
        base_prompt.len(),
        workspace_context.len(),
        instruction_context.len(),
        env_context.len(),
        skill_context.len(),
        tool_guide_context.len(),
        0,
        0,
        final_prompt.len(),
    );
    let expected_layout = format!(
        "base_prompt:core_static:static:1:{};workspace_context:environment_workspace:dynamic:1:{};instruction_context:environment_instruction:dynamic:1:{};env_context:environment_configuration:dynamic:1:{};skill_context:skill_metadata:dynamic:1:{};tool_guide_context:capability_tool:dynamic:1:{}",
        base_prompt.len(),
        workspace_context.len(),
        instruction_context.len(),
        env_context.len(),
        skill_context.len(),
        tool_guide_context.len(),
    );

    assert_eq!(
        report.component_flags_value(),
        "workspace=1;instruction=1;env=1;skill=1;tool_guide=1;external_memory=0;task_list=0"
    );
    assert_eq!(report.component_lengths_value(), expected_lengths);
    assert_eq!(report.section_layout_value(), expected_layout);
}

#[test]
fn build_stable_prompt_frame_includes_base_and_stable_contexts() {
    let _lock = crate::runtime::tests::env_cache_lock_acquire();
    let mut config_with_env = bamboo_llm::Config::default();
    config_with_env.env_vars = vec![bamboo_config::EnvVarEntry {
        name: "TEST_PROMPT_ENVELOPE_TOKEN".to_string(),
        value: "hidden-value".to_string(),
        secret: true,
        value_encrypted: None,
        credential_ref: None,
        configured: true,
        description: Some("Prompt envelope token".to_string()),
    }];
    config_with_env.publish_env_vars();

    let workspace = std::env::temp_dir().join("bamboo-prompt-envelope-workspace");
    let system_prompt = format!(
        "Base system\n\n{}\nWorkspace path: {}\n{}\n{}",
        crate::runtime::context::WORKSPACE_CONTEXT_START_MARKER,
        workspace.display(),
        crate::runtime::context::WORKSPACE_CONTEXT_END_MARKER,
        crate::runtime::context::workspace_prompt_guidance(),
    );

    let config = crate::runtime::config::AgentLoopConfig {
        system_prompt: Some(system_prompt),
        ..Default::default()
    };
    let mut session = Session::new("session-stable-frame-1", "model");
    session.metadata.insert(
        "skill.context".to_string(),
        "## Skill\nUse the skill".to_string(),
    );

    let stable = build_stable_prompt_frame_with_sections(
        &session,
        &config,
        &[],
        &std::collections::BTreeSet::new(),
    )
    .0;

    assert!(stable.stable_instructions.contains("Base system"));
    assert!(stable.stable_instructions.contains("Workspace path:"));
    assert!(stable
        .stable_instructions
        .contains("environment variables were explicitly configured by the user inside Bodhi"));
    // Framework-invariant directives ride on top of even a fully custom override
    // base (`config.system_prompt`), so they are present regardless of the user's
    // base prompt.
    assert!(stable
        .stable_instructions
        .contains("Investigate before you conclude"));
    assert!(stable.stable_instructions.contains("Verify your own work"));
    assert!(stable.stable_prefix_messages.is_empty());
}

#[test]
fn build_stable_prompt_frame_strips_round_dynamic_prompt_blocks() {
    let _lock = crate::runtime::tests::env_cache_lock_acquire();
    let workspace = std::env::temp_dir().join("bamboo-prompt-envelope-workspace-dynamic");
    let system_prompt = format!(
        "Base system\n\n{}\nWorkspace path: {}\n{}\n{}\n\n<!-- BAMBOO_TASK_LIST_START -->\n## Current Task List: Agent Tasks\n[/] task-1: do the thing\n<!-- BAMBOO_TASK_LIST_END -->\n\n<!-- BAMBOO_EXTERNAL_MEMORY_START -->\nExternal memory snapshot\n<!-- BAMBOO_EXTERNAL_MEMORY_END -->\n\n<!-- BAMBOO_PLAN_MODE_START -->\nPLAN MODE ACTIVE\n<!-- BAMBOO_PLAN_MODE_END -->\n\n<!-- BAMBOO_PLAN_RUNTIME_CONTEXT_START -->\nPlan runtime snapshot\n<!-- BAMBOO_PLAN_RUNTIME_CONTEXT_END -->",
        crate::runtime::context::WORKSPACE_CONTEXT_START_MARKER,
        workspace.display(),
        crate::runtime::context::WORKSPACE_CONTEXT_END_MARKER,
        crate::runtime::context::workspace_prompt_guidance(),
    );

    let config = crate::runtime::config::AgentLoopConfig {
        system_prompt: Some(system_prompt),
        ..Default::default()
    };
    let mut session = Session::new("session-stable-frame-2", "model");
    session.metadata.insert(
        "skill.context".to_string(),
        "## Skill\nUse the skill".to_string(),
    );
    session.task_list = Some(TaskList {
        session_id: session.id.clone(),
        title: "Agent Tasks".to_string(),
        items: vec![TaskItem {
            id: "task-1".to_string(),
            description: "do the thing".to_string(),
            status: TaskItemStatus::InProgress,
            ..TaskItem::default()
        }],
        created_at: Utc::now(),
        updated_at: Utc::now(),
    });
    session.conversation_summary = Some(bamboo_agent_core::ConversationSummary::new(
        "Older work was compressed.",
        2,
        80,
    ));

    let stable = build_stable_prompt_frame_with_sections(
        &session,
        &config,
        &[],
        &std::collections::BTreeSet::new(),
    )
    .0;

    assert!(stable.stable_instructions.contains("Base system"));
    assert!(stable.stable_instructions.contains("Workspace path:"));
    assert!(!stable.stable_instructions.contains("Current Task List"));
    assert!(!stable
        .stable_instructions
        .contains("External memory snapshot"));
    assert!(!stable.stable_instructions.contains("PLAN MODE ACTIVE"));
    assert!(!stable.stable_instructions.contains("Plan runtime snapshot"));
}

#[test]
fn stable_prompt_frame_carries_instructions_and_prefix_messages() {
    // The stable frame is what feeds the IR's system field + StablePrefix run; the
    // Responses-input/chat projections are derived by the IR's lowering methods, not
    // a per-envelope converter.
    let stable =
        StablePromptFrame::new("Stable instructions", vec![Message::user("stable prefix")]);
    assert_eq!(stable.stable_instructions, "Stable instructions");
    assert_eq!(stable.stable_prefix_messages.len(), 1);
    assert_eq!(stable.stable_prefix_messages[0].content, "stable prefix");
}