badness 0.16.0

A language server, formatter, and linter for LaTeX
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
//! `badness.toml` configuration: schema, file loading, ancestor-walk
//! discovery, and the `BADNESS_CONFIG`/global user-config fallbacks.
//!
//! The CLI is the only consumer; the library API (`format_with_style`,
//! `check_paths_with_style`, the linter) continues to take a fully-resolved
//! [`FormatStyle`] / [`ExcludeFilter`](crate::file_discovery::ExcludeFilter) /
//! rule selection.
//!
//! Two deliberate design choices:
//!
//! - **Excludes use the Ruff model** (`exclude` + `extend-exclude`): a present
//!   `exclude` *replaces* the built-in
//!   [`DEFAULT_EXCLUDE`] set; `extend-exclude` is always *additive* on top.
//! - **`[format]` carries `wrap`, not `line-ending`** (the LaTeX paragraph
//!   line-break policy). `wrap` is optional: when omitted every file kind uses
//!   [`WrapMode::default`] (`reflow`). It stays an `Option` here so the LSP can
//!   tell "unset" from "set" when merging editor settings over project config,
//!   not because the fallback depends on the file.
//!
//! There is no `[index]` section (badness has no R-package index) and no
//! `[lint]`-driven network egress key.

use std::collections::BTreeMap;
use std::fmt;
use std::fs;
use std::path::{Path, PathBuf};

use serde::Deserialize;

use crate::declarations::{DeclarationError, Declarations, EnvironmentDecls, ResolvedDeclarations};
use crate::formatter::{FormatStyle, LineEnding, MathWrap, WrapMode};

pub const CONFIG_FILE_NAME: &str = "badness.toml";

/// Environment variable naming a config file to use when no project
/// `badness.toml` is discovered. Sits between project discovery and the
/// [global user config](global_config_path) in [`Config::resolve`]'s
/// precedence, and shadows the global file entirely when set.
pub const CONFIG_ENV_VAR: &str = "BADNESS_CONFIG";

const MIN_WIDTH: u32 = 1;
const MAX_WIDTH: u32 = 1000;

const DEFAULT_LINE_WIDTH: u32 = 80;
const DEFAULT_INDENT_WIDTH: u32 = 2;

/// Built-in exclude patterns applied when `exclude` is unset (a present `exclude`
/// replaces them). Kept deliberately small: badness only ever processes
/// `.tex`/`.sty`/`.cls`/`.dtx`/`.ins`/`.bib`, so most generated-file noise never
/// reaches discovery anyway. Tune as real-world LaTeX trees demand. `extend-exclude`
/// is always layered on top of whichever base is in effect.
pub const DEFAULT_EXCLUDE: &[&str] = &[".git/"];

#[derive(Debug, Clone, Default, PartialEq, Eq, Deserialize)]
#[serde(deny_unknown_fields, rename_all = "kebab-case")]
pub struct Config {
    /// Gitignore-style patterns to exclude from directory discovery, resolved
    /// relative to the directory containing this `badness.toml`. Applies to *both*
    /// `format` and `lint` (which share one file walk), so it is a top-level key,
    /// not nested under `[format]`.
    ///
    /// When present it **replaces** the built-in [`DEFAULT_EXCLUDE`] set (Ruff's
    /// `exclude` semantics); when absent the defaults apply. Either way,
    /// [`extend_exclude`](Self::extend_exclude) is added on top.
    #[serde(default)]
    pub exclude: Option<Vec<String>>,
    /// Gitignore-style patterns added *in addition to* whichever base set
    /// [`exclude`](Self::exclude) selects (Ruff's `extend-exclude` semantics). Use
    /// this to skip a few extra paths without restating the defaults.
    #[serde(default)]
    pub extend_exclude: Vec<String>,
    #[serde(default)]
    pub format: FormatConfig,
    #[serde(default)]
    pub lint: LintConfig,
    #[serde(default)]
    pub build: BuildConfig,
    /// The `[environments.<name>]` declaration map: what a user-defined
    /// environment behaves like, and which command spellings stand in for its
    /// delimiters (`\bea`/`\eea`).
    ///
    /// Different in kind from the sections above, because it reaches the
    /// *parser* rather than the formatter or the linter (`AGENTS.md` decision
    /// #12). It is deserialized straight into the `badness-parser` type instead
    /// of a local mirror: serde is a hard dependency of that crate, so unlike
    /// `FormatStyle` there is no feature to turn on, and a mirror would only add
    /// a second wire spelling that could drift from the one the dprint plugin
    /// reads.
    ///
    /// A top-level map rather than a nested section, and a keyed table rather
    /// than an `[[environments]]` array: the key *is* the environment, so
    /// entries merge per name once config layers or per-file overrides appear.
    #[serde(default)]
    pub environments: EnvironmentDecls,
}

impl Config {
    /// The final, ordered exclude pattern list: the base set (configured
    /// `exclude`, or [`DEFAULT_EXCLUDE`] when unset) followed by `extend-exclude`.
    /// `extra` (the CLI `--exclude` patterns) is appended last so command-line
    /// excludes always layer on top. The
    /// [`ExcludeFilter`](crate::file_discovery::ExcludeFilter) compiles this list.
    pub fn exclude_patterns(&self, extra: &[String]) -> Vec<String> {
        let mut patterns: Vec<String> = match &self.exclude {
            Some(patterns) => patterns.clone(),
            None => DEFAULT_EXCLUDE.iter().map(|p| p.to_string()).collect(),
        };
        patterns.extend(self.extend_exclude.iter().cloned());
        patterns.extend(extra.iter().cloned());
        patterns
    }

    /// The project's [`Declarations`], gathered from the top-level declaration
    /// maps. One value rather than a field per map, because everything
    /// downstream — resolution, the `ParseCtx` seed, the salsa input — takes the
    /// whole vocabulary at once, and because the other front ends (the dprint
    /// plugin, a future comment directive) produce a `Declarations` with no
    /// `Config` in sight.
    pub fn declarations(&self) -> Declarations {
        Declarations {
            environments: self.environments.clone(),
        }
    }

    /// The project's declarations, checked and projected into signature data —
    /// what the parser and the signature scope actually consume.
    ///
    /// Infallible because [`validate`](Self::validate) already resolved them
    /// when the file loaded, so the only way to reach a failure here is a
    /// `Config` built in memory and never validated. Falling back to *no*
    /// declarations beats panicking in a CLI path, and beats a `Result` every
    /// caller would have to launder a second time.
    pub fn resolved_declarations(&self) -> ResolvedDeclarations {
        self.declarations().resolve().unwrap_or_default()
    }
}

#[derive(Debug, Clone, PartialEq, Eq, Deserialize)]
#[serde(deny_unknown_fields, rename_all = "kebab-case")]
pub struct FormatConfig {
    #[serde(default = "default_line_width")]
    pub line_width: u32,
    #[serde(default = "default_indent_width")]
    pub indent_width: u32,
    /// The paragraph line-break policy. See [`WrapModeConfig`]. When omitted,
    /// every file kind uses [`WrapMode::default`] (`reflow`) — the formatter
    /// declines to reflow content that is unsafe to reflow on its own, in every
    /// mode, so the file's extension is not a layout input.
    #[serde(default)]
    pub wrap: Option<WrapModeConfig>,
    /// The display-math line-break policy. See [`MathWrapConfig`]. When omitted
    /// (or `auto`), it derives from the effective `wrap`: `preserve` keeps
    /// authored math breaks, every other wrap mode uses the amsmath-style
    /// breaker.
    #[serde(default)]
    pub math_wrap: Option<MathWrapConfig>,
    /// How formatted line breaks are spelled. See [`LineEndingConfig`]. When
    /// omitted (or `auto`), each file keeps the endings it was written with.
    #[serde(default)]
    pub line_ending: Option<LineEndingConfig>,
    /// Document language (a BCP-47-style code, e.g. `en`, `de`, `pt-BR`), used by
    /// the `sentence`/`semantic` wrap modes to pick the sentence-boundary
    /// abbreviation profile. Unknown or absent languages fall back to English.
    /// (Auto-detection from babel/polyglossia is not yet implemented.)
    #[serde(default)]
    pub lang: Option<String>,
    /// User-supplied no-break abbreviations for the `sentence`/`semantic` wrap
    /// modes, keyed by language code or the literal `default` bucket (applied to
    /// every document). An abbreviation here never ends a sentence, so a line is
    /// not broken after it. Merged on top of the built-in per-language lists.
    #[serde(default)]
    pub no_break_abbreviations: BTreeMap<String, Vec<String>>,
}

impl Default for FormatConfig {
    fn default() -> Self {
        Self {
            line_width: DEFAULT_LINE_WIDTH,
            indent_width: DEFAULT_INDENT_WIDTH,
            wrap: None,
            math_wrap: None,
            line_ending: None,
            lang: None,
            no_break_abbreviations: BTreeMap::new(),
        }
    }
}

/// The `wrap` key under `[format]`. A thin, serde-named mirror of [`WrapMode`]
/// (the formatter's own type), kept separate so the TOML spelling (`kebab-case`)
/// is a config concern, not baked into the formatter API — the same split as the
/// CLI's `WrapArg` in `cli.rs`.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize)]
#[serde(rename_all = "kebab-case")]
pub enum WrapModeConfig {
    /// Greedy fill: wrap words to the line width.
    Reflow,
    /// Prefer acceptable authored breaks, changing the smallest possible region
    /// (revision-stable wrapping).
    Stable,
    /// One sentence per line (width ignored).
    Sentence,
    /// Semantic line breaks (sembr.org): keep authored breaks and add breaks at
    /// sentence boundaries.
    Semantic,
    /// Leave authored line breaks untouched.
    Preserve,
}

impl From<WrapModeConfig> for WrapMode {
    fn from(value: WrapModeConfig) -> Self {
        match value {
            WrapModeConfig::Reflow => WrapMode::Reflow,
            WrapModeConfig::Stable => WrapMode::Stable,
            WrapModeConfig::Sentence => WrapMode::Sentence,
            WrapModeConfig::Semantic => WrapMode::Semantic,
            WrapModeConfig::Preserve => WrapMode::Preserve,
        }
    }
}

/// The `math-wrap` key under `[format]`. A serde-named mirror of [`MathWrap`],
/// the same split as [`WrapModeConfig`]. Scope: single-formula display math
/// (`\[…\]`, `$$…$$`, a non-grid `equation`); grid environments and inline
/// `$…$` are unaffected.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize)]
#[serde(rename_all = "kebab-case")]
pub enum MathWrapConfig {
    /// Derive from the effective `wrap`: `preserve` → `preserve`, else `break`.
    Auto,
    /// Keep authored line breaks inside the body (in-line spacing still
    /// normalized).
    Preserve,
    /// Never insert breaks; a long body overflows the line width.
    SingleLine,
    /// Break a too-long body before its top-level operators (amsmath style).
    Break,
}

impl From<MathWrapConfig> for MathWrap {
    fn from(value: MathWrapConfig) -> Self {
        match value {
            MathWrapConfig::Auto => MathWrap::Auto,
            MathWrapConfig::Preserve => MathWrap::Preserve,
            MathWrapConfig::SingleLine => MathWrap::SingleLine,
            MathWrapConfig::Break => MathWrap::Break,
        }
    }
}

/// The `line-ending` key under `[format]`. A serde-named mirror of
/// [`LineEnding`], the same split as [`WrapModeConfig`].
#[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize)]
#[serde(rename_all = "kebab-case")]
pub enum LineEndingConfig {
    /// Keep whatever the file was written with (CRLF if its first line break is
    /// one, LF otherwise).
    Auto,
    /// Always `\n`.
    Lf,
    /// Always `\r\n`.
    Crlf,
    /// The platform's convention: `\r\n` on Windows, `\n` elsewhere.
    Native,
}

impl From<LineEndingConfig> for LineEnding {
    fn from(value: LineEndingConfig) -> Self {
        match value {
            LineEndingConfig::Auto => LineEnding::Auto,
            LineEndingConfig::Lf => LineEnding::Lf,
            LineEndingConfig::Crlf => LineEnding::Crlf,
            LineEndingConfig::Native => LineEnding::Native,
        }
    }
}

impl FormatConfig {
    /// Validate values, returning a [`ConfigError::InvalidValue`] with the
    /// originating file path (when known) for diagnostics.
    pub fn validate(&self, path: Option<&Path>) -> Result<(), ConfigError> {
        validate_width("line-width", self.line_width, path)?;
        validate_width("indent-width", self.indent_width, path)?;
        Ok(())
    }
}

fn default_line_width() -> u32 {
    DEFAULT_LINE_WIDTH
}

fn default_indent_width() -> u32 {
    DEFAULT_INDENT_WIDTH
}

/// The `[build]` section: where the TeX compiler leaves its artifacts, and which
/// file it was run on. Read by the language server only (label-number hover and
/// document symbols pull resolved numbers from the `.aux`; forward search locates
/// the compiled PDF); never by the formatter or linter, which stay hermetic (see
/// `AGENTS.md`).
#[derive(Debug, Clone, PartialEq, Eq, Deserialize, Default)]
#[serde(deny_unknown_fields, rename_all = "kebab-case")]
pub struct BuildConfig {
    /// Directory holding the build's `.aux` files (latexmk's `-auxdir`/`-outdir`),
    /// resolved relative to the root document's directory when not absolute. When
    /// unset, each document's `.aux` is expected next to it (plain
    /// `latex`/`pdflatex` runs).
    #[serde(default)]
    pub aux_dir: Option<PathBuf>,
    /// Directory holding the build's PDF output (latexmk's `-outdir`), resolved
    /// relative to the root document's directory when not absolute. When unset,
    /// the PDF is expected next to the root document. Read by forward search.
    #[serde(default)]
    pub pdf_dir: Option<PathBuf>,
    /// The compiled PDF's file name, when the build does not name it after the
    /// root document (latexmk's `-jobname`). A bare file name resolved inside
    /// [`pdf_dir`](Self::pdf_dir), never a path; `.pdf` is appended when it
    /// carries no extension.
    #[serde(default)]
    pub pdf_filename: Option<String>,
    /// The project's root document — the file the compiler was run on — resolved
    /// relative to this `badness.toml`'s directory when not absolute.
    ///
    /// Overrides the include-graph scan for a `\documentclass`/`\begin{document}`
    /// member, which can only see files the server has already loaded: editing
    /// `chapters/ch1.tex` in a project rooted at `../main.tex` seeds only
    /// `chapters/`, so the scan finds no root at all.
    #[serde(default)]
    pub root: Option<PathBuf>,
}

impl BuildConfig {
    fn validate(&self, path: Option<&Path>) -> Result<(), ConfigError> {
        // A directory here would be silently ignored (the name is joined onto
        // `pdf-dir`), so reject it rather than resolve a PDF the user did not
        // mean.
        if let Some(name) = &self.pdf_filename
            && Path::new(name).components().count() != 1
        {
            return Err(ConfigError::InvalidValue {
                path: path.map(Path::to_path_buf),
                field: "pdf-filename",
                message: format!(
                    "must be a bare file name; use `pdf-dir` for the directory, got `{name}`"
                ),
            });
        }
        Ok(())
    }
}

#[derive(Debug, Clone, PartialEq, Eq, Deserialize, Default)]
#[serde(deny_unknown_fields, rename_all = "kebab-case")]
pub struct LintConfig {
    /// Explicit allowlist of rule IDs. When `Some`, only these rules run.
    /// Unknown rule IDs are reported at lint-time, not at config parse-time.
    #[serde(default)]
    pub select: Option<Vec<String>>,
    /// Rule IDs to disable. Applied on top of either `select` (subtracts) or the
    /// default rule set.
    #[serde(default)]
    pub ignore: Vec<String>,
}

impl From<&FormatConfig> for FormatStyle {
    /// Maps the two width knobs. `wrap` is left at [`WrapMode::default`] as a
    /// placeholder: the effective wrap is resolved *per file* by the caller (CLI
    /// flag → configured `wrap` → file-kind default), so this field is always
    /// overwritten before the style reaches the formatter.
    fn from(config: &FormatConfig) -> Self {
        FormatStyle {
            line_width: config.line_width as usize,
            indent_width: config.indent_width as usize,
            wrap: WrapMode::default(),
            // Unlike `wrap`, `math-wrap` has no per-file-kind default: the
            // configured value (or `Auto`) maps straight through, and `Auto`
            // resolves against the effective wrap inside the formatter.
            math_wrap: config.math_wrap.map_or(MathWrap::Auto, Into::into),
            // Also unlike `wrap`: the same for every file kind, and `Auto` is
            // resolved per document inside the formatter (from the endings the
            // source used).
            line_ending: config.line_ending.map_or(LineEnding::Auto, Into::into),
        }
    }
}

#[derive(Debug)]
pub enum ConfigError {
    Io {
        path: PathBuf,
        source: std::io::Error,
    },
    Parse {
        path: PathBuf,
        line: usize,
        column: usize,
        message: String,
    },
    InvalidValue {
        path: Option<PathBuf>,
        field: &'static str,
        message: String,
    },
    /// A declaration broke one of its rules. Separate from
    /// [`InvalidValue`](Self::InvalidValue) because the offending key is
    /// dynamic (`environments.myenv.like`, not a fixed field name) and the
    /// explanation is the parser crate's to give.
    Declaration {
        path: Option<PathBuf>,
        source: DeclarationError,
    },
}

impl fmt::Display for ConfigError {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            Self::Io { path, source } => {
                write!(f, "failed to read {}: {source}", path.display())
            }
            Self::Parse {
                path,
                line,
                column,
                message,
            } => write!(f, "{}:{line}:{column}: {message}", path.display()),
            Self::InvalidValue {
                path,
                field,
                message,
            } => match path {
                Some(path) => write!(f, "{}: invalid `{field}`: {message}", path.display()),
                None => write!(f, "invalid `{field}`: {message}"),
            },
            Self::Declaration { path, source } => match path {
                Some(path) => write!(f, "{}: {source}", path.display()),
                None => write!(f, "{source}"),
            },
        }
    }
}

impl std::error::Error for ConfigError {
    fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
        match self {
            Self::Io { source, .. } => Some(source),
            Self::Declaration { source, .. } => Some(source),
            _ => None,
        }
    }
}

impl Config {
    /// Parse a `badness.toml` from disk and validate it.
    pub fn load_from(path: &Path) -> Result<Self, ConfigError> {
        let text = fs::read_to_string(path).map_err(|source| ConfigError::Io {
            path: path.to_path_buf(),
            source,
        })?;
        Self::parse_str(&text, path)
    }

    fn parse_str(text: &str, path: &Path) -> Result<Self, ConfigError> {
        let config: Self = toml::from_str(text).map_err(|err| {
            let (line, column) = match err.span() {
                Some(span) => byte_offset_to_line_col(text, span.start),
                None => (1, 1),
            };
            ConfigError::Parse {
                path: path.to_path_buf(),
                line,
                column,
                message: err.message().to_string(),
            }
        })?;
        config.validate(Some(path))?;
        Ok(config)
    }

    fn validate(&self, path: Option<&Path>) -> Result<(), ConfigError> {
        self.format.validate(path)?;
        self.build.validate(path)?;
        // Resolution *is* the validation: a declaration that breaks a rule must
        // fail here, at load, rather than quietly parse and then do nothing to
        // the document. The resolved tier is rebuilt where it is consumed —
        // config loads once, so the second pass costs nothing worth caching.
        self.declarations()
            .resolve()
            .map(|_| ())
            .map_err(|source| ConfigError::Declaration {
                path: path.map(Path::to_path_buf),
                source,
            })
    }

    /// Walk `start` and its ancestors looking for a `badness.toml`. Stops at the
    /// first match or at a directory that contains a `.git` entry (repo root),
    /// whichever comes first. Returns `None` if neither is found before the
    /// filesystem root. The global user config is *not* consulted here; that
    /// fallback lives in [`resolve`](Self::resolve).
    pub fn discover(start: &Path) -> Result<Option<(PathBuf, Self)>, ConfigError> {
        let canonical = start.canonicalize().map_err(|source| ConfigError::Io {
            path: start.to_path_buf(),
            source,
        })?;
        for dir in canonical.ancestors() {
            let candidate = dir.join(CONFIG_FILE_NAME);
            if candidate.is_file() {
                let config = Self::load_from(&candidate)?;
                return Ok(Some((candidate, config)));
            }
            if dir.join(".git").exists() {
                return Ok(None);
            }
        }
        Ok(None)
    }

    /// Config resolution for the CLI and the language server. Precedence:
    /// an explicit `--config` path, then a discovered project `badness.toml`,
    /// then a file named by [`$BADNESS_CONFIG`](CONFIG_ENV_VAR), then the
    /// [global user config](global_config_path), then built-in defaults.
    /// Whole-file fallback, never a merge. `no_config` skips every file
    /// (project, env, and global). CLI flag overrides for the formatter/lint
    /// knobs are applied by the caller after this returns.
    pub fn resolve(
        explicit: Option<&Path>,
        no_config: bool,
        anchor: &Path,
    ) -> Result<(Self, ConfigSource), ConfigError> {
        Self::resolve_with_fallbacks(
            explicit,
            no_config,
            anchor,
            env_config_path().as_deref(),
            global_config_path().as_deref(),
        )
    }

    /// [`resolve`](Self::resolve) with the env and global fallback paths
    /// injected, so tests can exercise them without touching the real
    /// environment or home directory.
    fn resolve_with_fallbacks(
        explicit: Option<&Path>,
        no_config: bool,
        anchor: &Path,
        env: Option<&Path>,
        global: Option<&Path>,
    ) -> Result<(Self, ConfigSource), ConfigError> {
        if no_config {
            return Ok((Self::default(), ConfigSource::None));
        }
        if let Some(path) = explicit {
            let config = Self::load_from(path)?;
            return Ok((config, ConfigSource::Explicit(path.to_path_buf())));
        }
        if let Some((path, config)) = Self::discover(anchor)? {
            return Ok((config, ConfigSource::Discovered(path)));
        }
        // A set `$BADNESS_CONFIG` shadows the global config entirely, and a
        // missing or broken file is a hard error rather than a fall-through:
        // it is the config that would apply, and silently ignoring it would
        // hide a typo'd path indefinitely.
        if let Some(path) = env {
            let config = Self::load_from(path)?;
            return Ok((config, ConfigSource::Env(path.to_path_buf())));
        }
        // Same rationale: a broken global config is a hard error, not a
        // silent fall-through to built-in defaults.
        if let Some(path) = global {
            let config = Self::load_from(path)?;
            return Ok((config, ConfigSource::Global(path.to_path_buf())));
        }
        Ok((Self::default(), ConfigSource::None))
    }
}

/// Which configuration source [`Config::resolve`] loaded, carrying its path.
///
/// The distinction matters for relative exclude patterns: a project-local file
/// anchors them at its own directory, while the global config has no project
/// location and anchors at the caller's directory instead (see
/// [`exclude_root`](Self::exclude_root)).
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum ConfigSource {
    /// Loaded from an explicit `--config <path>`.
    Explicit(PathBuf),
    /// Discovered by the ancestor walk from the input's directory.
    Discovered(PathBuf),
    /// Named by the [`$BADNESS_CONFIG`](CONFIG_ENV_VAR) environment variable,
    /// used when no project config is discovered.
    Env(PathBuf),
    /// The global user config (e.g. `~/.config/badness/config.toml`), used when
    /// no project config is discovered and `$BADNESS_CONFIG` is unset.
    Global(PathBuf),
    /// No config file found; built-in defaults are in use.
    None,
}

impl ConfigSource {
    /// Path of the resolved config file, if any.
    pub fn path(&self) -> Option<&Path> {
        match self {
            Self::Explicit(p) | Self::Discovered(p) | Self::Env(p) | Self::Global(p) => Some(p),
            Self::None => None,
        }
    }

    /// The directory relative exclude patterns resolve against: the config
    /// file's own directory for a project-local file, or `anchor` (the CLI
    /// working directory, or the document's directory in the LSP) for the
    /// env and global configs and the no-config case, which have no project
    /// location.
    pub fn exclude_root<'a>(&'a self, anchor: &'a Path) -> &'a Path {
        match self {
            Self::Explicit(p) | Self::Discovered(p) => p.parent().unwrap_or(anchor),
            Self::Env(_) | Self::Global(_) | Self::None => anchor,
        }
    }
}

/// Path named by the [`$BADNESS_CONFIG`](CONFIG_ENV_VAR) environment variable,
/// or `None` when unset or empty (an empty value counts as unset, the usual
/// shell convention).
fn env_config_path() -> Option<PathBuf> {
    let value = std::env::var_os(CONFIG_ENV_VAR)?;
    if value.is_empty() {
        return None;
    }
    Some(PathBuf::from(value))
}

/// Path to the global user config, the fallback when no project `badness.toml`
/// is discovered: the first existing file among
/// `$XDG_CONFIG_HOME/badness/config.toml`, `~/.config/badness/config.toml`, and
/// `<platform config dir>/badness/config.toml` (Windows `%APPDATA%`, macOS
/// `~/Library/Application Support`). The `~/.config` candidate is checked on
/// every platform so the CLI-dotfile convention works on macOS and Windows too.
fn global_config_path() -> Option<PathBuf> {
    let mut candidates: Vec<PathBuf> = Vec::new();
    if let Some(xdg) = std::env::var_os("XDG_CONFIG_HOME")
        && !xdg.is_empty()
    {
        candidates.push(PathBuf::from(xdg));
    }
    if let Some(home) = dirs::home_dir() {
        candidates.push(home.join(".config"));
    }
    if let Some(config) = dirs::config_dir() {
        candidates.push(config);
    }
    candidates
        .into_iter()
        .map(|dir| dir.join("badness").join("config.toml"))
        .find(|path| path.is_file())
}

fn validate_width(field: &'static str, value: u32, path: Option<&Path>) -> Result<(), ConfigError> {
    if !(MIN_WIDTH..=MAX_WIDTH).contains(&value) {
        return Err(ConfigError::InvalidValue {
            path: path.map(Path::to_path_buf),
            field,
            message: format!("must be between {MIN_WIDTH} and {MAX_WIDTH}, got {value}"),
        });
    }
    Ok(())
}

fn byte_offset_to_line_col(source: &str, offset: usize) -> (usize, usize) {
    let mut line = 1usize;
    let mut column = 1usize;
    let clamped = offset.min(source.len());
    for ch in source[..clamped].chars() {
        if ch == '\n' {
            line += 1;
            column = 1;
        } else {
            column += 1;
        }
    }
    (line, column)
}

#[cfg(test)]
mod tests {
    use super::*;
    use tempfile::tempdir;

    fn parse(text: &str) -> Result<Config, ConfigError> {
        Config::parse_str(text, Path::new("badness.toml"))
    }

    #[test]
    fn default_config_matches_format_style_default_widths() {
        let config = Config::default();
        let style = FormatStyle::from(&config.format);
        assert_eq!(style.line_width, FormatStyle::default().line_width);
        assert_eq!(style.indent_width, FormatStyle::default().indent_width);
    }

    #[test]
    fn empty_file_yields_defaults() {
        let config = parse("").expect("parse");
        assert_eq!(config, Config::default());
    }

    #[test]
    fn parses_minimal_format_section() {
        let config = parse("[format]\nline-width = 100\n").expect("parse");
        let style = FormatStyle::from(&config.format);
        assert_eq!(style.line_width, 100);
        assert_eq!(style.indent_width, 2);
    }

    #[test]
    fn parses_indent_width() {
        let config = parse("[format]\nindent-width = 4\n").expect("parse");
        let style = FormatStyle::from(&config.format);
        assert_eq!(style.indent_width, 4);
        assert_eq!(style.line_width, 80);
    }

    #[test]
    fn wrap_defaults_to_none() {
        let config = parse("[format]\n").expect("parse");
        assert_eq!(config.format.wrap, None);
    }

    #[test]
    fn rejects_texmf_section() {
        // `[texmf]` moved to the LSP editor settings (it is machine configuration,
        // not project data); a leftover section is surfaced, not silently ignored.
        assert!(parse("[texmf]\nenabled = false\n").is_err());
    }

    #[test]
    fn build_aux_dir_defaults_to_none() {
        let config = parse("").expect("parse");
        assert_eq!(config.build, BuildConfig::default());
    }

    #[test]
    fn parses_build_section() {
        let config = parse(
            "[build]\naux-dir = \"out\"\npdf-dir = \"out\"\npdf-filename = \"thesis.pdf\"\nroot = \"main.tex\"\n",
        )
        .expect("parse");
        assert_eq!(config.build.aux_dir, Some(PathBuf::from("out")));
        assert_eq!(config.build.pdf_dir, Some(PathBuf::from("out")));
        assert_eq!(config.build.pdf_filename, Some("thesis.pdf".to_owned()));
        assert_eq!(config.build.root, Some(PathBuf::from("main.tex")));
    }

    #[test]
    fn rejects_a_pdf_filename_carrying_a_directory() {
        for name in ["out/thesis.pdf", ""] {
            let err = parse(&format!("[build]\npdf-filename = \"{name}\"\n"))
                .expect_err("a path is not a bare file name");
            assert!(
                matches!(err, ConfigError::InvalidValue { field, .. } if field == "pdf-filename"),
                "unexpected error for `{name}`: {err}"
            );
        }
    }

    #[test]
    fn rejects_an_unknown_build_key() {
        assert!(parse("[build]\npdf-directory = \"out\"\n").is_err());
    }

    #[test]
    fn parses_wrap_variants() {
        for (key, expected) in [
            ("reflow", WrapModeConfig::Reflow),
            ("stable", WrapModeConfig::Stable),
            ("sentence", WrapModeConfig::Sentence),
            ("semantic", WrapModeConfig::Semantic),
            ("preserve", WrapModeConfig::Preserve),
        ] {
            let text = format!("[format]\nwrap = \"{key}\"\n");
            let config = parse(&text).unwrap_or_else(|e| panic!("parse {key}: {e}"));
            assert_eq!(config.format.wrap, Some(expected), "for {key}");
            assert_eq!(WrapMode::from(expected), expected_wrap_mode(key));
        }
    }

    fn expected_wrap_mode(key: &str) -> WrapMode {
        match key {
            "reflow" => WrapMode::Reflow,
            "stable" => WrapMode::Stable,
            "sentence" => WrapMode::Sentence,
            "semantic" => WrapMode::Semantic,
            "preserve" => WrapMode::Preserve,
            other => panic!("unexpected {other}"),
        }
    }

    #[test]
    fn rejects_unknown_wrap() {
        let err = parse("[format]\nwrap = \"smart\"\n").expect_err("unknown variant");
        assert!(matches!(err, ConfigError::Parse { .. }));
    }

    #[test]
    fn parses_math_wrap_variants() {
        for (key, expected) in [
            ("auto", MathWrapConfig::Auto),
            ("preserve", MathWrapConfig::Preserve),
            ("single-line", MathWrapConfig::SingleLine),
            ("break", MathWrapConfig::Break),
        ] {
            let text = format!("[format]\nmath-wrap = \"{key}\"\n");
            let config = parse(&text).unwrap_or_else(|e| panic!("parse {key}: {e}"));
            assert_eq!(config.format.math_wrap, Some(expected), "for {key}");
        }
    }

    #[test]
    fn math_wrap_defaults_to_none_and_maps_to_auto() {
        let config = parse("[format]\n").expect("parse");
        assert_eq!(config.format.math_wrap, None);
        let style = FormatStyle::from(&config.format);
        assert_eq!(style.math_wrap, MathWrap::Auto);
    }

    #[test]
    fn rejects_unknown_math_wrap() {
        let err = parse("[format]\nmath-wrap = \"never\"\n").expect_err("unknown variant");
        assert!(matches!(err, ConfigError::Parse { .. }));
    }

    #[test]
    fn parses_line_ending_variants() {
        for (key, expected) in [
            ("auto", LineEndingConfig::Auto),
            ("lf", LineEndingConfig::Lf),
            ("crlf", LineEndingConfig::Crlf),
            ("native", LineEndingConfig::Native),
        ] {
            let text = format!("[format]\nline-ending = \"{key}\"\n");
            let config = parse(&text).unwrap_or_else(|e| panic!("parse {key}: {e}"));
            assert_eq!(config.format.line_ending, Some(expected), "for {key}");
            let style = FormatStyle::from(&config.format);
            assert_eq!(style.line_ending, LineEnding::from(expected), "for {key}");
        }
    }

    #[test]
    fn line_ending_defaults_to_none_and_maps_to_auto() {
        let config = parse("[format]\n").expect("parse");
        assert_eq!(config.format.line_ending, None);
        let style = FormatStyle::from(&config.format);
        assert_eq!(style.line_ending, LineEnding::Auto);
    }

    #[test]
    fn rejects_unknown_line_ending() {
        let err = parse("[format]\nline-ending = \"cr\"\n").expect_err("unknown variant");
        assert!(matches!(err, ConfigError::Parse { .. }));
    }

    #[test]
    fn stable_wrap_target_sits_below_line_width() {
        let config = parse("[format]\nline-width = 100\nwrap = \"stable\"\n").expect("parse");
        let style = FormatStyle::from(&config.format);
        assert_eq!(config.format.wrap, Some(WrapModeConfig::Stable));
        assert_eq!(style.stable_wrap_target(), 85);
    }

    #[test]
    fn rejects_unknown_top_level_table() {
        let err = parse("[formatt]\nline-width = 80\n").expect_err("unknown table");
        match err {
            ConfigError::Parse { message, .. } => {
                assert!(message.contains("formatt"), "got: {message}");
            }
            other => panic!("expected Parse error, got {other:?}"),
        }
    }

    #[test]
    fn rejects_unknown_field_in_format() {
        let err = parse("[format]\nline-widht = 80\n").expect_err("unknown field");
        match err {
            ConfigError::Parse { message, .. } => {
                assert!(message.contains("line-widht"), "got: {message}");
            }
            other => panic!("expected Parse error, got {other:?}"),
        }
    }

    #[test]
    fn rejects_snake_case_keys() {
        // We use kebab-case in the schema; snake_case must be rejected so users get
        // a clear error instead of silent fallthrough to defaults.
        let err = parse("[format]\nline_width = 80\n").expect_err("snake_case");
        assert!(matches!(err, ConfigError::Parse { .. }));
    }

    #[test]
    fn lang_defaults_to_none_and_abbreviations_empty() {
        let config = parse("[format]\n").expect("parse");
        assert_eq!(config.format.lang, None);
        assert!(config.format.no_break_abbreviations.is_empty());
    }

    #[test]
    fn parses_lang_and_no_break_abbreviations() {
        let text = "[format]\nwrap = \"sentence\"\nlang = \"de\"\n\n\
                    [format.no-break-abbreviations]\n\
                    default = [\"ibid.\"]\n\
                    de = [\"bzw.\", \"Abb.\"]\n";
        let config = parse(text).expect("parse");
        assert_eq!(config.format.lang.as_deref(), Some("de"));
        assert_eq!(
            config.format.no_break_abbreviations.get("default"),
            Some(&vec!["ibid.".to_string()])
        );
        assert_eq!(
            config.format.no_break_abbreviations.get("de"),
            Some(&vec!["bzw.".to_string(), "Abb.".to_string()])
        );
    }

    #[test]
    fn rejects_zero_line_width() {
        let err = parse("[format]\nline-width = 0\n").expect_err("zero width");
        match err {
            ConfigError::InvalidValue { field, message, .. } => {
                assert_eq!(field, "line-width");
                assert!(message.contains('0'));
            }
            other => panic!("expected InvalidValue, got {other:?}"),
        }
    }

    #[test]
    fn rejects_huge_line_width() {
        let err = parse("[format]\nline-width = 10000\n").expect_err("too big");
        assert!(matches!(
            err,
            ConfigError::InvalidValue {
                field: "line-width",
                ..
            }
        ));
    }

    #[test]
    fn rejects_negative_width_as_parse_error() {
        // u32 deserialization rejects negatives at the type layer.
        let err = parse("[format]\nline-width = -1\n").expect_err("negative");
        assert!(matches!(err, ConfigError::Parse { .. }));
    }

    #[test]
    fn exclude_defaults_to_none_and_uses_builtin_set() {
        let config = Config::default();
        assert_eq!(config.exclude, None);
        assert!(config.extend_exclude.is_empty());
        // With no `exclude`, the base list is the built-in defaults.
        assert_eq!(
            config.exclude_patterns(&[]),
            DEFAULT_EXCLUDE
                .iter()
                .map(|p| p.to_string())
                .collect::<Vec<_>>()
        );
    }

    #[test]
    fn present_exclude_replaces_defaults() {
        let config = parse("exclude = [\"vendor/\"]\n").expect("parse");
        assert_eq!(
            config.exclude.as_deref(),
            Some(&["vendor/".to_string()][..])
        );
        assert_eq!(config.exclude_patterns(&[]), vec!["vendor/".to_string()]);
    }

    #[test]
    fn empty_exclude_drops_defaults() {
        let config = parse("exclude = []\n").expect("parse");
        assert_eq!(config.exclude.as_deref(), Some(&[][..]));
        assert!(config.exclude_patterns(&[]).is_empty());
    }

    #[test]
    fn extend_exclude_is_additive_over_defaults() {
        let config = parse("extend-exclude = [\"build/\"]\n").expect("parse");
        let mut expected: Vec<String> = DEFAULT_EXCLUDE.iter().map(|p| p.to_string()).collect();
        expected.push("build/".to_string());
        assert_eq!(config.exclude_patterns(&[]), expected);
    }

    #[test]
    fn extend_exclude_layers_on_present_exclude_then_cli() {
        let config =
            parse("exclude = [\"vendor/\"]\nextend-exclude = [\"build/\"]\n").expect("parse");
        assert_eq!(
            config.exclude_patterns(&["tmp/".to_string()]),
            vec![
                "vendor/".to_string(),
                "build/".to_string(),
                "tmp/".to_string(),
            ]
        );
    }

    #[test]
    fn rejects_exclude_under_format() {
        // `exclude` is a top-level key (it governs both format and lint), never
        // nested under `[format]`.
        let err = parse("[format]\nexclude = [\"x\"]\n").expect_err("exclude is top-level");
        assert!(matches!(err, ConfigError::Parse { .. }));
    }

    #[test]
    fn accepts_empty_lint_section() {
        let config = parse("[lint]\n").expect("parse");
        assert_eq!(config.lint, LintConfig::default());
    }

    #[test]
    fn rejects_unknown_field_in_lint() {
        let err = parse("[lint]\nstyle = \"strict\"\n").expect_err("unknown field");
        assert!(matches!(err, ConfigError::Parse { .. }));
    }

    #[test]
    fn parses_lint_select() {
        let config = parse("[lint]\nselect = [\"duplicate-label\"]\n").expect("parse");
        assert_eq!(
            config.lint.select.as_deref(),
            Some(&["duplicate-label".to_string()][..])
        );
    }

    #[test]
    fn parses_lint_ignore() {
        let config = parse("[lint]\nignore = [\"deprecated-command\"]\n").expect("parse");
        assert_eq!(config.lint.ignore, vec!["deprecated-command".to_string()]);
    }

    #[test]
    fn parse_error_reports_file_path_and_line() {
        let path = Path::new("/tmp/oops.toml");
        let err = Config::parse_str("[format]\nbogus = 1\n", path).expect_err("bad field");
        let rendered = err.to_string();
        assert!(rendered.starts_with("/tmp/oops.toml:"));
    }

    #[test]
    fn load_from_missing_file_returns_io_error() {
        let dir = tempdir().unwrap();
        let path = dir.path().join("nope.toml");
        let err = Config::load_from(&path).expect_err("missing file");
        assert!(matches!(err, ConfigError::Io { .. }));
    }

    #[test]
    fn discover_finds_config_in_parent() {
        let dir = tempdir().unwrap();
        fs::write(
            dir.path().join(CONFIG_FILE_NAME),
            "[format]\nline-width = 70\n",
        )
        .unwrap();
        let nested = dir.path().join("a").join("b");
        fs::create_dir_all(&nested).unwrap();

        let (path, config) = Config::discover(&nested).expect("discover").expect("found");
        assert_eq!(
            path,
            dir.path().canonicalize().unwrap().join(CONFIG_FILE_NAME)
        );
        assert_eq!(config.format.line_width, 70);
    }

    #[test]
    fn discover_stops_at_git_boundary() {
        let dir = tempdir().unwrap();
        // Ancestor sets a config we must NOT pick up.
        fs::write(
            dir.path().join(CONFIG_FILE_NAME),
            "[format]\nline-width = 70\n",
        )
        .unwrap();
        let repo = dir.path().join("repo");
        fs::create_dir_all(repo.join(".git")).unwrap();
        let nested = repo.join("src");
        fs::create_dir_all(&nested).unwrap();

        let found = Config::discover(&nested).expect("discover");
        assert!(
            found.is_none(),
            "should stop at .git boundary, got {found:?}"
        );
    }

    #[test]
    fn discover_prefers_config_at_repo_root() {
        let dir = tempdir().unwrap();
        let repo = dir.path().join("repo");
        fs::create_dir_all(repo.join(".git")).unwrap();
        fs::write(repo.join(CONFIG_FILE_NAME), "[format]\nline-width = 70\n").unwrap();
        let nested = repo.join("src");
        fs::create_dir_all(&nested).unwrap();

        let (path, config) = Config::discover(&nested).expect("discover").expect("found");
        assert_eq!(path, repo.canonicalize().unwrap().join(CONFIG_FILE_NAME));
        assert_eq!(config.format.line_width, 70);
    }

    #[test]
    fn resolve_no_config_returns_defaults() {
        let dir = tempdir().unwrap();
        fs::write(
            dir.path().join(CONFIG_FILE_NAME),
            "[format]\nline-width = 20\n",
        )
        .unwrap();
        let (config, source) = Config::resolve(None, true, dir.path()).expect("resolve");
        assert_eq!(config, Config::default());
        assert_eq!(source, ConfigSource::None);
    }

    #[test]
    fn resolve_explicit_overrides_discovery() {
        let dir = tempdir().unwrap();
        fs::write(
            dir.path().join(CONFIG_FILE_NAME),
            "[format]\nline-width = 20\n",
        )
        .unwrap();
        let explicit = dir.path().join("custom.toml");
        fs::write(&explicit, "[format]\nline-width = 40\n").unwrap();

        let (config, source) =
            Config::resolve(Some(&explicit), false, dir.path()).expect("resolve");
        assert_eq!(config.format.line_width, 40);
        assert_eq!(source, ConfigSource::Explicit(explicit.clone()));
    }

    #[test]
    fn resolve_discovers_when_no_explicit_and_not_disabled() {
        let dir = tempdir().unwrap();
        fs::write(
            dir.path().join(CONFIG_FILE_NAME),
            "[format]\nline-width = 50\n",
        )
        .unwrap();
        let (config, source) = Config::resolve(None, false, dir.path()).expect("resolve");
        assert_eq!(config.format.line_width, 50);
        assert!(matches!(source, ConfigSource::Discovered(_)));
    }

    /// A project directory bounded by a `.git` entry, so the discovery walk in
    /// the global-fallback tests never escapes the tempdir.
    fn bounded_project() -> (tempfile::TempDir, PathBuf) {
        let dir = tempdir().unwrap();
        let repo = dir.path().join("repo");
        fs::create_dir_all(repo.join(".git")).unwrap();
        (dir, repo)
    }

    fn write_global(dir: &Path) -> PathBuf {
        let global = dir.join("config-home").join("badness").join("config.toml");
        fs::create_dir_all(global.parent().unwrap()).unwrap();
        fs::write(&global, "[format]\nline-width = 66\n").unwrap();
        global
    }

    #[test]
    fn resolve_falls_back_to_global_config() {
        let (dir, repo) = bounded_project();
        let global = write_global(dir.path());

        let (config, source) =
            Config::resolve_with_fallbacks(None, false, &repo, None, Some(&global))
                .expect("resolve");
        assert_eq!(config.format.line_width, 66);
        assert_eq!(source, ConfigSource::Global(global.clone()));
        // Global config has no project location: excludes anchor at the caller.
        assert_eq!(source.exclude_root(&repo), repo.as_path());
    }

    #[test]
    fn discovered_config_beats_global() {
        let (dir, repo) = bounded_project();
        let global = write_global(dir.path());
        fs::write(repo.join(CONFIG_FILE_NAME), "[format]\nline-width = 50\n").unwrap();

        let (config, source) =
            Config::resolve_with_fallbacks(None, false, &repo, None, Some(&global))
                .expect("resolve");
        assert_eq!(config.format.line_width, 50);
        assert!(matches!(source, ConfigSource::Discovered(_)));
    }

    #[test]
    fn no_config_skips_global() {
        let (dir, repo) = bounded_project();
        let global = write_global(dir.path());

        let (config, source) =
            Config::resolve_with_fallbacks(None, true, &repo, None, Some(&global))
                .expect("resolve");
        assert_eq!(config, Config::default());
        assert_eq!(source, ConfigSource::None);
    }

    #[test]
    fn broken_global_config_is_an_error() {
        let (dir, repo) = bounded_project();
        let global = dir
            .path()
            .join("config-home")
            .join("badness")
            .join("config.toml");
        fs::create_dir_all(global.parent().unwrap()).unwrap();
        fs::write(&global, "[format]\nline-widht = 80\n").unwrap();

        let err = Config::resolve_with_fallbacks(None, false, &repo, None, Some(&global))
            .expect_err("typo'd global config must not be silently ignored");
        assert!(matches!(err, ConfigError::Parse { .. }));
    }

    fn write_env_config(dir: &Path) -> PathBuf {
        let env = dir.join("synced").join("badness.toml");
        fs::create_dir_all(env.parent().unwrap()).unwrap();
        fs::write(&env, "[format]\nline-width = 44\n").unwrap();
        env
    }

    #[test]
    fn env_config_beats_global() {
        let (dir, repo) = bounded_project();
        let env = write_env_config(dir.path());
        let global = write_global(dir.path());

        let (config, source) =
            Config::resolve_with_fallbacks(None, false, &repo, Some(&env), Some(&global))
                .expect("resolve");
        assert_eq!(config.format.line_width, 44);
        assert_eq!(source, ConfigSource::Env(env.clone()));
        // Env config has no project location: excludes anchor at the caller.
        assert_eq!(source.exclude_root(&repo), repo.as_path());
    }

    #[test]
    fn discovered_config_beats_env() {
        let (dir, repo) = bounded_project();
        let env = write_env_config(dir.path());
        fs::write(repo.join(CONFIG_FILE_NAME), "[format]\nline-width = 50\n").unwrap();

        let (config, source) =
            Config::resolve_with_fallbacks(None, false, &repo, Some(&env), None).expect("resolve");
        assert_eq!(config.format.line_width, 50);
        assert!(matches!(source, ConfigSource::Discovered(_)));
    }

    #[test]
    fn explicit_config_beats_env() {
        let (dir, repo) = bounded_project();
        let env = write_env_config(dir.path());
        let explicit = dir.path().join("custom.toml");
        fs::write(&explicit, "[format]\nline-width = 40\n").unwrap();

        let (config, source) =
            Config::resolve_with_fallbacks(Some(&explicit), false, &repo, Some(&env), None)
                .expect("resolve");
        assert_eq!(config.format.line_width, 40);
        assert_eq!(source, ConfigSource::Explicit(explicit.clone()));
    }

    #[test]
    fn no_config_skips_env() {
        let (dir, repo) = bounded_project();
        let env = write_env_config(dir.path());

        let (config, source) =
            Config::resolve_with_fallbacks(None, true, &repo, Some(&env), None).expect("resolve");
        assert_eq!(config, Config::default());
        assert_eq!(source, ConfigSource::None);
    }

    #[test]
    fn missing_env_config_is_an_error() {
        let (dir, repo) = bounded_project();
        let env = dir.path().join("nowhere").join("badness.toml");
        let global = write_global(dir.path());

        // A set but dangling `$BADNESS_CONFIG` must not silently fall through
        // to the global config or the defaults.
        let err = Config::resolve_with_fallbacks(None, false, &repo, Some(&env), Some(&global))
            .expect_err("typo'd $BADNESS_CONFIG path must not be silently ignored");
        assert!(matches!(err, ConfigError::Io { .. }));
    }

    #[test]
    fn broken_env_config_is_an_error() {
        let (dir, repo) = bounded_project();
        let env = dir.path().join("synced").join("badness.toml");
        fs::create_dir_all(env.parent().unwrap()).unwrap();
        fs::write(&env, "[format]\nline-widht = 80\n").unwrap();

        let err = Config::resolve_with_fallbacks(None, false, &repo, Some(&env), None)
            .expect_err("broken $BADNESS_CONFIG file must not be silently ignored");
        assert!(matches!(err, ConfigError::Parse { .. }));
    }

    #[test]
    fn exclude_root_for_project_config_is_its_directory() {
        let source = ConfigSource::Discovered(PathBuf::from("/proj/badness.toml"));
        assert_eq!(
            source.exclude_root(Path::new("/elsewhere")),
            Path::new("/proj")
        );
        let explicit = ConfigSource::Explicit(PathBuf::from("/proj/custom.toml"));
        assert_eq!(
            explicit.exclude_root(Path::new("/elsewhere")),
            Path::new("/proj")
        );
        assert_eq!(
            ConfigSource::None.exclude_root(Path::new("/elsewhere")),
            Path::new("/elsewhere")
        );
    }

    // --- declarations (`AGENTS.md` decision #12)
    //
    // The type and its wire spellings are tested in `badness_parser::declarations`;
    // what these pin is the *TOML* surface, which that crate cannot see (`toml` is
    // a dependency of this crate only).

    #[test]
    fn a_project_declares_no_environments_by_default() {
        assert!(parse("").expect("parse").declarations().is_empty());
    }

    #[test]
    fn parses_an_environment_declared_by_behavior() {
        let config = parse("[environments.myenv]\nlike = \"align\"\n").expect("parse");
        let decls = config.declarations();
        assert_eq!(decls.environments["myenv"].like.as_deref(), Some("align"));
    }

    /// TOML literal strings are what spares users `"\\bea"`, and the leading
    /// backslash normalizes away either way.
    #[test]
    fn parses_delimiter_spellings_in_either_toml_string_form() {
        let config = parse("[environments.eqnarray]\nbegin = ['\\bea']\nend = [\"\\\\eea\"]\n")
            .expect("parse");
        let entry = &config.declarations().environments["eqnarray"];
        assert_eq!(entry.begin[0].as_str(), "bea");
        assert_eq!(entry.end[0].as_str(), "eea");
    }

    /// The `\startmyenv … \endmyenv` shape from issue #109: behavior and
    /// spellings in one entry, keyed by the environment it is.
    #[test]
    fn parses_an_environment_declared_by_behavior_and_spellings() {
        let config = parse(
            "[environments.mytheorem]\nlike = \"theorem\"\nbegin = ['\\startmyenv']\nend = ['\\endmyenv']\n",
        )
        .expect("parse");
        let entry = &config.declarations().environments["mytheorem"];
        assert_eq!(entry.like.as_deref(), Some("theorem"));
        assert!(entry.has_delimiters());
    }

    #[test]
    fn a_misspelled_declaration_key_is_rejected() {
        let err = parse("[environments.myenv]\nliek = \"align\"\n")
            .expect_err("unknown key must not be silently ignored");
        assert!(matches!(err, ConfigError::Parse { .. }), "{err:?}");
        assert!(err.to_string().contains("liek"), "{err}");
    }

    /// An environment may legitimately be named after a config section, so the
    /// map must be its own table rather than sharing a key space with scalars.
    #[test]
    fn an_environment_may_be_named_like_a_config_section() {
        let config = parse("[environments.format]\nlike = \"center\"\n").expect("parse");
        assert!(config.declarations().environments.contains_key("format"));
        assert_eq!(config.format, FormatConfig::default());
    }

    /// The rules themselves are tested in `badness_parser::declarations`; what
    /// this pins is that loading a config *runs* them, so a broken declaration
    /// is reported at load rather than silently doing nothing to the document.
    #[test]
    fn a_broken_declaration_fails_at_load() {
        let err = parse("[environments.myenv]\nlike = \"algin\"\n")
            .expect_err("an unknown `like` target must not load");
        assert!(matches!(err, ConfigError::Declaration { .. }), "{err:?}");
        let rendered = err.to_string();
        assert!(rendered.contains("badness.toml"), "{rendered}");
        assert!(rendered.contains("environments.myenv.like"), "{rendered}");
        assert!(rendered.contains("algin"), "{rendered}");
    }

    #[test]
    fn a_declared_opener_without_a_closer_fails_at_load() {
        let err = parse("[environments.eqnarray]\nbegin = ['\\bea']\n")
            .expect_err("an opener with no closer must not load");
        assert!(matches!(err, ConfigError::Declaration { .. }), "{err:?}");
    }
}